amicus 4.6.3 → 4.7.1

package/src/mcp-server.js

@@ -423,6 +423,10 @@ const handlers = {
     // gate / template pre-render) for parity between the two paths.
     if (packForward.maxCost !== undefined) { args.push('--max-cost', String(packForward.maxCost)); }
     if (packForward.template !== undefined) { args.push('--template', packForward.template); }
+    // v4.7 F8 (D13, errata E-PR3-2): forwarded for the spawn-fallback path
+    // below — DEAD on the shared-server branch (args is never read there);
+    // that branch stamps input.tag directly into its own metadata write instead.
+    if (input.tag) { args.push('--tag', input.tag); }
     args.push('--cwd', cwd);
 
     if (sharedServer.enabled && input.noUi) {
@@ -435,28 +439,30 @@ const handlers = {
         // a fall-through to the spawn-fallback catch must never leak one.
         const inProcessNotices = [...fwd.notices];
         const renderedPrompt = fwd.renderedPrompt !== undefined ? fwd.renderedPrompt : input.prompt;
-        if (packForward.maxCost !== undefined) {
-          // fwd.maxCost is already validated (I2); the ceiling gate itself
-          // stays here (needs resolvedModel/pricing, unavailable to pack-forward.js).
-          const { lookupPricing } = require('./utils/pricing');
-          const { checkBudget, formatBudgetError } = require('./sidecar/budget');
-          const { loadConfig } = require('./utils/config');
-          const cfg = loadConfig() || {};
-          const soloLeg = { modelInput: input.model || resolvedModel, model: resolvedModel, pricing: lookupPricing(resolvedModel) };
-          const budget = checkBudget([soloLeg], {
-            maxCostPerMtok: cfg.maxCostPerMtok, maxCost: fwd.maxCost,
-            promptChars: (renderedPrompt && renderedPrompt.length) || 0,
-          });
-          if (!budget.ok) {
-            const { buildErrorDoc, ERROR_CODES } = require('./utils/error-doc');
-            return {
-              isError: true,
-              content: [{ type: 'text', text: JSON.stringify(buildErrorDoc({
-                code: ERROR_CODES.BUDGET_EXCEEDED, message: 'Error: budget gate refused the run',
-                hint: formatBudgetError(budget),
-              })) }],
-            };
-          }
+        // v4.7 PR6: the gate used to hang off `packForward.maxCost !== undefined`,
+        // so a no-pack MCP start skipped it while the CLI (cli-handlers-run.js:90)
+        // gated unconditionally with a cfg.maxCost fallback. Same guard, both doors.
+        // fwd.maxCost is already validated (I2); the ceiling gate itself
+        // stays here (needs resolvedModel/pricing, unavailable to pack-forward.js).
+        const { lookupPricing } = require('./utils/pricing');
+        const { checkBudget, formatBudgetError } = require('./sidecar/budget');
+        const { loadConfig } = require('./utils/config');
+        const cfg = loadConfig() || {};
+        const soloLeg = { modelInput: input.model || resolvedModel, model: resolvedModel, pricing: lookupPricing(resolvedModel) };
+        const budget = checkBudget([soloLeg], {
+          maxCostPerMtok: cfg.maxCostPerMtok,
+          maxCost: fwd.maxCost !== undefined ? fwd.maxCost : cfg.maxCost,
+          promptChars: (renderedPrompt && renderedPrompt.length) || 0,
+        });
+        if (!budget.ok) {
+          const { buildErrorDoc, ERROR_CODES } = require('./utils/error-doc');
+          return {
+            isError: true,
+            content: [{ type: 'text', text: JSON.stringify(buildErrorDoc({
+              code: ERROR_CODES.BUDGET_EXCEEDED, message: 'Error: budget gate refused the run',
+              hint: formatBudgetError(budget, { kind: 'mcp' }),
+            })) }],
+          };
         }
 
         const { server, client } = await sharedServer.ensureServer();
@@ -500,6 +506,10 @@ const handlers = {
           briefing: renderedPrompt,
           // v4.5 Task 15: additive-only — absent (not null) without a pack.
           ...(packRecord ? { pack: packRecord } : {}),
+          // v4.7 F8 (D13, errata E-PR3-2): THE critical site — this shared-server
+          // branch never spawns a CLI child, so the --tag argv forward above
+          // (dead here) can never reach it. Same additive-only idiom as pack.
+          ...(input.tag ? { tag: input.tag } : {}),
         }, null, 2), { mode: 0o600 });
 
         // Build context from parent conversation (unless --no-context)
@@ -693,6 +703,19 @@ const handlers = {
     // resolved the route in-process above, so surface its notice here.
     const spawnContent = [{ type: 'text', text: body }];
     if (routeResult.notice) { spawnContent.push({ type: 'text', text: routeResult.notice }); }
+    // W1-M6/M7: NOT dead code. This is the same idiom applyPackToMcpInput's
+    // orphan-knob notices always use — amicus_fanout genuinely reaches it today
+    // (FANOUT_PACK_PARAM_MAP has no contextTurns/contextMaxTokens destination;
+    // the fanout handler's own push into waveContent below is covered by
+    // mcp-pack-params.test.js's "notice wording (decision 1b)" test — named,
+    // not line-numbered, because a line citation goes stale the moment anything
+    // is inserted above it, including by its own commit). On THIS solo surface it is
+    // unreachable only while KIND_OPTIONS.solo stays fully covered by
+    // SOLO_PACK_PARAM_MAP destinations + pack-resolve.js's FORWARDABLE_ARG_KEYS
+    // — the invariant tests/pack/mcp-pack-params.test.js guards (the
+    // KIND_OPTIONS.solo round-trip test, mutation-proven against a synthetic
+    // orphaned knob). If that invariant ever breaks, this loop is what turns a
+    // silent drop into a visible notice — never delete it as unreachable.
     for (const n of packNotices) { spawnContent.push({ type: 'text', text: n }); }
     if (isHeadless) {
       spawnContent.push({ type: 'text', text: HEADLESS_START_REMINDER });
@@ -984,37 +1007,11 @@ const handlers = {
     const root = path.join(cwd, '.claude', SESSIONS_DIR);
     if (!fs.existsSync(root)) { return textResult('No amicus sessions found.'); }
 
+    // v4.7 F8 (D14): one enumeration behind both the CLI and MCP list surfaces
+    // — enumerateSessions is the shared core (src/sidecar/read.js).
+    const { enumerateSessions, searchSessions } = require('./sidecar/read');
     const byId = new Map();
-    for (const d of fs.readdirSync(root)) {
-      if (!/^[a-zA-Z0-9_-]{1,64}$/.test(d)) { continue; }
-      if (byId.has(d)) { continue; }
-      const metaPath = path.join(root, d, 'metadata.json');
-      if (!fs.existsSync(metaPath)) { continue; }
-      try {
-        const meta = JSON.parse(fs.readFileSync(metaPath, 'utf-8'));
-        const entry = {
-          id: d, model: meta.model, status: meta.status, agent: meta.agent,
-          briefing: sanitizePreview(String(meta.briefing || ''), 80),
-          createdAt: meta.createdAt,
-          mode: meta.mode
-            || (meta.headless === undefined ? undefined : (meta.headless ? 'headless' : 'interactive')),
-        };
-        // Live-progress enrichment for RUNNING sessions only — readProgress
-        // parses conversation.jsonl, so terminal rows stay cheap.
-        if (meta.status === 'running') {
-          try {
-            const p = readProgress(path.join(root, d));
-            entry.phase = deriveStage(meta.status, p.stage);
-            entry.messageCount = p.messages;
-            entry.lastActivityAt = p.lastActivityAt;
-            entry.latestPreview = p.latestPreview;
-          } catch { /* progress optional */ }
-        }
-        byId.set(d, entry);
-      } catch {
-        // Skip unreadable metadata
-      }
-    }
+    for (const row of enumerateSessions(cwd, {})) { byId.set(row.id, row); }
 
     // v4.0 §8: council runs are pointer files in the same sessions root — merge
     // them as first-class rows (type 'council-run') before sorting/filtering.
@@ -1025,8 +1022,34 @@ const handlers = {
     if (input.status && input.status !== 'all') {
       sessions = sessions.filter(s => s.status === input.status);
     }
+    // v4.7 F8 (D15, errata E-PR3-5): search runs on RAW briefing material —
+    // BEFORE the sanitize/enrich pass below truncates row.briefing to an
+    // 80-char preview. Council rows' material is read straight off disk
+    // inside searchSessions; the `briefing` merged onto them here is already
+    // listCouncilRuns' own sanitized preview and is never used for matching.
+    if (input.search) { sessions = searchSessions(sessions, input.search, { project: cwd }); }
     if (sessions.length === 0) { return textResult('No amicus sessions found.'); }
 
+    // Rows are re-grafted here with the EXACT decorations this handler always
+    // applied: sanitized (not raw) briefing, and running-only live-progress
+    // enrichment. Council rows already carry a sanitized briefing from
+    // listCouncilRuns, so they're left alone.
+    for (const row of sessions) {
+      if (row.type === 'council-run') { continue; }
+      row.briefing = sanitizePreview(String(row.briefing || ''), 80);
+      // Live-progress enrichment for RUNNING sessions only — readProgress
+      // parses conversation.jsonl, so terminal rows stay cheap.
+      if (row.status === 'running') {
+        try {
+          const p = readProgress(path.join(root, row.id));
+          row.phase = deriveStage(row.status, p.stage);
+          row.messageCount = p.messages;
+          row.lastActivityAt = p.lastActivityAt;
+          row.latestPreview = p.latestPreview;
+        } catch { /* progress optional */ }
+      }
+    }
+
     return textResult(JSON.stringify(sessions, null, 2));
   },
 
@@ -1237,6 +1260,17 @@ const handlers = {
     if (fwd.error) { return textResult(fwd.error.message + (fwd.error.hint ? `\n${fwd.error.hint}` : ''), true); }
     packNotices.push(...fwd.notices);
 
+    // ⚠️ v4.7 PR7: the zod schema closes the TYPED door; a pack can push the same values through
+    // the other one (validatePack checks option KEY names, never value types). Both entrances
+    // reach the same spawn, so the check lives here, after pack merge, before any wave dir.
+    if (typeof input.prompt !== 'string' || !input.prompt.trim()) {
+      return textResult('Error: prompt must not be empty.', true);
+    }
+    if (input.timeout !== undefined
+        && (typeof input.timeout !== 'number' || !Number.isFinite(input.timeout) || input.timeout <= 0)) {
+      return textResult('Error: timeout must be a positive number of minutes.', true);
+    }
+
     // Resolve a single effective models list (council OR models), validated
     // BEFORE any wave dir / metadata is written so a bad request never strands
     // a pid-less 'running' orphan wave.
@@ -1270,15 +1304,34 @@ const handlers = {
     const waveDir = getSessionDir(cwd, waveId);
 
     let briefingPath;
+    let childPromptPath;
     try {
       fs.mkdirSync(waveDir, { recursive: true, mode: 0o700 });
       briefingPath = path.join(waveDir, 'briefing.md');
+      // ⚠️ W1-M4 (v4.7 PR7): this default is LOAD-BEARING. Omit it and every non-template wave
+      // spawns with `--prompt-file undefined`.
+      childPromptPath = briefingPath;
       // The prompt goes via file: the spawned command line must NOT carry it,
       // or it re-hits the ~32KB Windows argument cap (F4 spec §4.2).
-      fs.writeFileSync(briefingPath, input.prompt, { mode: 0o600 });
+      // ⚠️ W1-M4: briefing.md is the SEARCH CORPUS — src/sidecar/list-search.js reads it verbatim
+      // — and a child that aborts before fanout.js:145 never re-renders it, leaving the wave
+      // permanently unfindable by the text the user actually sees. Write the RENDERED text here
+      // (parity with the amicus_start path at :441/:506) and hand the child the raw input in a
+      // sibling file, so its own later re-render still produces byte-identical output and
+      // promptMeta.template provenance survives.
+      const briefingText = fwd.renderedPrompt !== undefined ? fwd.renderedPrompt : input.prompt;
+      fs.writeFileSync(briefingPath, briefingText, { mode: 0o600 });
+      if (fwd.renderedPrompt !== undefined) {
+        childPromptPath = path.join(waveDir, 'briefing-input.md');
+        fs.writeFileSync(childPromptPath, input.prompt, { mode: 0o600 });
+      }
+      // ⚠️ W1-M4 rider (owner-approved fold): the `briefing` key below must stay — without it the
+      // `list` BRIEFING column renders EMPTY for an aborted MCP wave, since only fanout.js:147
+      // ever wrote a briefing key and an aborted child never reaches it.
       writeFileAtomic(path.join(waveDir, 'metadata.json'), JSON.stringify({
         taskId: waveId, type: 'wave', status: 'running', legs: legIds,
         models: effectiveModels, headless: true, createdAt: new Date().toISOString(),
+        briefing: briefingText.slice(0, 200),
         // v4.5 Task 15: additive-only — absent (not null) without a pack.
         ...(packRecord ? { pack: packRecord } : {}),
       }, null, 2), { mode: 0o600 });
@@ -1292,7 +1345,7 @@ const handlers = {
 
     const args = [
       'fanout', '--models', effectiveModels.join(','),
-      '--prompt-file', briefingPath, '--wave-id', waveId,
+      '--prompt-file', childPromptPath, '--wave-id', waveId,
       '--json', '--client', detectClient(mcpServer), '--cwd', cwd,
     ];
     const agent = input.agent || 'Build';
@@ -1317,6 +1370,12 @@ const handlers = {
     // itself is never forwarded, only the two knobs it resolved to).
     if (packForward.maxCost !== undefined) { args.push('--max-cost', String(packForward.maxCost)); }
     if (packForward.template !== undefined) { args.push('--template', packForward.template); }
+    // v4.7 F8 (D13, errata E-PR3-2): argv-only forward — unlike pack, this does
+    // NOT pre-seed the wave metadata (no single-resolution rule forces it here);
+    // the spawned CLI child's own cli-handlers-fanout.js stores the tag on wave
+    // metadata itself (Task 3), so fanout.js's metaTag inherit arm has no MCP
+    // producer and is defense-in-depth only.
+    if (input.tag) { args.push('--tag', input.tag); }
 
     let child;
     try { child = spawnSidecarProcess(args, waveDir); } catch (err) {
@@ -1506,4 +1565,5 @@ async function startMcpServer() {
 
 module.exports = {
   handlers, startMcpServer, getProjectDir, resolveProjectDir, getClientRoot,
+  FANOUT_PACK_PARAM_MAP, SOLO_PACK_PARAM_MAP,
 };

package/src/mcp-tools.js

@@ -121,6 +121,7 @@ function getTools() {
           'left: flush against the left edge. center: centered.'
         ),
       pack: z.string().optional().describe('Policy pack name or path — bench/chair/options/template defaults for this run; explicit params override pack values (recorded either way).'),
+      tag: z.string().regex(/^[a-zA-Z0-9_-]{1,64}$/, '1-64 chars, letters/digits/_/- only').optional().describe('Label this session for list/search/spend grouping'),
       project: z.string().optional().describe(
         'Optional project directory path. Auto-detected from working directory if omitted.'
       ),
@@ -211,10 +212,14 @@ function getTools() {
     annotations: { readOnlyHint: true, destructiveHint: false, idempotentHint: true, openWorldHint: false },
     description:
       'List all Amicus sessions for the current project. Shows task ID, ' +
-      'model, status, age, and briefing excerpt.',
+      'model, status, tag, createdAt, and briefing excerpt. Use `search` to ' +
+      'filter by id/tag/briefing substring.',
     inputSchema: {
-      status: z.enum(['all', 'running', 'complete']).optional().describe(
-        'Filter by status. Default: show all.'
+      status: z.string().optional().describe(
+        "Filter by status ('all', 'running', 'complete', 'error', 'aborted', …). Default: show all."
+      ),
+      search: z.string().optional().describe(
+        'Case-insensitive substring filter over id, tag, and briefing material (F8 D15).'
       ),
       project: z.string().optional().describe(
         'Optional project directory path. Auto-detected from working directory if omitted.'
@@ -336,7 +341,7 @@ function getTools() {
         'Routing preference: auto (direct-first, default), direct (require a ' +
         'direct provider key), or openrouter (force OpenRouter).'
       ),
-      prompt: z.string().describe(
+      prompt: z.string().min(1, 'prompt must not be empty').describe(
         'The briefing sent to every model. Self-contained briefings work best (set includeContext false).'
       ),
       agent: z.enum(['Plan', 'Build']).optional().describe(
@@ -345,7 +350,7 @@ function getTools() {
       thinking: z.enum(['none', 'minimal', 'low', 'medium', 'high', 'xhigh']).optional().describe(
         'Reasoning effort for every leg. Default: medium.'
       ),
-      timeout: z.number().optional().describe(
+      timeout: z.number().positive('timeout must be a positive number of minutes').optional().describe(
         'Per-leg timeout in minutes (wall-clock ≈ slowest leg). Default: 15.'
       ),
       summaryLength: z.enum(['brief', 'normal', 'verbose']).optional().describe(
@@ -369,6 +374,7 @@ function getTools() {
         'commands are NOT accepted over MCP.'
       ),
       pack: z.string().optional().describe('Policy pack name or path — bench/chair/options/template defaults for this run; explicit params override pack values (recorded either way).'),
+      tag: z.string().regex(/^[a-zA-Z0-9_-]{1,64}$/, '1-64 chars, letters/digits/_/- only').optional().describe('Label this session for list/search/spend grouping'),
       project: z.string().optional().describe(
         'Optional project directory path. Auto-detected from working directory if omitted.'
       ),
@@ -509,6 +515,7 @@ function getTools() {
         'commands are NOT accepted over MCP.'
       ),
       pack: z.string().optional().describe('Policy pack name or path — bench/chair/options/template defaults for this run; explicit params override pack values (recorded either way).'),
+      tag: z.string().regex(/^[a-zA-Z0-9_-]{1,64}$/, '1-64 chars, letters/digits/_/- only').optional().describe('Label this session for list/search/spend grouping'),
       ui: z.boolean().optional().describe(
         'Auto-open the Council Workspace window on this run. Default: opens when the client is ' +
         'Claude Code (local), Electron is installed, a display exists, and config workspace.autoOpen is ' +

package/src/pack/pack-cli.js

@@ -30,7 +30,7 @@ function applyPackOrExit(args, expectedKind, useJson) {
   if (args.pack === undefined) { return null; }
   const explicit = args.__explicit || new Set();
   const pr = applyPackToArgs({ packRef: args.pack, expectedKind, args, explicit, useJson });
-  if (pr.error) { process.exit(failJson(useJson, pr.error)); }
+  if (pr.error) { return process.exit(failJson(useJson, pr.error)); }
   for (const n of pr.notices) { process.stderr.write(n + '\n'); }
   return pr.packRecord;
 }

package/src/pack/pack-forward.js

@@ -36,10 +36,18 @@
  *    render, so template provenance (`promptMeta.template`) is still
  *    recorded exactly as Wave 1 built it.
  *
- * Callers that only need the pre-spend validation (the two spawn paths)
- * ignore the returned `renderedPrompt`; amicus_start's in-process path
- * (which never spawns a child, so nothing else would render it) reuses it
- * as the actual prompt instead of rendering a second time.
+ * `renderedPrompt` has two different consumers now (W1-M4, v4.7 PR7):
+ * amicus_start's in-process path (which never spawns a child, so nothing
+ * else would render it) reuses it as the actual prompt instead of rendering
+ * a second time; amicus_fanout's spawn path writes it to the wave's
+ * on-disk `briefing.md` — the `--search` corpus (src/sidecar/list-search.js)
+ * — instead of the raw prompt, so a wave whose spawned child aborts before
+ * its own render (src/sidecar/fanout.js) stays findable by the text the
+ * user actually sees. The spawned child itself still gets the RAW prompt
+ * (via a sibling `briefing-input.md`), so its own later render remains the
+ * provenance source for `promptMeta.template`. amicus_start's
+ * spawn-fallback path is the one remaining caller that still only needs the
+ * pre-spend validation and ignores `renderedPrompt`.
  */
 
 const { ERROR_CODES } = require('../utils/error-doc');

package/src/pack/pack-resolve.js

@@ -54,6 +54,9 @@ function resolveBenchKnob(pack, args, explicit) {
     else if (Array.isArray(bench)) { args.models = bench.join(','); }
     return null;
   }
+  // Both-typed names --models here, but every consuming surface — fanout (cli-handlers-fanout.js:77),
+  // council run (cli-council-run-bench.js:45), MCP (mcp-council-bench.js:29) — rejects
+  // --models+--council with BAD_ARGS after pack apply, so a both-typed notice is never actionable.
   const flag = modelsExplicit ? '--models' : '--council';
   return `Notice: ${flag} overrides the bench from pack '${pack.name}'`;
 }

package/src/pack/pack-store.js

@@ -52,7 +52,21 @@ function resolvePackRef(ref) {
 
 function stripBom(text) { return text.charCodeAt(0) === 0xFEFF ? text.slice(1) : text; }
 
-/** @returns {{pack, path, source:'dir'|'path', hash}|{error}} */
+/**
+ * @returns {{pack, path, source:'dir'|'path', hash}|{error}}
+ * All SIX `{error}` returns below — malformed name, name-form unreadable,
+ * path-form unreadable, invalid JSON, non-object body, name/filename mismatch —
+ * are mapped to PACK_NOT_FOUND by both callers (pack-resolve.js:76,
+ * cli-handlers-pack.js:225). A new `{error}` added here inherits that code
+ * silently: re-code it deliberately or it lands as "not found".
+ * PACK_NOT_FOUND has a THIRD emit site that never calls readPack — `pack rm`
+ * (cli-handlers-pack.js:242, via rmPack) — unified there by the v4.5 HOLD-gate
+ * decision 3 and pinned by the "rm nonexistent pack -> PACK_NOT_FOUND" describe
+ * in tests/pack/cli-pack-cmd.test.js.
+ * PACK_INVALID is NOT readPack's: it belongs to validatePack
+ * (pack-resolve.js:94, cli-handlers-pack.js:199) and to prepareForward's
+ * maxCost guard (pack-forward.js:68-76), which is not a validatePack call.
+ */
 function readPack(ref) {
   const r = resolvePackRef(ref);
   if (r.error) { return r; }
@@ -66,8 +80,11 @@ function readPack(ref) {
   let pack;
   try { pack = JSON.parse(raw); }
   catch (err) { return { error: `Error: pack ${file} is not valid JSON: ${err.message}` }; }
-  if (r.kind === 'name' && pack && pack.name !== r.name) {
-    return { error: `Error: pack file ${file} declares name '${pack && pack.name}' which does not match its filename — rename one of them` };
+  if (pack === null || typeof pack !== 'object' || Array.isArray(pack)) {
+    return { error: `Error: pack ${file} is not a pack object (found ${pack === null ? 'null' : Array.isArray(pack) ? 'an array' : typeof pack})` };
+  }
+  if (r.kind === 'name' && pack.name !== r.name) {
+    return { error: `Error: pack file ${file} declares name '${pack.name}' which does not match its filename — rename one of them` };
   }
   return { pack, path: file, source: r.kind === 'name' ? 'dir' : 'path', hash: canonicalHash(pack) };
 }

package/src/pack/pack-validate.js

@@ -74,6 +74,11 @@ function validatePack(pack, { mode } = { mode: 'run' }) {
     if (typeof pack.model !== 'string' || !pack.model.trim()) { errors.push('solo pack requires model'); }
     else if (!seatOk(pack.model)) { errors.push(`unresolvable model '${pack.model}'`); }
   } else {
+    // T11-d: bench-independent — a by-name bench used to skip this entirely, so a pack
+    // could carry both and only fail (mis-attributed) at handler time.
+    if (pack.kind === 'council' && pack.critic && pack.lenses) {
+      errors.push('critic and lenses are mutually exclusive');
+    }
     const bench = pack.bench;
     if (typeof bench === 'string') {
       const { members } = getCouncilWithSource(bench, []);
@@ -87,7 +92,6 @@ function validatePack(pack, { mode } = { mode: 'run' }) {
       if (pack.kind === 'council') {
         if (pack.chair && bench.includes(pack.chair)) { errors.push(`chair '${pack.chair}' is a bench seat — the chair must not review`); }
         if (pack.critic && !bench.includes(pack.critic)) { errors.push(`critic '${pack.critic}' must be one of the bench seats`); }
-        if (pack.critic && pack.lenses) { errors.push('critic and lenses are mutually exclusive'); }
         if (Array.isArray(pack.lenses) && pack.lenses.length !== bench.length) {
           errors.push(`lenses needs exactly one lens per seat (${bench.length} seats, got ${pack.lenses.length})`);
         }

package/src/sidecar/budget.js

@@ -63,20 +63,54 @@ function checkBudget(legs, opts = {}) {
   return { ok, offending, overCeiling, breakdown: { legs: breakdownLegs, totalEstCost, unpricedCount, maxCostPerMtok: cap, maxCost: opts.maxCost || null } };
 }
 
-/** Human-readable refusal text (also used as the error envelope `hint`). */
-function formatBudgetError(result) {
+/**
+ * Human-readable refusal text (also used as the error envelope `hint`).
+ * @param {object} result checkBudget's return value
+ * @param {{kind:'cli'|'mcp'}} [surface] where the text will be read. Remedies are
+ *   surface-specific: the MCP tool surface has no --flags, and (since v4.7 PR6's
+ *   gate hoist) no per-call override at all. Defaults to 'cli' so the two CLI
+ *   callers stay byte-identical.
+ */
+function formatBudgetError(result, surface = { kind: 'cli' }) {
   const lines = [];
+  const isMcp = surface && surface.kind === 'mcp';
   if (result.offending.length > 0) {
     lines.push('Budget gate: model(s) over the per-$/Mtok threshold:');
     for (const o of result.offending) { lines.push(`  - ${o.modelInput} (${o.model}): ${o.reason}`); }
   }
   if (result.overCeiling) {
-    lines.push(`Budget gate: estimated total $${result.breakdown.totalEstCost.toFixed(4)} exceeds --max-cost $${result.breakdown.maxCost.toFixed(4)} (estimate, not guaranteed).`);
+    // On MCP the ceiling can come from EITHER a pack's `maxCost` option or the
+    // config, and the pack wins (mcp-server.js's fwd.maxCost ?? cfg.maxCost).
+    // Naming only one of them would send the caller to edit the loser — the very
+    // "remedy that cannot work" class this surface split exists to end.
+    lines.push(`Budget gate: estimated total $${result.breakdown.totalEstCost.toFixed(4)} exceeds ${isMcp ? 'the effective maxCost' : '--max-cost'} $${result.breakdown.maxCost.toFixed(4)} (estimate, not guaranteed).`);
   }
   if (result.breakdown.unpricedCount > 0) {
     lines.push(`(${result.breakdown.unpricedCount} unpriced leg(s) — direct provider; cost unknown, not included in the estimate.)`);
   }
-  lines.push('Override: --max-cost <$> to raise the ceiling, or --no-cost-gate to disable both guards (e.g. an intentional o3 run).');
+  // offending and overCeiling are independent (unrelated inputs — see module
+  // header), and either or both may have fired since formatBudgetError is only
+  // called when !ok. Only name a remedy that actually clears every branch that
+  // fired; when both fired, raising just one lever will not clear the run.
+  const hasOffending = result.offending.length > 0;
+  const hasCeiling = result.overCeiling;
+  if (isMcp) {
+    if (hasOffending && hasCeiling) {
+      lines.push("Override: raise maxCostPerMtok in the amicus config AND the effective maxCost (the pack's `maxCost` option if this run used a pack, otherwise the config's), or choose a cheaper model — raising just one will not clear this run.");
+    } else if (hasOffending) {
+      lines.push('Override: raise maxCostPerMtok in the amicus config, or choose a cheaper model.');
+    } else {
+      lines.push("Override: raise the effective maxCost — the pack's `maxCost` option if this run used a pack, otherwise the config's — or choose a cheaper model.");
+    }
+  } else {
+    if (hasOffending && hasCeiling) {
+      lines.push('Override: --no-cost-gate to disable both guards (e.g. an intentional o3 run) — raising just one of maxCostPerMtok or --max-cost will not clear this run.');
+    } else if (hasOffending) {
+      lines.push('Override: --no-cost-gate to disable both guards (e.g. an intentional o3 run), or raise maxCostPerMtok in config.');
+    } else {
+      lines.push('Override: --max-cost <$> to raise the ceiling, or --no-cost-gate to disable both guards (e.g. an intentional o3 run).');
+    }
+  }
   return lines.join('\n');
 }
 

package/src/sidecar/continue.js

@@ -88,7 +88,7 @@ Build on the previous sidecar's findings. The user wants to continue or extend t
 
 /** Create session metadata for continuation */
 function createContinueSessionMetadata(taskId, project, options, oldTaskId) {
-  const { model, briefing, headless, agent, gateway, resolutionVersion } = options;
+  const { model, briefing, headless, agent, gateway, resolutionVersion, tag } = options;
 
   const sessionDir = SessionPaths.sessionDir(project, taskId);
   fs.mkdirSync(sessionDir, { recursive: true });
@@ -102,7 +102,11 @@ function createContinueSessionMetadata(taskId, project, options, oldTaskId) {
     agent: agent || (headless ? 'build' : 'chat'),
     status: 'running',
     createdAt: new Date().toISOString(),
-    continuesFrom: oldTaskId
+    continuesFrom: oldTaskId,
+    // v4.7.1 Task 7 (D13): absent-not-null, same idiom as start-metadata.js:50
+    // — a continuation inherits the parent's tag so a continue chain never
+    // scatters into `(unattributed)`.
+    ...(tag ? { tag } : {}),
   };
   // #61 Task 5.2 (best-effort provenance): only present when THIS continue
   // call freshly routed an explicit --model through the gateway router — the
@@ -116,26 +120,6 @@ function createContinueSessionMetadata(taskId, project, options, oldTaskId) {
   return sessionDir;
 }
 
-/**
- * Resolve a reopened session's usage, write it onto metadata, and append one
- * attributed ledger row. Mirrors start.js's finalize (the only sites that
- * dropped usage - BACKLOG.md:280). Best-effort ledger append; never throws.
- * @returns {{usage: object|null}}
- */
-function finalizeSpendForReopen({ taskId, model, mode, op, result, status, project, metadata }, ctx = {}) {
-  const { resolveUsage } = require('../utils/pricing');
-  const usage = result && result.usage ? resolveUsage({ model, usageTotals: result.usage }) : null;
-  if (usage) {
-    metadata.usage = usage; // buildRunResult surfaces metadata.usage into the --json doc for free
-    try {
-      const { appendSpend } = require('../utils/spend-ledger');
-      const gateway = metadata.gateway || (String(model).startsWith('openrouter/') ? 'openrouter' : 'direct');
-      appendSpend({ taskId, model, mode, usage, op, status, project, gateway }, ctx);
-    } catch { /* best-effort */ }
-  }
-  return { usage };
-}
-
 /**
  * Continue from a previous sidecar session - Spec Reference: §4.4, §8.5
  * @returns {Promise<number>} process exit code
@@ -196,6 +180,7 @@ async function continueSidecar(options) {
 
   const sessionDir = createContinueSessionMetadata(newTaskId, project, {
     model, briefing, headless, agent: effectiveAgent, gateway, resolutionVersion,
+    tag: oldMetadata.tag, // v4.7.1 Task 7: inherit the parent's tag (absent if the parent had none).
   }, oldTaskId);
 
   // Lock the NEW continuation session dir too — not just the previous one — so a
@@ -270,6 +255,7 @@ async function continueSidecar(options) {
   // ledger row (status: statusFromResult, matching start.js — not terminal.status).
   {
     const { statusFromResult } = require('../utils/result-schema');
+    const { finalizeSpendForReopen } = require('./reopen-spend');
     const reloaded = JSON.parse(fs.readFileSync(metaPath, 'utf-8'));
     const { usage } = finalizeSpendForReopen({
       taskId: newTaskId, model, mode: headless ? 'headless' : 'interactive',
@@ -292,6 +278,5 @@ module.exports = {
   loadPreviousSession,
   buildContinuationContext,
   createContinueSessionMetadata,
-  finalizeSpendForReopen,
   continueSidecar
 };

package/src/sidecar/fanout-budget.js

@@ -61,8 +61,7 @@ function preflightBudget(okLegs, options) {
       message: 'Error: budget gate refused the wave',
       hint: `Budget gate: estimated total $${estimate.toFixed(4)} does not fit the --max-cost `
         + 'allowance still unclaimed by concurrently launching waves (estimate, not guaranteed).\n'
-        + 'The run continues with the waves that did launch. Override: --max-cost <$> to raise the '
-        + 'ceiling, or --no-cost-gate to disable both guards.',
+        + 'The run continues with the waves that did launch.',
     };
   }
   return { ok: true, estimate };

package/src/sidecar/fanout-leg-fallback.js

@@ -18,9 +18,12 @@ const { deriveChain } = require('./fallback-chains');
 
 /**
  * Append ONE attributed ledger row for a single attempt (spec 6.2/7.1). At
- * `attempt:0` this is byte-identical to today's pre-fallback appendSpend row
- * (same fields, sourced from `leg.attempt`/`leg.substitutedFor`/
- * `leg.retryOfWaveId`, all undefined -> omitted for a plain leg). A
+ * `attempt:0` this row's LINKAGE fields (attempt/substitutedFor/retryOfWaveId,
+ * all undefined -> omitted for a plain leg) are byte-identical to today's
+ * pre-fallback appendSpend row. v4.7 F8 D16 adds `tag` — a NULLABLE dim, not a
+ * linkage field, so every row now carries it (null-default when the leg was
+ * never tagged) rather than omitting it; the byte-identity claim above applies
+ * only to the linkage-field convention, not to the full row shape. A
  * substitution (`attempt` param > 0, the LOOP's attempt index) overrides
  * `row.attempt`/`row.substitutedFor` with the substitution's own values.
  * Best-effort — never throws, never affects the leg. `deps.spendDir` (tests)
@@ -42,6 +45,7 @@ function recordAttemptSpend({ doc, leg, currentModel, legId, waveId, project, at
       councilRunId: leg && leg.councilRunId, councilName: leg && leg.councilName,
       project, attempt: leg && leg.attempt, substitutedFor: leg && leg.substitutedFor,
       retryOfWaveId: leg && leg.retryOfWaveId,
+      tag: (leg && leg.tag) || null,
     };
     if (attempt > 0) { row.attempt = attempt; row.substitutedFor = originalModel; }
     appendSpend(row, deps.spendDir ? { dir: deps.spendDir } : undefined);

package/src/sidecar/fanout-retry.js

@@ -73,7 +73,10 @@ function buildRetryPlan(origWaveId, project, { models } = {}) {
     } catch { /* legacy leg — fall back to briefing.md at launch time */ }
     eligible.push({ legId, model, systemPrompt, userMessage, hadSavedContext });
   }
-  return { eligible };
+  // waveMeta has been read since :51 but was discarded; retryFailedWave needs
+  // the tag BEFORE it builds fanoutOpts, and its own origMeta re-read at :176
+  // runs after runFanoutImpl at :153 — too late to influence the launch.
+  return { eligible, tag: waveMeta.tag };
 }
 
 /**
@@ -121,7 +124,7 @@ async function retryFailedWave(origWaveId, project, opts = {}) {
         // --json caller's stdout stays machine-parseable either way.
         const noopDoc = {
           ...buildWaveResult({ waveId: origWaveId, legs: [], status: 'complete' }),
-          retryOf: origWaveId, effective: [], note: 'no failed legs',
+          retryOf: origWaveId, effective: [], note: 'no failed legs', tag: plan.tag,
         };
         process.stdout.write(JSON.stringify(noopDoc, null, 2) + '\n');
       } else {
@@ -148,7 +151,16 @@ async function retryFailedWave(origWaveId, project, opts = {}) {
   // expects (parseModelsList/validateFanoutModels) — an array silently fails
   // every leg pre-flight (BAD_ARGS), matching run-launch.js:41's precedent.
   // Strip our own injection key so it is never forwarded.
-  const fanoutOpts = { ...opts, models: models.join(','), prompt: briefing, project, waveId: newWaveId, retryContexts, retryOfWaveId: origWaveId };
+  const fanoutOpts = {
+    ...opts, models: models.join(','), prompt: briefing, project, waveId: newWaveId, retryContexts, retryOfWaveId: origWaveId,
+    // v4.7.1 Task 8: inherit the ORIGINAL wave's tag — sourced from disk
+    // (plan.tag, off waveMeta) never from opts.tag/args.tag. This is placed
+    // AFTER the `...opts` spread so it wins even if a caller's opts somehow
+    // carried a tag (the CLI itself already rejects --tag + --retry-failed
+    // upstream in cli-handlers-fanout.js). Absent-not-null idiom, matching
+    // fanout.js:152's `...(options.pack ? {...} : {})`.
+    ...(plan.tag ? { tag: plan.tag } : {}),
+  };
   delete fanoutOpts.runFanout;
   const { wave, exitCode } = await runFanoutImpl(fanoutOpts);