amicus 4.6.1 → 4.6.2

package/src/utils/no-output-backstop.js

@@ -0,0 +1,48 @@
+/**
+ * @module utils/no-output-backstop
+ * v4.6.2 PR2 (spec §5, D4): fail a headless leg fast when the model produces
+ * ZERO output, reasoning, and tool calls — the "accepted but not serving"
+ * class (the v4.6.1 gemini release-gate incident: requests accepted, zero
+ * tokens, three suites burned 130s timeouts each to learn nothing).
+ *
+ * Pure state machine, loop-driven (no timers of its own — the poll loop
+ * ticks it): armed at leg start, DISARMED PERMANENTLY by the first
+ * `progressed` tick (a 30-90s cold-prefill local model is never affected),
+ * fired when the deadline passes with nothing ever observed. `fired` is
+ * terminal. `ms <= 0` never arms — 0 is the documented escape hatch, which
+ * is why the env resolver uses envNumber (explicit 0 honored) rather than
+ * the `Number(env) || default` idiom.
+ *
+ * PR3's live probe reuses this with a 30s override — ms is an input; only
+ * the exported resolver reads the environment.
+ */
+'use strict';
+
+const { envNumber } = require('./env-num');
+
+const DEFAULT_NO_OUTPUT_BACKSTOP_MS = 120000;
+
+/** @param {object} [env] test seam; defaults to process.env */
+function resolveNoOutputBackstopMs(env) {
+  return envNumber('AMICUS_NO_OUTPUT_BACKSTOP_MS', DEFAULT_NO_OUTPUT_BACKSTOP_MS, env);
+}
+
+/**
+ * @param {{ms:number, startedAt:number}} opts
+ * @returns {{tick:(progressed:boolean, nowMs:number)=>string, state:()=>string}}
+ */
+function createNoOutputBackstop({ ms, startedAt }) {
+  let state = ms > 0 ? 'armed' : 'disarmed';
+  const deadline = startedAt + ms;
+  return {
+    tick(progressed, nowMs) {
+      if (state !== 'armed') { return state; }
+      if (progressed) { state = 'disarmed'; return state; }
+      if (nowMs >= deadline) { state = 'fired'; }
+      return state;
+    },
+    state() { return state; },
+  };
+}
+
+module.exports = { resolveNoOutputBackstopMs, createNoOutputBackstop, DEFAULT_NO_OUTPUT_BACKSTOP_MS };

package/src/utils/result-schema.js

@@ -192,10 +192,32 @@ function buildCatalogDoc({ models, fetchedAt, refreshed = false, search = null,
  * of curated DEFAULT aliases (toGatewayRoutes() vs. the live catalog),
  * distinct from the flat `stale` audit above. Defaults to [] so existing
  * callers that omit it are unaffected.
+ * `drifted` (v4.6.2 PR1, 2A) is additive: stored user-config aliases whose
+ * target is still catalog-live but behind the current quick-pick family
+ * resolution (findDriftedStoredAliases). Defaults to [] so existing callers
+ * that omit it are unaffected. Paired with an additive `driftedCount`
+ * (drifted.length), mirroring the staleCount/stale and
+ * gatewayFindingsCount/gatewayFindings pairs above.
+ * `probe` (v4.6.2 PR3, spec §6 D5) is additive: the `--live` opt-in per-alias
+ * probe outcomes (probeStoredAliases — served/accepted-but-silent/error), one
+ * row per stored alias actually probed. Defaults to [] so every call without
+ * --live (i.e. every existing caller) is unaffected. Paired with an additive
+ * `probeCount` (probe.length), mirroring the driftedCount/drifted pair above.
+ * `probeSkipped` (v4.6.2 PR3 Task 4) is additive: null when the probe ran or
+ * `--live` wasn't requested; otherwise a stable reason slug (e.g.
+ * 'catalog-unavailable') for the one case this function can see — the
+ * `--refresh --check --live` skip (runRefresh returns before this is ever
+ * called) is announced by the caller instead, since that path emits a
+ * model-catalog doc, not this one.
  * @param {{stale: Array<{alias,model,source,suggestions}>, catalogAvailable: boolean,
- *   gatewayFindings?: Array<{alias,gateway,kind,model,expected?}>}} opts
+ *   gatewayFindings?: Array<{alias,gateway,kind,model,expected?}>,
+ *   drifted?: Array<{alias,stored,current}>,
+ *   probe?: Array<{alias,target,outcome,detail,cost}>,
+ *   probeSkipped?: string|null}} opts
  */
-function buildAuditDoc({ stale, catalogAvailable, gatewayFindings = [] }) {
+function buildAuditDoc({
+  stale, catalogAvailable, gatewayFindings = [], drifted = [], probe = [], probeSkipped = null
+}) {
   return {
     schemaVersion: SCHEMA_VERSION,
     type: 'alias-audit',
@@ -204,6 +226,11 @@ function buildAuditDoc({ stale, catalogAvailable, gatewayFindings = [] }) {
     stale,
     gatewayFindingsCount: gatewayFindings.length,
     gatewayFindings,
+    driftedCount: drifted.length,
+    drifted,
+    probeCount: probe.length,
+    probe,
+    probeSkipped,
   };
 }
 

package/src/workspace/live-normalize.js

@@ -126,6 +126,7 @@ function normalizeLive(doc) {
     stageName: active ? active.name : null,
     stages,
     seats: legRowsOf(doc).map(seatOf),
+    degrades: Array.isArray(doc.degrades) ? doc.degrades : [],
     // ⚠️ v4.4.1 RN-8 (D1 ruling: delete the promise). `legsTotal`/`legsComplete` used to be
     // mapped here under a comment promising them as "the honest fallback readout if a seat row
     // is ever unavailable" — a UI fallback nobody ever wired. Nothing in electron/workspace-ui/