amicus 4.5.4 → 4.6.0

package/src/utils/doctor-engine-check.js

@@ -73,7 +73,7 @@ function evaluateEngineInstalls(d) {
  * the engine into each via d.repairEngine, then re-report from a fresh scan.
  * Without d.fix — or when nothing is copy-fixable — returns the plain verdict.
  * @param {object} d doctor deps (scanEngineInstalls, fix?, repairEngine?)
- * @returns {Promise<{id,name,status,message,hint}>}
+ * @returns {Promise<{id,name,status,message,hint,fixed?,fixDetail?}>}
  */
 async function evaluateEngineMcp(d) {
   const verdict = evaluateEngineInstalls(d);
@@ -94,11 +94,22 @@ async function evaluateEngineMcp(d) {
   const after = evaluateEngineInstalls(d); // fresh scan reflects the copies
   if (after.status === 'ok') {
     const n = results.length;
-    return { ...after, message: `${after.message} (self-healed ${n} npx-cache ${plural(n, 'copy', 'copies')})` };
+    return {
+      ...after,
+      message: `${after.message} (self-healed ${n} npx-cache ${plural(n, 'copy', 'copies')})`,
+      fixed: true,
+      fixDetail: `copied the engine into ${n} npx-cache ${plural(n, 'copy', 'copies')}`,
+    };
   }
   const failed = results.filter((r) => !r.repaired)
     .map((r) => `${r.pkgDir}${r.reason ? ` — ${r.reason}` : ''}`).join('; ');
-  return { ...after, message: `${after.message}; self-heal incomplete: ${failed}` };
+  // Partial credit: some copies healed even though the check overall is still
+  // not 'ok' — flag it ONLY when >=1 repair actually succeeded (#84-style rule).
+  const healed = results.filter((r) => r.repaired).length;
+  const fixFields = healed > 0
+    ? { fixed: true, fixDetail: `copied the engine into ${healed} npx-cache ${plural(healed, 'copy', 'copies')}` }
+    : {};
+  return { ...after, message: `${after.message}; self-heal incomplete: ${failed}`, ...fixFields };
 }
 
 module.exports = { evaluateEngineInstalls, evaluateEngineMcp };

package/src/utils/doctor-mcp-checks.js

@@ -68,14 +68,21 @@ function evaluateLegacyMcpEntry(d) {
   }
   if (d.fix) {
     const removed = (d.migrateLegacyMcpEntries() || []).filter(r => r.result === 'removed');
+    // Structured fix outcome (v4.6 Plan 3 Task 3): a repaired row carries
+    // fixed/fixDetail whenever ANY entry was actually removed, even on the
+    // partial-failure path below — a genuine no-op (removed.length === 0)
+    // stays unflagged.
+    const fixFields = removed.length > 0
+      ? { fixed: true, fixDetail: `removed the duplicate legacy 'sidecar' entry from ${removed.map(r => r.target).join(', ')}` }
+      : {};
     if (removed.length >= dupes.length) {
       const message = `removed legacy entry from: ${removed.map(r => r.target).join(', ')}`;
       return unreadableNote
-        ? { id, name, status: 'warn', message: `${message}; ${unreadableNote}`, hint: HINTS.removeLegacySidecar }
-        : { id, name, status: 'ok', message, hint: null };
+        ? { id, name, status: 'warn', message: `${message}; ${unreadableNote}`, hint: HINTS.removeLegacySidecar, ...fixFields }
+        : { id, name, status: 'ok', message, hint: null, ...fixFields };
     }
     const message = `removed ${removed.length}/${dupes.length} duplicate(s) — could not update every config`;
-    return { id, name, status: 'warn', message: unreadableNote ? `${message}; ${unreadableNote}` : message, hint: HINTS.removeLegacySidecar };
+    return { id, name, status: 'warn', message: unreadableNote ? `${message}; ${unreadableNote}` : message, hint: HINTS.removeLegacySidecar, ...fixFields };
   }
   const message = `duplicate 'sidecar' entry in ${dupes.map(e => e.target).join(', ')} — doubles the MCP tool list`;
   return { id, name, status: 'warn', message: unreadableNote ? `${message}; ${unreadableNote}` : message, hint: HINTS.removeLegacySidecar };

package/src/utils/known-flags.js

@@ -29,7 +29,7 @@
  * Real flags that appear in NO usage block. Rejecting any of these would break
  * working callers, so they are enumerated deliberately rather than derived.
  *
- * ⚠️ The first four are spawned by the MCP server onto its own CLI children
+ * ⚠️ These are spawned by the MCP server onto its own CLI children
  * (src/mcp-server.js, src/mcp-council-run.js). They are not user-facing and are
  * intentionally undocumented — but they are on the argv of every MCP-launched
  * run, so rejecting them would break the entire MCP surface.
@@ -39,6 +39,7 @@ const INTERNAL_FLAGS = new Set([
   'run-id',          // MCP → `council run`: pins the child's run id
   'council-name',    // MCP → `council run`: preset name for ledger attribution
   'cowork-process',  // MCP → `start`: Cowork process handle for context capture
+  'dropped-members', // MCP → 'council run': per-member preset drops as JSON (v4.6 Plan 4)
 
   // User-facing but undocumented, and read by real handlers today. Listed so the
   // rejection is a bug fix and not a silent removal of working behaviour; if any

package/src/utils/remediation-hints.js

@@ -33,7 +33,7 @@ const REMEDIATION_HINTS = Object.freeze({
    */
   reinstallEngineAv:
     'npm install -g amicus  (a transient install error can roll back the engine binaries — re-run, or: npm cache clean --force && npm install -g amicus). '
-    + 'If your antivirus (e.g. Windows Defender) quarantined opencode.exe, allow-list it first, then reinstall.',
+    + 'If your antivirus (e.g. Windows Defender) quarantined opencode.exe — unverified, but a known cause — allow-list it first, then reinstall.',
 
   /**
    * Runtime server-start failure when the opencode engine binary does not
@@ -41,8 +41,10 @@ const REMEDIATION_HINTS = Object.freeze({
    * spawn ENOENT — surfaced by startServer (the missing-binary boundary).
    */
   engineMissing:
-    'OpenCode engine binary not found — it was likely skipped during install or quarantined by antivirus. '
-    + 'Run "amicus doctor", reinstall with "npm i -g amicus", and allow-list opencode.exe in your antivirus.',
+    'OpenCode engine binary not found — the cause was not verified. Common causes (unverified): '
+    + 'an install that skipped or rolled back the engine packages, or antivirus quarantine of opencode.exe. '
+    + 'Run "amicus doctor" to check the actual install, reinstall with "npm i -g amicus", '
+    + 'and allow-list opencode.exe in your antivirus if quarantine was the cause.',
 
   /** Electron absent — reinstall to add the interactive GUI (headless still works). */
   reinstallElectron: 'npm install -g amicus  (reinstall to add Electron)',

package/src/utils/result-schema.js

@@ -209,9 +209,10 @@ function buildAuditDoc({ stale, catalogAvailable, gatewayFindings = [] }) {
 
 /**
  * Build a doctor health-check document (`doctor --json`).
- * @param {{version: string, timestamp: string, checks: Array<{id,name,status,message,hint}>}} opts
+ * @param {{version: string, timestamp: string, checks: Array<{id,name,status,message,hint}>,
+ *   degrades?: Array<{kind,channel,what,why,effect,remedy?,data?}>}} opts
  */
-function buildDoctorDoc({ version, timestamp, checks }) {
+function buildDoctorDoc({ version, timestamp, checks, degrades }) {
   return {
     schemaVersion: SCHEMA_VERSION,
     type: 'doctor',
@@ -219,6 +220,9 @@ function buildDoctorDoc({ version, timestamp, checks }) {
     version,
     timestamp,
     checks,
+    // v4.6 Plan 3 (spec §4/§6): the shared-vocabulary surface. Additive and
+    // OPTIONAL — present only when a check failed or --fix repaired something.
+    ...(degrades && degrades.length ? { degrades } : {}),
   };
 }
 

package/src/utils/session-index-tmp-sweep.js

@@ -70,7 +70,8 @@ function evaluateSessionIndexTmpSweep(d) {
   }
   const remaining = files.length - swept;
   if (remaining === 0) {
-    return { id, name, status: 'ok', message: `swept ${swept} orphaned tmp file(s)`, hint: null };
+    const fixFields = swept > 0 ? { fixed: true, fixDetail: `swept ${swept} orphaned session-index tmp file(s)` } : {};
+    return { id, name, status: 'ok', message: `swept ${swept} orphaned tmp file(s)`, hint: null, ...fixFields };
   }
   return { id, name, status: 'warn', message: `swept ${swept}, ${remaining} remaining (too fresh or unremovable)`, hint: HINTS.sweepSessionIndexTmp };
 }

package/src/workspace/run-scan.js

@@ -70,7 +70,11 @@ function readPointer(project, runId) {
   const id = String(runId).replace(/^council-/, '');
   if (!RUN_ID_RE.test(id)) { return { runId: id, error: 'invalid runId' }; }
   const ptr = runState.readPointer(project, id);
-  if (!ptr) { return { runId: id, error: 'pointer missing, unreadable, or invalid' }; }
+  if (!ptr) {
+    return { runId: id, error: 'pointer missing — run pointers live under the LAUNCH directory '
+      + '(where `council run` was invoked), not --out-dir. If this run used --out-dir, point '
+      + '--project at the launch directory instead.' };
+  }
   return { runId: id, runDir: ptr.runDir };
 }