amazingteam 3.0.0
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/.ai-team/agents/architect.md +144 -0
- package/.ai-team/agents/ci-analyst.md +188 -0
- package/.ai-team/agents/developer.md +176 -0
- package/.ai-team/agents/planner.md +355 -0
- package/.ai-team/agents/qa.md +189 -0
- package/.ai-team/agents/reviewer.md +211 -0
- package/.ai-team/agents/triage.md +146 -0
- package/.ai-team/commands/ci-analyze.md +116 -0
- package/.ai-team/commands/design.md +100 -0
- package/.ai-team/commands/implement.md +108 -0
- package/.ai-team/commands/release-check.md +142 -0
- package/.ai-team/commands/review.md +142 -0
- package/.ai-team/commands/test.md +115 -0
- package/.ai-team/commands/triage.md +138 -0
- package/.ai-team/memory/architect/architecture_notes.md +67 -0
- package/.ai-team/memory/architect/design_rationale.md +113 -0
- package/.ai-team/memory/architect/module_map.md +84 -0
- package/.ai-team/memory/ci-analyst/failure_patterns.md +102 -0
- package/.ai-team/memory/ci-analyst/runbook_references.md +87 -0
- package/.ai-team/memory/developer/bug_investigation.md +102 -0
- package/.ai-team/memory/developer/build_issues.md +115 -0
- package/.ai-team/memory/developer/implementation_notes.md +83 -0
- package/.ai-team/memory/failures/failure_library.md +103 -0
- package/.ai-team/memory/planner/decomposition_notes.md +82 -0
- package/.ai-team/memory/planner/flow_rules.md +86 -0
- package/.ai-team/memory/planner/github_issue_patterns.md +229 -0
- package/.ai-team/memory/qa/regression_cases.md +101 -0
- package/.ai-team/memory/qa/test_strategy.md +138 -0
- package/.ai-team/memory/qa/validation_notes.md +110 -0
- package/.ai-team/memory/reviewer/quality_rules.md +105 -0
- package/.ai-team/memory/reviewer/recurring_risks.md +109 -0
- package/.ai-team/memory/reviewer/review_notes.md +124 -0
- package/.ai-team/memory/triage/classification_heuristics.md +82 -0
- package/.ai-team/memory/triage/debug_notes.md +87 -0
- package/.ai-team/opencode.template.jsonc +216 -0
- package/.ai-team/skills/bugfix-playbook/skill.md +174 -0
- package/.ai-team/skills/ci-failure-analysis/skill.md +176 -0
- package/.ai-team/skills/issue-triage/skill.md +163 -0
- package/.ai-team/skills/regression-checklist/skill.md +176 -0
- package/.ai-team/skills/release-readiness-check/skill.md +216 -0
- package/.ai-team/skills/repo-architecture-reader/skill.md +139 -0
- package/.ai-team/skills/safe-refactor-checklist/skill.md +215 -0
- package/.ai-team/skills/task-breakdown-and-dispatch/skill.md +151 -0
- package/.ai-team/skills/test-first-feature-dev/skill.md +205 -0
- package/.ai-team/workflows/ci.yml +81 -0
- package/.ai-team/workflows/nightly-ai-maintenance.yml +129 -0
- package/.ai-team/workflows/opencode.yml +33 -0
- package/.ai-team/workflows/pr-check.yml +41 -0
- package/.foundation/foundation.lock +38 -0
- package/.foundation/local-overrides.md +97 -0
- package/.foundation/upgrade-history.md +38 -0
- package/.opencode/agents/architect.md +38 -0
- package/.opencode/agents/ci-analyst.md +38 -0
- package/.opencode/agents/developer.md +43 -0
- package/.opencode/agents/planner.md +47 -0
- package/.opencode/agents/qa.md +34 -0
- package/.opencode/agents/reviewer.md +38 -0
- package/.opencode/agents/triage.md +37 -0
- package/.opencode/commands/auto.md +264 -0
- package/.opencode/commands/breakdown-issue.md +94 -0
- package/.opencode/commands/ci-analyze.md +15 -0
- package/.opencode/commands/close-parent-task.md +122 -0
- package/.opencode/commands/design.md +15 -0
- package/.opencode/commands/dispatch-next.md +102 -0
- package/.opencode/commands/implement.md +16 -0
- package/.opencode/commands/release-check.md +16 -0
- package/.opencode/commands/resume.md +88 -0
- package/.opencode/commands/review.md +15 -0
- package/.opencode/commands/show-blockers.md +97 -0
- package/.opencode/commands/summarize-parent.md +121 -0
- package/.opencode/commands/test.md +15 -0
- package/.opencode/commands/triage.md +109 -0
- package/.opencode/skills/bugfix-playbook/SKILL.md +81 -0
- package/.opencode/skills/ci-failure-analysis/SKILL.md +94 -0
- package/.opencode/skills/issue-triage/SKILL.md +80 -0
- package/.opencode/skills/regression-checklist/SKILL.md +81 -0
- package/.opencode/skills/release-readiness-check/SKILL.md +81 -0
- package/.opencode/skills/repo-architecture-reader/SKILL.md +65 -0
- package/.opencode/skills/safe-refactor-checklist/SKILL.md +76 -0
- package/.opencode/skills/task-breakdown-and-dispatch/SKILL.md +255 -0
- package/.opencode/skills/test-first-feature-dev/SKILL.md +78 -0
- package/AGENTS.md +879 -0
- package/CHANGELOG.md +261 -0
- package/LICENSE +21 -0
- package/README.md +1215 -0
- package/VERSION +1 -0
- package/action/__tests__/downloader.test.js +251 -0
- package/action/__tests__/merger.test.js +156 -0
- package/action/__tests__/path-resolver.test.js +199 -0
- package/action/__tests__/validator.test.js +310 -0
- package/action/action.yml +61 -0
- package/action/index.js +223 -0
- package/action/lib/downloader.js +344 -0
- package/action/lib/merger.js +170 -0
- package/action/lib/path-resolver.js +176 -0
- package/action/lib/setup.js +286 -0
- package/action/lib/validator.js +324 -0
- package/cli/__tests__/cli.test.js +270 -0
- package/cli/amazingteam.cjs +225 -0
- package/cli/commands/check-update.cjs +159 -0
- package/cli/commands/init.cjs +412 -0
- package/cli/commands/local.cjs +264 -0
- package/cli/commands/migrate.cjs +316 -0
- package/cli/commands/status.cjs +241 -0
- package/cli/commands/upgrade.cjs +213 -0
- package/cli/commands/validate.cjs +259 -0
- package/cli/commands/version.cjs +59 -0
- package/cli/sync.cjs +237 -0
- package/dist/index.js +35 -0
- package/docs/architecture/overview.md +138 -0
- package/docs/blocker_resolution_design.md +372 -0
- package/docs/bootstrap-model.md +356 -0
- package/docs/config-reference.md +458 -0
- package/docs/how-to-use.md +178 -0
- package/docs/migration-to-v3.md +355 -0
- package/docs/overlay-guide.md +156 -0
- package/docs/patterns/README.md +67 -0
- package/docs/quick-start-v3.md +330 -0
- package/docs/releases/README.md +64 -0
- package/docs/runbooks/ci/README.md +62 -0
- package/docs/runbooks/ci/build-debug.md +120 -0
- package/docs/runbooks/ci/flaky-tests.md +127 -0
- package/docs/runbooks/getting-started.md +81 -0
- package/docs/upgrade-policy.md +188 -0
- package/docs/versioning.md +199 -0
- package/overlays/README.md +30 -0
- package/overlays/ai-agent-product/.ai-team/skills/llm-integration/skill.md +99 -0
- package/overlays/ai-agent-product/docs/ai-agent-architecture.md +68 -0
- package/overlays/ai-agent-product/overlay.yaml +26 -0
- package/overlays/cpp-qt-desktop/.ai-team/skills/qt-signals-slots/skill.md +60 -0
- package/overlays/cpp-qt-desktop/docs/qt-conventions.md +64 -0
- package/overlays/cpp-qt-desktop/overlay.yaml +22 -0
- package/overlays/python-backend/.ai-team/skills/python-testing/skill.md +90 -0
- package/overlays/python-backend/docs/python-style.md +78 -0
- package/overlays/python-backend/overlay.yaml +22 -0
- package/overlays/web-fullstack/.ai-team/skills/frontend-testing/skill.md +70 -0
- package/overlays/web-fullstack/docs/frontend-conventions.md +68 -0
- package/overlays/web-fullstack/overlay.yaml +26 -0
- package/package.json +84 -0
- package/presets/default.yaml +161 -0
- package/presets/go.yaml +43 -0
- package/presets/python.yaml +43 -0
- package/presets/typescript.yaml +40 -0
- package/schemas/config.schema.json +239 -0
- package/scripts/diff_foundation_vs_project.sh +134 -0
- package/scripts/generate_docs.sh +200 -0
- package/scripts/init_project.sh +455 -0
- package/scripts/plan_upgrade.sh +268 -0
- package/scripts/upgrade_foundation.sh +365 -0
- package/scripts/validate-foundation.cjs +278 -0
- package/scripts/validate_foundation.sh +192 -0
- package/scripts/validate_project_setup.sh +171 -0
- package/tasks/README.md +94 -0
- package/tasks/_template/analysis.md +76 -0
- package/tasks/_template/design.md +121 -0
- package/tasks/_template/implementation.md +121 -0
- package/tasks/_template/release.md +119 -0
- package/tasks/_template/review.md +131 -0
- package/tasks/_template/subtasks/task.yaml +24 -0
- package/tasks/_template/task.yaml +75 -0
- package/tasks/_template/validation.md +128 -0
- package/templates/amazingteam.yml +81 -0
- package/templates/gitignore +14 -0
- package/templates/opencode.jsonc +216 -0
|
@@ -0,0 +1,110 @@
|
|
|
1
|
+
# QA Memory - Validation Notes
|
|
2
|
+
|
|
3
|
+
This file records validation observations and lessons learned by the QA agent.
|
|
4
|
+
|
|
5
|
+
---
|
|
6
|
+
|
|
7
|
+
## Validation Process
|
|
8
|
+
|
|
9
|
+
### For Features
|
|
10
|
+
|
|
11
|
+
1. **Requirements Review**
|
|
12
|
+
- Verify acceptance criteria are testable
|
|
13
|
+
- Identify edge cases
|
|
14
|
+
- Note dependencies
|
|
15
|
+
|
|
16
|
+
2. **Test Design**
|
|
17
|
+
- Design test cases for each criterion
|
|
18
|
+
- Include happy path and error paths
|
|
19
|
+
- Consider boundary conditions
|
|
20
|
+
|
|
21
|
+
3. **Execution**
|
|
22
|
+
- Run all relevant tests
|
|
23
|
+
- Verify behavior matches expectations
|
|
24
|
+
- Document any deviations
|
|
25
|
+
|
|
26
|
+
4. **Reporting**
|
|
27
|
+
- Summarize results
|
|
28
|
+
- Report issues found
|
|
29
|
+
- Recommend sign-off or revision
|
|
30
|
+
|
|
31
|
+
### For Bug Fixes
|
|
32
|
+
|
|
33
|
+
1. **Reproduction Verification**
|
|
34
|
+
- Verify the reported issue exists
|
|
35
|
+
- Confirm fix addresses root cause
|
|
36
|
+
- Check for similar issues
|
|
37
|
+
|
|
38
|
+
2. **Regression Testing**
|
|
39
|
+
- Run related tests
|
|
40
|
+
- Check adjacent functionality
|
|
41
|
+
- Verify no new issues
|
|
42
|
+
|
|
43
|
+
3. **Documentation**
|
|
44
|
+
- Update test coverage
|
|
45
|
+
- Add regression tests
|
|
46
|
+
- Document lessons learned
|
|
47
|
+
|
|
48
|
+
---
|
|
49
|
+
|
|
50
|
+
## Validation Results Log
|
|
51
|
+
|
|
52
|
+
### [Date] - [Issue/Feature]
|
|
53
|
+
|
|
54
|
+
**Type**: [Feature/Bug Fix/Refactor]
|
|
55
|
+
|
|
56
|
+
**Items Tested**: [List of items]
|
|
57
|
+
|
|
58
|
+
**Results**: [Summary of results]
|
|
59
|
+
|
|
60
|
+
**Issues Found**: [List any issues]
|
|
61
|
+
|
|
62
|
+
**Recommendation**: [Approve/Request Changes]
|
|
63
|
+
|
|
64
|
+
---
|
|
65
|
+
|
|
66
|
+
## Common Validation Issues
|
|
67
|
+
|
|
68
|
+
### False Positives
|
|
69
|
+
|
|
70
|
+
| Issue | Cause | Mitigation |
|
|
71
|
+
|-------|-------|------------|
|
|
72
|
+
| Flaky test | Timing/state | Add retry/stabilize |
|
|
73
|
+
| Environment config | Different settings | Use consistent config |
|
|
74
|
+
|
|
75
|
+
### False Negatives
|
|
76
|
+
|
|
77
|
+
| Issue | Cause | Mitigation |
|
|
78
|
+
|-------|-------|------------|
|
|
79
|
+
| Missing test case | Incomplete coverage | Add test |
|
|
80
|
+
| Wrong assertion | Misunderstood requirement | Clarify requirement |
|
|
81
|
+
|
|
82
|
+
---
|
|
83
|
+
|
|
84
|
+
## Validation Checklist
|
|
85
|
+
|
|
86
|
+
### Pre-Validation
|
|
87
|
+
|
|
88
|
+
- [ ] Requirements understood
|
|
89
|
+
- [ ] Test cases designed
|
|
90
|
+
- [ ] Environment prepared
|
|
91
|
+
|
|
92
|
+
### During Validation
|
|
93
|
+
|
|
94
|
+
- [ ] Tests executed
|
|
95
|
+
- [ ] Results recorded
|
|
96
|
+
- [ ] Edge cases explored
|
|
97
|
+
|
|
98
|
+
### Post-Validation
|
|
99
|
+
|
|
100
|
+
- [ ] Results summarized
|
|
101
|
+
- [ ] Issues documented
|
|
102
|
+
- [ ] Recommendation provided
|
|
103
|
+
|
|
104
|
+
---
|
|
105
|
+
|
|
106
|
+
## Notes
|
|
107
|
+
|
|
108
|
+
- Record validation patterns that work well
|
|
109
|
+
- Document common issues and solutions
|
|
110
|
+
- Track validation efficiency metrics
|
|
@@ -0,0 +1,105 @@
|
|
|
1
|
+
# Reviewer Memory - Quality Rules
|
|
2
|
+
|
|
3
|
+
This file defines code quality rules and standards enforced by the Reviewer agent.
|
|
4
|
+
|
|
5
|
+
---
|
|
6
|
+
|
|
7
|
+
## Code Quality Standards
|
|
8
|
+
|
|
9
|
+
### Naming Conventions
|
|
10
|
+
|
|
11
|
+
| Element | Convention | Example |
|
|
12
|
+
|---------|------------|---------|
|
|
13
|
+
| Variables | camelCase | `userName` |
|
|
14
|
+
| Constants | SCREAMING_SNAKE_CASE | `MAX_RETRY_COUNT` |
|
|
15
|
+
| Functions | camelCase | `getUserById` |
|
|
16
|
+
| Classes | PascalCase | `UserService` |
|
|
17
|
+
| Interfaces | PascalCase | `IUserRepository` |
|
|
18
|
+
| Types | PascalCase | `UserRole` |
|
|
19
|
+
| Files | kebab-case | `user-service.ts` |
|
|
20
|
+
|
|
21
|
+
### Code Structure
|
|
22
|
+
|
|
23
|
+
| Rule | Rationale |
|
|
24
|
+
|------|-----------|
|
|
25
|
+
| Max function length: 30 lines | Readability |
|
|
26
|
+
| Max nesting: 3 levels | Complexity management |
|
|
27
|
+
| One responsibility per function | Maintainability |
|
|
28
|
+
| No magic numbers | Clarity |
|
|
29
|
+
|
|
30
|
+
### TypeScript Rules
|
|
31
|
+
|
|
32
|
+
| Rule | Standard |
|
|
33
|
+
|------|----------|
|
|
34
|
+
| Explicit return types | Required for public functions |
|
|
35
|
+
| No `any` type | Use specific types |
|
|
36
|
+
| Strict null checks | Enabled |
|
|
37
|
+
| No unused variables | Error |
|
|
38
|
+
|
|
39
|
+
---
|
|
40
|
+
|
|
41
|
+
## Quality Metrics
|
|
42
|
+
|
|
43
|
+
### Maintainability Index
|
|
44
|
+
|
|
45
|
+
| Score | Rating | Action |
|
|
46
|
+
|-------|--------|--------|
|
|
47
|
+
| 0-9 | Low | Refactor required |
|
|
48
|
+
| 10-19 | Medium | Consider refactoring |
|
|
49
|
+
| 20+ | High | Good |
|
|
50
|
+
|
|
51
|
+
### Complexity Thresholds
|
|
52
|
+
|
|
53
|
+
| Metric | Warning | Error |
|
|
54
|
+
|--------|---------|-------|
|
|
55
|
+
| Cyclomatic Complexity | 10 | 20 |
|
|
56
|
+
| Cognitive Complexity | 15 | 25 |
|
|
57
|
+
| Lines of Code (per function) | 20 | 30 |
|
|
58
|
+
|
|
59
|
+
---
|
|
60
|
+
|
|
61
|
+
## Forbidden Patterns
|
|
62
|
+
|
|
63
|
+
| Pattern | Why Forbidden | Alternative |
|
|
64
|
+
|---------|---------------|-------------|
|
|
65
|
+
| `any` type | Loses type safety | Use specific type or `unknown` |
|
|
66
|
+
| `console.log` in production | Performance, security | Use logger |
|
|
67
|
+
| Deep nesting | Hard to read | Early returns, extract methods |
|
|
68
|
+
| Magic numbers | Unclear meaning | Named constants |
|
|
69
|
+
| Uncaught promises | Silent failures | Try/catch or .catch() |
|
|
70
|
+
|
|
71
|
+
---
|
|
72
|
+
|
|
73
|
+
## Code Smells
|
|
74
|
+
|
|
75
|
+
### Detect and Address
|
|
76
|
+
|
|
77
|
+
| Smell | Detection | Fix |
|
|
78
|
+
|-------|-----------|-----|
|
|
79
|
+
| Long method | > 30 lines | Extract methods |
|
|
80
|
+
| Large class | > 200 lines | Split responsibilities |
|
|
81
|
+
| Duplicate code | Similar blocks | Extract common code |
|
|
82
|
+
| Dead code | Unused | Remove |
|
|
83
|
+
| Feature envy | Using other's data | Move method |
|
|
84
|
+
|
|
85
|
+
---
|
|
86
|
+
|
|
87
|
+
## Security Rules
|
|
88
|
+
|
|
89
|
+
### Must Check
|
|
90
|
+
|
|
91
|
+
| Area | Rule |
|
|
92
|
+
|------|------|
|
|
93
|
+
| Input | Validate and sanitize |
|
|
94
|
+
| Output | Encode for context |
|
|
95
|
+
| Auth | Verify on every request |
|
|
96
|
+
| Secrets | Never in code |
|
|
97
|
+
| Logs | No sensitive data |
|
|
98
|
+
|
|
99
|
+
---
|
|
100
|
+
|
|
101
|
+
## Notes
|
|
102
|
+
|
|
103
|
+
- Update when new patterns emerge
|
|
104
|
+
- Document exceptions to rules
|
|
105
|
+
- Track effectiveness of rules
|
|
@@ -0,0 +1,109 @@
|
|
|
1
|
+
# Reviewer Memory - Recurring Risks
|
|
2
|
+
|
|
3
|
+
This file tracks recurring code risks and patterns that frequently cause issues.
|
|
4
|
+
|
|
5
|
+
---
|
|
6
|
+
|
|
7
|
+
## Risk Categories
|
|
8
|
+
|
|
9
|
+
### High Risk Patterns
|
|
10
|
+
|
|
11
|
+
| Risk | Frequency | Impact | Mitigation |
|
|
12
|
+
|------|-----------|--------|------------|
|
|
13
|
+
| Missing null checks | High | Runtime error | Use optional chaining |
|
|
14
|
+
| Unhandled promises | Medium | Silent failure | Async/await with try/catch |
|
|
15
|
+
| Hardcoded values | Medium | Maintenance | Use configuration |
|
|
16
|
+
| Missing tests | High | Regression | Require tests for changes |
|
|
17
|
+
|
|
18
|
+
### Medium Risk Patterns
|
|
19
|
+
|
|
20
|
+
| Risk | Frequency | Impact | Mitigation |
|
|
21
|
+
|------|-----------|--------|------------|
|
|
22
|
+
| Complex conditionals | Medium | Bugs | Simplify or document |
|
|
23
|
+
| Large functions | Medium | Maintainability | Extract methods |
|
|
24
|
+
| Deep nesting | Low | Readability | Early returns |
|
|
25
|
+
| Missing error handling | Medium | Poor UX | Handle all cases |
|
|
26
|
+
|
|
27
|
+
---
|
|
28
|
+
|
|
29
|
+
## Risk Detection Patterns
|
|
30
|
+
|
|
31
|
+
### Security Risks
|
|
32
|
+
|
|
33
|
+
```typescript
|
|
34
|
+
// Risk: SQL Injection
|
|
35
|
+
const query = `SELECT * FROM users WHERE id = ${userId}`;
|
|
36
|
+
// Fix: Use parameterized queries
|
|
37
|
+
|
|
38
|
+
// Risk: XSS
|
|
39
|
+
element.innerHTML = userInput;
|
|
40
|
+
// Fix: Use textContent or sanitize
|
|
41
|
+
|
|
42
|
+
// Risk: Hardcoded secrets
|
|
43
|
+
const apiKey = "sk-xxxxx";
|
|
44
|
+
// Fix: Use environment variables
|
|
45
|
+
```
|
|
46
|
+
|
|
47
|
+
### Performance Risks
|
|
48
|
+
|
|
49
|
+
```typescript
|
|
50
|
+
// Risk: N+1 queries
|
|
51
|
+
for (const user of users) {
|
|
52
|
+
const posts = await getPosts(user.id);
|
|
53
|
+
}
|
|
54
|
+
// Fix: Batch query
|
|
55
|
+
|
|
56
|
+
// Risk: Memory leak
|
|
57
|
+
const listener = () => {};
|
|
58
|
+
element.addEventListener('click', listener);
|
|
59
|
+
// Fix: Remove listener when done
|
|
60
|
+
```
|
|
61
|
+
|
|
62
|
+
### Correctness Risks
|
|
63
|
+
|
|
64
|
+
```typescript
|
|
65
|
+
// Risk: Race condition
|
|
66
|
+
let value = 0;
|
|
67
|
+
async function increment() {
|
|
68
|
+
value++;
|
|
69
|
+
}
|
|
70
|
+
// Fix: Use atomic operations or locks
|
|
71
|
+
|
|
72
|
+
// Risk: Stale closure
|
|
73
|
+
for (var i = 0; i < 3; i++) {
|
|
74
|
+
setTimeout(() => console.log(i), 100);
|
|
75
|
+
}
|
|
76
|
+
// Fix: Use let or capture value
|
|
77
|
+
```
|
|
78
|
+
|
|
79
|
+
---
|
|
80
|
+
|
|
81
|
+
## Risk Log
|
|
82
|
+
|
|
83
|
+
### [Date] - [Risk Description]
|
|
84
|
+
|
|
85
|
+
**Pattern**: [Code pattern that indicates risk]
|
|
86
|
+
|
|
87
|
+
**Impact**: [What could go wrong]
|
|
88
|
+
|
|
89
|
+
**Frequency**: [How often seen]
|
|
90
|
+
|
|
91
|
+
**Mitigation**: [How to prevent/fix]
|
|
92
|
+
|
|
93
|
+
---
|
|
94
|
+
|
|
95
|
+
## Risk Assessment Matrix
|
|
96
|
+
|
|
97
|
+
| Likelihood \ Impact | Low | Medium | High |
|
|
98
|
+
|---------------------|-----|--------|------|
|
|
99
|
+
| High | Monitor | Address | Critical |
|
|
100
|
+
| Medium | Accept | Monitor | Address |
|
|
101
|
+
| Low | Accept | Accept | Monitor |
|
|
102
|
+
|
|
103
|
+
---
|
|
104
|
+
|
|
105
|
+
## Notes
|
|
106
|
+
|
|
107
|
+
- Update when new recurring risks are identified
|
|
108
|
+
- Track effectiveness of mitigations
|
|
109
|
+
- Share patterns with Developer agent for prevention
|
|
@@ -0,0 +1,124 @@
|
|
|
1
|
+
# Reviewer Memory - Review Notes
|
|
2
|
+
|
|
3
|
+
This file stores code review observations and patterns identified by the Reviewer agent.
|
|
4
|
+
|
|
5
|
+
---
|
|
6
|
+
|
|
7
|
+
## Review Process
|
|
8
|
+
|
|
9
|
+
### Step 1: Understand Context
|
|
10
|
+
|
|
11
|
+
1. Read PR description
|
|
12
|
+
2. Review related issue
|
|
13
|
+
3. Understand the change purpose
|
|
14
|
+
4. Note acceptance criteria
|
|
15
|
+
|
|
16
|
+
### Step 2: Examine Changes
|
|
17
|
+
|
|
18
|
+
1. Review each file systematically
|
|
19
|
+
2. Check coding standards
|
|
20
|
+
3. Identify potential issues
|
|
21
|
+
4. Note positive aspects
|
|
22
|
+
|
|
23
|
+
### Step 3: Provide Feedback
|
|
24
|
+
|
|
25
|
+
1. Write clear, constructive comments
|
|
26
|
+
2. Explain reasoning
|
|
27
|
+
3. Provide code examples when helpful
|
|
28
|
+
4. Prioritize by severity
|
|
29
|
+
|
|
30
|
+
### Step 4: Summarize
|
|
31
|
+
|
|
32
|
+
1. Overall assessment
|
|
33
|
+
2. Required changes
|
|
34
|
+
3. Optional suggestions
|
|
35
|
+
4. Merge recommendation
|
|
36
|
+
|
|
37
|
+
---
|
|
38
|
+
|
|
39
|
+
## Review Categories
|
|
40
|
+
|
|
41
|
+
### 🔴 Critical (Must Fix)
|
|
42
|
+
|
|
43
|
+
- Security vulnerabilities
|
|
44
|
+
- Data loss risks
|
|
45
|
+
- Breaking bugs
|
|
46
|
+
- Performance critical issues
|
|
47
|
+
|
|
48
|
+
### 🟡 Important (Should Fix)
|
|
49
|
+
|
|
50
|
+
- Potential bugs
|
|
51
|
+
- Maintainability concerns
|
|
52
|
+
- Missing error handling
|
|
53
|
+
- Incomplete tests
|
|
54
|
+
|
|
55
|
+
### 🟢 Suggestions (Nice to Have)
|
|
56
|
+
|
|
57
|
+
- Code style improvements
|
|
58
|
+
- Documentation enhancements
|
|
59
|
+
- Minor optimizations
|
|
60
|
+
|
|
61
|
+
### 💬 Questions
|
|
62
|
+
|
|
63
|
+
- Clarification needed
|
|
64
|
+
- Design discussion points
|
|
65
|
+
- Alternative approaches
|
|
66
|
+
|
|
67
|
+
---
|
|
68
|
+
|
|
69
|
+
## Review Checklist
|
|
70
|
+
|
|
71
|
+
### Code Quality
|
|
72
|
+
|
|
73
|
+
- [ ] Code is readable
|
|
74
|
+
- [ ] Naming is clear
|
|
75
|
+
- [ ] Functions are focused
|
|
76
|
+
- [ ] No duplication
|
|
77
|
+
- [ ] Error handling is appropriate
|
|
78
|
+
|
|
79
|
+
### Security
|
|
80
|
+
|
|
81
|
+
- [ ] No sensitive data exposed
|
|
82
|
+
- [ ] Input validation present
|
|
83
|
+
- [ ] Authentication/authorization correct
|
|
84
|
+
- [ ] No injection vulnerabilities
|
|
85
|
+
|
|
86
|
+
### Performance
|
|
87
|
+
|
|
88
|
+
- [ ] No obvious bottlenecks
|
|
89
|
+
- [ ] Resources properly managed
|
|
90
|
+
- [ ] Caching used appropriately
|
|
91
|
+
|
|
92
|
+
### Testing
|
|
93
|
+
|
|
94
|
+
- [ ] Tests cover new code
|
|
95
|
+
- [ ] Edge cases tested
|
|
96
|
+
- [ ] Tests are meaningful
|
|
97
|
+
|
|
98
|
+
### Documentation
|
|
99
|
+
|
|
100
|
+
- [ ] Public APIs documented
|
|
101
|
+
- [ ] Complex logic explained
|
|
102
|
+
- [ ] README updated if needed
|
|
103
|
+
|
|
104
|
+
---
|
|
105
|
+
|
|
106
|
+
## Review Log
|
|
107
|
+
|
|
108
|
+
### [Date] - PR #[number]
|
|
109
|
+
|
|
110
|
+
**Summary**: [Brief description]
|
|
111
|
+
|
|
112
|
+
**Strengths**: [What was done well]
|
|
113
|
+
|
|
114
|
+
**Concerns**: [Issues found]
|
|
115
|
+
|
|
116
|
+
**Verdict**: [Approve/Request Changes]
|
|
117
|
+
|
|
118
|
+
---
|
|
119
|
+
|
|
120
|
+
## Notes
|
|
121
|
+
|
|
122
|
+
- Track patterns in code issues
|
|
123
|
+
- Note areas that frequently need attention
|
|
124
|
+
- Record effective review techniques
|
|
@@ -0,0 +1,82 @@
|
|
|
1
|
+
# Triage Memory - Classification Heuristics
|
|
2
|
+
|
|
3
|
+
This file stores issue classification patterns and heuristics.
|
|
4
|
+
|
|
5
|
+
---
|
|
6
|
+
|
|
7
|
+
## Classification Quick Reference
|
|
8
|
+
|
|
9
|
+
### Issue Type Indicators
|
|
10
|
+
|
|
11
|
+
| Type | Indicators |
|
|
12
|
+
|------|------------|
|
|
13
|
+
| bug | Error messages, crashes, unexpected behavior |
|
|
14
|
+
| feature | New capability request, "would like to" |
|
|
15
|
+
| enhancement | Improvement to existing, "better", "faster" |
|
|
16
|
+
| docs | Missing/outdated documentation |
|
|
17
|
+
| tech | Technical debt, infrastructure |
|
|
18
|
+
| question | "How do I", clarification needed |
|
|
19
|
+
|
|
20
|
+
### Priority Indicators
|
|
21
|
+
|
|
22
|
+
| Priority | Indicators |
|
|
23
|
+
|----------|------------|
|
|
24
|
+
| critical | Production down, security issue, data loss |
|
|
25
|
+
| high | Major feature broken, many users affected |
|
|
26
|
+
| medium | Standard issue, workaround exists |
|
|
27
|
+
| low | Minor issue, niche case |
|
|
28
|
+
|
|
29
|
+
---
|
|
30
|
+
|
|
31
|
+
## Debugging Heuristics
|
|
32
|
+
|
|
33
|
+
### Error Pattern → Likely Cause
|
|
34
|
+
|
|
35
|
+
| Error Pattern | Likely Cause | Investigation |
|
|
36
|
+
|---------------|--------------|---------------|
|
|
37
|
+
| Null reference | Missing null check | Check data flow |
|
|
38
|
+
| Timeout | Network/slow operation | Check async code |
|
|
39
|
+
| Permission denied | Access control | Check auth/config |
|
|
40
|
+
| Type error | Type mismatch | Check types/interfaces |
|
|
41
|
+
| Not found | Missing resource | Check paths/IDs |
|
|
42
|
+
|
|
43
|
+
### Recent Change Check
|
|
44
|
+
|
|
45
|
+
1. Check commits in last 24-48 hours
|
|
46
|
+
2. Look for changes in affected modules
|
|
47
|
+
3. Check dependency updates
|
|
48
|
+
4. Review config changes
|
|
49
|
+
|
|
50
|
+
---
|
|
51
|
+
|
|
52
|
+
## Classification Log
|
|
53
|
+
|
|
54
|
+
### [Date] - Issue #[number]
|
|
55
|
+
|
|
56
|
+
**Symptoms**: [What was reported]
|
|
57
|
+
|
|
58
|
+
**Classification**: [Type/Priority]
|
|
59
|
+
|
|
60
|
+
**Rationale**: [Why classified this way]
|
|
61
|
+
|
|
62
|
+
**Outcome**: [Resolution or handoff]
|
|
63
|
+
|
|
64
|
+
---
|
|
65
|
+
|
|
66
|
+
## Common Issue Patterns
|
|
67
|
+
|
|
68
|
+
### Pattern: [Pattern Name]
|
|
69
|
+
|
|
70
|
+
**Symptoms**: [Typical symptoms]
|
|
71
|
+
|
|
72
|
+
**Root Cause**: [Typical cause]
|
|
73
|
+
|
|
74
|
+
**Quick Fix**: [Typical fix]
|
|
75
|
+
|
|
76
|
+
---
|
|
77
|
+
|
|
78
|
+
## Notes
|
|
79
|
+
|
|
80
|
+
- Update with new patterns as discovered
|
|
81
|
+
- Document false positives
|
|
82
|
+
- Track classification accuracy
|
|
@@ -0,0 +1,87 @@
|
|
|
1
|
+
# Triage Memory - Debug Notes
|
|
2
|
+
|
|
3
|
+
This file stores debugging observations and investigation patterns.
|
|
4
|
+
|
|
5
|
+
---
|
|
6
|
+
|
|
7
|
+
## Investigation Checklist
|
|
8
|
+
|
|
9
|
+
### Initial Assessment
|
|
10
|
+
|
|
11
|
+
- [ ] Error message captured
|
|
12
|
+
- [ ] Stack trace available
|
|
13
|
+
- [ ] Reproduction steps documented
|
|
14
|
+
- [ ] Environment noted
|
|
15
|
+
- [ ] Recent changes reviewed
|
|
16
|
+
|
|
17
|
+
### Deep Investigation
|
|
18
|
+
|
|
19
|
+
- [ ] Affected files identified
|
|
20
|
+
- [ ] Root cause hypothesis formed
|
|
21
|
+
- [ ] Similar issues searched
|
|
22
|
+
- [ ] Related code reviewed
|
|
23
|
+
- [ ] Tests checked
|
|
24
|
+
|
|
25
|
+
---
|
|
26
|
+
|
|
27
|
+
## Debug Log
|
|
28
|
+
|
|
29
|
+
### [Date] - Issue #[number]
|
|
30
|
+
|
|
31
|
+
**Error**: [Error message]
|
|
32
|
+
|
|
33
|
+
**Context**: [When/where it occurs]
|
|
34
|
+
|
|
35
|
+
**Investigation**: [Steps taken]
|
|
36
|
+
|
|
37
|
+
**Findings**: [What was found]
|
|
38
|
+
|
|
39
|
+
**Root Cause**: [Final determination]
|
|
40
|
+
|
|
41
|
+
**Resolution**: [How fixed]
|
|
42
|
+
|
|
43
|
+
---
|
|
44
|
+
|
|
45
|
+
## Recurring Issues
|
|
46
|
+
|
|
47
|
+
### Issue Pattern: [Pattern Name]
|
|
48
|
+
|
|
49
|
+
**Frequency**: [How often it occurs]
|
|
50
|
+
|
|
51
|
+
**Symptoms**: [Typical presentation]
|
|
52
|
+
|
|
53
|
+
**Root Cause**: [Underlying cause]
|
|
54
|
+
|
|
55
|
+
**Fix**: [Standard fix]
|
|
56
|
+
|
|
57
|
+
**Prevention**: [How to prevent]
|
|
58
|
+
|
|
59
|
+
---
|
|
60
|
+
|
|
61
|
+
## Environment-Specific Issues
|
|
62
|
+
|
|
63
|
+
### Development
|
|
64
|
+
|
|
65
|
+
| Issue | Cause | Resolution |
|
|
66
|
+
|-------|-------|------------|
|
|
67
|
+
| | | |
|
|
68
|
+
|
|
69
|
+
### Staging
|
|
70
|
+
|
|
71
|
+
| Issue | Cause | Resolution |
|
|
72
|
+
|-------|-------|------------|
|
|
73
|
+
| | | |
|
|
74
|
+
|
|
75
|
+
### Production
|
|
76
|
+
|
|
77
|
+
| Issue | Cause | Resolution |
|
|
78
|
+
|-------|-------|------------|
|
|
79
|
+
| | | |
|
|
80
|
+
|
|
81
|
+
---
|
|
82
|
+
|
|
83
|
+
## Notes
|
|
84
|
+
|
|
85
|
+
- Document all investigations, even unsuccessful ones
|
|
86
|
+
- Track patterns that lead to quick resolutions
|
|
87
|
+
- Note environment-specific behaviors
|