amalgm 0.1.149 → 0.1.150

package/runtime/scripts/amalgm-mcp/tests/state-registry.test.js

@@ -0,0 +1,95 @@
+'use strict';
+
+const test = require('node:test');
+const assert = require('node:assert/strict');
+
+// Stub the event log so requiring snapshot.js never opens a real database.
+const eventsPath = require.resolve('../state/events');
+require.cache[eventsPath] = {
+  id: eventsPath,
+  filename: eventsPath,
+  loaded: true,
+  exports: {
+    currentSeq: () => 0,
+  },
+};
+
+const registry = require('../state/registry');
+const snapshot = require('../state/snapshot');
+
+test.after(() => {
+  delete require.cache[eventsPath];
+});
+
+// The registry must reproduce the pre-registry default set exactly — this is
+// the wire contract clients built against.
+const LEGACY_DEFAULT_RESOURCES = ['automations', 'triggers', 'workflows', 'automation_runs', 'workflow_cell_runs', 'agents', 'agent_configs', 'skills', 'apps', 'ports', 'toolbox', 'tools', 'tool_actions', 'hooks', 'projects', 'workspaces', 'project_context', 'user_preferences', 'chat_payloads', 'mcp_connections', 'browser_profiles', 'browser_auth_bundles', 'browser_login_sessions'];
+
+test('default snapshot set matches the legacy hardcoded list exactly', () => {
+  assert.deepEqual(registry.listDefaultResources(), LEGACY_DEFAULT_RESOURCES);
+  assert.deepEqual(snapshot.DEFAULT_RESOURCES, LEGACY_DEFAULT_RESOURCES);
+  assert.deepEqual(snapshot.normalizeResources(undefined), LEGACY_DEFAULT_RESOURCES);
+});
+
+test('non-default built-ins are registered but excluded from the default set', () => {
+  for (const name of ['tasks', 'task_runs', 'event_runs', 'event_triggers', 'uploads', 'browser_surfaces']) {
+    assert.equal(registry.hasResource(name), true, `${name} should be registered`);
+    assert.equal(registry.listDefaultResources().includes(name), false, `${name} should not be a default`);
+  }
+});
+
+test('files: prefix resolves for any path under it', () => {
+  assert.equal(registry.hasResource('files:workspace/notes'), true);
+  assert.equal(registry.hasResource('filesystem'), false);
+});
+
+test('unknown resources read as undefined and are omitted from snapshots', () => {
+  assert.equal(registry.hasResource('no_such_resource'), false);
+  assert.equal(registry.readRegisteredResource('no_such_resource', {}), undefined);
+  const result = snapshot.buildSnapshot('no_such_resource');
+  assert.deepEqual(result.resources, {});
+  assert.equal(result.stable, true);
+});
+
+test('a newly registered resource flows through buildSnapshot end to end', () => {
+  const rows = [{ id: 'n1', text: 'buy milk' }];
+  registry.registerResource('app:demo:notes', { read: () => rows });
+  try {
+    const result = snapshot.buildSnapshot('app:demo:notes');
+    assert.deepEqual(result.resources['app:demo:notes'], rows);
+    // Registering does not add it to the default set.
+    assert.equal(registry.listDefaultResources().includes('app:demo:notes'), false);
+  } finally {
+    registry.unregisterResource('app:demo:notes');
+  }
+});
+
+test('read context is shared within one snapshot pass', () => {
+  let reads = 0;
+  registry.registerResource('app:demo:shared_a', {
+    read: (ctx) => {
+      ctx.demoShared ||= (reads += 1, { value: reads });
+      return [ctx.demoShared];
+    },
+  });
+  registry.registerResource('app:demo:shared_b', {
+    read: (ctx) => {
+      ctx.demoShared ||= (reads += 1, { value: reads });
+      return [ctx.demoShared];
+    },
+  });
+  try {
+    const result = snapshot.buildSnapshot('app:demo:shared_a,app:demo:shared_b');
+    assert.equal(reads, 1, 'shared read should run once per attempt');
+    assert.deepEqual(result.resources['app:demo:shared_a'], result.resources['app:demo:shared_b']);
+  } finally {
+    registry.unregisterResource('app:demo:shared_a');
+    registry.unregisterResource('app:demo:shared_b');
+  }
+});
+
+test('duplicate and invalid registrations are rejected', () => {
+  assert.throws(() => registry.registerResource('skills', { read: () => [] }), /already registered/);
+  assert.throws(() => registry.registerResource('app:demo:bad', {}), /read\(\) function/);
+  assert.throws(() => registry.registerResource('', { read: () => [] }), /non-empty string/);
+});

package/runtime/scripts/amalgm-mcp/workflows/compiler.js

@@ -172,6 +172,11 @@ function normalizeWorkflow(definition) {
     ? definition.trigger
     : splitEventRef(definition.trigger || '*.*');
   const names = new Set();
+  if (definition.cells !== undefined && !Array.isArray(definition.cells)) {
+    throw new Error(
+      `\`cells\` must be an array of cell-builder calls, e.g. cells: [code("step1", fn), tool("step2", "notifications.notify_user", fn)] — got ${typeof definition.cells}.`,
+    );
+  }
   const cells = Array.isArray(definition.cells)
     ? definition.cells.map((cell, index) => normalizeCell(cell, index, names))
     : [];