amalgm 0.1.103 → 0.1.104

package/runtime/scripts/amalgm-mcp/notify/email-media.js

@@ -31,7 +31,19 @@ const MAX_VIDEO_BYTES = 20 * 1024 * 1024;
 const MAX_TOTAL_BYTES = 22 * 1024 * 1024; // proxy caps at 25MB; leave margin
 const MAX_ATTACHMENTS = 8;
 
-const MEDIA_LINE_RE = /^!\[([^\]]*)\]\(([^)\s]+)(?:\s+"([^"]*)")?\)$/;
+function parseMediaLine(line) {
+  const match = line.trim().match(/^!\[([^\]]*)\]\((.*)\)$/);
+  if (!match) return null;
+  let src = match[2].trim();
+  let title = null;
+  const titleMatch = src.match(/^(.*)\s+"([^"]*)"$/);
+  if (titleMatch) {
+    src = titleMatch[1].trim();
+    title = titleMatch[2];
+  }
+  if (!src) return null;
+  return { alt: match[1], src, title };
+}
 
 /** Resolve a media src to an absolute path on this computer, or null. */
 function resolveLocalPath(src) {
@@ -133,9 +145,9 @@ function prepareEmailMedia(message) {
   };
 
   const lines = message.split('\n').map((line) => {
-    const match = line.trim().match(MEDIA_LINE_RE);
-    if (!match) return line;
-    const [, alt, src, title] = match;
+    const media = parseMediaLine(line);
+    if (!media) return line;
+    const { alt, src, title } = media;
 
     if (/^(https?:|cid:|attached:|data:)/i.test(src)) return line;
     const filePath = resolveLocalPath(src);

package/runtime/scripts/amalgm-mcp/notify/index.js

@@ -9,6 +9,7 @@
 const { PROXY_BASE_URL, PROXY_TOKEN } = require('../config');
 const { ensureFreshProxyToken, readProxyToken } = require('../../proxy-token-store');
 const { formatNotificationEmail } = require('../lib/email-md');
+const { prepareEmailIconAttachments } = require('../lib/email-icons');
 const { prepareEmailMedia } = require('./email-media');
 const { textResult, errorResult } = require('../lib/tool-result');
 
@@ -32,6 +33,10 @@ async function notifyUserViaProxy({ subject: customSubject, message, link, sessi
   // inline via cid:, videos as regular attachments with a poster card.
   const media = prepareEmailMedia(message);
   const html = formatNotificationEmail(media.message, link || null);
+  const attachments = [
+    ...media.attachments,
+    ...prepareEmailIconAttachments(html, media.attachments),
+  ];
 
   try {
     const res = await fetch(notifyUrl, {
@@ -44,7 +49,7 @@ async function notifyUserViaProxy({ subject: customSubject, message, link, sessi
         subject,
         html,
         text: message,
-        ...(media.attachments.length ? { attachments: media.attachments } : {}),
+        ...(attachments.length ? { attachments } : {}),
         ...(sessionId ? { sessionId } : {}),
       }),
     });

package/runtime/scripts/amalgm-mcp/tests/email-embeds.test.js

@@ -0,0 +1,97 @@
+'use strict';
+
+const assert = require('node:assert/strict');
+const test = require('node:test');
+
+const {
+  fileBasenameOf,
+  renderEntityEmbed,
+  renderMediaEmbed,
+  resolveFileEmbedIdentity,
+} = require('../lib/email-embeds');
+const { prepareEmailIconAttachments } = require('../lib/email-icons');
+const { markdownToEmailHtml } = require('../lib/email-md');
+
+test('file identity decodes local, amalgm, url, and attached sources', () => {
+  assert.equal(fileBasenameOf('/Users/me/Recordings/flower.webm'), 'flower.webm');
+  assert.equal(fileBasenameOf('amalgm://file/%2FUsers%2Fme%2Fsample.pdf'), 'sample.pdf');
+  assert.equal(fileBasenameOf('https://example.com/files/report%20final.pdf?token=abc'), 'report final.pdf');
+  assert.equal(fileBasenameOf('attached:qa-pass.webm'), 'qa-pass.webm');
+});
+
+test('attached video embed uses filename for the floating tab, not markdown alt', () => {
+  const html = renderMediaEmbed('QA recording', 'attached:qa-pass.webm', 'cid:poster-1');
+
+  assert.match(html, /qa-pass\.webm/);
+  assert.doesNotMatch(html, /QA recording/);
+  assert.match(html, /role="presentation" width="100%"/);
+  assert.match(html, /display:inline-table;height:32px/);
+  assert.match(html, /cid:amalgm-icon-lucide-video-f472b6/);
+  assert.match(html, /cid:amalgm-icon-lucide-externallink-ffffff/);
+  assert.doesNotMatch(html, /<svg/);
+  assert.doesNotMatch(html, /position:absolute/);
+  assert.match(html, /font-weight:400/);
+  assert.doesNotMatch(html, /\.\.\./);
+  assert.doesNotMatch(html, /▸/);
+});
+
+test('email icon cid references become inline png attachments', () => {
+  const html = renderMediaEmbed('QA recording', 'attached:qa-pass.webm', 'cid:poster-1');
+  const icons = prepareEmailIconAttachments(html, []);
+
+  assert.equal(icons.length, 2);
+  assert.equal(icons[0].contentType, 'image/png');
+  assert.deepEqual(
+    icons.map((attachment) => attachment.contentId).sort(),
+    ['amalgm-icon-lucide-externallink-ffffff', 'amalgm-icon-lucide-video-f472b6'],
+  );
+});
+
+test('long email embed tabs use faded title text instead of hard ellipsis', () => {
+  const html = renderMediaEmbed(
+    'QA recording',
+    'attached:amalgm-new-chat-flow-2026-06-12T05-57-32-525Z.webm',
+    'cid:poster-1',
+  );
+
+  assert.match(html, /amalgm-new-c/);
+  assert.match(html, /rgba\(255,255,255,0\.75\)/);
+  assert.match(html, /font-weight:400/);
+  assert.doesNotMatch(html, /\.\.\./);
+});
+
+test('local file fallback uses chrome identity only, not email-specific metadata rows', () => {
+  const html = renderMediaEmbed('Context label', 'amalgm://file/%2Ftmp%2Fdocx-experiment-sandbox.docx', null);
+
+  assert.match(html, /docx-experiment-sandbox\.docx/);
+  assert.doesNotMatch(html, /Context label/);
+  assert.doesNotMatch(html, /On your computer/);
+});
+
+test('standalone media lines accept local file paths with spaces', () => {
+  const html = markdownToEmailHtml('![Context label](/tmp/amalgm repo/sample file.pdf)');
+
+  assert.match(html, /sample file\.pdf/);
+  assert.match(html, /display:inline-table;height:32px/);
+  assert.doesNotMatch(html, /Context label/);
+});
+
+test('full entity embed uses chrome identity only, not centered email-only body text', () => {
+  const html = renderEntityEmbed('full', 'app', 'scout');
+
+  assert.match(html, /scout/);
+  assert.doesNotMatch(html, /text-transform:uppercase/);
+});
+
+test('file identity prefers explicit filename over path and url', () => {
+  const identity = resolveFileEmbedIdentity({
+    name: 'renamed.mov',
+    path: '/tmp/original.webm',
+    url: 'https://example.com/original.webm',
+    mimeType: 'video/quicktime',
+  });
+
+  assert.equal(identity.label, 'renamed.mov');
+  assert.equal(identity.kind, 'video');
+  assert.equal(identity.mimeType, 'video/quicktime');
+});

package/runtime/scripts/amalgm-mcp/tests/email-media.test.js

@@ -32,3 +32,22 @@ test('prepareEmailMedia attaches local video and prefers sibling animated GIF pr
     fs.rmSync(dir, { recursive: true, force: true });
   }
 });
+
+test('prepareEmailMedia accepts absolute media paths with spaces', () => {
+  const dir = fs.mkdtempSync(path.join(os.tmpdir(), 'amalgm email media-'));
+  try {
+    const videoPath = path.join(dir, 'qa pass.webm');
+    const gifPath = path.join(dir, 'qa pass.preview.gif');
+    fs.writeFileSync(videoPath, Buffer.from('not really a webm but enough for extension detection'));
+    fs.writeFileSync(gifPath, Buffer.from('GIF89a'));
+
+    const result = prepareEmailMedia(`![QA recording](${videoPath})`);
+
+    assert.match(result.message, /!\[QA recording\]\(attached:qa%20pass\.webm "cid:poster-1"\)/);
+    assert.equal(result.attachments.length, 2);
+    assert.equal(result.attachments[0].filename, 'qa pass.webm');
+    assert.equal(result.attachments[1].filename, 'qa pass.preview.gif');
+  } finally {
+    fs.rmSync(dir, { recursive: true, force: true });
+  }
+});