alvin-bot 5.1.5 → 5.1.6

package/CHANGELOG.md

@@ -2,6 +2,29 @@
 
 All notable changes to Alvin Bot are documented here.
 
+## [5.1.6] — 2026-05-15
+
+### Planned restarts really stop counting as crashes now
+
+v5.1.5 added a flag that marks self-updates and `/update` / `/restart`
+as intentional so they don't inflate the crash counter. Half of it
+didn't actually work: the code that reads the saved state back on the
+next boot rebuilt it field by field and silently dropped that very
+flag, so the crash detector never saw it and planned restarts were
+still scored as crashes. (The other half of v5.1.5 — not counting
+benign log lines as errors — was unaffected and has been working.)
+
+This release makes the read path preserve the flag, so a planned
+restart is now genuinely treated as a clean exit. The state-parsing
+logic was pulled into a tested pure function so the read-back round
+trip can't silently regress like this again.
+
+### What this means for you
+
+If you updated to 5.1.5 and still saw the crash count tick up by one
+each time the bot updated itself, that stops now. The error-trend
+half of the 5.1.5 fix already worked; this completes the crash half.
+
 ## [5.1.5] — 2026-05-15
 
 ### Health monitor no longer cries wolf about its own log lines

package/dist/services/watchdog-brake.js

@@ -27,6 +27,45 @@ export const DEFAULTS = {
      *  crashes with ≥5 min gaps sailed right past the brake. 1 h is safer. */
     RESET_AFTER_MS: 60 * 60_000,
 };
+/**
+ * Validate + normalize a parsed beacon JSON into a BeaconData (or null
+ * if the core fields are missing/wrong-typed). Pure so the read-path
+ * field mapping is unit-testable — extracted after v5.1.5 shipped a
+ * broken expectedRestart: the old readBeacon() rebuilt the object
+ * field-by-field and silently dropped expectedRestart, so the flag
+ * never reached decideBrakeAction and intentional restarts were still
+ * counted as crashes. Whatever round-trips here is what the brake sees.
+ */
+export function normalizeBeacon(parsed) {
+    if (!parsed)
+        return null;
+    if (typeof parsed.lastBeat === "number" &&
+        typeof parsed.pid === "number" &&
+        typeof parsed.bootTime === "number" &&
+        typeof parsed.crashCount === "number" &&
+        typeof parsed.crashWindowStart === "number" &&
+        typeof parsed.version === "string") {
+        return {
+            lastBeat: parsed.lastBeat,
+            pid: parsed.pid,
+            bootTime: parsed.bootTime,
+            crashCount: parsed.crashCount,
+            crashWindowStart: parsed.crashWindowStart,
+            version: parsed.version,
+            // Older beacons don't have daily-counter fields — default them to
+            // 0/now so the brake logic treats this run as the start of the
+            // first daily window.
+            dailyCrashCount: typeof parsed.dailyCrashCount === "number" ? parsed.dailyCrashCount : 0,
+            dailyCrashWindowStart: typeof parsed.dailyCrashWindowStart === "number"
+                ? parsed.dailyCrashWindowStart
+                : Date.now(),
+            // The whole point of the v5.1.6 fix: propagate expectedRestart so
+            // a planned restart is not scored as a crash on the next boot.
+            expectedRestart: parsed.expectedRestart === true,
+        };
+    }
+    return null;
+}
 /**
  * Given the previous beacon (or null on first boot) and the current time,
  * decide whether the bot should proceed with boot or engage the crash-loop

package/dist/services/watchdog.js

@@ -29,7 +29,7 @@ import { execSync } from "child_process";
 import { BOT_VERSION } from "../version.js";
 import { emitCritical } from "./critical-notify.js";
 import { writeDiagnosticBundle } from "./auto-diagnostic.js";
-import { decideBrakeAction, shouldResetCrashCounter, DEFAULTS, } from "./watchdog-brake.js";
+import { decideBrakeAction, shouldResetCrashCounter, normalizeBeacon, DEFAULTS, } from "./watchdog-brake.js";
 const DATA_DIR = process.env.ALVIN_DATA_DIR || resolve(os.homedir(), ".alvin-bot");
 const STATE_DIR = resolve(DATA_DIR, "state");
 const BEACON_FILE = resolve(STATE_DIR, "watchdog.json");
@@ -50,30 +50,7 @@ function ensureStateDir() {
 function readBeacon() {
     try {
         const raw = fs.readFileSync(BEACON_FILE, "utf-8");
-        const parsed = JSON.parse(raw);
-        if (typeof parsed.lastBeat === "number" &&
-            typeof parsed.pid === "number" &&
-            typeof parsed.bootTime === "number" &&
-            typeof parsed.crashCount === "number" &&
-            typeof parsed.crashWindowStart === "number" &&
-            typeof parsed.version === "string") {
-            // Older beacons don't have daily-counter fields — default them to
-            // 0/now so the brake logic treats this run as the start of the
-            // first daily window.
-            return {
-                lastBeat: parsed.lastBeat,
-                pid: parsed.pid,
-                bootTime: parsed.bootTime,
-                crashCount: parsed.crashCount,
-                crashWindowStart: parsed.crashWindowStart,
-                version: parsed.version,
-                dailyCrashCount: typeof parsed.dailyCrashCount === "number" ? parsed.dailyCrashCount : 0,
-                dailyCrashWindowStart: typeof parsed.dailyCrashWindowStart === "number"
-                    ? parsed.dailyCrashWindowStart
-                    : Date.now(),
-            };
-        }
-        return null;
+        return normalizeBeacon(JSON.parse(raw));
     }
     catch {
         return null;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "alvin-bot",
-  "version": "5.1.5",
+  "version": "5.1.6",
   "description": "Alvin Bot — Your personal AI agent on Telegram, WhatsApp, Discord, Signal, and Web.",
   "type": "module",
   "main": "dist/index.js",