alvin-bot 4.8.3 → 4.8.4

package/CHANGELOG.md

@@ -2,6 +2,46 @@
 
 All notable changes to Alvin Bot are documented here.
 
+## [4.8.4] — 2026-04-11
+
+### 🐛 WhatsApp self-chat detection for the new `@lid` identity format
+
+Ali reported that the WhatsApp bot wasn't responding to "Hi" in his self-chat even after enabling both `Self-chat only` and `Reply to private messages` in the Web UI. Debug logging showed the bot receiving the message correctly and detecting `fromMe=true`, but then hitting the "skip: own message in group/DM" branch because `isSelfChat()` was returning `false`.
+
+**Root cause**: WhatsApp has rolled out a new privacy feature that replaces phone-number JIDs in self-chats (and some groups) with a **LID — Linked Identity**. Instead of `4917661236656@s.whatsapp.net`, messages in a self-chat now arrive with `jid = "162805718225143@lid"` — a completely opaque identifier that looks nothing like the phone number.
+
+Our `isSelfChat(jid)` compared the incoming JID against `sock.user.id` (the traditional phone-number format `4917661236656:22@s.whatsapp.net`), stripped the device suffix, and compared the bare numbers. But the LID has a completely different number (`162805718225143`), so the match failed and every self-chat message fell through to the "own message in DM" skip branch.
+
+**Fix**: `isSelfChat()` now checks **both** identity formats:
+
+- **Traditional phone JID** via `sock.user.id` (legacy path, still matches on older WhatsApp clients)
+- **LID** via `sock.user.lid` (baileys ≥ 6.7 exposes this) with `@lid` suffix matching
+
+Either match wins. The check short-circuits on groups (`@g.us`) so the new code never misclassifies a group as self-chat.
+
+Caught on the Mac mini production bot after midnight — WhatsApp connected, QR scanned, user sending "Hi", bot silent. Debug logging revealed the actual incoming JID (`162805718225143@lid`) which immediately pointed at the LID format as the culprit.
+
+### 🧹 Dual-bot session collision (root cause of WhatsApp reconnect flapping)
+
+While debugging the `@lid` issue above, the test revealed a deeper problem: two `node dist/index.js` processes were running simultaneously on the Mac mini (PID 47744 from an earlier `launchctl kickstart` that didn't cleanly kill the old instance, plus PID 49153 from a new `launchd install`). Both processes were trying to hold the same WhatsApp Multi-Device session at the same time, causing:
+
+- WhatsApp `Reconnecting in 3s` every few seconds (each process would claim the session, the other would be kicked)
+- Baileys `Closing session` dumps to the log
+- Signal session state corruption → "Warte auf diese Nachricht" (waiting-to-decrypt) messages appearing spontaneously in the self-chat
+
+**Short-term workaround**: explicit `pkill -9 -f 'node.*alvin-bot/dist/index'` before `launchctl kickstart` to ensure only one process is running.
+
+**Session wipe procedure** (when the corruption is already baked in):
+
+1. `launchctl unload -w ~/Library/LaunchAgents/com.alvinbot.app.plist`
+2. `pkill -9 -f "node.*alvin-bot/dist/index"`
+3. `rm -rf ~/.alvin-bot/data/whatsapp-auth`
+4. Remove the zombie linked-device from your phone (iPhone Settings → Linked Devices → remove all "Alvin Bot" entries)
+5. `launchctl load -w ~/Library/LaunchAgents/com.alvinbot.app.plist`
+6. Re-scan the QR code
+
+A future release should add a proper `alvin-bot wa reset` command to automate this and a startup check that refuses to boot if another instance is already running.
+
 ## [4.8.3] — 2026-04-11
 
 ### 🐛 Critical: Claude SDK heartbeat false-positive "unavailable"

package/dist/platforms/whatsapp.js

@@ -536,10 +536,38 @@ export class WhatsAppAdapter {
         await this.handler(incoming);
     }
     isSelfChat(jid) {
-        const myJid = this.sock?.user?.id;
-        if (!myJid)
+        if (!this.sock?.user)
             return false;
-        return normalizeJid(jid) === normalizeJid(myJid);
+        // Groups are never self-chat regardless of which identity format
+        // the group uses.
+        if (jid.endsWith("@g.us"))
+            return false;
+        // WhatsApp has two identity formats that can appear in self-chat:
+        //   1. Traditional phone-number JID: 49176...:22@s.whatsapp.net
+        //   2. LID (linked identity): 162805718...@lid — privacy feature
+        //      added in 2024 that hides the real phone number in self-chats
+        //      and some groups. Baileys exposes this as sock.user.lid.
+        //
+        // Check both so self-chat detection works regardless of which
+        // format WhatsApp chose to tag the chat with today.
+        const user = this.sock.user;
+        const myId = user.id;
+        const myLid = user.lid;
+        // Match against phone-number JID (traditional path)
+        if (myId) {
+            const myNumber = jidToNumber(myId);
+            const jidNumber = jidToNumber(jid);
+            if (myNumber && jidNumber && myNumber === jidNumber)
+                return true;
+        }
+        // Match against LID (new privacy format)
+        if (myLid && jid.endsWith("@lid")) {
+            const myLidNum = jidToNumber(myLid);
+            const jidLidNum = jidToNumber(jid);
+            if (myLidNum && jidLidNum && myLidNum === jidLidNum)
+                return true;
+        }
+        return false;
     }
     // ── Public API: Groups ────────────────────────────────────────────────────
     async getGroups() {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "alvin-bot",
-  "version": "4.8.3",
+  "version": "4.8.4",
   "description": "Alvin Bot — Your personal AI agent on Telegram, WhatsApp, Discord, Signal, and Web.",
   "type": "module",
   "main": "dist/index.js",