alvin-bot 4.5.0 → 4.5.1

package/CHANGELOG.md

@@ -2,6 +2,26 @@
 
 All notable changes to Alvin Bot are documented here.
 
+## [4.5.1] — 2026-04-09
+
+### 🐛 TUI Header Rendering Hotfix
+
+**The header was appearing inline in the middle of the conversation after scrolling** — a follow-up bug to the 4.5.0 TUI fix. Reported from a live 4.5.0 Test MacBook session where the header popped up right after a long bot response.
+
+**Root cause**: `redrawHeader()` in 4.5.0 used `\x1b[H` (move to top-left) + `\x1b[s`/`\x1b[u` (save/restore cursor) to update the header in place when cost/model/target changed. But `\x1b[H` resolves to the **current viewport top**, not the document top — and once the terminal has scrolled past the original header, the "viewport top" is somewhere in the middle of the conversation. So the header got re-rendered inline in the middle of the bot's output.
+
+**Fix**: removed all `redrawHeader()` calls from mid-session code paths:
+- `ws.on("open")` (connect): no redraw, header was already drawn at startup
+- `ws.on("close")` (disconnect): no redraw, just the error message
+- `case "done"` (after each bot response): no redraw (this was the primary bug site — it fired after every message)
+- `case "model"` (model switch): no redraw, just a success info line
+- `case "target tui|telegram"` (target switch): no redraw, just an info line
+- `process.stdout.on("resize")`: no redraw, just re-renders the prompt line
+
+The only remaining `redrawHeader()` call is inside `/clear`, which calls `console.clear()` first to wipe the whole buffer — the only context where an in-place redraw is safe.
+
+The trade-off: the header no longer reflects live cost/model/target updates mid-session. You'll see the up-to-date values after the next `/clear` or on the next TUI start. In exchange, the conversation flow stays clean. A future release could add a proper status-line region using terminal scrolling regions if this becomes annoying.
+
 ## [4.5.0] — 2026-04-09
 
 ### 🐛 TUI Bug Fixes (critical — the old TUI was effectively unusable)

package/dist/tui/index.js

@@ -105,27 +105,25 @@ function drawHeader() {
     console.log(`${C.gray}${"─".repeat(w)}${C.reset}`);
 }
 /**
- * Redraw the header in place. Only safe to call when NOT streaming —
- * the previous implementation used aggressive cursor save/restore escape
- * sequences that collided with readline's internal cursor state and
- * produced garbled output. Now this is a no-op during streaming and
- * a clean redraw otherwise.
+ * Redraw the header. The old "in-place" implementation used cursor save/
+ * restore escape sequences and jumped to \x1b[H — but once the terminal
+ * has scrolled past the original header, \x1b[H resolves to the current
+ * viewport top (not the document top), which means the header gets
+ * re-rendered inline in the middle of the content. That's what produced
+ * the "header appears in the middle of the bot response" bug in 4.5.0.
+ *
+ * The only safe way to redraw the header in a scrolling terminal is to
+ * clear the whole screen and redraw from scratch. Do that only in
+ * explicit reset contexts (/clear, SIGWINCH resize, initial connect).
+ * For mid-session cost/status updates, use inline info messages instead.
  */
-function redrawHeader() {
+function redrawHeader(opts = {}) {
     if (isStreaming)
-        return; // Don't touch the cursor mid-stream
-    clearCurrentLine();
-    process.stdout.write("\x1b[s"); // Save cursor
-    process.stdout.write("\x1b[H"); // Move to top-left
-    for (let i = 0; i < HEADER_LINES; i++) {
-        cursorTo(process.stdout, 0);
-        rlClearLine(process.stdout, 0);
-        if (i < HEADER_LINES - 1)
-            process.stdout.write("\x1b[1B");
+        return;
+    if (opts.clearScreen) {
+        console.clear();
     }
-    process.stdout.write("\x1b[H");
     drawHeader();
-    process.stdout.write("\x1b[u"); // Restore cursor
     if (rl && !isStreaming)
         rl.prompt(true);
 }
@@ -222,7 +220,8 @@ function connectWebSocket() {
     ws = new WebSocket(wsUrl);
     ws.on("open", () => {
         connected = true;
-        redrawHeader();
+        // No header redraw here — the header was already drawn at startTUI().
+        // Calling redrawHeader() in a scrolled terminal re-renders it inline.
         printInfo(t("tui.connectedTo"));
         showPrompt();
     });
@@ -236,7 +235,7 @@ function connectWebSocket() {
     ws.on("close", () => {
         connected = false;
         isStreaming = false;
-        redrawHeader();
+        // No header redraw — it would appear inline mid-chat.
         printError(t("tui.connectionLost"));
         setTimeout(connectWebSocket, 3000);
     });
@@ -279,7 +278,10 @@ function handleMessage(msg) {
             isStreaming = false;
             currentResponse = "";
             currentToolName = "";
-            redrawHeader(); // Update cost in header (only if not streaming — see redrawHeader)
+            // NOTE: do NOT call redrawHeader() here. On a scrolled terminal it
+            // renders the header inline at the viewport top, which looks like
+            // the header appeared in the middle of the conversation. The total
+            // cost is already shown inline at the end of each response.
             showPrompt();
             break;
         case "error":
@@ -395,7 +397,8 @@ async function handleCommand(cmd) {
                     if (res.ok) {
                         currentModel = res.active || parts[1];
                         printSuccess(`${t("tui.switchedTo")}: ${currentModel}`);
-                        redrawHeader();
+                        // Header stays as-is (would appear inline otherwise) —
+                        // next /clear redraws it with the new model.
                     }
                     else {
                         printError(res.error || t("tui.switchError"));
@@ -508,10 +511,15 @@ async function handleCommand(cmd) {
         }
         case "clear":
         case "c":
-            console.clear();
-            drawHeader();
+            // /clear is the ONLY command that safely redraws the header, because
+            // it wipes the entire screen first.
+            redrawHeader({ clearScreen: true });
             if (ws?.readyState === WebSocket.OPEN) {
-                ws.send(JSON.stringify({ type: "reset" }));
+                ws.send(JSON.stringify({
+                    type: "reset",
+                    target: activeTarget,
+                    sessionKey: activeTarget === "tui" ? tuiSessionKey : undefined,
+                }));
             }
             break;
         case "target":
@@ -520,12 +528,10 @@ async function handleCommand(cmd) {
             if (val === "tui") {
                 activeTarget = "tui";
                 printSuccess("Target: TUI (your own isolated session)");
-                redrawHeader();
             }
             else if (val === "telegram" || val === "tel") {
                 activeTarget = "telegram";
                 printSuccess("Target: Telegram (your messages now go into the Telegram session — the bot replies in Telegram AND here)");
-                redrawHeader();
             }
             else {
                 printInfo(`Current target: ${activeTarget}. Use /target tui or /target telegram.`);
@@ -639,12 +645,12 @@ export async function startTUI() {
     // mode on top of that causes every keystroke to be echoed TWICE (once by
     // the terminal, once by readline's line editor) — producing the classic
     // "hheelllloo" double-echo bug. Let readline manage the tty mode itself.
-    // Handle terminal resize — redraw header to fit the new width.
+    // Handle terminal resize — we can't safely redraw the header in place
+    // on a scrolled buffer. Just re-render the prompt so readline picks up
+    // the new width for its line editor.
     process.stdout.on("resize", () => {
-        if (!isStreaming) {
-            redrawHeader();
+        if (!isStreaming)
             showPrompt();
-        }
     });
     await fetchInitialModel();
     connectWebSocket();

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "alvin-bot",
-  "version": "4.5.0",
+  "version": "4.5.1",
   "description": "Alvin Bot — Your personal AI agent on Telegram, WhatsApp, Discord, Signal, and Web.",
   "type": "module",
   "main": "dist/index.js",