alvin-bot 4.4.2 → 4.4.3

package/CHANGELOG.md

@@ -2,6 +2,17 @@
 
 All notable changes to Alvin Bot are documented here.
 
+## [4.4.3] — 2026-04-09
+
+### 🔐 Security
+- **Sudo password storage** — Fixed a vulnerability where the sudo password was passed to `/usr/bin/security` as a command-line argument, making it briefly visible in `ps aux` output during keychain writes. Password is now piped via stdin using the documented `-w` prompt mode (must be the last option, and the password is supplied twice for the interactive prompt + confirmation). Byte-exact round-trip verified for arbitrary special characters.
+
+### 🛠 Providers
+- **Gemini auto-registration narrowed** — The Google Gemini chat provider is no longer registered automatically just because `GOOGLE_API_KEY` is set. It is now registered only when `google` is referenced as the primary provider or in the fallback chain. The environment variable is still used for other Google-powered features (e.g. `/imagine` image generation) without forcing Gemini onto the chat provider list.
+
+### 🧰 Tooling
+- `package-lock.json` now tracks `package.json` version correctly.
+
 ## [2.2.0] — 2026-02-24
 
 ### 🔐 Security

package/dist/providers/registry.js

@@ -185,12 +185,13 @@ export function createRegistry(config) {
             model: "claude-opus-4-6",
         };
     }
-    // Auto-register Google Gemini (single model) if key is available
-    if (config.apiKeys?.google) {
+    // Register Google Gemini only if explicitly referenced as primary/fallback
+    // (GOOGLE_API_KEY is also used for image generation — doesn't mean Gemini should be a chat provider)
+    if (config.primary === "google" || config.fallbacks?.includes("google")) {
         providers["google"] = {
             ...PROVIDER_PRESETS["gemini-2.5-flash"],
             name: "Google Gemini",
-            apiKey: config.apiKeys.google,
+            apiKey: config.apiKeys?.google,
         };
     }
     // Always try to detect local Ollama

package/dist/services/sudo.js

@@ -11,7 +11,7 @@
  * - OS dialog handling (Accessibility, Full Disk Access, etc.)
  * - Status check (is sudo configured? does it work?)
  */
-import { execSync, spawn } from "child_process";
+import { execSync, spawn, spawnSync } from "child_process";
 import os from "os";
 import fs from "fs";
 import crypto from "crypto";
@@ -34,7 +34,33 @@ export function storePassword(password) {
                 execSync(`security delete-generic-password -a "${KEYCHAIN_ACCOUNT}" -s "${KEYCHAIN_SERVICE}" 2>/dev/null`, { stdio: "pipe" });
             }
             catch { /* didn't exist */ }
-            execSync(`security add-generic-password -a "${KEYCHAIN_ACCOUNT}" -s "${KEYCHAIN_SERVICE}" -w "${password.replace(/"/g, '\\"')}" -U`, { stdio: "pipe", timeout: 5000 });
+            // Pipe password via stdin — NEVER pass it as an argv element,
+            // or it leaks into `ps aux` during the lifetime of the child process.
+            //
+            // From `man security`:
+            //   "Use of the -p or -w options is insecure. Specify -w as the last
+            //    option to be prompted."
+            //
+            // Requirements for this to work:
+            //   1. `-w` must be the LAST argument (otherwise security consumes
+            //      the next argv element as the password).
+            //   2. The password must be written to stdin TWICE: once for the
+            //      prompt, once for the "retype password" confirmation.
+            const result = spawnSync("security", [
+                "add-generic-password",
+                "-a", KEYCHAIN_ACCOUNT,
+                "-s", KEYCHAIN_SERVICE,
+                "-U",
+                "-w", // MUST be last — triggers interactive prompt reading from stdin
+            ], {
+                input: password + "\n" + password + "\n", // prompt + confirm
+                stdio: ["pipe", "pipe", "pipe"],
+                timeout: 5000,
+            });
+            if (result.status !== 0) {
+                const stderr = result.stderr?.toString().trim() || `exit ${result.status}`;
+                throw new Error(stderr);
+            }
             return { ok: true, method: "macOS Keychain" };
         }
         else {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "alvin-bot",
-  "version": "4.4.2",
+  "version": "4.4.3",
   "description": "Alvin Bot — Your personal AI agent on Telegram, WhatsApp, Discord, Signal, and Web.",
   "type": "module",
   "main": "dist/index.js",