alvin-bot 4.14.0 → 4.14.1

package/CHANGELOG.md

@@ -2,6 +2,40 @@
 
 All notable changes to Alvin Bot are documented here.
 
+## [4.14.1] — 2026-04-16
+
+### 🐛 Patch: `/subagents list` now shows v4.13+ dispatch agents too
+
+**Bug Ali caught:** typing `/subagents list` in Telegram while a `alvin_dispatch_agent` sub-agent was actively running returned "no agents running" — even though the user could see the agent finish and deliver a result shortly after. Cross-platform effect too: `/alvin` slash command on Slack had the same display gap.
+
+**Root cause:** two separate registries for sub-agents:
+- `src/services/subagents.ts` `activeAgents` Map — used since v4.0.0 for bot-level sub-agents (cron spawns, implicit Task tool children, `/sub-agents spawn` CLI)
+- `src/services/async-agent-watcher.ts` `pending` Map — used since v4.13 for detached `alvin_dispatch_agent` subprocesses
+
+`/subagents list` only read from the first map. The entire v4.13+ dispatch path was invisible in the listing.
+
+**Fix:** new `listActiveSubAgents()` helper in subagents.ts that merges both registries. Pending async-agent-watcher entries get synthesized into `SubAgentInfo` shape (status="running", source="cron", depth=0, platform preserved). The `/subagents list` handler and the default-render path both switch to the merged helper. The old `listSubAgents()` function stays pure (unchanged behavior) — cancel/result paths still use it because detached subprocess PIDs aren't tracked.
+
+### Technical details
+
+- `listActiveSubAgents()` is async (lazy dynamic import of the watcher module to keep subagents.ts load order clean) — existing `listSubAgents()` remains sync for the v4.0.0 consumers
+- Synthesis mapping: `PendingAsyncAgent.agentId → SubAgentInfo.id`, `description → name`, `startedAt → startedAt`, always `status="running"` (pending by definition), `source="cron"` (matches watcher's delivery banner), `depth=0`
+- Platform field preserved so the renderer can show cross-platform context if desired later
+
+### Testing
+
+- **Baseline**: 492 tests (v4.14.0)
+- **New**: `test/list-subagents-merged.test.ts` — 6 tests (empty state, single slack agent, multi-platform merge, timestamp preservation, source tag, listSubAgents purity guard)
+- **Total**: 498 tests, all green, TSC clean
+
+### Files changed
+
+- **Modified**: `src/services/subagents.ts` (new listActiveSubAgents helper), `src/handlers/commands.ts` (both /subagents list paths switch to merged view)
+- **NEW tests**: `test/list-subagents-merged.test.ts`
+- **Version**: `package.json` 4.14.0 → 4.14.1
+
+---
+
 ## [4.14.0] — 2026-04-16
 
 ### ✨ Sub-agent dispatch on Slack, Discord, WhatsApp (Telegram unchanged)

package/dist/handlers/commands.js

@@ -1910,7 +1910,7 @@ export function registerCommands(bot) {
     // type both "/sub-agents" and "/subagents" — Telegram routes both to this.
     bot.command(["sub_agents", "subagents"], async (ctx) => {
         const lang = getSession(ctx.from.id).language;
-        const { listSubAgents, cancelSubAgent, getSubAgentResult, getMaxParallelAgents, getConfiguredMaxParallel, setMaxParallelAgents, findSubAgentByName, getVisibility, setVisibility, getQueueCap, setQueueCap, getDefaultTimeoutMs, setDefaultTimeoutMs, } = await import("../services/subagents.js");
+        const { listSubAgents, listActiveSubAgents, cancelSubAgent, getSubAgentResult, getMaxParallelAgents, getConfiguredMaxParallel, setMaxParallelAgents, findSubAgentByName, getVisibility, setVisibility, getQueueCap, setQueueCap, getDefaultTimeoutMs, setDefaultTimeoutMs, } = await import("../services/subagents.js");
         const arg = (ctx.match || "").trim();
         const tokens = arg.split(/\s+/).filter(Boolean);
         const sub = tokens[0]?.toLowerCase() || "";
@@ -2040,8 +2040,10 @@ export function registerCommands(bot) {
             return;
         }
         // /sub-agents list  — same rendering as the default, but forced
+        // v4.14.1 — uses listActiveSubAgents (merged view) so v4.13+
+        // alvin_dispatch_agent detached subprocesses also show up here.
         if (sub === "list") {
-            const agents = listSubAgents();
+            const agents = await listActiveSubAgents();
             if (agents.length === 0) {
                 await ctx.reply(t("bot.subagents.noneRunning", lang));
                 return;
@@ -2142,7 +2144,8 @@ export function registerCommands(bot) {
         const timeoutLabel = currentTimeout <= 0
             ? `⏱ Timeout: *∞ (unlimited)*`
             : `⏱ Timeout: *${Math.round(currentTimeout / 1000)}s*`;
-        const agents = listSubAgents();
+        // v4.14.1 — merged view incl. v4.13+ alvin_dispatch_agent agents.
+        const agents = await listActiveSubAgents();
         let body = "";
         if (agents.length === 0) {
             body = `\n${t("bot.subagents.noneRunning", lang)}`;

package/dist/services/subagents.js

@@ -576,10 +576,69 @@ export function spawnSubAgent(agentConfig) {
 }
 /**
  * List all agents (active + recent completed).
+ *
+ * This is the v4.0.0 API — shows only agents from the bot-level
+ * registry (activeAgents Map). Does NOT include v4.13+ detached
+ * `alvin_dispatch_agent` subprocesses which live in async-agent-
+ * watcher. For the merged view used by `/subagents list`, use
+ * `listActiveSubAgents()` instead.
  */
 export function listSubAgents() {
     return [...activeAgents.values()].map((a) => ({ ...a.info }));
 }
+/**
+ * v4.14.1 — Merged view of BOTH sub-agent registries:
+ *   1. Bot-level agents (subagents.ts activeAgents Map) — v4.0.0+
+ *      the /sub-agents spawn CLI, cron-spawned sub-agents, implicit
+ *      Task-tool children.
+ *   2. Detached `alvin_dispatch_agent` subprocesses (async-agent-
+ *      watcher pending Map) — v4.13+ the MCP-tool-dispatched
+ *      agents that survive parent aborts.
+ *
+ * The user doesn't care which registry an agent lives in — "is there
+ * anything running right now?" is the question `/subagents list`
+ * answers. This function unifies the view.
+ *
+ * Pending async agents are synthesized into SubAgentInfo shape:
+ *   - id: PendingAsyncAgent.agentId (alvin-prefixed hex)
+ *   - name: PendingAsyncAgent.description
+ *   - status: "running" (we wouldn't be pending otherwise)
+ *   - startedAt: PendingAsyncAgent.startedAt
+ *   - source: "cron" — matches the delivery banner's source tag
+ *   - depth: 0 — dispatch agents are always top-level (no nesting)
+ *   - platform: preserved from the pending entry
+ *   - parentChatId: from the pending entry
+ *
+ * Lazy import of the watcher keeps this function cheap for callers
+ * who only need the v4.0.0 view (importing the watcher pulls in its
+ * whole startup cost otherwise).
+ */
+export async function listActiveSubAgents() {
+    const botLevel = listSubAgents();
+    let pending = [];
+    try {
+        // Lazy dynamic import so this module doesn't depend on the watcher
+        // at load time (preserves test isolation + avoids a circular boot).
+        const watcher = await import("./async-agent-watcher.js");
+        if (typeof watcher.listPendingAgents === "function") {
+            const raw = watcher.listPendingAgents();
+            pending = raw.map((p) => ({
+                id: p.agentId,
+                name: p.description,
+                status: "running",
+                startedAt: p.startedAt,
+                source: "cron",
+                depth: 0,
+                platform: p.platform,
+                parentChatId: p.chatId,
+            }));
+        }
+    }
+    catch {
+        /* never break listing because of merge errors */
+    }
+    return [...botLevel, ...pending];
+}
 /**
  * Cancel a running sub-agent by ID.
  * Returns true if the agent was found and aborted.

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "alvin-bot",
-  "version": "4.14.0",
+  "version": "4.14.1",
   "description": "Alvin Bot \u2014 Your personal AI agent on Telegram, WhatsApp, Discord, Signal, and Web.",
   "type": "module",
   "main": "dist/index.js",

package/test/list-subagents-merged.test.ts

@@ -0,0 +1,172 @@
+/**
+ * v4.14.1 — `/subagents list` must show v4.13+ dispatch agents too.
+ *
+ * Root cause: `listSubAgents()` in subagents.ts only iterates the
+ * `activeAgents` Map (B1+B2 from v4.0.0). v4.13's `alvin_dispatch_agent`
+ * MCP tool writes into `async-agent-watcher.ts`'s `pending` Map instead.
+ * User-facing impact: "no subagents running" while the bot is visibly
+ * dispatching sub-agents.
+ *
+ * Fix strategy: a new `listActiveSubAgents()` helper that merges both
+ * registries into a unified SubAgentInfo-shaped list. The `/subagents
+ * list` handler uses this instead of the bare `listSubAgents()`.
+ * Cancel/result operations keep using the old registry — we can't
+ * cancel a detached `claude -p` subprocess anyway without knowing its
+ * PID, which isn't tracked.
+ */
+import { describe, it, expect, beforeEach, afterEach, vi } from "vitest";
+import fs from "fs";
+import os from "os";
+import { resolve } from "path";
+
+const TEST_DATA_DIR = resolve(
+  os.tmpdir(),
+  `alvin-list-merged-${process.pid}-${Date.now()}`,
+);
+
+beforeEach(async () => {
+  if (fs.existsSync(TEST_DATA_DIR)) {
+    fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true });
+  }
+  fs.mkdirSync(TEST_DATA_DIR, { recursive: true });
+  process.env.ALVIN_DATA_DIR = TEST_DATA_DIR;
+  vi.resetModules();
+
+  vi.doMock("../src/services/subagent-delivery.js", () => ({
+    deliverSubAgentResult: async () => {},
+    attachBotApi: () => {},
+    __setBotApiForTest: () => {},
+  }));
+});
+
+afterEach(async () => {
+  try {
+    const mod = await import("../src/services/async-agent-watcher.js");
+    mod.stopWatcher();
+    mod.__resetForTest();
+  } catch {}
+});
+
+describe("listActiveSubAgents merged view (v4.14.1)", () => {
+  it("returns empty list when neither registry has agents", async () => {
+    const mod = await import("../src/services/subagents.js");
+    expect(await mod.listActiveSubAgents()).toEqual([]);
+  });
+
+  it("includes async-agent-watcher pending agents in the merged list", async () => {
+    const watcher = await import("../src/services/async-agent-watcher.js");
+    watcher.registerPendingAgent({
+      agentId: "alvin-abc123",
+      outputFile: `${TEST_DATA_DIR}/out.jsonl`,
+      description: "Research Higgsfield",
+      prompt: "...",
+      chatId: "C012SLACK",
+      userId: "U123",
+      toolUseId: null,
+      sessionKey: "slack:C012SLACK",
+      platform: "slack",
+    });
+
+    const mod = await import("../src/services/subagents.js");
+    const agents = await mod.listActiveSubAgents();
+    expect(agents).toHaveLength(1);
+    expect(agents[0].id).toBe("alvin-abc123");
+    expect(agents[0].name).toBe("Research Higgsfield");
+    expect(agents[0].status).toBe("running");
+    expect(agents[0].depth).toBe(0);
+    expect(agents[0].platform).toBe("slack");
+  });
+
+  it("merges multiple agents from both registries without dupes", async () => {
+    const watcher = await import("../src/services/async-agent-watcher.js");
+    watcher.registerPendingAgent({
+      agentId: "alvin-one",
+      outputFile: `${TEST_DATA_DIR}/a.jsonl`,
+      description: "Agent One",
+      prompt: "p",
+      chatId: 42,
+      userId: 42,
+      toolUseId: null,
+      sessionKey: "s",
+      platform: "telegram",
+    });
+    watcher.registerPendingAgent({
+      agentId: "alvin-two",
+      outputFile: `${TEST_DATA_DIR}/b.jsonl`,
+      description: "Agent Two",
+      prompt: "p",
+      chatId: 42,
+      userId: 42,
+      toolUseId: null,
+      sessionKey: "s",
+      platform: "telegram",
+    });
+
+    const mod = await import("../src/services/subagents.js");
+    const agents = await mod.listActiveSubAgents();
+    const ids = agents.map((a) => a.id).sort();
+    expect(ids).toEqual(["alvin-one", "alvin-two"]);
+  });
+
+  it("preserves startedAt timestamp for age rendering", async () => {
+    const fixedTs = Date.now() - 45_000; // 45 seconds ago
+    const watcher = await import("../src/services/async-agent-watcher.js");
+    watcher.registerPendingAgent({
+      agentId: "alvin-aged",
+      outputFile: `${TEST_DATA_DIR}/aged.jsonl`,
+      description: "Old agent",
+      prompt: "p",
+      chatId: 1,
+      userId: 1,
+      toolUseId: null,
+      sessionKey: "s",
+      platform: "slack",
+    });
+
+    const mod = await import("../src/services/subagents.js");
+    const agents = await mod.listActiveSubAgents();
+    expect(agents[0].startedAt).toBeGreaterThan(fixedTs - 1000);
+    expect(agents[0].startedAt).toBeLessThan(Date.now() + 1000);
+  });
+
+  it("tags async dispatch agents with source='cron' (matches v4.12 banner format)", async () => {
+    const watcher = await import("../src/services/async-agent-watcher.js");
+    watcher.registerPendingAgent({
+      agentId: "alvin-sourced",
+      outputFile: `${TEST_DATA_DIR}/s.jsonl`,
+      description: "sourced",
+      prompt: "p",
+      chatId: 1,
+      userId: 1,
+      toolUseId: null,
+      sessionKey: "s",
+      platform: "telegram",
+    });
+    const mod = await import("../src/services/subagents.js");
+    const agents = await mod.listActiveSubAgents();
+    // source='cron' = the ⏰ badge in /subagents list rendering. Matches
+    // the existing v4.12.x watcher delivery's SubAgentInfo.source value.
+    expect(agents[0].source).toBe("cron");
+  });
+
+  it("listSubAgents() (v4.0.0 API) is unchanged and doesn't include pending dispatches", async () => {
+    const watcher = await import("../src/services/async-agent-watcher.js");
+    watcher.registerPendingAgent({
+      agentId: "alvin-isolated",
+      outputFile: `${TEST_DATA_DIR}/iso.jsonl`,
+      description: "isolated",
+      prompt: "p",
+      chatId: 1,
+      userId: 1,
+      toolUseId: null,
+      sessionKey: "s",
+      platform: "telegram",
+    });
+    const mod = await import("../src/services/subagents.js");
+    // The original listSubAgents is kept pure — only the merged helper
+    // returns combined results. Cancel/result paths still use the
+    // bot-level registry.
+    expect(mod.listSubAgents()).toHaveLength(0);
+    expect(await mod.listActiveSubAgents()).toHaveLength(1);
+  });
+});