all-hands-cli 0.1.0
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/.allhands/README.md +75 -0
- package/.allhands/agents/compounder.yaml +15 -0
- package/.allhands/agents/coordinator.yaml +17 -0
- package/.allhands/agents/documentor.yaml +15 -0
- package/.allhands/agents/e2e-test-planner.yaml +17 -0
- package/.allhands/agents/emergent.yaml +22 -0
- package/.allhands/agents/executor.yaml +14 -0
- package/.allhands/agents/ideation.yaml +11 -0
- package/.allhands/agents/initiative-steering.yaml +19 -0
- package/.allhands/agents/judge.yaml +13 -0
- package/.allhands/agents/planner.yaml +19 -0
- package/.allhands/agents/pr-reviewer.yaml +15 -0
- package/.allhands/docs.json +5 -0
- package/.allhands/docs.local.json +26 -0
- package/.allhands/flows/COMPOUNDING.md +203 -0
- package/.allhands/flows/COORDINATION.md +89 -0
- package/.allhands/flows/CORE.md +87 -0
- package/.allhands/flows/DOCUMENTATION.md +218 -0
- package/.allhands/flows/E2E_TEST_PLAN_BUILDING.md +140 -0
- package/.allhands/flows/EMERGENT_PLANNING.md +57 -0
- package/.allhands/flows/IDEATION_SCOPING.md +154 -0
- package/.allhands/flows/INITIATIVE_STEERING.md +110 -0
- package/.allhands/flows/JUDGE_REVIEWING.md +79 -0
- package/.allhands/flows/PROMPT_TASK_EXECUTION.md +68 -0
- package/.allhands/flows/PR_REVIEWING.md +43 -0
- package/.allhands/flows/SPEC_PLANNING.md +216 -0
- package/.allhands/flows/harness/WRITING_HARNESS_FLOWS.md +27 -0
- package/.allhands/flows/harness/WRITING_HARNESS_KNOWLEDGE.md +27 -0
- package/.allhands/flows/harness/WRITING_HARNESS_ORCHESTRATION.md +27 -0
- package/.allhands/flows/harness/WRITING_HARNESS_SKILLS.md +27 -0
- package/.allhands/flows/harness/WRITING_HARNESS_TOOLS.md +27 -0
- package/.allhands/flows/harness/WRITING_HARNESS_VALIDATION_TOOLING.md +27 -0
- package/.allhands/flows/shared/CODEBASE_UNDERSTANDING.md +72 -0
- package/.allhands/flows/shared/CREATE_HARNESS_SPEC.md +48 -0
- package/.allhands/flows/shared/CREATE_SPEC.md +41 -0
- package/.allhands/flows/shared/CREATE_VALIDATION_TOOLING_SPEC.md +70 -0
- package/.allhands/flows/shared/DOCUMENTATION_DISCOVERY.md +123 -0
- package/.allhands/flows/shared/DOCUMENTATION_WRITER.md +101 -0
- package/.allhands/flows/shared/EMERGENT_REFINEMENT_ANALYSIS.md +76 -0
- package/.allhands/flows/shared/EXTERNAL_TECH_GUIDANCE.md +97 -0
- package/.allhands/flows/shared/IDEATION_CODEBASE_GROUNDING.md +49 -0
- package/.allhands/flows/shared/PLAN_DEEPENING.md +152 -0
- package/.allhands/flows/shared/PROMPT_TASKS_CURATION.md +113 -0
- package/.allhands/flows/shared/PROMPT_VALIDATION_REVIEW.MD +99 -0
- package/.allhands/flows/shared/QUICK_PREMORTEM.md +70 -0
- package/.allhands/flows/shared/RESEARCH_GUIDANCE.md +38 -0
- package/.allhands/flows/shared/REVIEW_OPTIONS_BREAKDOWN.md +68 -0
- package/.allhands/flows/shared/SKILL_EXTRACTION.md +84 -0
- package/.allhands/flows/shared/SPEC_FLOW_ANALYSIS.md +119 -0
- package/.allhands/flows/shared/TDD_WORKFLOW.md +109 -0
- package/.allhands/flows/shared/UTILIZE_VALIDATION_TOOLING.md +84 -0
- package/.allhands/flows/shared/WRITING_HARNESS_FLOWS.md +11 -0
- package/.allhands/flows/shared/WRITING_HARNESS_MCP_TOOLS.md +84 -0
- package/.allhands/flows/shared/jury/ARCHITECTURE_REVIEW.md +91 -0
- package/.allhands/flows/shared/jury/BEST_PRACTICES_REVIEW.md +80 -0
- package/.allhands/flows/shared/jury/CLAIM_VERIFICATION_REVIEW.md +101 -0
- package/.allhands/flows/shared/jury/EXPECTATIONS_FIT_REVIEW.md +78 -0
- package/.allhands/flows/shared/jury/MAINTAINABILITY_REVIEW.md +110 -0
- package/.allhands/flows/shared/jury/PROMPTS_EXPECTATIONS_FIT.md +74 -0
- package/.allhands/flows/shared/jury/PROMPTS_FLOW_ANALYSIS.md +92 -0
- package/.allhands/flows/shared/jury/PROMPTS_YAGNI.md +78 -0
- package/.allhands/flows/shared/jury/PROMPT_PREMORTEM.md +125 -0
- package/.allhands/flows/shared/jury/SECURITY_REVIEW.md +86 -0
- package/.allhands/flows/shared/jury/YAGNI_REVIEW.md +82 -0
- package/.allhands/flows/wip/DEBUG_INVESTIGATION.md +162 -0
- package/.allhands/flows/wip/MEMORY_RECALL.md +62 -0
- package/.allhands/harness/ah +131 -0
- package/.allhands/harness/package-lock.json +5292 -0
- package/.allhands/harness/package.json +52 -0
- package/.allhands/harness/src/__tests__/e2e/commands.test.ts +307 -0
- package/.allhands/harness/src/__tests__/e2e/event-loop.test.ts +539 -0
- package/.allhands/harness/src/__tests__/e2e/hooks.test.ts +427 -0
- package/.allhands/harness/src/__tests__/e2e/new-initiative-routing.test.ts +137 -0
- package/.allhands/harness/src/__tests__/e2e/run-e2e.ts +109 -0
- package/.allhands/harness/src/__tests__/e2e/specs-type.test.ts +210 -0
- package/.allhands/harness/src/__tests__/e2e/validation-hooks.test.ts +669 -0
- package/.allhands/harness/src/__tests__/e2e/validation-path-consistency.test.ts +354 -0
- package/.allhands/harness/src/__tests__/e2e/validation.test.ts +528 -0
- package/.allhands/harness/src/__tests__/harness/assertions.ts +318 -0
- package/.allhands/harness/src/__tests__/harness/cli-runner.ts +359 -0
- package/.allhands/harness/src/__tests__/harness/fixture.ts +384 -0
- package/.allhands/harness/src/__tests__/harness/hook-runner.ts +411 -0
- package/.allhands/harness/src/__tests__/harness/index.ts +122 -0
- package/.allhands/harness/src/cli.ts +36 -0
- package/.allhands/harness/src/commands/complexity.ts +177 -0
- package/.allhands/harness/src/commands/context7.ts +202 -0
- package/.allhands/harness/src/commands/docs.ts +557 -0
- package/.allhands/harness/src/commands/hooks.ts +24 -0
- package/.allhands/harness/src/commands/index.ts +51 -0
- package/.allhands/harness/src/commands/knowledge.ts +382 -0
- package/.allhands/harness/src/commands/memories.ts +302 -0
- package/.allhands/harness/src/commands/notify.ts +61 -0
- package/.allhands/harness/src/commands/oracle.ts +158 -0
- package/.allhands/harness/src/commands/perplexity.ts +220 -0
- package/.allhands/harness/src/commands/planning.ts +245 -0
- package/.allhands/harness/src/commands/schema.ts +73 -0
- package/.allhands/harness/src/commands/skills.ts +128 -0
- package/.allhands/harness/src/commands/solutions.ts +353 -0
- package/.allhands/harness/src/commands/spawn.ts +158 -0
- package/.allhands/harness/src/commands/specs.ts +532 -0
- package/.allhands/harness/src/commands/tavily.ts +226 -0
- package/.allhands/harness/src/commands/tools.ts +579 -0
- package/.allhands/harness/src/commands/trace.ts +327 -0
- package/.allhands/harness/src/commands/tui.ts +960 -0
- package/.allhands/harness/src/commands/validate.ts +143 -0
- package/.allhands/harness/src/commands/validation-tools.ts +108 -0
- package/.allhands/harness/src/hooks/context.ts +1442 -0
- package/.allhands/harness/src/hooks/enforcement.ts +170 -0
- package/.allhands/harness/src/hooks/index.ts +54 -0
- package/.allhands/harness/src/hooks/lifecycle.ts +229 -0
- package/.allhands/harness/src/hooks/notification.ts +104 -0
- package/.allhands/harness/src/hooks/observability.ts +551 -0
- package/.allhands/harness/src/hooks/session.ts +88 -0
- package/.allhands/harness/src/hooks/shared.ts +815 -0
- package/.allhands/harness/src/hooks/transcript-parser.ts +208 -0
- package/.allhands/harness/src/hooks/validation.ts +617 -0
- package/.allhands/harness/src/lib/__tests__/ctags.test.ts +244 -0
- package/.allhands/harness/src/lib/__tests__/docs-validation.test.ts +344 -0
- package/.allhands/harness/src/lib/__tests__/mcp-runtime.test.ts +190 -0
- package/.allhands/harness/src/lib/__tests__/schema.test.ts +861 -0
- package/.allhands/harness/src/lib/base-command.ts +198 -0
- package/.allhands/harness/src/lib/cli-daemon.ts +343 -0
- package/.allhands/harness/src/lib/compaction.ts +313 -0
- package/.allhands/harness/src/lib/ctags.ts +497 -0
- package/.allhands/harness/src/lib/docs-validation.ts +907 -0
- package/.allhands/harness/src/lib/event-loop.ts +662 -0
- package/.allhands/harness/src/lib/flows.ts +155 -0
- package/.allhands/harness/src/lib/git.ts +276 -0
- package/.allhands/harness/src/lib/knowledge-worker.ts +72 -0
- package/.allhands/harness/src/lib/knowledge.ts +810 -0
- package/.allhands/harness/src/lib/llm.ts +255 -0
- package/.allhands/harness/src/lib/mcp-client.ts +432 -0
- package/.allhands/harness/src/lib/mcp-daemon.ts +486 -0
- package/.allhands/harness/src/lib/mcp-runtime.ts +418 -0
- package/.allhands/harness/src/lib/notification.ts +115 -0
- package/.allhands/harness/src/lib/opencode/index.ts +70 -0
- package/.allhands/harness/src/lib/opencode/profiles.ts +300 -0
- package/.allhands/harness/src/lib/opencode/prompts/codesearch.md +98 -0
- package/.allhands/harness/src/lib/opencode/prompts/knowledge-aggregator.md +67 -0
- package/.allhands/harness/src/lib/opencode/runner.ts +281 -0
- package/.allhands/harness/src/lib/oracle.ts +926 -0
- package/.allhands/harness/src/lib/planning-utils.ts +150 -0
- package/.allhands/harness/src/lib/planning.ts +605 -0
- package/.allhands/harness/src/lib/pr-review.ts +225 -0
- package/.allhands/harness/src/lib/prompts.ts +522 -0
- package/.allhands/harness/src/lib/schema.ts +418 -0
- package/.allhands/harness/src/lib/schemas/agent-profile.ts +141 -0
- package/.allhands/harness/src/lib/schemas/template-vars.ts +138 -0
- package/.allhands/harness/src/lib/session.ts +164 -0
- package/.allhands/harness/src/lib/specs.ts +348 -0
- package/.allhands/harness/src/lib/tldr.ts +829 -0
- package/.allhands/harness/src/lib/tmux.ts +1051 -0
- package/.allhands/harness/src/lib/trace-store.ts +714 -0
- package/.allhands/harness/src/mcp/__tests__/index.test.ts +46 -0
- package/.allhands/harness/src/mcp/_template.ts +47 -0
- package/.allhands/harness/src/mcp/filesystem.ts +33 -0
- package/.allhands/harness/src/mcp/index.ts +69 -0
- package/.allhands/harness/src/mcp/playwright.ts +34 -0
- package/.allhands/harness/src/mcp/xcodebuild.ts +29 -0
- package/.allhands/harness/src/schemas/docs.schema.json +44 -0
- package/.allhands/harness/src/schemas/settings.schema.json +214 -0
- package/.allhands/harness/src/tui/actions.ts +227 -0
- package/.allhands/harness/src/tui/file-viewer-modal.ts +270 -0
- package/.allhands/harness/src/tui/index.ts +1574 -0
- package/.allhands/harness/src/tui/modal.ts +232 -0
- package/.allhands/harness/src/tui/prompts-pane.ts +186 -0
- package/.allhands/harness/src/tui/status-pane.ts +434 -0
- package/.allhands/harness/tsconfig.json +22 -0
- package/.allhands/harness/vitest.config.ts +13 -0
- package/.allhands/pillars.md +33 -0
- package/.allhands/principles.md +88 -0
- package/.allhands/schemas/alignment.yaml +51 -0
- package/.allhands/schemas/documentation.yaml +10 -0
- package/.allhands/schemas/prompt.yaml +92 -0
- package/.allhands/schemas/skill.yaml +34 -0
- package/.allhands/schemas/solution.yaml +131 -0
- package/.allhands/schemas/spec.yaml +67 -0
- package/.allhands/schemas/validation-suite.yaml +49 -0
- package/.allhands/schemas/workflow.yaml +51 -0
- package/.allhands/settings.json +57 -0
- package/.allhands/skills/claude-code-patterns/SKILL.md +60 -0
- package/.allhands/skills/claude-code-patterns/docs/context-hygiene.md +19 -0
- package/.allhands/skills/harness-maintenance/SKILL.md +449 -0
- package/.allhands/skills/harness-maintenance/references/core-architecture.md +187 -0
- package/.allhands/skills/harness-maintenance/references/harness-skills.md +87 -0
- package/.allhands/skills/harness-maintenance/references/knowledge-compounding.md +78 -0
- package/.allhands/skills/harness-maintenance/references/tools-commands-mcp-hooks.md +115 -0
- package/.allhands/skills/harness-maintenance/references/validation-tooling.md +77 -0
- package/.allhands/skills/harness-maintenance/references/writing-flows.md +84 -0
- package/.allhands/validation/browser-automation.md +109 -0
- package/.allhands/validation/xcode-automation.md +195 -0
- package/.allhands/workflows/documentation.md +86 -0
- package/.allhands/workflows/investigation.md +81 -0
- package/.allhands/workflows/milestone.md +91 -0
- package/.allhands/workflows/optimization.md +85 -0
- package/.allhands/workflows/refactor.md +99 -0
- package/.allhands/workflows/triage.md +81 -0
- package/.claude/README.md +1 -0
- package/.claude/agents/explorer.md +10 -0
- package/.claude/agents/researcher.md +11 -0
- package/.claude/agents/task-runner.md +8 -0
- package/.claude/settings.json +231 -0
- package/.env.ai.example +7 -0
- package/.github/workflows/npm-publish.yml +69 -0
- package/.internal.json +45 -0
- package/.tldr/config.json +11 -0
- package/.tldrignore +90 -0
- package/CLAUDE.md +6 -0
- package/README.md +98 -0
- package/bin/sync-cli.js +7552 -0
- package/concerns.md +7 -0
- package/docs/README.md +41 -0
- package/docs/agents/README.md +24 -0
- package/docs/agents/agent-configuration-system.md +86 -0
- package/docs/agents/execution-agents.md +50 -0
- package/docs/agents/knowledge-agents.md +61 -0
- package/docs/agents/orchestration-agent.md +57 -0
- package/docs/agents/planning-agents.md +84 -0
- package/docs/agents/quality-review-agents.md +67 -0
- package/docs/agents/workflow-agent-orchestration.md +69 -0
- package/docs/flows/README.md +44 -0
- package/docs/flows/compounding.md +126 -0
- package/docs/flows/coordination.md +72 -0
- package/docs/flows/core-harness-integration.md +63 -0
- package/docs/flows/documentation-orchestration.md +98 -0
- package/docs/flows/e2e-test-plan-building.md +83 -0
- package/docs/flows/emergent-refinement.md +104 -0
- package/docs/flows/flow-authoring-and-mcp-tools.md +89 -0
- package/docs/flows/judge-reviewing.md +112 -0
- package/docs/flows/plan-deepening-and-research.md +107 -0
- package/docs/flows/plan-review-jury.md +114 -0
- package/docs/flows/pr-reviewing.md +54 -0
- package/docs/flows/prompt-task-execution.md +119 -0
- package/docs/flows/spec-planning.md +162 -0
- package/docs/flows/type-specific-scoping-flows.md +49 -0
- package/docs/flows/validation-and-skills-integration.md +145 -0
- package/docs/flows/wip/wip-flows.md +102 -0
- package/docs/harness/README.md +23 -0
- package/docs/harness/agent-profiles.md +84 -0
- package/docs/harness/cli/README.md +24 -0
- package/docs/harness/cli/cli-entry-and-command-discovery.md +91 -0
- package/docs/harness/cli/docs-command.md +87 -0
- package/docs/harness/cli/knowledge-command.md +91 -0
- package/docs/harness/cli/minor-cli-commands.md +65 -0
- package/docs/harness/cli/oracle-command.md +113 -0
- package/docs/harness/cli/planning-command.md +95 -0
- package/docs/harness/cli/schema-and-validation-commands.md +154 -0
- package/docs/harness/cli/search-commands.md +97 -0
- package/docs/harness/cli/spawn-command.md +136 -0
- package/docs/harness/cli/specs-command.md +102 -0
- package/docs/harness/cli/tools-command.md +122 -0
- package/docs/harness/cli/trace-command.md +122 -0
- package/docs/harness/cli-daemon.md +92 -0
- package/docs/harness/event-loop.md +184 -0
- package/docs/harness/hooks/README.md +15 -0
- package/docs/harness/hooks/context-hooks.md +96 -0
- package/docs/harness/hooks/lifecycle-and-observability-hooks.md +135 -0
- package/docs/harness/hooks/validation-hooks.md +97 -0
- package/docs/harness/test-harness.md +149 -0
- package/docs/harness/tui.md +176 -0
- package/docs/memories.md +20 -0
- package/docs/solutions/agentic-issues/premature-agent-deletion-tui-action-dependency-20260130.md +49 -0
- package/docs/solutions/agentic-issues/ref-anchor-scope-mismatch-skill-references-20260131.md +55 -0
- package/docs/solutions/agentic-issues/tautological-tests-routing-20260131.md +52 -0
- package/docs/solutions/integration_issue/blocktool-output-format-mismatch-hook-runner-20260130.md +52 -0
- package/docs/solutions/integration_issue/dual-validation-path-divergence-schema-20260130.md +66 -0
- package/docs/solutions/security-issues/unsanitized-domain-path-join-20260131.md +52 -0
- package/docs/solutions/test-failures/event-loop-mock-ordering-checkAgentWindows-20260130.md +63 -0
- package/docs/sync-cli/README.md +19 -0
- package/docs/sync-cli/cli-entrypoint-and-commands.md +39 -0
- package/docs/sync-cli/commands/README.md +11 -0
- package/docs/sync-cli/commands/pull-manifest-command.md +36 -0
- package/docs/sync-cli/commands/push-command.md +84 -0
- package/docs/sync-cli/commands/sync-command.md +71 -0
- package/docs/sync-cli/systems/README.md +14 -0
- package/docs/sync-cli/systems/git-and-github-integration.md +49 -0
- package/docs/sync-cli/systems/interactive-ui.md +43 -0
- package/docs/sync-cli/systems/manifest-and-distribution.md +51 -0
- package/docs/sync-cli/systems/path-resolution.md +42 -0
- package/package.json +46 -0
- package/scripts/install-shim.sh +40 -0
- package/scripts/pre-pack.sh +25 -0
- package/specs/harness-maintenance-skill.spec.md +138 -0
- package/specs/roadmap/git-spec-lifecycle-management.spec.md +113 -0
- package/specs/sync-init-flag.spec.md +117 -0
- package/specs/unified-workflow-orchestration.spec.md +250 -0
- package/specs/validation-tooling-practice.spec.md +98 -0
- package/specs/workflow-domain-configuration.spec.md +265 -0
- package/src/commands/pull-manifest.ts +31 -0
- package/src/commands/push.ts +344 -0
- package/src/commands/sync.ts +289 -0
- package/src/lib/constants.ts +10 -0
- package/src/lib/dotfiles.ts +36 -0
- package/src/lib/fs-utils.ts +18 -0
- package/src/lib/gh.ts +40 -0
- package/src/lib/git.ts +63 -0
- package/src/lib/gitignore.ts +167 -0
- package/src/lib/manifest.ts +121 -0
- package/src/lib/marker-sync.ts +39 -0
- package/src/lib/paths.ts +38 -0
- package/src/lib/target-lines.ts +66 -0
- package/src/lib/ui.ts +78 -0
- package/src/sync-cli.ts +120 -0
- package/target-lines.json +23 -0
- package/tsconfig.json +20 -0
|
@@ -0,0 +1,78 @@
|
|
|
1
|
+
<goal>
|
|
2
|
+
Review implementation for engineer expectations fit. Per **Ideation First**, verify that implementation honors the desires, concerns, and decisions captured during ideation and planning.
|
|
3
|
+
</goal>
|
|
4
|
+
|
|
5
|
+
<inputs>
|
|
6
|
+
- Alignment doc path
|
|
7
|
+
- Spec doc path
|
|
8
|
+
</inputs>
|
|
9
|
+
|
|
10
|
+
<outputs>
|
|
11
|
+
- Critical review of expectations fit
|
|
12
|
+
- Improvements needed to better match expectations
|
|
13
|
+
- Summary of expectation violations, ordered by priority
|
|
14
|
+
</outputs>
|
|
15
|
+
|
|
16
|
+
<constraints>
|
|
17
|
+
- MUST read both spec doc and alignment doc completely
|
|
18
|
+
- MUST account for all engineer decisions in alignment doc
|
|
19
|
+
- MUST verify implementation against original ideation desires
|
|
20
|
+
</constraints>
|
|
21
|
+
|
|
22
|
+
## Context Gathering
|
|
23
|
+
|
|
24
|
+
- Read the spec doc for original engineer expectations, desires, and success criteria
|
|
25
|
+
- Read the alignment doc for planning decisions and engineer interjections
|
|
26
|
+
- Identify implementation files changed from base branch
|
|
27
|
+
- Read select prompts for detailed implementation context where necessary
|
|
28
|
+
|
|
29
|
+
## Expectations Extraction
|
|
30
|
+
|
|
31
|
+
From spec doc:
|
|
32
|
+
- Engineer desires and expectations
|
|
33
|
+
- Success criteria defined
|
|
34
|
+
- Concerns raised during ideation
|
|
35
|
+
- Guiding principles synthesized
|
|
36
|
+
|
|
37
|
+
From alignment doc:
|
|
38
|
+
- Planning decisions made
|
|
39
|
+
- Engineer-specific interjections
|
|
40
|
+
- Compromises documented
|
|
41
|
+
- Scope adjustments
|
|
42
|
+
|
|
43
|
+
## Review Process
|
|
44
|
+
|
|
45
|
+
Compare implementation against expectations:
|
|
46
|
+
|
|
47
|
+
| Check | Question |
|
|
48
|
+
|-------|----------|
|
|
49
|
+
| Desires | Are engineer's stated desires implemented? |
|
|
50
|
+
| Success Criteria | Does implementation meet defined success criteria? |
|
|
51
|
+
| Concerns | Were engineer's concerns addressed? |
|
|
52
|
+
| Decisions | Are planning decisions honored? |
|
|
53
|
+
| Scope | Does implementation match agreed scope? |
|
|
54
|
+
| Goal Achievement | Does implementation achieve goals or just complete tasks? |
|
|
55
|
+
|
|
56
|
+
Per **Quality Engineering**, task completion ≠ goal achievement. Verify implementation is substantive and connected, not placeholder-heavy.
|
|
57
|
+
|
|
58
|
+
## Output Format
|
|
59
|
+
|
|
60
|
+
Return findings ordered by priority:
|
|
61
|
+
|
|
62
|
+
```
|
|
63
|
+
## Expectations Fit Review
|
|
64
|
+
|
|
65
|
+
### P1 (Expectation Gaps)
|
|
66
|
+
- [Expectation]: [What was expected] -> [What was implemented] -> [Gap]
|
|
67
|
+
|
|
68
|
+
### P2 (Partial Fit)
|
|
69
|
+
- [Expectation]: [What was expected] -> [What was implemented] -> [What's missing]
|
|
70
|
+
|
|
71
|
+
### P3 (Minor Deviations)
|
|
72
|
+
- [Expectation]: [What was expected] -> [What was implemented] -> [Deviation]
|
|
73
|
+
|
|
74
|
+
## Summary
|
|
75
|
+
- [Total expectations reviewed]
|
|
76
|
+
- [Fit percentage]
|
|
77
|
+
- [Critical gaps requiring engineer attention]
|
|
78
|
+
```
|
|
@@ -0,0 +1,110 @@
|
|
|
1
|
+
<goal>
|
|
2
|
+
Review implementation for maintainability, code simplicity, and agentic anti-patterns. Per **Frontier Models are Capable**, identify hallucinations, duplications, and inter-prompt miscommunications. Per **Quality Engineering**, estimate simplification opportunities with LOC reduction.
|
|
3
|
+
</goal>
|
|
4
|
+
|
|
5
|
+
<inputs>
|
|
6
|
+
- Git diff to base (implementation files)
|
|
7
|
+
</inputs>
|
|
8
|
+
|
|
9
|
+
<outputs>
|
|
10
|
+
- Areas for improvement, ordered by priority
|
|
11
|
+
- Simplification recommendations with before/after
|
|
12
|
+
- LOC reduction estimates
|
|
13
|
+
- Complexity score assessment
|
|
14
|
+
- Agentic issues detected
|
|
15
|
+
</outputs>
|
|
16
|
+
|
|
17
|
+
<constraints>
|
|
18
|
+
- MUST use git diff to base for implementation review
|
|
19
|
+
- MUST compare against established codebase patterns
|
|
20
|
+
- MUST identify agentic-specific anti-patterns
|
|
21
|
+
</constraints>
|
|
22
|
+
|
|
23
|
+
## Context Gathering
|
|
24
|
+
|
|
25
|
+
- Review all implementation changes from base branch
|
|
26
|
+
- Run `ah knowledge docs search "architecture"` for established patterns
|
|
27
|
+
- Run `ah knowledge docs search "conventions"` for codebase standards
|
|
28
|
+
|
|
29
|
+
## Agentic Anti-Patterns to Detect
|
|
30
|
+
|
|
31
|
+
| Pattern | Description |
|
|
32
|
+
|---------|-------------|
|
|
33
|
+
| **Hallucination** | Imports that don't exist, APIs used incorrectly, made-up patterns |
|
|
34
|
+
| **Duplication** | Re-implementing existing utilities, duplicate logic across prompts |
|
|
35
|
+
| **Miscommunication** | Prompt A establishes pattern, Prompt B ignores it |
|
|
36
|
+
| **Inconsistency** | Different approaches for same problem in different files |
|
|
37
|
+
| **Over-abstraction** | Unnecessary wrappers, premature generalization |
|
|
38
|
+
| **Orphaned Artifacts** | Files created but never imported or connected |
|
|
39
|
+
|
|
40
|
+
## Design Quality Checks
|
|
41
|
+
|
|
42
|
+
| Check | Question |
|
|
43
|
+
|-------|----------|
|
|
44
|
+
| Composability | Can components be reused independently? |
|
|
45
|
+
| Naming | Are names descriptive and consistent? |
|
|
46
|
+
| Structure | Does organization follow codebase conventions? |
|
|
47
|
+
| Readability | Is the code self-documenting? |
|
|
48
|
+
| Simplicity | Is this the simplest solution that works? |
|
|
49
|
+
|
|
50
|
+
## Simplification Analysis
|
|
51
|
+
|
|
52
|
+
For each file, identify:
|
|
53
|
+
- **Unnecessary complexity** - Logic that could be simpler
|
|
54
|
+
- **Redundant code** - Duplicate checks, repeated patterns
|
|
55
|
+
- **Over-engineering** - Abstractions for single use cases
|
|
56
|
+
- **Dead code** - Unused functions, unreachable branches
|
|
57
|
+
|
|
58
|
+
Estimate LOC reduction for each simplification opportunity.
|
|
59
|
+
|
|
60
|
+
## Review Process
|
|
61
|
+
|
|
62
|
+
For each changed file:
|
|
63
|
+
- Compare against similar existing code
|
|
64
|
+
- Identify deviations from established patterns
|
|
65
|
+
- Flag probable agentic issues
|
|
66
|
+
- Note design inefficiencies
|
|
67
|
+
- Estimate simplification potential (LOC)
|
|
68
|
+
|
|
69
|
+
## Output Format
|
|
70
|
+
|
|
71
|
+
Return findings ordered by priority:
|
|
72
|
+
|
|
73
|
+
```
|
|
74
|
+
## Maintainability Review
|
|
75
|
+
|
|
76
|
+
### P1 (Critical)
|
|
77
|
+
- [File:lines]: [Issue] -> [Impact] -> [Fix]
|
|
78
|
+
|
|
79
|
+
### P2 (Important)
|
|
80
|
+
- [File:lines]: [Issue] -> [Impact] -> [Fix]
|
|
81
|
+
|
|
82
|
+
### P3 (Polish)
|
|
83
|
+
- [File:lines]: [Issue] -> [Impact] -> [Fix]
|
|
84
|
+
|
|
85
|
+
## Simplification Recommendations
|
|
86
|
+
|
|
87
|
+
### 1. [Most impactful simplification]
|
|
88
|
+
- **File**: [path:lines]
|
|
89
|
+
- **Current**: [Brief description of current approach]
|
|
90
|
+
- **Proposed**: [Simpler alternative]
|
|
91
|
+
- **LOC reduction**: ~X lines
|
|
92
|
+
|
|
93
|
+
### 2. [Next simplification]
|
|
94
|
+
...
|
|
95
|
+
|
|
96
|
+
## Agentic Issues Detected
|
|
97
|
+
|
|
98
|
+
| Type | Count | Examples |
|
|
99
|
+
|------|-------|----------|
|
|
100
|
+
| Hallucinations | X | [Brief examples of made-up APIs/patterns] |
|
|
101
|
+
| Duplications | X | [Brief examples of redundant code] |
|
|
102
|
+
| Miscommunications | X | [Brief examples of inter-prompt conflicts] |
|
|
103
|
+
|
|
104
|
+
## Complexity Assessment
|
|
105
|
+
|
|
106
|
+
- **Total LOC added**: X
|
|
107
|
+
- **Potential LOC reduction**: ~Y (Z%)
|
|
108
|
+
- **Complexity score**: [High/Medium/Low]
|
|
109
|
+
- **Recommendation**: [Proceed as-is / Minor simplifications / Significant refactoring needed]
|
|
110
|
+
```
|
|
@@ -0,0 +1,74 @@
|
|
|
1
|
+
<goal>
|
|
2
|
+
Review planning artifacts for engineer expectations fit. Per **Ideation First**, verify that prompts and alignment doc fully capture engineer desires from spec with no gaps or inconsistencies.
|
|
3
|
+
</goal>
|
|
4
|
+
|
|
5
|
+
<inputs>
|
|
6
|
+
- Alignment doc path
|
|
7
|
+
- Spec doc path
|
|
8
|
+
- Prompts folder path
|
|
9
|
+
</inputs>
|
|
10
|
+
|
|
11
|
+
<outputs>
|
|
12
|
+
- Review of expectations fit for planning artifacts
|
|
13
|
+
- Improvements needed (by prompt number / alignment doc section)
|
|
14
|
+
- Summary of expectation gaps, ordered by priority
|
|
15
|
+
</outputs>
|
|
16
|
+
|
|
17
|
+
<constraints>
|
|
18
|
+
- MUST treat spec doc engineer expectations as ground truth
|
|
19
|
+
- MUST identify inconsistencies between spec and planning artifacts
|
|
20
|
+
- MUST find holes missed during planning consolidation
|
|
21
|
+
</constraints>
|
|
22
|
+
|
|
23
|
+
## Context Gathering
|
|
24
|
+
|
|
25
|
+
- Read the spec doc for engineer expectations (ground truth)
|
|
26
|
+
- Read the alignment doc for planning decisions
|
|
27
|
+
- Read all prompts in the prompts folder
|
|
28
|
+
|
|
29
|
+
## Expectations Comparison
|
|
30
|
+
|
|
31
|
+
| Spec Element | Check |
|
|
32
|
+
|--------------|-------|
|
|
33
|
+
| Desires | Are they reflected in prompts? |
|
|
34
|
+
| Success Criteria | Do prompts collectively achieve them? |
|
|
35
|
+
| Concerns | Are they addressed in tasks? |
|
|
36
|
+
| Assumptions | Are they validated by prompt dependencies? |
|
|
37
|
+
| Open Questions | Were they resolved in alignment doc? |
|
|
38
|
+
|
|
39
|
+
## Inconsistency Detection
|
|
40
|
+
|
|
41
|
+
Look for:
|
|
42
|
+
- Spec desires not covered by any prompt
|
|
43
|
+
- Prompts that contradict spec expectations
|
|
44
|
+
- Alignment doc decisions that deviate from spec without explanation
|
|
45
|
+
- Holes in coverage (engineer expected X, nothing implements X)
|
|
46
|
+
|
|
47
|
+
## Review Process
|
|
48
|
+
|
|
49
|
+
For each spec expectation:
|
|
50
|
+
- Trace to prompts that address it
|
|
51
|
+
- Verify alignment doc documents any deviations
|
|
52
|
+
- Flag gaps where planning missed expectations
|
|
53
|
+
|
|
54
|
+
## Output Format
|
|
55
|
+
|
|
56
|
+
Return findings ordered by priority:
|
|
57
|
+
|
|
58
|
+
```
|
|
59
|
+
## Prompts Expectations Fit Review
|
|
60
|
+
|
|
61
|
+
### P1 (Missing Coverage)
|
|
62
|
+
- [Spec expectation]: [What was expected] -> [No prompt addresses this]
|
|
63
|
+
|
|
64
|
+
### P2 (Inconsistencies)
|
|
65
|
+
- [Spec expectation]: [What was expected] -> [Prompt X says Y instead]
|
|
66
|
+
|
|
67
|
+
### P3 (Clarification Needed)
|
|
68
|
+
- [Spec element]: [Ambiguous] -> [Prompts interpret as X, but could be Y]
|
|
69
|
+
|
|
70
|
+
## Summary
|
|
71
|
+
- [Total spec expectations reviewed]
|
|
72
|
+
- [Coverage percentage]
|
|
73
|
+
- [Critical gaps requiring planner attention]
|
|
74
|
+
```
|
|
@@ -0,0 +1,92 @@
|
|
|
1
|
+
<goal>
|
|
2
|
+
Analyze prompt dependencies and ordering for optimal derisking and parallelization. Per **Quality Engineering**, derisk the most critical logic first to reveal feasibility/stability signals as early as possible.
|
|
3
|
+
</goal>
|
|
4
|
+
|
|
5
|
+
<inputs>
|
|
6
|
+
- Alignment doc path
|
|
7
|
+
- Prompts folder path
|
|
8
|
+
</inputs>
|
|
9
|
+
|
|
10
|
+
<outputs>
|
|
11
|
+
- Dependency analysis with parallelization opportunities
|
|
12
|
+
- Reordering recommendations for derisking
|
|
13
|
+
- Merge/conflict risk identification
|
|
14
|
+
</outputs>
|
|
15
|
+
|
|
16
|
+
<constraints>
|
|
17
|
+
- MUST map all prompt dependencies
|
|
18
|
+
- MUST identify critical path for derisking
|
|
19
|
+
- MUST balance parallelization with merge risk
|
|
20
|
+
</constraints>
|
|
21
|
+
|
|
22
|
+
## Context Gathering
|
|
23
|
+
|
|
24
|
+
- Read all prompts in the prompts folder
|
|
25
|
+
- Extract `dependencies` from each prompt's frontmatter
|
|
26
|
+
- Read alignment doc for goal priorities
|
|
27
|
+
|
|
28
|
+
## Dependency Analysis
|
|
29
|
+
|
|
30
|
+
Build dependency graph:
|
|
31
|
+
- Map which prompts block which others
|
|
32
|
+
- Identify prompts that can run in parallel
|
|
33
|
+
- Find critical path (longest dependency chain)
|
|
34
|
+
|
|
35
|
+
## Derisking Analysis
|
|
36
|
+
|
|
37
|
+
Think like a tech lead engineer:
|
|
38
|
+
|
|
39
|
+
| Priority | Question |
|
|
40
|
+
|----------|----------|
|
|
41
|
+
| Feasibility | Which prompts reveal if implementation is even possible? |
|
|
42
|
+
| Stability | Which prompts prove core architecture works? |
|
|
43
|
+
| Blockers | Which prompts unblock the most other work? |
|
|
44
|
+
| Confidence | Which prompts give earliest signal on success? |
|
|
45
|
+
| Wiring | Do prompts plan how components connect, not just create artifacts? |
|
|
46
|
+
|
|
47
|
+
Order prompts to derisk:
|
|
48
|
+
- Most important/revealing work first
|
|
49
|
+
- Critical feasibility checks before polish
|
|
50
|
+
- Foundation before features
|
|
51
|
+
|
|
52
|
+
## Parallelization Opportunities
|
|
53
|
+
|
|
54
|
+
For prompts that could run in parallel:
|
|
55
|
+
- Assess merge/conflict risks
|
|
56
|
+
- Identify setup/teardown dependencies
|
|
57
|
+
- Consider file overlap risks
|
|
58
|
+
|
|
59
|
+
| Risk Level | Criteria |
|
|
60
|
+
|------------|----------|
|
|
61
|
+
| Safe | No file overlap, independent domains |
|
|
62
|
+
| Medium | Shared utilities, coordinated patterns |
|
|
63
|
+
| High | Same files, database migrations, state |
|
|
64
|
+
|
|
65
|
+
## Output Format
|
|
66
|
+
|
|
67
|
+
Return findings ordered by priority:
|
|
68
|
+
|
|
69
|
+
```
|
|
70
|
+
## Prompts Flow Analysis
|
|
71
|
+
|
|
72
|
+
### Critical Path
|
|
73
|
+
1. Prompt X (blocks Y, Z)
|
|
74
|
+
2. Prompt Y (blocks W)
|
|
75
|
+
3. ...
|
|
76
|
+
|
|
77
|
+
### Parallelization Opportunities
|
|
78
|
+
- [Prompts A, B, C] can run in parallel (safe)
|
|
79
|
+
- [Prompts D, E] can run in parallel (medium risk: shared utils)
|
|
80
|
+
|
|
81
|
+
### Derisking Recommendations
|
|
82
|
+
- P1: Move Prompt X earlier (reveals feasibility of core feature)
|
|
83
|
+
- P2: Split Prompt Y into two (unblocks more parallelization)
|
|
84
|
+
|
|
85
|
+
### Merge Risks
|
|
86
|
+
- [Prompts N, M] have conflict risk if parallel (both touch auth)
|
|
87
|
+
|
|
88
|
+
## Summary
|
|
89
|
+
- [Critical path length]
|
|
90
|
+
- [Parallelization potential]
|
|
91
|
+
- [Reordering recommendations]
|
|
92
|
+
```
|
|
@@ -0,0 +1,78 @@
|
|
|
1
|
+
<goal>
|
|
2
|
+
Review planning artifacts for YAGNI (You Ain't Gonna Need It) violations. Per **Quality Engineering**, identify over-engineering and unnecessary complexity that wastes effort.
|
|
3
|
+
</goal>
|
|
4
|
+
|
|
5
|
+
<inputs>
|
|
6
|
+
- Alignment doc path
|
|
7
|
+
- Prompts folder path
|
|
8
|
+
</inputs>
|
|
9
|
+
|
|
10
|
+
<outputs>
|
|
11
|
+
- YAGNI violations identified
|
|
12
|
+
- Recommendations for simplification, ordered by priority
|
|
13
|
+
</outputs>
|
|
14
|
+
|
|
15
|
+
<constraints>
|
|
16
|
+
- MUST give leniency to explicit engineer decisions
|
|
17
|
+
- MUST still offer YAGNI perspective even on engineer-decided items (lower priority)
|
|
18
|
+
- MUST distinguish agentic over-engineering from engineer-requested complexity
|
|
19
|
+
</constraints>
|
|
20
|
+
|
|
21
|
+
## Context Gathering
|
|
22
|
+
|
|
23
|
+
- Read alignment doc for engineer decisions and rationale
|
|
24
|
+
- Read all prompts in the prompts folder
|
|
25
|
+
- Identify which elements were engineer-decided vs. agent-proposed
|
|
26
|
+
|
|
27
|
+
## YAGNI Detection
|
|
28
|
+
|
|
29
|
+
Look for:
|
|
30
|
+
|
|
31
|
+
| Pattern | Description | Example |
|
|
32
|
+
|---------|-------------|---------|
|
|
33
|
+
| Premature Abstraction | Generalization before proven need | Helper class for one-time operation |
|
|
34
|
+
| Future-Proofing | Building for hypothetical requirements | Config for thing that won't change |
|
|
35
|
+
| Over-Configuration | Making unchanging things configurable | ENV var for hardcoded value |
|
|
36
|
+
| Defensive Complexity | Error handling for impossible scenarios | Null check on required param |
|
|
37
|
+
| Feature Creep | Scope beyond stated goals within planned prompts (note: `type: emergent` prompts and disposable variants are not feature creep per **Quality Engineering** - they discover which extensions are valuable) | "While we're here, let's add..." |
|
|
38
|
+
| Scope Bloat | 10+ files or 7+ tasks in single prompt | Split needed |
|
|
39
|
+
|
|
40
|
+
## Priority Weighting
|
|
41
|
+
|
|
42
|
+
| Source | Priority Treatment |
|
|
43
|
+
|--------|-------------------|
|
|
44
|
+
| Agent-proposed complexity | Higher priority (agents over-engineer) |
|
|
45
|
+
| Engineer-decided complexity | Lower priority (explicit awareness, but still offer perspective) |
|
|
46
|
+
|
|
47
|
+
This respects engineer decisions while still providing value.
|
|
48
|
+
|
|
49
|
+
## Review Process
|
|
50
|
+
|
|
51
|
+
For each prompt/alignment doc element:
|
|
52
|
+
- Is this necessary for stated goals?
|
|
53
|
+
- Could this be simpler?
|
|
54
|
+
- Is complexity justified by requirements?
|
|
55
|
+
- Was this engineer-decided or agent-proposed?
|
|
56
|
+
|
|
57
|
+
## Output Format
|
|
58
|
+
|
|
59
|
+
Return findings ordered by priority:
|
|
60
|
+
|
|
61
|
+
```
|
|
62
|
+
## YAGNI Review
|
|
63
|
+
|
|
64
|
+
### P1 (Agent-Proposed Over-Engineering)
|
|
65
|
+
- [Prompt X]: [What's unnecessary] -> [Simpler alternative]
|
|
66
|
+
- [Alignment decision Y]: [Why it's excessive] -> [Leaner approach]
|
|
67
|
+
|
|
68
|
+
### P2 (Questionable Complexity)
|
|
69
|
+
- [Element]: [What seems over-engineered] -> [Consider simplifying]
|
|
70
|
+
|
|
71
|
+
### P3 (Engineer-Decided, Worth Reconsidering)
|
|
72
|
+
- [Element]: [Engineer chose this, but YAGNI perspective suggests...] -> [Alternative if desired]
|
|
73
|
+
|
|
74
|
+
## Summary
|
|
75
|
+
- [Potential effort saved by simplification]
|
|
76
|
+
- [Scope reduction opportunities]
|
|
77
|
+
- [Complexity hotspots]
|
|
78
|
+
```
|
|
@@ -0,0 +1,125 @@
|
|
|
1
|
+
<goal>
|
|
2
|
+
Identify failure modes in prompts before execution. Per **Quality Engineering**, detecting risks early prevents rework and wasted agent cycles.
|
|
3
|
+
</goal>
|
|
4
|
+
|
|
5
|
+
<inputs>
|
|
6
|
+
- Alignment doc path
|
|
7
|
+
- Prompts folder path
|
|
8
|
+
</inputs>
|
|
9
|
+
|
|
10
|
+
<outputs>
|
|
11
|
+
Structured risk findings in REVIEW_OPTIONS_BREAKDOWN consumable format:
|
|
12
|
+
- Tigers (clear threats requiring action)
|
|
13
|
+
- Elephants (unspoken concerns worth surfacing)
|
|
14
|
+
- Paper Tigers (looks scary but acceptable)
|
|
15
|
+
</outputs>
|
|
16
|
+
|
|
17
|
+
<constraints>
|
|
18
|
+
- MUST verify every potential risk before flagging as Tiger
|
|
19
|
+
- MUST read prompt files and alignment doc before flagging risks
|
|
20
|
+
- MUST output in structured format for REVIEW_OPTIONS_BREAKDOWN
|
|
21
|
+
- NEVER flag risks based on pattern-matching alone
|
|
22
|
+
</constraints>
|
|
23
|
+
|
|
24
|
+
## Risk Categories
|
|
25
|
+
|
|
26
|
+
| Category | Symbol | Meaning | Action Required |
|
|
27
|
+
|----------|--------|---------|-----------------|
|
|
28
|
+
| **Tiger** | `[TIGER]` | Clear threat that will hurt if not addressed | Must address or accept |
|
|
29
|
+
| **Paper Tiger** | `[PAPER]` | Looks threatening but probably fine | Acknowledge |
|
|
30
|
+
| **Elephant** | `[ELEPHANT]` | Concern nobody mentioned yet | Surface for discussion |
|
|
31
|
+
|
|
32
|
+
## Analysis Checklist
|
|
33
|
+
|
|
34
|
+
Work through each category systematically for the prompt set:
|
|
35
|
+
|
|
36
|
+
### Prompt Completeness
|
|
37
|
+
- [ ] Every prompt has clear acceptance criteria?
|
|
38
|
+
- [ ] Validation tooling referenced for each prompt?
|
|
39
|
+
- [ ] Dependencies between prompts explicit?
|
|
40
|
+
- [ ] Scope per prompt reasonable (2-3 tasks, <7 files)?
|
|
41
|
+
|
|
42
|
+
### Technical Risks
|
|
43
|
+
- [ ] External dependencies with fallbacks?
|
|
44
|
+
- [ ] Breaking changes identified?
|
|
45
|
+
- [ ] Migration/rollback path defined?
|
|
46
|
+
- [ ] Security considerations for auth/data?
|
|
47
|
+
- [ ] Error handling coverage?
|
|
48
|
+
|
|
49
|
+
### Integration Risks
|
|
50
|
+
- [ ] Components wire together (API → UI)?
|
|
51
|
+
- [ ] Feature flags needed for partial delivery?
|
|
52
|
+
- [ ] Testing strategy for cross-prompt work?
|
|
53
|
+
|
|
54
|
+
### Process Risks
|
|
55
|
+
- [ ] Requirements clear and complete?
|
|
56
|
+
- [ ] Validation suites exist for domains touched?
|
|
57
|
+
- [ ] Parallel execution conflicts avoided?
|
|
58
|
+
|
|
59
|
+
## Verification Protocol
|
|
60
|
+
|
|
61
|
+
Before flagging ANY Tiger, verify:
|
|
62
|
+
|
|
63
|
+
```yaml
|
|
64
|
+
potential_finding:
|
|
65
|
+
what: "<description of concern>"
|
|
66
|
+
prompt: "<prompt number(s) affected>"
|
|
67
|
+
|
|
68
|
+
verification:
|
|
69
|
+
context_read: true # Did I read the relevant prompts?
|
|
70
|
+
alignment_check: true # Is this addressed in alignment doc?
|
|
71
|
+
scope_check: true # Is this actually in scope?
|
|
72
|
+
|
|
73
|
+
result: tiger | paper_tiger | elephant | false_alarm
|
|
74
|
+
```
|
|
75
|
+
|
|
76
|
+
**If ANY verification check is "no" or "unknown", DO NOT flag as Tiger.**
|
|
77
|
+
|
|
78
|
+
## Output Format
|
|
79
|
+
|
|
80
|
+
Structure findings for REVIEW_OPTIONS_BREAKDOWN consumption:
|
|
81
|
+
|
|
82
|
+
```yaml
|
|
83
|
+
premortem:
|
|
84
|
+
prompts_analyzed: [01, 02, 03, ...]
|
|
85
|
+
alignment_doc: "<path>"
|
|
86
|
+
|
|
87
|
+
tigers:
|
|
88
|
+
- risk: "<description>"
|
|
89
|
+
prompts_affected: [01, 02]
|
|
90
|
+
severity: high | medium
|
|
91
|
+
category: completeness | technical | integration | process
|
|
92
|
+
mitigation_checked: "<what mitigation was looked for and NOT found>"
|
|
93
|
+
suggested_action: "<how to address>"
|
|
94
|
+
|
|
95
|
+
elephants:
|
|
96
|
+
- risk: "<unspoken concern worth surfacing>"
|
|
97
|
+
prompts_affected: [all | specific numbers]
|
|
98
|
+
severity: medium
|
|
99
|
+
suggested_action: "<what to discuss>"
|
|
100
|
+
|
|
101
|
+
paper_tigers:
|
|
102
|
+
- risk: "<looks scary but acceptable>"
|
|
103
|
+
reason: "<why it's fine - cite evidence from prompts/alignment>"
|
|
104
|
+
prompts_affected: [numbers]
|
|
105
|
+
|
|
106
|
+
checklist_gaps:
|
|
107
|
+
- category: "<which checklist section>"
|
|
108
|
+
items_failed: ["<item1>", "<item2>"]
|
|
109
|
+
prompts_affected: [numbers]
|
|
110
|
+
```
|
|
111
|
+
|
|
112
|
+
## Severity Guidelines
|
|
113
|
+
|
|
114
|
+
| Severity | Criteria | Examples |
|
|
115
|
+
|----------|----------|----------|
|
|
116
|
+
| **High** | Blocks goal achievement, security risk, data loss | Missing auth check, no rollback plan, circular dependencies |
|
|
117
|
+
| **Medium** | Quality impact, technical debt, maintenance burden | Missing tests, unclear acceptance criteria, over-engineering |
|
|
118
|
+
|
|
119
|
+
## Integration with Review Flow
|
|
120
|
+
|
|
121
|
+
This premortem output feeds directly into REVIEW_OPTIONS_BREAKDOWN:
|
|
122
|
+
- Tigers become P1 (blocking) or P2 (recommended) items
|
|
123
|
+
- Elephants become discussion points for engineer interview
|
|
124
|
+
- Paper Tigers are documented as acknowledged acceptable risks
|
|
125
|
+
- Checklist gaps inform specific prompt amendments
|
|
@@ -0,0 +1,86 @@
|
|
|
1
|
+
<goal>
|
|
2
|
+
Review implementation for security vulnerabilities and risks. Per **Agentic Validation Tooling**, identify security issues that programmatic validation may have missed.
|
|
3
|
+
</goal>
|
|
4
|
+
|
|
5
|
+
<inputs>
|
|
6
|
+
- Alignment doc path
|
|
7
|
+
- Prompts folder path
|
|
8
|
+
</inputs>
|
|
9
|
+
|
|
10
|
+
<outputs>
|
|
11
|
+
- Security vulnerabilities identified
|
|
12
|
+
- Risk assessment and remediation recommendations, ordered by priority
|
|
13
|
+
</outputs>
|
|
14
|
+
|
|
15
|
+
<constraints>
|
|
16
|
+
- MUST use git diff to base for implementation review
|
|
17
|
+
- MUST check alignment doc for security-specific decisions
|
|
18
|
+
- MUST focus on OWASP Top 10 and common vulnerability patterns
|
|
19
|
+
</constraints>
|
|
20
|
+
|
|
21
|
+
## Context Gathering
|
|
22
|
+
|
|
23
|
+
- Review all implementation changes from base branch
|
|
24
|
+
- Read alignment doc for security decisions made during planning
|
|
25
|
+
- Identify security-sensitive areas touched
|
|
26
|
+
|
|
27
|
+
## Vulnerability Categories
|
|
28
|
+
|
|
29
|
+
| Category | Check For |
|
|
30
|
+
|----------|-----------|
|
|
31
|
+
| Injection | SQL, command, LDAP, XPath injection |
|
|
32
|
+
| Auth | Broken authentication, session management |
|
|
33
|
+
| XSS | Cross-site scripting vectors |
|
|
34
|
+
| IDOR | Insecure direct object references |
|
|
35
|
+
| Misconfig | Security misconfigurations |
|
|
36
|
+
| Exposure | Sensitive data exposure |
|
|
37
|
+
| Access Control | Broken access control |
|
|
38
|
+
| CSRF | Cross-site request forgery |
|
|
39
|
+
| Dependencies | Known vulnerable components |
|
|
40
|
+
| Logging | Insufficient logging and monitoring |
|
|
41
|
+
|
|
42
|
+
## Implementation Review
|
|
43
|
+
|
|
44
|
+
For each changed file:
|
|
45
|
+
|
|
46
|
+
| File Type | Security Focus |
|
|
47
|
+
|-----------|----------------|
|
|
48
|
+
| API endpoints | Input validation, auth, authorization |
|
|
49
|
+
| Database queries | Parameterization, access control |
|
|
50
|
+
| Frontend | XSS prevention, CSRF tokens, secure storage |
|
|
51
|
+
| Config files | Secrets exposure, default credentials |
|
|
52
|
+
| Auth code | Token handling, session management |
|
|
53
|
+
|
|
54
|
+
## Risk Assessment
|
|
55
|
+
|
|
56
|
+
| Severity | Criteria |
|
|
57
|
+
|----------|----------|
|
|
58
|
+
| Critical | Remotely exploitable, data breach risk |
|
|
59
|
+
| High | Significant vulnerability, requires attention |
|
|
60
|
+
| Medium | Security weakness, should be addressed |
|
|
61
|
+
| Low | Minor issue, improve when convenient |
|
|
62
|
+
|
|
63
|
+
## Output Format
|
|
64
|
+
|
|
65
|
+
Return findings ordered by priority:
|
|
66
|
+
|
|
67
|
+
```
|
|
68
|
+
## Security Review
|
|
69
|
+
|
|
70
|
+
### Critical
|
|
71
|
+
- [File:line]: [Vulnerability] -> [Risk] -> [Remediation]
|
|
72
|
+
|
|
73
|
+
### High
|
|
74
|
+
- [File:line]: [Vulnerability] -> [Risk] -> [Remediation]
|
|
75
|
+
|
|
76
|
+
### Medium
|
|
77
|
+
- [File:line]: [Vulnerability] -> [Risk] -> [Remediation]
|
|
78
|
+
|
|
79
|
+
### Low
|
|
80
|
+
- [File:line]: [Issue] -> [Recommendation]
|
|
81
|
+
|
|
82
|
+
## Summary
|
|
83
|
+
- [Total vulnerabilities found]
|
|
84
|
+
- [Risk score]
|
|
85
|
+
- [Immediate actions required]
|
|
86
|
+
```
|