all-for-claudecode 2.9.1 → 2.11.0

package/.claude-plugin/marketplace.json

@@ -6,14 +6,14 @@
   },
   "metadata": {
     "description": "Automated pipeline for Claude Code — spec → plan → implement → review → clean",
-    "version": "2.9.1"
+    "version": "2.11.0"
   },
   "plugins": [
     {
       "name": "afc",
       "source": "./",
       "description": "Automated pipeline for Claude Code. Automates the full development cycle: spec → plan → implement → review → clean.",
-      "version": "2.9.1",
+      "version": "2.11.0",
       "category": "automation",
       "tags": ["pipeline", "automation", "spec", "plan", "implement", "review", "critic-loop"]
     }

package/.claude-plugin/plugin.json

@@ -1,11 +1,11 @@
 {
   "name": "afc",
-  "version": "2.9.1",
+  "version": "2.11.0",
   "description": "Automated pipeline for Claude Code. Automates the full development cycle: spec → plan → implement → review → clean.",
   "author": { "name": "jhlee0409", "email": "relee6203@gmail.com" },
   "homepage": "https://github.com/jhlee0409/all-for-claudecode",
   "repository": "https://github.com/jhlee0409/all-for-claudecode",
   "license": "MIT",
   "keywords": ["pipeline", "automation", "spec", "plan", "implement", "review", "critic-loop"],
-  "commands": "./commands/"
+  "skills": "./skills/"
 }

package/MIGRATION.md

@@ -112,7 +112,7 @@ git tag -d selfish/pre-auto 2>/dev/null
 |------|--------|-------|
 | Installation | `git clone` + `./install.sh` | `/plugin install <url>` |
 | Command separator | `.` (`/afc-legacy.spec`) | `:` (`/afc:spec`) |
-| Command location | `~/.claude/commands/afc-legacy.*.md` | `commands/*.md` inside the plugin |
+| Command location | `~/.claude/commands/afc-legacy.*.md` | `skills/*/SKILL.md` inside the plugin |
 | Hook scripts | `<project>/.claude/hooks/*.sh` | `scripts/*.sh` inside the plugin |
 | Hook config | `<project>/.claude/settings.json` | `hooks/hooks.json` inside the plugin |
 | Config file | `.claude/afc.config.md` (unchanged) | `.claude/afc.config.md` (unchanged) |

package/README.md

@@ -52,6 +52,10 @@ Spec (1/5) → Plan (2/5) → Implement (3/5) → Review (4/5) → Clean (5/5)
   │              └─ File change map, ADR recording, research persistence
   └─ Acceptance criteria, pre-implementation gates
 
+Skill Advisor checkpoints (A–E) between phases dynamically invoke
+auxiliary skills (ideate, consult, architect, security, test, qa, learner)
+when LLM evaluation detects they would add value. Budget: max 5 per run.
+
 Hooks run automatically at each step.
 CI failure → debug-based RCA (not blind retry).
 Critic Loops verify quality at each gate until convergence.

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "all-for-claudecode",
-  "version": "2.9.1",
+  "version": "2.11.0",
   "description": "Claude Code plugin that automates the full dev cycle — spec, plan, implement, review, clean.",
   "bin": {
     "all-for-claudecode": "bin/cli.mjs"
@@ -9,7 +9,7 @@
   "files": [
     "agents/",
     "bin/",
-    "commands/",
+    "skills/",
     "docs/",
     "hooks/",
     "schemas/",

package/schemas/plugin.schema.json

@@ -41,9 +41,9 @@
       "type": "array",
       "items": { "type": "string" }
     },
-    "commands": {
+    "skills": {
       "type": "string",
-      "description": "Path to commands directory"
+      "description": "Path to skills directory"
     },
     "agents": {
       "type": "string",

package/scripts/afc-consistency-check.sh

@@ -42,7 +42,7 @@ get_cmd_field() {
 }
 
 # --- Check 1: Config Placeholder Validation ---
-# Verify all {config.*} references in commands/ and docs/ map to known config keys
+# Verify all {config.*} references in skills/ and docs/ map to known config keys
 
 check_config_placeholders() {
   local template="$PROJECT_DIR/templates/afc.config.template.md"
@@ -66,9 +66,9 @@ check_config_placeholders() {
   local valid_keys
   valid_keys=$(printf '%s\n%s\n' "$yaml_keys" "$section_keys" | sort -u)
 
-  # Extract all {config.*} references from commands and docs
+  # Extract all {config.*} references from skills and docs
   local refs
-  refs=$(grep -rohE '\{config\.[a-z_]+\}' "$PROJECT_DIR/commands/" "$PROJECT_DIR/docs/" 2>/dev/null \
+  refs=$(grep -rohE '\{config\.[a-z_]+\}' "$PROJECT_DIR/skills/" "$PROJECT_DIR/docs/" 2>/dev/null \
     | sed 's/{config\.//;s/}//' \
     | sort -u || true)
 
@@ -104,15 +104,17 @@ check_agent_names() {
     | tr -d '"' \
     | sort -u || true)
 
-  # Extract subagent_type references from commands (afc:agent-name pattern)
+  # Extract subagent_type references from skills (afc:agent-name pattern)
   local referenced_agents
-  referenced_agents=$(grep -rohE 'subagent_type:[[:space:]]*"afc:[^"]*"' "$PROJECT_DIR/commands/" 2>/dev/null \
+  referenced_agents=$(grep -rohE 'subagent_type:[[:space:]]*"afc:[^"]*"' "$PROJECT_DIR/skills/" 2>/dev/null \
     | sed 's/.*"afc://;s/"//' \
     | sort -u || true)
 
   local count=0
   local invalid=0
   for ref in $referenced_agents; do
+    # Skip dynamic template patterns (e.g., afc-{domain}-expert)
+    case "$ref" in *"{"*) continue ;; esac
     count=$((count + 1))
     if ! printf '%s\n' "$defined_agents" | grep -qxF "$ref"; then
       fail "subagent_type 'afc:$ref' referenced but no agents/$ref.md found"
@@ -122,7 +124,7 @@ check_agent_names() {
 
   # Check for unprefixed subagent_type that should have afc: prefix
   local unprefixed
-  unprefixed=$(grep -rohE 'subagent_type:[[:space:]]*"afc-[^"]*"' "$PROJECT_DIR/commands/" 2>/dev/null \
+  unprefixed=$(grep -rohE 'subagent_type:[[:space:]]*"afc-[^"]*"' "$PROJECT_DIR/skills/" 2>/dev/null \
     | sed 's/.*subagent_type:[[:space:]]*"//;s/".*//' \
     | sort -u || true)
   for ref in $unprefixed; do
@@ -254,22 +256,22 @@ check_phase_ssot() {
   fi
 }
 
-# --- Check 7: Command Documentation Cross-Reference ---
-# Verify commands are documented in README.md, init.md, and CLAUDE.md
+# --- Check 7: Skill Documentation Cross-Reference ---
+# Verify skills are documented in README.md, init/SKILL.md, and CLAUDE.md
 
 check_command_docs() {
-  local commands_dir="$PROJECT_DIR/commands"
-  [ -d "$commands_dir" ] || return
+  local skills_dir="$PROJECT_DIR/skills"
+  [ -d "$skills_dir" ] || return
 
   local readme="$PROJECT_DIR/README.md"
-  local init_cmd="$commands_dir/init.md"
+  local init_skill="$skills_dir/init/SKILL.md"
   local claude_md="$PROJECT_DIR/CLAUDE.md"
   local issues=0
 
-  for cmd_file in "$commands_dir"/*.md; do
-    [ -f "$cmd_file" ] || continue
+  for skill_file in "$skills_dir"/*/SKILL.md; do
+    [ -f "$skill_file" ] || continue
     local cmd_name
-    cmd_name=$(basename "$cmd_file" .md)
+    cmd_name=$(basename "$(dirname "$skill_file")")
 
     # Sub-check A: README.md should mention /afc:{name}
     if [ -f "$readme" ]; then
@@ -279,29 +281,29 @@ check_command_docs() {
       fi
     fi
 
-    # Sub-check B: init.md should mention afc:{name} for user-invocable commands
+    # Sub-check B: init/SKILL.md should mention afc:{name} for user-invocable skills
     local invocable
-    invocable=$(get_cmd_field "$cmd_file" "user-invocable")
-    if [ "$invocable" != "false" ] && [ -f "$init_cmd" ]; then
-      if ! grep -qE "afc:${cmd_name}([^a-z0-9-]|$)" "$init_cmd" 2>/dev/null; then
-        warn "Command '$cmd_name' missing from init.md skill routing"
+    invocable=$(get_cmd_field "$skill_file" "user-invocable")
+    if [ "$invocable" != "false" ] && [ -f "$init_skill" ]; then
+      if ! grep -qE "afc:${cmd_name}([^a-z0-9-]|$)" "$init_skill" 2>/dev/null; then
+        warn "Skill '$cmd_name' missing from init/SKILL.md skill routing"
         issues=$((issues + 1))
       fi
     fi
 
-    # Sub-check C: CLAUDE.md fork list for context:fork commands
+    # Sub-check C: CLAUDE.md fork list for context:fork skills
     local ctx
-    ctx=$(get_cmd_field "$cmd_file" "context")
+    ctx=$(get_cmd_field "$skill_file" "context")
     if [ "$ctx" = "fork" ] && [ -f "$claude_md" ]; then
       if ! grep "context: fork" "$claude_md" 2>/dev/null | grep -qE "([(, ])${cmd_name}([,) ]|$)"; then
-        warn "Command '$cmd_name' (context:fork) missing from CLAUDE.md fork list"
+        warn "Skill '$cmd_name' (context:fork) missing from CLAUDE.md fork list"
         issues=$((issues + 1))
       fi
     fi
   done
 
   if [ "$issues" -eq 0 ]; then
-    ok "Command docs: all commands referenced in README.md, init.md, CLAUDE.md"
+    ok "Skill docs: all skills referenced in README.md, init/SKILL.md, CLAUDE.md"
   fi
 }
 

package/scripts/afc-doctor.sh

@@ -457,8 +457,8 @@ if [ "$IS_DEV" = true ]; then
   # Cache sync check
   CACHE_DIR="$HOME/.claude/plugins/cache/all-for-claudecode/afc/$V_PKG"
   if [ -d "$CACHE_DIR" ]; then
-    CACHE_AUTO="$CACHE_DIR/commands/auto.md"
-    SOURCE_AUTO="$PROJECT_DIR/commands/auto.md"
+    CACHE_AUTO="$CACHE_DIR/skills/auto/SKILL.md"
+    SOURCE_AUTO="$PROJECT_DIR/skills/auto/SKILL.md"
     if [ -f "$CACHE_AUTO" ] && [ -f "$SOURCE_AUTO" ]; then
       if diff -q "$SOURCE_AUTO" "$CACHE_AUTO" >/dev/null 2>&1; then
         pass "Cache in sync"
@@ -472,21 +472,21 @@ if [ "$IS_DEV" = true ]; then
     warn "Plugin cache directory not found" "install plugin first, then npm run sync:cache"
   fi
 
-  # --- Category 10: Command Definitions (dev only) ---
-  section "Command Definitions (dev)"
+  # --- Category 10: Skill Definitions (dev only) ---
+  section "Skill Definitions (dev)"
 
-  CMD_DIR="$PROJECT_DIR/commands"
-  if [ -d "$CMD_DIR" ]; then
+  SKILL_DIR="$PROJECT_DIR/skills"
+  if [ -d "$SKILL_DIR" ]; then
     CMD_COUNT=0
     CMD_FM_MISSING=""
     CMD_FIELD_MISSING=""
     CMD_NAME_MISMATCH=""
     CMD_AGENT_MISSING=""
 
-    for cmd_file in "$CMD_DIR"/*.md; do
+    for cmd_file in "$SKILL_DIR"/*/SKILL.md; do
       [ -f "$cmd_file" ] || continue
       CMD_COUNT=$((CMD_COUNT + 1))
-      BASENAME=$(basename "$cmd_file" .md)
+      BASENAME=$(basename "$(dirname "$cmd_file")")
 
       # Check frontmatter exists (--- ... ---)
       if ! head -1 "$cmd_file" | grep -q '^---' 2>/dev/null; then
@@ -658,9 +658,9 @@ if [ "$IS_DEV" = true ]; then
   # --- Category 12: Doc References (dev only) ---
   section "Doc References (dev)"
 
-  # Scan commands and agents for docs/ references
+  # Scan skills and agents for docs/ references
   DOC_REFS_MISSING=""
-  for src_file in "$CMD_DIR"/*.md "$AGENT_DIR"/*.md; do
+  for src_file in "$SKILL_DIR"/*/SKILL.md "$AGENT_DIR"/*.md; do
     [ -f "$src_file" ] || continue
     while IFS= read -r ref; do
       [ -z "$ref" ] && continue

package/scripts/afc-qa-audit.sh

@@ -452,7 +452,7 @@ check_d1_cache_divergence() {
   local diverged=0
   local checked=0
 
-  for subdir in commands scripts hooks; do
+  for subdir in skills scripts hooks; do
     local src_dir="$PROJECT_DIR/$subdir"
     local cache_subdir="$cache_version_dir/$subdir"
     [ -d "$src_dir" ] && [ -d "$cache_subdir" ] || continue

package/scripts/afc-sync-cache.sh

@@ -31,7 +31,7 @@ if [ ! -d "$CACHE_DIR" ]; then
 fi
 
 # Sync directories and files
-DIRS_TO_SYNC="commands agents scripts hooks docs schemas templates"
+DIRS_TO_SYNC="skills agents scripts hooks docs schemas templates"
 FILES_TO_SYNC="package.json"
 
 for dir in $DIRS_TO_SYNC; do

package/{commands/analyze.md → skills/analyze/SKILL.md}

@@ -32,16 +32,18 @@ If neither rules file nor config exists: read `CLAUDE.md` for architecture info.
 
 ### 1. Parse Analysis Intent
 
-Classify `$ARGUMENTS` into one of these analysis modes:
+Read the user's question semantically. What does the user actually want to understand? Select the mode that best serves their learning goal.
 
-| Mode | Trigger Keywords | Focus |
-|------|-----------------|-------|
-| **Root Cause** | "why", "cause", "bug", "error", "broken" | Error trace → data flow → hypothesis |
-| **Structural** | "how", "architecture", "flow", "trace", "structure" | Component relationships, call graphs, data flow |
-| **Exploratory** | "what", "find", "where", "which", "list" | File/function discovery, pattern matching |
-| **Comparative** | "difference", "compare", "vs", "between" | Side-by-side analysis of implementations |
+| Mode | When to select | Focus |
+|------|---------------|-------|
+| **Root Cause** | User wants to understand WHY something is broken, failing, or behaving unexpectedly — the goal is diagnosing a problem | Error trace → data flow → hypothesis |
+| **Structural** | User wants to understand HOW a system is built or how components relate — the goal is comprehension of design or flow | Component relationships, call graphs, data flow |
+| **Exploratory** | User wants to discover WHAT exists in the codebase — the goal is finding, listing, or locating things | File/function discovery, pattern matching |
+| **Comparative** | User wants to understand the DIFFERENCE between two or more things — the goal is contrast and tradeoff evaluation | Side-by-side analysis of implementations |
 
-If the intent doesn't clearly match a mode, default to **Exploratory**.
+If the question spans multiple modes, select the PRIMARY mode that best matches the user's core learning goal, and note secondary aspects to incorporate during analysis.
+
+If the intent doesn't clearly match a single mode, default to **Exploratory**.
 
 ### 2. Codebase Exploration
 

package/{commands/architect.md → skills/architect/SKILL.md}

@@ -53,8 +53,8 @@ Analyze `$ARGUMENTS` to identify the task type:
 
 Use Agent Teams for wide analysis scope (3+ modules) with parallel exploration:
 ```
-Task("analyze features/timeline", subagent_type: Explore)
-Task("analyze widgets/timeline", subagent_type: Explore)
+Task("analyze features/timeline", subagent_type: "Explore")
+Task("analyze widgets/timeline", subagent_type: "Explore")
 ```
 
 **Cross-Module Import Chain Verification** (after Explore agents return):
@@ -101,7 +101,7 @@ Structure analysis results and **print to console**:
 
 > **Always** read `${CLAUDE_PLUGIN_ROOT}/docs/critic-loop-rules.md` first and follow it.
 
-Run the critic loop until convergence. Safety cap: 7 passes (higher than the standard 5 because architecture analysis involves broader exploration across modules and layers).
+Run the critic loop until convergence. Safety cap: 5 passes.
 
 | Criterion | Validation |
 |-----------|------------|