all-for-claudecode 2.5.0 → 2.7.0

package/scripts/afc-user-prompt-submit.sh

@@ -2,9 +2,8 @@
 set -euo pipefail
 
 # UserPromptSubmit Hook: Two modes of operation:
-# 1. Pipeline INACTIVE: No action (routing handled by CLAUDE.md intent-based skill table)
+# 1. Pipeline INACTIVE: Detect user intent from prompt and inject specific skill routing hint
 # 2. Pipeline ACTIVE: Inject Phase/Feature context + drift checkpoint at thresholds
-# Exit 0 immediately if no action needed (minimize overhead)
 
 # shellcheck source=afc-state.sh
 . "$(dirname "$0")/afc-state.sh"
@@ -15,30 +14,116 @@ cleanup() {
 }
 trap cleanup EXIT
 
-# Consume stdin (required -- pipe breaks if not consumed)
-cat > /dev/null
+# Read stdin (contains user prompt JSON)
+INPUT=$(cat)
 
-# --- Branch: Pipeline INACTIVE → no action needed ---
-# Routing is handled by CLAUDE.md intent-based skill routing table.
-# The main model classifies user intent natively — no hook-level keyword matching.
+# --- Branch: Pipeline INACTIVE -> intent-based skill routing ---
+# The model has CLAUDE.md routing table but static instructions lose effectiveness
+# as context grows. Reading the actual prompt and suggesting a SPECIFIC skill
+# is far more actionable than a generic "check routing table" reminder.
 if ! afc_state_is_active; then
+
+  # Extract prompt text from stdin JSON
+  USER_TEXT=""
+  if command -v jq >/dev/null 2>&1; then
+    USER_TEXT=$(printf '%s' "$INPUT" | jq -r '.prompt // empty' 2>/dev/null || true)
+  else
+    # shellcheck disable=SC2001
+    # Note: sed fallback truncates at first embedded escaped quote — acceptable for keyword matching
+    USER_TEXT=$(printf '%s' "$INPUT" | sed 's/.*"prompt"[[:space:]]*:[[:space:]]*"//;s/".*//' 2>/dev/null || true)
+  fi
+
+  # Skip if prompt is already an explicit slash command
+  if printf '%s' "$USER_TEXT" | grep -qE '^\s*/afc:' 2>/dev/null; then
+    exit 0
+  fi
+
+  # Normalize: lowercase + truncate for matching
+  LOWER=$(printf '%s' "$USER_TEXT" | tr '[:upper:]' '[:lower:]' | cut -c1-500)
+
+  # Early exit for empty prompts (context-only messages, malformed JSON)
+  if [ -z "$LOWER" ]; then
+    if command -v jq >/dev/null 2>&1; then
+      jq -n --arg c "[afc] If this request matches an afc skill, invoke it via Skill tool. See CLAUDE.md routing table." \
+        '{"hookSpecificOutput":{"additionalContext":$c}}'
+    else
+      printf '{"hookSpecificOutput":{"additionalContext":"[afc] If this request matches an afc skill, invoke it via Skill tool. See CLAUDE.md routing table."}}\n'
+    fi
+    exit 0
+  fi
+
+  # Intent detection: priority-ordered if/elif chain.
+  # Each pattern targets strong-signal phrases to minimize false positives.
+  # The model retains final authority — this is a hint, not enforcement.
+  SKILL=""
+  # High confidence: distinctive multi-word or rare keywords
+  if printf '%s' "$LOWER" | grep -qE '(bug|broken|debug|not working|crash|exception)' 2>/dev/null; then
+    SKILL="afc:debug"
+  elif printf '%s' "$LOWER" | grep -qE '(code review|pr review)' 2>/dev/null; then
+    SKILL="afc:review"
+  elif printf '%s' "$LOWER" | grep -qE '(write test|add test|test coverage|improve coverage)' 2>/dev/null; then
+    SKILL="afc:test"
+  elif printf '%s' "$LOWER" | grep -qE '(security scan|security review|security audit|vulnerabilit)' 2>/dev/null; then
+    SKILL="afc:security"
+  elif printf '%s' "$LOWER" | grep -qE '(architecture|architect|system design)' 2>/dev/null; then
+    SKILL="afc:architect"
+  elif printf '%s' "$LOWER" | grep -qE '(doctor|health check|diagnose.*project)' 2>/dev/null; then
+    SKILL="afc:doctor"
+  elif printf '%s' "$LOWER" | grep -qE '(quality audit|qa audit|project quality)' 2>/dev/null; then
+    SKILL="afc:qa"
+  elif printf '%s' "$LOWER" | grep -qE '(new release|version bump|changelog|publish.*package)' 2>/dev/null; then
+    SKILL="afc:launch"
+  # Medium confidence: still distinctive but broader
+  elif printf '%s' "$LOWER" | grep -qE '(specification|requirements|acceptance criteria)' 2>/dev/null; then
+    SKILL="afc:spec"
+  elif printf '%s' "$LOWER" | grep -qE '(brainstorm|ideate|what to build|product brief)' 2>/dev/null; then
+    SKILL="afc:ideate"
+  elif printf '%s' "$LOWER" | grep -qE '(expert advice)' 2>/dev/null; then
+    SKILL="afc:consult"
+  elif printf '%s' "$LOWER" | grep -qE '(analyz|trace.*flow|how does.*work)' 2>/dev/null; then
+    SKILL="afc:analyze"
+  elif printf '%s' "$LOWER" | grep -qE '(research|investigat|compare.*lib)' 2>/dev/null; then
+    SKILL="afc:research"
+  # Lower confidence: common verbs
+  elif printf '%s' "$LOWER" | grep -qE '(implement|add feature|refactor|modify.*code)' 2>/dev/null; then
+    SKILL="afc:implement"
+  elif printf '%s' "$LOWER" | grep -qE '(review)' 2>/dev/null; then
+    SKILL="afc:review"
+  elif printf '%s' "$LOWER" | grep -qE '(spec[^a-z]|spec$)' 2>/dev/null; then
+    SKILL="afc:spec"
+  elif printf '%s' "$LOWER" | grep -qE '(plan[^a-z]|plan$)' 2>/dev/null; then
+    SKILL="afc:plan"
+  fi
+
+  # Build output (no TASK HYGIENE in inactive mode — stop-gate handles cleanup scope)
+  if [ -n "$SKILL" ]; then
+    HINT="[afc:route -> ${SKILL}] Detected intent from user prompt. Invoke /${SKILL} via Skill tool."
+  else
+    HINT="[afc] If this request matches an afc skill, invoke it via Skill tool. See CLAUDE.md routing table."
+  fi
+
+  if command -v jq >/dev/null 2>&1; then
+    jq -n --arg c "$HINT" '{"hookSpecificOutput":{"additionalContext":$c}}'
+  else
+    printf '{"hookSpecificOutput":{"additionalContext":"%s"}}\n' "$HINT"
+  fi
   exit 0
 fi
 
-# --- Branch: Pipeline ACTIVE → existing Phase/Feature context ---
+# --- Branch: Pipeline ACTIVE -> existing Phase/Feature context ---
 
-# Read Feature/Phase + JSON-safe processing (strip special characters)
+# Read Feature/Phase + JSON-safe processing (strip special characters + newlines)
 FEATURE="$(afc_state_read feature || echo '')"
-FEATURE="$(printf '%s' "$FEATURE" | tr -d '"' | cut -c1-100)"
+FEATURE="$(printf '%s' "$FEATURE" | tr -d '"\n\r' | cut -c1-100)"
 PHASE="$(afc_state_read phase || echo 'unknown')"
-PHASE="$(printf '%s' "$PHASE" | tr -d '"' | cut -c1-100)"
+PHASE="$(printf '%s' "$PHASE" | tr -d '"\n\r' | cut -c1-100)"
 
 # Increment per-phase prompt counter + pipeline-wide total
 CALL_COUNT=$(afc_state_increment promptCount 2>/dev/null || echo 0)
 afc_state_increment totalPromptCount >/dev/null 2>&1 || echo "[afc:prompt-submit] totalPromptCount increment failed" >&2
 
 # Build context message
-CONTEXT="[Pipeline: ${FEATURE}] [Phase: ${PHASE}]"
+CONTEXT="[Pipeline: ${FEATURE}] [Phase: ${PHASE}] [TASK HYGIENE: Mark completed tasks via TaskUpdate(status: completed) -- do not leave stale tasks]"
 
 # Drift checkpoint: inject plan constraints at every N prompts during implement/review
 # AFC_DRIFT_THRESHOLD sourced from afc-state.sh (SSOT)
@@ -53,7 +138,7 @@ fi
 
 # Output additionalContext to stdout (injected into Claude context)
 # Use jq for safe JSON encoding; printf fallback strips remaining quotes
-if command -v jq &> /dev/null; then
+if command -v jq >/dev/null 2>&1; then
   jq -n --arg c "$CONTEXT" '{"hookSpecificOutput":{"additionalContext":$c}}'
 else
   SAFE_CONTEXT="${CONTEXT//\\/\\\\}"

package/scripts/pre-compact-checkpoint.sh

@@ -79,14 +79,14 @@ fi
 # Guard against empty lists
 if [ -n "$MODIFIED" ]; then
   # shellcheck disable=SC2001
-  MODIFIED_LIST=$(echo "$MODIFIED" | sed 's/^/  - /')
+  MODIFIED_LIST=$(printf '%s\n' "$MODIFIED" | sed 's/^/  - /')
 else
   MODIFIED_LIST="  (none)"
 fi
 
 if [ -n "$STAGED" ]; then
   # shellcheck disable=SC2001
-  STAGED_LIST=$(echo "$STAGED" | sed 's/^/  - /')
+  STAGED_LIST=$(printf '%s\n' "$STAGED" | sed 's/^/  - /')
 else
   STAGED_LIST="  (none)"
 fi

package/scripts/session-start-context.sh

@@ -30,9 +30,11 @@ ENCODED_PATH="${PROJECT_PATH//\//-}"
 MEMORY_DIR="$HOME/.claude/projects/$ENCODED_PATH/memory"
 CHECKPOINT="$MEMORY_DIR/checkpoint.md"
 OUTPUT=""
+PIPELINE_ACTIVE=0
 
 # 1. Check for active pipeline
 if afc_state_is_active; then
+  PIPELINE_ACTIVE=1
   FEATURE=$(afc_state_read feature || true)
   OUTPUT="[AFC PIPELINE ACTIVE] Feature: $FEATURE"
 
@@ -49,20 +51,47 @@ if afc_state_is_active; then
   if [ -n "$CI_TIMESTAMP" ]; then
     OUTPUT="$OUTPUT | Last CI: PASSED ($CI_TIMESTAMP)"
   fi
+elif [ -f "$PROJECT_DIR/.claude/.afc-state.json" ]; then
+  # 1a. Zombie state cleanup — file exists but afc_state_is_active returned false
+  rm -f "$PROJECT_DIR/.claude/.afc-state.json"
+  OUTPUT="${OUTPUT:+$OUTPUT | }[ZOMBIE STATE CLEANED] Removed invalid .afc-state.json"
 fi
 
-# 2. Check if checkpoint exists (project-local first, fallback to auto-memory)
+# 1b. Version mismatch detection
+PLUGIN_ROOT="$(cd "$(dirname "$0")/.." && pwd)"
+if [ -f "$PLUGIN_ROOT/package.json" ]; then
+  # Read plugin version
+  if command -v jq >/dev/null 2>&1; then
+    PLUGIN_VERSION=$(jq -r '.version // empty' "$PLUGIN_ROOT/package.json" 2>/dev/null || true)
+  else
+    PLUGIN_VERSION=$(grep -o '"version"[[:space:]]*:[[:space:]]*"[^"]*"' "$PLUGIN_ROOT/package.json" 2>/dev/null | head -1 | sed 's/.*: *"//;s/"//') || true
+  fi
+
+  if [ -n "${PLUGIN_VERSION:-}" ]; then
+    # Read AFC block version from global CLAUDE.md
+    GLOBAL_CLAUDE="$HOME/.claude/CLAUDE.md"
+    if [ -f "$GLOBAL_CLAUDE" ]; then
+      BLOCK_VERSION=$(grep -o 'AFC:VERSION:[0-9][0-9.]*' "$GLOBAL_CLAUDE" 2>/dev/null | head -1 | sed 's/AFC:VERSION://' || true)
+      if [ -n "${BLOCK_VERSION:-}" ] && [ "$BLOCK_VERSION" != "$PLUGIN_VERSION" ]; then
+        OUTPUT="${OUTPUT:+$OUTPUT | }[AFC VERSION MISMATCH] v$PLUGIN_VERSION installed but CLAUDE.md block is v$BLOCK_VERSION. Run /afc:init to update."
+      fi
+    fi
+  fi
+fi
+
+# 2. Auto-memory checkpoint cleanup (prevent stale context pollution)
+# Auto-memory files are auto-loaded into every conversation by Claude Code.
+# Stale checkpoints from previous sessions can confuse the model.
+# Only remove auto-memory when project-local copy also exists (prevents stranded checkpoint data loss).
 LOCAL_CHECKPOINT="$PROJECT_DIR/.claude/afc/memory/checkpoint.md"
-CHECKPOINT_FILE=""
-if [ -f "$LOCAL_CHECKPOINT" ]; then
-  CHECKPOINT_FILE="$LOCAL_CHECKPOINT"
-elif [ -f "$CHECKPOINT" ]; then
-  CHECKPOINT_FILE="$CHECKPOINT"
+if [ "$PIPELINE_ACTIVE" -eq 0 ] && [ -f "$CHECKPOINT" ] && [ -f "$LOCAL_CHECKPOINT" ]; then
+  rm -f "$CHECKPOINT"
 fi
 
-if [ -n "$CHECKPOINT_FILE" ]; then
-  RAW_LINE=$(grep 'Auto-generated:' "$CHECKPOINT_FILE" 2>/dev/null || echo "")
-  FIRST_LINE=$(echo "$RAW_LINE" | head -1)
+# 3. Check if project-local checkpoint exists (for user notification only)
+if [ -f "$LOCAL_CHECKPOINT" ]; then
+  RAW_LINE=$(grep 'Auto-generated:' "$LOCAL_CHECKPOINT" 2>/dev/null || echo "")
+  FIRST_LINE=$(printf '%s\n' "$RAW_LINE" | head -1)
   CHECKPOINT_DATE="${FIRST_LINE##*Auto-generated: }"
   if [ -n "$CHECKPOINT_DATE" ]; then
     if [ -n "$OUTPUT" ]; then
@@ -73,7 +102,7 @@ if [ -n "$CHECKPOINT_FILE" ]; then
   fi
 fi
 
-# 3. Check for safety tag
+# 4. Check for safety tag
 HAS_SAFETY_TAG=$(cd "$PROJECT_DIR" 2>/dev/null && git tag -l 'afc/pre-*' 2>/dev/null | head -1 || echo "")
 if [ -n "$HAS_SAFETY_TAG" ]; then
   if [ -n "$OUTPUT" ]; then

package/scripts/track-afc-changes.sh

@@ -14,14 +14,14 @@ cleanup() {
 }
 trap cleanup EXIT
 
+# Consume stdin immediately (prevents SIGPIPE if exiting early)
+INPUT=$(cat)
+
 # If pipeline is inactive -> skip
 if ! afc_state_is_active; then
   exit 0
 fi
 
-# Parse tool input from stdin
-INPUT=$(cat)
-
 # Skip if stdin is empty
 if [ -z "$INPUT" ]; then
   exit 0