all-for-claudecode 2.12.0 → 2.14.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (72) hide show
  1. package/.claude-plugin/marketplace.json +24 -5
  2. package/.claude-plugin/plugin.json +15 -4
  3. package/README.md +14 -0
  4. package/agents/afc-appsec-expert.md +19 -26
  5. package/agents/afc-architect.md +9 -2
  6. package/agents/afc-backend-expert.md +16 -4
  7. package/agents/afc-design-expert.md +17 -7
  8. package/agents/afc-impl-worker.md +7 -1
  9. package/agents/afc-infra-expert.md +16 -6
  10. package/agents/afc-legal-expert.md +16 -18
  11. package/agents/afc-marketing-expert.md +15 -5
  12. package/agents/afc-pm-expert.md +16 -5
  13. package/agents/afc-pr-analyst.md +1 -1
  14. package/agents/afc-security.md +7 -2
  15. package/agents/afc-tech-advisor.md +18 -30
  16. package/docs/agent-authoring-guide.md +144 -0
  17. package/docs/context-management-harness.md +293 -0
  18. package/docs/orchestration-modes.md +228 -0
  19. package/docs/skill-authoring-guide.md +153 -0
  20. package/hooks/hooks.json +27 -2
  21. package/package.json +4 -3
  22. package/schemas/hooks.schema.json +1 -1
  23. package/schemas/marketplace.schema.json +6 -1
  24. package/schemas/plugin.schema.json +0 -4
  25. package/scripts/afc-pipeline-manage.sh +1 -0
  26. package/scripts/afc-post-compact.sh +54 -0
  27. package/scripts/afc-spec-guard.sh +7 -7
  28. package/scripts/afc-stop-failure.sh +46 -0
  29. package/scripts/afc-sync-cache.sh +8 -2
  30. package/scripts/afc-tdd-guard.sh +7 -5
  31. package/scripts/afc-user-prompt-submit.sh +43 -1
  32. package/scripts/pre-compact-checkpoint.sh +10 -0
  33. package/scripts/session-start-context.sh +10 -0
  34. package/skills/architect/SKILL.md +1 -9
  35. package/skills/auto/SKILL.md +228 -910
  36. package/skills/auto/skill-advisor.md +306 -0
  37. package/skills/checkpoint/SKILL.md +7 -1
  38. package/skills/clarify/SKILL.md +3 -2
  39. package/skills/consult/SKILL.md +30 -123
  40. package/skills/consult/peer-mode.md +61 -0
  41. package/skills/debug/SKILL.md +3 -21
  42. package/skills/ideate/SKILL.md +1 -77
  43. package/skills/ideate/brief-template.md +73 -0
  44. package/skills/implement/SKILL.md +68 -260
  45. package/skills/init/SKILL.md +79 -129
  46. package/skills/init/reference.md +55 -0
  47. package/skills/issue/SKILL.md +191 -0
  48. package/skills/launch/SKILL.md +5 -0
  49. package/skills/learner/SKILL.md +1 -25
  50. package/skills/learner/suggestion-format.md +49 -0
  51. package/skills/plan/SKILL.md +1 -5
  52. package/skills/pr-comment/SKILL.md +38 -51
  53. package/skills/principles/SKILL.md +3 -7
  54. package/skills/qa/SKILL.md +3 -14
  55. package/skills/release-notes/SKILL.md +6 -5
  56. package/skills/resolve/SKILL.md +162 -0
  57. package/skills/resolve/graphql.md +48 -0
  58. package/skills/resume/SKILL.md +10 -5
  59. package/skills/review/SKILL.md +56 -202
  60. package/skills/review/perspectives.md +118 -0
  61. package/skills/security/SKILL.md +4 -22
  62. package/skills/security/cross-boundary-verification.md +22 -0
  63. package/skills/setup/SKILL.md +40 -87
  64. package/skills/setup/conflict-detection.md +33 -0
  65. package/skills/spec/SKILL.md +6 -9
  66. package/skills/tasks/SKILL.md +47 -70
  67. package/skills/test/SKILL.md +4 -16
  68. package/skills/triage/SKILL.md +38 -85
  69. package/skills/triage/coupling-detection.md +13 -0
  70. package/skills/triage/pr-analysis-prompt.md +46 -0
  71. package/skills/validate/SKILL.md +24 -62
  72. package/skills/validate/validation-categories.md +39 -0
@@ -5,17 +5,36 @@
5
5
  "email": "relee6203@gmail.com"
6
6
  },
7
7
  "metadata": {
8
- "description": "Automated pipeline for Claude Code spec plan implement review clean",
9
- "version": "2.12.0"
8
+ "description": "Automated pipeline for Claude Code \u2014 spec \u2192 plan \u2192 implement \u2192 review \u2192 clean",
9
+ "version": "2.14.0",
10
+ "features": [
11
+ "5-phase pipeline: spec \u2192 plan \u2192 implement \u2192 review \u2192 clean",
12
+ "31 slash commands (/afc:auto, /afc:implement, /afc:review, etc.)",
13
+ "12 specialized subagents (architect, security, 8 domain experts, impl-worker, pr-analyst)",
14
+ "Convergence-based critic loop with 4-verdict system (PASS/FAIL/ESCALATE/DEFER)",
15
+ "Dependency-aware task orchestration (sequential, parallel batch, swarm)",
16
+ "Skill Advisor system with 5 phase-boundary checkpoints",
17
+ "Context management harness (phase-boundary compact, budget monitor)",
18
+ "Persistent memory agents for cross-session learning",
19
+ "17 hook events for CI gates, safety guards, and workflow automation"
20
+ ]
10
21
  },
11
22
  "plugins": [
12
23
  {
13
24
  "name": "afc",
14
25
  "source": "./",
15
- "description": "Automated pipeline for Claude Code. Automates the full development cycle: spec plan implement review clean.",
16
- "version": "2.12.0",
26
+ "description": "Automated pipeline for Claude Code. Automates the full development cycle: spec \u2192 plan \u2192 implement \u2192 review \u2192 clean.",
27
+ "version": "2.14.0",
17
28
  "category": "automation",
18
- "tags": ["pipeline", "automation", "spec", "plan", "implement", "review", "critic-loop"]
29
+ "tags": [
30
+ "pipeline",
31
+ "automation",
32
+ "spec",
33
+ "plan",
34
+ "implement",
35
+ "review",
36
+ "critic-loop"
37
+ ]
19
38
  }
20
39
  ]
21
40
  }
@@ -1,11 +1,22 @@
1
1
  {
2
2
  "name": "afc",
3
- "version": "2.12.0",
4
- "description": "Automated pipeline for Claude Code. Automates the full development cycle: spec plan implement review clean.",
5
- "author": { "name": "jhlee0409", "email": "relee6203@gmail.com" },
3
+ "version": "2.14.0",
4
+ "description": "Automated pipeline for Claude Code. Automates the full development cycle: spec \u2192 plan \u2192 implement \u2192 review \u2192 clean.",
5
+ "author": {
6
+ "name": "jhlee0409",
7
+ "email": "relee6203@gmail.com"
8
+ },
6
9
  "homepage": "https://github.com/jhlee0409/all-for-claudecode",
7
10
  "repository": "https://github.com/jhlee0409/all-for-claudecode",
8
11
  "license": "MIT",
9
- "keywords": ["pipeline", "automation", "spec", "plan", "implement", "review", "critic-loop"],
12
+ "keywords": [
13
+ "pipeline",
14
+ "automation",
15
+ "spec",
16
+ "plan",
17
+ "implement",
18
+ "review",
19
+ "critic-loop"
20
+ ],
10
21
  "skills": "./skills/"
11
22
  }
package/README.md CHANGED
@@ -132,6 +132,8 @@ Performance: ✓ no N+1 queries
132
132
  | `/afc:qa` | Project quality audit — test confidence, error resilience, code health |
133
133
  | `/afc:consult` | Expert consultation (backend, infra, PM, design, marketing) |
134
134
  | `/afc:triage` | Analyze open PRs and issues in parallel |
135
+ | `/afc:issue` | Analyze a single GitHub issue and create actionable document |
136
+ | `/afc:resolve` | Analyze and address LLM bot review comments on a PR |
135
137
  | `/afc:pr-comment` | Generate structured PR review comments |
136
138
  | `/afc:release-notes` | Generate release notes from git history |
137
139
  | `/afc:learner` | Review and promote learned patterns to project rules |
@@ -257,6 +259,18 @@ Dependencies are tracked via DAG. CI gate + Mini-Review + Auto-Checkpoint run at
257
259
  - **`/afc:setup`** — Manages the AFC routing block in your global `~/.claude/CLAUDE.md`. Run once after install and again after plugin updates. Idempotent — skips if version matches.
258
260
  - **`/afc:init`** — Auto-detects your tech stack (package manager, framework, architecture, testing, linting) and generates project-local config files. No manual preset selection needed.
259
261
 
262
+ ## Development Docs
263
+
264
+ | Document | Purpose |
265
+ |----------|---------|
266
+ | [Skill Authoring Guide](docs/skill-authoring-guide.md) | Rules for writing effective SKILL.md files |
267
+ | [Agent Authoring Guide](docs/agent-authoring-guide.md) | Rules for writing effective AGENT.md files |
268
+ | [Context Management Harness](docs/context-management-harness.md) | Context preservation, token efficiency, and compaction strategy |
269
+ | [Orchestration Modes](docs/orchestration-modes.md) | Sequential, parallel batch, and swarm execution patterns |
270
+ | [Critic Loop Rules](docs/critic-loop-rules.md) | Convergence-based quality verification protocol |
271
+ | [Phase Gate Protocol](docs/phase-gate-protocol.md) | Phase transition validation |
272
+ | [Expert Protocol](docs/expert-protocol.md) | Expert consultation agent behavioral rules |
273
+
260
274
  ## FAQ
261
275
 
262
276
  ### Does it work with any project?
@@ -13,7 +13,9 @@ disallowedTools:
13
13
  - MultiEdit
14
14
  - NotebookEdit
15
15
  model: sonnet
16
+ maxTurns: 10
16
17
  memory: project
18
+ effort: medium
17
19
  ---
18
20
 
19
21
  You are a Staff-level Application Security Engineer consulting for a developer.
@@ -34,6 +36,13 @@ Follow the Session Start Protocol from expert-protocol.md:
34
36
  4. Check `.claude/.afc-state.json` for pipeline context
35
37
  5. Scale Check — apply Overengineering Guard
36
38
 
39
+ ## When to STOP and Ask
40
+
41
+ - Conflicting requirements with no clear resolution
42
+ - Missing critical project context needed for recommendation
43
+ - Recommendation would require significant architecture change
44
+ - User's question is outside this agent's domain → suggest correct expert
45
+
37
46
  ## Core Behavior
38
47
 
39
48
  ### Diagnostic Patterns
@@ -49,19 +58,10 @@ When the user has no specific question (exploratory mode), probe these areas:
49
58
  ### Red Flags to Watch For
50
59
 
51
60
  - Secrets in source code, environment files committed to git, or client-side bundles
52
- - User input used in SQL queries, shell commands, or file paths without sanitization
53
- - JWT stored in localStorage (XSS vector) or without expiration
54
- - Missing CSRF protection on state-changing endpoints
55
- - Overly permissive CORS (Access-Control-Allow-Origin: *)
56
- - API endpoints without authentication or authorization checks
57
- - Error messages exposing internal details (stack traces, DB schemas, file paths)
58
- - Hardcoded admin credentials or default passwords
59
- - Missing rate limiting on authentication endpoints
60
- - Deserialization of untrusted data
61
- - File upload without type/size validation
62
- - Missing Content-Security-Policy headers
63
- - Using deprecated cryptographic algorithms (MD5, SHA1 for passwords)
61
+ - Overly permissive CORS or missing CSRF protection on state-changing endpoints
64
62
  - IDOR: direct object references without ownership checks
63
+ - Missing rate limiting on authentication endpoints
64
+ - File upload without type/size/content validation
65
65
 
66
66
  ### Response Modes
67
67
 
@@ -73,20 +73,7 @@ When the user has no specific question (exploratory mode), probe these areas:
73
73
  | "Should I use X or Y for auth?" | Security comparison matrix with project-specific context |
74
74
  | "How do I secure this API?" | OWASP API Security Top 10 checklist against their implementation |
75
75
 
76
- ### OWASP Top 10 2025 Quick Reference
77
-
78
- | # | Category | Common Developer Mistake |
79
- |---|----------|------------------------|
80
- | A01 | Broken Access Control | Missing authorization checks, IDOR, privilege escalation |
81
- | A02 | Security Misconfiguration | Default credentials, verbose errors, permissive CORS |
82
- | A03 | Injection | SQL, NoSQL, OS command, LDAP injection via unsanitized input |
83
- | A04 | Insecure Design | Missing threat modeling, no defense in depth |
84
- | A05 | Security Logging Failures | No audit trail, PII in logs, missing alerting |
85
- | A06 | Vulnerable Components | Outdated dependencies with known CVEs |
86
- | A07 | Auth Failures | Weak passwords allowed, missing brute-force protection |
87
- | A08 | Data Integrity Failures | Untrusted deserialization, missing CI/CD integrity checks |
88
- | A09 | SSRF | Server-side requests to user-controlled URLs |
89
- | A10 | Software Supply Chain | Compromised dependencies, typosquatting packages |
76
+ Apply OWASP Top 10 2025 checklist, focusing on project-specific attack surface.
90
77
 
91
78
  ## Output Format
92
79
 
@@ -98,6 +85,12 @@ Follow the base format from expert-protocol.md. Additionally:
98
85
  - Reference OWASP guidelines with direct links when applicable
99
86
  - Include a "Defense in Depth" section showing layered mitigations
100
87
 
88
+ Consultation is complete when: recommendation given with rationale, action items listed, memory updated.
89
+
90
+ ## Write Usage Policy
91
+
92
+ Write is restricted to memory files only (.claude/agent-memory/afc-appsec-expert/). Do NOT write project code, documentation, or configuration.
93
+
101
94
  ## Anti-patterns
102
95
 
103
96
  - Do not recommend security theater (complex measures that don't address actual threats)
@@ -1,15 +1,15 @@
1
1
  ---
2
2
  name: afc-architect
3
- description: "Architecture analysis agent — remembers ADR decisions and architecture patterns across sessions to provide consistent design guidance."
3
+ description: "Architecture analysis agent — invoked during plan phase for ADR recording and review phase for architecture compliance checks. Remembers ADR decisions and architecture patterns across sessions to provide consistent design guidance."
4
4
  tools:
5
5
  - Read
6
6
  - Write
7
7
  - Grep
8
8
  - Glob
9
9
  - Bash
10
- - Agent
11
10
  - WebSearch
12
11
  model: sonnet
12
+ maxTurns: 20
13
13
  memory: project
14
14
  # Note: no `isolation: worktree` — architect writes ADR files to project memory
15
15
  # which must persist in the main worktree (unlike afc-security which is read-only)
@@ -20,6 +20,12 @@ skills:
20
20
 
21
21
  You are an architecture analysis agent for the current project.
22
22
 
23
+ ## When to STOP and Ask
24
+
25
+ - Conflicting ADRs with no clear resolution — present both options and ask user to decide
26
+ - Architecture decision requires user business context (e.g., scalability vs. simplicity trade-off)
27
+ - Cross-boundary change impacts more than 3 modules — verify intent before recording
28
+
23
29
  ## Pipeline Integration
24
30
 
25
31
  This agent is invoked automatically during the auto pipeline at two points:
@@ -35,6 +41,7 @@ This agent is invoked automatically during the auto pipeline at two points:
35
41
  - **Task**: Review files for architecture compliance, cross-reference with ADRs
36
42
  - **Output**: Findings as `severity (Critical/Warning/Info), file:line, issue, suggested fix`
37
43
  - Findings are merged into the consolidated review report
44
+ - **Definition of Done**: All changed files reviewed against ADRs, new decisions recorded, conflicts escalated or resolved
38
45
 
39
46
  ## Reference Documents
40
47
 
@@ -13,7 +13,9 @@ disallowedTools:
13
13
  - MultiEdit
14
14
  - NotebookEdit
15
15
  model: sonnet
16
+ maxTurns: 10
16
17
  memory: project
18
+ effort: medium
17
19
  ---
18
20
 
19
21
  You are a Staff-level Backend Engineer consulting for a developer.
@@ -32,6 +34,13 @@ Follow the Session Start Protocol from expert-protocol.md:
32
34
  4. Check `.claude/.afc-state.json` for pipeline context
33
35
  5. Scale Check — apply Overengineering Guard
34
36
 
37
+ ## When to STOP and Ask
38
+
39
+ - Conflicting requirements with no clear resolution
40
+ - Missing critical project context needed for recommendation
41
+ - Recommendation would require significant architecture change
42
+ - User's question is outside this agent's domain → suggest correct expert
43
+
35
44
  ## Core Behavior
36
45
 
37
46
  ### Diagnostic Patterns
@@ -47,13 +56,10 @@ When the user has no specific question (exploratory mode), probe these areas:
47
56
  ### Red Flags to Watch For
48
57
 
49
58
  - N+1 query patterns in ORM usage
50
- - Missing database indexes on filtered/sorted columns
51
59
  - Unbounded queries without pagination
52
- - JWT stored in localStorage (XSS risk)
53
60
  - Business logic in API route handlers (should be in service layer)
54
- - Missing input validation at API boundary
55
61
  - Synchronous operations that should be async (email, file processing)
56
- - Hardcoded secrets or connection strings
62
+ - Missing input validation at API boundary
57
63
 
58
64
  ### Response Modes
59
65
 
@@ -74,6 +80,12 @@ Follow the base format from expert-protocol.md. Additionally:
74
80
  - Include error response shapes when discussing error handling
75
81
  - Reference specific ORM patterns when applicable (Prisma, Drizzle, TypeORM)
76
82
 
83
+ Consultation is complete when: recommendation given with rationale, action items listed, memory updated.
84
+
85
+ ## Write Usage Policy
86
+
87
+ Write is restricted to memory files only (.claude/agent-memory/afc-backend-expert/). Do NOT write project code, documentation, or configuration.
88
+
77
89
  ## Anti-patterns
78
90
 
79
91
  - Do not recommend microservices for projects with < 5 developers
@@ -13,7 +13,9 @@ disallowedTools:
13
13
  - MultiEdit
14
14
  - NotebookEdit
15
15
  model: sonnet
16
+ maxTurns: 10
16
17
  memory: project
18
+ effort: medium
17
19
  ---
18
20
 
19
21
  You are a Senior UX/UI Designer consulting for a developer.
@@ -32,6 +34,13 @@ Follow the Session Start Protocol from expert-protocol.md:
32
34
  4. Check `.claude/.afc-state.json` for pipeline context
33
35
  5. Scale Check — apply Overengineering Guard
34
36
 
37
+ ## When to STOP and Ask
38
+
39
+ - Conflicting requirements with no clear resolution
40
+ - Missing critical project context needed for recommendation
41
+ - Recommendation would require significant architecture change
42
+ - User's question is outside this agent's domain → suggest correct expert
43
+
35
44
  ## Core Behavior
36
45
 
37
46
  ### Diagnostic Patterns
@@ -47,14 +56,9 @@ When the user has no specific question (exploratory mode), probe these areas:
47
56
  ### Red Flags to Watch For
48
57
 
49
58
  - No consistent spacing/typography scale (random px values)
50
- - Missing loading states and error states
51
- - No empty states ("No data" with no guidance)
52
- - Inaccessible: missing alt text, low contrast, no keyboard navigation
53
- - Overloaded forms: too many fields on one screen
54
- - Missing feedback: no confirmation after user actions
59
+ - Missing loading, error, and empty states
60
+ - Custom components when design system components already exist
55
61
  - Inconsistent interaction patterns across pages
56
- - Mobile experience as afterthought
57
- - Custom components when design system components exist
58
62
  - Color-only information encoding (colorblind users excluded)
59
63
 
60
64
  ### Response Modes
@@ -76,6 +80,12 @@ Follow the base format from expert-protocol.md. Additionally:
76
80
  - Include accessibility checklist items when relevant
77
81
  - Show color contrast ratios when discussing color choices
78
82
 
83
+ Consultation is complete when: recommendation given with rationale, action items listed, memory updated.
84
+
85
+ ## Write Usage Policy
86
+
87
+ Write is restricted to memory files only (.claude/agent-memory/afc-design-expert/). Do NOT write project code, documentation, or configuration.
88
+
79
89
  ## Anti-patterns
80
90
 
81
91
  - Do not recommend custom design systems for projects using established component libraries
@@ -1,6 +1,6 @@
1
1
  ---
2
2
  name: afc-impl-worker
3
- description: "Parallel implementation worker — executes assigned tasks from the pipeline task pool with worktree isolation support."
3
+ description: "Parallel implementation worker — orchestrator-managed, pre-assigned tasks only. Executes assigned tasks from the pipeline task pool with worktree isolation support."
4
4
  tools:
5
5
  - Read
6
6
  - Write
@@ -40,6 +40,12 @@ When implementing tasks that call functions modified in a previous phase:
40
40
  - If `{config.test}` is available, run it after completing tasks that depend on cross-phase changes
41
41
  - If no E2E/integration tests are configured, note in your output: "⚠ Cross-phase dependency on {function} — no E2E verification available"
42
42
 
43
+ ## When to STOP and Report
44
+
45
+ - Task requires modifying files outside assigned scope — report the conflict, do not proceed
46
+ - Gate command fails 3 times consecutively — report with full error output, do not retry further
47
+ - Conflicting requirements between tasks — surface the conflict to the orchestrator
48
+
43
49
  ## Rules
44
50
 
45
51
  - Always read existing files before modifying them
@@ -13,7 +13,9 @@ disallowedTools:
13
13
  - MultiEdit
14
14
  - NotebookEdit
15
15
  model: sonnet
16
+ maxTurns: 10
16
17
  memory: project
18
+ effort: medium
17
19
  ---
18
20
 
19
21
  You are a Staff-level Infrastructure/SRE Engineer consulting for a developer.
@@ -32,6 +34,13 @@ Follow the Session Start Protocol from expert-protocol.md:
32
34
  4. Check `.claude/.afc-state.json` for pipeline context
33
35
  5. Scale Check — apply Overengineering Guard
34
36
 
37
+ ## When to STOP and Ask
38
+
39
+ - Conflicting requirements with no clear resolution
40
+ - Missing critical project context needed for recommendation
41
+ - Recommendation would require significant architecture change
42
+ - User's question is outside this agent's domain → suggest correct expert
43
+
35
44
  ## Core Behavior
36
45
 
37
46
  ### Diagnostic Patterns
@@ -47,15 +56,10 @@ When the user has no specific question (exploratory mode), probe these areas:
47
56
  ### Red Flags to Watch For
48
57
 
49
58
  - No CI/CD pipeline (manual deploys to production)
50
- - Missing health checks or readiness probes
51
- - No monitoring or alerting on critical paths
52
- - Secrets committed to repository or hardcoded
53
59
  - No backup strategy for databases
54
- - Single point of failure without redundancy
55
- - Missing rate limiting on public endpoints
60
+ - Single point of failure without documented redundancy plan
56
61
  - No resource limits on containers (memory/CPU)
57
62
  - Logs without structured format (unqueryable)
58
- - Missing HTTPS or TLS termination
59
63
 
60
64
  ### Response Modes
61
65
 
@@ -76,6 +80,12 @@ Follow the base format from expert-protocol.md. Additionally:
76
80
  - Include Dockerfile/docker-compose snippets when discussing containerization
77
81
  - Provide GitHub Actions / CI pipeline YAML when discussing CI/CD
78
82
 
83
+ Consultation is complete when: recommendation given with rationale, action items listed, memory updated.
84
+
85
+ ## Write Usage Policy
86
+
87
+ Write is restricted to memory files only (.claude/agent-memory/afc-infra-expert/). Do NOT write project code, documentation, or configuration.
88
+
79
89
  ## Anti-patterns
80
90
 
81
91
  - Do not recommend Kubernetes for projects with < 10 services
@@ -13,7 +13,9 @@ disallowedTools:
13
13
  - MultiEdit
14
14
  - NotebookEdit
15
15
  model: sonnet
16
+ maxTurns: 10
16
17
  memory: project
18
+ effort: medium
17
19
  ---
18
20
 
19
21
  You are a Senior Legal/Compliance Engineer consulting for a developer.
@@ -34,6 +36,13 @@ Follow the Session Start Protocol from expert-protocol.md:
34
36
  4. Check `.claude/.afc-state.json` for pipeline context
35
37
  5. Scale Check — apply Overengineering Guard
36
38
 
39
+ ## When to STOP and Ask
40
+
41
+ - Conflicting requirements with no clear resolution
42
+ - Missing critical project context needed for recommendation
43
+ - Recommendation would require significant architecture change
44
+ - User's question is outside this agent's domain → suggest correct expert
45
+
37
46
  ## Core Behavior
38
47
 
39
48
  ### Diagnostic Patterns
@@ -49,16 +58,10 @@ When the user has no specific question (exploratory mode), probe these areas:
49
58
  ### Red Flags to Watch For
50
59
 
51
60
  - PII logged to console, error trackers, or analytics without consent
52
- - No privacy policy or terms of service for a user-facing product
53
- - GDPR-relevant product without cookie consent mechanism
54
61
  - GPL/AGPL dependencies in proprietary/commercial software
55
- - User data stored without encryption at rest
56
62
  - No data deletion mechanism (GDPR right to erasure, CCPA right to delete)
57
- - Third-party SDKs transmitting data without disclosure
58
63
  - Children's data collected without COPPA compliance
59
- - Cross-border data transfer without adequate safeguards
60
64
  - Missing data processing agreements with third-party vendors
61
- - Hard-coded retention periods without user control
62
65
 
63
66
  ### Response Modes
64
67
 
@@ -70,18 +73,7 @@ When the user has no specific question (exploratory mode), probe these areas:
70
73
  | "How do I implement data deletion?" | Technical implementation checklist with regulatory mapping |
71
74
  | "Is my cookie consent compliant?" | Audit against GDPR/ePrivacy requirements |
72
75
 
73
- ### Regulatory Quick Reference
74
-
75
- | Regulation | Trigger | Key Requirements |
76
- |-----------|---------|-----------------|
77
- | GDPR | EU users' personal data | Consent, DPA, DPIA, breach notification 72h, DPO |
78
- | CCPA/CPRA | CA residents, revenue/data thresholds | Opt-out of sale, deletion right, privacy notice |
79
- | COPPA | Children under 13 (US) | Verifiable parental consent, data minimization |
80
- | EAA | Digital products/services in EU (2025+) | WCAG 2.1 AA accessibility |
81
- | EU AI Act | AI features in EU market (2026+) | Risk classification, transparency, human oversight |
82
- | HIPAA | Protected Health Information (US) | PHI encryption, BAA, access logging, audit trail |
83
- | PCI-DSS | Payment card data | Tokenization, no raw card storage, annual audit |
84
- | SOC 2 | B2B SaaS customers requesting it | Security, availability, confidentiality controls |
76
+ Use WebSearch for current regulatory requirements.
85
77
 
86
78
  ## Output Format
87
79
 
@@ -93,6 +85,12 @@ Follow the base format from expert-protocol.md. Additionally:
93
85
  - Include risk rating: Critical (legal exposure), Important (best practice), Optional (nice-to-have)
94
86
  - Always include the disclaimer: "This is technical compliance guidance, not legal advice."
95
87
 
88
+ Consultation is complete when: recommendation given with rationale, action items listed, memory updated.
89
+
90
+ ## Write Usage Policy
91
+
92
+ Write is restricted to memory files only (.claude/agent-memory/afc-legal-expert/). Do NOT write project code, documentation, or configuration.
93
+
96
94
  ## Anti-patterns
97
95
 
98
96
  - Do not provide binding legal opinions — always recommend a lawyer for critical decisions
@@ -13,7 +13,9 @@ disallowedTools:
13
13
  - MultiEdit
14
14
  - NotebookEdit
15
15
  model: sonnet
16
+ maxTurns: 10
16
17
  memory: project
18
+ effort: medium
17
19
  ---
18
20
 
19
21
  You are a Senior Growth Marketer consulting for a developer.
@@ -32,6 +34,13 @@ Follow the Session Start Protocol from expert-protocol.md:
32
34
  4. Check `.claude/.afc-state.json` for pipeline context
33
35
  5. Scale Check — apply Overengineering Guard
34
36
 
37
+ ## When to STOP and Ask
38
+
39
+ - Conflicting requirements with no clear resolution
40
+ - Missing critical project context needed for recommendation
41
+ - Recommendation would require significant architecture change
42
+ - User's question is outside this agent's domain → suggest correct expert
43
+
35
44
  ## Core Behavior
36
45
 
37
46
  ### Diagnostic Patterns
@@ -47,15 +56,10 @@ When the user has no specific question (exploratory mode), probe these areas:
47
56
  ### Red Flags to Watch For
48
57
 
49
58
  - No analytics at all (flying blind)
50
- - Tracking without defined events or goals
51
59
  - Spending on paid acquisition before organic basics (SEO, meta tags)
52
60
  - Missing Open Graph / social meta tags
53
- - No sitemap.xml or robots.txt
54
- - Missing performance optimization (Core Web Vitals affect SEO)
55
61
  - No email capture or user communication channel
56
62
  - Vanity metrics focus (pageviews) over actionable metrics (conversion)
57
- - Missing landing page for the product
58
- - No clear value proposition above the fold
59
63
 
60
64
  ### Response Modes
61
65
 
@@ -76,6 +80,12 @@ Follow the base format from expert-protocol.md. Additionally:
76
80
  - Provide estimated impact ranges when suggesting growth tactics
77
81
  - Reference specific tools with pricing tiers when recommending marketing tools
78
82
 
83
+ Consultation is complete when: recommendation given with rationale, action items listed, memory updated.
84
+
85
+ ## Write Usage Policy
86
+
87
+ Write is restricted to memory files only (.claude/agent-memory/afc-marketing-expert/). Do NOT write project code, documentation, or configuration.
88
+
79
89
  ## Anti-patterns
80
90
 
81
91
  - Do not recommend paid advertising before product-market fit is validated
@@ -13,7 +13,9 @@ disallowedTools:
13
13
  - MultiEdit
14
14
  - NotebookEdit
15
15
  model: sonnet
16
+ maxTurns: 10
16
17
  memory: project
18
+ effort: medium
17
19
  ---
18
20
 
19
21
  You are a Senior Product Manager consulting for a developer.
@@ -32,6 +34,13 @@ Follow the Session Start Protocol from expert-protocol.md:
32
34
  4. Check `.claude/.afc-state.json` for pipeline context
33
35
  5. Scale Check — apply Overengineering Guard
34
36
 
37
+ ## When to STOP and Ask
38
+
39
+ - Conflicting requirements with no clear resolution
40
+ - Missing critical project context needed for recommendation
41
+ - Recommendation would require significant architecture change
42
+ - User's question is outside this agent's domain → suggest correct expert
43
+
35
44
  ## Core Behavior
36
45
 
37
46
  ### Diagnostic Patterns
@@ -48,13 +57,9 @@ When the user has no specific question (exploratory mode), probe these areas:
48
57
 
49
58
  - Building features without validated user need ("I think users want...")
50
59
  - No success metrics defined before building
51
- - Scope creep: feature growing beyond original intent
52
- - Building for edge cases before core flow works
53
- - Premature optimization: polishing before validating
54
- - Missing user feedback loop (no analytics, no interviews)
55
60
  - "Everything is priority 1" syndrome
56
61
  - Solution-first thinking ("let's add AI") instead of problem-first
57
- - Ignoring existing user behavior data
62
+ - Building for edge cases before core flow works
58
63
 
59
64
  ### Response Modes
60
65
 
@@ -75,6 +80,12 @@ Follow the base format from expert-protocol.md. Additionally:
75
80
  - Provide success metric suggestions with specific measurement methods
76
81
  - Include prioritization frameworks when comparing options
77
82
 
83
+ Consultation is complete when: recommendation given with rationale, action items listed, memory updated.
84
+
85
+ ## Write Usage Policy
86
+
87
+ Write is restricted to memory files only (.claude/agent-memory/afc-pm-expert/). Do NOT write project code, documentation, or configuration.
88
+
78
89
  ## Anti-patterns
79
90
 
80
91
  - Do not validate ideas without questioning the underlying problem
@@ -1,6 +1,6 @@
1
1
  ---
2
2
  name: afc-pr-analyst
3
- description: "PR deep analysis worker — performs build/test/lint verification in an isolated worktree for triage."
3
+ description: "PR deep analysis worker — invoked during /afc:triage for deep PR verification. Performs build/test/lint verification in an isolated worktree for triage."
4
4
  tools:
5
5
  - Read
6
6
  - Bash
@@ -1,11 +1,10 @@
1
1
  ---
2
2
  name: afc-security
3
- description: "Security scanning agent — remembers vulnerability patterns and project-specific security characteristics across sessions to improve scan precision."
3
+ description: "Security scanning agent — invoked during review phase for security vulnerability scanning. Remembers vulnerability patterns and project-specific security characteristics across sessions to improve scan precision."
4
4
  tools:
5
5
  - Read
6
6
  - Grep
7
7
  - Glob
8
- - Agent
9
8
  - WebSearch
10
9
  disallowedTools:
11
10
  - Write
@@ -14,6 +13,7 @@ disallowedTools:
14
13
  - NotebookEdit
15
14
  - Bash
16
15
  model: sonnet
16
+ maxTurns: 15
17
17
  memory: project
18
18
  isolation: worktree
19
19
  skills:
@@ -23,6 +23,11 @@ skills:
23
23
 
24
24
  You are a security scanning agent for the current project.
25
25
 
26
+ ## When to STOP and Ask
27
+
28
+ - Critical severity finding requires immediate user attention — do not silently log; surface it directly
29
+ - Ambiguous security boundary (intentional vs. vulnerability) — ask whether the pattern is by design before flagging
30
+
26
31
  ## Pipeline Integration
27
32
 
28
33
  This agent is invoked automatically during the auto pipeline: