alchemymvc 1.1.7 → 1.2.0

package/lib/app/helper_datasource/00-nosql_datasource.js

@@ -611,6 +611,15 @@ NoSQL.setMethod(function compileCriteria(criteria, group) {
 		group = criteria.group;
 	}
 
+	let getAggregate = () => {
+		if (!aggregate) {
+			aggregate = {
+				pipeline: [],
+				lookups: {}
+			};
+		}
+	}
+
 	for (i = 0; i < group.items.length; i++) {
 		entry = group.items[i];
 
@@ -620,12 +629,7 @@ NoSQL.setMethod(function compileCriteria(criteria, group) {
 		}
 
 		if (entry.association) {
-			if (!aggregate) {
-				aggregate = {
-					pipeline: [],
-					lookups: {}
-				};
-			}
+			getAggregate();
 
 			// Get the association info
 			assoc = criteria.model.getAssociation(entry.association);
@@ -705,9 +709,45 @@ NoSQL.setMethod(function compileCriteria(criteria, group) {
 			    not,
 			    obj = {};
 
+			let field_entry = {},
+			    name = entry.target_path;
+
+			// Do we need to look into an object itself?
+			// (Like the "timestamp" property of a date field when stored with units)
+			if (entry.db_property) {
+				name += '.' + entry.db_property;
+			}
+
+			if (entry.association) {
+				name = entry.association + '.' + name;
+			}
+
 			for (let i = 0; i < entry.items.length; i++) {
 				item = entry.items[i];
 
+				// If the value is a RegExp, we might have to stringify the value
+				if (shouldStringify(entry, item) && RegExp.isRegExp(item.value)) {
+
+					let stringified_field = name + '_stringified';
+
+					getAggregate();
+
+					aggregate.pipeline.push({
+						$addFields: {
+							[stringified_field]: {
+								$convert: {
+									input: '$' + name,
+									to: 'string',
+									onError: '',
+									onNull: ''
+								}
+							}
+						}
+					});
+
+					name = stringified_field;
+				}
+
 				if (item.type == 'ne') {
 					obj.$ne = item.value;
 				} else if (item.type == 'not') {
@@ -771,19 +811,6 @@ NoSQL.setMethod(function compileCriteria(criteria, group) {
 					throw new Error('Unknown criteria expression: "' + item.type + '"');
 				}
 
-				let field_entry = {},
-				    name = entry.target_path;
-
-				// Do we need to look into an object itself?
-				// (Like the "timestamp" property of a date field when stored with units)
-				if (entry.db_property) {
-					name += '.' + entry.db_property;
-				}
-
-				if (entry.association) {
-					name = entry.association + '.' + name;
-				}
-
 				if (obj && obj.$or) {
 
 					let $or = [],
@@ -870,6 +897,33 @@ NoSQL.setMethod(function compileCriteria(criteria, group) {
 	return {$and: result};
 });
 
+/**
+ * Is the given item about a string field?
+ *
+ * @author   Jelle De Loecker   <jelle@elevenways.be>
+ * @since    1.2.0
+ * @version  1.2.0
+ *
+ * @param    {Object}   entry
+ * @param    {Object}   item
+ *
+ * @return   {boolean}
+ */
+function shouldStringify(entry, item) {
+
+	if (!item || !item.value) {
+		return false;
+	}
+
+	try {
+		let field = entry.model.getField(entry.target_path);
+
+		// The field value should only be stringified if it isn't a string already
+		return !(field instanceof Classes.Alchemy.Field.String);
+	} catch (err) {}
+
+	return false;
+}
 
 /**
  * Get the MongoDB options from this criteria

package/lib/app/helper_field/schema_field.js

@@ -277,7 +277,12 @@ SchemaField.setMethod(function _toApp(query, options, value, callback) {
 
 		name = this.name + 'FieldModel';
 		Dummy = alchemy.getModel('Model', false);
-		Dummy = new Dummy({name: name});
+
+		Dummy = new Dummy({
+			root_model : this.root_model,
+			name       : name
+		});
+
 		item = {};
 
 		item[name] = value;
@@ -338,7 +343,7 @@ SchemaField.setMethod(function _toApp(query, options, value, callback) {
 
 			if (field != null) {
 				tasks[field_name] = function doToDatasource(next) {
-					field.toApp({}, {}, field_value, next);
+					field.toApp({}, {_root_data: options._root_data}, field_value, next);
 				};
 			}
 		});

package/lib/app/helper_model/criteria.js

@@ -388,15 +388,26 @@ Criteria.setMethod(function clone() {
  *
  * @author   Jelle De Loecker   <jelle@develry.be>
  * @since    1.1.0
- * @version  1.1.0
+ * @version  1.2.0
  *
- * @return   {Array}
+ * @return   {String[]}
  */
 Criteria.setMethod(function getFieldsToSelect() {
 
-	var result = this.options.select.fields || [];
+	let result;
 
-	return result;
+	if (this.options.select.fields && this.options.select.fields.length) {
+		result = this.options.select.fields.slice(0);
+	}
+
+	// Fields can sometimes be required for a query (like in a join) but they
+	// won't be selected if other fields are explicitly set.
+	// So in that case: add these special fields to the projection
+	if (result && this.options.select.query_fields && this.options.select.query_fields) {
+		result.push(...this.options.select.query_fields);
+	}
+
+	return result || [];
 });
 
 /**
@@ -510,6 +521,9 @@ Criteria.setMethod(function getCriteriaForAssociation(name, item) {
 		assoc_crit.where(assoc_key).equals(value);
 	}
 
+	assoc_crit.setOption('assoc_key', assoc_key);
+	assoc_crit.setOption('assoc_value', value);
+
 	// Take over the locale option
 	if (options.locale) {
 		assoc_crit.setOption('locale', options.locale);
@@ -660,7 +674,7 @@ Criteria.setMethod(function page(page, page_size) {
  *
  * @author   Jelle De Loecker   <jelle@develry.be>
  * @since    1.1.0
- * @version  1.1.3
+ * @version  1.2.0
  *
  * @param    {String|Array}   field
  *
@@ -678,12 +692,6 @@ Criteria.setMethod(function select(field) {
 		}
 	} else {
 
-		if (typeof field == 'object') {
-			if (field instanceof Classes.Alchemy.Criteria.FieldConfig || field.name) {
-				field = field.name;
-			}
-		}
-
 		if (this._select) {
 			context = this._select.parse(field);
 		} else {
@@ -1380,7 +1388,7 @@ Select.setMethod(Blast.checksumSymbol, function toChecksum() {
  *
  * @author   Jelle De Loecker   <jelle@develry.be>
  * @since    1.1.0
- * @version  1.1.0
+ * @version  1.2.0
  *
  * @param    {String}   name
  *
@@ -1416,9 +1424,39 @@ Select.setMethod(function addAssociation(name) {
 		this.associations[name].association_name = name;
 	}
 
+	// Get the association data
+	try {
+		let info = this.criteria.model.getAssociation(name);
+
+		if (info) {
+			// Make sure the localkey is added to the resultset
+			this.requireFieldForQuery(info.options.localKey);
+		}
+	} catch (err) {
+		console.warn('Failed to find "' + name + '" association for ' + this.criteria.model.modelName);
+	}
+
 	return this.associations[name];
 });
 
+/**
+ * Require a field for query purposes
+ *
+ * @author   Jelle De Loecker   <jelle@develry.be>
+ * @since    1.2.0
+ * @version  1.2.0
+ *
+ * @param    {String}   path
+ */
+Select.setMethod(function requireFieldForQuery(path) {
+
+	if (!this.query_fields) {
+		this.query_fields = [];
+	}
+
+	this.query_fields.push(path);
+});
+
 /**
  * Add a field
  *
@@ -1442,17 +1480,33 @@ Select.setMethod(function addField(path) {
  *
  * @author   Jelle De Loecker   <jelle@develry.be>
  * @since    1.1.0
- * @version  1.1.0
+ * @version  1.2.0
  *
- * @param    {String}   path
+ * @param    {String|Object}   path
  *
  * @return   {Criteria|Null}   A criteria object if the context has changed
  */
 Select.setMethod(function parse(path) {
 
-	var context,
+	let context,
 	    select = this,
-	    parsed = Criteria.parsePath(path, this.criteria);
+	    parsed;
+
+	if (typeof path == 'object' && path && path.name) {
+
+		if (path.path) {
+			path = path.path;
+		} else {
+			let obj = path;
+			path = obj.name;
+
+			if (obj.association) {
+				path = obj.association + '.' + path;
+			}
+		}
+	}
+
+	parsed = Criteria.parsePath(path, this.criteria);
 
 	// Associations were found,
 	// like "Comment._id" or "Comment.User"
@@ -1467,7 +1521,7 @@ Select.setMethod(function parse(path) {
 				continue;
 			}
 
-			select = this.addAssociation(name);
+			select = select.addAssociation(name);
 		}
 	}
 
@@ -1486,7 +1540,7 @@ Select.setMethod(function parse(path) {
  *
  * @author   Jelle De Loecker   <jelle@develry.be>
  * @since    1.1.0
- * @version  1.1.0
+ * @version  1.2.0
  *
  * @param    {Criteria}   criteria
  *
@@ -1504,6 +1558,10 @@ Select.setMethod(function cloneForCriteria(criteria) {
 		clone.fields = this.fields.slice(0);
 	}
 
+	if (this.query_fields && this.query_fields.length) {
+		clone.query_fields = this.query_fields.slice(0);
+	}
+
 	if (this.associations) {
 		let key;
 

package/lib/app/helper_model/field_config.js

@@ -7,7 +7,7 @@
  *
  * @author   Jelle De Loecker <jelle@elevenways.be>
  * @since    1.1.3
- * @version  1.1.7
+ * @version  1.2.0
  * 
  * @param    {string}   path
  * @param    {Object}   options
@@ -20,6 +20,9 @@ const FieldConfig = Fn.inherits('Alchemy.Base', 'Alchemy.Criteria', function Fie
 	// The full path to the value
 	this.path = null;
 
+	// The local path to the value (subfields)
+	this.local_path = null;
+
 	// The pieces of the path
 	this.pieces = null;
 
@@ -89,7 +92,7 @@ FieldConfig.setMethod(function toDry() {
  *
  * @author   Jelle De Loecker   <jelle@elevenways.be>
  * @since    1.1.3
- * @version  1.1.4
+ * @version  1.2.0
  *
  * @return   {Object}
  */
@@ -97,6 +100,7 @@ FieldConfig.setMethod(function toJSON() {
 	return {
 		name        : this.name,
 		path        : this.path,
+		local_path  : this.local_path,
 		association : this.association,
 		options     : this.options,
 	};
@@ -107,7 +111,7 @@ FieldConfig.setMethod(function toJSON() {
  *
  * @author   Jelle De Loecker   <jelle@elevenways.be>
  * @since    1.1.3
- * @version  1.1.3
+ * @version  1.2.0
  *
  * @param    {string}   path
  */
@@ -120,6 +124,7 @@ FieldConfig.setMethod(function parsePath(path) {
 	} else if (path.indexOf('.') == -1) {
 		this.name = path;
 		this.path = path;
+		this.local_path = path;
 		this.pieces = [path];
 		return;
 	} else {
@@ -132,13 +137,27 @@ FieldConfig.setMethod(function parsePath(path) {
 
 	this.path = path;
 	this.pieces = pieces;
+	this.local_path = '';
 
 	for (i = 0; i < pieces.length; i++) {
 		piece = pieces[i];
 
-		if (i == 0 && piece[0].isUpperCase()) {
-			this.association = piece;
+		if (piece[0].isUpperCase()) {
+
+			if (this.association) {
+				this.association += '.';
+			} else {
+				this.association = '';
+			}
+
+			this.association += piece;
 			continue;
+		} else {
+			if (this.local_path) {
+				this.local_path += '.';
+			}
+
+			this.local_path += piece;
 		}
 	}
 

package/lib/app/helper_model/model.js

@@ -403,7 +403,7 @@ Model.setMethod(function getFindOptions(options) {
  *
  * @author   Jelle De Loecker   <jelle@develry.be>
  * @since    1.1.0
- * @version  1.1.0
+ * @version  1.2.0
  *
  * @param    {String}   alias
  *
@@ -415,7 +415,30 @@ Model.setMethod(function getAssociation(alias) {
 		throw new Error('Unable to find ' + this.constructor.name + ' schema associations');
 	}
 
-	let config = this.schema.associations[alias];
+	let config;
+
+	// @TODO: Test nested association getting
+	if (alias && alias.indexOf('.') > -1) {
+		let pieces = alias.split('.'),
+		    context = this,
+		    piece,
+		    temp;
+
+		for (piece of pieces) {
+			temp = context.getAssociation(piece);
+
+			if (!temp) {
+				break;
+			}
+
+			context = this.getModel(temp.modelName);
+		}
+
+		// The config s the last association gotten
+		config = temp;
+	} else {
+		config = this.schema.associations[alias];
+	}
 
 	if (!config) {
 		throw new Error('Unable to find ' + JSON.stringify(alias) + ' association in ' + this.constructor.name + ' model');
@@ -1058,6 +1081,26 @@ Model.setMethod(function addAssociatedDataToRecord(criteria, item, callback) {
 			return;
 		}
 
+		// SchemaFields use a dummy Model name, so get the root_model in that case
+		let root_model = (that.options && that.options.root_model) || that.name;
+
+		// Make sure references to the same model don't cause a deadlock
+		// (Can happen when a model refers to itself)
+		if (association.modelName == root_model && criteria.options._root_data) {
+			let assoc_key = assoc_crit.options.assoc_key,
+			    assoc_value = assoc_crit.options.assoc_value,
+			    root = criteria.options._root_data[root_model];
+
+			if (root && root[assoc_key] && Object.alike(root[assoc_key], assoc_value)) {
+
+				aliases[alias] = nextAlias => {
+					nextAlias(null, root[assoc_key]);
+				};
+
+				return;
+			}
+		}
+
 		aliases[alias] = function aliasRecordTask(nextAlias) {
 
 			var key;
@@ -1381,15 +1424,30 @@ Model.setProperty(function associations() {
  *
  * @author   Jelle De Loecker   <jelle@develry.be>
  * @since    1.0.0
- * @version  1.1.0
+ * @version  1.2.0
  *
- * @param    {String}   name   The name of the field
+ * @param    {string}   path   The path to the field
  *
  * @return   {Object}
  */
-Model.setMethod(function getField(name) {
-	return this.schema.getField(name);
-}, false);
+Model.setMethod(function getField(path) {
+
+	if (path.indexOf('.') > -1) {
+		let config = new Classes.Alchemy.Criteria.FieldConfig(path);
+
+		// If part of the path is an association, look for that now
+		if (config.association) {
+			let association = this.getAssociation(config.association);
+			let model = this.getModel(association.modelName);
+			return model.getField(config.local_path);
+		}
+
+		// If not, just use the local_path
+		path = config.local_path;
+	}
+
+	return this.schema.getField(path);
+});
 
 // Make this class easily available
 Hawkejs.Model = Model;

package/lib/app/model/alchemy_migration_model.js

@@ -0,0 +1,33 @@
+/**
+ * The Alchemy Migration Model class
+ *
+ * @constructor
+ *
+ * @author   Jelle De Loecker   <jelle@elevenways.be>
+ * @since    1.2.0
+ * @version  1.2.0
+ */
+const AlchemyMigration = Function.inherits('Alchemy.Model.App', 'AlchemyMigration');
+
+/**
+ * Constitute the class wide schema
+ *
+ * @author   Jelle De Loecker   <jelle@elevenways.be>
+ * @since    1.2.0
+ * @version  1.2.0
+ */
+AlchemyMigration.constitute(function addTaskFields() {
+
+	// The name of the migration
+	this.addField('name', 'String');
+
+	// The full path of the file
+	this.addField('path', 'String');
+
+	// When the migration ended
+	this.addField('ended', 'Datetime');
+
+	// Was there an error?
+	this.addField('error', 'String');
+
+});

package/lib/bootstrap.js

@@ -61,6 +61,15 @@ require('./core/base');
  */
 require('./core/client_base');
 
+/**
+ * The migration class
+ *
+ * @author   Jelle De Loecker   <jelle@elevenways.be>
+ * @since    1.2.0
+ * @version  1.2.0
+ */
+require('./class/migration');
+
 var hawkejs_options = {
 	server : false,
 	make_commonjs: true,