akm-cli 0.9.0 → 0.9.1-beta.2

package/dist/commands/lint/index.js

@@ -3,8 +3,7 @@
 // file, You can obtain one at https://mozilla.org/MPL/2.0/.
 import fs from "node:fs";
 import path from "node:path";
-import { parse as parseYaml } from "yaml";
-import { factDiagnostics, matchWorkflowPlaceholder, memoryOrphanStubApplies, nameOrTypeDiagnostics, ORPHANED_STUB_DETAIL, taskDiagnostics, workflowStructureDiagnostics, } from "../../core/adapter/adapters/akm-lint.js";
+import { factDiagnostics, matchWorkflowPlaceholder, memoryOrphanStubApplies, nameOrTypeDiagnostics, ORPHANED_STUB_DETAIL, taskDiagnostics, workflowFrontendDiagnostics, } from "../../core/adapter/adapters/akm-lint.js";
 import { detectAdapterId } from "../../core/adapter/detect-adapter.js";
 import { adapterForId } from "../../core/adapter/registry.js";
 import { createValidateContext } from "../../core/adapter/validate-context.js";
@@ -15,9 +14,12 @@ import { deriveBundleIds } from "../../core/bundle-id.js";
 import { resolveStashDir } from "../../core/common.js";
 import { loadConfig, primaryBundlePath } from "../../core/config/config.js";
 import { UsageError } from "../../core/errors.js";
+import { warn } from "../../core/warn.js";
 import { resolveSourceEntries } from "../../indexer/search/search-source.js";
+import { parseTaskYaml, TASK_EXTENSION, TASK_NEAR_MISS_EXTENSION, taskExtensionDetail, taskYamlParseDetail, } from "../../tasks/schema.js";
 import { runBaseChecks } from "./base-linter.js";
 import { checkEnvForDangerousKeys } from "./env-key-rules.js";
+import { isAdvisoryLintIssue } from "./types.js";
 // ── Constants ─────────────────────────────────────────────────────────────────
 const STASH_SUBDIRS = [
     "agents",
@@ -31,21 +33,34 @@ const STASH_SUBDIRS = [
     "facts",
 ];
 // ── Helpers ───────────────────────────────────────────────────────────────────
-function collectYamlFiles(dir) {
+/**
+ * Every task-shaped file under `tasks/`: the recognized `.yml` spelling AND the
+ * `.yaml` near-miss. A `.yaml` file is not a runnable task — it is invisible to
+ * the indexer's `tasks` matcher — but collecting it here is what lets the sweep
+ * SAY so (`invalid-task-yaml`, see {@link taskExtensionDetail}) instead of
+ * walking past it and reporting a clean scan (issue #760).
+ */
+function collectTaskFiles(dir) {
     if (!fs.existsSync(dir))
         return [];
     const results = [];
     for (const entry of fs.readdirSync(dir, { withFileTypes: true })) {
         const full = path.join(dir, entry.name);
         if (entry.isDirectory()) {
-            results.push(...collectYamlFiles(full));
+            results.push(...collectTaskFiles(full));
         }
-        else if (entry.isFile() && entry.name.endsWith(".yml")) {
+        else if (entry.isFile() && (isTaskFileName(entry.name) || isNearMissTaskFileName(entry.name))) {
             results.push(full);
         }
     }
     return results;
 }
+function isTaskFileName(fileName) {
+    return fileName.toLowerCase().endsWith(TASK_EXTENSION);
+}
+function isNearMissTaskFileName(fileName) {
+    return fileName.toLowerCase().endsWith(TASK_NEAR_MISS_EXTENSION);
+}
 function collectMarkdownFiles(dir, caseInsensitive = false) {
     if (!fs.existsSync(dir))
         return [];
@@ -141,18 +156,32 @@ const KNOWN_ADAPTER_ISSUE_TYPES = new Set([
     "missing-type",
     "missing-name-or-type",
     "missing-skill-md",
+    // The `akm-task` adapter's own code. Now reachable from `akm lint` for a
+    // malformed or misnamed task file (issue #760); without it here, a genuine
+    // task finding would arrive folded onto `adapter-diagnostic`.
+    "invalid-task-yaml",
     "dangerous-env-key",
     "uncited-raw",
     "missing-description",
     "broken-xref",
     "broken-source",
+    "workflow-warning",
 ]);
 /** Map one adapter {@link Diagnostic} onto a {@link LintIssue} — see `types.ts`'s `"adapter-diagnostic"` doc comment for the open→closed reconciliation. */
 export function diagnosticToLintIssue(diag) {
+    // `line` is optional on both shapes: carry it only when the adapter set one,
+    // so whole-file findings keep their exact existing serialization.
+    const location = typeof diag.line === "number" ? { line: diag.line } : {};
     if (KNOWN_ADAPTER_ISSUE_TYPES.has(diag.issue)) {
-        return { file: diag.file, issue: diag.issue, detail: diag.detail, fixed: diag.fixed };
+        return { file: diag.file, issue: diag.issue, detail: diag.detail, fixed: diag.fixed, ...location };
     }
-    return { file: diag.file, issue: "adapter-diagnostic", detail: `[${diag.issue}] ${diag.detail}`, fixed: diag.fixed };
+    return {
+        file: diag.file,
+        issue: "adapter-diagnostic",
+        detail: `[${diag.issue}] ${diag.detail}`,
+        fixed: diag.fixed,
+        ...location,
+    };
 }
 /**
  * Lint a bundle through its OWN adapter's `validate()` (spec §12.1): the
@@ -169,6 +198,17 @@ async function lintViaAdapter(adapterId, stashRoot, extraStashRoots, sources, cf
     // always applied to a bundle it can't otherwise place.
     if (!adapter)
         return lintAkmSweep(stashRoot, extraStashRoots, cfg, sources, options);
+    // `--type` names an AKM stash subdir; every other adapter has its own type
+    // vocabulary and `validate()` sees the whole bundle regardless. That is not a
+    // correctness problem (full-bundle validation is a superset of the requested
+    // scope), but a user narrowing a run deserves to hear the flag did nothing
+    // rather than infer it from identical output (issue #762). Warn, don't throw:
+    // a hard error would break scripts passing one `--type` across mixed-adapter
+    // bundle sets.
+    if (options.typeFilter) {
+        warn(`Warning: lint --type "${options.typeFilter}" is not supported for the "${adapterId}" adapter — ` +
+            "type scoping applies to akm bundles only; the whole bundle was validated.");
+    }
     const files = collectAdapterFiles(stashRoot, adapter.extensions);
     const changes = files.map((filePath) => ({
         path: path.relative(stashRoot, filePath).replace(/\\/g, "/"),
@@ -179,7 +219,13 @@ async function lintViaAdapter(adapterId, stashRoot, extraStashRoots, sources, cf
     const componentId = sourceIndex >= 0 ? ids[sourceIndex] : stashRoot;
     const ctx = createValidateContext({ root: stashRoot, extraRoots: extraStashRoots });
     const diagnostics = await adapter.validate({ id: componentId, adapter: adapterId, root: stashRoot, writable: true }, changes, ctx);
-    const flagged = diagnostics.map(diagnosticToLintIssue);
+    const mapped = diagnostics.map(diagnosticToLintIssue);
+    // Advisory diagnostics travel in their own channel — never `flagged`, so a
+    // `--fail-on-flagged` gate is not tripped by a non-fatal warning. Classified
+    // by the shared `ADVISORY_LINT_ISSUES` set rather than a code spelled out
+    // here, so this and the sweep below can never disagree about a code.
+    const warnings = mapped.filter(isAdvisoryLintIssue);
+    const flagged = mapped.filter((issue) => !isAdvisoryLintIssue(issue));
     // The cross-bundle env dangerous-key sweep (see `runEnvDangerousKeyPass`'s
     // doc comment) ran for every non-akm adapter via the STASH_SUBDIRS
     // fallthrough this dispatch replaces — EXCEPT `okf`, which the old code
@@ -199,7 +245,13 @@ async function lintViaAdapter(adapterId, stashRoot, extraStashRoots, sources, cf
             flagged.push(issue);
         }
     }
-    return { ok: true, fixed: [], flagged, summary: { fixed: 0, flagged: flagged.length } };
+    return {
+        ok: true,
+        fixed: [],
+        flagged,
+        warnings,
+        summary: { fixed: 0, flagged: flagged.length, warnings: warnings.length },
+    };
 }
 function lintIssueDedupeKey(issue) {
     return `${issue.file} ${issue.issue} ${issue.detail}`;
@@ -259,6 +311,29 @@ function runEnvDangerousKeyPass(stashRoot, extraStashRoots, sources, cfg) {
     }
     return flagged;
 }
+/**
+ * Refuse `--fix` against a bundle the config marks `writable: false`, BEFORE
+ * the sweep touches a single file (issue #761).
+ *
+ * Every other mutating command routes through `core/write-source.ts`'s
+ * `ensureWritable`/`resolveWritable` pair; `akm lint --fix` writes and deletes
+ * directly and never consulted the flag, so it happily rewrote frontmatter in a
+ * bundle explicitly configured read-only. `SearchSource.writable` is already the
+ * EFFECTIVE policy (`resolveWritable` applied — see `resolveSourceEntries`), so
+ * this reads the same answer the write path would, without a second resolver.
+ *
+ * A root that is not a configured source at all (an ad-hoc `--dir`) carries no
+ * policy and stays fixable, exactly as today.
+ */
+function assertFixTargetWritable(stashRoot, sources) {
+    const target = sources.find((source) => path.resolve(source.path) === path.resolve(stashRoot));
+    if (target?.writable !== false)
+        return;
+    // Same error kind and code `write-source.ts#ensureWritable` raises for the
+    // identical refusal, so a scripted caller classifies both the same way.
+    throw new UsageError(`lint --fix: bundle "${stashRoot}" is configured \`writable: false\`; refusing to modify it. ` +
+        "Run `akm lint` without --fix to report findings, or set `writable: true` on the bundle.", "INVALID_FLAG_VALUE");
+}
 /** True when the issue represents a file deletion that was successfully applied. */
 function isFileDeletion(issue) {
     return issue.fixed === true && (issue.issue === "orphaned-stub" || issue.issue === "placeholder-stub");
@@ -308,46 +383,53 @@ function appendMemoryStubIssue(ctx, issues) {
     }
     issues.push({ file: ctx.relPath, issue: "orphaned-stub", detail: ORPHANED_STUB_DETAIL, fixed: false });
 }
-/** WorkflowLinter's `placeholder-stub` (WITH `--fix` delete) + `invalid-workflow-structure` (workflow-linter.ts:22-79). */
-function appendWorkflowIssues(ctx, issues) {
+/**
+ * WorkflowLinter's `placeholder-stub` check WITH its `--fix` delete
+ * (workflow-linter.ts:22-79). Its sibling `invalid-workflow-structure` check is
+ * deliberately NOT here: parse+compile is a single pass shared with the
+ * advisory channel, so {@link lintAkmSweep} runs it once per file and routes
+ * both halves.
+ */
+function appendWorkflowStubIssue(ctx, issues) {
     const placeholder = matchWorkflowPlaceholder(ctx.body);
-    if (placeholder) {
-        if (ctx.fix) {
-            try {
-                fs.unlinkSync(ctx.filePath);
-                issues.push({
-                    file: ctx.relPath,
-                    issue: "placeholder-stub",
-                    detail: `deleted: found "${placeholder}"`,
-                    fixed: true,
-                });
-            }
-            catch (e) {
-                issues.push({
-                    file: ctx.relPath,
-                    issue: "placeholder-stub",
-                    detail: `could not delete: ${e instanceof Error ? e.message : String(e)}`,
-                    fixed: "failed",
-                });
-            }
-            return; // WorkflowLinter returns before the structure check once a stub is fixed.
+    if (!placeholder)
+        return;
+    if (ctx.fix) {
+        try {
+            fs.unlinkSync(ctx.filePath);
+            issues.push({
+                file: ctx.relPath,
+                issue: "placeholder-stub",
+                detail: `deleted: found "${placeholder}"`,
+                fixed: true,
+            });
         }
-        issues.push({
-            file: ctx.relPath,
-            issue: "placeholder-stub",
-            detail: `placeholder text: "${placeholder}"`,
-            fixed: false,
-        });
+        catch (e) {
+            issues.push({
+                file: ctx.relPath,
+                issue: "placeholder-stub",
+                detail: `could not delete: ${e instanceof Error ? e.message : String(e)}`,
+                fixed: "failed",
+            });
+        }
+        return;
     }
-    // NB: the CLI passes the ABSOLUTE filePath to parseWorkflow (matching the old
-    // WorkflowLinter), whereas the adapter passes the change relPath.
-    issues.push(...workflowStructureDiagnostics(ctx.relPath, ctx.raw, ctx.filePath));
+    issues.push({
+        file: ctx.relPath,
+        issue: "placeholder-stub",
+        detail: `placeholder text: "${placeholder}"`,
+        fixed: false,
+    });
 }
 /**
  * Lint ONE asset file: the shared base checks, then the winning stash subdir's
  * per-`type` extra rules. Replaces `getLinterForType(subdir).lint(ctx)`.
  * `--fix` mutations (frontmatter rewrites inside `runBaseChecks`; stub deletes
  * here) are applied when `ctx.fix` is set.
+ *
+ * The workflow parse/compile frontend is NOT one of these rules — it is one
+ * pass feeding two channels, so {@link lintAkmSweep} owns it (see
+ * {@link appendWorkflowStubIssue}).
  */
 export function lintAssetFile(ctx, subdir) {
     const issues = runBaseChecks(ctx);
@@ -368,7 +450,7 @@ export function lintAssetFile(ctx, subdir) {
             appendMemoryStubIssue(ctx, issues);
             break;
         case "workflows":
-            appendWorkflowIssues(ctx, issues);
+            appendWorkflowStubIssue(ctx, issues);
             break;
         // knowledge / lessons / skills: base checks only (skill directory-level
         // `missing-skill-md` runs separately, per-subdir, in the sweep loop).
@@ -387,14 +469,17 @@ export function lintAssetFile(ctx, subdir) {
  */
 function lintAkmSweep(stashRoot, extraStashRoots, cfg, sources, options) {
     const fix = options.fix === true;
+    if (fix)
+        assertFixTargetWritable(stashRoot, sources);
     const fixed = [];
     const flagged = [];
+    const warnings = [];
     const dirsToScan = options.typeFilter ? STASH_SUBDIRS.filter((d) => d === options.typeFilter) : STASH_SUBDIRS;
     for (const subdir of dirsToScan) {
         const dirPath = path.join(stashRoot, subdir);
         // Tasks are .yml files; everything else (including workflows, one
         // markdown format now) is .md
-        const files = subdir === "tasks" ? collectYamlFiles(dirPath) : collectMarkdownFiles(dirPath, true);
+        const files = subdir === "tasks" ? collectTaskFiles(dirPath) : collectMarkdownFiles(dirPath, true);
         const assetFiles = subdir === "workflows" ? files.filter((file) => path.basename(file).toLowerCase() !== "readme.md") : files;
         // Directory-level check: skills require a SKILL.md entry point (was
         // SkillLinter.lintDirectory). Run once per direct subdirectory before the
@@ -417,7 +502,11 @@ function lintAkmSweep(stashRoot, extraStashRoots, cfg, sources, options) {
         }
         for (const filePath of assetFiles) {
             // Skip registry-cached read-only files — --fix must not mutate them.
-            if (filePath.includes("/.cache/") || filePath.includes("/registry/"))
+            // Compare on a separator-normalized copy: on Windows these paths carry
+            // backslashes, so the forward-slash substring never matched and --fix
+            // rewrote files inside the registry cache.
+            const posixPath = filePath.replace(/\\/g, "/");
+            if (posixPath.includes("/.cache/") || posixPath.includes("/registry/"))
                 continue;
             const relPath = path.relative(stashRoot, filePath);
             let raw;
@@ -430,15 +519,32 @@ function lintAkmSweep(stashRoot, extraStashRoots, cfg, sources, options) {
             let data;
             let body;
             let frontmatter;
+            // File-identity findings the per-type rules cannot produce: they describe
+            // the FILE (its extension, whether it parsed at all), not its fields.
+            const fileIssues = [];
             if (subdir === "tasks") {
                 // Task files are pure YAML — parseFrontmatter returns empty data for them.
-                try {
-                    const parsed = parseYaml(raw);
-                    data =
-                        parsed && typeof parsed === "object" && !Array.isArray(parsed) ? parsed : {};
+                const parsed = parseTaskYaml(raw);
+                data = parsed.data;
+                if (!parsed.ok) {
+                    // A parse failure used to fall through as `data = {}`, and every task
+                    // rule short-circuits on an empty mapping — so an unparseable task
+                    // file reported a CLEAN scan. Report the parse failure itself
+                    // (issue #760).
+                    fileIssues.push({
+                        file: relPath,
+                        issue: "invalid-task-yaml",
+                        detail: taskYamlParseDetail(parsed.error),
+                        fixed: false,
+                    });
                 }
-                catch {
-                    data = {};
+                if (isNearMissTaskFileName(relPath)) {
+                    fileIssues.push({
+                        file: relPath,
+                        issue: "invalid-task-yaml",
+                        detail: taskExtensionDetail(relPath),
+                        fixed: false,
+                    });
                 }
                 body = raw;
                 frontmatter = null;
@@ -446,13 +552,40 @@ function lintAkmSweep(stashRoot, extraStashRoots, cfg, sources, options) {
             else {
                 ({ data, content: body, frontmatter } = parseFrontmatter(raw));
             }
-            const issues = lintAssetFile({ filePath, relPath, raw, data, body, frontmatter, fix, stashRoot, extraStashRoots }, subdir);
+            // One file's checks — including its `--fix` mutations — must never abort
+            // the sweep: an uncaught throw here left the caller with an exception and
+            // no record of which earlier files had ALREADY been rewritten on disk
+            // (issue #761). A failure is reported per-file, in-band, and the sweep
+            // continues so the rest of the bundle is still linted.
+            let issues;
+            try {
+                issues = [
+                    ...fileIssues,
+                    ...lintAssetFile({ filePath, relPath, raw, data, body, frontmatter, fix, stashRoot, extraStashRoots }, subdir),
+                ];
+            }
+            catch (e) {
+                flagged.push(...fileIssues, {
+                    file: relPath,
+                    issue: "lint-failed",
+                    detail: `lint ${fix ? "--fix " : ""}failed for this file: ${e instanceof Error ? e.message : String(e)}`,
+                    fixed: fix ? "failed" : false,
+                });
+                continue;
+            }
             let fileDeleted = false;
             for (const issue of issues) {
                 if (isFileDeletion(issue)) {
                     fileDeleted = true;
                     fixed.push(issue);
                 }
+                else if (isAdvisoryLintIssue(issue)) {
+                    // `lintAssetFile` returns errors only today, so this branch is
+                    // reached by no current producer — it is here so that an advisory
+                    // added to a per-type check later cannot silently become a
+                    // `--fail-on-flagged` failure, the way the unclassified default does.
+                    warnings.push(issue);
+                }
                 else if (issue.fixed === true) {
                     fixed.push(issue);
                 }
@@ -463,6 +596,26 @@ function lintAkmSweep(stashRoot, extraStashRoots, cfg, sources, options) {
             }
             if (fileDeleted)
                 continue; // file is gone — skip any remaining checks
+            // The workflow frontend is ONE parse+compile whose output feeds BOTH
+            // channels, so it runs here — once per file — rather than inside
+            // `lintAssetFile`, which is an errors-only surface (pinned by the lint
+            // golden). Which channel a finding lands in is decided by
+            // `ADVISORY_LINT_ISSUES`, never by which half of the pass produced it, so
+            // a future compile-warning kind carrying a fatal code cannot slip past
+            // `--fail-on-flagged`.
+            // NB: the CLI passes the ABSOLUTE filePath to parseWorkflow (matching the
+            // old WorkflowLinter), whereas the adapter passes the change relPath.
+            if (subdir === "workflows") {
+                const frontend = workflowFrontendDiagnostics(relPath, raw, filePath);
+                for (const finding of [...frontend.errors, ...frontend.warnings]) {
+                    if (isAdvisoryLintIssue(finding)) {
+                        warnings.push(finding);
+                    }
+                    else {
+                        flagged.push(finding);
+                    }
+                }
+            }
         }
     }
     // ── Env dangerous-key pass ─────────────────────────────────────────────────
@@ -483,7 +636,8 @@ function lintAkmSweep(stashRoot, extraStashRoots, cfg, sources, options) {
         ok: true,
         fixed,
         flagged,
-        summary: { fixed: fixed.length, flagged: flagged.length },
+        warnings,
+        summary: { fixed: fixed.length, flagged: flagged.length, warnings: warnings.length },
     };
 }
 /**

package/dist/commands/lint/types.js

@@ -1,4 +1,25 @@
 // This Source Code Form is subject to the terms of the Mozilla Public
 // License, v. 2.0. If a copy of the MPL was not distributed with this
 // file, You can obtain one at https://mozilla.org/MPL/2.0/.
-export {};
+/**
+ * The issue codes that are ADVISORY: surfaced in lint output but never routed
+ * into `flagged`, so `--fail-on-flagged` cannot fail a run over one.
+ *
+ * ONE home for that decision. EVERY routing point consults it — the adapter
+ * path (`lint/index.ts#lintViaAdapter`), the sweep's per-file loop, and the
+ * sweep's workflow-frontend pass — so a new advisory code cannot be classified
+ * correctly in one place and land in `flagged` (exit 1) in another; a finding
+ * is never filed by which producer emitted it. A future advisory belongs in
+ * BOTH this set and {@link LintIssueType}: an unrecognized code is folded onto
+ * `adapter-diagnostic` at the adapter boundary, which is deliberately NOT
+ * advisory, so a code missing from the union cannot be routed by this set.
+ *
+ * Advisory-ness is deliberately NOT a field on {@link LintIssue}: issues are
+ * serialized verbatim by `--format json`, and a new key on every advisory
+ * would change every consumer's output to restate what `issue` already says.
+ */
+export const ADVISORY_LINT_ISSUES = new Set(["workflow-warning"]);
+/** True when `issue` belongs to the advisory channel — see {@link ADVISORY_LINT_ISSUES}. */
+export function isAdvisoryLintIssue(issue) {
+    return ADVISORY_LINT_ISSUES.has(issue.issue);
+}

package/dist/commands/proposal/repository.js

@@ -54,6 +54,7 @@ import { _setTxnMutationHookForTests, advanceTxn, beginTxn, canonicalTxnRoot, cl
 import { canonicalBundleIdForTarget, resolveBundleWriteTarget } from "../../core/mutation-target.js";
 import { withImmediateTransaction, withStateDb } from "../../core/state-db.js";
 import { warn } from "../../core/warn.js";
+import { recordWrittenPath } from "../../core/write-provenance.js";
 import { assertAkmAssetWrite, assertWriteTargetPathsClean, captureGitPublication, captureWriteTargetPathSnapshot, prepareWriteTargetForMutation, publishWriteTargetTransaction, resolveWriteTarget, } from "../../core/write-source.js";
 import { withAssetMutationLease } from "../../indexer/index-writer-lock.js";
 import { indexWrittenAssets } from "../../indexer/index-written-assets.js";
@@ -901,6 +902,9 @@ function rollbackPreparedProposalTransaction(txn) {
         if (p.originalHash === null) {
             if (currentHash === p.publishedHash && sameProposalFile(p.assetPath, p.publishPath)) {
                 fs.unlinkSync(p.assetPath);
+                // #652: un-publishing is a mutation of this run's own write — journal
+                // it so the sync stages the FINAL state of a written-then-reverted path.
+                recordWrittenPath(p.assetPath);
             }
             else if (currentHash !== null) {
                 throw new Error(`Cannot roll back proposal transaction: target was created externally.`);
@@ -912,8 +916,10 @@ function rollbackPreparedProposalTransaction(txn) {
         cleanupProposalPublication(p);
         return;
     }
-    if (currentHash === p.publishedHash)
+    if (currentHash === p.publishedHash) {
         fs.unlinkSync(p.assetPath);
+        recordWrittenPath(p.assetPath);
+    }
     else if (currentHash !== null && currentHash !== p.originalHash) {
         throw new Error(`Cannot roll back proposal transaction: ${p.assetPath} diverged.`);
     }
@@ -922,6 +928,9 @@ function rollbackPreparedProposalTransaction(txn) {
             throw new Error(`Cannot restore proposal backup: ${p.assetPath} is occupied.`);
         }
         fs.linkSync(p.displacedPath, p.assetPath);
+        // #652: restoring the displaced original still leaves the path in a state
+        // this run produced; journal it so the final on-disk bytes are staged.
+        recordWrittenPath(p.assetPath);
     }
     cleanupProposalPublication(p);
 }
@@ -1023,6 +1032,10 @@ function persistProposalEvent(txn, proposal, ctx) {
 async function finalizeProposalTransaction(txn, target, proposal, ctx) {
     const p = txn.journal.payload;
     validatePublishedProposal(p);
+    // #652: finalizing an `asset-published` transaction that a CRASHED earlier
+    // run left behind is this run adopting that write — journal the asset so the
+    // adopting run's auto-sync commits it instead of leaving it stranded.
+    recordWrittenPath(p.assetPath);
     cleanupProposalPublication(p);
     if (txn.journal.phase === "asset-published") {
         const commitRoot = target.source.repoPath ?? target.source.path;
@@ -1343,6 +1356,9 @@ function publishProposalAsset(txn, target) {
             }
         }
         fs.linkSync(p.publishPath, p.assetPath);
+        // #652: the accepted-proposal (and revert) target is the run's headline
+        // write — journal it the instant the asset lands, before the txn advances.
+        recordWrittenPath(p.assetPath);
         fsyncTxnDir(path.dirname(p.assetPath));
         const snapshot = captureWriteTargetPathSnapshot(target, p.assetPath);
         if (snapshot)

package/dist/commands/sources/add-cli.js

@@ -10,6 +10,7 @@ import { decideDangerousKeyInstall } from "../../core/activation-policy.js";
 import { UsageError } from "../../core/errors.js";
 import { appendEvent } from "../../core/events.js";
 import { warn } from "../../core/warn.js";
+import { sanitizeString } from "../../sources/providers/provider-utils.js";
 import { akmRemove } from "./installed-stashes.js";
 import { akmAdd } from "./source-add.js";
 import { addStash } from "./source-manage.js";
@@ -180,9 +181,14 @@ export async function auditInstalledStashForDangerousKeys(opts) {
             groupedByEnv.set(f.envRef, existing);
         }
         for (const [envRef, keys] of groupedByEnv) {
-            warn(`[warn] Env "${envRef}" in stash "${stashLabel}" contains potentially dangerous keys:`);
+            // envRef and keys come from filenames and KEY names inside a downloaded or
+            // cloned bundle, i.e. attacker-controllable. Tar validation rejects NUL but
+            // not ESC/CSI, and git checkout allows them in filenames on Linux/macOS —
+            // so printing them raw let a crafted bundle rewrite this security prompt
+            // with terminal escapes right before an "Install anyway?" confirmation.
+            warn(`[warn] Env "${sanitizeString(envRef)}" in stash "${sanitizeString(stashLabel)}" contains potentially dangerous keys:`);
             for (const key of keys) {
-                warn(`  - ${key}: can hijack process execution via \`akm env run\``);
+                warn(`  - ${sanitizeString(key)}: can hijack process execution via \`akm env run\``);
             }
         }
         const confirmed = await p.confirm({

package/dist/commands/sources/info.js

@@ -1,10 +1,10 @@
 // This Source Code Form is subject to the terms of the Mozilla Public
 // License, v. 2.0. If a copy of the MPL was not distributed with this
 // file, You can obtain one at https://mozilla.org/MPL/2.0/.
-import fs from "node:fs";
 import { placementTypes } from "../../core/asset/asset-placement.js";
 import { resolveStashDir } from "../../core/common.js";
 import { getSources, loadConfig } from "../../core/config/config.js";
+import { classifyPathAccess, describeInaccessiblePath } from "../../core/path-access.js";
 import { getDbPath } from "../../core/paths.js";
 import { error } from "../../core/warn.js";
 import { getEffectiveSemanticStatus, readSemanticStatus } from "../../indexer/search/semantic-status.js";
@@ -83,8 +83,18 @@ function readIndexStats(resolvedPath) {
         hasEmbeddings: false,
         vecAvailable: false,
     };
-    if (!fs.existsSync(resolvedPath))
+    // "Absent" is the ordinary first-run state; "inaccessible" is a fault that
+    // must not present as an empty index (#791). `akm info` is the command an
+    // operator reaches for to DIAGNOSE this, so it reports rather than throws —
+    // but it says so explicitly instead of returning zeros that look healthy.
+    const { access, code } = classifyPathAccess(resolvedPath);
+    if (access === "absent")
         return EMPTY;
+    if (access === "inaccessible") {
+        const detail = describeInaccessiblePath(resolvedPath, code);
+        error(`[akm info] index database is not readable: ${detail}`);
+        return { ...EMPTY, unreadable: detail };
+    }
     let db;
     try {
         db = openExistingDatabase(resolvedPath);

package/dist/commands/sources/installed-stashes.js

@@ -18,6 +18,7 @@ import path from "node:path";
 import { isWithin, resolveStashDir } from "../../core/common.js";
 import { getSources, loadConfig } from "../../core/config/config.js";
 import { ConfigError, NotFoundError, UsageError } from "../../core/errors.js";
+import { isPathAbsent } from "../../core/path-access.js";
 import { getDbPath } from "../../core/paths.js";
 import { warn } from "../../core/warn.js";
 import { withAssetMutationLease } from "../../indexer/index-writer-lock.js";
@@ -125,7 +126,11 @@ function describeLock(entry) {
 function readBundleCounts() {
     const counts = new Map();
     const dbPath = getDbPath();
-    if (!fs.existsSync(dbPath))
+    // An empty map renders as `itemCount: 0` for every bundle — indistinguishable
+    // from "these bundles really are empty". Only a never-built index gets to say
+    // that silently; an unreadable one falls through to the opener and is
+    // reported by the `warn` in the catch below (#791).
+    if (isPathAbsent(dbPath))
         return counts;
     let db;
     try {

package/dist/commands/sources/migration-help.js

@@ -3,6 +3,7 @@
 // file, You can obtain one at https://mozilla.org/MPL/2.0/.
 import fs from "node:fs";
 import path from "node:path";
+import embeddedChangelog from "../../../CHANGELOG.md" with { type: "text" };
 import { getDirname } from "../../runtime.js";
 const CHANGELOG_URL = "https://github.com/itlackey/akm/blob/main/CHANGELOG.md";
 const MIGRATION_DOC_URL = "https://github.com/itlackey/akm/blob/main/docs/migration/v0.5-to-v0.6.md";
@@ -24,9 +25,13 @@ function loadChangelog() {
         }
     }
     catch {
-        // fall through to bundled notes
+        // fall through to the embedded copy
     }
-    return undefined;
+    // In the `bun build --compile` standalone binary, import.meta.url points into
+    // the virtual /$bunfs tree and every existsSync above misses, so `akm help
+    // migrate <version>` degraded to the generic "no dedicated note" message for
+    // EVERY version. Only assets imported `with { type: "text" }` are embedded.
+    return embeddedChangelog.length > 0 ? embeddedChangelog : undefined;
 }
 /**
  * Load the bundled migration note for a specific version, if one exists.
@@ -87,7 +92,11 @@ function resolveLatestVersion(changelog) {
     return undefined;
 }
 function extractChangelogSection(changelog, version) {
-    const pattern = new RegExp(`^## \\[${escapeRegexString(version)}\\][^\\n]*\\n([\\s\\S]*?)(?=^## \\[|\\Z)`, "m");
+    // `\Z` is not a JavaScript anchor — it matches a literal "Z", which truncated
+    // the section at the first capital Z in the body (and failed outright for the
+    // last entry). `$` with the `m` flag would stop at the first line end, so the
+    // end-of-input alternative has to be an explicit lookahead for the input end.
+    const pattern = new RegExp(`^## \\[${escapeRegexString(version)}\\][^\\n]*\\n([\\s\\S]*?)(?=^## \\[|$(?![\\s\\S]))`, "m");
     const match = changelog.match(pattern);
     if (!match)
         return undefined;

package/dist/commands/sources/self-update.js

@@ -10,6 +10,7 @@ import { ConfigError } from "../../core/errors.js";
 import { warn } from "../../core/warn.js";
 import { githubHeaders } from "../../integrations/github.js";
 import { getDirname, mainPath, semverOrder } from "../../runtime.js";
+import { resolveAkmInvocation } from "../../tasks/resolve-akm-bin.js";
 const REPO = "itlackey/akm";
 const DEFAULT_PACKAGE_NAME = "akm-cli";
 const NODE_MODULES_SEGMENT = "/node_modules/";
@@ -474,7 +475,14 @@ function readInstalledCliVersion(akmBin) {
     return match?.[0];
 }
 function runRequiredCommand(akmBin, args, label) {
-    const result = childProcess.spawnSync(akmBin, args, {
+    // A bare "akm" is not spawnable on Windows: npm/pnpm/yarn install a global CLI
+    // as akm.cmd / akm.ps1 shims, and spawnSync without a shell does not apply
+    // PATHEXT — so the package-manager upgrade arm died with ENOENT before it ever
+    // ran. resolveAkmInvocation returns a concrete argv (launcher, runtime + main
+    // script, or a standalone binary) for however this install actually runs.
+    // An explicit path (the standalone arm passes one) is used as given.
+    const [command, ...prefixArgs] = path.isAbsolute(akmBin) ? [akmBin] : resolveAkmInvocation().argv;
+    const result = childProcess.spawnSync(command ?? akmBin, [...prefixArgs, ...args], {
         encoding: "utf8",
         env: process.env,
         stdio: "pipe",