akm-cli 0.9.0-rc.1 → 0.9.0-rc.2

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (228) hide show
  1. package/CHANGELOG.md +223 -9
  2. package/SECURITY.md +23 -24
  3. package/dist/assets/help/help-improve.md +10 -10
  4. package/dist/assets/hints/cli-hints-full.md +44 -10
  5. package/dist/assets/hints/cli-hints-short.md +6 -2
  6. package/dist/assets/{profiles → improve-strategies}/default.json +1 -0
  7. package/dist/assets/{profiles → improve-strategies}/graph-refresh.json +1 -1
  8. package/dist/assets/{profiles → improve-strategies}/proactive-maintenance.json +2 -3
  9. package/dist/assets/{profiles → improve-strategies}/reflect-distill.json +3 -4
  10. package/dist/assets/stash-skeleton/README.md +28 -0
  11. package/dist/assets/stash-skeleton/facts/conventions/assets/agent.md +6 -0
  12. package/dist/assets/stash-skeleton/facts/conventions/assets/command.md +6 -0
  13. package/dist/assets/stash-skeleton/facts/conventions/assets/fact.md +12 -1
  14. package/dist/assets/stash-skeleton/facts/conventions/assets/knowledge.md +11 -1
  15. package/dist/assets/stash-skeleton/facts/conventions/assets/lesson.md +6 -0
  16. package/dist/assets/stash-skeleton/facts/conventions/assets/memory.md +9 -0
  17. package/dist/assets/stash-skeleton/facts/conventions/assets/script.md +7 -0
  18. package/dist/assets/stash-skeleton/facts/conventions/assets/skill.md +7 -0
  19. package/dist/assets/stash-skeleton/facts/conventions/assets/workflow.md +6 -0
  20. package/dist/assets/stash-skeleton/facts/conventions/backlinks.md +98 -0
  21. package/dist/assets/stash-skeleton/facts/conventions/domains.md +63 -0
  22. package/dist/assets/stash-skeleton/facts/conventions/organization.md +127 -0
  23. package/dist/assets/tasks/core/backup.yml +1 -0
  24. package/dist/assets/tasks/core/extract.yml +1 -0
  25. package/dist/assets/tasks/core/improve.yml +1 -0
  26. package/dist/assets/tasks/core/index-refresh.yml +1 -0
  27. package/dist/assets/tasks/core/sync.yml +1 -0
  28. package/dist/assets/tasks/core/version-check.yml +1 -0
  29. package/dist/assets/tasks/graph-refresh-weekly.yml +4 -4
  30. package/dist/assets/templates/html/health.html +5 -1
  31. package/dist/cli/config-migrate.js +31 -138
  32. package/dist/cli/config-validate.js +10 -8
  33. package/dist/cli.js +48 -14
  34. package/dist/commands/agent/agent-dispatch.js +17 -16
  35. package/dist/commands/agent/agent-support.js +0 -24
  36. package/dist/commands/agent/contribute-cli.js +5 -15
  37. package/dist/commands/backup-cli.js +54 -0
  38. package/dist/commands/config-cli.js +45 -159
  39. package/dist/commands/env/secret.js +8 -5
  40. package/dist/commands/health/checks.js +130 -83
  41. package/dist/commands/health/html-report.js +4 -0
  42. package/dist/commands/health/improve-metrics.js +30 -32
  43. package/dist/commands/health/llm-usage.js +19 -19
  44. package/dist/commands/health/md-report.js +4 -0
  45. package/dist/commands/health/metrics.js +2 -1
  46. package/dist/commands/health/surfaces.js +5 -4
  47. package/dist/commands/health.js +1 -1
  48. package/dist/commands/improve/consolidate/chunking.js +2 -2
  49. package/dist/commands/improve/consolidate.js +28 -25
  50. package/dist/commands/improve/distill/promote-memory.js +5 -12
  51. package/dist/commands/improve/distill/quality-gate.js +5 -7
  52. package/dist/commands/improve/distill.js +16 -5
  53. package/dist/commands/improve/eligibility.js +22 -12
  54. package/dist/commands/improve/extract-cli.js +47 -19
  55. package/dist/commands/improve/extract.js +110 -62
  56. package/dist/commands/improve/improve-cli.js +38 -16
  57. package/dist/commands/improve/improve-result-file.js +30 -24
  58. package/dist/commands/improve/improve-strategies.js +137 -0
  59. package/dist/commands/improve/improve.js +60 -30
  60. package/dist/commands/improve/locks.js +66 -45
  61. package/dist/commands/improve/loop-stages.js +75 -33
  62. package/dist/commands/improve/memory/memory-belief.js +79 -7
  63. package/dist/commands/improve/memory/memory-contradiction-detect.js +12 -4
  64. package/dist/commands/improve/preparation.js +71 -73
  65. package/dist/commands/improve/procedural.js +3 -2
  66. package/dist/commands/improve/recombine.js +2 -1
  67. package/dist/commands/improve/reflect.js +119 -214
  68. package/dist/commands/improve/shared.js +11 -5
  69. package/dist/commands/lint/base-linter.js +152 -42
  70. package/dist/commands/mv-cli.js +809 -0
  71. package/dist/commands/proposal/proposal-cli.js +18 -8
  72. package/dist/commands/proposal/propose.js +64 -69
  73. package/dist/commands/read/knowledge.js +436 -4
  74. package/dist/commands/read/remember-cli.js +39 -2
  75. package/dist/commands/read/search-cli.js +6 -1
  76. package/dist/commands/registry-cli.js +29 -14
  77. package/dist/commands/remember.js +2 -0
  78. package/dist/commands/sources/init.js +13 -14
  79. package/dist/commands/sources/schema-repair.js +2 -4
  80. package/dist/commands/sources/source-add.js +62 -73
  81. package/dist/commands/sources/source-manage.js +50 -46
  82. package/dist/commands/sources/stash-cli.js +41 -4
  83. package/dist/commands/tasks/default-tasks.js +12 -12
  84. package/dist/commands/tasks/tasks-cli.js +7 -3
  85. package/dist/commands/tasks/tasks.js +113 -18
  86. package/dist/commands/wiki-cli.js +9 -10
  87. package/dist/core/asset/frontmatter.js +12 -2
  88. package/dist/core/common.js +5 -3
  89. package/dist/core/config/config-io.js +28 -17
  90. package/dist/core/config/config-schema.js +358 -66
  91. package/dist/core/config/config-types.js +3 -3
  92. package/dist/core/config/config-version.js +29 -0
  93. package/dist/core/config/config-walker.js +98 -27
  94. package/dist/core/config/config.js +132 -266
  95. package/dist/core/config/deep-merge.js +41 -0
  96. package/dist/core/config/engine-semantics.js +32 -0
  97. package/dist/core/errors.js +2 -2
  98. package/dist/core/extra-params.js +61 -0
  99. package/dist/core/file-lock.js +201 -56
  100. package/dist/core/improve-result.js +178 -0
  101. package/dist/core/maintenance-barrier.js +119 -0
  102. package/dist/core/migration-backup.js +416 -0
  103. package/dist/core/paths.js +3 -0
  104. package/dist/core/redaction.js +358 -0
  105. package/dist/core/state/migrations.js +17 -2
  106. package/dist/core/state-db.js +44 -1
  107. package/dist/indexer/db/db.js +116 -1
  108. package/dist/indexer/graph/graph-extraction.js +28 -16
  109. package/dist/indexer/index-writer-lock.js +31 -24
  110. package/dist/indexer/index-written-assets.js +15 -6
  111. package/dist/indexer/indexer.js +47 -2
  112. package/dist/indexer/passes/memory-inference.js +10 -6
  113. package/dist/indexer/passes/metadata.js +250 -0
  114. package/dist/indexer/search/db-search.js +111 -44
  115. package/dist/indexer/search/fts-query.js +41 -0
  116. package/dist/indexer/search/ranking-contributors.js +48 -0
  117. package/dist/indexer/search/ranking.js +36 -23
  118. package/dist/indexer/search/search-fields.js +11 -1
  119. package/dist/integrations/agent/builder-shared.js +7 -0
  120. package/dist/integrations/agent/builders.js +5 -52
  121. package/dist/integrations/agent/config.js +3 -143
  122. package/dist/integrations/agent/detect.js +17 -2
  123. package/dist/integrations/agent/engine-resolution.js +202 -0
  124. package/dist/integrations/agent/index.js +1 -2
  125. package/dist/integrations/agent/model-aliases.js +7 -2
  126. package/dist/integrations/agent/profiles.js +6 -99
  127. package/dist/integrations/agent/runner-dispatch.js +76 -13
  128. package/dist/integrations/agent/runner.js +76 -207
  129. package/dist/integrations/agent/spawn.js +4 -6
  130. package/dist/integrations/harnesses/aider/agent-builder.js +2 -3
  131. package/dist/integrations/harnesses/aider/index.js +0 -1
  132. package/dist/integrations/harnesses/amazonq/agent-builder.js +2 -3
  133. package/dist/integrations/harnesses/amazonq/index.js +0 -1
  134. package/dist/integrations/harnesses/claude/agent-builder.js +2 -3
  135. package/dist/integrations/harnesses/claude/index.js +0 -2
  136. package/dist/integrations/harnesses/codex/agent-builder.js +2 -3
  137. package/dist/integrations/harnesses/codex/index.js +0 -1
  138. package/dist/integrations/harnesses/copilot/agent-builder.js +2 -3
  139. package/dist/integrations/harnesses/copilot/index.js +0 -1
  140. package/dist/integrations/harnesses/gemini/agent-builder.js +2 -3
  141. package/dist/integrations/harnesses/gemini/index.js +0 -1
  142. package/dist/integrations/harnesses/index.js +1 -24
  143. package/dist/integrations/harnesses/opencode/agent-builder.js +2 -3
  144. package/dist/integrations/harnesses/opencode/index.js +0 -6
  145. package/dist/integrations/harnesses/opencode-sdk/harness.js +1 -6
  146. package/dist/integrations/harnesses/opencode-sdk/sdk-runner.js +274 -191
  147. package/dist/integrations/harnesses/openhands/agent-builder.js +2 -3
  148. package/dist/integrations/harnesses/openhands/index.js +0 -1
  149. package/dist/integrations/harnesses/pi/agent-builder.js +2 -3
  150. package/dist/integrations/harnesses/pi/index.js +0 -1
  151. package/dist/integrations/harnesses/types.js +1 -32
  152. package/dist/integrations/lockfile.js +32 -21
  153. package/dist/llm/client.js +48 -14
  154. package/dist/llm/feature-gate.js +15 -47
  155. package/dist/llm/graph-extract.js +1 -1
  156. package/dist/llm/index-passes.js +8 -42
  157. package/dist/llm/memory-infer-impl.js +1 -1
  158. package/dist/llm/usage-persist.js +4 -0
  159. package/dist/llm/usage-telemetry.js +35 -5
  160. package/dist/output/shapes/helpers.js +2 -1
  161. package/dist/output/shapes/passthrough.js +2 -0
  162. package/dist/output/text/helpers.js +3 -1
  163. package/dist/schemas/akm-config.json +11013 -8600
  164. package/dist/schemas/akm-task.json +87 -0
  165. package/dist/schemas/akm-workflow.json +57 -13
  166. package/dist/scripts/migrate-storage.js +8591 -509
  167. package/dist/scripts/migrations/import-fs-improve-runs-to-db.js +8623 -484
  168. package/dist/setup/detected-engines.js +142 -0
  169. package/dist/setup/engine-config.js +89 -0
  170. package/dist/setup/setup.js +236 -132
  171. package/dist/setup/steps/connection.js +61 -32
  172. package/dist/setup/steps/platforms.js +4 -4
  173. package/dist/setup/steps.js +3 -2
  174. package/dist/storage/database.js +13 -1
  175. package/dist/storage/engines/sqlite-migrations.js +1 -0
  176. package/dist/storage/repositories/improve-runs-repository.js +5 -5
  177. package/dist/storage/repositories/task-history-repository.js +78 -0
  178. package/dist/storage/repositories/workflow-runs-repository.js +9 -8
  179. package/dist/tasks/parser.js +138 -52
  180. package/dist/tasks/runner.js +71 -75
  181. package/dist/tasks/schema.js +1 -1
  182. package/dist/tasks/validator.js +11 -6
  183. package/dist/wiki/wiki.js +9 -8
  184. package/dist/workflows/authoring/workflow-program-template.yaml +3 -3
  185. package/dist/workflows/concurrency-policy.js +15 -0
  186. package/dist/workflows/db.js +65 -13
  187. package/dist/workflows/exec/brief.js +18 -24
  188. package/dist/workflows/exec/frozen-judge.js +47 -0
  189. package/dist/workflows/exec/native-executor.js +124 -65
  190. package/dist/workflows/exec/report.js +93 -33
  191. package/dist/workflows/exec/run-workflow.js +38 -25
  192. package/dist/workflows/exec/scheduler.js +12 -41
  193. package/dist/workflows/exec/step-work.js +91 -35
  194. package/dist/workflows/ir/compile.js +13 -26
  195. package/dist/workflows/ir/freeze.js +243 -0
  196. package/dist/workflows/ir/plan-hash.js +40 -5
  197. package/dist/workflows/ir/schema.js +542 -1
  198. package/dist/workflows/parser.js +7 -0
  199. package/dist/workflows/program/parser.js +132 -23
  200. package/dist/workflows/program/project.js +3 -4
  201. package/dist/workflows/program/schema.js +2 -2
  202. package/dist/workflows/resource-limits.js +20 -0
  203. package/dist/workflows/runtime/plan-classifier.js +187 -0
  204. package/dist/workflows/runtime/runs.js +54 -47
  205. package/dist/workflows/runtime/workflow-asset-loader.js +0 -22
  206. package/dist/workflows/validator.js +25 -0
  207. package/docs/data-and-telemetry.md +2 -2
  208. package/docs/migration/release-notes/0.6.0.md +1 -1
  209. package/docs/migration/release-notes/0.7.0.md +5 -4
  210. package/docs/migration/v0.8-to-v0.9.md +401 -0
  211. package/package.json +4 -2
  212. package/schemas/akm-config.json +16638 -0
  213. package/schemas/akm-task.json +87 -0
  214. package/schemas/akm-workflow.json +372 -0
  215. package/dist/commands/improve/improve-profiles.js +0 -168
  216. package/dist/core/config/config-migration.js +0 -602
  217. package/dist/core/deep-merge.js +0 -38
  218. package/dist/llm/call-ai.js +0 -62
  219. package/dist/setup/legacy-config.js +0 -106
  220. package/docs/README.md +0 -104
  221. /package/dist/assets/{profiles → improve-strategies}/catchup.json +0 -0
  222. /package/dist/assets/{profiles → improve-strategies}/consolidate.json +0 -0
  223. /package/dist/assets/{profiles → improve-strategies}/frequent.json +0 -0
  224. /package/dist/assets/{profiles → improve-strategies}/memory-focus.json +0 -0
  225. /package/dist/assets/{profiles → improve-strategies}/quick.json +0 -0
  226. /package/dist/assets/{profiles → improve-strategies}/recombine-only.json +0 -0
  227. /package/dist/assets/{profiles → improve-strategies}/synthesize.json +0 -0
  228. /package/dist/assets/{profiles → improve-strategies}/thorough.json +0 -0
@@ -14,7 +14,7 @@ const COMMON_PASSTHROUGH = ["HOME", "PATH", "USER", "LANG", "LC_ALL", "TERM", "T
14
14
  * amazonq, openhands — plan §"Capability matrix"). The fields here are
15
15
  * conservative defaults — every value is overridable from user config.
16
16
  *
17
- * For headless/automation use (propose, reflect, tasks), use the '-headless' variant.
17
+ * Engine lowering selects captured stdio for unattended dispatch.
18
18
  */
19
19
  const BUILTINS = {
20
20
  opencode: {
@@ -91,108 +91,15 @@ const BUILTINS = {
91
91
  parseOutput: "text",
92
92
  },
93
93
  };
94
- /**
95
- * Headless variants of the base profiles for automation use (propose, reflect, tasks).
96
- *
97
- * These profiles use `stdio: "captured"` and `parseOutput: "json"` so the
98
- * agent's response can be read from stdout. They share the same `bin` and
99
- * `envPassthrough` as the corresponding base profile but are intentionally
100
- * kept out of `BUILTIN_AGENT_PROFILE_NAMES` (and therefore out of CLI
101
- * detection/enumeration) to avoid showing up as separate installable profiles.
102
- *
103
- * Users may reference them by name via `--profile opencode-headless` or by
104
- * setting `agent.default: "opencode-headless"` in config.json.
105
- */
106
- const HEADLESS_BUILTINS = {
107
- "opencode-headless": {
108
- name: "opencode-headless",
109
- bin: "opencode",
110
- args: ["run"],
111
- stdio: "captured",
112
- envPassthrough: [...COMMON_PASSTHROUGH, "OPENCODE_API_KEY", "OPENCODE_CONFIG"],
113
- parseOutput: "json",
114
- },
115
- "claude-headless": {
116
- name: "claude-headless",
117
- bin: "claude",
118
- args: [],
119
- stdio: "captured",
120
- envPassthrough: [...COMMON_PASSTHROUGH, "ANTHROPIC_API_KEY", "CLAUDE_CONFIG"],
121
- parseOutput: "json",
122
- },
123
- "codex-headless": {
124
- name: "codex-headless",
125
- bin: "codex",
126
- args: [],
127
- stdio: "captured",
128
- envPassthrough: [...COMMON_PASSTHROUGH, "OPENAI_API_KEY", "CODEX_CONFIG"],
129
- parseOutput: "json",
130
- },
131
- "gemini-headless": {
132
- name: "gemini-headless",
133
- bin: "gemini",
134
- args: [],
135
- stdio: "captured",
136
- envPassthrough: [...COMMON_PASSTHROUGH, "GEMINI_API_KEY", "GOOGLE_API_KEY"],
137
- parseOutput: "json",
138
- },
139
- "aider-headless": {
140
- name: "aider-headless",
141
- bin: "aider",
142
- args: ["--no-auto-commits"],
143
- stdio: "captured",
144
- envPassthrough: [...COMMON_PASSTHROUGH, "OPENAI_API_KEY", "ANTHROPIC_API_KEY"],
145
- parseOutput: "json",
146
- },
147
- // ── P2 harness-adapter headless variants (plan §"Capability matrix") ───────
148
- "copilot-headless": {
149
- name: "copilot-headless",
150
- bin: "copilot",
151
- args: [],
152
- stdio: "captured",
153
- envPassthrough: [...COMMON_PASSTHROUGH, "GH_TOKEN", "GITHUB_TOKEN"],
154
- parseOutput: "json",
155
- },
156
- "pi-headless": {
157
- name: "pi-headless",
158
- bin: "pi",
159
- args: [],
160
- stdio: "captured",
161
- envPassthrough: [...COMMON_PASSTHROUGH, "PI_API_KEY", "ANTHROPIC_API_KEY", "OPENAI_API_KEY"],
162
- parseOutput: "json",
163
- },
164
- "amazonq-headless": {
165
- name: "amazonq-headless",
166
- bin: "q",
167
- args: [],
168
- stdio: "captured",
169
- envPassthrough: [...COMMON_PASSTHROUGH, "AWS_PROFILE", "AWS_REGION"],
170
- parseOutput: "json",
171
- },
172
- "openhands-headless": {
173
- name: "openhands-headless",
174
- bin: "openhands",
175
- args: [],
176
- stdio: "captured",
177
- envPassthrough: [...COMMON_PASSTHROUGH, "LLM_MODEL", "LLM_API_KEY", "LLM_BASE_URL"],
178
- parseOutput: "json",
179
- },
180
- };
181
- /**
182
- * Names of the primary built-in profiles. Stable, sorted. Does NOT
183
- * include the `-headless` variants (those are resolvable by name but are
184
- * excluded from detection/enumeration flows).
185
- */
94
+ /** Names of the canonical built-in harness descriptors. Stable, sorted. */
186
95
  export const BUILTIN_AGENT_PROFILE_NAMES = Object.freeze(Object.keys(BUILTINS).sort());
187
- /** Returns the built-in profile by name (including headless variants), or `undefined` if not found. */
96
+ /** Returns the built-in descriptor for a canonical harness id. */
188
97
  export function getBuiltinAgentProfile(name) {
189
- return BUILTINS[name] ?? HEADLESS_BUILTINS[name];
98
+ return BUILTINS[name];
190
99
  }
191
100
  /**
192
- * Return a deep copy of every primary built-in profile keyed by name.
193
- * Headless variants are NOT included use `getBuiltinAgentProfile(name)`
194
- * to look them up by name. Callers should not assume reference equality with
195
- * subsequent calls.
101
+ * Return a copy of every canonical built-in descriptor keyed by harness id.
102
+ * Callers should not assume reference equality with subsequent calls.
196
103
  */
197
104
  export function listBuiltinAgentProfiles() {
198
105
  const out = {};
@@ -28,13 +28,16 @@
28
28
  * (X2) can wrap `executeRunner` without changing this contract.
29
29
  */
30
30
  import { assertNever } from "../../core/assert.js";
31
- import { closeServer as disposeOpencodeSdkServers, runOpencodeSdk } from "../harnesses/opencode-sdk/index.js";
31
+ import { collectSensitiveValues, isEnvPassthroughValueSafeToExpose, redactSensitiveText, redactSensitiveValue, } from "../../core/redaction.js";
32
+ import { closeServer as disposeOpencodeSdkServers, runOpencodeSdk } from "../harnesses/opencode-sdk/sdk-runner.js";
33
+ import { materializeLlmConnection } from "./engine-resolution.js";
34
+ import { materializeLlmRunnerConnection } from "./runner.js";
32
35
  import { runAgent } from "./spawn.js";
33
36
  /**
34
37
  * Release every long-lived resource the dispatch runners CACHE for reuse, so a
35
38
  * one-shot process (the CLI) can exit cleanly once dispatching is done.
36
39
  *
37
- * The `sdk` runner keeps a per-env registry of `opencode serve` CHILD
40
+ * The `sdk` runner keeps a per-material registry of `opencode serve` CHILD
38
41
  * PROCESSES (see `opencode-sdk/sdk-runner.ts`), started lazily and reused
39
42
  * across units within a process. Each live child is an OS handle that keeps
40
43
  * Bun's event loop open — and the registry's own teardown is wired ONLY to
@@ -44,15 +47,47 @@ import { runAgent } from "./spawn.js";
44
47
  * never idle enough for the exit hook to run and close the children it is
45
48
  * waiting on.
46
49
  *
47
- * The engine therefore calls this in its run `finally` (every exit path —
48
- * success, gate rejection, failure, abort) to drain the registry deterministically
49
- * BEFORE relying on the event loop to drain. The close is synchronous and
50
- * idempotent; when no SDK server was ever started it is a no-op, so the `agent`
51
- * / `llm` dispatch paths pay nothing. Servers are re-created lazily on the next
52
- * dispatch, so calling this between independent dispatch invocations is safe.
50
+ * The CLI composition root and workflow engine call this in `finally` blocks to
51
+ * drain the registry deterministically before relying on the event loop. Started
52
+ * servers close synchronously; in-flight starts are awaited and closed on
53
+ * arrival. When no SDK server was started this is an idempotent no-op.
53
54
  */
54
- export function disposeDispatchResources() {
55
- disposeOpencodeSdkServers();
55
+ export async function disposeDispatchResources() {
56
+ await disposeOpencodeSdkServers();
57
+ }
58
+ /** Collect every materialized value that can reach one runner dispatch. */
59
+ export function collectDispatchSensitiveValues(spec, opts, envSource = opts.envSource ?? process.env) {
60
+ const values = new Set();
61
+ const add = (value) => {
62
+ if (value !== undefined && value.length > 0)
63
+ values.add(value);
64
+ };
65
+ const addConnection = (connection) => add(connection?.apiKey);
66
+ if (spec.kind === "llm")
67
+ addConnection(spec.connection);
68
+ if (spec.kind === "sdk")
69
+ addConnection(spec.fallbackConnection);
70
+ if (spec.kind !== "llm") {
71
+ for (const value of Object.values(spec.profile.env ?? {}))
72
+ add(value);
73
+ for (const name of spec.profile.envPassthrough) {
74
+ const value = envSource[name];
75
+ if (!isEnvPassthroughValueSafeToExpose(name, value))
76
+ add(value);
77
+ }
78
+ }
79
+ for (const value of Object.values(opts.env ?? {}))
80
+ add(value);
81
+ return collectSensitiveValues(values);
82
+ }
83
+ function redactResult(result, sensitiveValues) {
84
+ return {
85
+ ...result,
86
+ stdout: redactSensitiveText(result.stdout, sensitiveValues),
87
+ stderr: redactSensitiveText(result.stderr, sensitiveValues),
88
+ ...(result.error !== undefined ? { error: redactSensitiveText(result.error, sensitiveValues) } : {}),
89
+ ...(result.parsed !== undefined ? { parsed: redactSensitiveValue(result.parsed, sensitiveValues) } : {}),
90
+ };
56
91
  }
57
92
  /**
58
93
  * Dispatch a {@link RunnerSpec} to its runner and return the raw
@@ -61,23 +96,51 @@ export function disposeDispatchResources() {
61
96
  * its exact option set (incl. any `timeoutMs` the caller chose to apply).
62
97
  */
63
98
  export async function executeRunner(spec, prompt, opts, seams = {}) {
99
+ const withSpecOptions = (timeoutMs, workspace) => ({
100
+ ...opts,
101
+ ...(Object.hasOwn(opts, "timeoutMs") ? {} : timeoutMs !== undefined ? { timeoutMs } : {}),
102
+ ...(opts.cwd === undefined && workspace ? { cwd: workspace } : {}),
103
+ });
104
+ let result;
105
+ const dispatchSensitiveValues = [];
64
106
  switch (spec.kind) {
65
107
  case "llm": {
66
108
  if (!seams.llm) {
67
109
  throw new Error("executeRunner: an `llm` runner requires a `seams.llm` handler (no default LLM dispatch).");
68
110
  }
69
- return seams.llm(spec, prompt);
111
+ const connection = materializeLlmRunnerConnection(spec);
112
+ if (connection.apiKey)
113
+ dispatchSensitiveValues.push(connection.apiKey);
114
+ result = await seams.llm({ ...spec, connection }, prompt, withSpecOptions(spec.timeoutMs));
115
+ break;
70
116
  }
71
117
  case "agent": {
72
118
  const run = seams.runAgent ?? runAgent;
73
- return run(spec.profile, prompt, opts);
119
+ result = await run(spec.profile, prompt, withSpecOptions(spec.timeoutMs, spec.profile.workspace));
120
+ break;
74
121
  }
75
122
  case "sdk": {
76
123
  const run = seams.runSdk ?? runOpencodeSdk;
77
- return run(spec.profile, prompt, opts);
124
+ const fallbackConnection = spec.fallbackConnection
125
+ ? materializeLlmConnection({
126
+ engine: spec.engine ?? "unnamed-sdk-fallback",
127
+ connection: spec.fallbackConnection,
128
+ ...(spec.fallbackCredential ? { credential: spec.fallbackCredential } : {}),
129
+ timeoutMs: spec.fallbackTimeoutMs !== undefined
130
+ ? spec.fallbackTimeoutMs
131
+ : Object.hasOwn(spec.fallbackConnection, "timeoutMs")
132
+ ? (spec.fallbackConnection.timeoutMs ?? null)
133
+ : null,
134
+ })
135
+ : undefined;
136
+ if (fallbackConnection?.apiKey)
137
+ dispatchSensitiveValues.push(fallbackConnection.apiKey);
138
+ result = await run(spec.profile, prompt, withSpecOptions(spec.timeoutMs, spec.profile.workspace), fallbackConnection);
139
+ break;
78
140
  }
79
141
  default:
80
142
  // Exhaustiveness arm: a 4th RunnerSpec kind becomes a compile error here.
81
143
  return assertNever(spec);
82
144
  }
145
+ return redactResult(result, [...collectDispatchSensitiveValues(spec, opts), ...dispatchSensitiveValues]);
83
146
  }
@@ -2,230 +2,99 @@
2
2
  // License, v. 2.0. If a copy of the MPL was not distributed with this
3
3
  // file, You can obtain one at https://mozilla.org/MPL/2.0/.
4
4
  import { ConfigError } from "../../core/errors.js";
5
- import { warn } from "../../core/warn.js";
6
- // ── RunnerSpec capability predicates (H1) ───────────────────────────────────
7
- // The `RunnerSpec` union is dispatched ad-hoc across the improve slice. These
8
- // predicates co-locate the capability questions with the union definition so
9
- // callers stop hand-inlining `kind !== "llm"` (which couples the call site to
10
- // the exact shape of the union). They are typed as TypeScript type guards so
11
- // narrowing flows through to the `connection` / `profile` accessors.
12
- /** The in-tree LLM HTTP runner (`chatCompletion`); has no filesystem access. */
5
+ import { materializeLlmConnection, resolveEngine, resolveLlmEngineUse, } from "./engine-resolution.js";
6
+ import { resolveModel } from "./model-aliases.js";
7
+ /** Resolve the current credential value for one frozen LLM runner at dispatch. */
8
+ export function materializeLlmRunnerConnection(runner) {
9
+ const connectionWithLegacyTimeout = runner.connection;
10
+ const timeoutMs = runner.timeoutMs !== undefined
11
+ ? runner.timeoutMs
12
+ : Object.hasOwn(connectionWithLegacyTimeout, "timeoutMs")
13
+ ? (connectionWithLegacyTimeout.timeoutMs ?? null)
14
+ : null;
15
+ return materializeLlmConnection({
16
+ engine: runner.engine ?? "unnamed",
17
+ connection: runner.connection,
18
+ ...(runner.credential ? { credential: runner.credential } : {}),
19
+ timeoutMs,
20
+ });
21
+ }
13
22
  export function runnerIsLlm(runner) {
14
23
  return runner.kind === "llm";
15
24
  }
16
- /**
17
- * Whether this runner can honour the file-write contract. Agent CLI + OpenCode
18
- * SDK runners both have filesystem access; the direct LLM HTTP runner does NOT
19
- * (see `src/llm/call-ai.ts`). Equivalent to `!runnerIsLlm(runner)` but names
20
- * the capability the callers actually care about.
21
- */
22
25
  export function runnerSupportsFileWrite(runner) {
23
26
  return runner.kind !== "llm";
24
27
  }
25
- function resolveEffectiveMode(entry, profileName, config) {
26
- if (entry.mode)
27
- return entry.mode;
28
- // Infer from profile pool when profile is specified
29
- if (profileName) {
30
- if (config.profiles?.llm?.[profileName])
31
- return "llm";
32
- const agentProfile = config.profiles?.agent?.[profileName];
33
- if (agentProfile) {
34
- return agentProfile.platform === "opencode-sdk" ? "sdk" : "agent";
35
- }
36
- }
37
- // Fall back to defaults
38
- if (config.defaults?.llm)
39
- return "llm";
40
- if (config.defaults?.agent)
41
- return "agent";
42
- return "llm";
43
- }
44
- function resolveProfileName(entry, mode, config) {
45
- if (entry.profile)
46
- return entry.profile;
47
- if (mode === "llm") {
48
- const defaultName = config.defaults?.llm;
49
- if (defaultName)
50
- return defaultName;
51
- throw new ConfigError(`No LLM profile configured. Set defaults.llm in config or specify profile in the process entry.`, "LLM_NOT_CONFIGURED", "Run `akm setup` or define a profile under `profiles.llm` and set `defaults.llm`.");
52
- }
53
- const defaultName = config.defaults?.agent;
54
- if (defaultName)
55
- return defaultName;
56
- throw new ConfigError(`No agent profile configured. Set defaults.agent in config or specify profile in the process entry.`, "INVALID_CONFIG_FILE", "Run `akm setup` to configure an agent profile, or add one under `profiles.agent`.");
57
- }
58
- function buildLlmRunnerSpec(profileName, timeoutMs, config) {
59
- const profile = config.profiles?.llm?.[profileName];
60
- if (!profile) {
61
- throw new ConfigError(`LLM profile "${profileName}" not found in profiles.llm.`, "LLM_NOT_CONFIGURED", `Available profiles: ${Object.keys(config.profiles?.llm ?? {}).join(", ") || "none"}. Run \`akm setup\` to configure.`);
62
- }
28
+ /** Resolve the configured LLM default without ever consulting retired profiles. */
29
+ export function resolveDefaultLlmRunner(config, timeoutMs) {
30
+ const resolved = resolveLlmEngineUse(config, [], { optional: true });
31
+ if (!resolved)
32
+ return null;
63
33
  return {
64
34
  kind: "llm",
65
- connection: profile,
66
- ...(typeof timeoutMs === "number" ? { timeoutMs } : {}),
67
- };
68
- }
69
- function buildAgentRunnerSpec(kind, profileName, timeoutMs, config) {
70
- const profileConfig = config.profiles?.agent?.[profileName];
71
- if (!profileConfig) {
72
- throw new ConfigError(`Agent profile "${profileName}" not found in profiles.agent.`, "INVALID_CONFIG_FILE", `Available profiles: ${Object.keys(config.profiles?.agent ?? {}).join(", ") || "none"}. Run \`akm setup\` to configure.`);
73
- }
74
- // Validate mode/platform consistency
75
- if (kind === "sdk" && profileConfig.platform !== "opencode-sdk") {
76
- throw new ConfigError(`Mode "sdk" requires platform "opencode-sdk", but profiles.agent["${profileName}"].platform is "${profileConfig.platform}".`, "INVALID_CONFIG_FILE");
77
- }
78
- if (kind === "agent" && profileConfig.platform === "opencode-sdk") {
79
- throw new ConfigError(`Mode "agent" requires platform "opencode" or "claude", but profiles.agent["${profileName}"].platform is "opencode-sdk".`, "INVALID_CONFIG_FILE");
80
- }
81
- const agentProfile = {
82
- name: profileName,
83
- bin: profileConfig.bin ?? profileName,
84
- args: profileConfig.args ?? [],
85
- stdio: "captured",
86
- envPassthrough: [],
87
- parseOutput: "text",
88
- ...(profileConfig.model ? { model: profileConfig.model } : {}),
89
- ...(profileConfig.workspace ? { workspace: profileConfig.workspace } : {}),
90
- };
91
- return {
92
- kind,
93
- profile: agentProfile,
94
- ...(typeof timeoutMs === "number" ? { timeoutMs } : {}),
35
+ engine: resolved.engine,
36
+ connection: resolved.connection,
37
+ ...(resolved.credential ? { credential: resolved.credential } : {}),
38
+ ...(timeoutMs !== undefined ? { timeoutMs } : { timeoutMs: resolved.timeoutMs }),
95
39
  };
96
40
  }
97
- /**
98
- * Resolve the runner used for "validation" passes on the `improve` section
99
- * (Advantage D3 / Phase 4B third model tier).
100
- *
101
- * Look-up order:
102
- * 1. `profiles.improve.default.processes.validation` (preferred — lets users
103
- * wire a lower-cost classifier model for staleness detection, confidence
104
- * scoring, and lesson classification).
105
- * 2. `defaults.llm` as a final fallback so callers always get a usable
106
- * runner when any LLM is configured.
107
- *
108
- * Returns `null` when neither is configured (callers may then skip the
109
- * validation pass rather than throwing).
110
- */
111
- /**
112
- * Shared resolution path for the `validation` and `triage judgment` tiers,
113
- * both of which take a `{ mode?, profile?, timeoutMs? }`-shaped block, attempt
114
- * to resolve it via {@link resolveImproveProcessRunnerFromProfile}, and
115
- * otherwise fall back to an `llm` runner built from `defaults.llm`.
116
- *
117
- * @param block the `{ mode?, profile?, timeoutMs? }` subset to resolve.
118
- * @param config the active AKM config.
119
- * @param opts.fallbackTimeoutMs timeout applied to the `defaults.llm` fallback
120
- * runner (validation passes `undefined`; triage forwards `block.timeoutMs`).
121
- * @param opts.suppressLlmFallbackForExplicitMode when `true` and the block
122
- * explicitly sets `mode: "agent"` or `"sdk"`, do NOT silently fall back
123
- * to `defaults.llm` if the profile resolver returns `null` or throws —
124
- * return `null` instead and emit a `warn(...)` (see FIX 8). Validation
125
- * passes `false` to preserve its always-fallback behavior.
126
- */
127
- function resolveProcessRunnerWithLlmFallback(block, config, opts) {
128
- const explicitNonLlmMode = block?.mode === "agent" || block?.mode === "sdk";
129
- if (block && (block.mode || block.profile)) {
130
- try {
131
- const spec = resolveImproveProcessRunnerFromProfile(block, config);
132
- if (spec)
133
- return spec;
41
+ /** Resolve a triage judgment using judgment -> triage -> strategy -> defaults.llmEngine precedence. */
42
+ export function resolveTriageJudgmentRunner(judgment, config, triage, strategy) {
43
+ const layers = [strategy ?? {}, triage ?? {}, judgment ?? {}];
44
+ const selectedEngine = judgment?.engine ?? triage?.engine ?? strategy?.engine ?? config.defaults?.llmEngine;
45
+ if (selectedEngine) {
46
+ const runner = resolveEngine(selectedEngine, config);
47
+ if (runner.kind === "llm") {
48
+ const resolved = resolveLlmEngineUse(config, layers);
49
+ return {
50
+ kind: "llm",
51
+ engine: resolved.engine,
52
+ connection: resolved.connection,
53
+ ...(resolved.credential ? { credential: resolved.credential } : {}),
54
+ timeoutMs: resolved.timeoutMs,
55
+ };
134
56
  }
135
- catch {
136
- // Fall through to defaults.llm below (unless suppressed for explicit modes).
137
- }
138
- // FIX 8: an EXPLICIT agent/sdk request must not be silently downgraded to
139
- // llm. When the profile resolver could not produce a runner, surface the
140
- // misconfiguration and let callers skip this tier rather than substituting
141
- // an llm judge.
142
- if (opts.suppressLlmFallbackForExplicitMode && explicitNonLlmMode) {
143
- warn(`[akm] Could not resolve the "${block?.mode}" judgment profile; ` +
144
- `skipping the judgment tier instead of falling back to an llm judge. ` +
145
- `Check profiles.agent and the judgment profile/mode configuration.`);
146
- return null;
147
- }
148
- }
149
- const defaultLlm = config.defaults?.llm;
150
- if (defaultLlm) {
151
- try {
152
- return buildLlmRunnerSpec(defaultLlm, opts.fallbackTimeoutMs, config);
153
- }
154
- catch {
155
- return null;
57
+ const effectiveLlmOverrides = [...layers].reverse().find((layer) => layer.llm !== undefined)?.llm;
58
+ if (effectiveLlmOverrides) {
59
+ throw new ConfigError(`Triage judgment engine "${selectedEngine}" is an agent engine and cannot receive llm overrides.`, "INVALID_CONFIG_FILE");
156
60
  }
61
+ const model = [...layers].reverse().find((layer) => layer.model !== undefined)?.model;
62
+ const profile = model
63
+ ? {
64
+ ...runner.profile,
65
+ model: resolveModel(model, runner.profile.platform ?? runner.profile.name, runner.profile.modelAliases, runner.profile.globalModelAliases),
66
+ modelIsExact: true,
67
+ }
68
+ : runner.profile;
69
+ const timeoutLayer = [...layers].reverse().find((layer) => Object.hasOwn(layer, "timeoutMs"));
70
+ return {
71
+ ...runner,
72
+ profile,
73
+ ...(timeoutLayer ? { timeoutMs: timeoutLayer.timeoutMs ?? null } : {}),
74
+ };
157
75
  }
158
76
  return null;
159
77
  }
160
- /**
161
- * Build the tool-less HTTP runner from `defaults.llm`, or `null` when unset.
162
- * The unattended-improve reflect pin (meta-review 07 Chain-G / P1.3) uses this
163
- * as the mandatory downgrade target when config would otherwise hand reflect a
164
- * tool-capable (agent/SDK) runner in a scheduled run. Throws ConfigError when
165
- * `defaults.llm` names a profile that does not exist.
166
- */
167
- export function resolveDefaultLlmRunner(config, timeoutMs) {
168
- const name = config.defaults?.llm;
169
- if (!name)
170
- return null;
171
- return buildLlmRunnerSpec(name, timeoutMs, config);
172
- }
173
- export function resolveValidationRunner(config) {
174
- const validation = config.profiles?.improve?.default?.processes?.validation;
175
- const block = validation && validation.enabled !== false ? validation : undefined;
176
- return resolveProcessRunnerWithLlmFallback(block, config, {
177
- fallbackTimeoutMs: undefined,
178
- suppressLlmFallbackForExplicitMode: false,
179
- });
78
+ export function resolveImproveProcessLlmUse(config, strategy, processName, options = {}) {
79
+ const process = strategy?.processes?.[processName];
80
+ const layers = strategy ? [strategy, process ?? {}] : [];
81
+ return options.optional
82
+ ? resolveLlmEngineUse(config, layers, { optional: true })
83
+ : resolveLlmEngineUse(config, layers);
180
84
  }
181
- /**
182
- * Resolve the runner for the triage judgment tier (Proposal-Queue Triage,
183
- * Phase 3). The `judgment` block is a `{ mode?, profile?, timeoutMs? }` subset
184
- * compatible with {@link ImproveProcessConfig}, so it resolves through the same
185
- * {@link resolveImproveProcessRunnerFromProfile} path.
186
- *
187
- * Mirrors {@link resolveValidationRunner}'s `defaults.llm` fallback only for
188
- * the unset/`llm` case: when the block sets neither `mode` nor `profile` (so
189
- * the profile resolver returns `null`) or `mode: "llm"`, fall back to an `llm`
190
- * runner built from `defaults.llm` so `judgment.mode: llm` defaults are honored
191
- * (§14). However (FIX 8) when the caller EXPLICITLY sets `mode: "agent"` or
192
- * `"sdk"` and the profile resolver returns `null` or throws, do NOT downgrade
193
- * to an llm judge — return `null` (callers skip the judgment tier and emit
194
- * `triage_deferred`) and emit a `warn(...)`. Returns `null` when nothing is
195
- * configured.
196
- */
197
- export function resolveTriageJudgmentRunner(judgment, config) {
198
- return resolveProcessRunnerWithLlmFallback(judgment, config, {
199
- fallbackTimeoutMs: judgment?.timeoutMs,
200
- suppressLlmFallbackForExplicitMode: true,
201
- });
202
- }
203
- export function resolveRunner(mode, profileName, config) {
204
- if (mode === "llm")
205
- return buildLlmRunnerSpec(profileName, undefined, config);
206
- return buildAgentRunnerSpec(mode, profileName, undefined, config);
207
- }
208
- /**
209
- * Resolve a RunnerSpec from an improve-profile process entry. Returns `null`
210
- * when the entry is absent or provides no overrides — callers should fall
211
- * back to the default per-process runner resolution path.
212
- */
213
- export function resolveImproveProcessRunnerFromProfile(processConfig, config) {
214
- if (!processConfig)
85
+ /** Resolve the LLM runner selected by an improve strategy and process without reading credentials. */
86
+ export function resolveImproveProcessRunner(strategy, processName, config) {
87
+ if (!strategy)
215
88
  return null;
216
- const { mode: explicitMode, profile, timeoutMs } = processConfig;
217
- if (!explicitMode && !profile)
89
+ const resolved = resolveImproveProcessLlmUse(config, strategy, processName, { optional: true });
90
+ if (!resolved)
218
91
  return null;
219
- const mode = explicitMode ?? resolveEffectiveMode(processConfig, profile, config);
220
- const profileName = profile ?? resolveProfileName(processConfig, mode, config);
221
- if (mode === "llm") {
222
- return buildLlmRunnerSpec(profileName, timeoutMs, config);
223
- }
224
- if (mode === "agent" || mode === "sdk") {
225
- return buildAgentRunnerSpec(mode, profileName, timeoutMs, config);
226
- }
227
- return null;
92
+ return {
93
+ kind: "llm",
94
+ engine: resolved.engine,
95
+ connection: resolved.connection,
96
+ ...(resolved.credential ? { credential: resolved.credential } : {}),
97
+ timeoutMs: resolved.timeoutMs,
98
+ };
228
99
  }
229
- // Re-export `isProcessEnabled` from feature-gate.ts so callers that previously
230
- // imported it from runner.ts continue to work.
231
100
  export { isProcessEnabled } from "../../llm/feature-gate.js";
@@ -251,8 +251,8 @@ function streamFailureMessage(profileName, stdout, stderr) {
251
251
  */
252
252
  export async function runAgent(profile, prompt, options = {}) {
253
253
  const stdioMode = options.stdio ?? profile.stdio;
254
- // null = explicitly disabled (no kill timer). undefined = inherit from profile/default.
255
- const timeoutMs = options.timeoutMs !== undefined ? options.timeoutMs : (profile.timeoutMs ?? DEFAULT_TIMEOUT_MS);
254
+ // null = explicitly disabled (no kill timer). undefined = runtime default.
255
+ const timeoutMs = options.timeoutMs !== undefined ? options.timeoutMs : DEFAULT_TIMEOUT_MS;
256
256
  const parseOutput = options.parseOutput ?? profile.parseOutput;
257
257
  const setTimeoutImpl = options.setTimeoutFn ?? setTimeout;
258
258
  const clearTimeoutImpl = options.clearTimeoutFn ?? clearTimeout;
@@ -272,7 +272,7 @@ export async function runAgent(profile, prompt, options = {}) {
272
272
  let builtArgv;
273
273
  let builtEnv;
274
274
  if (options.dispatch !== undefined) {
275
- const builder = getCommandBuilder(profile.commandBuilder ?? profile.name, options.builderRegistry);
275
+ const builder = getCommandBuilder(profile.platform ?? profile.name, options.builderRegistry);
276
276
  const built = builder.build(profile, options.dispatch);
277
277
  builtArgv = built.argv;
278
278
  builtEnv = built.env;
@@ -308,9 +308,7 @@ export async function runAgent(profile, prompt, options = {}) {
308
308
  stdout: stdioMode === "captured" ? "pipe" : "inherit",
309
309
  stderr: stdioMode === "captured" ? "pipe" : "inherit",
310
310
  env,
311
- // options.cwd wins; dispatch.cwd is the request-level fallback (it was
312
- // declared on AgentDispatchRequest but consumed by nothing — P0.5 fix).
313
- ...((options.cwd ?? options.dispatch?.cwd) ? { cwd: options.cwd ?? options.dispatch?.cwd } : {}),
311
+ ...(options.cwd ? { cwd: options.cwd } : {}),
314
312
  // Spawn in its own process group so killGroup(-pid, signal) reaches all
315
313
  // descendants (e.g. the .opencode binary that opencode's node wrapper forks).
316
314
  // Only applied in captured mode — interactive mode inherits the parent
@@ -65,8 +65,7 @@
65
65
  * `structuredOutput: "none"` and no `resume`). Exported standalone so that
66
66
  * task only adds a registry entry.
67
67
  */
68
- import { assertNotFlag } from "../../agent/builder-shared.js";
69
- import { resolveModel } from "../../agent/model-aliases.js";
68
+ import { assertNotFlag, resolveDispatchModel, } from "../../agent/builder-shared.js";
70
69
  /** Canonical harness/platform id used for model-alias resolution. */
71
70
  export const AIDER_PLATFORM = "aider";
72
71
  /**
@@ -98,7 +97,7 @@ export const aiderBuilder = {
98
97
  assertNotFlag(req.model, "model");
99
98
  const args = [...profile.args];
100
99
  if (req.model) {
101
- const resolved = resolveModel(req.model, AIDER_PLATFORM, profile.modelAliases, profile.globalModelAliases);
100
+ const resolved = resolveDispatchModel(req, profile, AIDER_PLATFORM);
102
101
  args.push("--model", resolved);
103
102
  }
104
103
  // Headless essentials (matrix shape): auto-confirm everything, and keep
@@ -24,7 +24,6 @@ function caps(c) {
24
24
  detection: false,
25
25
  configImport: false,
26
26
  runtimeIdentity: false,
27
- v1Migration: false,
28
27
  ...c,
29
28
  };
30
29
  }
@@ -60,8 +60,7 @@
60
60
  * pattern `local-runner`, structuredOutput `none`). Exported standalone so
61
61
  * that task only adds a registry entry.
62
62
  */
63
- import { assertNotFlag } from "../../agent/builder-shared.js";
64
- import { resolveModel } from "../../agent/model-aliases.js";
63
+ import { assertNotFlag, resolveDispatchModel, } from "../../agent/builder-shared.js";
65
64
  /** Canonical harness/platform id used for model-alias resolution. */
66
65
  export const AMAZONQ_PLATFORM = "amazonq";
67
66
  /**
@@ -141,7 +140,7 @@ export const amazonqBuilder = {
141
140
  args.push("--trust-all-tools");
142
141
  }
143
142
  if (req.model) {
144
- const resolved = resolveModel(req.model, AMAZONQ_PLATFORM, profile.modelAliases, profile.globalModelAliases);
143
+ const resolved = resolveDispatchModel(req, profile, AMAZONQ_PLATFORM);
145
144
  args.push("--model", resolved);
146
145
  }
147
146
  // No system-prompt / schema flags exist on `q chat` — both travel in the
@@ -25,7 +25,6 @@ function caps(c) {
25
25
  detection: false,
26
26
  configImport: false,
27
27
  runtimeIdentity: false,
28
- v1Migration: false,
29
28
  ...c,
30
29
  };
31
30
  }