akm-cli 0.9.0-rc.1 → 0.9.0-rc.13

package/dist/commands/improve/outcome-loop.js

@@ -1,6 +1,7 @@
 // This Source Code Form is subject to the terms of the Mozilla Public
 // License, v. 2.0. If a copy of the MPL was not distributed with this
 // file, You can obtain one at https://mozilla.org/MPL/2.0/.
+import { getAllAssetOutcomes, getAssetOutcome, getOutcomeScoresByRef, upsertAssetOutcome, } from "../../storage/repositories/outcome-repository.js";
 // ── Constants ─────────────────────────────────────────────────────────────────
 /**
  * EMA decay factor for the expected-retrieval rolling mean (α).
@@ -42,25 +43,14 @@ export const OUTCOME_SCORE_MAX = 1.5;
  * assets cannot be permanently outcompeted. 0 = disabled (pure competition).
  */
 export const DIVERSITY_FLOOR_FRACTION = 0.1;
-/**
- * Default review_pressure increment per negative-feedback retrieval cycle.
- * Each cycle where negative_feedback_count > 0, pressure increases by this
- * much (and decreases by REVIEW_PRESSURE_DECAY if no new negatives).
- */
-export const REVIEW_PRESSURE_INCREMENT = 1;
-/**
- * Decay per non-negative cycle. Keeps review_pressure from accumulating forever
- * when an asset's quality problems are addressed and feedback turns positive.
- */
-export const REVIEW_PRESSURE_DECAY = 1;
 /**
  * Upsert one asset's outcome row.
  *
  * On first call for a ref (no prior row): warm-starts from `utilityScore`.
  * On subsequent calls: applies the differential update formula.
  *
- * Returns the resulting `outcome_score` and `review_pressure` so the caller
- * can pass them to `computeSalience` without a second read.
+ * Returns the resulting `outcome_score` so the caller can pass it to
+ * `computeSalience` without a second read.
  */
 export function updateAssetOutcome(db, inputs) {
     const now = inputs.now ?? Date.now();
@@ -69,7 +59,6 @@ export function updateAssetOutcome(db, inputs) {
     const existing = getAssetOutcome(db, inputs.ref);
     const isNewRow = existing === undefined;
     let outcomeScore;
-    let reviewPressure;
     let expectedRetrievalRate;
     if (isNewRow) {
         // ── Warm-start ─────────────────────────────────────────────────────────
@@ -78,7 +67,6 @@ export function updateAssetOutcome(db, inputs) {
         // will adjust it up or down from there.
         const seedScore = Math.min(WARM_START_CAP, Math.max(0, inputs.utilityScore ?? 0));
         outcomeScore = seedScore;
-        reviewPressure = 0;
         // Seed expected_retrieval_rate = 0 (no delta history yet).
         // Seeding with currentRetrievalCount would produce a large spurious negative
         // prediction error on the first real cycle (delta ≪ cumulative count).
@@ -107,83 +95,32 @@ export function updateAssetOutcome(db, inputs) {
         const newScore = OUTCOME_EMA_ALPHA * rawUpdate + (1 - OUTCOME_EMA_ALPHA) * existing.outcome_score;
         // Clip to [OUTCOME_SCORE_MIN, OUTCOME_SCORE_MAX] — the ceiling is the RPE
         // saturation analog (G2): without it, long-lived popular assets accumulate
-        // unbounded positive mass (live max was 3.13) and would dominate rank_score
-        // the moment the outcome weight is enabled. Stored legacy scores above the
-        // ceiling converge back under it on their next differential update.
+        // unbounded positive mass and would dominate rank_score when outcome weight
+        // is enabled.
         outcomeScore = Math.min(OUTCOME_SCORE_MAX, Math.max(OUTCOME_SCORE_MIN, newScore));
-        // ── review_pressure (#613) ─────────────────────────────────────────────
-        // New negatives this cycle.
-        const newNegatives = Math.max(0, inputs.negativeFeedbackCount - existing.negative_feedback_count);
-        if (newNegatives > 0) {
-            reviewPressure = Math.min(10, existing.review_pressure + REVIEW_PRESSURE_INCREMENT * newNegatives);
-        }
-        else {
-            // Decay when no new negatives.
-            reviewPressure = Math.max(0, existing.review_pressure - REVIEW_PRESSURE_DECAY);
-        }
     }
-    // Upsert the row.
-    db.prepare(`INSERT INTO asset_outcome
-       (asset_ref, last_retrieved_at, retrieval_count, expected_retrieval_rate,
-        negative_feedback_count, accepted_change_count, review_pressure,
-        outcome_score, updated_at)
-     VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?)
-     ON CONFLICT(asset_ref) DO UPDATE SET
-       last_retrieved_at      = excluded.last_retrieved_at,
-       retrieval_count        = excluded.retrieval_count,
-       expected_retrieval_rate= excluded.expected_retrieval_rate,
-       negative_feedback_count= excluded.negative_feedback_count,
-       accepted_change_count  = excluded.accepted_change_count,
-       review_pressure        = excluded.review_pressure,
-       outcome_score          = excluded.outcome_score,
-       updated_at             = excluded.updated_at`).run(inputs.ref, inputs.lastRetrievedAt, inputs.currentRetrievalCount, expectedRetrievalRate, inputs.negativeFeedbackCount, inputs.acceptedChangeCount, reviewPressure, outcomeScore, now);
-    return { outcomeScore, reviewPressure, isNewRow };
+    // Upsert the row. See `upsertAssetOutcome` in
+    // storage/repositories/outcome-repository.ts (#672 part 2) for the SQL text
+    // and the `review_pressure` omission rationale — this call site is
+    // unchanged in intent, just no longer inline.
+    upsertAssetOutcome(db, {
+        ref: inputs.ref,
+        lastRetrievedAt: inputs.lastRetrievedAt,
+        retrievalCount: inputs.currentRetrievalCount,
+        expectedRetrievalRate,
+        negativeFeedbackCount: inputs.negativeFeedbackCount,
+        acceptedChangeCount: inputs.acceptedChangeCount,
+        outcomeScore,
+        updatedAt: now,
+    });
+    return { outcomeScore, isNewRow };
 }
 // ── Reader ────────────────────────────────────────────────────────────────────
-/**
- * Load the outcome row for one asset, or `undefined` if not yet written.
- */
-export function getAssetOutcome(db, ref) {
-    const row = db
-        .prepare(`SELECT asset_ref, last_retrieved_at, retrieval_count, expected_retrieval_rate,
-              negative_feedback_count, accepted_change_count, review_pressure,
-              outcome_score, updated_at
-       FROM asset_outcome WHERE asset_ref = ?`)
-        .get(ref);
-    return row == null ? undefined : row;
-}
-/**
- * Load ALL asset_outcome rows. Used for the proxy-adequacy tripwire computation.
- */
-export function getAllAssetOutcomes(db) {
-    return db
-        .prepare(`SELECT asset_ref, last_retrieved_at, retrieval_count, expected_retrieval_rate,
-              negative_feedback_count, accepted_change_count, review_pressure,
-              outcome_score, updated_at
-       FROM asset_outcome ORDER BY asset_ref`)
-        .all();
-}
-/**
- * Build a Map<ref, outcome_score> for a set of refs in one query.
- * Used by `salience.ts` to populate `outcomeSalience`.
- */
-export function getOutcomeScoresByRef(db, refs) {
-    const result = new Map();
-    if (refs.length === 0)
-        return result;
-    const CHUNK = 500;
-    for (let i = 0; i < refs.length; i += CHUNK) {
-        const chunk = refs.slice(i, i + CHUNK);
-        const placeholders = chunk.map(() => "?").join(",");
-        const rows = db
-            .prepare(`SELECT asset_ref, outcome_score FROM asset_outcome WHERE asset_ref IN (${placeholders})`)
-            .all(...chunk);
-        for (const row of rows) {
-            result.set(row.asset_ref, row.outcome_score);
-        }
-    }
-    return result;
-}
+//
+// getAssetOutcome / getAllAssetOutcomes / getOutcomeScoresByRef moved verbatim
+// to storage/repositories/outcome-repository.ts (#672 part 2) — re-exported
+// here so existing importers of this module resolve unchanged.
+export { getAllAssetOutcomes, getAssetOutcome, getOutcomeScoresByRef };
 // ── outcomeSalience projection ────────────────────────────────────────────────
 /**
  * Convert a raw `outcome_score` (differential, may be negative) to a