akm-cli 0.7.5 → 0.8.0-rc.6

package/dist/output/shapes.js

@@ -1,11 +1,75 @@
-/**
- * Pure shaping functions that select and trim fields from command result
- * objects according to the active detail level / agent mode.
- *
- * Every function in this module is side-effect free and operates on plain
- * `Record<string, unknown>` shapes, which makes them trivial to unit test.
- */
+// This Source Code Form is subject to the terms of the Mozilla Public
+// License, v. 2.0. If a copy of the MPL was not distributed with this
+// file, You can obtain one at https://mozilla.org/MPL/2.0/.
 const NORMAL_DESCRIPTION_LIMIT = 250;
+const PASSTHROUGH_COMMANDS = new Set([
+    "add",
+    "agent-result",
+    "clone",
+    "config",
+    "consolidate",
+    "curate",
+    "db-backups",
+    "disable",
+    "enable",
+    "feedback",
+    "graph-entities",
+    "graph-entity",
+    "graph-export",
+    "graph-orphans",
+    "graph-related",
+    "graph-relations",
+    "graph-summary",
+    "health",
+    "import",
+    "improve",
+    "index",
+    "info",
+    "init",
+    "lessons-coverage",
+    "lint",
+    "list",
+    "registry-add",
+    "registry-build-index",
+    "registry-list",
+    "registry-remove",
+    "remember",
+    "remove",
+    "save",
+    "setup",
+    "tasks-add",
+    "tasks-disable",
+    "tasks-doctor",
+    "tasks-enable",
+    "tasks-history",
+    "tasks-list",
+    "tasks-remove",
+    "tasks-run",
+    "tasks-show",
+    "tasks-sync",
+    "update",
+    "upgrade",
+    "vault-create",
+    "vault-set",
+    "vault-unset",
+    "wiki-create",
+    "wiki-ingest",
+    "wiki-lint",
+    "wiki-list",
+    "wiki-pages",
+    "wiki-register",
+    "wiki-remove",
+    "wiki-show",
+    "wiki-stash",
+    "workflow-complete",
+    "workflow-create",
+    "workflow-list",
+    "workflow-next",
+    "workflow-resume",
+    "workflow-start",
+    "workflow-status",
+    "workflow-validate",
+]);
 export function shapeForCommand(command, result, detail, forAgent = false) {
     switch (command) {
         case "search":
@@ -39,72 +103,40 @@ export function shapeForCommand(command, result, detail, forAgent = false) {
             return shapeProposalRejectOutput(result, detail);
         case "proposal-diff":
             return shapeProposalDiffOutput(result, detail);
+        // Phase 6C (Advantage D6c): revert envelope mirrors accept/reject.
+        case "proposal-revert":
+            return shapeProposalRevertOutput(result, detail);
         // Output shape registration for `akm reflect` and `akm propose` (#226).
         // Both share the proposal-producer envelope shape (success carries a
         // proposal entry; failure carries an AgentFailureReason discriminant).
         case "reflect":
         case "propose":
             return shapeProposalProducerOutput(result, detail);
-        // Output shape registration for `akm distill <ref>` (#228). The shape is
-        // simple — outcome + ids + optional payload — so `brief` strips the full
-        // proposal blob, `normal` keeps the headline fields, and `full` projects
-        // everything for downstream automation.
         case "distill":
             return shapeDistillOutput(result, detail);
-        // Identity-passthrough commands — registered here so the registry stays
-        // exhaustive (v1 spec §9). Each result object is already shaped at the
-        // command boundary; the registry just confirms there's no surprise
-        // command name slipping through.
-        case "add":
-        case "clone":
-        case "config":
-        case "curate":
-        case "disable":
-        case "enable":
-        case "feedback":
-        case "import":
-        case "index":
-        case "info":
-        case "init":
-        case "list":
-        case "registry-add":
-        case "registry-build-index":
-        case "registry-list":
-        case "registry-remove":
-        case "remember":
-        case "remove":
-        case "save":
-        case "update":
-        case "upgrade":
-        case "vault-create":
-        case "vault-list":
-        case "vault-set":
-        case "vault-unset":
-        case "wiki-create":
-        case "wiki-ingest":
-        case "wiki-lint":
-        case "wiki-list":
-        case "wiki-pages":
-        case "wiki-register":
-        case "wiki-remove":
-        case "wiki-show":
-        case "wiki-stash":
-        case "workflow-complete":
-        case "workflow-create":
-        case "workflow-list":
-        case "workflow-next":
-        case "workflow-resume":
-        case "workflow-start":
-        case "workflow-status":
-        case "workflow-validate":
-            return result;
+        case "vault-list": {
+            const r = result;
+            const vaults = Array.isArray(r.vaults) ? r.vaults : [];
+            return {
+                ...r,
+                vaults: vaults.map((v) => {
+                    const { path: _path, ...rest } = v;
+                    return rest;
+                }),
+            };
+        }
         default:
-            // v1 spec §9 (output-shape registry exhaustive): no silent JSON.stringify
-            // fallback. A missing case here is a registration bug — fail loudly so
-            // the caller (or its tests) sees the missing command name.
+            // v1 spec §9 (output-shape registry exhaustive): identity-passthrough
+            // commands are listed in PASSTHROUGH_COMMANDS; anything not in that set
+            // is a registration bug — fail loudly.
+            if (PASSTHROUGH_COMMANDS.has(command))
+                return result;
             throw new Error(`output shape not registered for command: ${command}`);
     }
 }
+function maybeAddSchema(base, detail, version) {
+    return detail === "full" ? { schemaVersion: version ?? 1, ...base } : base;
+}
 /**
  * Shape the result of `akm reflect` / `akm propose`. On success we surface
  * the queued proposal entry (using the standard proposal-entry shaper so
@@ -141,17 +173,27 @@ export function shapeProposalProducerOutput(result, detail) {
         ...(typeof result.durationMs === "number" ? { durationMs: result.durationMs } : {}),
         proposal: shapeProposalEntry(proposal, detail === "brief" ? "normal" : detail),
     };
-    if (detail === "full") {
-        return { schemaVersion: result.schemaVersion ?? 1, ...base };
-    }
-    return base;
+    return maybeAddSchema(base, detail, result.schemaVersion);
 }
 export function shapeProposalEntry(entry, detail) {
     if (detail === "brief") {
-        return pickFields(entry, ["id", "ref", "status", "source", "createdAt"]);
+        // Phase 6A: confidence is small + load-bearing for auto-accept telemetry,
+        // so include it even at brief detail.
+        return pickFields(entry, ["id", "ref", "status", "source", "createdAt", "confidence"]);
     }
     if (detail === "normal" || detail === "summary") {
-        return pickFields(entry, ["id", "ref", "status", "source", "sourceRun", "createdAt", "updatedAt", "review"]);
+        return pickFields(entry, [
+            "id",
+            "ref",
+            "status",
+            "source",
+            "sourceRun",
+            "createdAt",
+            "updatedAt",
+            "review",
+            "confidence",
+            "backup",
+        ]);
     }
     // full / agent: project everything including the payload.
     return pickFields(entry, [
@@ -164,6 +206,8 @@ export function shapeProposalEntry(entry, detail) {
         "updatedAt",
         "payload",
         "review",
+        "confidence",
+        "backup",
     ]);
 }
 export function shapeProposalListOutput(result, detail) {
@@ -173,10 +217,7 @@ export function shapeProposalListOutput(result, detail) {
         totalCount: result.totalCount ?? shaped.length,
         proposals: shaped,
     };
-    if (detail === "full") {
-        return { schemaVersion: result.schemaVersion ?? 1, ...base };
-    }
-    return base;
+    return maybeAddSchema(base, detail, result.schemaVersion);
 }
 export function shapeProposalShowOutput(result, detail) {
     const proposal = result.proposal ?? {};
@@ -185,10 +226,7 @@ export function shapeProposalShowOutput(result, detail) {
         proposal: shapeProposalEntry(proposal, detail === "brief" ? "normal" : detail),
         ...(validation ? { validation } : {}),
     };
-    if (detail === "full") {
-        return { schemaVersion: result.schemaVersion ?? 1, ...base };
-    }
-    return base;
+    return maybeAddSchema(base, detail, result.schemaVersion);
 }
 export function shapeProposalAcceptOutput(result, detail) {
     const proposal = result.proposal ?? {};
@@ -199,10 +237,7 @@ export function shapeProposalAcceptOutput(result, detail) {
         assetPath: result.assetPath,
         proposal: shapeProposalEntry(proposal, detail === "brief" ? "normal" : detail),
     };
-    if (detail === "full") {
-        return { schemaVersion: result.schemaVersion ?? 1, ...base };
-    }
-    return base;
+    return maybeAddSchema(base, detail, result.schemaVersion);
 }
 export function shapeProposalRejectOutput(result, detail) {
     const proposal = result.proposal ?? {};
@@ -213,10 +248,26 @@ export function shapeProposalRejectOutput(result, detail) {
         ...(result.reason !== undefined ? { reason: result.reason } : {}),
         proposal: shapeProposalEntry(proposal, detail === "brief" ? "normal" : detail),
     };
-    if (detail === "full") {
-        return { schemaVersion: result.schemaVersion ?? 1, ...base };
-    }
-    return base;
+    return maybeAddSchema(base, detail, result.schemaVersion);
+}
+/**
+ * Shape the result of `akm proposal revert <id>` (Phase 6C / Advantage D6c).
+ *
+ * Mirrors {@link shapeProposalAcceptOutput} — the surface is intentionally
+ * symmetric with accept because the user-visible workflow is: accept restores
+ * the new content; revert restores the prior content; both should look the
+ * same in JSON output beyond the verb.
+ */
+export function shapeProposalRevertOutput(result, detail) {
+    const proposal = result.proposal ?? {};
+    const base = {
+        ok: result.ok ?? true,
+        id: result.id,
+        ref: result.ref,
+        assetPath: result.assetPath,
+        proposal: shapeProposalEntry(proposal, detail === "brief" ? "normal" : detail),
+    };
+    return maybeAddSchema(base, detail, result.schemaVersion);
 }
 export function shapeDistillOutput(result, detail) {
     const proposal = result.proposal;
@@ -233,10 +284,7 @@ export function shapeDistillOutput(result, detail) {
         ...(Array.isArray(result.findings) && result.findings.length > 0 ? { findings: result.findings } : {}),
         ...(proposal ? { proposal: shapeProposalEntry(proposal, detail === "summary" ? "normal" : detail) } : {}),
     };
-    if (detail === "full") {
-        return { schemaVersion: result.schemaVersion ?? 1, ...base };
-    }
-    return base;
+    return maybeAddSchema(base, detail, result.schemaVersion);
 }
 export function shapeProposalDiffOutput(result, detail) {
     const base = {
@@ -246,10 +294,7 @@ export function shapeProposalDiffOutput(result, detail) {
         unified: result.unified,
         ...(result.targetPath !== undefined ? { targetPath: result.targetPath } : {}),
     };
-    if (detail === "full") {
-        return { schemaVersion: result.schemaVersion ?? 1, ...base };
-    }
-    return base;
+    return maybeAddSchema(base, detail, result.schemaVersion);
 }
 export function shapeEventsOutput(result, detail) {
     const events = Array.isArray(result.events) ? result.events : [];
@@ -268,16 +313,10 @@ export function shapeEventsOutput(result, detail) {
     if (typeof result.reason === "string") {
         base.reason = result.reason;
     }
-    if (detail === "full") {
-        return { schemaVersion: result.schemaVersion ?? 1, ...base };
-    }
-    return base;
+    return maybeAddSchema(base, detail, result.schemaVersion);
 }
 export function shapeEventEntry(entry, detail) {
-    if (detail === "brief") {
-        return pickFields(entry, ["eventType", "ref", "ts"]);
-    }
-    if (detail === "normal" || detail === "summary") {
+    if (detail === "brief" || detail === "normal" || detail === "summary") {
         return pickFields(entry, ["eventType", "ref", "ts"]);
     }
     // full / agent: project everything the reader emits.
@@ -313,13 +352,13 @@ export function shapeHistoryEntry(entry, detail) {
     if (detail === "brief") {
         // signal is load-bearing for feedback rows (positive/negative) so we
         // project it even at brief — without it the entry is ambiguous.
-        return pickFields(entry, ["eventType", "ref", "signal", "createdAt"]);
+        return pickFields(entry, ["eventType", "ref", "signal", "source", "createdAt"]);
     }
     if (detail === "normal" || detail === "summary") {
-        return pickFields(entry, ["eventType", "ref", "signal", "query", "createdAt"]);
+        return pickFields(entry, ["eventType", "ref", "signal", "query", "source", "createdAt"]);
     }
     // full / agent: return everything the reader emits.
-    return pickFields(entry, ["id", "eventType", "ref", "entryId", "query", "signal", "metadata", "createdAt"]);
+    return pickFields(entry, ["id", "eventType", "ref", "entryId", "query", "signal", "source", "metadata", "createdAt"]);
 }
 export function shapeSearchOutput(result, detail, forAgent = false) {
     const hits = Array.isArray(result.hits) ? result.hits : [];
@@ -462,6 +501,7 @@ export function shapeShowOutput(result, detail, forAgent = false) {
             "steps",
             "keys",
             "comments",
+            "related",
         ]);
     }
     if (detail === "summary") {
@@ -477,9 +517,10 @@ export function shapeShowOutput(result, detail, forAgent = false) {
             "origin",
             "keys",
             "comments",
+            "related",
         ]);
     }
-    const base = pickFields(result, [
+    const baseFields = [
         "type",
         "name",
         "origin",
@@ -502,11 +543,15 @@ export function shapeShowOutput(result, detail, forAgent = false) {
         "activeRun",
         "keys",
         "comments",
+        "related",
         // path and editable are always projected so JSON consumers can locate and
         // edit the asset without needing --detail full (QA #7).
-        "path",
+        // Exception: vault assets omit path to avoid leaking absolute disk paths
+        // into structured JSON output (security fix M3).
+        ...(result.type === "vault" ? [] : ["path"]),
         "editable",
-    ]);
+    ];
+    const base = pickFields(result, baseFields);
     if (detail !== "full") {
         return base;
     }