akm-cli 0.7.4 → 0.8.0-rc.3

package/dist/commands/lint/task-linter.js

@@ -0,0 +1,47 @@
+import { BaseLinter } from "./base-linter";
+/**
+ * Linter for `tasks/` assets.
+ *
+ * Tasks are `.md` files with YAML frontmatter. In addition to the base checks
+ * this linter validates the required task fields:
+ *
+ *   - `schedule`  (string, non-empty) — cron expression or `@`-alias
+ *   - `enabled`   (boolean)
+ *   - At least one of: `prompt` or `workflow` field present
+ *
+ * All issues are reported as `invalid-task-frontmatter` and are **not**
+ * auto-fixable. Cron expression syntax validation is intentionally out of
+ * scope (that belongs to `parseSchedule()`).
+ */
+export class TaskLinter extends BaseLinter {
+    types = ["tasks"];
+    lint(ctx) {
+        const issues = this.runBaseChecks(ctx);
+        // Only validate frontmatter fields when frontmatter is present.
+        if (ctx.frontmatter === null)
+            return issues;
+        const missing = [];
+        // schedule: must be present and non-empty
+        if (!("schedule" in ctx.data) || typeof ctx.data.schedule !== "string" || ctx.data.schedule.trim() === "") {
+            missing.push("schedule");
+        }
+        // enabled: must be present (boolean — value of false is valid)
+        if (!("enabled" in ctx.data)) {
+            missing.push("enabled");
+        }
+        // At least one of: prompt or workflow
+        const hasTarget = "prompt" in ctx.data || "workflow" in ctx.data;
+        if (!hasTarget) {
+            missing.push("prompt or workflow");
+        }
+        if (missing.length > 0) {
+            issues.push({
+                file: ctx.relPath,
+                issue: "invalid-task-frontmatter",
+                detail: `missing required fields: ${missing.join(", ")}`,
+                fixed: false,
+            });
+        }
+        return issues;
+    }
+}

package/dist/commands/lint/types.js

@@ -0,0 +1 @@
+export {};

package/dist/commands/lint/vault-key-rules.js

@@ -0,0 +1,67 @@
+/**
+ * Vault security lint rules — flags known-dangerous environment variable names.
+ *
+ * These env var names, when present as vault keys, indicate the vault can be
+ * used to hijack process execution via loader injection, path override, or
+ * shell/runtime startup hooks.  The lint pass emits a warning-level finding;
+ * it does NOT block vault load or `akm add` installation.
+ */
+import { listKeys } from "../vault";
+// ── Dangerous key set ─────────────────────────────────────────────────────────
+export const DANGEROUS_VAULT_KEYS = new Set([
+    // Dynamic linker hijacking (Linux)
+    "LD_PRELOAD",
+    "LD_LIBRARY_PATH",
+    "LD_AUDIT",
+    "LD_DEBUG",
+    // Dynamic linker hijacking (macOS)
+    "DYLD_INSERT_LIBRARIES",
+    "DYLD_LIBRARY_PATH",
+    "DYLD_FRAMEWORK_PATH",
+    // Shell and command resolution
+    "PATH",
+    "BASH_ENV",
+    "ENV",
+    "PROMPT_COMMAND",
+    "PS1",
+    "PS2",
+    // Language runtime hijacking
+    "NODE_OPTIONS",
+    "NODE_PATH",
+    "PYTHONSTARTUP",
+    "PYTHONPATH",
+    "PYTHONINSPECT",
+    "RUBYLIB",
+    "RUBYOPT",
+    "PERL5LIB",
+    "PERL5OPT",
+    "JAVA_TOOL_OPTIONS",
+    "JDK_JAVA_OPTIONS",
+    "_JAVA_OPTIONS",
+]);
+// ── Checker ───────────────────────────────────────────────────────────────────
+/**
+ * Inspect a vault `.env` file and return a lint finding for every key whose
+ * name appears in `DANGEROUS_VAULT_KEYS`.
+ *
+ * @param vaultPath  Absolute path to the `.env` file.
+ * @param relPath    Stash-relative path used as the `file` field in findings
+ *                   (e.g. `"vaults/prod.env"`).
+ * @param vaultRef   Human-readable vault ref (e.g. `"vault:prod"`) shown in
+ *                   the finding message.
+ */
+export function checkVaultForDangerousKeys(vaultPath, relPath, vaultRef) {
+    const { keys } = listKeys(vaultPath);
+    const issues = [];
+    for (const key of keys) {
+        if (!DANGEROUS_VAULT_KEYS.has(key))
+            continue;
+        issues.push({
+            file: relPath,
+            issue: "dangerous-vault-key",
+            detail: `Vault key \`${key}\` can be used to hijack process execution when injected via \`akm vault run\`. Vault ref: ${vaultRef}. Review this vault file before running \`akm vault run\` commands against untrusted stashes.`,
+            fixed: false,
+        });
+    }
+    return issues;
+}

package/dist/commands/lint/workflow-linter.js

@@ -0,0 +1,53 @@
+import fs from "node:fs";
+import { BaseLinter } from "./base-linter";
+const PLACEHOLDER_STRINGS = ["Describe what this workflow accomplishes", "Example Workflow"];
+/**
+ * Linter for `workflows/` assets.
+ *
+ * Extra check beyond base:
+ *   - `placeholder-stub`: body contains a known placeholder string.
+ *     Fix: delete the file.
+ */
+export class WorkflowLinter extends BaseLinter {
+    types = ["workflows"];
+    lint(ctx) {
+        const issues = this.runBaseChecks(ctx);
+        const placeholderMatch = this.#checkPlaceholderStub(ctx.body);
+        if (placeholderMatch) {
+            if (ctx.fix) {
+                try {
+                    fs.unlinkSync(ctx.filePath);
+                    issues.push({
+                        file: ctx.relPath,
+                        issue: "placeholder-stub",
+                        detail: `deleted: found "${placeholderMatch}"`,
+                        fixed: true,
+                    });
+                }
+                catch (e) {
+                    issues.push({
+                        file: ctx.relPath,
+                        issue: "placeholder-stub",
+                        detail: `could not delete: ${e instanceof Error ? e.message : String(e)}`,
+                        fixed: false,
+                    });
+                }
+                return issues;
+            }
+            issues.push({
+                file: ctx.relPath,
+                issue: "placeholder-stub",
+                detail: `placeholder text: "${placeholderMatch}"`,
+                fixed: false,
+            });
+        }
+        return issues;
+    }
+    #checkPlaceholderStub(body) {
+        for (const placeholder of PLACEHOLDER_STRINGS) {
+            if (body.includes(placeholder))
+                return placeholder;
+        }
+        return null;
+    }
+}

package/dist/commands/lint.js

@@ -0,0 +1 @@
+export { akmLint } from "./lint/index";

package/dist/commands/migration-help.js

@@ -1,6 +1,6 @@
 import fs from "node:fs";
 import path from "node:path";
-const CHANGELOG_URL = "https://github.com/itlackey/akm/blob/main/CHANGELOG.md";
+const CHANGELOG_URL = "https://github.com/itlackey/akm/blob/main/.github/CHANGELOG.md";
 const MIGRATION_DOC_URL = "https://github.com/itlackey/akm/blob/main/docs/migration/v0.5-to-v0.6.md";
 /**
  * Directory containing per-version release notes. Resolved relative to
@@ -14,7 +14,7 @@ function releaseNotesDir() {
 }
 function loadChangelog() {
     try {
-        const changelogPath = path.resolve(import.meta.dir, "../../CHANGELOG.md");
+        const changelogPath = path.resolve(import.meta.dir, "../../.github/CHANGELOG.md");
         if (fs.existsSync(changelogPath)) {
             return fs.readFileSync(changelogPath, "utf8");
         }

package/dist/commands/proposal.js

@@ -12,7 +12,7 @@ import { resolveStashDir } from "../core/common";
 import { loadConfig } from "../core/config";
 import { UsageError } from "../core/errors";
 import { appendEvent } from "../core/events";
-import { archiveProposal, createProposal, diffProposal, getProposal, listProposals, promoteProposal, validateProposal, } from "../core/proposals";
+import { archiveProposal, createProposal, diffProposal, getProposal, listProposals, promoteProposal, resolveProposalId, validateProposal, } from "../core/proposals";
 // ── Shared helpers ──────────────────────────────────────────────────────────
 function resolveStash(stashDir) {
     if (stashDir)
@@ -43,7 +43,8 @@ export function akmProposalShow(options) {
 export async function akmProposalAccept(options) {
     const stash = resolveStash(options.stashDir);
     const config = options.config ?? loadConfig();
-    const result = await promoteProposal(stash, config, options.id, { target: options.target }, options.ctx);
+    const resolvedId = resolveProposalId(stash, options.id).id;
+    const result = await promoteProposal(stash, config, resolvedId, { target: options.target }, options.ctx);
     // Emit `promoted` to the events stream so observers (audit, dashboards,
     // sync) see the accept happen. Only emit on the happy path — promotion
     // throws on validation failure, so reaching this point means the asset
@@ -69,11 +70,11 @@ export async function akmProposalAccept(options) {
 }
 export function akmProposalReject(options) {
     const stash = resolveStash(options.stashDir);
-    const existing = getProposal(stash, options.id);
+    const existing = resolveProposalId(stash, options.id);
     if (existing.status !== "pending") {
-        throw new UsageError(`Proposal ${options.id} is not pending (current status: ${existing.status}). Only pending proposals can be rejected.`, "INVALID_FLAG_VALUE");
+        throw new UsageError(`Proposal ${existing.id} is not pending (current status: ${existing.status}). Only pending proposals can be rejected.`, "INVALID_FLAG_VALUE");
     }
-    const updated = archiveProposal(stash, options.id, "rejected", options.reason, options.ctx);
+    const updated = archiveProposal(stash, existing.id, "rejected", options.reason, options.ctx);
     appendEvent({
         eventType: "rejected",
         ref: updated.ref,
@@ -96,8 +97,8 @@ export function akmProposalReject(options) {
 export function akmProposalDiff(options) {
     const stash = resolveStash(options.stashDir);
     const config = options.config ?? loadConfig();
-    const proposal = getProposal(stash, options.id);
-    const diff = diffProposal(stash, config, options.id, { target: options.target });
+    const proposal = resolveProposalId(stash, options.id);
+    const diff = diffProposal(stash, config, proposal.id, { target: options.target });
     return {
         schemaVersion: 1,
         id: proposal.id,

package/dist/commands/propose.js

@@ -12,34 +12,19 @@
 import { parseAssetRef } from "../core/asset-ref";
 import { TYPE_DIRS } from "../core/asset-spec";
 import { resolveStashDir } from "../core/common";
-import { loadConfig } from "../core/config";
 import { ConfigError, UsageError } from "../core/errors";
 import { appendEvent } from "../core/events";
 import { createProposal } from "../core/proposals";
-import { parseAgentConfig, requireAgentProfile, runAgent, } from "../integrations/agent";
+import { runAgent, } from "../integrations/agent";
+import { resolveProcessAgentProfile } from "../integrations/agent/config";
 import { buildProposePrompt, parseAgentProposalPayload } from "../integrations/agent/prompts";
-function loadAgentConfigFromDisk() {
-    const config = loadConfig();
-    return parseAgentConfig(config.agent);
-}
-function resolveProfile(options) {
-    if (options.agentProfile)
-        return options.agentProfile;
-    const agent = options.agentConfig ?? loadAgentConfigFromDisk();
-    return requireAgentProfile(agent, options.profile);
-}
+import { runAgentSdk } from "../integrations/agent/sdk-runner";
+import { baseFailureFields, enoentHintMessage, isEnoentFailure, loadAgentConfigFromDisk, resolveAgentProfile, } from "./agent-support";
 function failureEnvelope(result, type, name, fallbackReason = "non_zero_exit") {
-    const reason = result.reason ?? fallbackReason;
     return {
-        schemaVersion: 1,
-        ok: false,
-        reason,
-        error: result.error ?? `agent failure (${reason})`,
+        ...baseFailureFields(result, fallbackReason),
         type,
         name,
-        exitCode: result.exitCode,
-        ...(result.stdout ? { stdout: result.stdout } : {}),
-        ...(result.stderr ? { stderr: result.stderr } : {}),
     };
 }
 export async function akmPropose(options) {
@@ -68,9 +53,31 @@ export async function akmPropose(options) {
         },
     });
     // 2. Resolve profile.
+    // When an explicit --profile flag is given, honour it directly (existing
+    // behaviour). Otherwise use resolveProcessAgentProfile so that per-process
+    // agent config (agent.processes["propose"]) is picked up automatically.
     let profile;
+    let resolvedTimeoutMs = options.timeoutMs;
     try {
-        profile = resolveProfile(options);
+        if (options.agentProfile) {
+            // Test seam: injected profile bypasses all config.
+            profile = options.agentProfile;
+        }
+        else if (options.profile) {
+            // Explicit --profile flag wins over process config.
+            profile = resolveAgentProfile(options);
+        }
+        else {
+            // Use per-process config resolution (falls back to agent.default).
+            const agent = options.agentConfig ?? loadAgentConfigFromDisk();
+            const processName = options.agentProcess ?? "propose";
+            const resolved = resolveProcessAgentProfile(processName, agent);
+            profile = resolved.profile;
+            // Only apply process-resolved timeoutMs when caller didn't supply one.
+            if (resolvedTimeoutMs === undefined) {
+                resolvedTimeoutMs = resolved.timeoutMs;
+            }
+        }
     }
     catch (err) {
         if (err instanceof ConfigError || err instanceof UsageError)
@@ -78,40 +85,96 @@ export async function akmPropose(options) {
         throw err;
     }
     // 3. Build prompt.
+    // Synthesize a temp draft path so opencode can write the asset content
+    // directly using its file tools rather than returning JSON via stdout.
+    const draftFilePath = import("node:os").then((os) => import("node:path").then((path) => path.join(os.tmpdir(), `akm-propose-${options.type}-${options.name.replace(/[^a-z0-9_-]/gi, "_")}-${Date.now()}.md`)));
+    const resolvedDraftPath = await draftFilePath;
     const prompt = buildProposePrompt({
         type: options.type,
         name: options.name,
         task: options.task,
+        draftFilePath: resolvedDraftPath,
     });
     // 4. Spawn the agent.
-    const runOptions = {
-        stdio: "captured",
-        parseOutput: "text",
-        ...(options.timeoutMs !== undefined ? { timeoutMs: options.timeoutMs } : {}),
-        ...(options.runAgentOptions ?? {}),
-    };
-    const result = await runAgent(profile, prompt, runOptions);
+    // Real agent runs use interactive mode so file tools can write the draft.
+    // Injected/custom spawns still need captured stdout for JSON payload tests.
+    // Use callAi for the unified AI dispatch path (agent CLI preferred, LLM HTTP fallback).
+    const useCustomSpawn = Boolean(options.runAgentOptions?.spawn);
+    let result;
+    if (useCustomSpawn) {
+        // Test seam: use raw runAgent with injected spawn so tests remain deterministic.
+        const runOptions = {
+            stdio: "captured",
+            parseOutput: "text",
+            ...(resolvedTimeoutMs !== undefined ? { timeoutMs: resolvedTimeoutMs } : {}),
+            ...(options.runAgentOptions ?? {}),
+        };
+        result = await runAgent(profile, prompt, runOptions);
+    }
+    else {
+        // Production path: dispatch directly to the appropriate runner.
+        const runOptions = {
+            stdio: resolvedDraftPath ? "interactive" : "captured",
+            parseOutput: "text",
+            ...(resolvedTimeoutMs !== undefined ? { timeoutMs: resolvedTimeoutMs } : {}),
+        };
+        result = profile.sdkMode
+            ? await runAgentSdk(profile, prompt ?? "", runOptions)
+            : await runAgent(profile, prompt, runOptions);
+    }
     if (!result.ok) {
+        // B3: ENOENT / not-found gives an actionable hint.
+        if (isEnoentFailure(result)) {
+            return { ...failureEnvelope(result, options.type, options.name), error: enoentHintMessage(profile.bin) };
+        }
         return failureEnvelope(result, options.type, options.name);
     }
-    // 5. Parse the structured response.
+    // 5. Resolve the proposal content.
+    // Path A: opencode wrote the draft file — read it directly (no stdout parse).
+    // Path B: fallback to stdout JSON parse for non-file-writing agents.
+    const fs = await import("node:fs");
     let payload;
-    try {
-        payload = parseAgentProposalPayload(result.stdout);
-    }
-    catch (err) {
-        return {
-            schemaVersion: 1,
-            ok: false,
-            reason: "parse_error",
-            error: err instanceof Error ? err.message : String(err),
-            type: options.type,
-            name: options.name,
-            exitCode: result.exitCode,
-            stdout: result.stdout,
-            ...(result.stderr ? { stderr: result.stderr } : {}),
+    if (fs.existsSync(resolvedDraftPath)) {
+        const draftContent = fs.readFileSync(resolvedDraftPath, "utf8");
+        fs.unlinkSync(resolvedDraftPath);
+        payload = {
+            ref: `${options.type}:${options.name}`,
+            content: draftContent,
         };
     }
+    else {
+        // B1: When interactive mode was used and stdout is empty, the agent did not
+        // write the draft file and stdout was not captured — surface an actionable error.
+        const stdioWasInteractive = !useCustomSpawn;
+        if (stdioWasInteractive && (result.stdout ?? "") === "") {
+            return {
+                schemaVersion: 1,
+                ok: false,
+                reason: "parse_error",
+                error: "Agent did not write draft file and stdout was not captured (interactive mode). Check that the agent CLI understood the file-write instruction, or configure a headless profile with stdio: 'captured'.",
+                type: options.type,
+                name: options.name,
+                exitCode: result.exitCode,
+                ...(result.stderr ? { stderr: result.stderr } : {}),
+            };
+        }
+        try {
+            payload = parseAgentProposalPayload(result.stdout ?? "");
+        }
+        catch (err) {
+            return {
+                schemaVersion: 1,
+                ok: false,
+                reason: "parse_error",
+                error: err instanceof Error ? err.message : String(err),
+                type: options.type,
+                name: options.name,
+                exitCode: result.exitCode,
+                stdout: result.stdout,
+                ...(result.stderr ? { stderr: result.stderr } : {}),
+            };
+        }
+    }
     // 6. Insert the proposal. Note: we allow the agent's `ref` to normalise the
     // asset name (e.g. path-cleanup), but only after validating that the ref is
     // well-formed and the type still matches the requested type.