akm-cli 0.6.0 → 0.7.0-rc1
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/CHANGELOG.md +66 -0
- package/dist/{cli.js → src/cli.js} +672 -29
- package/dist/{commands → src/commands}/config-cli.js +5 -4
- package/dist/src/commands/distill.js +283 -0
- package/dist/src/commands/events.js +108 -0
- package/dist/src/commands/history.js +120 -0
- package/dist/{commands → src/commands}/installed-stashes.js +28 -2
- package/dist/src/commands/proposal.js +119 -0
- package/dist/src/commands/propose.js +171 -0
- package/dist/src/commands/reflect.js +193 -0
- package/dist/{commands → src/commands}/registry-search.js +2 -1
- package/dist/{commands → src/commands}/remember.js +12 -0
- package/dist/{commands → src/commands}/search.js +74 -1
- package/dist/{commands → src/commands}/self-update.js +4 -3
- package/dist/{commands → src/commands}/show.js +67 -2
- package/dist/{core → src/core}/asset-ref.js +5 -5
- package/dist/{core → src/core}/asset-spec.js +12 -0
- package/dist/{core → src/core}/common.js +1 -1
- package/dist/{core → src/core}/config.js +175 -121
- package/dist/{core → src/core}/errors.js +4 -0
- package/dist/src/core/events.js +239 -0
- package/dist/src/core/lesson-lint.js +86 -0
- package/dist/src/core/proposals.js +406 -0
- package/dist/src/core/warn.js +72 -0
- package/dist/{core → src/core}/write-source.js +80 -5
- package/dist/{indexer → src/indexer}/db-search.js +119 -27
- package/dist/{indexer → src/indexer}/db.js +76 -23
- package/dist/{indexer → src/indexer}/file-context.js +0 -3
- package/dist/src/indexer/graph-boost.js +179 -0
- package/dist/src/indexer/graph-extraction.js +212 -0
- package/dist/{indexer → src/indexer}/indexer.js +73 -6
- package/dist/src/indexer/memory-inference.js +263 -0
- package/dist/{indexer → src/indexer}/metadata.js +114 -11
- package/dist/src/integrations/agent/config.js +292 -0
- package/dist/src/integrations/agent/detect.js +94 -0
- package/dist/src/integrations/agent/index.js +17 -0
- package/dist/src/integrations/agent/profiles.js +65 -0
- package/dist/src/integrations/agent/prompts.js +167 -0
- package/dist/src/integrations/agent/spawn.js +221 -0
- package/dist/{integrations → src/integrations}/lockfile.js +0 -26
- package/dist/{llm → src/llm}/client.js +33 -2
- package/dist/src/llm/feature-gate.js +108 -0
- package/dist/src/llm/graph-extract.js +107 -0
- package/dist/src/llm/index-passes.js +35 -0
- package/dist/src/llm/memory-infer.js +86 -0
- package/dist/{output → src/output}/renderers.js +60 -1
- package/dist/src/output/shapes.js +516 -0
- package/dist/{output → src/output}/text.js +447 -4
- package/dist/{registry → src/registry}/build-index.js +14 -4
- package/dist/{registry → src/registry}/factory.js +0 -8
- package/dist/{registry → src/registry}/providers/static-index.js +3 -2
- package/dist/{registry → src/registry}/resolve.js +68 -2
- package/dist/{setup → src/setup}/setup.js +43 -5
- package/dist/{sources → src/sources}/providers/git.js +7 -15
- package/dist/{wiki → src/wiki}/wiki.js +9 -11
- package/dist/tests/add-website-source.test.js +119 -0
- package/dist/tests/agent/agent-config-loader.test.js +70 -0
- package/dist/tests/agent/agent-config.test.js +221 -0
- package/dist/tests/agent/agent-detect.test.js +100 -0
- package/dist/tests/agent/agent-spawn.test.js +234 -0
- package/dist/tests/agent-output.test.js +186 -0
- package/dist/tests/architecture/agent-no-llm-sdk-guard.test.js +103 -0
- package/dist/tests/architecture/agent-spawn-seam.test.js +193 -0
- package/dist/tests/architecture/llm-stateless-seam.test.js +112 -0
- package/dist/tests/asset-ref.test.js +192 -0
- package/dist/tests/asset-registry.test.js +103 -0
- package/dist/tests/asset-spec.test.js +241 -0
- package/dist/tests/bench/attribution.test.js +995 -0
- package/dist/tests/bench/cleanup-sigint.test.js +83 -0
- package/dist/tests/bench/cleanup.js +203 -0
- package/dist/tests/bench/cleanup.test.js +166 -0
- package/dist/tests/bench/cli.js +683 -0
- package/dist/tests/bench/cli.test.js +177 -0
- package/dist/tests/bench/compare.test.js +556 -0
- package/dist/tests/bench/corpus.js +314 -0
- package/dist/tests/bench/corpus.test.js +258 -0
- package/dist/tests/bench/driver.js +346 -0
- package/dist/tests/bench/driver.test.js +443 -0
- package/dist/tests/bench/evolve-metrics.js +179 -0
- package/dist/tests/bench/evolve-metrics.test.js +187 -0
- package/dist/tests/bench/evolve.js +580 -0
- package/dist/tests/bench/evolve.test.js +616 -0
- package/dist/tests/bench/failure-modes.test.js +300 -0
- package/dist/tests/bench/feedback-integrity.test.js +456 -0
- package/dist/tests/bench/leakage.test.js +125 -0
- package/dist/tests/bench/learning-curve.test.js +133 -0
- package/dist/tests/bench/metrics.js +2319 -0
- package/dist/tests/bench/metrics.test.js +1144 -0
- package/dist/tests/bench/no-os-tmpdir-invariant.test.js +43 -0
- package/dist/tests/bench/report.js +1821 -0
- package/dist/tests/bench/report.test.js +989 -0
- package/dist/tests/bench/runner.js +536 -0
- package/dist/tests/bench/runner.test.js +958 -0
- package/dist/tests/bench/search-bridge.test.js +331 -0
- package/dist/tests/bench/tmp.js +41 -0
- package/dist/tests/bench/trajectory.js +116 -0
- package/dist/tests/bench/trajectory.test.js +127 -0
- package/dist/tests/bench/verifier.js +109 -0
- package/dist/tests/bench/verifier.test.js +118 -0
- package/dist/tests/bench/workflow-evaluator.js +557 -0
- package/dist/tests/bench/workflow-evaluator.test.js +421 -0
- package/dist/tests/bench/workflow-spec.js +358 -0
- package/dist/tests/bench/workflow-spec.test.js +363 -0
- package/dist/tests/bench/workflow-trace.js +438 -0
- package/dist/tests/bench/workflow-trace.test.js +254 -0
- package/dist/tests/benchmark-search-quality.js +536 -0
- package/dist/tests/benchmark-suite.js +1441 -0
- package/dist/tests/capture-cli.test.js +112 -0
- package/dist/tests/cli-errors.test.js +203 -0
- package/dist/tests/commands/events.test.js +370 -0
- package/dist/tests/commands/history.test.js +223 -0
- package/dist/tests/commands/import.test.js +103 -0
- package/dist/tests/commands/proposal-cli.test.js +209 -0
- package/dist/tests/commands/reflect-propose-cli.test.js +333 -0
- package/dist/tests/commands/remember.test.js +97 -0
- package/dist/tests/commands/scope-flags.test.js +300 -0
- package/dist/tests/commands/search.test.js +537 -0
- package/dist/tests/commands/show-indexer-parity.test.js +117 -0
- package/dist/tests/commands/show.test.js +294 -0
- package/dist/tests/common.test.js +266 -0
- package/dist/tests/completions.test.js +142 -0
- package/dist/tests/config-cli.test.js +193 -0
- package/dist/tests/config-llm-features.test.js +139 -0
- package/dist/tests/config.test.js +544 -0
- package/dist/tests/contracts/migration-baseline.test.js +43 -0
- package/dist/tests/contracts/reflect-propose-envelope.test.js +139 -0
- package/dist/tests/contracts/spec-helpers.js +46 -0
- package/dist/tests/contracts/v1-spec-section-11-proposal-queue.test.js +228 -0
- package/dist/tests/contracts/v1-spec-section-12-agent-config.test.js +56 -0
- package/dist/tests/contracts/v1-spec-section-13-lesson-type.test.js +34 -0
- package/dist/tests/contracts/v1-spec-section-14-llm-features.test.js +94 -0
- package/dist/tests/contracts/v1-spec-section-4-1-asset-types.test.js +39 -0
- package/dist/tests/contracts/v1-spec-section-4-2-quality-rules.test.js +44 -0
- package/dist/tests/contracts/v1-spec-section-5-configuration.test.js +47 -0
- package/dist/tests/contracts/v1-spec-section-6-orchestration.test.js +40 -0
- package/dist/tests/contracts/v1-spec-section-7-module-layout.test.js +58 -0
- package/dist/tests/contracts/v1-spec-section-8-extension-points.test.js +34 -0
- package/dist/tests/contracts/v1-spec-section-9-4-cli-surface.test.js +75 -0
- package/dist/tests/contracts/v1-spec-section-9-7-llm-agent-boundary.test.js +36 -0
- package/dist/tests/core/write-source.test.js +366 -0
- package/dist/tests/curate-command.test.js +87 -0
- package/dist/tests/db-scoring.test.js +201 -0
- package/dist/tests/db.test.js +654 -0
- package/dist/tests/distill-cli-flag.test.js +208 -0
- package/dist/tests/distill.test.js +515 -0
- package/dist/tests/docker-install.test.js +120 -0
- package/dist/tests/e2e.test.js +1398 -0
- package/dist/tests/embedder.test.js +340 -0
- package/dist/tests/embedding-model-config.test.js +379 -0
- package/dist/tests/feedback-command.test.js +172 -0
- package/dist/tests/file-context.test.js +552 -0
- package/dist/tests/fixtures/scripts/git/summarize-diff.js +9 -0
- package/dist/tests/fixtures/scripts/lint/eslint-check.js +7 -0
- package/dist/tests/fixtures/stashes/load.js +166 -0
- package/dist/tests/fixtures/stashes/load.test.js +88 -0
- package/dist/tests/fixtures/stashes/ranking-baseline/scripts/mem0-search.js +12 -0
- package/dist/tests/frontmatter.test.js +190 -0
- package/dist/tests/fts-field-weighting.test.js +254 -0
- package/dist/tests/fuzzy-search.test.js +230 -0
- package/dist/tests/git-provider-clone.test.js +45 -0
- package/dist/tests/github.test.js +161 -0
- package/dist/tests/graph-boost-ranking.test.js +305 -0
- package/dist/tests/graph-extraction.test.js +282 -0
- package/dist/tests/helpers/usage-events.js +8 -0
- package/dist/tests/index-pass-llm.test.js +161 -0
- package/dist/tests/indexer.test.js +559 -0
- package/dist/tests/info-command.test.js +166 -0
- package/dist/tests/init.test.js +69 -0
- package/dist/tests/install-script.test.js +246 -0
- package/dist/tests/integration/agent-real-profile.test.js +94 -0
- package/dist/tests/issue-36-repro.test.js +304 -0
- package/dist/tests/issues-191-194.test.js +160 -0
- package/dist/tests/lesson-lint.test.js +111 -0
- package/dist/tests/llm-client.test.js +115 -0
- package/dist/tests/llm-feature-gate.test.js +151 -0
- package/dist/tests/llm.test.js +139 -0
- package/dist/tests/lockfile.test.js +216 -0
- package/dist/tests/manifest.test.js +205 -0
- package/dist/tests/markdown.test.js +126 -0
- package/dist/tests/matchers-unit.test.js +189 -0
- package/dist/tests/memory-inference.test.js +299 -0
- package/dist/tests/merge-scoring.test.js +136 -0
- package/dist/tests/metadata.test.js +313 -0
- package/dist/tests/migration-help.test.js +89 -0
- package/dist/tests/origin-resolve.test.js +124 -0
- package/dist/tests/output-baseline.test.js +217 -0
- package/dist/tests/output-shapes-unit.test.js +476 -0
- package/dist/tests/parallel-search.test.js +272 -0
- package/dist/tests/parameter-metadata.test.js +365 -0
- package/dist/tests/paths.test.js +177 -0
- package/dist/tests/progressive-disclosure.test.js +280 -0
- package/dist/tests/proposals.test.js +279 -0
- package/dist/tests/proposed-quality.test.js +271 -0
- package/dist/tests/provider-registry.test.js +32 -0
- package/dist/tests/ranking-regression.test.js +548 -0
- package/dist/tests/reflect-propose.test.js +455 -0
- package/dist/tests/registry-build-index.test.js +378 -0
- package/dist/tests/registry-cli.test.js +290 -0
- package/dist/tests/registry-index-v2.test.js +430 -0
- package/dist/tests/registry-install.test.js +728 -0
- package/dist/tests/registry-providers/parity.test.js +189 -0
- package/dist/tests/registry-providers/skills-sh.test.js +309 -0
- package/dist/tests/registry-providers/static-index.test.js +204 -0
- package/dist/tests/registry-resolve.test.js +126 -0
- package/dist/tests/registry-search.test.js +723 -0
- package/dist/tests/remember-frontmatter.test.js +380 -0
- package/dist/tests/remember-unit.test.js +123 -0
- package/dist/tests/ripgrep-install.test.js +251 -0
- package/dist/tests/ripgrep-resolve.test.js +108 -0
- package/dist/tests/ripgrep.test.js +163 -0
- package/dist/tests/save-command.test.js +94 -0
- package/dist/tests/save-trust-qa-fixes.test.js +270 -0
- package/dist/tests/scoring-pipeline.test.js +648 -0
- package/dist/tests/search-include-proposed-cli.test.js +118 -0
- package/dist/tests/self-update.test.js +442 -0
- package/dist/tests/semantic-search-e2e.test.js +512 -0
- package/dist/tests/semantic-status.test.js +471 -0
- package/dist/tests/setup-run.integration.js +877 -0
- package/dist/tests/setup-wizard.test.js +198 -0
- package/dist/tests/setup.test.js +131 -0
- package/dist/tests/source-add.test.js +11 -0
- package/dist/tests/source-clone.test.js +254 -0
- package/dist/tests/source-manage.test.js +366 -0
- package/dist/tests/source-providers/filesystem.test.js +82 -0
- package/dist/tests/source-providers/git.test.js +252 -0
- package/dist/tests/source-providers/website.test.js +128 -0
- package/dist/tests/source-qa-fixes.test.js +268 -0
- package/dist/tests/source-registry.test.js +350 -0
- package/dist/tests/source-resolve.test.js +100 -0
- package/dist/tests/source-source.test.js +221 -0
- package/dist/tests/source.test.js +533 -0
- package/dist/tests/tar-utils-scan.test.js +73 -0
- package/dist/tests/toggle-components.test.js +73 -0
- package/dist/tests/usage-telemetry.test.js +265 -0
- package/dist/tests/utility-scoring.test.js +558 -0
- package/dist/tests/vault-load-error.test.js +78 -0
- package/dist/tests/vault-qa-fixes.test.js +194 -0
- package/dist/tests/vault.test.js +429 -0
- package/dist/tests/vector-search.test.js +608 -0
- package/dist/tests/walker.test.js +252 -0
- package/dist/tests/wave2-cluster-bc.test.js +228 -0
- package/dist/tests/wave2-cluster-d.test.js +180 -0
- package/dist/tests/wave2-cluster-e.test.js +179 -0
- package/dist/tests/wiki-qa-fixes.test.js +270 -0
- package/dist/tests/wiki.test.js +529 -0
- package/dist/tests/workflow-cli.test.js +271 -0
- package/dist/tests/workflow-markdown.test.js +171 -0
- package/dist/tests/workflow-path-escape.test.js +132 -0
- package/dist/tests/workflow-qa-fixes.test.js +377 -0
- package/dist/tests/workflows/indexer-rejection.test.js +213 -0
- package/docs/README.md +8 -0
- package/docs/migration/release-notes/0.7.0.md +244 -0
- package/package.json +2 -2
- package/dist/core/warn.js +0 -27
- package/dist/output/shapes.js +0 -212
- /package/dist/{commands → src/commands}/completions.js +0 -0
- /package/dist/{commands → src/commands}/curate.js +0 -0
- /package/dist/{commands → src/commands}/info.js +0 -0
- /package/dist/{commands → src/commands}/init.js +0 -0
- /package/dist/{commands → src/commands}/install-audit.js +0 -0
- /package/dist/{commands → src/commands}/migration-help.js +0 -0
- /package/dist/{commands → src/commands}/source-add.js +0 -0
- /package/dist/{commands → src/commands}/source-clone.js +0 -0
- /package/dist/{commands → src/commands}/source-manage.js +0 -0
- /package/dist/{commands → src/commands}/vault.js +0 -0
- /package/dist/{core → src/core}/asset-registry.js +0 -0
- /package/dist/{core → src/core}/frontmatter.js +0 -0
- /package/dist/{core → src/core}/markdown.js +0 -0
- /package/dist/{core → src/core}/paths.js +0 -0
- /package/dist/{indexer → src/indexer}/manifest.js +0 -0
- /package/dist/{indexer → src/indexer}/matchers.js +0 -0
- /package/dist/{indexer → src/indexer}/search-fields.js +0 -0
- /package/dist/{indexer → src/indexer}/search-source.js +0 -0
- /package/dist/{indexer → src/indexer}/semantic-status.js +0 -0
- /package/dist/{indexer → src/indexer}/usage-events.js +0 -0
- /package/dist/{indexer → src/indexer}/walker.js +0 -0
- /package/dist/{integrations → src/integrations}/github.js +0 -0
- /package/dist/{llm → src/llm}/embedder.js +0 -0
- /package/dist/{llm → src/llm}/embedders/cache.js +0 -0
- /package/dist/{llm → src/llm}/embedders/local.js +0 -0
- /package/dist/{llm → src/llm}/embedders/remote.js +0 -0
- /package/dist/{llm → src/llm}/embedders/types.js +0 -0
- /package/dist/{llm → src/llm}/metadata-enhance.js +0 -0
- /package/dist/{output → src/output}/cli-hints.js +0 -0
- /package/dist/{output → src/output}/context.js +0 -0
- /package/dist/{registry → src/registry}/create-provider-registry.js +0 -0
- /package/dist/{registry → src/registry}/origin-resolve.js +0 -0
- /package/dist/{registry → src/registry}/providers/index.js +0 -0
- /package/dist/{registry → src/registry}/providers/skills-sh.js +0 -0
- /package/dist/{registry → src/registry}/providers/types.js +0 -0
- /package/dist/{registry → src/registry}/types.js +0 -0
- /package/dist/{setup → src/setup}/detect.js +0 -0
- /package/dist/{setup → src/setup}/ripgrep-install.js +0 -0
- /package/dist/{setup → src/setup}/ripgrep-resolve.js +0 -0
- /package/dist/{setup → src/setup}/steps.js +0 -0
- /package/dist/{sources → src/sources}/include.js +0 -0
- /package/dist/{sources → src/sources}/provider-factory.js +0 -0
- /package/dist/{sources → src/sources}/provider.js +0 -0
- /package/dist/{sources → src/sources}/providers/filesystem.js +0 -0
- /package/dist/{sources → src/sources}/providers/index.js +0 -0
- /package/dist/{sources → src/sources}/providers/install-types.js +0 -0
- /package/dist/{sources → src/sources}/providers/npm.js +0 -0
- /package/dist/{sources → src/sources}/providers/provider-utils.js +0 -0
- /package/dist/{sources → src/sources}/providers/sync-from-ref.js +0 -0
- /package/dist/{sources → src/sources}/providers/tar-utils.js +0 -0
- /package/dist/{sources → src/sources}/providers/website.js +0 -0
- /package/dist/{sources → src/sources}/resolve.js +0 -0
- /package/dist/{sources → src/sources}/types.js +0 -0
- /package/dist/{templates → src/templates}/wiki-templates.js +0 -0
- /package/dist/{version.js → src/version.js} +0 -0
- /package/dist/{workflows → src/workflows}/authoring.js +0 -0
- /package/dist/{workflows → src/workflows}/cli.js +0 -0
- /package/dist/{workflows → src/workflows}/db.js +0 -0
- /package/dist/{workflows → src/workflows}/document-cache.js +0 -0
- /package/dist/{workflows → src/workflows}/parser.js +0 -0
- /package/dist/{workflows → src/workflows}/renderer.js +0 -0
- /package/dist/{workflows → src/workflows}/runs.js +0 -0
- /package/dist/{workflows → src/workflows}/schema.js +0 -0
- /package/dist/{workflows → src/workflows}/validator.js +0 -0
|
@@ -0,0 +1,279 @@
|
|
|
1
|
+
import { afterEach, beforeEach, describe, expect, test } from "bun:test";
|
|
2
|
+
import fs from "node:fs";
|
|
3
|
+
import os from "node:os";
|
|
4
|
+
import path from "node:path";
|
|
5
|
+
import { akmProposalAccept, akmProposalDiff, akmProposalList, akmProposalReject, akmProposalShow, } from "../src/commands/proposal";
|
|
6
|
+
import { readEvents } from "../src/core/events";
|
|
7
|
+
import { createProposal, diffProposal, getProposal, listProposals, validateProposal } from "../src/core/proposals";
|
|
8
|
+
// ── Test setup ──────────────────────────────────────────────────────────────
|
|
9
|
+
const tempDirs = [];
|
|
10
|
+
const savedEnv = {
|
|
11
|
+
AKM_STASH_DIR: process.env.AKM_STASH_DIR,
|
|
12
|
+
XDG_CACHE_HOME: process.env.XDG_CACHE_HOME,
|
|
13
|
+
XDG_CONFIG_HOME: process.env.XDG_CONFIG_HOME,
|
|
14
|
+
};
|
|
15
|
+
function makeTempDir(prefix) {
|
|
16
|
+
const dir = fs.mkdtempSync(path.join(os.tmpdir(), prefix));
|
|
17
|
+
tempDirs.push(dir);
|
|
18
|
+
return dir;
|
|
19
|
+
}
|
|
20
|
+
function makeStashDir() {
|
|
21
|
+
const stash = makeTempDir("akm-proposals-stash-");
|
|
22
|
+
// Pre-create the canonical type directories the writer expects.
|
|
23
|
+
for (const dir of ["lessons", "skills", "memories"]) {
|
|
24
|
+
fs.mkdirSync(path.join(stash, dir), { recursive: true });
|
|
25
|
+
}
|
|
26
|
+
return stash;
|
|
27
|
+
}
|
|
28
|
+
function makeConfig(stashDir) {
|
|
29
|
+
return {
|
|
30
|
+
stashDir,
|
|
31
|
+
sources: [{ type: "filesystem", name: "stash", path: stashDir, writable: true }],
|
|
32
|
+
defaultWriteTarget: "stash",
|
|
33
|
+
};
|
|
34
|
+
}
|
|
35
|
+
beforeEach(() => {
|
|
36
|
+
process.env.XDG_CACHE_HOME = makeTempDir("akm-proposals-cache-");
|
|
37
|
+
process.env.XDG_CONFIG_HOME = makeTempDir("akm-proposals-config-");
|
|
38
|
+
});
|
|
39
|
+
afterEach(() => {
|
|
40
|
+
if (savedEnv.AKM_STASH_DIR === undefined)
|
|
41
|
+
delete process.env.AKM_STASH_DIR;
|
|
42
|
+
else
|
|
43
|
+
process.env.AKM_STASH_DIR = savedEnv.AKM_STASH_DIR;
|
|
44
|
+
if (savedEnv.XDG_CACHE_HOME === undefined)
|
|
45
|
+
delete process.env.XDG_CACHE_HOME;
|
|
46
|
+
else
|
|
47
|
+
process.env.XDG_CACHE_HOME = savedEnv.XDG_CACHE_HOME;
|
|
48
|
+
if (savedEnv.XDG_CONFIG_HOME === undefined)
|
|
49
|
+
delete process.env.XDG_CONFIG_HOME;
|
|
50
|
+
else
|
|
51
|
+
process.env.XDG_CONFIG_HOME = savedEnv.XDG_CONFIG_HOME;
|
|
52
|
+
for (const dir of tempDirs.splice(0)) {
|
|
53
|
+
fs.rmSync(dir, { recursive: true, force: true });
|
|
54
|
+
}
|
|
55
|
+
});
|
|
56
|
+
// ── Tests ───────────────────────────────────────────────────────────────────
|
|
57
|
+
const VALID_LESSON = `---\ndescription: Use ripgrep before grep\nwhen_to_use: Searching large repos for patterns\n---\n\nPrefer rg over grep when scanning large code repos.\n`;
|
|
58
|
+
describe("createProposal / listProposals / getProposal", () => {
|
|
59
|
+
test("round-trip: create → list → show → accept materialises asset and emits promoted event", async () => {
|
|
60
|
+
const stash = makeStashDir();
|
|
61
|
+
const config = makeConfig(stash);
|
|
62
|
+
const created = createProposal(stash, {
|
|
63
|
+
ref: "lesson:rg-over-grep",
|
|
64
|
+
source: "distill",
|
|
65
|
+
sourceRun: "run-123",
|
|
66
|
+
payload: { content: VALID_LESSON },
|
|
67
|
+
});
|
|
68
|
+
expect(created.id).toBeDefined();
|
|
69
|
+
expect(created.status).toBe("pending");
|
|
70
|
+
// list
|
|
71
|
+
const listResult = akmProposalList({ stashDir: stash });
|
|
72
|
+
expect(listResult.totalCount).toBe(1);
|
|
73
|
+
expect(listResult.proposals[0]?.id).toBe(created.id);
|
|
74
|
+
// show
|
|
75
|
+
const showResult = akmProposalShow({ stashDir: stash, id: created.id });
|
|
76
|
+
expect(showResult.proposal.ref).toBe("lesson:rg-over-grep");
|
|
77
|
+
expect(showResult.validation.ok).toBe(true);
|
|
78
|
+
// accept
|
|
79
|
+
const acceptResult = await akmProposalAccept({ stashDir: stash, id: created.id, config });
|
|
80
|
+
expect(acceptResult.ok).toBe(true);
|
|
81
|
+
expect(acceptResult.ref).toBe("lesson:rg-over-grep");
|
|
82
|
+
expect(fs.existsSync(acceptResult.assetPath)).toBe(true);
|
|
83
|
+
expect(fs.readFileSync(acceptResult.assetPath, "utf8")).toContain("Prefer rg over grep");
|
|
84
|
+
// status promoted
|
|
85
|
+
const promoted = getProposal(stash, created.id);
|
|
86
|
+
expect(promoted.status).toBe("accepted");
|
|
87
|
+
expect(promoted.review?.outcome).toBe("accepted");
|
|
88
|
+
// promoted event emitted
|
|
89
|
+
const events = readEvents({ type: "promoted" });
|
|
90
|
+
expect(events.events.length).toBe(1);
|
|
91
|
+
expect(events.events[0]?.ref).toBe("lesson:rg-over-grep");
|
|
92
|
+
expect(events.events[0]?.metadata?.proposalId).toBe(created.id);
|
|
93
|
+
});
|
|
94
|
+
test("reject path: archive contains entry, status rejected, rejected event emitted", () => {
|
|
95
|
+
const stash = makeStashDir();
|
|
96
|
+
const created = createProposal(stash, {
|
|
97
|
+
ref: "lesson:bad-idea",
|
|
98
|
+
source: "reflect",
|
|
99
|
+
payload: { content: VALID_LESSON },
|
|
100
|
+
});
|
|
101
|
+
const result = akmProposalReject({ stashDir: stash, id: created.id, reason: "duplicate of existing lesson" });
|
|
102
|
+
expect(result.ok).toBe(true);
|
|
103
|
+
expect(result.proposal.status).toBe("rejected");
|
|
104
|
+
expect(result.proposal.review?.reason).toBe("duplicate of existing lesson");
|
|
105
|
+
// archive directory contains it
|
|
106
|
+
const archivePath = path.join(stash, ".akm", "proposals", "archive", created.id, "proposal.json");
|
|
107
|
+
expect(fs.existsSync(archivePath)).toBe(true);
|
|
108
|
+
// live queue empty
|
|
109
|
+
const live = listProposals(stash);
|
|
110
|
+
expect(live).toHaveLength(0);
|
|
111
|
+
// rejected event
|
|
112
|
+
const events = readEvents({ type: "rejected" });
|
|
113
|
+
expect(events.events.length).toBe(1);
|
|
114
|
+
expect(events.events[0]?.metadata?.reason).toBe("duplicate of existing lesson");
|
|
115
|
+
});
|
|
116
|
+
test("multiple proposals for same ref: distinct ids, no path collision", () => {
|
|
117
|
+
const stash = makeStashDir();
|
|
118
|
+
const a = createProposal(stash, { ref: "lesson:dup", source: "reflect", payload: { content: VALID_LESSON } });
|
|
119
|
+
const b = createProposal(stash, { ref: "lesson:dup", source: "distill", payload: { content: VALID_LESSON } });
|
|
120
|
+
expect(a.id).not.toBe(b.id);
|
|
121
|
+
const list = listProposals(stash);
|
|
122
|
+
expect(list.length).toBe(2);
|
|
123
|
+
const ids = list.map((p) => p.id).sort();
|
|
124
|
+
expect(ids).toEqual([a.id, b.id].sort());
|
|
125
|
+
});
|
|
126
|
+
});
|
|
127
|
+
describe("diff path", () => {
|
|
128
|
+
test("new asset: shows new-asset diff with /dev/null marker", () => {
|
|
129
|
+
const stash = makeStashDir();
|
|
130
|
+
const config = makeConfig(stash);
|
|
131
|
+
const proposal = createProposal(stash, {
|
|
132
|
+
ref: "lesson:fresh",
|
|
133
|
+
source: "reflect",
|
|
134
|
+
payload: { content: VALID_LESSON },
|
|
135
|
+
});
|
|
136
|
+
const diff = diffProposal(stash, config, proposal.id);
|
|
137
|
+
expect(diff.isNew).toBe(true);
|
|
138
|
+
expect(diff.unified).toContain("/dev/null");
|
|
139
|
+
expect(diff.unified).toContain("Prefer rg over grep");
|
|
140
|
+
});
|
|
141
|
+
test("existing asset + proposal: produces unified diff", async () => {
|
|
142
|
+
const stash = makeStashDir();
|
|
143
|
+
const config = makeConfig(stash);
|
|
144
|
+
// Pre-write an existing lesson so the diff has a left-hand side.
|
|
145
|
+
const lessonPath = path.join(stash, "lessons", "rg-over-grep.md");
|
|
146
|
+
fs.writeFileSync(lessonPath, `---\ndescription: Use ripgrep before grep\nwhen_to_use: Searching repos\n---\n\nOriginal body.\n`, "utf8");
|
|
147
|
+
const proposal = createProposal(stash, {
|
|
148
|
+
ref: "lesson:rg-over-grep",
|
|
149
|
+
source: "reflect",
|
|
150
|
+
payload: { content: VALID_LESSON },
|
|
151
|
+
});
|
|
152
|
+
const diffResult = akmProposalDiff({ stashDir: stash, id: proposal.id, config });
|
|
153
|
+
expect(diffResult.isNew).toBe(false);
|
|
154
|
+
expect(diffResult.unified).toContain("---");
|
|
155
|
+
expect(diffResult.unified).toContain("+++");
|
|
156
|
+
expect(diffResult.unified).toContain("Prefer rg over grep");
|
|
157
|
+
});
|
|
158
|
+
});
|
|
159
|
+
describe("validation failure", () => {
|
|
160
|
+
test("invalid lesson frontmatter → accept fails non-zero with clear error", async () => {
|
|
161
|
+
const stash = makeStashDir();
|
|
162
|
+
const config = makeConfig(stash);
|
|
163
|
+
const proposal = createProposal(stash, {
|
|
164
|
+
ref: "lesson:no-fields",
|
|
165
|
+
source: "distill",
|
|
166
|
+
payload: { content: `---\ndescription: ""\nwhen_to_use: ""\n---\n\nbody\n` },
|
|
167
|
+
});
|
|
168
|
+
const report = validateProposal(proposal);
|
|
169
|
+
expect(report.ok).toBe(false);
|
|
170
|
+
expect(report.findings.length).toBeGreaterThan(0);
|
|
171
|
+
let threw = false;
|
|
172
|
+
try {
|
|
173
|
+
await akmProposalAccept({ stashDir: stash, id: proposal.id, config });
|
|
174
|
+
}
|
|
175
|
+
catch (err) {
|
|
176
|
+
threw = true;
|
|
177
|
+
expect(err.message).toContain("validation");
|
|
178
|
+
}
|
|
179
|
+
expect(threw).toBe(true);
|
|
180
|
+
// Proposal still pending; no asset materialised
|
|
181
|
+
const stillPending = getProposal(stash, proposal.id);
|
|
182
|
+
expect(stillPending.status).toBe("pending");
|
|
183
|
+
expect(fs.existsSync(path.join(stash, "lessons", "no-fields.md"))).toBe(false);
|
|
184
|
+
});
|
|
185
|
+
test("empty content → validation fails", () => {
|
|
186
|
+
const stash = makeStashDir();
|
|
187
|
+
const proposal = createProposal(stash, {
|
|
188
|
+
ref: "lesson:empty",
|
|
189
|
+
source: "distill",
|
|
190
|
+
payload: { content: "" },
|
|
191
|
+
});
|
|
192
|
+
const report = validateProposal(proposal);
|
|
193
|
+
expect(report.ok).toBe(false);
|
|
194
|
+
expect(report.findings.some((f) => f.kind === "empty-content")).toBe(true);
|
|
195
|
+
});
|
|
196
|
+
});
|
|
197
|
+
// ── #284 GAP-HIGH backfill ───────────────────────────────────────────────────
|
|
198
|
+
describe("akmProposalReject — non-pending status (#284 HIGH 4)", () => {
|
|
199
|
+
test("rejecting an already-archived proposal → UsageError with .code INVALID_FLAG_VALUE", async () => {
|
|
200
|
+
const stash = makeStashDir();
|
|
201
|
+
const created = createProposal(stash, {
|
|
202
|
+
ref: "lesson:once",
|
|
203
|
+
source: "reflect",
|
|
204
|
+
payload: { content: VALID_LESSON },
|
|
205
|
+
});
|
|
206
|
+
// First reject moves it to the archive.
|
|
207
|
+
akmProposalReject({ stashDir: stash, id: created.id });
|
|
208
|
+
// Second reject must fail with a typed UsageError (.code load-bearing).
|
|
209
|
+
let thrown;
|
|
210
|
+
try {
|
|
211
|
+
akmProposalReject({ stashDir: stash, id: created.id });
|
|
212
|
+
}
|
|
213
|
+
catch (err) {
|
|
214
|
+
thrown = err;
|
|
215
|
+
}
|
|
216
|
+
expect(thrown).toBeInstanceOf(Error);
|
|
217
|
+
const e = thrown;
|
|
218
|
+
expect(e.name).toBe("UsageError");
|
|
219
|
+
expect(e.code).toBe("INVALID_FLAG_VALUE");
|
|
220
|
+
expect(e.message).toMatch(/not pending|already/i);
|
|
221
|
+
});
|
|
222
|
+
});
|
|
223
|
+
describe("akmProposalShow / akmProposalDiff — missing id (#284 HIGH 5)", () => {
|
|
224
|
+
test("akmProposalShow on missing id → NotFoundError with .code FILE_NOT_FOUND", () => {
|
|
225
|
+
const stash = makeStashDir();
|
|
226
|
+
let thrown;
|
|
227
|
+
try {
|
|
228
|
+
akmProposalShow({ stashDir: stash, id: "deadbeef-0000-0000-0000-000000000000" });
|
|
229
|
+
}
|
|
230
|
+
catch (err) {
|
|
231
|
+
thrown = err;
|
|
232
|
+
}
|
|
233
|
+
expect(thrown).toBeInstanceOf(Error);
|
|
234
|
+
const e = thrown;
|
|
235
|
+
expect(e.name).toBe("NotFoundError");
|
|
236
|
+
expect(e.code).toBe("FILE_NOT_FOUND");
|
|
237
|
+
});
|
|
238
|
+
test("akmProposalDiff on missing id → NotFoundError with .code FILE_NOT_FOUND", () => {
|
|
239
|
+
const stash = makeStashDir();
|
|
240
|
+
const config = makeConfig(stash);
|
|
241
|
+
let thrown;
|
|
242
|
+
try {
|
|
243
|
+
akmProposalDiff({ stashDir: stash, id: "deadbeef-0000-0000-0000-000000000001", config });
|
|
244
|
+
}
|
|
245
|
+
catch (err) {
|
|
246
|
+
thrown = err;
|
|
247
|
+
}
|
|
248
|
+
expect(thrown).toBeInstanceOf(Error);
|
|
249
|
+
const e = thrown;
|
|
250
|
+
expect(e.name).toBe("NotFoundError");
|
|
251
|
+
expect(e.code).toBe("FILE_NOT_FOUND");
|
|
252
|
+
});
|
|
253
|
+
});
|
|
254
|
+
describe("akmProposalAccept — validation failure (#284 HIGH 6)", () => {
|
|
255
|
+
test("validation failure → no `promoted` event emitted; proposal stays pending", async () => {
|
|
256
|
+
const stash = makeStashDir();
|
|
257
|
+
const config = makeConfig(stash);
|
|
258
|
+
// Empty content — fails the lesson lint.
|
|
259
|
+
const proposal = createProposal(stash, {
|
|
260
|
+
ref: "lesson:invalid",
|
|
261
|
+
source: "distill",
|
|
262
|
+
payload: { content: "" },
|
|
263
|
+
});
|
|
264
|
+
let threw = false;
|
|
265
|
+
try {
|
|
266
|
+
await akmProposalAccept({ stashDir: stash, id: proposal.id, config });
|
|
267
|
+
}
|
|
268
|
+
catch {
|
|
269
|
+
threw = true;
|
|
270
|
+
}
|
|
271
|
+
expect(threw).toBe(true);
|
|
272
|
+
// Critical: `promoted` event must NOT be emitted on validation failure.
|
|
273
|
+
const promoted = readEvents({ type: "promoted" });
|
|
274
|
+
expect(promoted.events.length).toBe(0);
|
|
275
|
+
// And the proposal stays pending.
|
|
276
|
+
const stillPending = getProposal(stash, proposal.id);
|
|
277
|
+
expect(stillPending.status).toBe("pending");
|
|
278
|
+
});
|
|
279
|
+
});
|
|
@@ -0,0 +1,271 @@
|
|
|
1
|
+
/**
|
|
2
|
+
* Issue #224: `quality: "proposed"` is excluded from default search.
|
|
3
|
+
*
|
|
4
|
+
* Covers:
|
|
5
|
+
* - default search excludes `proposed` entries
|
|
6
|
+
* - `--include-proposed` (i.e. `akmSearch({ includeProposed: true })`) restores them
|
|
7
|
+
* - `generated` and `curated` remain on by default
|
|
8
|
+
* - unknown quality values warn once and remain searchable
|
|
9
|
+
* - SearchHit projection surfaces optional `quality` when present
|
|
10
|
+
*
|
|
11
|
+
* Mirrors the harness in `tests/parallel-search.test.ts` and
|
|
12
|
+
* `tests/issue-36-repro.test.ts`.
|
|
13
|
+
*/
|
|
14
|
+
import { afterAll, afterEach, beforeEach, describe, expect, test } from "bun:test";
|
|
15
|
+
import fs from "node:fs";
|
|
16
|
+
import os from "node:os";
|
|
17
|
+
import path from "node:path";
|
|
18
|
+
import { akmSearch } from "../src/commands/search";
|
|
19
|
+
import { saveConfig } from "../src/core/config";
|
|
20
|
+
import { akmIndex } from "../src/indexer/indexer";
|
|
21
|
+
import { _resetUnknownQualityWarnings, isProposedQuality, validateStashEntry } from "../src/indexer/metadata";
|
|
22
|
+
// ── Temp directory tracking ─────────────────────────────────────────────────
|
|
23
|
+
const createdTmpDirs = [];
|
|
24
|
+
function createTmpDir(prefix = "akm-issue224-") {
|
|
25
|
+
const dir = fs.mkdtempSync(path.join(os.tmpdir(), prefix));
|
|
26
|
+
createdTmpDirs.push(dir);
|
|
27
|
+
return dir;
|
|
28
|
+
}
|
|
29
|
+
afterAll(() => {
|
|
30
|
+
for (const dir of createdTmpDirs) {
|
|
31
|
+
fs.rmSync(dir, { recursive: true, force: true });
|
|
32
|
+
}
|
|
33
|
+
});
|
|
34
|
+
function writeFile(filePath, content = "") {
|
|
35
|
+
fs.mkdirSync(path.dirname(filePath), { recursive: true });
|
|
36
|
+
fs.writeFileSync(filePath, content);
|
|
37
|
+
}
|
|
38
|
+
function tmpStash() {
|
|
39
|
+
const dir = createTmpDir("akm-issue224-stash-");
|
|
40
|
+
for (const sub of ["skills", "commands", "agents", "knowledge", "scripts"]) {
|
|
41
|
+
fs.mkdirSync(path.join(dir, sub), { recursive: true });
|
|
42
|
+
}
|
|
43
|
+
return dir;
|
|
44
|
+
}
|
|
45
|
+
async function buildTestIndex(stashDir) {
|
|
46
|
+
process.env.AKM_STASH_DIR = stashDir;
|
|
47
|
+
saveConfig({ semanticSearchMode: "off" });
|
|
48
|
+
return akmIndex({ stashDir, full: true });
|
|
49
|
+
}
|
|
50
|
+
// ── Environment isolation ───────────────────────────────────────────────────
|
|
51
|
+
const originalXdgCacheHome = process.env.XDG_CACHE_HOME;
|
|
52
|
+
const originalXdgConfigHome = process.env.XDG_CONFIG_HOME;
|
|
53
|
+
const originalAkmStashDir = process.env.AKM_STASH_DIR;
|
|
54
|
+
let testCacheDir = "";
|
|
55
|
+
let testConfigDir = "";
|
|
56
|
+
beforeEach(() => {
|
|
57
|
+
testCacheDir = createTmpDir("akm-issue224-cache-");
|
|
58
|
+
testConfigDir = createTmpDir("akm-issue224-config-");
|
|
59
|
+
process.env.XDG_CACHE_HOME = testCacheDir;
|
|
60
|
+
process.env.XDG_CONFIG_HOME = testConfigDir;
|
|
61
|
+
_resetUnknownQualityWarnings();
|
|
62
|
+
});
|
|
63
|
+
afterEach(() => {
|
|
64
|
+
if (originalXdgCacheHome === undefined) {
|
|
65
|
+
delete process.env.XDG_CACHE_HOME;
|
|
66
|
+
}
|
|
67
|
+
else {
|
|
68
|
+
process.env.XDG_CACHE_HOME = originalXdgCacheHome;
|
|
69
|
+
}
|
|
70
|
+
if (originalXdgConfigHome === undefined) {
|
|
71
|
+
delete process.env.XDG_CONFIG_HOME;
|
|
72
|
+
}
|
|
73
|
+
else {
|
|
74
|
+
process.env.XDG_CONFIG_HOME = originalXdgConfigHome;
|
|
75
|
+
}
|
|
76
|
+
if (originalAkmStashDir === undefined) {
|
|
77
|
+
delete process.env.AKM_STASH_DIR;
|
|
78
|
+
}
|
|
79
|
+
else {
|
|
80
|
+
process.env.AKM_STASH_DIR = originalAkmStashDir;
|
|
81
|
+
}
|
|
82
|
+
if (testCacheDir) {
|
|
83
|
+
fs.rmSync(testCacheDir, { recursive: true, force: true });
|
|
84
|
+
testCacheDir = "";
|
|
85
|
+
}
|
|
86
|
+
if (testConfigDir) {
|
|
87
|
+
fs.rmSync(testConfigDir, { recursive: true, force: true });
|
|
88
|
+
testConfigDir = "";
|
|
89
|
+
}
|
|
90
|
+
});
|
|
91
|
+
// ── Helpers ─────────────────────────────────────────────────────────────────
|
|
92
|
+
/**
|
|
93
|
+
* Author three skills with deliberately distinct quality markers under the
|
|
94
|
+
* same query token so default-vs-include-proposed deltas are obvious.
|
|
95
|
+
*/
|
|
96
|
+
function seedQualitySpread(stashDir) {
|
|
97
|
+
// Curated entry
|
|
98
|
+
writeFile(path.join(stashDir, "skills", "deploy-curated", "SKILL.md"), "---\ndescription: Curated deploy skill\n---\n# Deploy curated\n");
|
|
99
|
+
writeFile(path.join(stashDir, "skills", "deploy-curated", ".stash.json"), JSON.stringify({
|
|
100
|
+
entries: [
|
|
101
|
+
{
|
|
102
|
+
name: "deploy-curated",
|
|
103
|
+
type: "skill",
|
|
104
|
+
description: "Curated deploy skill",
|
|
105
|
+
tags: ["deploy"],
|
|
106
|
+
filename: "SKILL.md",
|
|
107
|
+
quality: "curated",
|
|
108
|
+
},
|
|
109
|
+
],
|
|
110
|
+
}));
|
|
111
|
+
// Generated entry
|
|
112
|
+
writeFile(path.join(stashDir, "skills", "deploy-generated", "SKILL.md"), "---\ndescription: Generated deploy skill\n---\n# Deploy generated\n");
|
|
113
|
+
writeFile(path.join(stashDir, "skills", "deploy-generated", ".stash.json"), JSON.stringify({
|
|
114
|
+
entries: [
|
|
115
|
+
{
|
|
116
|
+
name: "deploy-generated",
|
|
117
|
+
type: "skill",
|
|
118
|
+
description: "Generated deploy skill",
|
|
119
|
+
tags: ["deploy"],
|
|
120
|
+
filename: "SKILL.md",
|
|
121
|
+
quality: "generated",
|
|
122
|
+
},
|
|
123
|
+
],
|
|
124
|
+
}));
|
|
125
|
+
// Proposed entry — should be filtered by default
|
|
126
|
+
writeFile(path.join(stashDir, "skills", "deploy-proposed", "SKILL.md"), "---\ndescription: Proposed deploy skill\n---\n# Deploy proposed\n");
|
|
127
|
+
writeFile(path.join(stashDir, "skills", "deploy-proposed", ".stash.json"), JSON.stringify({
|
|
128
|
+
entries: [
|
|
129
|
+
{
|
|
130
|
+
name: "deploy-proposed",
|
|
131
|
+
type: "skill",
|
|
132
|
+
description: "Proposed deploy skill",
|
|
133
|
+
tags: ["deploy"],
|
|
134
|
+
filename: "SKILL.md",
|
|
135
|
+
quality: "proposed",
|
|
136
|
+
},
|
|
137
|
+
],
|
|
138
|
+
}));
|
|
139
|
+
}
|
|
140
|
+
// ── Tests ───────────────────────────────────────────────────────────────────
|
|
141
|
+
describe("Issue #224: proposed quality is excluded from default search", () => {
|
|
142
|
+
test("default search returns curated + generated, excludes proposed", async () => {
|
|
143
|
+
const stashDir = tmpStash();
|
|
144
|
+
seedQualitySpread(stashDir);
|
|
145
|
+
await buildTestIndex(stashDir);
|
|
146
|
+
const result = await akmSearch({ query: "deploy", source: "stash" });
|
|
147
|
+
const hits = result.hits.filter((h) => h.type !== "registry");
|
|
148
|
+
const names = hits.map((h) => h.name);
|
|
149
|
+
expect(names).toContain("deploy-curated");
|
|
150
|
+
expect(names).toContain("deploy-generated");
|
|
151
|
+
expect(names).not.toContain("deploy-proposed");
|
|
152
|
+
});
|
|
153
|
+
test("--include-proposed surfaces proposed entries alongside the rest", async () => {
|
|
154
|
+
const stashDir = tmpStash();
|
|
155
|
+
seedQualitySpread(stashDir);
|
|
156
|
+
await buildTestIndex(stashDir);
|
|
157
|
+
const result = await akmSearch({ query: "deploy", source: "stash", includeProposed: true });
|
|
158
|
+
const hits = result.hits.filter((h) => h.type !== "registry");
|
|
159
|
+
const names = hits.map((h) => h.name);
|
|
160
|
+
expect(names).toContain("deploy-curated");
|
|
161
|
+
expect(names).toContain("deploy-generated");
|
|
162
|
+
expect(names).toContain("deploy-proposed");
|
|
163
|
+
});
|
|
164
|
+
test("empty-query enumeration also excludes proposed by default", async () => {
|
|
165
|
+
const stashDir = tmpStash();
|
|
166
|
+
seedQualitySpread(stashDir);
|
|
167
|
+
await buildTestIndex(stashDir);
|
|
168
|
+
// Empty query path goes through getAllEntries — exercise that code path too.
|
|
169
|
+
const result = await akmSearch({ query: ".", source: "stash", limit: 50 });
|
|
170
|
+
const hits = result.hits.filter((h) => h.type !== "registry");
|
|
171
|
+
const names = hits.map((h) => h.name);
|
|
172
|
+
expect(names).toContain("deploy-curated");
|
|
173
|
+
expect(names).toContain("deploy-generated");
|
|
174
|
+
expect(names).not.toContain("deploy-proposed");
|
|
175
|
+
const opted = await akmSearch({ query: ".", source: "stash", limit: 50, includeProposed: true });
|
|
176
|
+
const optedNames = opted.hits.filter((h) => h.type !== "registry").map((h) => h.name);
|
|
177
|
+
expect(optedNames).toContain("deploy-proposed");
|
|
178
|
+
});
|
|
179
|
+
});
|
|
180
|
+
describe("Issue #224: SearchHit surfaces optional quality field", () => {
|
|
181
|
+
test("hits carry quality verbatim when present, omit it otherwise", async () => {
|
|
182
|
+
const stashDir = tmpStash();
|
|
183
|
+
seedQualitySpread(stashDir);
|
|
184
|
+
await buildTestIndex(stashDir);
|
|
185
|
+
const result = await akmSearch({ query: "deploy", source: "stash", includeProposed: true });
|
|
186
|
+
const hits = result.hits.filter((h) => h.type !== "registry");
|
|
187
|
+
const curated = hits.find((h) => h.name === "deploy-curated");
|
|
188
|
+
const generated = hits.find((h) => h.name === "deploy-generated");
|
|
189
|
+
const proposed = hits.find((h) => h.name === "deploy-proposed");
|
|
190
|
+
expect(curated?.quality).toBe("curated");
|
|
191
|
+
expect(generated?.quality).toBe("generated");
|
|
192
|
+
expect(proposed?.quality).toBe("proposed");
|
|
193
|
+
});
|
|
194
|
+
});
|
|
195
|
+
describe("Issue #224: unknown quality values warn once and remain searchable", () => {
|
|
196
|
+
test("validateStashEntry preserves unknown quality and warns once per value", () => {
|
|
197
|
+
const calls = [];
|
|
198
|
+
const originalWarn = console.warn;
|
|
199
|
+
console.warn = (...args) => {
|
|
200
|
+
calls.push(args.map(String).join(" "));
|
|
201
|
+
};
|
|
202
|
+
try {
|
|
203
|
+
_resetUnknownQualityWarnings();
|
|
204
|
+
const a = validateStashEntry({ name: "a", type: "skill", quality: "experimental" });
|
|
205
|
+
const b = validateStashEntry({ name: "b", type: "skill", quality: "experimental" });
|
|
206
|
+
const c = validateStashEntry({ name: "c", type: "skill", quality: "draft" });
|
|
207
|
+
expect(a?.quality).toBe("experimental");
|
|
208
|
+
expect(b?.quality).toBe("experimental");
|
|
209
|
+
expect(c?.quality).toBe("draft");
|
|
210
|
+
// One warn per unique unknown value — not per occurrence.
|
|
211
|
+
const unknownWarns = calls.filter((c) => c.includes("unknown quality value"));
|
|
212
|
+
expect(unknownWarns.length).toBe(2);
|
|
213
|
+
expect(unknownWarns.some((m) => m.includes("experimental"))).toBe(true);
|
|
214
|
+
expect(unknownWarns.some((m) => m.includes("draft"))).toBe(true);
|
|
215
|
+
// Known values must not warn.
|
|
216
|
+
const known = validateStashEntry({ name: "d", type: "skill", quality: "curated" });
|
|
217
|
+
expect(known?.quality).toBe("curated");
|
|
218
|
+
const knownGen = validateStashEntry({ name: "e", type: "skill", quality: "generated" });
|
|
219
|
+
expect(knownGen?.quality).toBe("generated");
|
|
220
|
+
const knownProp = validateStashEntry({ name: "f", type: "skill", quality: "proposed" });
|
|
221
|
+
expect(knownProp?.quality).toBe("proposed");
|
|
222
|
+
const stillTwo = calls.filter((c) => c.includes("unknown quality value")).length;
|
|
223
|
+
expect(stillTwo).toBe(2);
|
|
224
|
+
}
|
|
225
|
+
finally {
|
|
226
|
+
console.warn = originalWarn;
|
|
227
|
+
}
|
|
228
|
+
});
|
|
229
|
+
test("unknown quality entries remain in default search (treated as included-by-default)", async () => {
|
|
230
|
+
const stashDir = tmpStash();
|
|
231
|
+
writeFile(path.join(stashDir, "skills", "deploy-experimental", "SKILL.md"), "---\ndescription: Experimental quality marker test\n---\n# deploy\n");
|
|
232
|
+
writeFile(path.join(stashDir, "skills", "deploy-experimental", ".stash.json"), JSON.stringify({
|
|
233
|
+
entries: [
|
|
234
|
+
{
|
|
235
|
+
name: "deploy-experimental",
|
|
236
|
+
type: "skill",
|
|
237
|
+
description: "Experimental quality marker test",
|
|
238
|
+
tags: ["deploy"],
|
|
239
|
+
filename: "SKILL.md",
|
|
240
|
+
quality: "experimental",
|
|
241
|
+
},
|
|
242
|
+
],
|
|
243
|
+
}));
|
|
244
|
+
// Suppress warns from the indexer load path so they don't pollute test output.
|
|
245
|
+
const originalWarn = console.warn;
|
|
246
|
+
console.warn = () => { };
|
|
247
|
+
try {
|
|
248
|
+
await buildTestIndex(stashDir);
|
|
249
|
+
const result = await akmSearch({ query: "deploy", source: "stash" });
|
|
250
|
+
const hits = result.hits.filter((h) => h.type !== "registry");
|
|
251
|
+
const names = hits.map((h) => h.name);
|
|
252
|
+
expect(names).toContain("deploy-experimental");
|
|
253
|
+
// Quality field is surfaced verbatim on the hit.
|
|
254
|
+
const experimental = hits.find((h) => h.name === "deploy-experimental");
|
|
255
|
+
expect(experimental?.quality).toBe("experimental");
|
|
256
|
+
}
|
|
257
|
+
finally {
|
|
258
|
+
console.warn = originalWarn;
|
|
259
|
+
}
|
|
260
|
+
});
|
|
261
|
+
});
|
|
262
|
+
describe("Issue #224: isProposedQuality helper", () => {
|
|
263
|
+
test("returns true only for the literal 'proposed' marker", () => {
|
|
264
|
+
expect(isProposedQuality("proposed")).toBe(true);
|
|
265
|
+
expect(isProposedQuality("curated")).toBe(false);
|
|
266
|
+
expect(isProposedQuality("generated")).toBe(false);
|
|
267
|
+
expect(isProposedQuality(undefined)).toBe(false);
|
|
268
|
+
expect(isProposedQuality("PROPOSED")).toBe(false);
|
|
269
|
+
expect(isProposedQuality("experimental")).toBe(false);
|
|
270
|
+
});
|
|
271
|
+
});
|
|
@@ -0,0 +1,32 @@
|
|
|
1
|
+
import { describe, expect, test } from "bun:test";
|
|
2
|
+
import { registerProvider, resolveProviderFactory } from "../src/registry/factory";
|
|
3
|
+
import { resolveSourceProviderFactory } from "../src/sources/provider-factory";
|
|
4
|
+
describe("provider-registry", () => {
|
|
5
|
+
test("resolveProviderFactory returns null for unknown type", () => {
|
|
6
|
+
expect(resolveProviderFactory("nonexistent-provider-xyz")).toBeNull();
|
|
7
|
+
});
|
|
8
|
+
test("registerProvider + resolveProviderFactory round-trips", () => {
|
|
9
|
+
const factory = (() => ({
|
|
10
|
+
type: "test-provider",
|
|
11
|
+
search: async () => ({ hits: [] }),
|
|
12
|
+
searchKits: async () => [],
|
|
13
|
+
getKit: async () => null,
|
|
14
|
+
canHandle: () => false,
|
|
15
|
+
}));
|
|
16
|
+
registerProvider("test-roundtrip", factory);
|
|
17
|
+
expect(resolveProviderFactory("test-roundtrip")).toBe(factory);
|
|
18
|
+
});
|
|
19
|
+
test("static-index is registered after import", async () => {
|
|
20
|
+
// Importing triggers self-registration
|
|
21
|
+
await import("../src/registry/providers/static-index");
|
|
22
|
+
expect(resolveProviderFactory("static-index")).not.toBeNull();
|
|
23
|
+
});
|
|
24
|
+
test("skills-sh is registered after import", async () => {
|
|
25
|
+
await import("../src/registry/providers/skills-sh");
|
|
26
|
+
expect(resolveProviderFactory("skills-sh")).not.toBeNull();
|
|
27
|
+
});
|
|
28
|
+
test("filesystem stash provider is registered after import", async () => {
|
|
29
|
+
await import("../src/sources/providers/filesystem");
|
|
30
|
+
expect(resolveSourceProviderFactory("filesystem")).not.toBeNull();
|
|
31
|
+
});
|
|
32
|
+
});
|