aiwcli 0.15.5 → 0.17.0

package/dist/templates/cc-native/_cc-native/{plan-review/lib → lib-ts}/reviewers/providers/orchestrator-claude-agent.ts

@@ -1,225 +1,196 @@
-/**
- * Orchestrator agent implementation using BaseCliAgent framework.
- * Analyzes plan complexity and selects reviewer agents via Claude CLI.
- */
-
-import { buildCliInvocation, reviewSpec, type CliProvider } from "../../../../../_shared/lib-ts/base/cli-args.js";
-import type { ExecutionBackend } from "../../../../../_shared/lib-ts/agent-exec/execution-backend.js";
-import type { ExecutionResult } from "../../../../../_shared/lib-ts/agent-exec/execution-backend.js";
-import { parseStructuredOutput } from "../../../../../_shared/lib-ts/agent-exec/structured-output.js";
-import { logDebug } from "../../../../../_shared/lib-ts/base/logger.js";
-import { debugLog, debugRaw } from "../../../../lib-ts/debug.js";
-import type { AgentConfig, AgentReviewSettings, AgentSelectionConfig, OrchestratorResult, ComplexityCategory } from "../../../../lib-ts/types.js";
-import { BaseCliAgent } from "../base/base-agent.js";
-import { buildOrchestratorSchema, ORCHESTRATOR_SCHEMA } from "../schemas.js";
-
-// ---------------------------------------------------------------------------
-// Constants
-// ---------------------------------------------------------------------------
-
-const DEFAULT_COMPLEXITY_CATEGORIES = [
-  "code",
-  "infrastructure",
-  "documentation",
-  "life",
-  "business",
-  "design",
-  "research",
-];
-
-const DEFAULT_AGENT_SELECTION: AgentSelectionConfig = {
-  simple: { min: 3, max: 3 },
-  medium: { min: 8, max: 8 },
-  high: { min: 12, max: 12 },
-  fallbackCount: 3,
-};
-
-/**
- * Claude CLI-based orchestrator agent.
- * Extends BaseCliAgent<OrchestratorResult> to reuse subprocess execution infrastructure.
- */
-export class OrchestratorClaudeAgent extends BaseCliAgent<OrchestratorResult> {
-  private categories: string[];
-  private fallbackCount: number;
-  private mandatoryCount: number;
-  private nonMandatory: AgentConfig[];
-  private settings: AgentReviewSettings;
-  private validNames: string[];
-
-  constructor(
-    agent: AgentConfig,
-    agentLibrary: AgentConfig[],
-    mandatoryNames: Set<string>,
-    settings: AgentReviewSettings,
-    timeout: number,
-    contextPath?: string,
-    sessionName?: string,
-    backend?: ExecutionBackend,
-  ) {
-    // Build schema dynamically based on valid agent names
-    const nonMandatory = agentLibrary.filter(
-      (a) => !mandatoryNames.has(a.name),
-    );
-    const validNames = nonMandatory.map((a) => a.name);
-    const categories = settings.complexityCategories ?? DEFAULT_COMPLEXITY_CATEGORIES;
-
-    const schema = validNames.length > 0
-      ? buildOrchestratorSchema(validNames, categories)
-      : ORCHESTRATOR_SCHEMA;
-
-    super({
-      agent, schema, timeout, contextPath, sessionName,
-      debugLogger: { log: debugLog, raw: debugRaw },
-    }, backend);
-
-    this.nonMandatory = nonMandatory;
-    this.validNames = validNames;
-    this.categories = categories;
-    this.settings = settings;
-
-    const selection = settings.agentSelection ?? DEFAULT_AGENT_SELECTION;
-    this.fallbackCount = selection.fallbackCount ?? DEFAULT_AGENT_SELECTION.fallbackCount;
-    this.mandatoryCount = agentLibrary.filter((a) => mandatoryNames.has(a.name)).length;
-
-    logDebug("orchestrator", `Mandatory agents (always run): ${[...mandatoryNames].sort().join(", ")}`);
-    logDebug("orchestrator", `Non-mandatory agents for selection: ${validNames.join(", ")}`);
-  }
-
-  protected buildCliArgs(): string[] {
-    const systemPrompt = `You are a plan orchestrator for code review. Your job is to analyze plans and select appropriate reviewer agents.
-
-You MUST call StructuredOutput immediately with your analysis. Do NOT ask questions or use any other tools.
-
-When selecting agents:
-- Match agent expertise to plan requirements
-- Consider what each agent specializes in
-- Only select agents whose categories match the plan category
-- Fewer agents for simple plans, more for complex plans`;
-
-    return buildCliInvocation(
-      reviewSpec((this.agent.provider ?? "claude") as CliProvider, this.agent.model, this.schema, systemPrompt),
-    ).args;
-  }
-
-  protected buildPrompt(plan: string): string {
-    const selection = this.settings.agentSelection ?? DEFAULT_AGENT_SELECTION;
-
-    const agentList = this.nonMandatory
-      .map(
-        (a) =>
-          `- ${a.name} [${a.categories.join(", ")}]\n  Focus: ${a.focus}\n  Expertise: ${a.description}`,
-      )
-      .join("\n");
-    const categoryList = this.categories.join("/");
-
-    const simpleAdditional = Math.max(0, (selection.simple?.max ?? 3) - this.mandatoryCount);
-    const mediumAdditional = Math.max(0, (selection.medium?.max ?? 8) - this.mandatoryCount);
-    const highAdditional = Math.max(0, (selection.high?.max ?? 12) - this.mandatoryCount);
-
-    return `Analyze this plan and select appropriate reviewer agents.
-
-Available agents (select ONLY from this list):
-${agentList}
-
-Selection rules (number of ADDITIONAL agents to select from the list above):
-- simple complexity = ${simpleAdditional} agents
-- medium complexity = ${mediumAdditional} agents
-- high complexity = ${highAdditional} agents
-- Only select agents whose categories match the plan category (${categoryList})
-- Non-technical plans (life, business) typically need 0 code-focused agents
-- Note: mandatory agents run separately and are NOT listed above
-
-PLAN:
-<<<
-${plan}
->>>
-
-Call StructuredOutput now with: complexity, category, selectedAgents, reasoning`;
-  }
-
-  protected coerceResult(obj: Record<string, unknown> | null, _raw: string, _err: string): OrchestratorResult {
-    if (!obj) {
-      return this.makeFallback("Orchestrator output could not be parsed", "Failed to parse orchestrator output");
-    }
-
-    // Extract and validate fields
-    const rawComplexity = String(obj.complexity ?? "medium");
-    const complexity: ComplexityCategory =
-      rawComplexity === "simple" || rawComplexity === "medium" || rawComplexity === "high"
-        ? rawComplexity
-        : "medium";
-
-    const defaultCategory = this.categories.includes("code")
-      ? "code"
-      : (this.categories[0] ?? "code");
-    let category = defaultCategory;
-    if (typeof obj.category === "string" && this.categories.includes(obj.category)) {
-      category = obj.category;
-    }
-
-    const rawSelected = Array.isArray(obj.selectedAgents)
-      ? obj.selectedAgents
-      : (Array.isArray(obj.selected_agents) ? obj.selected_agents : []);
-
-    const validNames = new Set(this.validNames);
-    const selectedAgents: string[] = [];
-    const unknownNames: string[] = [];
-    const seen = new Set<string>();
-    for (const value of rawSelected) {
-      if (typeof value !== "string") continue;
-      if (!validNames.has(value)) {
-        unknownNames.push(value);
-        continue;
-      }
-      if (!seen.has(value)) {
-        selectedAgents.push(value);
-        seen.add(value);
-      }
-    }
-
-    if (unknownNames.length > 0) {
-      logDebug("orchestrator", `Ignoring unknown orchestrator selections: ${unknownNames.join(", ")}`);
-    }
-
-    const reasoning = String(obj.reasoning ?? "").trim() || "No reasoning provided";
-    const skipReasonRaw = typeof obj.skipReason === "string"
-      ? obj.skipReason
-      : (typeof obj.skip_reason === "string" ? obj.skip_reason : undefined);
-
-    return {
-      complexity,
-      category,
-      selected_agents: selectedAgents,
-      reasoning,
-      skip_reason: skipReasonRaw || undefined,
-    };
-  }
-
-  protected getCliName(): string {
-    return this.agent.provider ?? "claude";
-  }
-
-  protected makeErrorResult(type: "skip" | "error", message: string): OrchestratorResult {
-    return this.makeFallback(
-      type === "skip" ? `Orchestrator skipped - ${message}` : message,
-      message,
-    );
-  }
-
-  protected parseOutput(raw: string, _result: ExecutionResult): Record<string, unknown> | null {
-    return parseStructuredOutput(raw, {
-      requireFields: ["complexity", "category", "reasoning"],
-      loggerTag: "orchestrator_parser",
-    });
-  }
-
-  private makeFallback(reasoning: string, error: string): OrchestratorResult {
-    return {
-      complexity: "medium",
-      category: "code",
-      selected_agents: this.nonMandatory.slice(0, this.fallbackCount).map((a) => a.name),
-      reasoning,
-      error,
-    };
-  }
-}
+/**
+ * Orchestrator agent implementation using BaseCliAgent framework.
+ * Analyzes plan complexity and selects reviewer agents via Claude CLI.
+ */
+
+import { logDebug } from "../../../../_core/lib-ts/runtime/logger.js";
+import { shellQuoteWin } from "../../../../_core/lib-ts/runtime/subprocess-utils.js";
+import { parseCliOutput } from "../../cli-output-parser.js";
+import type { AgentConfig, OrchestratorResult, ComplexityCategory } from "../../types.js";
+import { BaseCliAgent } from "../base/base-agent.js";
+import { buildOrchestratorSchema, ORCHESTRATOR_SCHEMA } from "../schemas.js";
+
+// ---------------------------------------------------------------------------
+// Constants
+// ---------------------------------------------------------------------------
+
+const DEFAULT_COMPLEXITY_CATEGORIES = [
+  "code",
+  "infrastructure",
+  "documentation",
+  "life",
+  "business",
+  "design",
+  "research",
+];
+
+const DEFAULT_AGENT_SELECTION: Record<string, unknown> = {
+  simple: { min: 3, max: 3 },
+  medium: { min: 8, max: 8 },
+  high: { min: 12, max: 12 },
+  fallbackCount: 3,
+};
+
+/**
+ * Claude CLI-based orchestrator agent.
+ * Extends BaseCliAgent<OrchestratorResult> to reuse subprocess execution infrastructure.
+ */
+export class OrchestratorClaudeAgent extends BaseCliAgent<OrchestratorResult> {
+  private nonMandatory: AgentConfig[];
+  private validNames: string[];
+  private categories: string[];
+  private fallbackCount: number;
+  private mandatoryCount: number;
+  private settings: Record<string, unknown>;
+
+  constructor(
+    agent: AgentConfig,
+    agentLibrary: AgentConfig[],
+    mandatoryNames: Set<string>,
+    settings: Record<string, unknown>,
+    timeout: number,
+    contextPath?: string,
+    sessionName?: string,
+  ) {
+    // Build schema dynamically based on valid agent names
+    const nonMandatory = agentLibrary.filter(
+      (a) => !mandatoryNames.has(a.name),
+    );
+    const validNames = nonMandatory.map((a) => a.name);
+    const categories = (settings.complexityCategories as string[]) ?? DEFAULT_COMPLEXITY_CATEGORIES;
+
+    const schema = validNames.length > 0
+      ? buildOrchestratorSchema(validNames, categories)
+      : ORCHESTRATOR_SCHEMA;
+
+    super(agent, schema, timeout, contextPath, sessionName);
+
+    this.nonMandatory = nonMandatory;
+    this.validNames = validNames;
+    this.categories = categories;
+    this.settings = settings;
+
+    const selection = (settings.agentSelection as Record<string, unknown>) ?? DEFAULT_AGENT_SELECTION;
+    this.fallbackCount = (selection.fallbackCount as number) ?? 2;
+    this.mandatoryCount = agentLibrary.filter((a) => mandatoryNames.has(a.name)).length;
+
+    logDebug("orchestrator", `Mandatory agents (always run): ${[...mandatoryNames].sort().join(", ")}`);
+    logDebug("orchestrator", `Non-mandatory agents for selection: ${validNames.join(", ")}`);
+  }
+
+  protected getCliName(): string {
+    return "claude";
+  }
+
+  protected buildPrompt(plan: string): string {
+    const selection = (this.settings.agentSelection as Record<string, unknown>) ?? DEFAULT_AGENT_SELECTION;
+
+    const agentList = this.nonMandatory
+      .map(
+        (a) =>
+          `- ${a.name} [${a.categories.join(", ")}]\n  Focus: ${a.focus}\n  Expertise: ${a.description}`,
+      )
+      .join("\n");
+    const categoryList = this.categories.join("/");
+
+    const simpleAdditional = Math.max(0, ((selection.simple as Record<string, number> | undefined)?.max ?? 3) - this.mandatoryCount);
+    const mediumAdditional = Math.max(0, ((selection.medium as Record<string, number> | undefined)?.max ?? 8) - this.mandatoryCount);
+    const highAdditional = Math.max(0, ((selection.high as Record<string, number> | undefined)?.max ?? 12) - this.mandatoryCount);
+
+    return `Analyze this plan and select appropriate reviewer agents.
+
+Available agents (select ONLY from this list):
+${agentList}
+
+Selection rules (number of ADDITIONAL agents to select from the list above):
+- simple complexity = ${simpleAdditional} agents
+- medium complexity = ${mediumAdditional} agents
+- high complexity = ${highAdditional} agents
+- Only select agents whose categories match the plan category (${categoryList})
+- Non-technical plans (life, business) typically need 0 code-focused agents
+- Note: mandatory agents run separately and are NOT listed above
+
+PLAN:
+<<<
+${plan}
+>>>
+
+Call StructuredOutput now with: complexity, category, selectedAgents, reasoning`;
+  }
+
+  protected buildCliArgs(): string[] {
+    const schemaJson = JSON.stringify(this.schema);
+
+    const systemPrompt = `You are a plan orchestrator for code review. Your job is to analyze plans and select appropriate reviewer agents.
+
+You MUST call StructuredOutput immediately with your analysis. Do NOT ask questions or use any other tools.
+
+When selecting agents:
+- Match agent expertise to plan requirements
+- Consider what each agent specializes in
+- Only select agents whose categories match the plan category
+- Fewer agents for simple plans, more for complex plans`;
+
+    return [
+      "--model", this.agent.model,
+      "--output-format", "json",
+      "--json-schema", shellQuoteWin(schemaJson),
+      "--max-turns", "3",
+      "--setting-sources", process.platform === "win32" ? '""' : "",
+      "--system-prompt", shellQuoteWin(systemPrompt),
+      "-p",
+      "--no-session-persistence", // Prevent subprocess from creating session records
+    ];
+  }
+
+  protected parseOutput(raw: string, _result: unknown): Record<string, unknown> | null {
+    return parseCliOutput(raw);
+  }
+
+  protected coerceResult(obj: Record<string, unknown> | null, _raw: string, _err: string): OrchestratorResult {
+    if (!obj) {
+      return this.makeFallback("Orchestrator output could not be parsed", "Failed to parse orchestrator output");
+    }
+
+    // Extract and validate fields
+    const rawComplexity = String(obj.complexity ?? "medium");
+    const complexity: ComplexityCategory =
+      rawComplexity === "simple" || rawComplexity === "medium" || rawComplexity === "high"
+        ? rawComplexity
+        : "medium";
+
+    let category = (obj.category as string) ?? "code";
+    if (!this.categories.includes(category)) category = "code";
+
+    let selectedAgents = obj.selectedAgents;
+    if (!Array.isArray(selectedAgents)) selectedAgents = [];
+
+    const reasoning = String(obj.reasoning ?? "").trim() || "No reasoning provided";
+    const skipReason = obj.skipReason as string | undefined;
+
+    return {
+      complexity,
+      category,
+      selected_agents: selectedAgents as string[],
+      reasoning,
+      skip_reason: skipReason || undefined,
+    };
+  }
+
+  protected makeErrorResult(type: "skip" | "error", message: string): OrchestratorResult {
+    return this.makeFallback(
+      type === "skip" ? `Orchestrator skipped - ${message}` : message,
+      message,
+    );
+  }
+
+  private makeFallback(reasoning: string, error: string): OrchestratorResult {
+    return {
+      complexity: "medium",
+      category: "code",
+      selected_agents: this.nonMandatory.slice(0, this.fallbackCount).map((a) => a.name),
+      reasoning,
+      error,
+    };
+  }
+}