aiwcli 0.12.7 → 0.13.0

package/dist/templates/cc-native/_cc-native/{lib-ts → plan-review/lib}/output-builder.ts

@@ -1,130 +1,121 @@
-/**
- * Output construction: issue truncation, verdict override, message building.
- * Extracted from cc-native-plan-review.ts.
- */
-
-import { logInfo } from "../../_shared/lib-ts/base/logger.js";
-
-import type {
-  ReviewerResult,
-  CombinedReviewResult,
-  CorroborationResult,
-  IterationState,
-} from "./types.js";
-import {
-  buildInlineReviewSummary,
-  extractTopIssuesText,
-} from "./artifacts/format.js";
-import { extractTopIssuesForTracker } from "./graduation.js";
-
-const HOOK = "output-builder";
-
-const REVIEWER_CAVEAT = "Reviewers have limited context compared to your full session — use your judgment to adopt valid points and dismiss genuine false positives. However, treat false positives as a clarity signal: if a reviewer misunderstood your plan, an agent executing it will likely hit the same confusion. Revise those sections to be unambiguous so no future reader — human or AI — makes the same mistake.";
-const RESUBMIT_INSTRUCTION = "IMPORTANT: After revising the plan file, you MUST call ExitPlanMode again to trigger re-review. Do not end your turn or ask the user without calling ExitPlanMode.";
-
-// ---------------------------------------------------------------------------
-// Issue Truncation
-// ---------------------------------------------------------------------------
-
-/**
- * Truncate per-agent issues to top N by severity.
- * @mutates agentResults[name].data.issues in place.
- */
-export function truncateAgentIssues(
-  agentResults: Record<string, ReviewerResult>,
-  maxPerAgent: number,
-): void {
-  for (const r of Object.values(agentResults)) {
-    if (!Array.isArray(r.data?.issues)) continue;
-    const issues = r.data.issues as Array<{ severity?: string }>;
-    if (issues.length <= maxPerAgent) continue;
-    const severityOrder: Record<string, number> = { high: 0, medium: 1, low: 2 };
-    issues.sort((a, b) => (severityOrder[a.severity ?? "low"] ?? 2) - (severityOrder[b.severity ?? "low"] ?? 2));
-    const originalCount = issues.length;
-    r.data.issues = issues.slice(0, maxPerAgent);
-    logInfo(HOOK, `${r.name}: truncated issues ${originalCount} → ${maxPerAgent}`);
-  }
-}
-
-// ---------------------------------------------------------------------------
-// Verdict Override
-// ---------------------------------------------------------------------------
-
-/**
- * Override verdict to "fail" for agents exceeding high-issue threshold.
- * @mutates agentResults[name].verdict in place.
- */
-export function overrideVerdictsByThreshold(
-  agentResults: Record<string, ReviewerResult>,
-  threshold: number,
-): void {
-  for (const r of Object.values(agentResults)) {
-    if (!r.verdict || r.verdict === "skip" || r.verdict === "error") continue;
-    const issues = Array.isArray(r.data?.issues) ? r.data.issues as Array<{ severity?: string }> : [];
-    const agentHigh = issues.filter(i => i.severity === "high").length;
-    if (agentHigh >= threshold) {
-      logInfo(HOOK, `${r.name}: verdict overridden to 'fail' (${agentHigh} high issues >= ${threshold})`);
-      r.verdict = "fail";
-    }
-  }
-}
-
-// ---------------------------------------------------------------------------
-// Output Building
-// ---------------------------------------------------------------------------
-
-export interface ReviewOutputParams {
-  combinedResult: CombinedReviewResult;
-  corroborationResult: CorroborationResult;
-  iterationState: IterationState;
-  reviewFile: string;
-  highIssuesPath: string;
-}
-
-export interface ReviewOutput {
-  contextText: string;
-  blockReason: string;
-  shouldDeny: boolean;
-}
-
-/**
- * Build the final review output: context text and block reason.
- */
-export function buildReviewOutput(params: ReviewOutputParams): ReviewOutput {
-  const { combinedResult, corroborationResult, iterationState } = params;
-
-  const shouldDeny = corroborationResult.blocking.length > 0;
-  const reviewScore = shouldDeny ? 1.0 : 0.0;
-  const overall = corroborationResult.verdict;
-
-  // Build inline summary
-  const inlineSummary = buildInlineReviewSummary(combinedResult, 5, 800, corroborationResult);
-  const contextParts = [inlineSummary];
-
-  // Top issues
-  const topIssuesList = extractTopIssuesForTracker(combinedResult, 5);
-  if (topIssuesList.length > 0) {
-    contextParts.push(`\nTop high-severity issues:\n${topIssuesList.map(i => `- ${i}`).join("\n")}`);
-  }
-  contextParts.push(`\nFull review: \`${params.reviewFile}\`\n`);
-
-  const contextText = contextParts.join("");
-  const iterInfo = ` (iteration ${iterationState.current}/${iterationState.max}, score=${reviewScore.toFixed(2)})`;
-
-  let blockReason: string;
-  if (shouldDeny) {
-    const topIssuesText = extractTopIssuesText(combinedResult, 3, "high");
-    blockReason = `Plan review FAILED${iterInfo}. ` +
-      `Critical issues: ${topIssuesText}. ` +
-      `IMPORTANT: Read \`${params.highIssuesPath}\` for ALL high-severity issues — ` +
-      `this file contains only the most critical findings, no noise. ` +
-      `${REVIEWER_CAVEAT} ` +
-      `Revise the plan to address these issues, then call ExitPlanMode again. ` +
-      RESUBMIT_INSTRUCTION;
-  } else {
-    blockReason = `Plan review ${overall.toUpperCase()}${iterInfo}. Review complete. ${REVIEWER_CAVEAT}`;
-  }
-
-  return { contextText, blockReason, shouldDeny };
-}
-
+/**
+ * Output construction: issue truncation, verdict override, message building.
+ * Extracted from cc-native-plan-review.ts.
+ */
+
+import { logInfo } from "../../../_shared/lib-ts/base/logger.js";
+import {
+  buildInlineReviewSummary,
+  extractTopIssuesText,
+} from "../../artifacts/lib/format.js";
+import type {
+  ReviewerResult,
+  CombinedReviewResult,
+  CorroborationResult,
+  IterationState,
+} from "../../lib-ts/types.js";
+
+const HOOK = "output-builder";
+
+const REVIEWER_CAVEAT = "Reviewers have limited context compared to your full session — use your judgment to adopt valid points and dismiss genuine false positives. However, treat false positives as a clarity signal: if a reviewer misunderstood your plan, an agent executing it will likely hit the same confusion. Revise those sections to be unambiguous so no future reader — human or AI — makes the same mistake.";
+const RESUBMIT_INSTRUCTION = "IMPORTANT: After revising the plan file, you MUST call ExitPlanMode again to trigger re-review. Do not end your turn or ask the user without calling ExitPlanMode.";
+
+// ---------------------------------------------------------------------------
+// Issue Truncation
+// ---------------------------------------------------------------------------
+
+/**
+ * Truncate per-agent issues to top N by severity.
+ * Mutates agentResults[name].data.issues in place.
+ */
+export function truncateAgentIssues(
+  agentResults: Record<string, ReviewerResult>,
+  maxPerAgent: number,
+): void {
+  for (const r of Object.values(agentResults)) {
+    if (!Array.isArray(r.data?.issues)) continue;
+    const issues = r.data.issues as Array<{ severity?: string }>;
+    if (issues.length <= maxPerAgent) continue;
+    const severityOrder: Record<string, number> = { high: 0, medium: 1, low: 2 };
+    issues.sort((a, b) => (severityOrder[a.severity ?? "low"] ?? 2) - (severityOrder[b.severity ?? "low"] ?? 2));
+    const originalCount = issues.length;
+    r.data.issues = issues.slice(0, maxPerAgent);
+    logInfo(HOOK, `${r.name}: truncated issues ${originalCount} → ${maxPerAgent}`);
+  }
+}
+
+// ---------------------------------------------------------------------------
+// Verdict Override
+// ---------------------------------------------------------------------------
+
+/**
+ * Override verdict to "fail" for agents exceeding high-issue threshold.
+ * Mutates agentResults[name].verdict in place.
+ */
+export function overrideVerdictsByThreshold(
+  agentResults: Record<string, ReviewerResult>,
+  threshold: number,
+): void {
+  for (const r of Object.values(agentResults)) {
+    if (!r.verdict || r.verdict === "skip" || r.verdict === "error") continue;
+    const issues = Array.isArray(r.data?.issues) ? r.data.issues as Array<{ severity?: string }> : [];
+    const agentHigh = issues.filter(i => i.severity === "high").length;
+    if (agentHigh >= threshold) {
+      logInfo(HOOK, `${r.name}: verdict overridden to 'fail' (${agentHigh} high issues >= ${threshold})`);
+      r.verdict = "fail";
+    }
+  }
+}
+
+// ---------------------------------------------------------------------------
+// Output Building
+// ---------------------------------------------------------------------------
+
+export interface ReviewOutputParams {
+  combinedResult: CombinedReviewResult;
+  corroborationResult: CorroborationResult;
+  iterationState: IterationState;
+  reviewFile: string;
+  highIssuesPath: string;
+}
+
+export interface ReviewOutput {
+  contextText: string;
+  blockReason: string;
+  shouldDeny: boolean;
+}
+
+/**
+ * Build the final review output: context text and block reason.
+ */
+export function buildReviewOutput(params: ReviewOutputParams): ReviewOutput {
+  const { combinedResult, corroborationResult, iterationState } = params;
+
+  const shouldDeny = corroborationResult.blocking.length > 0;
+  const reviewScore = shouldDeny ? 1 : 0;
+  const overall = corroborationResult.verdict;
+
+  // Build inline summary (no individual issues — those go in blockReason)
+  const inlineSummary = buildInlineReviewSummary(combinedResult, 0, 800, corroborationResult);
+  const contextParts = [inlineSummary];
+  contextParts.push(`\nFull review: \`${params.reviewFile}\`\n`);
+
+  const contextText = contextParts.join("");
+  const iterInfo = ` (iteration ${iterationState.current}/${iterationState.max}, score=${reviewScore.toFixed(2)})`;
+
+  let blockReason: string;
+  if (shouldDeny) {
+    const topIssuesText = extractTopIssuesText(combinedResult, 15, "high");
+    blockReason = `Plan review FAILED${iterInfo}. ` +
+      `High-severity issues:\n${topIssuesText}\n\n` +
+      `Full details: \`${params.highIssuesPath}\`\n` +
+      `${REVIEWER_CAVEAT} ` +
+      `Revise the plan to address these issues, then call ExitPlanMode again. ` +
+      RESUBMIT_INSTRUCTION;
+  } else {
+    blockReason = `Plan review ${overall.toUpperCase()}${iterInfo}. Review complete. ${REVIEWER_CAVEAT}`;
+  }
+
+  return { contextText, blockReason, shouldDeny };
+}
+

package/dist/templates/cc-native/_cc-native/{lib-ts → plan-review/lib}/plan-questions.ts

@@ -1,102 +1,101 @@
-/**
- * Plan question generation — runs a fresh-context agent to identify
- * questions, assumptions, and ambiguities in a plan before review.
- * See cc-native-plan-review.ts for integration point (questions gate).
- */
-
-import * as path from "node:path";
-
-import { aggregateAgents } from "./aggregate-agents.js";
-import { runAgentReview } from "./reviewers/index.js";
-import { QUESTIONS_SCHEMA } from "./reviewers/schemas.js";
-import type { AgentConfig, ModelsConfig } from "./types.js";
-import { logInfo, logWarn, logError } from "../../_shared/lib-ts/base/logger.js";
-
-// ---------------------------------------------------------------------------
-// Types
-// ---------------------------------------------------------------------------
-
-export interface PlanQuestionsResult {
-  questions: string[];
-  assumptions: string[];
-  ambiguities: string[];
-}
-
-// ---------------------------------------------------------------------------
-// Provider assignment (local copy — avoids circular import from hook)
-// ---------------------------------------------------------------------------
-
-import { findExecutable } from "../../_shared/lib-ts/base/subprocess-utils.js";
-
-function assignProvider(agent: AgentConfig): AgentConfig {
-  // Default to claude provider with the agent's configured model
-  const found = findExecutable("claude");
-  if (found) {
-    return { ...agent, provider: "claude" };
-  }
-  logWarn("plan-questions", "Claude CLI not found, using agent defaults");
-  return agent;
-}
-
-// ---------------------------------------------------------------------------
-// Main
-// ---------------------------------------------------------------------------
-
-const HOOK = "plan-questions";
-
-/**
- * Run the plan-questions agent to generate questions about a plan.
- * Returns structured questions/assumptions/ambiguities, or null on failure.
- *
- * The agent runs in a fresh context (no codebase, no session history)
- * and uses QUESTIONS_SCHEMA instead of REVIEW_SCHEMA — the agent runner
- * is schema-agnostic.
- */
-export async function runPlanQuestions(
-  plan: string,
-  aiwcliDir: string,
-  timeout: number,
-  contextPath?: string,
-  sessionName?: string,
-): Promise<PlanQuestionsResult | null> {
-  // Load the plan-questions agent from agents/plan-questions/
-  const questionsAgentDir = path.join(aiwcliDir, "_cc-native", "agents", "plan-questions");
-  const agents = aggregateAgents(questionsAgentDir);
-
-  if (agents.length === 0) {
-    logWarn(HOOK, `No agents found in ${questionsAgentDir}`);
-    return null;
-  }
-
-  // Use the first agent (PLAN-QUESTIONER)
-  let agent = agents[0]!;
-  logInfo(HOOK, `Using plan-questions agent: ${agent.name}`);
-
-  // Assign provider
-  agent = assignProvider(agent);
-
-  // Run the agent with QUESTIONS_SCHEMA
-  const result = await runAgentReview(
-    plan,
-    agent,
-    QUESTIONS_SCHEMA,
-    timeout,
-    contextPath,
-    sessionName ?? "unknown",
-  );
-
-  if (!result.ok) {
-    logError(HOOK, `Plan-questions agent failed: ${result.err}`);
-    return null;
-  }
-
-  // Extract structured data
-  const data = result.data ?? {};
-  const questions = Array.isArray(data.questions) ? (data.questions as string[]) : [];
-  const assumptions = Array.isArray(data.assumptions) ? (data.assumptions as string[]) : [];
-  const ambiguities = Array.isArray(data.ambiguities) ? (data.ambiguities as string[]) : [];
-
-  logInfo(HOOK, `Plan-questions result: ${questions.length} questions, ${assumptions.length} assumptions, ${ambiguities.length} ambiguities`);
-
-  return { questions, assumptions, ambiguities };
-}
+/**
+ * Plan question generation — runs a fresh-context agent to identify
+ * questions, assumptions, and ambiguities in a plan before review.
+ * See cc-native-plan-review.ts for integration point (questions gate).
+ */
+
+import * as path from "node:path";
+
+import { runAgentReview } from "./reviewers/index.js";
+import { QUESTIONS_SCHEMA } from "./reviewers/schemas.js";
+import { logInfo, logWarn, logError } from "../../../_shared/lib-ts/base/logger.js";
+import { findExecutable } from "../../../_shared/lib-ts/base/subprocess-utils.js";
+import { aggregateAgents } from "../../lib-ts/aggregate-agents.js";
+import type { AgentConfig } from "../../lib-ts/types.js";
+
+// ---------------------------------------------------------------------------
+// Types
+// ---------------------------------------------------------------------------
+
+export interface PlanQuestionsResult {
+  questions: string[];
+  assumptions: string[];
+  ambiguities: string[];
+}
+
+// ---------------------------------------------------------------------------
+// Provider assignment (local copy — avoids circular import from hook)
+// ---------------------------------------------------------------------------
+
+function assignProvider(agent: AgentConfig): AgentConfig {
+  // Default to claude provider with the agent's configured model
+  const found = findExecutable("claude");
+  if (found) {
+    return { ...agent, provider: "claude" };
+  }
+  logWarn("plan-questions", "Claude CLI not found, using agent defaults");
+  return agent;
+}
+
+// ---------------------------------------------------------------------------
+// Main
+// ---------------------------------------------------------------------------
+
+const HOOK = "plan-questions";
+
+/**
+ * Run the plan-questions agent to generate questions about a plan.
+ * Returns structured questions/assumptions/ambiguities, or null on failure.
+ *
+ * The agent runs in a fresh context (no codebase, no session history)
+ * and uses QUESTIONS_SCHEMA instead of REVIEW_SCHEMA — the agent runner
+ * is schema-agnostic.
+ */
+export async function runPlanQuestions(
+  plan: string,
+  aiwcliDir: string,
+  timeout: number,
+  contextPath?: string,
+  sessionName?: string,
+): Promise<PlanQuestionsResult | null> {
+  // Load the plan-questions agent from agents/plan-questions/
+  const questionsAgentDir = path.join(aiwcliDir, "_cc-native", "plan-review", "agents", "plan-questions");
+  const agents = aggregateAgents(questionsAgentDir);
+
+  if (agents.length === 0) {
+    logWarn(HOOK, `No agents found in ${questionsAgentDir}`);
+    return null;
+  }
+
+  // Use the first agent (PLAN-QUESTIONER)
+  let agent = agents[0]!;
+  logInfo(HOOK, `Using plan-questions agent: ${agent.name}`);
+
+  // Assign provider
+  agent = assignProvider(agent);
+
+  // Run the agent with QUESTIONS_SCHEMA
+  const result = await runAgentReview(
+    plan,
+    agent,
+    QUESTIONS_SCHEMA,
+    timeout,
+    contextPath,
+    sessionName ?? "unknown",
+  );
+
+  if (!result.ok) {
+    logError(HOOK, `Plan-questions agent failed: ${result.err}`);
+    return null;
+  }
+
+  // Extract structured data
+  const data = result.data ?? {};
+  const questions = Array.isArray(data.questions) ? (data.questions as string[]) : [];
+  const assumptions = Array.isArray(data.assumptions) ? (data.assumptions as string[]) : [];
+  const ambiguities = Array.isArray(data.ambiguities) ? (data.ambiguities as string[]) : [];
+
+  logInfo(HOOK, `Plan-questions result: ${questions.length} questions, ${assumptions.length} assumptions, ${ambiguities.length} ambiguities`);
+
+  return { questions, assumptions, ambiguities };
+}