aitasks 1.3.4 → 1.3.6

package/dist/index.js

@@ -1890,7 +1890,7 @@ var require_commander = __commonJS((exports) => {
 var require_package = __commonJS((exports, module) => {
   module.exports = {
     name: "aitasks",
-    version: "1.3.4",
+    version: "1.3.6",
     description: "CLI task management tool built for AI agents",
     type: "module",
     bin: {
@@ -29426,26 +29426,27 @@ ${reviewRequired ? `3. Submit for review \u2014 you CANNOT mark done directly:
    \`\`\`bash
    aitasks review TASK-001 --agent $AITASKS_AGENT_ID
    \`\`\`
-   **STOP HERE. Do not run \`aitasks done\` yourself.** The system will block self-approval.
+   **Do not run \`aitasks done\` yourself.** The system will block self-approval.
 
-4. **IMMEDIATELY spawn a review sub-agent with a DIFFERENT agent ID** to inspect the implementation.
-   The review sub-agent must first register itself, then approve or reject:
+4. **IN THIS SAME SESSION**, immediately spawn a review sub-agent with a DIFFERENT agent ID.
+   Do this NOW \u2014 before writing any summary, before moving to any other task, before anything else.
    \`\`\`bash
    # Review sub-agent registers itself
-   aitasks heartbeat --agent <review-agent-id>
+   aitasks heartbeat --agent review-task-001
 
    # Approve (moves task to done):
-   aitasks done TASK-001 --agent <review-agent-id>
+   aitasks done TASK-001 --agent review-task-001
 
    # OR reject (sends task back to in_progress with feedback):
-   aitasks reject TASK-001 --reason "<specific feedback>" --agent <review-agent-id>
+   aitasks reject TASK-001 --reason "<specific feedback>" --agent review-task-001
    \`\`\`
-   The task is still incomplete until the review agent approves it.
-   **The system will block approval from any agent that has not registered or that submitted the review itself.**
+   **Your session is NOT complete after submitting for review. You must remain active and drive the
+   review to completion. The task is still incomplete until \`aitasks done\` succeeds.**
 
 5. If rejected: address the feedback, re-check criteria, and repeat from step 3.
 
-> The task is only done when \`aitasks done\` completes successfully. \`review\` status means awaiting approval \u2014 it is not done.` : `3. Mark done (will FAIL if any criterion is unchecked):
+> The task is only done when \`aitasks done\` completes successfully. \`review\` status means
+> awaiting approval \u2014 it is NOT done. Do not write a final summary until all tasks are \`done\`.` : `3. Mark done (will FAIL if any criterion is unchecked):
    \`\`\`bash
    aitasks done TASK-001 --agent $AITASKS_AGENT_ID
    \`\`\`
@@ -29490,9 +29491,28 @@ aitasks unclaim TASK-001 --agent $AITASKS_AGENT_ID --reason "Blocked on missing
 6. If a task needs splitting, create subtasks BEFORE marking parent done.
 7. Your evidence strings must be concrete and verifiable \u2014 not vague affirmations.
 8. Always provide --desc, at least one --ac, and --agent when creating a task. All three are required.${reviewRequired ? `
-9. NEVER move a task to done directly. Always submit for review first with \`aitasks review\`, then IMMEDIATELY spawn a review sub-agent with a DIFFERENT agent ID. Do NOT call \`aitasks done\` yourself after submitting for review \u2014 the system blocks self-approval.` : ""}
+9. NEVER move a task to done directly. Always submit for review first with \`aitasks review\`, then IMMEDIATELY spawn a review sub-agent with a DIFFERENT agent ID in the SAME session. Do NOT call \`aitasks done\` yourself \u2014 the system blocks the implementing agent and the agent that submitted the review from self-approving.
+10. **Do not end your session or write a final summary until every task you worked on is in \`done\` status.** If any task is in \`review\`, you must spawn the review sub-agent NOW in this session. Submitting for review and stopping is an incomplete session.` : ""}
 
----
+${reviewRequired ? `---
+
+### Before Ending Your Session
+
+**Run this check before writing any final summary or concluding your work:**
+
+\`\`\`bash
+aitasks list --json   # Check that ALL your tasks are in done status
+\`\`\`
+
+- Any task in \`done\` \u2192 \u2713 complete
+- Any task in \`review\` \u2192 you MUST spawn a review sub-agent NOW in this session before stopping
+- Any task in \`in_progress\` \u2192 continue implementation
+
+**You are NOT finished until \`aitasks list\` shows every task you worked on as \`done\`.**
+Submitting tasks for review and then stopping is an incomplete session. The review sub-agent
+must be spawned and must approve the task in this same session.
+
+` : ""}---
 
 ### Quick Reference
 
@@ -30487,17 +30507,6 @@ function completeTask(taskId, agentId) {
 ` + `  A separate review sub-agent must run: aitasks done ${taskId} --agent <review-agent-id>`
       };
     }
-    const reviewerRow = db.query(`SELECT first_seen FROM agents WHERE id = ?`).get(agentId);
-    const reviewSubmittedAt = reviewEvent?.created_at ?? 0;
-    if (!reviewerRow || reviewerRow.first_seen > reviewSubmittedAt) {
-      return {
-        task: null,
-        error: `Review agent '${agentId}' was not active before this review was submitted.
-` + `  A real review sub-agent must be independently spawned \u2014 it cannot be registered
-` + `  moments before approving. The reviewer must have prior activity in the system
-` + `  before the review was submitted.`
-      };
-    }
   }
   const updated = updateTask(taskId, { status: "done", completed_at: Date.now() });
   logEvent({ task_id: taskId, agent_id: agentId, event_type: "completed", payload: {} });
@@ -30517,7 +30526,8 @@ function completeTask(taskId, agentId) {
       });
     }
   }
-  db.run(`UPDATE agents SET current_task = NULL WHERE id = ?`, [agentId]);
+  if (agentId)
+    db.run(`UPDATE agents SET current_task = NULL WHERE id = ?`, [agentId]);
   return { task: updated };
 }
 function blockTask(taskId, blockerIds, agentId) {
@@ -41236,7 +41246,7 @@ var checkCommand = new Command("check").description("Verify an acceptance criter
 var doneCommand = new Command("done").description("Mark task(s) as complete (all acceptance criteria must be verified) - supports patterns").argument("<taskId...>", "Task ID(s) - can specify multiple or use patterns (e.g., TASK-00*)").option("--agent <agentId>", "Agent ID (or set AITASKS_AGENT_ID)").option("--json", "Output as JSON").action((taskIds, opts) => {
   requireInitialized();
   const json = isJsonMode(opts.json);
-  const agent = requireAgentId(opts.agent, "done");
+  const agent = opts.agent ?? process.env.AITASKS_AGENT_ID;
   const allTaskIds = listTasks().map((t) => t.id);
   const resolvedIds = resolveTaskIds(taskIds.map((id) => id.toUpperCase()), allTaskIds);
   if (resolvedIds.length === 0) {
@@ -41391,7 +41401,7 @@ var reviewCommand = new Command("review").description("Request human review for
         console.log(source_default.dim(`  3. Sub-agent examines implementation and verifies all acceptance criteria`));
         console.log(source_default.dim(`  4. Approve:  aitasks done ${task.id} --agent review-${task.id.toLowerCase()}`));
         console.log(source_default.dim(`     Reject:   aitasks reject ${task.id} --reason "<feedback>" --agent review-${task.id.toLowerCase()}`));
-        console.log(source_default.dim(`  The system will reject approval from unregistered or self-approving agents.`));
+        console.log(source_default.dim(`  The system will reject approval from the implementing agent or the agent that submitted the review.`));
       } else {
         console.log(source_default.dim(`     Approve: aitasks done ${task.id} --agent <review-agent-id>`));
         console.log(source_default.dim(`     Reject:  aitasks reject ${task.id} --reason "<feedback>"`));
@@ -41953,6 +41963,7 @@ var TreeBoardComponent = ({ getTasks }) => {
   const [scrollOffset, setScrollOffset] = import_react29.useState(0);
   const [leftScrollOffset, setLeftScrollOffset] = import_react29.useState(0);
   const [mode, setMode] = import_react29.useState("normal");
+  const [moveError, setMoveError] = import_react29.useState(null);
   const [searchQuery, setSearchQuery] = import_react29.useState("");
   const { exit } = use_app_default();
   const { stdout } = use_stdout_default();
@@ -42073,9 +42084,23 @@ var TreeBoardComponent = ({ getTasks }) => {
       };
       const newStatus = statusMap[input];
       if (newStatus && selectedTask) {
-        updateTask(selectedTask.id, { status: newStatus });
-        setTasks(getTasks());
-        setMode("normal");
+        if (newStatus === "done") {
+          const { error } = completeTask(selectedTask.id);
+          if (error) {
+            setMoveError(error.split(`
+`)[0] ?? error);
+            setMode("normal");
+          } else {
+            setMoveError(null);
+            setTasks(getTasks());
+            setMode("normal");
+          }
+        } else {
+          setMoveError(null);
+          updateTask(selectedTask.id, { status: newStatus });
+          setTasks(getTasks());
+          setMode("normal");
+        }
       }
       return;
     }
@@ -42085,10 +42110,14 @@ var TreeBoardComponent = ({ getTasks }) => {
       searchQuery ? setSearchQuery("") : exit();
       return;
     }
-    if (key.upArrow)
+    if (key.upArrow) {
+      setMoveError(null);
       setSelectedIdx((i) => Math.max(0, i - 1));
-    if (key.downArrow)
+    }
+    if (key.downArrow) {
+      setMoveError(null);
       setSelectedIdx((i) => Math.min(items.length - 1, i + 1));
+    }
     if (input === "s")
       setMode("search");
     if (input === "m" && selectedTask)
@@ -42442,13 +42471,28 @@ var TreeBoardComponent = ({ getTasks }) => {
           borderColor: "gray",
           children: mode === "move" && selectedTask ? /* @__PURE__ */ jsx_dev_runtime3.jsxDEV(StatusPicker, {
             task: selectedTask
-          }, undefined, false, undefined, this) : /* @__PURE__ */ jsx_dev_runtime3.jsxDEV(RightPane, {
-            task: selectedTask,
-            width: rightInner,
-            height: rightHeight,
-            scrollOffset,
-            metricsRef: rightMetricsRef
-          }, undefined, false, undefined, this)
+          }, undefined, false, undefined, this) : /* @__PURE__ */ jsx_dev_runtime3.jsxDEV(jsx_dev_runtime3.Fragment, {
+            children: [
+              moveError && /* @__PURE__ */ jsx_dev_runtime3.jsxDEV(Box_default, {
+                paddingX: 1,
+                paddingTop: 1,
+                children: /* @__PURE__ */ jsx_dev_runtime3.jsxDEV(Text, {
+                  color: "red",
+                  children: [
+                    "\u2717 ",
+                    moveError
+                  ]
+                }, undefined, true, undefined, this)
+              }, undefined, false, undefined, this),
+              /* @__PURE__ */ jsx_dev_runtime3.jsxDEV(RightPane, {
+                task: selectedTask,
+                width: rightInner,
+                height: rightHeight,
+                scrollOffset,
+                metricsRef: rightMetricsRef
+              }, undefined, false, undefined, this)
+            ]
+          }, undefined, true, undefined, this)
         }, undefined, false, undefined, this)
       ]
     }, undefined, true, undefined, this)
@@ -43328,4 +43372,4 @@ program2.parseAsync(process.argv).catch((err) => {
   process.exit(1);
 });
 
-//# debugId=6CE8123AAE8C303564756E2164756E21
+//# debugId=5791C0490824449C64756E2164756E21

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "aitasks",
-  "version": "1.3.4",
+  "version": "1.3.6",
   "description": "CLI task management tool built for AI agents",
   "type": "module",
   "bin": {