aitasks 1.3.4 → 1.3.5

package/dist/index.js

@@ -1890,7 +1890,7 @@ var require_commander = __commonJS((exports) => {
 var require_package = __commonJS((exports, module) => {
   module.exports = {
     name: "aitasks",
-    version: "1.3.4",
+    version: "1.3.5",
     description: "CLI task management tool built for AI agents",
     type: "module",
     bin: {
@@ -29426,12 +29426,13 @@ ${reviewRequired ? `3. Submit for review \u2014 you CANNOT mark done directly:
    \`\`\`bash
    aitasks review TASK-001 --agent $AITASKS_AGENT_ID
    \`\`\`
-   **STOP HERE. Do not run \`aitasks done\` yourself.** The system will block self-approval.
+   **Do not run \`aitasks done\` yourself.** The system will block self-approval.
 
-4. **IMMEDIATELY spawn a review sub-agent with a DIFFERENT agent ID** to inspect the implementation.
-   The review sub-agent must first register itself, then approve or reject:
+4. **IN THIS SAME SESSION, immediately spawn a review sub-agent** with a DIFFERENT agent ID.
+   Do this NOW \u2014 before writing any summary, before moving to any other task, before anything else.
+   The review sub-agent must register first, then inspect and approve or reject:
    \`\`\`bash
-   # Review sub-agent registers itself
+   # Review sub-agent registers itself (BEFORE the review was submitted \u2014 or it will be blocked)
    aitasks heartbeat --agent <review-agent-id>
 
    # Approve (moves task to done):
@@ -29440,12 +29441,15 @@ ${reviewRequired ? `3. Submit for review \u2014 you CANNOT mark done directly:
    # OR reject (sends task back to in_progress with feedback):
    aitasks reject TASK-001 --reason "<specific feedback>" --agent <review-agent-id>
    \`\`\`
-   The task is still incomplete until the review agent approves it.
-   **The system will block approval from any agent that has not registered or that submitted the review itself.**
+   **Your session is NOT complete after submitting for review. You must remain active and drive the
+   review to completion. The task is still incomplete until \`aitasks done\` succeeds.**
+   The system will block approval from any agent that registered after the review was submitted
+   or that submitted the review itself.
 
 5. If rejected: address the feedback, re-check criteria, and repeat from step 3.
 
-> The task is only done when \`aitasks done\` completes successfully. \`review\` status means awaiting approval \u2014 it is not done.` : `3. Mark done (will FAIL if any criterion is unchecked):
+> The task is only done when \`aitasks done\` completes successfully. \`review\` status means
+> awaiting approval \u2014 it is NOT done. Do not write a final summary until all tasks are \`done\`.` : `3. Mark done (will FAIL if any criterion is unchecked):
    \`\`\`bash
    aitasks done TASK-001 --agent $AITASKS_AGENT_ID
    \`\`\`
@@ -29490,9 +29494,28 @@ aitasks unclaim TASK-001 --agent $AITASKS_AGENT_ID --reason "Blocked on missing
 6. If a task needs splitting, create subtasks BEFORE marking parent done.
 7. Your evidence strings must be concrete and verifiable \u2014 not vague affirmations.
 8. Always provide --desc, at least one --ac, and --agent when creating a task. All three are required.${reviewRequired ? `
-9. NEVER move a task to done directly. Always submit for review first with \`aitasks review\`, then IMMEDIATELY spawn a review sub-agent with a DIFFERENT agent ID. Do NOT call \`aitasks done\` yourself after submitting for review \u2014 the system blocks self-approval.` : ""}
+9. NEVER move a task to done directly. Always submit for review first with \`aitasks review\`, then IMMEDIATELY spawn a review sub-agent with a DIFFERENT agent ID in the SAME session. Do NOT call \`aitasks done\` yourself after submitting for review \u2014 the system blocks self-approval.
+10. **Do not end your session or write a final summary until every task you worked on is in \`done\` status.** If any task is in \`review\`, you must spawn the review sub-agent NOW in this session. Submitting for review and stopping is an incomplete session.` : ""}
 
----
+${reviewRequired ? `---
+
+### Before Ending Your Session
+
+**Run this check before writing any final summary or concluding your work:**
+
+\`\`\`bash
+aitasks list --json   # Check that ALL your tasks are in done status
+\`\`\`
+
+- Any task in \`done\` \u2192 \u2713 complete
+- Any task in \`review\` \u2192 you MUST spawn a review sub-agent NOW in this session before stopping
+- Any task in \`in_progress\` \u2192 continue implementation
+
+**You are NOT finished until \`aitasks list\` shows every task you worked on as \`done\`.**
+Submitting tasks for review and then stopping is an incomplete session. The review sub-agent
+must be spawned and must approve the task in this same session.
+
+` : ""}---
 
 ### Quick Reference
 
@@ -30487,16 +30510,18 @@ function completeTask(taskId, agentId) {
 ` + `  A separate review sub-agent must run: aitasks done ${taskId} --agent <review-agent-id>`
       };
     }
-    const reviewerRow = db.query(`SELECT first_seen FROM agents WHERE id = ?`).get(agentId);
-    const reviewSubmittedAt = reviewEvent?.created_at ?? 0;
-    if (!reviewerRow || reviewerRow.first_seen > reviewSubmittedAt) {
-      return {
-        task: null,
-        error: `Review agent '${agentId}' was not active before this review was submitted.
+    if (agentId) {
+      const reviewerRow = db.query(`SELECT first_seen FROM agents WHERE id = ?`).get(agentId);
+      const reviewSubmittedAt = reviewEvent?.created_at ?? 0;
+      if (!reviewerRow || reviewerRow.first_seen > reviewSubmittedAt) {
+        return {
+          task: null,
+          error: `Review agent '${agentId}' was not active before this review was submitted.
 ` + `  A real review sub-agent must be independently spawned \u2014 it cannot be registered
 ` + `  moments before approving. The reviewer must have prior activity in the system
 ` + `  before the review was submitted.`
-      };
+        };
+      }
     }
   }
   const updated = updateTask(taskId, { status: "done", completed_at: Date.now() });
@@ -30517,7 +30542,8 @@ function completeTask(taskId, agentId) {
       });
     }
   }
-  db.run(`UPDATE agents SET current_task = NULL WHERE id = ?`, [agentId]);
+  if (agentId)
+    db.run(`UPDATE agents SET current_task = NULL WHERE id = ?`, [agentId]);
   return { task: updated };
 }
 function blockTask(taskId, blockerIds, agentId) {
@@ -41236,7 +41262,7 @@ var checkCommand = new Command("check").description("Verify an acceptance criter
 var doneCommand = new Command("done").description("Mark task(s) as complete (all acceptance criteria must be verified) - supports patterns").argument("<taskId...>", "Task ID(s) - can specify multiple or use patterns (e.g., TASK-00*)").option("--agent <agentId>", "Agent ID (or set AITASKS_AGENT_ID)").option("--json", "Output as JSON").action((taskIds, opts) => {
   requireInitialized();
   const json = isJsonMode(opts.json);
-  const agent = requireAgentId(opts.agent, "done");
+  const agent = opts.agent ?? process.env.AITASKS_AGENT_ID;
   const allTaskIds = listTasks().map((t) => t.id);
   const resolvedIds = resolveTaskIds(taskIds.map((id) => id.toUpperCase()), allTaskIds);
   if (resolvedIds.length === 0) {
@@ -43328,4 +43354,4 @@ program2.parseAsync(process.argv).catch((err) => {
   process.exit(1);
 });
 
-//# debugId=6CE8123AAE8C303564756E2164756E21
+//# debugId=1AD83EE12EE8B53364756E2164756E21

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "aitasks",
-  "version": "1.3.4",
+  "version": "1.3.5",
   "description": "CLI task management tool built for AI agents",
   "type": "module",
   "bin": {