aitasks 1.3.3 → 1.3.5

package/README.md

@@ -140,7 +140,8 @@ aitasks create \
   --ac "Returns 200" \          # Acceptance criterion (repeatable, at least one required)
   --priority high \             # critical | high | medium | low
   --type feature \              # feature | bug | chore | spike
-  --parent TASK-001             # Parent task ID (optional)
+  --parent TASK-001 \           # Parent task ID (optional)
+  --agent $AITASKS_AGENT_ID     # Agent creating the task (logged in event history)
 ```
 
 ---

package/dist/index.js

@@ -1890,7 +1890,7 @@ var require_commander = __commonJS((exports) => {
 var require_package = __commonJS((exports, module) => {
   module.exports = {
     name: "aitasks",
-    version: "1.3.3",
+    version: "1.3.5",
     description: "CLI task management tool built for AI agents",
     type: "module",
     bin: {
@@ -29071,7 +29071,7 @@ import { join as join3 } from "path";
 import { existsSync as existsSync3 } from "fs";
 
 // src/db/schema.ts
-var SCHEMA_VERSION = 2;
+var SCHEMA_VERSION = 3;
 function runMigrations(db) {
   const row = db.query(`SELECT value FROM meta WHERE key = 'schema_version'`).get();
   const current = row ? parseInt(row.value, 10) : 1;
@@ -29080,6 +29080,11 @@ function runMigrations(db) {
     db.exec(`INSERT OR IGNORE INTO meta (key, value) VALUES ('review_required', 'false')`);
     db.exec(`UPDATE meta SET value = '2' WHERE key = 'schema_version'`);
   }
+  if (current < 3) {
+    db.exec(`ALTER TABLE agents ADD COLUMN first_seen INTEGER`);
+    db.exec(`UPDATE agents SET first_seen = last_seen WHERE first_seen IS NULL`);
+    db.exec(`UPDATE meta SET value = '3' WHERE key = 'schema_version'`);
+  }
 }
 function initializeSchema(db) {
   db.exec(`
@@ -29111,6 +29116,7 @@ function initializeSchema(db) {
 
     CREATE TABLE IF NOT EXISTS agents (
       id           TEXT PRIMARY KEY,
+      first_seen   INTEGER NOT NULL,
       last_seen    INTEGER NOT NULL,
       current_task TEXT REFERENCES tasks(id) ON DELETE SET NULL
     );
@@ -29383,7 +29389,7 @@ Always note:
 
 Creating subtasks:
 \`\`\`bash
-aitasks create --title "Write unit tests for auth" --desc "Add unit tests covering all auth edge cases" --ac "All tests pass" --ac "Coverage \u2265 90%" --parent TASK-001 --priority high --type chore
+aitasks create --title "Write unit tests for auth" --desc "Add unit tests covering all auth edge cases" --ac "All tests pass" --ac "Coverage \u2265 90%" --parent TASK-001 --priority high --type chore --agent $AITASKS_AGENT_ID
 \`\`\`
 
 If you discover your task is blocked by something:
@@ -29420,12 +29426,13 @@ ${reviewRequired ? `3. Submit for review \u2014 you CANNOT mark done directly:
    \`\`\`bash
    aitasks review TASK-001 --agent $AITASKS_AGENT_ID
    \`\`\`
-   **STOP HERE. Do not run \`aitasks done\` yourself.** The system will block self-approval.
+   **Do not run \`aitasks done\` yourself.** The system will block self-approval.
 
-4. **IMMEDIATELY spawn a review sub-agent with a DIFFERENT agent ID** to inspect the implementation.
-   The review sub-agent must first register itself, then approve or reject:
+4. **IN THIS SAME SESSION, immediately spawn a review sub-agent** with a DIFFERENT agent ID.
+   Do this NOW \u2014 before writing any summary, before moving to any other task, before anything else.
+   The review sub-agent must register first, then inspect and approve or reject:
    \`\`\`bash
-   # Review sub-agent registers itself
+   # Review sub-agent registers itself (BEFORE the review was submitted \u2014 or it will be blocked)
    aitasks heartbeat --agent <review-agent-id>
 
    # Approve (moves task to done):
@@ -29434,12 +29441,15 @@ ${reviewRequired ? `3. Submit for review \u2014 you CANNOT mark done directly:
    # OR reject (sends task back to in_progress with feedback):
    aitasks reject TASK-001 --reason "<specific feedback>" --agent <review-agent-id>
    \`\`\`
-   The task is still incomplete until the review agent approves it.
-   **The system will block approval from any agent that has not registered or that submitted the review itself.**
+   **Your session is NOT complete after submitting for review. You must remain active and drive the
+   review to completion. The task is still incomplete until \`aitasks done\` succeeds.**
+   The system will block approval from any agent that registered after the review was submitted
+   or that submitted the review itself.
 
 5. If rejected: address the feedback, re-check criteria, and repeat from step 3.
 
-> The task is only done when \`aitasks done\` completes successfully. \`review\` status means awaiting approval \u2014 it is not done.` : `3. Mark done (will FAIL if any criterion is unchecked):
+> The task is only done when \`aitasks done\` completes successfully. \`review\` status means
+> awaiting approval \u2014 it is NOT done. Do not write a final summary until all tasks are \`done\`.` : `3. Mark done (will FAIL if any criterion is unchecked):
    \`\`\`bash
    aitasks done TASK-001 --agent $AITASKS_AGENT_ID
    \`\`\`
@@ -29483,10 +29493,29 @@ aitasks unclaim TASK-001 --agent $AITASKS_AGENT_ID --reason "Blocked on missing
 5. Add implementation notes continuously, not just at the end.
 6. If a task needs splitting, create subtasks BEFORE marking parent done.
 7. Your evidence strings must be concrete and verifiable \u2014 not vague affirmations.
-8. Always provide --desc and at least one --ac when creating a task. Both are required.${reviewRequired ? `
-9. NEVER move a task to done directly. Always submit for review first with \`aitasks review\`, then IMMEDIATELY spawn a review sub-agent with a DIFFERENT agent ID. Do NOT call \`aitasks done\` yourself after submitting for review \u2014 the system blocks self-approval.` : ""}
+8. Always provide --desc, at least one --ac, and --agent when creating a task. All three are required.${reviewRequired ? `
+9. NEVER move a task to done directly. Always submit for review first with \`aitasks review\`, then IMMEDIATELY spawn a review sub-agent with a DIFFERENT agent ID in the SAME session. Do NOT call \`aitasks done\` yourself after submitting for review \u2014 the system blocks self-approval.
+10. **Do not end your session or write a final summary until every task you worked on is in \`done\` status.** If any task is in \`review\`, you must spawn the review sub-agent NOW in this session. Submitting for review and stopping is an incomplete session.` : ""}
 
----
+${reviewRequired ? `---
+
+### Before Ending Your Session
+
+**Run this check before writing any final summary or concluding your work:**
+
+\`\`\`bash
+aitasks list --json   # Check that ALL your tasks are in done status
+\`\`\`
+
+- Any task in \`done\` \u2192 \u2713 complete
+- Any task in \`review\` \u2192 you MUST spawn a review sub-agent NOW in this session before stopping
+- Any task in \`in_progress\` \u2192 continue implementation
+
+**You are NOT finished until \`aitasks list\` shows every task you worked on as \`done\`.**
+Submitting tasks for review and then stopping is an incomplete session. The review sub-agent
+must be spawned and must approve the task in this same session.
+
+` : ""}---
 
 ### Quick Reference
 
@@ -29496,7 +29525,7 @@ aitasks list [--status <s>] [--json]        List tasks
 aitasks show <id>                           Full task detail (includes time tracking)
 aitasks search <query>                      Search titles, descriptions, notes
 aitasks deps <id>                           Show dependency tree
-aitasks create --title <t> --desc <d> --ac <c> [--ac <c> ...]   Create a task
+aitasks create --title <t> --desc <d> --ac <c> [--ac <c> ...] --agent <id>   Create a task
 aitasks claim <id...> --agent <id>          Claim task(s) - supports patterns like TASK-0*
 aitasks start <id...> --agent <id>          Begin work on task(s)
 aitasks note <id> <text> --agent <id>       Add implementation note
@@ -30323,7 +30352,7 @@ function createTask(data) {
     now,
     JSON.stringify(data.metadata ?? {})
   ]);
-  logEvent({ task_id: id, event_type: "created", payload: { title: data.title } });
+  logEvent({ task_id: id, agent_id: data.created_by, event_type: "created", payload: { title: data.title } });
   return getTask(id);
 }
 var JSON_FIELDS = new Set([
@@ -30409,9 +30438,9 @@ function claimTask(taskId, agentId) {
       error: `Task is blocked by: ${task.blocked_by.join(", ")}. Complete those first.`
     };
   }
-  db.run(`INSERT INTO agents (id, last_seen, current_task)
-     VALUES (?, ?, ?)
-     ON CONFLICT(id) DO UPDATE SET last_seen = excluded.last_seen, current_task = excluded.current_task`, [agentId, Date.now(), taskId]);
+  db.run(`INSERT INTO agents (id, first_seen, last_seen, current_task)
+     VALUES (?, ?, ?, ?)
+     ON CONFLICT(id) DO UPDATE SET last_seen = excluded.last_seen, current_task = excluded.current_task`, [agentId, Date.now(), Date.now(), taskId]);
   const updated = updateTask(taskId, { assigned_to: agentId, status: "ready" });
   logEvent({ task_id: taskId, agent_id: agentId, event_type: "claimed", payload: {} });
   return { task: updated };
@@ -30427,9 +30456,9 @@ function startTask(taskId, agentId) {
   }
   const db = getDb();
   if (!task.assigned_to) {
-    db.run(`INSERT INTO agents (id, last_seen, current_task)
-       VALUES (?, ?, ?)
-       ON CONFLICT(id) DO UPDATE SET last_seen = excluded.last_seen, current_task = excluded.current_task`, [agentId, Date.now(), taskId]);
+    db.run(`INSERT INTO agents (id, first_seen, last_seen, current_task)
+       VALUES (?, ?, ?, ?)
+       ON CONFLICT(id) DO UPDATE SET last_seen = excluded.last_seen, current_task = excluded.current_task`, [agentId, Date.now(), Date.now(), taskId]);
   }
   const updated = updateTask(taskId, {
     assigned_to: agentId,
@@ -30481,14 +30510,18 @@ function completeTask(taskId, agentId) {
 ` + `  A separate review sub-agent must run: aitasks done ${taskId} --agent <review-agent-id>`
       };
     }
-    const knownAgent = db.query(`SELECT id FROM agents WHERE id = ?`).get(agentId);
-    if (!knownAgent) {
-      return {
-        task: null,
-        error: `Unknown review agent: '${agentId}' has not registered with the system.
-` + `  A real review sub-agent must register first by running any aitasks command
-` + `  (e.g. aitasks heartbeat --agent ${agentId}) before it can approve a review.`
-      };
+    if (agentId) {
+      const reviewerRow = db.query(`SELECT first_seen FROM agents WHERE id = ?`).get(agentId);
+      const reviewSubmittedAt = reviewEvent?.created_at ?? 0;
+      if (!reviewerRow || reviewerRow.first_seen > reviewSubmittedAt) {
+        return {
+          task: null,
+          error: `Review agent '${agentId}' was not active before this review was submitted.
+` + `  A real review sub-agent must be independently spawned \u2014 it cannot be registered
+` + `  moments before approving. The reviewer must have prior activity in the system
+` + `  before the review was submitted.`
+        };
+      }
     }
   }
   const updated = updateTask(taskId, { status: "done", completed_at: Date.now() });
@@ -30509,7 +30542,8 @@ function completeTask(taskId, agentId) {
       });
     }
   }
-  db.run(`UPDATE agents SET current_task = NULL WHERE id = ?`, [agentId]);
+  if (agentId)
+    db.run(`UPDATE agents SET current_task = NULL WHERE id = ?`, [agentId]);
   return { task: updated };
 }
 function blockTask(taskId, blockerIds, agentId) {
@@ -30621,9 +30655,9 @@ function unclaimTask(taskId, agentId, reason) {
 }
 function heartbeat(agentId, taskId) {
   const db = getDb();
-  db.run(`INSERT INTO agents (id, last_seen, current_task)
-     VALUES (?, ?, ?)
-     ON CONFLICT(id) DO UPDATE SET last_seen = excluded.last_seen`, [agentId, Date.now(), taskId ?? null]);
+  db.run(`INSERT INTO agents (id, first_seen, last_seen, current_task)
+     VALUES (?, ?, ?, ?)
+     ON CONFLICT(id) DO UPDATE SET last_seen = excluded.last_seen`, [agentId, Date.now(), Date.now(), taskId ?? null]);
 }
 function listAgents() {
   const db = getDb();
@@ -30721,7 +30755,7 @@ function exitError(msg, json) {
 }
 
 // src/commands/create.ts
-var createCommand2 = new Command("create").description("Create a new task").option("-t, --title <title>", "Task title").option("-d, --desc <description>", "Task description").option("-a, --ac <criterion>", "Acceptance criterion (repeatable)", collect, []).option("-p, --priority <priority>", "Priority: critical|high|medium|low", "medium").option("--type <type>", "Type: feature|bug|chore|spike", "feature").option("--parent <taskId>", "Parent task ID for subtasks").option("--json", "Output as JSON").action(async (opts) => {
+var createCommand2 = new Command("create").description("Create a new task").option("-t, --title <title>", "Task title").option("-d, --desc <description>", "Task description").option("-a, --ac <criterion>", "Acceptance criterion (repeatable)", collect, []).option("-p, --priority <priority>", "Priority: critical|high|medium|low", "medium").option("--type <type>", "Type: feature|bug|chore|spike", "feature").option("--parent <taskId>", "Parent task ID for subtasks").option("--agent <agentId>", "Agent ID creating this task (or set AITASKS_AGENT_ID)").option("--json", "Output as JSON").action(async (opts) => {
   requireInitialized();
   const json = isJsonMode(opts.json);
   if (opts.title) {
@@ -30746,13 +30780,15 @@ var createCommand2 = new Command("create").description("Create a new task").opti
         process.exit(1);
       }
     }
+    const aid = agentId(opts.agent) ?? undefined;
     const task2 = createTask({
       title: opts.title,
       description: opts.desc ?? "",
       acceptance_criteria: opts.ac,
       priority: opts.priority,
       type: opts.type,
-      parent_id: opts.parent
+      parent_id: opts.parent,
+      created_by: aid
     });
     if (json)
       return jsonOut(true, task2);
@@ -41226,7 +41262,7 @@ var checkCommand = new Command("check").description("Verify an acceptance criter
 var doneCommand = new Command("done").description("Mark task(s) as complete (all acceptance criteria must be verified) - supports patterns").argument("<taskId...>", "Task ID(s) - can specify multiple or use patterns (e.g., TASK-00*)").option("--agent <agentId>", "Agent ID (or set AITASKS_AGENT_ID)").option("--json", "Output as JSON").action((taskIds, opts) => {
   requireInitialized();
   const json = isJsonMode(opts.json);
-  const agent = requireAgentId(opts.agent, "done");
+  const agent = opts.agent ?? process.env.AITASKS_AGENT_ID;
   const allTaskIds = listTasks().map((t) => t.id);
   const resolvedIds = resolveTaskIds(taskIds.map((id) => id.toUpperCase()), allTaskIds);
   if (resolvedIds.length === 0) {
@@ -43318,4 +43354,4 @@ program2.parseAsync(process.argv).catch((err) => {
   process.exit(1);
 });
 
-//# debugId=62CCA2B3357C2C9A64756E2164756E21
+//# debugId=1AD83EE12EE8B53364756E2164756E21

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "aitasks",
-  "version": "1.3.3",
+  "version": "1.3.5",
   "description": "CLI task management tool built for AI agents",
   "type": "module",
   "bin": {