aios-core 4.0.0 → 4.0.2

package/packages/installer/src/wizard/ide-config-generator.js

@@ -506,7 +506,7 @@ async function generateIDEConfigs(selectedIDEs, wizardState, options = {}) {
           }
         }
 
-        // For Claude Code, also copy .claude/rules folder
+        // For Claude Code, also copy .claude/rules folder, hooks, and settings
         if (ideKey === 'claude-code') {
           spinner.start('Copying Claude Code rules...');
           const rulesFiles = await copyClaudeRulesFolder(projectRoot);
@@ -517,6 +517,27 @@ async function generateIDEConfigs(selectedIDEs, wizardState, options = {}) {
           } else {
             spinner.info('No rule files to copy');
           }
+
+          // BUG-3 fix (INS-1): Copy .claude/hooks/ folder (SYNAPSE engine + precompact)
+          spinner.start('Copying Claude Code hooks...');
+          const hookFiles = await copyClaudeHooksFolder(projectRoot);
+          createdFiles.push(...hookFiles);
+          if (hookFiles.length > 0) {
+            createdFolders.push(path.join(projectRoot, '.claude', 'hooks'));
+            spinner.succeed(`Copied ${hookFiles.length} hook file(s) to .claude/hooks`);
+          } else {
+            spinner.info('No hook files to copy (SYNAPSE hooks not found in source)');
+          }
+
+          // BUG-4 fix (INS-1): Create .claude/settings.local.json with hook registration
+          spinner.start('Configuring Claude Code settings...');
+          const settingsFile = await createClaudeSettingsLocal(projectRoot);
+          if (settingsFile) {
+            createdFiles.push(settingsFile);
+            spinner.succeed('Created .claude/settings.local.json with SYNAPSE hook');
+          } else {
+            spinner.info('Skipped settings.local.json (no hooks to register)');
+          }
         }
 
       } catch (error) {
@@ -581,6 +602,128 @@ function showSuccessSummary(result) {
   console.log('  4. Use * commands to interact with agents\n');
 }
 
+/**
+ * BUG-3 fix (INS-1): Copy .claude/hooks/ folder during installation
+ * Only copies JS hooks that work without external dependencies (Python, etc.)
+ * @param {string} projectRoot - Project root directory
+ * @returns {Promise<string[]>} List of copied files
+ */
+async function copyClaudeHooksFolder(projectRoot) {
+  const sourceDir = path.join(__dirname, '..', '..', '..', '..', '.claude', 'hooks');
+  const targetDir = path.join(projectRoot, '.claude', 'hooks');
+  const copiedFiles = [];
+
+  if (!await fs.pathExists(sourceDir)) {
+    return copiedFiles;
+  }
+
+  // QA-C2 fix: Guard source === dest (framework-dev mode)
+  if (path.resolve(sourceDir) === path.resolve(targetDir)) {
+    return copiedFiles;
+  }
+
+  await fs.ensureDir(targetDir);
+
+  // Only copy JS hooks that work standalone (no Python/shell deps)
+  const HOOKS_TO_COPY = [
+    'synapse-engine.js',
+    'precompact-session-digest.js',
+    'README.md',
+  ];
+
+  const files = await fs.readdir(sourceDir);
+
+  for (const file of files) {
+    if (!HOOKS_TO_COPY.includes(file)) {
+      continue;
+    }
+
+    const sourcePath = path.join(sourceDir, file);
+    const targetPath = path.join(targetDir, file);
+
+    const stat = await fs.stat(sourcePath);
+    if (stat.isFile()) {
+      await fs.copy(sourcePath, targetPath);
+      copiedFiles.push(targetPath);
+    }
+  }
+
+  return copiedFiles;
+}
+
+/**
+ * BUG-4 fix (INS-1): Create .claude/settings.local.json with hook registration
+ * Creates or merges hook entries into settings.local.json
+ * @param {string} projectRoot - Project root directory
+ * @returns {Promise<string|null>} Path to created/updated file, or null if skipped
+ */
+async function createClaudeSettingsLocal(projectRoot) {
+  const settingsPath = path.join(projectRoot, '.claude', 'settings.local.json');
+  const hookFile = path.join(projectRoot, '.claude', 'hooks', 'synapse-engine.js');
+
+  // Only create if the hook file was actually copied
+  if (!await fs.pathExists(hookFile)) {
+    return null;
+  }
+
+  // QA-C1 fix: Use correct Claude Code nested hook format
+  // Format: { hooks: [{ type, command }] } not flat { type, command }
+  const hookWrapper = {
+    hooks: [
+      {
+        type: 'command',
+        command: 'node ".claude/hooks/synapse-engine.js"',
+      },
+    ],
+  };
+
+  let settings = {};
+
+  // Merge with existing settings if present
+  if (await fs.pathExists(settingsPath)) {
+    try {
+      const existing = await fs.readFile(settingsPath, 'utf8');
+      settings = JSON.parse(existing);
+    } catch (parseError) {
+      // Corrupted file — log and overwrite with fresh settings
+      console.error(`   ⚠️  Could not parse ${settingsPath}: ${parseError.message}`);
+      settings = {};
+    }
+  }
+
+  // Ensure hooks.UserPromptSubmit structure exists
+  if (!settings.hooks) {
+    settings.hooks = {};
+  }
+  if (!Array.isArray(settings.hooks.UserPromptSubmit)) {
+    settings.hooks.UserPromptSubmit = [];
+  }
+
+  // Check if synapse hook is already registered (supports both nested and flat formats)
+  const alreadyRegistered = settings.hooks.UserPromptSubmit.some(entry => {
+    // Nested format: entry.hooks[].command
+    if (Array.isArray(entry.hooks)) {
+      return entry.hooks.some(h => h.command && h.command.includes('synapse-engine.js'));
+    }
+    // Flat format (legacy): entry.command
+    return entry.command && entry.command.includes('synapse-engine.js');
+  });
+
+  if (!alreadyRegistered) {
+    settings.hooks.UserPromptSubmit.push(hookWrapper);
+  }
+
+  try {
+    await fs.ensureDir(path.dirname(settingsPath));
+    await fs.writeFile(settingsPath, JSON.stringify(settings, null, 2), 'utf8');
+  } catch (writeError) {
+    console.error(`   ⚠️  Failed to write ${settingsPath}: ${writeError.message}`);
+    return null;
+  }
+
+  return settingsPath;
+}
+
 module.exports = {
   generateIDEConfigs,
   showSuccessSummary,
@@ -589,4 +732,6 @@ module.exports = {
   backupFile,
   promptFileExists,
   generateTemplateVariables,
+  copyClaudeHooksFolder,
+  createClaudeSettingsLocal,
 };

package/packages/installer/src/wizard/index.js

@@ -384,40 +384,57 @@ async function runWizard(options = {}) {
             const targetPresetDir = path.join(process.cwd(), '.aios-core', 'data', 'tech-presets');
             await fse.ensureDir(targetPresetDir);
 
-            // Copy the selected preset
-            await fse.copy(
-              presetFile,
-              path.join(targetPresetDir, `${answers.selectedTechPreset}.md`),
-            );
-
-            // Copy the template too
-            const templateFile = path.join(sourcePresetDir, '_template.md');
-            if (fse.existsSync(templateFile)) {
-              await fse.copy(templateFile, path.join(targetPresetDir, '_template.md'));
-            }
-
-            // Update technical-preferences.md to mark the selected preset
-            const techPrefsFile = path.join(
-              process.cwd(),
-              '.aios-core',
-              'data',
-              'technical-preferences.md',
-            );
-            const techPrefsSource = path.join(sourcePresetDir, '..', 'technical-preferences.md');
+            // BUG-5 fix (INS-1): Guard against source === dest (e.g., running inside aios-core repo)
+            const targetPresetFile = path.join(targetPresetDir, `${answers.selectedTechPreset}.md`);
+            const sourceResolved = path.resolve(presetFile);
+            const targetResolved = path.resolve(targetPresetFile);
 
-            if (fse.existsSync(techPrefsSource)) {
-              let techPrefsContent = await fse.readFile(techPrefsSource, 'utf8');
-
-              // Add active preset marker
-              const activePresetSection = `\n## Active Preset\n\n**Selected:** \`${answers.selectedTechPreset}\`\n\nThis preset was selected during installation. The @architect and @dev agents will use these patterns by default.\n`;
-
-              // Insert after the first heading
-              techPrefsContent = techPrefsContent.replace(
-                '# User-Defined Preferred Patterns and Preferences',
-                '# User-Defined Preferred Patterns and Preferences' + activePresetSection,
+            if (sourceResolved === targetResolved) {
+              console.log('   ℹ️  Tech preset already in place (framework-dev mode)');
+            } else {
+              // Copy the selected preset
+              await fse.copy(presetFile, targetPresetFile);
+
+              // Copy the template too
+              const templateFile = path.join(sourcePresetDir, '_template.md');
+              if (fse.existsSync(templateFile)) {
+                const targetTemplate = path.join(targetPresetDir, '_template.md');
+                if (path.resolve(templateFile) !== path.resolve(targetTemplate)) {
+                  await fse.copy(templateFile, targetTemplate);
+                }
+              }
+
+              // Update technical-preferences.md to mark the selected preset
+              const techPrefsFile = path.join(
+                process.cwd(),
+                '.aios-core',
+                'data',
+                'technical-preferences.md',
               );
-
-              await fse.writeFile(techPrefsFile, techPrefsContent, 'utf8');
+              const techPrefsSource = path.join(sourcePresetDir, '..', 'technical-preferences.md');
+
+              if (fse.existsSync(techPrefsSource)) {
+                const techPrefsSourceResolved = path.resolve(techPrefsSource);
+                const techPrefsTargetResolved = path.resolve(techPrefsFile);
+
+                if (techPrefsSourceResolved !== techPrefsTargetResolved) {
+                  // Prefer existing target file to preserve user customizations
+                  const baseFile = fse.existsSync(techPrefsFile) ? techPrefsFile : techPrefsSource;
+                  let techPrefsContent = await fse.readFile(baseFile, 'utf8');
+
+                  // Add active preset marker only if not already present
+                  const activePresetSection = `\n## Active Preset\n\n**Selected:** \`${answers.selectedTechPreset}\`\n\nThis preset was selected during installation. The @architect and @dev agents will use these patterns by default.\n`;
+
+                  if (!techPrefsContent.includes('## Active Preset')) {
+                    // Insert after the first heading
+                    techPrefsContent = techPrefsContent.replace(
+                      '# User-Defined Preferred Patterns and Preferences',
+                      '# User-Defined Preferred Patterns and Preferences' + activePresetSection,
+                    );
+                    await fse.writeFile(techPrefsFile, techPrefsContent, 'utf8');
+                  }
+                }
+              }
             }
 
             console.log(`   ✅ Tech Preset: ${answers.selectedTechPreset}`);