aidevops 3.5.541 → 3.5.544

package/VERSION

@@ -1 +1 @@
-3.5.541
+3.5.544

package/aidevops.sh

@@ -3,7 +3,7 @@
 # AI DevOps Framework CLI
 # Usage: aidevops <command> [options]
 #
-# Version: 3.5.541
+# Version: 3.5.544
 
 set -euo pipefail
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "aidevops",
-  "version": "3.5.541",
+  "version": "3.5.544",
   "description": "AI DevOps Framework - AI-assisted development workflows, code quality, and deployment automation",
   "type": "module",
   "bin": {

package/setup-modules/core.sh

@@ -536,51 +536,132 @@ check_requirements() {
 
 # Check for quality/linting tools (shellcheck, shfmt, markdownlint)
 # These are optional but recommended for development
-check_quality_tools() {
-	print_info "Checking quality tools..."
-
-	local missing_tools=()
-	local missing_npm_tools=()
-
-	# Check for shellcheck
-	if command -v shellcheck >/dev/null 2>&1; then
-		print_success "shellcheck: $(shellcheck --version | head -1)"
+_check_quality_tool() {
+	local tool_name="$1"
+	local version=""
+
+	if command -v "$tool_name" >/dev/null 2>&1; then
+		case "$tool_name" in
+		shellcheck)
+			version=$(shellcheck --version 2>/dev/null | head -1)
+			;;
+		shfmt)
+			version=$(shfmt --version 2>/dev/null)
+			;;
+		esac
+		print_success "$tool_name: ${version:-installed}"
 	else
-		missing_tools+=("shellcheck")
+		missing_tools+=("$tool_name")
 	fi
 
-	# Check for shfmt
-	if command -v shfmt >/dev/null 2>&1; then
-		print_success "shfmt: $(shfmt --version)"
-	else
-		missing_tools+=("shfmt")
-	fi
+	return 0
+}
+
+_check_markdownlint_tool() {
+	local version=""
 
-	# Check for markdownlint (accept either CLI variant)
 	if command -v markdownlint >/dev/null 2>&1; then
-		print_success "markdownlint: $(markdownlint --version 2>/dev/null | head -1)"
-	elif command -v markdownlint-cli2 >/dev/null 2>&1; then
-		print_success "markdownlint-cli2: $(markdownlint-cli2 --version 2>/dev/null | head -1)"
-	else
-		missing_npm_tools+=("markdownlint-cli2")
+		version=$(markdownlint --version 2>/dev/null | head -1)
+		print_success "markdownlint: ${version:-installed}"
+		return 0
 	fi
 
-	# If all tools present, return early
-	if [[ ${#missing_tools[@]} -eq 0 && ${#missing_npm_tools[@]} -eq 0 ]]; then
-		print_success "All quality tools installed"
+	if command -v markdownlint-cli2 >/dev/null 2>&1; then
+		version=$(markdownlint-cli2 --version 2>/dev/null | head -1)
+		print_success "markdownlint-cli2: ${version:-installed}"
 		return 0
 	fi
 
-	# Show missing tools
+	missing_npm_tools+=("markdownlint-cli2")
+	return 0
+}
+
+_report_missing_quality_tools() {
 	if [[ ${#missing_tools[@]} -gt 0 ]]; then
 		print_warning "Missing quality tools: ${missing_tools[*]}"
 	fi
+
 	if [[ ${#missing_npm_tools[@]} -gt 0 ]]; then
 		print_warning "Missing npm quality tools: ${missing_npm_tools[*]}"
 	fi
+
 	print_info "These tools are used by linters-local.sh for code quality checks"
+	return 0
+}
+
+_install_missing_quality_tools() {
+	local pkg_manager="$1"
+	local install_quality="Y"
+
+	if [[ "$pkg_manager" == "unknown" ]]; then
+		print_info "Install manually:"
+		echo "  macOS: brew install ${missing_tools[*]}"
+		echo "  Ubuntu/Debian: sudo apt-get install ${missing_tools[*]}"
+		echo "  Fedora: sudo dnf install ${missing_tools[*]}"
+		return 0
+	fi
+
+	echo ""
+	setup_prompt install_quality "Install quality tools using $pkg_manager? [Y/n]: " "Y"
+
+	if [[ "$install_quality" =~ ^[Yy]?$ ]]; then
+		print_info "Installing ${missing_tools[*]}..."
+		if install_packages "$pkg_manager" "${missing_tools[@]}"; then
+			print_success "Quality tools installed successfully"
+		else
+			print_warning "Failed to install some quality tools - continuing anyway"
+		fi
+	else
+		print_info "Skipped quality tools installation"
+		print_info "Install later: $pkg_manager install ${missing_tools[*]}"
+	fi
+
+	return 0
+}
+
+_install_missing_npm_quality_tools() {
+	local install_npm_quality="Y"
+
+	if ! command -v npm >/dev/null 2>&1; then
+		print_warning "npm not found; cannot auto-install ${missing_npm_tools[*]}"
+		print_info "Install Node.js/npm, then run: npm install -g ${missing_npm_tools[*]}"
+		return 0
+	fi
+
+	echo ""
+	setup_prompt install_npm_quality "Install npm quality tools (npm install -g ${missing_npm_tools[*]})? [Y/n]: " "Y"
+	if [[ "$install_npm_quality" =~ ^[Yy]?$ ]]; then
+		print_info "Installing npm quality tools: ${missing_npm_tools[*]}..."
+		if npm install -g "${missing_npm_tools[@]}" >/dev/null 2>&1; then
+			print_success "npm quality tools installed successfully"
+		else
+			print_warning "Failed to install npm quality tools - continuing anyway"
+		fi
+	else
+		print_info "Skipped npm quality tools installation"
+		print_info "Install later: npm install -g ${missing_npm_tools[*]}"
+	fi
+
+	return 0
+}
+
+check_quality_tools() {
+	print_info "Checking quality tools..."
+
+	local missing_tools=()
+	local missing_npm_tools=()
+
+	_check_quality_tool "shellcheck"
+	_check_quality_tool "shfmt"
+	_check_markdownlint_tool
+
+	if [[ ${#missing_tools[@]} -eq 0 && ${#missing_npm_tools[@]} -eq 0 ]]; then
+		print_success "All quality tools installed"
+		return 0
+	fi
+
+	_report_missing_quality_tools
 
-	# In non-interactive mode, just warn and continue
 	if [[ "$NON_INTERACTIVE" == "true" ]]; then
 		if [[ ${#missing_tools[@]} -gt 0 ]]; then
 			print_info "Install later: brew install ${missing_tools[*]}"
@@ -599,49 +680,12 @@ check_quality_tools() {
 	local pkg_manager
 	pkg_manager=$(detect_package_manager)
 
-	if [[ "$pkg_manager" == "unknown" && ${#missing_tools[@]} -gt 0 ]]; then
-		print_info "Install manually:"
-		echo "  macOS: brew install ${missing_tools[*]}"
-		echo "  Ubuntu/Debian: sudo apt-get install ${missing_tools[*]}"
-		echo "  Fedora: sudo dnf install ${missing_tools[*]}"
-	elif [[ ${#missing_tools[@]} -gt 0 ]]; then
-		local install_quality="Y"
-		echo ""
-		setup_prompt install_quality "Install quality tools using $pkg_manager? [Y/n]: " "Y"
-
-		if [[ "$install_quality" =~ ^[Yy]?$ ]]; then
-			print_info "Installing ${missing_tools[*]}..."
-			if install_packages "$pkg_manager" "${missing_tools[@]}"; then
-				print_success "Quality tools installed successfully"
-			else
-				print_warning "Failed to install some quality tools - continuing anyway"
-			fi
-		else
-			print_info "Skipped quality tools installation"
-			print_info "Install later: $pkg_manager install ${missing_tools[*]}"
-		fi
+	if [[ ${#missing_tools[@]} -gt 0 ]]; then
+		_install_missing_quality_tools "$pkg_manager"
 	fi
 
 	if [[ ${#missing_npm_tools[@]} -gt 0 ]]; then
-		if ! command -v npm >/dev/null 2>&1; then
-			print_warning "npm not found; cannot auto-install ${missing_npm_tools[*]}"
-			print_info "Install Node.js/npm, then run: npm install -g ${missing_npm_tools[*]}"
-		else
-			local install_npm_quality="Y"
-			echo ""
-			setup_prompt install_npm_quality "Install npm quality tools (npm install -g ${missing_npm_tools[*]})? [Y/n]: " "Y"
-			if [[ "$install_npm_quality" =~ ^[Yy]?$ ]]; then
-				print_info "Installing npm quality tools: ${missing_npm_tools[*]}..."
-				if npm install -g "${missing_npm_tools[@]}" >/dev/null 2>&1; then
-					print_success "npm quality tools installed successfully"
-				else
-					print_warning "Failed to install npm quality tools - continuing anyway"
-				fi
-			else
-				print_info "Skipped npm quality tools installation"
-				print_info "Install later: npm install -g ${missing_npm_tools[*]}"
-			fi
-		fi
+		_install_missing_npm_quality_tools
 	fi
 
 	return 0

package/setup-modules/schedulers.sh

@@ -215,13 +215,11 @@ setup_supervisor_pulse() {
 	return 0
 }
 
-# Install supervisor pulse via launchd (macOS)
-_install_pulse_launchd() {
+# Clean up old/legacy pulse launchd plists before reinstalling.
+# Args: $1=pulse_label, $2=pulse_plist path
+_cleanup_old_pulse_plists() {
 	local pulse_label="$1"
-	local wrapper_script="$2"
-	local opencode_bin="$3"
-	local _pulse_installed="$4"
-	local pulse_plist="$HOME/Library/LaunchAgents/${pulse_label}.plist"
+	local pulse_plist="$2"
 
 	# Unload old plist if upgrading
 	if _launchd_has_agent "$pulse_label"; then
@@ -235,21 +233,18 @@ _install_pulse_launchd() {
 		launchctl unload "$old_plist" || true
 		rm -f "$old_plist"
 	fi
+	return 0
+}
 
-	# XML-escape paths for safe plist embedding (prevents injection
-	# if $HOME or paths contain &, <, > characters)
-	local _xml_wrapper_script _xml_home _xml_opencode_bin _xml_pulse_dir _xml_path
+# Build XML environment variable fragment for headless model overrides.
+# Reads configured overrides and emits XML key/string pairs for plist embedding.
+# Prints the XML fragment to stdout (may be empty if no overrides configured).
+_build_pulse_headless_env_xml() {
 	local _headless_xml_env=""
 	local _configured_headless_models _configured_pulse_model
 	_configured_headless_models=$(_resolve_headless_models_override)
 	_configured_pulse_model=$(_resolve_pulse_model_override)
-	_xml_wrapper_script=$(_xml_escape "$wrapper_script")
-	_xml_home=$(_xml_escape "$HOME")
-	_xml_opencode_bin=$(_xml_escape "$opencode_bin")
-	# Use neutral workspace path for PULSE_DIR so supervisor sessions
-	# are not associated with any specific managed repo (GH#5136).
-	_xml_pulse_dir=$(_xml_escape "${HOME}/.aidevops/.agent-workspace")
-	_xml_path=$(_xml_escape "$PATH")
+
 	if [[ -n "$_configured_headless_models" ]]; then
 		local _xml_headless_models
 		_xml_headless_models=$(_xml_escape "$_configured_headless_models")
@@ -275,8 +270,33 @@ _install_pulse_launchd() {
 		_headless_xml_env+=$'\t\t'"<string>${_xml_headless_allowlist}</string>"
 	fi
 
-	# Write the plist (always regenerated to pick up config changes)
-	cat >"$pulse_plist" <<PLIST
+	printf '%s' "$_headless_xml_env"
+	return 0
+}
+
+# Generate the full pulse launchd plist XML content.
+# Args: $1=pulse_label, $2=wrapper_script, $3=opencode_bin
+# Prints the complete plist XML to stdout.
+_generate_pulse_plist_content() {
+	local pulse_label="$1"
+	local wrapper_script="$2"
+	local opencode_bin="$3"
+
+	# XML-escape paths for safe plist embedding (prevents injection
+	# if $HOME or paths contain &, <, > characters)
+	local _xml_wrapper_script _xml_home _xml_opencode_bin _xml_pulse_dir _xml_path
+	_xml_wrapper_script=$(_xml_escape "$wrapper_script")
+	_xml_home=$(_xml_escape "$HOME")
+	_xml_opencode_bin=$(_xml_escape "$opencode_bin")
+	# Use neutral workspace path for PULSE_DIR so supervisor sessions
+	# are not associated with any specific managed repo (GH#5136).
+	_xml_pulse_dir=$(_xml_escape "${HOME}/.aidevops/.agent-workspace")
+	_xml_path=$(_xml_escape "$PATH")
+
+	local _headless_xml_env
+	_headless_xml_env=$(_build_pulse_headless_env_xml)
+
+	cat <<PLIST
 <?xml version="1.0" encoding="UTF-8"?>
 <!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
 <plist version="1.0">
@@ -315,6 +335,21 @@ _install_pulse_launchd() {
 </dict>
 </plist>
 PLIST
+	return 0
+}
+
+# Install supervisor pulse via launchd (macOS)
+_install_pulse_launchd() {
+	local pulse_label="$1"
+	local wrapper_script="$2"
+	local opencode_bin="$3"
+	local _pulse_installed="$4"
+	local pulse_plist="$HOME/Library/LaunchAgents/${pulse_label}.plist"
+
+	_cleanup_old_pulse_plists "$pulse_label" "$pulse_plist"
+
+	# Write the plist (always regenerated to pick up config changes)
+	_generate_pulse_plist_content "$pulse_label" "$wrapper_script" "$opencode_bin" >"$pulse_plist"
 
 	if launchctl load "$pulse_plist"; then
 		if [[ "$_pulse_installed" == "true" ]]; then

package/setup.sh

@@ -10,7 +10,7 @@ shopt -s inherit_errexit 2>/dev/null || true
 # AI Assistant Server Access Framework Setup Script
 # Helps developers set up the framework for their infrastructure
 #
-# Version: 3.5.541
+# Version: 3.5.544
 #
 # Quick Install:
 #   npm install -g aidevops && aidevops update          (recommended)
@@ -500,32 +500,24 @@ create_backup_with_rotation() {
 	local backup_name="$2"
 	local backup_base="$HOME/.aidevops/${backup_name}-backups"
 	local backup_dir
-	local backup_target
 	backup_dir="$backup_base/$(date +%Y%m%d_%H%M%S)"
-	backup_target="$backup_dir/$(basename "$source_path")"
 
 	# Create backup directory
 	mkdir -p "$backup_dir"
 
-	# Copy source to backup
+	# Copy source to backup (tolerant of broken symlinks / missing entries)
 	if [[ -d "$source_path" ]]; then
-		mkdir -p "$backup_target"
-		if command -v rsync >/dev/null 2>&1; then
-			local rsync_status=0
-			if rsync -a "$source_path/" "$backup_target/"; then
-				rsync_status=0
-			else
-				rsync_status=$?
-			fi
-
-			if [[ "$rsync_status" -eq 24 ]]; then
-				print_warning "Backup completed with missing source entries skipped: $source_path"
-			elif [[ "$rsync_status" -ne 0 ]]; then
-				print_error "Backup failed for $source_path (rsync exit $rsync_status)"
-				return "$rsync_status"
+		if command -v rsync >/dev/null 2>&1 && rsync --help 2>&1 | grep -q -- '--ignore-missing-args'; then
+			# rsync >= 3.1.0: --ignore-missing-args skips missing/broken entries gracefully
+			if ! rsync -a --ignore-missing-args "$source_path/" "$backup_dir/$(basename "$source_path")/" 2>/dev/null; then
+				print_warning "Backup had partial failures (broken symlinks?), continuing"
 			fi
 		else
-			cp -R "$source_path" "$backup_dir/"
+			# Fallback: cp -R may fail on broken symlinks under set -e,
+			# so run in a subshell that tolerates errors
+			if ! (cp -R "$source_path" "$backup_dir/" 2>/dev/null); then
+				print_warning "Backup had partial failures (broken symlinks?), continuing"
+			fi
 		fi
 	elif [[ -f "$source_path" ]]; then
 		cp "$source_path" "$backup_dir/"