aidevops 3.11.15 → 3.11.17

package/VERSION

@@ -1 +1 @@
-3.11.15
+3.11.17

package/aidevops.sh

@@ -5,7 +5,7 @@
 # AI DevOps Framework CLI
 # Usage: aidevops <command> [options]
 #
-# Version: 3.11.15
+# Version: 3.11.17
 
 set -euo pipefail
 
@@ -651,6 +651,27 @@ cmd_update() {
 		_update_check_daemon_health
 	fi
 
+	# t2914: ensure pulse is running after every update. The existing
+	# restart paths (setup.sh:1329, agent-deploy.sh:601) call
+	# pulse-lifecycle-helper.sh restart-if-running which is a silent no-op
+	# when pulse is dead — so a dead pulse stays dead through any number
+	# of subsequent updates. The 'start' subcommand is idempotent
+	# (pulse-lifecycle-helper.sh:127-131): no-op when running, starts when
+	# dead. This belt-and-braces call after the daemon health check
+	# guarantees the pulse is alive when 'aidevops update' returns,
+	# regardless of whether scripts were redeployed.
+	#
+	# Honour AIDEVOPS_SKIP_PULSE_RESTART=1 at the call site (the helper's
+	# 'start' subcommand does not check it directly — only 'restart' and
+	# 'restart-if-running' do). Non-fatal: a pulse start failure should
+	# not fail the update.
+	if [[ "${AIDEVOPS_SKIP_PULSE_RESTART:-0}" != "1" ]]; then
+		local _pulse_helper="${HOME}/.aidevops/agents/scripts/pulse-lifecycle-helper.sh"
+		if [[ -x "$_pulse_helper" ]]; then
+			"$_pulse_helper" start >/dev/null 2>&1 || print_warning "Pulse start failed (non-fatal)"
+		fi
+	fi
+
 	return 0
 }
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "aidevops",
-  "version": "3.11.15",
+  "version": "3.11.17",
   "description": "AI DevOps Framework - AI-assisted development workflows, code quality, and deployment automation",
   "type": "module",
   "bin": {

package/setup-modules/schedulers.sh

@@ -1684,6 +1684,121 @@ setup_contribution_watch() {
 	return 0
 }
 
+# Install complexity scan via launchd (macOS).
+# Args: $1=label, $2=script path, $3=log dir
+# (t2903) Extracted from pulse dispatch preflight — independent schedule so
+# the 200-470s scan never starves dispatch or downstream scanners.
+_install_complexity_scan_launchd() {
+	local cs_label="$1"
+	local cs_script="$2"
+	local _cs_log_dir="$3"
+	local cs_plist="$HOME/Library/LaunchAgents/${cs_label}.plist"
+
+	local _xml_cs_script _xml_cs_home _xml_cs_log_dir
+	_xml_cs_script=$(_xml_escape "$cs_script")
+	_xml_cs_home=$(_xml_escape "$HOME")
+	_xml_cs_log_dir=$(_xml_escape "$_cs_log_dir")
+
+	local cs_plist_content
+	cs_plist_content=$(
+		cat <<CS_PLIST
+<?xml version="1.0" encoding="UTF-8"?>
+<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
+<plist version="1.0">
+<dict>
+	<key>Label</key>
+	<string>${cs_label}</string>
+	<key>ProgramArguments</key>
+	<array>
+		<string>$(_xml_escape "$(_resolve_modern_bash)")</string>
+		<string>${_xml_cs_script}</string>
+		<string>run</string>
+	</array>
+	<key>StartInterval</key>
+	<integer>3600</integer>
+	<key>StandardOutPath</key>
+	<string>${_xml_cs_log_dir}/complexity-scan-runner.log</string>
+	<key>StandardErrorPath</key>
+	<string>${_xml_cs_log_dir}/complexity-scan-runner.log</string>
+	<key>EnvironmentVariables</key>
+	<dict>
+		<key>PATH</key>
+		<string>/opt/homebrew/bin:/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin</string>
+		<key>HOME</key>
+		<string>${_xml_cs_home}</string>
+	</dict>
+	<key>RunAtLoad</key>
+	<true/>
+	<key>KeepAlive</key>
+	<false/>
+	<key>ProcessType</key>
+	<string>Background</string>
+	<key>LowPriorityBackgroundIO</key>
+	<true/>
+	<key>Nice</key>
+	<integer>10</integer>
+</dict>
+</plist>
+CS_PLIST
+	)
+
+	if _launchd_install_if_changed "$cs_label" "$cs_plist" "$cs_plist_content"; then
+		print_info "Complexity scan enabled (launchd, hourly run)"
+	else
+		print_warning "Failed to load complexity scan LaunchAgent"
+	fi
+	return 0
+}
+
+# Install complexity scan via systemd or cron (Linux).
+# Args: $1=script path, $2=log dir
+_install_complexity_scan_linux() {
+	local cs_script="$1"
+	local _cs_log_dir="$2"
+	local cs_systemd="aidevops-complexity-scan"
+	_install_scheduler_linux \
+		"$cs_systemd" \
+		"aidevops: complexity-scan" \
+		"$CRON_HOURLY" \
+		"\"${cs_script}\" run" \
+		"3600" \
+		"${_cs_log_dir}/complexity-scan-runner.log" \
+		"" \
+		"Complexity scan enabled (hourly run)" \
+		"Failed to install complexity scan scheduler" \
+		"true" \
+		"true"
+	return 0
+}
+
+# Setup complexity scan (t2903) — extracts the weekly complexity scan from
+# pulse dispatch preflight into its own launchd/cron schedule. The scan was
+# observed consuming 200-470s per pulse cycle (26%+ of the 1800s pulse stale
+# ceiling), starving downstream scanners. Promoting it to its own schedule
+# decouples it from dispatch entirely. The runner reuses run_weekly_complexity_scan
+# from pulse-simplification.sh, which has internal 15-min cadence gating
+# (COMPLEXITY_SCAN_INTERVAL=900) so hourly launchd ticks are always safe.
+setup_complexity_scan() {
+	local cs_script="$HOME/.aidevops/agents/scripts/complexity-scan-runner.sh"
+	local cs_label="sh.aidevops.complexity-scan"
+	if ! [[ -x "$cs_script" ]]; then
+		return 0
+	fi
+
+	# Reuse contribution-watch's log-dir resolver (same logic, same config key).
+	local _cs_log_dir
+	_cs_log_dir=$(_resolve_cw_log_dir) || return 1
+	mkdir -p "$_cs_log_dir"
+
+	# Install/update scheduled runner
+	if [[ "$(uname -s)" == "Darwin" ]]; then
+		_install_complexity_scan_launchd "$cs_label" "$cs_script" "$_cs_log_dir"
+	else
+		_install_complexity_scan_linux "$cs_script" "$_cs_log_dir"
+	fi
+	return 0
+}
+
 # Setup draft responses — private repo + local draft storage for reviewing
 # AI-drafted replies to external contributions (t1555).
 # Respects config: aidevops config set orchestration.draft_responses false

package/setup.sh

@@ -12,7 +12,7 @@ shopt -s inherit_errexit 2>/dev/null || true
 # AI Assistant Server Access Framework Setup Script
 # Helps developers set up the framework for their infrastructure
 #
-# Version: 3.11.15
+# Version: 3.11.17
 #
 # Quick Install:
 #   npm install -g aidevops && aidevops update          (recommended)
@@ -1159,6 +1159,63 @@ _setup_run_interactive() {
 }
 
 # Post-setup steps: schedulers, final instructions, optional tool update check.
+# Non-interactive scheduler installation. Extracted from
+# `_setup_post_setup_steps` (t2903) to keep the parent under the
+# function-complexity gate threshold. Each `_should_setup_noninteractive_*`
+# guard returns 0 when the corresponding scheduler is already installed
+# (regenerate on update) or first-time install is consented via config.
+_setup_noninteractive_schedulers() {
+	local os="$1"
+
+	# Auto-update handles non-interactive internally (systemd detection fixed in GH#17861)
+	setup_auto_update
+	if _should_setup_noninteractive_supervisor_pulse; then
+		setup_supervisor_pulse "$os"
+	fi
+	# Regenerate other schedulers if already installed (GH#17695 Finding B).
+	# Stats wrapper is a pulse dependency — also install on first run when
+	# the supervisor pulse is consented (t2418, GH#20016).
+	if _should_setup_noninteractive_stats_wrapper; then
+		setup_stats_wrapper "${PULSE_ENABLED:-}"
+	fi
+	if _should_setup_noninteractive_scheduler "Failure miner" "sh.aidevops.routine-gh-failure-miner" "aidevops: gh-failure-miner" "aidevops-gh-failure-miner"; then
+		setup_failure_miner "${PULSE_ENABLED:-}"
+	fi
+	if _should_setup_noninteractive_scheduler "Process guard" "sh.aidevops.process-guard" "aidevops: process-guard" "aidevops-process-guard"; then
+		setup_process_guard
+	fi
+	if _should_setup_noninteractive_scheduler "Memory pressure" "sh.aidevops.memory-pressure-monitor" "aidevops: memory-pressure-monitor" "aidevops-memory-pressure-monitor"; then
+		setup_memory_pressure_monitor
+	fi
+	if _should_setup_noninteractive_scheduler "Screen time" "sh.aidevops.screen-time-snapshot" "aidevops: screen-time-snapshot" "aidevops-screen-time-snapshot"; then
+		setup_screen_time_snapshot
+	fi
+	if _should_setup_noninteractive_scheduler "Contribution watch" "sh.aidevops.contribution-watch" "aidevops: contribution-watch" "aidevops-contribution-watch"; then
+		setup_contribution_watch
+	fi
+	# t2903 (#21049): complexity scan — extracted from pulse dispatch preflight
+	if _should_setup_noninteractive_scheduler "Complexity scan" "sh.aidevops.complexity-scan" "aidevops: complexity-scan" "aidevops-complexity-scan"; then
+		setup_complexity_scan
+	fi
+	# Repo sync handles non-interactive mode internally (systemd detection fixed in GH#17861)
+	setup_repo_sync
+	# r914 repo-aidevops-health — daily drift keeper (t2366)
+	setup_repo_aidevops_health
+	if _should_setup_noninteractive_scheduler "Profile README" "sh.aidevops.profile-readme-update" "aidevops: profile-readme-update" "aidevops-profile-readme-update"; then
+		setup_profile_readme
+	fi
+	if _should_setup_noninteractive_scheduler "OAuth token refresh" "sh.aidevops.token-refresh" "aidevops: token-refresh" "aidevops-token-refresh"; then
+		setup_oauth_token_refresh
+	fi
+	# opencode DB maintenance (r913, t2183). Helper self-noops on missing
+	# DB — safe to install unconditionally in non-interactive mode too.
+	setup_opencode_db_maintenance
+	# Migrate cron entries to systemd after schedulers are installed (GH#17695 Finding D)
+	migrate_cron_to_systemd
+	setup_tabby
+	return 0
+}
+
 _setup_post_setup_steps() {
 	local os="$1"
 
@@ -1184,48 +1241,7 @@ _setup_post_setup_steps() {
 	# Exceptions: regenerate existing schedulers (GH#17381, GH#17695 Finding B)
 	# and allow first-time install when config consent is explicitly true (GH#17403).
 	if [[ "$NON_INTERACTIVE" == "true" ]]; then
-		# Auto-update handles non-interactive internally (systemd detection fixed in GH#17861)
-		setup_auto_update
-		if _should_setup_noninteractive_supervisor_pulse; then
-			setup_supervisor_pulse "$os"
-		fi
-		# Regenerate other schedulers if already installed (GH#17695 Finding B).
-		# Stats wrapper is a pulse dependency — also install on first run when
-		# the supervisor pulse is consented (t2418, GH#20016).
-		if _should_setup_noninteractive_stats_wrapper; then
-			setup_stats_wrapper "${PULSE_ENABLED:-}"
-		fi
-		if _should_setup_noninteractive_scheduler "Failure miner" "sh.aidevops.routine-gh-failure-miner" "aidevops: gh-failure-miner" "aidevops-gh-failure-miner"; then
-			setup_failure_miner "${PULSE_ENABLED:-}"
-		fi
-		if _should_setup_noninteractive_scheduler "Process guard" "sh.aidevops.process-guard" "aidevops: process-guard" "aidevops-process-guard"; then
-			setup_process_guard
-		fi
-		if _should_setup_noninteractive_scheduler "Memory pressure" "sh.aidevops.memory-pressure-monitor" "aidevops: memory-pressure-monitor" "aidevops-memory-pressure-monitor"; then
-			setup_memory_pressure_monitor
-		fi
-		if _should_setup_noninteractive_scheduler "Screen time" "sh.aidevops.screen-time-snapshot" "aidevops: screen-time-snapshot" "aidevops-screen-time-snapshot"; then
-			setup_screen_time_snapshot
-		fi
-		if _should_setup_noninteractive_scheduler "Contribution watch" "sh.aidevops.contribution-watch" "aidevops: contribution-watch" "aidevops-contribution-watch"; then
-			setup_contribution_watch
-		fi
-		# Repo sync handles non-interactive mode internally (systemd detection fixed in GH#17861)
-		setup_repo_sync
-		# r914 repo-aidevops-health — daily drift keeper (t2366)
-		setup_repo_aidevops_health
-		if _should_setup_noninteractive_scheduler "Profile README" "sh.aidevops.profile-readme-update" "aidevops: profile-readme-update" "aidevops-profile-readme-update"; then
-			setup_profile_readme
-		fi
-		if _should_setup_noninteractive_scheduler "OAuth token refresh" "sh.aidevops.token-refresh" "aidevops: token-refresh" "aidevops-token-refresh"; then
-			setup_oauth_token_refresh
-		fi
-		# opencode DB maintenance (r913, t2183). Helper self-noops on missing
-		# DB — safe to install unconditionally in non-interactive mode too.
-		setup_opencode_db_maintenance
-		# Migrate cron entries to systemd after schedulers are installed (GH#17695 Finding D)
-		migrate_cron_to_systemd
-		setup_tabby
+		_setup_noninteractive_schedulers "$os"
 		return 0
 	fi
 
@@ -1241,6 +1257,7 @@ _setup_post_setup_steps() {
 	setup_memory_pressure_monitor
 	setup_screen_time_snapshot
 	setup_contribution_watch
+	setup_complexity_scan
 	setup_draft_responses
 	setup_profile_readme
 	setup_oauth_token_refresh