aidevops 3.11.13 → 3.11.15

package/VERSION

@@ -1 +1 @@
-3.11.13
+3.11.15

package/aidevops.sh

@@ -5,7 +5,7 @@
 # AI DevOps Framework CLI
 # Usage: aidevops <command> [options]
 #
-# Version: 3.11.13
+# Version: 3.11.15
 
 set -euo pipefail
 
@@ -639,6 +639,58 @@ cmd_update() {
 	_update_check_tools
 	_update_sweep_opencode_symlinks
 
+	# t2898: When invoked interactively (terminal stdin AND not from the
+	# auto-update daemon itself, which sets AIDEVOPS_AUTO_UPDATE=1 in its
+	# environment), verify the daemon is healthy and warn if not. The
+	# advisory file gets picked up by the next session greeting so the
+	# user sees the warning even if they miss this output.
+	#
+	# Skip in headless / CI runs (no stdin, no TTY) to avoid spurious
+	# warnings in setup.sh-driven flows that already do their own check.
+	if [[ -t 0 ]] && [[ -z "${AIDEVOPS_AUTO_UPDATE:-}" ]] && [[ "${NON_INTERACTIVE:-false}" != "true" ]]; then
+		_update_check_daemon_health
+	fi
+
+	return 0
+}
+
+# t2898: post-update daemon health verification (interactive only).
+# Side effect: writes ~/.aidevops/advisories/daemon-disabled.advisory when
+# the daemon is unhealthy so the session greeting surfaces the warning.
+# Cleared (file removed) when the daemon recovers.
+_update_check_daemon_health() {
+	local helper="$HOME/.aidevops/agents/scripts/auto-update-helper.sh"
+	[[ -x "$helper" ]] || return 0
+	local advisory_dir="$HOME/.aidevops/advisories"
+	local advisory_file="$advisory_dir/daemon-disabled.advisory"
+
+	local hc_rc=0
+	"$helper" health-check --quiet >/dev/null 2>&1 || hc_rc=$?
+
+	if [[ "$hc_rc" -eq 0 ]]; then
+		# Healthy — clear any stale advisory.
+		[[ -f "$advisory_file" ]] && rm -f "$advisory_file"
+		return 0
+	fi
+
+	# Unhealthy — warn on stderr and write advisory.
+	mkdir -p "$advisory_dir" 2>/dev/null || return 0
+	local fix_cmd="aidevops auto-update enable"
+	[[ "$hc_rc" -eq 1 ]] && fix_cmd="aidevops auto-update check"
+	cat >"$advisory_file" <<EOF
+auto-update daemon is not running normally on this runner. Without it, this
+runner falls behind the fleet and may dispatch workers that fail because of
+bugs already fixed upstream. See cross-runner-coordination.md §4.4.
+
+Diagnose: aidevops auto-update health-check
+Fix:      ${fix_cmd}
+EOF
+
+	if [[ "$hc_rc" -eq 1 ]]; then
+		print_warning "Auto-update daemon is stalled. Fix: ${fix_cmd}"
+	else
+		print_warning "Auto-update daemon is not running. Fix: ${fix_cmd}"
+	fi
 	return 0
 }
 # Uninstall helpers (extracted for complexity reduction)

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "aidevops",
-  "version": "3.11.13",
+  "version": "3.11.15",
   "description": "AI DevOps Framework - AI-assisted development workflows, code quality, and deployment automation",
   "type": "module",
   "bin": {

package/setup-modules/post-setup.sh

@@ -32,6 +32,28 @@ setup_auto_update() {
 		"aidevops-auto-update"; then
 		_auto_update_installed=true
 	fi
+	# t2898: ALWAYS run idempotent re-install + health-check after the
+	# detection above, so every release self-heals broken installs (daemon
+	# unloaded by an OS update, scrubbed by a cron cleanup, etc.). The
+	# detection helper already handled the "freshly install if missing"
+	# interactive prompt; this loop ensures that even when the detection
+	# said "yes installed" the daemon is actually loaded right now and
+	# running on schedule.
+	if [[ "$_auto_update_installed" == "true" ]]; then
+		# Idempotent: no-op when daemon already loaded; re-installs only on drift.
+		bash "$auto_update_script" enable --idempotent >/dev/null 2>&1 || true
+		# Verify it's actually healthy. Surface any degradation so the
+		# operator sees it on every release deploy.
+		local _hc_rc=0
+		bash "$auto_update_script" health-check --quiet >/dev/null 2>&1 || _hc_rc=$?
+		if [[ "$_hc_rc" -eq 0 ]]; then
+			:
+		elif [[ "$_hc_rc" -eq 1 ]]; then
+			print_warning "Auto-update daemon installed but stalled — run: aidevops auto-update check"
+		elif [[ "$_hc_rc" -eq 2 ]]; then
+			print_warning "Auto-update daemon not loaded — run: aidevops auto-update enable"
+		fi
+	fi
 	if [[ "$_auto_update_installed" == "false" ]]; then
 		if [[ "$NON_INTERACTIVE" == "true" ]]; then
 			# Non-interactive: enable silently

package/setup-modules/schedulers.sh

@@ -683,10 +683,16 @@ _install_pulse_launchd() {
 	local _pulse_installed="$4"
 	local pulse_plist="$HOME/Library/LaunchAgents/${pulse_label}.plist"
 
-	_cleanup_old_pulse_plists "$pulse_label" "$pulse_plist"
-
-	# Write the plist (always regenerated to pick up config changes)
-	_generate_pulse_plist_content "$pulse_label" "$wrapper_script" "$opencode_bin" >"$pulse_plist"
+	# Capture plist content before touching the existing file.
+	# This avoids the "unload old, then write fails" window that leaves a 0-byte plist.
+	local pulse_plist_content
+	pulse_plist_content=$(_generate_pulse_plist_content "$pulse_label" "$wrapper_script" "$opencode_bin")
+
+	# Defensive: if generation produced empty content, refuse to touch the existing plist.
+	if [[ -z "$pulse_plist_content" ]]; then
+		print_warning "Pulse plist generation produced empty content — leaving existing plist untouched"
+		return 1
+	fi
 
 	# Resolve interval for the user-facing message (matches what the plist contains).
 	local _interval_sec _interval_label
@@ -697,8 +703,10 @@ _install_pulse_launchd() {
 		_interval_label="${_interval_sec}s"
 	fi
 
+	# _launchd_install_if_changed handles unload-before-replace only when content
+	# has changed, and writes atomically via tmp+rename (see setup.sh).
 	# shell-portability: ignore next — _install_pulse_launchd is macOS-only (launchd)
-	if launchctl load "$pulse_plist"; then
+	if _launchd_install_if_changed "$pulse_label" "$pulse_plist" "$pulse_plist_content"; then
 		if [[ "$_pulse_installed" == "true" ]]; then
 			print_info "Supervisor pulse updated (launchd config regenerated, every ${_interval_label})"
 		else

package/setup.sh

@@ -12,7 +12,7 @@ shopt -s inherit_errexit 2>/dev/null || true
 # AI Assistant Server Access Framework Setup Script
 # Helps developers set up the framework for their infrastructure
 #
-# Version: 3.11.13
+# Version: 3.11.15
 #
 # Quick Install:
 #   npm install -g aidevops && aidevops update          (recommended)
@@ -241,8 +241,20 @@ _launchd_install_if_changed() {
 		fi
 	fi
 
-	# Write new plist and load
-	printf '%s\n' "$new_content" >"$plist_path"
+	# Atomic write: build at sibling tmp path, then rename into place.
+	# If printf is killed mid-write, the destination is untouched.
+	local tmp_plist="${plist_path}.tmp.$$"
+	if ! printf '%s\n' "$new_content" >"$tmp_plist"; then
+		rm -f "$tmp_plist"
+		return 1
+	fi
+	# Defensive: refuse to install an empty file (should be guaranteed by the
+	# caller's content check, but guard here too).
+	if [[ ! -s "$tmp_plist" ]]; then
+		rm -f "$tmp_plist"
+		return 1
+	fi
+	mv -f "$tmp_plist" "$plist_path"
 	launchctl load "$plist_path" 2>/dev/null || return 1
 	return 0
 }