aidevops 3.0.11 → 3.1.0

package/VERSION

@@ -1 +1 @@
-3.0.11
+3.1.0

package/aidevops.sh

@@ -3,7 +3,7 @@
 # AI DevOps Framework CLI
 # Usage: aidevops <command> [options]
 #
-# Version: 3.0.11
+# Version: 3.1.0
 
 set -euo pipefail
 
@@ -102,6 +102,14 @@ check_file() {
 	[[ -f "$1" ]]
 }
 
+# Ensure file ends with a trailing newline (prevents malformed appends)
+ensure_trailing_newline() {
+	local file="$1"
+	local last
+	last="$(tail -c 1 "$file"; printf x)"
+	[[ -s "$file" ]] && [[ "$last" != $'\n'x ]] && printf '\n' >>"$file"
+}
+
 # Initialize repos.json if it doesn't exist
 init_repos_file() {
 	if [[ ! -f "$REPOS_FILE" ]]; then
@@ -1936,7 +1944,7 @@ SOPSEOF
 		# Add runtime artifact ignores
 		if ! grep -q "^\.agents/loop-state/" "$gitignore" 2>/dev/null; then
 			# Ensure trailing newline before appending (prevents malformed entries like *.zip.agents/loop-state/)
-			[[ -s "$gitignore" && $(tail -c1 "$gitignore" | wc -l) -eq 0 ]] && printf '\n' >>"$gitignore"
+			ensure_trailing_newline "$gitignore"
 			{
 				echo ""
 				echo "# aidevops runtime artifacts"
@@ -1958,7 +1966,7 @@ SOPSEOF
 				print_info "Untracked .aidevops.json from git (was committed by older version)"
 			fi
 			# Ensure trailing newline before appending
-			[[ -s "$gitignore" && $(tail -c1 "$gitignore" | wc -l) -eq 0 ]] && printf '\n' >>"$gitignore"
+			ensure_trailing_newline "$gitignore"
 			echo ".aidevops.json" >>"$gitignore"
 			gitignore_updated=true
 		fi
@@ -1967,7 +1975,7 @@ SOPSEOF
 		if [[ "$enable_beads" == "true" ]]; then
 			if ! grep -q "^\.beads$" "$gitignore" 2>/dev/null; then
 				# Ensure trailing newline before appending
-				[[ -s "$gitignore" && $(tail -c1 "$gitignore" | wc -l) -eq 0 ]] && printf '\n' >>"$gitignore"
+				ensure_trailing_newline "$gitignore"
 				echo ".beads" >>"$gitignore"
 				print_success "Added .beads to .gitignore"
 				gitignore_updated=true

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "aidevops",
-  "version": "3.0.11",
+  "version": "3.1.0",
   "description": "AI DevOps Framework - AI-assisted development workflows, code quality, and deployment automation",
   "type": "module",
   "bin": {

package/setup-modules/migrations.sh

@@ -37,6 +37,22 @@ cleanup_deprecated_paths() {
 		"$agents_dir/youtube"
 		# osgrep removed — disproportionate CPU/disk cost vs rg + LLM comprehension
 		"$agents_dir/tools/context/osgrep.md"
+		# GH#5155: scripts archived upstream but orphaned in deployed installs
+		# (rsync only adds/overwrites, doesn't delete removed files)
+		"$agents_dir/scripts/pattern-tracker-helper.sh"
+		"$agents_dir/scripts/quality-sweep-helper.sh"
+		"$agents_dir/scripts/quality-loop-helper.sh"
+		"$agents_dir/scripts/review-pulse-helper.sh"
+		"$agents_dir/scripts/self-improve-helper.sh"
+		"$agents_dir/scripts/coderabbit-pulse-helper.sh"
+		"$agents_dir/scripts/coderabbit-task-creator-helper.sh"
+		"$agents_dir/scripts/audit-task-creator-helper.sh"
+		"$agents_dir/scripts/batch-cleanup-helper.sh"
+		"$agents_dir/scripts/coordinator-helper.sh"
+		"$agents_dir/scripts/finding-to-task-helper.sh"
+		"$agents_dir/scripts/objective-runner-helper.sh"
+		"$agents_dir/scripts/ralph-loop-helper.sh"
+		"$agents_dir/scripts/stale-pr-helper.sh"
 	)
 
 	for path in "${deprecated_paths[@]}"; do
@@ -963,3 +979,88 @@ migrate_pulse_repos_to_repos_json() {
 
 	return 0
 }
+
+# Migrate orphaned supervisor-helper.sh and supervisor/ modules (GH#5147)
+# After the supervisor-to-pulse-wrapper migration (PR #2291, PR #2475), the
+# upstream repo moved supervisor files to supervisor-archived/. But aidevops
+# update (rsync) only adds/overwrites — it doesn't delete files that no longer
+# exist in the source. Users who installed before the migration retain:
+#   - ~/.aidevops/agents/scripts/supervisor-helper.sh (old entry point)
+#   - ~/.aidevops/agents/scripts/supervisor/ (old module directory)
+#   - cron/launchd entries invoking supervisor-helper.sh pulse
+# These orphaned files shadow the new pulse-wrapper.sh architecture.
+# This migration removes the orphaned files and rewrites scheduler entries.
+migrate_orphaned_supervisor() {
+	local agents_dir="$HOME/.aidevops/agents"
+	local scripts_dir="$agents_dir/scripts"
+	local cleaned=0
+
+	# 1. Remove orphaned supervisor-helper.sh from deployed scripts
+	#    The canonical location is now supervisor-archived/supervisor-helper.sh
+	#    (shipped for reference/tests only, not as an active entry point)
+	if [[ -f "$scripts_dir/supervisor-helper.sh" ]]; then
+		rm -f "$scripts_dir/supervisor-helper.sh"
+		print_info "Removed orphaned supervisor-helper.sh from deployed scripts"
+		((++cleaned))
+	fi
+
+	# 2. Remove orphaned supervisor/ module directory
+	#    The canonical location is now supervisor-archived/ (shipped by rsync)
+	#    Only remove if it's the old modules dir (contains pulse.sh, dispatch.sh, etc.)
+	#    Do NOT remove supervisor-archived/ — that's the intentional archive
+	if [[ -d "$scripts_dir/supervisor" && ! -L "$scripts_dir/supervisor" ]]; then
+		# Verify it's the old module directory (not something user-created)
+		if [[ -f "$scripts_dir/supervisor/pulse.sh" ]] ||
+			[[ -f "$scripts_dir/supervisor/dispatch.sh" ]] ||
+			[[ -f "$scripts_dir/supervisor/_common.sh" ]]; then
+			rm -rf "$scripts_dir/supervisor"
+			print_info "Removed orphaned supervisor/ module directory from deployed scripts"
+			((++cleaned))
+		fi
+	fi
+
+	# 3. Migrate cron entries from supervisor-helper.sh to pulse-wrapper.sh
+	#    Old pattern: */2 * * * * ... supervisor-helper.sh pulse ...
+	#    New pattern: already installed by setup.sh's pulse section
+	#    Strategy: remove old entries; setup.sh will install the new one if pulse is enabled
+	local current_crontab
+	current_crontab=$(crontab -l 2>/dev/null) || current_crontab=""
+	if echo "$current_crontab" | grep -qF "supervisor-helper.sh"; then
+		# Remove all cron lines referencing supervisor-helper.sh
+		local new_crontab
+		new_crontab=$(echo "$current_crontab" | grep -v "supervisor-helper.sh")
+		if [[ -n "$new_crontab" ]]; then
+			printf '%s\n' "$new_crontab" | crontab - || true
+		else
+			# All entries were supervisor-helper.sh — remove crontab entirely
+			crontab -r || true
+		fi
+		print_info "Removed orphaned supervisor-helper.sh cron entries"
+		print_info "  pulse-wrapper.sh will be installed by setup.sh if supervisor pulse is enabled"
+		((++cleaned))
+	fi
+
+	# 4. Migrate launchd entries from old supervisor label (macOS only)
+	#    Old label: com.aidevops.supervisor-pulse (from cron.sh/launchd.sh)
+	#    New label: com.aidevops.aidevops-supervisor-pulse (from setup.sh)
+	#    setup.sh already handles the new label cleanup at line ~1000, but
+	#    the old label from cron.sh may also be present
+	if [[ "$(uname -s)" == "Darwin" ]]; then
+		local old_label="com.aidevops.supervisor-pulse"
+		local old_plist="$HOME/Library/LaunchAgents/${old_label}.plist"
+		if _launchd_has_agent "$old_label" || [[ -f "$old_plist" ]]; then
+			# Use launchctl remove by label — works even when the plist file is
+			# missing (orphaned agent loaded without a backing file on disk)
+			launchctl remove "$old_label" || true
+			rm -f "$old_plist"
+			print_info "Removed orphaned supervisor-pulse LaunchAgent ($old_label)"
+			((++cleaned))
+		fi
+	fi
+
+	if [[ $cleaned -gt 0 ]]; then
+		print_success "Cleaned up $cleaned orphaned supervisor artifact(s) — pulse-wrapper.sh is the active system"
+	fi
+
+	return 0
+}

package/setup-modules/tool-install.sh

@@ -57,7 +57,7 @@ setup_git_clis() {
 					echo "📋 Next steps - authenticate each CLI:"
 					for pkg in "${missing_packages[@]}"; do
 						case "$pkg" in
-						gh) echo "  • gh auth login" ;;
+						gh) echo "  • gh auth login -s workflow  (workflow scope required for CI PRs)" ;;
 						glab) echo "  • glab auth login" ;;
 						esac
 					done

package/setup.sh

@@ -10,7 +10,7 @@ shopt -s inherit_errexit 2>/dev/null || true
 # AI Assistant Server Access Framework Setup Script
 # Helps developers set up the framework for their infrastructure
 #
-# Version: 3.0.11
+# Version: 3.1.0
 #
 # Quick Install:
 #   npm install -g aidevops && aidevops update          (recommended)
@@ -716,6 +716,7 @@ main() {
 		migrate_mcp_env_to_credentials
 		migrate_pulse_repos_to_repos_json
 		cleanup_deprecated_paths
+		migrate_orphaned_supervisor
 		cleanup_deprecated_mcps
 		cleanup_stale_bun_opencode
 		validate_opencode_config
@@ -795,6 +796,7 @@ main() {
 		confirm_step "Migrate mcp-env.sh -> credentials.sh" && migrate_mcp_env_to_credentials
 		confirm_step "Migrate pulse-repos.json into repos.json" && migrate_pulse_repos_to_repos_json
 		confirm_step "Cleanup deprecated agent paths" && cleanup_deprecated_paths
+		confirm_step "Migrate orphaned supervisor to pulse-wrapper" && migrate_orphaned_supervisor
 		confirm_step "Cleanup deprecated MCP entries (hetzner, serper, etc.)" && cleanup_deprecated_mcps
 		confirm_step "Cleanup stale bun opencode install" && cleanup_stale_bun_opencode
 		confirm_step "Validate and repair OpenCode config schema" && validate_opencode_config
@@ -892,10 +894,6 @@ main() {
 	#   - Non-interactive: only installs if config explicitly says true
 	local wrapper_script="$HOME/.aidevops/agents/scripts/pulse-wrapper.sh"
 	local pulse_label="com.aidevops.aidevops-supervisor-pulse"
-	local _aidevops_dir _pulse_repo_dir
-	_aidevops_dir="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
-	_pulse_repo_dir=$(_resolve_main_worktree_dir "$_aidevops_dir")
-
 	# Read explicit user consent from config.jsonc (not merged defaults).
 	# Empty = user never configured this; "true"/"false" = explicit choice.
 	local _pulse_user_config=""
@@ -1009,12 +1007,14 @@ main() {
 
 			# XML-escape paths for safe plist embedding (prevents injection
 			# if $HOME or paths contain &, <, > characters)
-			local _xml_wrapper_script _xml_home _xml_opencode_bin _xml_aidevops_dir _xml_path
+			local _xml_wrapper_script _xml_home _xml_opencode_bin _xml_pulse_dir _xml_path
 			local _headless_xml_env=""
 			_xml_wrapper_script=$(_xml_escape "$wrapper_script")
 			_xml_home=$(_xml_escape "$HOME")
 			_xml_opencode_bin=$(_xml_escape "$opencode_bin")
-			_xml_aidevops_dir=$(_xml_escape "$_pulse_repo_dir")
+			# Use neutral workspace path for PULSE_DIR so supervisor sessions
+			# are not associated with any specific managed repo (GH#5136).
+			_xml_pulse_dir=$(_xml_escape "${HOME}/.aidevops/.agent-workspace")
 			_xml_path=$(_xml_escape "$PATH")
 			if [[ -n "${AIDEVOPS_HEADLESS_MODELS:-}" ]]; then
 				local _xml_headless_models
@@ -1061,7 +1061,7 @@ main() {
 		<key>OPENCODE_BIN</key>
 		<string>${_xml_opencode_bin}</string>
 		<key>PULSE_DIR</key>
-		<string>${_xml_aidevops_dir}</string>
+		<string>${_xml_pulse_dir}</string>
 		<key>PULSE_STALE_THRESHOLD</key>
 		<string>1800</string>
 		${_headless_xml_env}
@@ -1092,8 +1092,9 @@ PLIST
 			# PATH= here, it overrides the global line and breaks nvm/bun/cargo.
 			# OPENCODE_BIN removed — resolved from PATH at runtime via command -v.
 			# See #4099 and #4240 for history.
-			local _cron_aidevops_dir _cron_wrapper_script _cron_headless_env=""
-			_cron_aidevops_dir=$(_cron_escape "$_pulse_repo_dir")
+			local _cron_pulse_dir _cron_wrapper_script _cron_headless_env=""
+			# Use neutral workspace path for PULSE_DIR (GH#5136)
+			_cron_pulse_dir=$(_cron_escape "${HOME}/.aidevops/.agent-workspace")
 			_cron_wrapper_script=$(_cron_escape "$wrapper_script")
 			if [[ -n "${AIDEVOPS_HEADLESS_MODELS:-}" ]]; then
 				local _cron_headless_models
@@ -1107,7 +1108,7 @@ PLIST
 			fi
 			(
 				crontab -l 2>/dev/null | grep -v 'aidevops: supervisor-pulse'
-				echo "*/2 * * * * PULSE_DIR=${_cron_aidevops_dir}${_cron_headless_env} /bin/bash ${_cron_wrapper_script} >> \"\$HOME/.aidevops/logs/pulse-wrapper.log\" 2>&1 # aidevops: supervisor-pulse"
+				echo "*/2 * * * * PULSE_DIR=${_cron_pulse_dir}${_cron_headless_env} /bin/bash ${_cron_wrapper_script} >> \"\$HOME/.aidevops/logs/pulse-wrapper.log\" 2>&1 # aidevops: supervisor-pulse"
 			) | crontab - || true
 			if crontab -l 2>/dev/null | grep -qF "aidevops: supervisor-pulse"; then
 				print_info "Supervisor pulse enabled (cron, every 2 min). Disable: crontab -e and remove the supervisor-pulse line"