aidevops 2.172.29 → 2.172.31

package/README.md

@@ -502,7 +502,7 @@ aidevops implements proven agent design patterns identified by [Lance Martin (La
 | **Compaction Resilience** | Preserve context across compaction | OpenCode plugin injects dynamic state at compaction time |
 | **Ralph Loop** | Iterative execution until complete | `/full-loop`, `full-loop-helper.sh` |
 | **Evolve Context** | Learn from sessions | `/remember`, `/recall` with SQLite FTS5 + opt-in semantic search |
-| **Pattern Tracking** | Learn what works/fails | `/patterns` command, memory system |
+| **Pattern Tracking** | Learn what works/fails | `/patterns` command, `memory-helper.sh` |
 | **Cost-Aware Routing** | Match model to task complexity | `model-routing.md` with 5-tier guidance, `/route` command |
 | **Model Comparison** | Compare models side-by-side | `/compare-models` (live data), `/compare-models-free` (offline) |
 | **Response Scoring** | Evaluate actual model outputs | `/score-responses` with structured criteria |
@@ -756,7 +756,7 @@ Agents that learn from experience and contribute improvements:
 
 | Phase | Description |
 |-------|-------------|
-| **Review** | Analyze memory for success/failure patterns (memory system) |
+| **Review** | Analyze memory for success/failure patterns (`memory-helper.sh`) |
 | **Refine** | Generate and apply improvements to agents |
 | **Test** | Validate in isolated OpenCode sessions |
 | **PR** | Contribute to community with privacy filtering |

package/VERSION

@@ -1 +1 @@
-2.172.29
+2.172.31

package/aidevops.sh

@@ -3,7 +3,7 @@
 # AI DevOps Framework CLI
 # Usage: aidevops <command> [options]
 #
-# Version: 2.172.29
+# Version: 2.172.31
 
 set -euo pipefail
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "aidevops",
-  "version": "2.172.29",
+  "version": "2.172.31",
   "description": "AI DevOps Framework - AI-assisted development workflows, code quality, and deployment automation",
   "type": "module",
   "bin": {

package/setup-modules/core.sh

@@ -219,16 +219,28 @@ install_packages() {
 	shift
 	local packages=("$@")
 
+	# Cache sudo credentials before spinner commands.
+	# Backgrounded processes cannot safely prompt for passwords.
+	if [[ "$pkg_manager" =~ ^(apt|dnf|yum|pacman|apk)$ ]]; then
+		sudo -v
+	fi
+
 	case "$pkg_manager" in
 	brew)
 		# Run brew update with spinner (Homebrew auto-update is slow and silent)
-		run_with_spinner "Updating Homebrew" brew update
+		if ! run_with_spinner "Updating Homebrew" brew update; then
+			print_error "Homebrew update failed"
+			return 1
+		fi
 		# Install with auto-update disabled (we just ran it)
 		# Note: run_with_spinner auto-exports HOMEBREW_NO_AUTO_UPDATE for brew commands
 		run_with_spinner "Installing ${packages[*]}" brew install "${packages[@]}"
 		;;
 	apt)
-		run_with_spinner "Updating package lists" sudo apt-get update -qq
+		if ! run_with_spinner "Updating package lists" sudo apt-get update -qq; then
+			print_error "apt-get update failed"
+			return 1
+		fi
 		run_with_spinner "Installing ${packages[*]}" sudo apt-get install -y -qq "${packages[@]}"
 		;;
 	dnf)
@@ -247,6 +259,8 @@ install_packages() {
 		return 1
 		;;
 	esac
+
+	return 0
 }
 
 # Offer to install Homebrew (Linuxbrew) on Linux when brew is not available

package/setup-modules/mcp-setup.sh

@@ -68,13 +68,16 @@ install_mcp_packages() {
 		fi
 	fi
 
-	if command -v uv &>/dev/null; then
+	if command -v uv &>/dev/null && uv tool --help &>/dev/null; then
 		print_info "Installing/updating outscraper-mcp-server via uv..."
 		if command -v outscraper-mcp-server &>/dev/null; then
 			uv tool upgrade outscraper-mcp-server >/dev/null 2>&1 || true
 		else
 			uv tool install outscraper-mcp-server >/dev/null 2>&1 || print_warning "Failed to install outscraper-mcp-server"
 		fi
+	elif command -v uv &>/dev/null; then
+		print_warning "uv is installed but too old to support 'tool' subcommand — skipping outscraper-mcp-server"
+		print_info "Update uv with: curl -LsSf https://astral.sh/uv/install.sh | sh"
 	fi
 
 	# Update opencode.json with resolved full paths for all MCP binaries

package/setup-modules/migrations.sh

@@ -92,13 +92,13 @@ cleanup_osgrep() {
 	# 0. Kill running osgrep processes first (MCP servers, indexers)
 	# These are Node.js processes already loaded in memory — removing the
 	# binary and data won't stop them, and they may try to rebuild indexes.
-	if pgrep -f 'osgrep' >/dev/null 2>&1; then
+	if pgrep -f 'osgrep' >/dev/null; then
 		print_info "Killing running osgrep processes..."
-		pkill -f 'osgrep' 2>/dev/null || true
+		pkill -f 'osgrep' || true
 		# Give processes a moment to exit gracefully
 		sleep 1
 		# Force-kill any stragglers
-		pkill -9 -f 'osgrep' 2>/dev/null || true
+		pkill -9 -f 'osgrep' || true
 		cleaned=true
 	fi
 

package/setup-modules/plugins.sh

@@ -424,7 +424,7 @@ scan_imported_skills() {
 		local installed=false
 
 		# 1. uv tool install (preferred - fast, isolated, manages its own Python)
-		if [[ "$installed" == "false" ]] && command -v uv &>/dev/null; then
+		if [[ "$installed" == "false" ]] && command -v uv &>/dev/null && uv tool --help &>/dev/null; then
 			print_info "Installing Cisco Skill Scanner via uv..."
 			if run_with_spinner "Installing cisco-ai-skill-scanner" uv tool install cisco-ai-skill-scanner; then
 				print_success "Cisco Skill Scanner installed via uv"
@@ -512,7 +512,7 @@ setup_multi_tenant_credentials() {
 	# Check if there are existing credentials to migrate
 	if [[ -f "$HOME/.config/aidevops/credentials.sh" ]]; then
 		local key_count
-		key_count=$(grep -c "^export " "$HOME/.config/aidevops/credentials.sh" 2>/dev/null || echo "0")
+		key_count=$(grep -c "^export " "$HOME/.config/aidevops/credentials.sh" 2>/dev/null) || true
 		print_info "Found $key_count existing API keys in credentials.sh"
 		print_info "Multi-tenant enables managing separate credential sets for:"
 		echo "  - Multiple clients (agency/freelance work)"

package/setup-modules/shell-env.sh

@@ -29,7 +29,8 @@ detect_default_shell() {
 
 # Usage: get_shell_rc "zsh" or get_shell_rc "bash"
 get_shell_rc() {
-	local shell_name="$1"
+	local shell_name
+	shell_name="$1"
 	case "$shell_name" in
 	zsh)
 		echo "$HOME/.zshrc"
@@ -866,8 +867,9 @@ setup_terminal_title() {
 	local tabby_config="$HOME/Library/Application Support/tabby/config.yaml"
 	if [[ -f "$tabby_config" ]]; then
 		local disabled_count
-		disabled_count=$(grep -c "disableDynamicTitle: true" "$tabby_config" || echo "0")
-		if [[ "$disabled_count" -gt 0 ]]; then
+		# grep -c exits 1 on no match; || : inside subshell prevents ERR trap noise
+		disabled_count=$(grep -c "disableDynamicTitle: true" "$tabby_config" || :)
+		if [[ "${disabled_count:-0}" -gt 0 ]]; then
 			echo "  Tabby: detected, dynamic titles disabled in $disabled_count profile(s) (will fix)"
 		else
 			echo "  Tabby: detected, dynamic titles enabled"

package/setup.sh

@@ -10,7 +10,7 @@ shopt -s inherit_errexit 2>/dev/null || true
 # AI Assistant Server Access Framework Setup Script
 # Helps developers set up the framework for their infrastructure
 #
-# Version: 2.172.29
+# Version: 2.172.31
 #
 # Quick Install:
 #   npm install -g aidevops && aidevops update          (recommended)
@@ -141,12 +141,13 @@ _ensure_cron_path() {
 	current_crontab=$(crontab -l 2>/dev/null) || current_crontab=""
 
 	# Deduplicate PATH entries (preserving order)
+	# Bash 3.2 compat: no associative arrays — use string-based seen list
 	local deduped_path=""
-	local -A seen_dirs=()
+	local seen_dirs=" "
 	local IFS=':'
 	for dir in $PATH; do
-		if [[ -n "$dir" && -z "${seen_dirs[$dir]:-}" ]]; then
-			seen_dirs[$dir]=1
+		if [[ -n "$dir" && "$seen_dirs" != *" ${dir} "* ]]; then
+			seen_dirs="${seen_dirs}${dir} "
 			deduped_path="${deduped_path:+${deduped_path}:}${dir}"
 		fi
 	done
@@ -186,6 +187,46 @@ _launchd_has_agent() {
 	return $?
 }
 
+# Detect whether a scheduler is already installed via launchd or cron.
+# Optionally migrates legacy launchd labels / cron entries to launchd on macOS.
+_scheduler_detect_installed() {
+	local scheduler_name="$1"
+	local launchd_label="$2"
+	local legacy_launchd_label="$3"
+	local cron_marker="$4"
+	local migrate_script="$5"
+	local migrate_arg="$6"
+	local migrate_hint="$7"
+	local installed=false
+
+	if _launchd_has_agent "$launchd_label"; then
+		installed=true
+	elif [[ -n "$legacy_launchd_label" ]] && _launchd_has_agent "$legacy_launchd_label"; then
+		if [[ -n "$migrate_script" ]] && [[ -x "$migrate_script" ]]; then
+			if bash "$migrate_script" "$migrate_arg" >/dev/null 2>&1; then
+				print_info "$scheduler_name LaunchAgent migrated to new label"
+			else
+				print_warning "$scheduler_name label migration failed. Run: $migrate_hint"
+			fi
+		fi
+		installed=true
+	elif crontab -l 2>/dev/null | grep -qF "$cron_marker"; then
+		if [[ "$PLATFORM_MACOS" == "true" ]] && [[ -n "$migrate_script" ]] && [[ -x "$migrate_script" ]]; then
+			if bash "$migrate_script" "$migrate_arg" >/dev/null 2>&1; then
+				print_info "$scheduler_name migrated from cron to launchd"
+			else
+				print_warning "$scheduler_name cron->launchd migration failed. Run: $migrate_hint"
+			fi
+		fi
+		installed=true
+	fi
+
+	if [[ "$installed" == "true" ]]; then
+		return 0
+	fi
+
+	return 1
+}
 # Spinner for long-running operations
 # Usage: run_with_spinner "Installing package..." command arg1 arg2
 run_with_spinner() {
@@ -631,6 +672,8 @@ main() {
 	bootstrap_repo "$@"
 
 	parse_args "$@"
+	local _os
+	_os="$(uname -s)"
 
 	# Auto-detect non-interactive terminals (CI/CD, agent shells, piped stdin)
 	# Must run after parse_args so explicit --interactive flag takes precedence
@@ -798,25 +841,14 @@ main() {
 	local auto_update_script="$HOME/.aidevops/agents/scripts/auto-update-helper.sh"
 	if [[ -x "$auto_update_script" ]] && is_feature_enabled auto_update 2>/dev/null; then
 		local _auto_update_installed=false
-		if _launchd_has_agent "com.aidevops.aidevops-auto-update"; then
-			_auto_update_installed=true
-		elif _launchd_has_agent "com.aidevops.auto-update"; then
-			# Old label — re-running enable will migrate to new label
-			if bash "$auto_update_script" enable >/dev/null 2>&1; then
-				print_info "Auto-update LaunchAgent migrated to new label"
-			else
-				print_warning "Auto-update label migration failed. Run: aidevops auto-update enable"
-			fi
-			_auto_update_installed=true
-		elif crontab -l 2>/dev/null | grep -qF "aidevops-auto-update"; then
-			if [[ "$(uname -s)" == "Darwin" ]]; then
-				# macOS: cron entry exists but no launchd plist — migrate
-				if bash "$auto_update_script" enable >/dev/null 2>&1; then
-					print_info "Auto-update migrated from cron to launchd"
-				else
-					print_warning "Auto-update cron→launchd migration failed. Run: aidevops auto-update enable"
-				fi
-			fi
+		if _scheduler_detect_installed \
+			"Auto-update" \
+			"com.aidevops.aidevops-auto-update" \
+			"com.aidevops.auto-update" \
+			"aidevops-auto-update" \
+			"$auto_update_script" \
+			"enable" \
+			"aidevops auto-update enable"; then
 			_auto_update_installed=true
 		fi
 		if [[ "$_auto_update_installed" == "false" ]]; then
@@ -847,7 +879,7 @@ main() {
 	#
 	# Ensure crontab has a global PATH= line (Linux only; macOS uses launchd env).
 	# Must run before any cron entries are installed so they inherit the PATH.
-	if [[ "$(uname -s)" != "Darwin" ]]; then
+	if [[ "$_os" != "Darwin" ]]; then
 		_ensure_cron_path
 	fi
 
@@ -937,14 +969,16 @@ main() {
 	fi
 
 	# Detect if pulse is already installed (for upgrade messaging)
+	# Uses shared helper to check both launchd and cron consistently
 	local _pulse_installed=false
-	if [[ "$(uname -s)" == "Darwin" ]]; then
-		local pulse_plist="$HOME/Library/LaunchAgents/${pulse_label}.plist"
-		if _launchd_has_agent "$pulse_label"; then
-			_pulse_installed=true
-		fi
-	fi
-	if [[ "$_pulse_installed" == "false" ]] && crontab -l 2>/dev/null | grep -qF "pulse-wrapper"; then
+	if _scheduler_detect_installed \
+		"Supervisor pulse" \
+		"$pulse_label" \
+		"" \
+		"pulse-wrapper" \
+		"" \
+		"" \
+		""; then
 		_pulse_installed=true
 	fi
 
@@ -955,7 +989,7 @@ main() {
 	if [[ "$_do_install" == "true" ]]; then
 		mkdir -p "$HOME/.aidevops/logs"
 
-		if [[ "$(uname -s)" == "Darwin" ]]; then
+		if [[ "$_os" == "Darwin" ]]; then
 			# macOS: use launchd plist with wrapper
 			local pulse_plist="$HOME/Library/LaunchAgents/${pulse_label}.plist"
 
@@ -987,7 +1021,7 @@ main() {
 				_headless_xml_env+=$'\n'
 				_headless_xml_env+=$'\t\t<key>AIDEVOPS_HEADLESS_MODELS</key>'
 				_headless_xml_env+=$'\n'
-				_headless_xml_env+="\t\t<string>${_xml_headless_models}</string>"
+				_headless_xml_env+=$'\t\t'"<string>${_xml_headless_models}</string>"
 			fi
 			if [[ -n "${AIDEVOPS_HEADLESS_PROVIDER_ALLOWLIST:-}" ]]; then
 				local _xml_headless_allowlist
@@ -995,7 +1029,7 @@ main() {
 				_headless_xml_env+=$'\n'
 				_headless_xml_env+=$'\t\t<key>AIDEVOPS_HEADLESS_PROVIDER_ALLOWLIST</key>'
 				_headless_xml_env+=$'\n'
-				_headless_xml_env+="\t\t<string>${_xml_headless_allowlist}</string>"
+				_headless_xml_env+=$'\t\t'"<string>${_xml_headless_allowlist}</string>"
 			fi
 
 			# Write the plist (always regenerated to pick up config changes)
@@ -1082,7 +1116,7 @@ PLIST
 		fi
 	elif [[ "$_pulse_lower" == "false" && "$_pulse_installed" == "true" ]]; then
 		# User explicitly disabled but pulse is still installed — clean up
-		if [[ "$(uname -s)" == "Darwin" ]]; then
+		if [[ "$_os" == "Darwin" ]]; then
 			local pulse_plist="$HOME/Library/LaunchAgents/${pulse_label}.plist"
 			if _launchd_has_agent "$pulse_label"; then
 				launchctl unload "$pulse_plist" || true