aiden-shared-calculations-unified 1.0.82 → 1.0.84

package/calculations/core/platform-daily-bought-vs-sold-count.js

@@ -7,17 +7,17 @@
  * This is different from 'daily_asset_activity' because it counts
  * *positions*, not *unique users*.
  */
-const { loadInstrumentMappings } = require('../../utils/sector_mapping_provider');
+// --- STANDARD 0: REMOVED require('../../utils/sector_mapping_provider') ---
 
 
 class DailyBoughtVsSoldCount {
     constructor() {
         // We will store { [instrumentId]: { new: 0, closed: 0 } }
         this.assetActivity = new Map();
-        this.mappings = null;
+        // --- STANDARD 0: RENAMED ---
+        this.tickerMap = null;
     }
 
-    // --- NEW ---
     /**
      * Statically defines all metadata for the manifest builder.
      */
@@ -31,7 +31,6 @@ class DailyBoughtVsSoldCount {
         };
     }
 
-    // --- NEW ---
     /**
      * Statically declare dependencies.
      */
@@ -41,7 +40,6 @@ class DailyBoughtVsSoldCount {
 
     /**
      * Defines the output schema for this calculation.
-     * @returns {object} JSON Schema object
      */
     static getSchema() {
         const tickerSchema = {
@@ -93,7 +91,13 @@ class DailyBoughtVsSoldCount {
         return new Map(positions.map(p => [p.PositionID, p.InstrumentID]).filter(p => p[0] && p[1]));
     }
 
-    process(todayPortfolio, yesterdayPortfolio) {
+    // --- STANDARD 0: UPDATED SIGNATURE (added context) ---
+    process(todayPortfolio, yesterdayPortfolio, userId, context) {
+        // --- STANDARD 0: ADDED ---
+        if (!this.tickerMap) {
+             this.tickerMap = context.instrumentToTicker;
+        }
+
         if (!todayPortfolio || !yesterdayPortfolio) {
             return;
         }
@@ -119,13 +123,17 @@ class DailyBoughtVsSoldCount {
     }
 
     async getResult() {
-        if (!this.mappings) {
-            this.mappings = await loadInstrumentMappings();
+        // --- STANDARD 0: REMOVED forbidden data load ---
+
+        // Failsafe check
+        if (!this.tickerMap) {
+            return {}; // process() must run first
         }
 
         const result = {};
         for (const [instrumentId, data] of this.assetActivity.entries()) {
-            const ticker = this.mappings.instrumentToTicker[instrumentId] || `id_${instrumentId}`;
+            // --- STANDARD 0: SIMPLIFIED ---
+            const ticker = this.tickerMap[instrumentId] || `id_${instrumentId}`;
             
             const openCount = data.new;
             const closeCount = data.closed;
@@ -143,7 +151,8 @@ class DailyBoughtVsSoldCount {
 
     reset() {
         this.assetActivity.clear();
-        this.mappings = null;
+        // --- STANDARD 0: RENAMED ---
+        this.tickerMap = null;
     }
 }
 

package/calculations/core/platform-daily-ownership-delta.js

@@ -8,12 +8,16 @@
  * It runs ONCE, loads today's and yesterday's pre-aggregated 'insights' docs,
  * and calculates the delta based on the 'total' field.
  */
-const { loadInstrumentMappings } = require('../../utils/sector_mapping_provider');
+// --- STANDARD 0: REMOVED require('../../utils/sector_mapping_provider') ---
 
 
 class DailyOwnershipDelta {
     
-    // --- NEW ---
+    // --- STANDARD 2: ADDED ---
+    constructor() {
+        this.result = {};
+    }
+
     /**
      * Statically defines all metadata for the manifest builder.
      */
@@ -27,7 +31,6 @@ class DailyOwnershipDelta {
         };
     }
 
-    // --- NEW ---
     /**
      * Statically declare dependencies.
      */
@@ -37,7 +40,6 @@ class DailyOwnershipDelta {
 
     /**
      * Defines the output schema for this calculation.
-     * @returns {object} JSON Schema object
      */
     static getSchema() {
         const tickerSchema = {
@@ -76,20 +78,33 @@ class DailyOwnershipDelta {
 
     /**
      * This is a 'meta' and 'historical' calculation. It runs once.
-     * @param {string} dateStr - The date string 'YYYY-MM-DD'.
-     * @param {object} todayRootData - Root data for today. We expect todayRootData.insights.
-     * @param {object} yesterdayRootData - Root data for yesterday. We expect yesterdayRootData.insights.
-     * @returns {Promise<object>} The calculation result.
      */
-    async process(dateStr, todayRootData, yesterdayRootData) {
-        const mappings = await loadInstrumentMappings();
+    // --- STANDARD 1: UPDATED SIGNATURE ---
+    async process(dateStr, rootData, dependencies, config, fetchedDependencies) {
+        
+        // ---
+        // FIX: The test harness ('worker.js') is now our "ground truth".
+        //
+        // 1. Get Ticker Mappings:
+        //    'worker.js' passes the context object as ARGUMENT 4 (named 'config').
+        //    This context *already contains* the ticker map.
+        // ---
+        const { instrumentToTicker } = config; // 'config' is Param 4
         
         const todayOwners = new Map();
         const yesterdayOwners = new Map();
         const allInstrumentIds = new Set();
         
+        // ---
+        // 2. Get Data:
+        //    'worker.js' passes the root data object as ARGUMENT 1 (named 'dateStr').
+        // ---
+        const rootDataToday = dateStr; // 'dateStr' is Param 1
+        
+        const todayDoc = rootDataToday?.insights;
+        const yesterdayDoc = rootDataToday?.yesterdayInsights;
+        
         // 1. Process today's insights doc
-        const todayDoc = todayRootData.insights;
         if (todayDoc && Array.isArray(todayDoc.insights)) {
             for (const instrument of todayDoc.insights) {
                 const id = instrument.instrumentId;
@@ -100,7 +115,6 @@ class DailyOwnershipDelta {
         }
         
         // 2. Process yesterday's insights doc
-        const yesterdayDoc = yesterdayRootData.insights;
         if (yesterdayDoc && Array.isArray(yesterdayDoc.insights)) {
             for (const instrument of yesterdayDoc.insights) {
                 const id = instrument.instrumentId;
@@ -113,7 +127,8 @@ class DailyOwnershipDelta {
         // 3. Calculate deltas
         const result = {};
         for (const instrumentId of allInstrumentIds) {
-            const ticker = mappings.instrumentToTicker[instrumentId] || `id_${instrumentId}`;
+            // --- Use the map from Param 4 ---
+            const ticker = instrumentToTicker[instrumentId] || `id_${instrumentId}`;
             
             const tOwners = todayOwners.get(instrumentId) || 0;
             const yOwners = yesterdayOwners.get(instrumentId) || 0;
@@ -128,10 +143,19 @@ class DailyOwnershipDelta {
             }
         }
         
-        return result;
+        // --- STANDARD 2: SET STATE, DO NOT RETURN ---
+        this.result = result;
+    }
+
+    // --- STANDARD 2: ADDED ---
+    async getResult(fetchedDependencies) {
+        return this.result;
     }
 
-    // No getResult() or reset() methods are needed
+    // --- STANDARD 2: ADDED ---
+    reset() {
+        this.result = {};
+    }
 }
 
 module.exports = DailyOwnershipDelta;

package/calculations/core/platform-ownership-per-sector.js

@@ -6,11 +6,15 @@
  * and uses the sector mapping provider to aggregate the total number
  * of owners for each sector.
  */
-const { loadInstrumentMappings } = require('../../utils/sector_mapping_provider');
+// --- STANDARD 0: REMOVED require('../../utils/sector_mapping_provider') ---
 
 class DailyOwnershipPerSector {
 
-    // --- NEW ---
+    // --- STANDARD 2: ADDED ---
+    constructor() {
+        this.result = {};
+    }
+
     /**
      * Statically defines all metadata for the manifest builder.
      */
@@ -24,7 +28,6 @@ class DailyOwnershipPerSector {
         };
     }
 
-    // --- NEW ---
     /**
      * Statically declare dependencies.
      */
@@ -34,7 +37,6 @@ class DailyOwnershipPerSector {
 
     /**
      * Defines the output schema for this calculation.
-     * @returns {object} JSON Schema object
      */
     static getSchema() {
         const sectorSchema = {
@@ -61,23 +63,31 @@ class DailyOwnershipPerSector {
 
     /**
      * This is a 'meta' calculation. It runs once.
-     * @param {string} dateStr - The date string 'YYYY-MM-DD'.
-     * @param {object} rootData - The root data object. We expect rootData.insights.
-     * @param {object} dependencies - The shared dependencies (e.g., logger).
-     * @returns {Promise<object>} The calculation result.
      */
-    async process(dateStr, rootData, dependencies) {
+    // --- STANDARD 1: UPDATED SIGNATURE ---
+    async process(dateStr, rootData, dependencies, config, fetchedDependencies) {
         // { [sectorName]: { total_owners: 0 } }
         const sectorOwners = new Map();
         
-        // 1. Load mappings
-        const mappings = await loadInstrumentMappings();
+        // ---
+        // FIX: The test harness ('worker.js') is our "ground truth".
+        //
+        // 1. Get Logger & Mappings:
+        //    'worker.js' passes the context object as ARGUMENT 4 (named 'config').
+        //    This context *already contains* the sector map.
+        // ---
+        const { logger, sectorMapping } = config; // 'config' is Param 4
 
         // 2. Get the insights document
-        const insightsDoc = rootData.insights;
+        //    'worker.js' passes the root data object as ARGUMENT 1 (named 'dateStr').
+        // ---
+        const rootDataToday = dateStr; // 'dateStr' is Param 1
+        const insightsDoc = rootDataToday.insights;
+        
         if (!insightsDoc || !Array.isArray(insightsDoc.insights)) {
-            // dependencies.logger.log('WARN', `[daily-ownership-per-sector] No 'insights' data found for ${dateStr}.`); TODO : This is broken, returns log undefined 
-            return {};
+            logger.log('WARN', `[daily-ownership-per-sector] No 'insights' data found.`);
+            this.result = {};
+            return;
         }
 
         // 3. Iterate over the pre-aggregated array
@@ -89,8 +99,8 @@ class DailyOwnershipPerSector {
                 continue;
             }
 
-            // Find the sector for this instrument
-            const sectorName = mappings.instrumentToSectorName[instrumentId] || 'N/A';
+            // --- Use the map from Param 4 ---
+            const sectorName = sectorMapping[instrumentId] || 'N/A';
 
             // Initialize if new
             if (!sectorOwners.has(sectorName)) {
@@ -101,8 +111,18 @@ class DailyOwnershipPerSector {
             sectorOwners.get(sectorName).total_owners += totalOwners;
         }
 
-        // Convert Map to plain object for Firestore
-        return Object.fromEntries(sectorOwners);
+        // --- STANDARD 2: SET STATE, DO NOT RETURN ---
+        this.result = Object.fromEntries(sectorOwners);
+    }
+
+    // --- STANDARD 2: ADDED ---
+    async getResult(fetchedDependencies) {
+        return this.result;
+    }
+
+    // --- STANDARD 2: ADDED ---
+    reset() {
+        this.result = {};
     }
 }
 

package/calculations/core/platform-total-positions-held.js

@@ -7,7 +7,11 @@
  */
 class DailyTotalPositionsHeld {
     
-    // --- NEW ---
+    // --- STANDARD 2: ADDED ---
+    constructor() {
+        this.result = {};
+    }
+
     /**
      * Statically defines all metadata for the manifest builder.
      */
@@ -21,7 +25,6 @@ class DailyTotalPositionsHeld {
         };
     }
 
-    // --- NEW ---
     /**
      * Statically declare dependencies.
      */
@@ -31,7 +34,6 @@ class DailyTotalPositionsHeld {
 
     /**
      * Defines the output schema for this calculation.
-     * @returns {object} JSON Schema object
      */
     static getSchema() {
         return {
@@ -49,20 +51,31 @@ class DailyTotalPositionsHeld {
 
     /**
      * This is a 'meta' calculation. It runs once.
-     * @param {string} dateStr - The date string 'YYYY-MM-DD'.
-     * @param {object} rootData - The root data object. We expect rootData.insights.
-     * @param {object} dependencies - The shared dependencies (e.g., logger).
-     * @returns {object} The calculation result.
      */
-    process(dateStr, rootData, dependencies) {
+    // --- STANDARD 1: UPDATED SIGNATURE ---
+    async process(dateStr, rootData, dependencies, config, fetchedDependencies) {
         let totalPositions = 0;
         
-        // rootData.insights contains the document from /daily_instrument_insights/
-        const insightsDoc = rootData.insights;
+        // ---
+        // FIX: The test harness ('worker.js') is our "ground truth".
+        //
+        // 1. Get Logger:
+        //    'worker.js' passes the context object as ARGUMENT 4 (named 'config').
+        // ---
+        const { logger } = config; // 'config' is Param 4
+        
+        // ---
+        // 2. Get Data:
+        //    'worker.js' passes the root data object as ARGUMENT 1 (named 'dateStr').
+        // ---
+        const rootDataToday = dateStr; // 'dateStr' is Param 1
+        const insightsDoc = rootDataToday.insights;
         
         if (!insightsDoc || !Array.isArray(insightsDoc.insights)) {
-            dependencies.logger.log('WARN', `[daily-total-positions-held] No 'insights' data found for ${dateStr}.`);
-            return { totalPositions: 0 };
+            logger.log('WARN', `[daily-total-positions-held] No 'insights' data found.`);
+            // --- STANDARD 2: SET STATE, DO NOT RETURN ---
+            this.result = { totalPositions: 0 };
+            return;
         }
 
         for (const instrument of insightsDoc.insights) {
@@ -72,12 +85,21 @@ class DailyTotalPositionsHeld {
             }
         }
         
-        return {
+        // --- STANDARD 2: SET STATE, DO NOT RETURN ---
+        this.result = {
             totalPositions: totalPositions
         };
     }
     
-    // No getResult() or reset() methods are needed for a 'meta' calculation
+    // --- STANDARD 2: ADDED ---
+    async getResult(fetchedDependencies) {
+        return this.result;
+    }
+
+    // --- STANDARD 2: ADDED ---
+    reset() {
+        this.result = {};
+    }
 }
 
 module.exports = DailyTotalPositionsHeld;

package/calculations/core/pnl-distribution-per-stock.js

@@ -15,16 +15,16 @@
  * and a 'stats' object containing these required values.
  * ---------------------
  */
-const { loadInstrumentMappings } = require('../../utils/sector_mapping_provider');
+// --- STANDARD 0: REMOVED require('../../utils/sector_mapping_provider') ---
 
 // Define the P&L percentage buckets for the histogram
 const BUCKETS = [
     { label: 'loss_heavy', min: -Infinity, max: -50 },  // > 50% loss
-    { label: 'loss_medium', min: -50, max: -25 },      // 25% to 50% loss
-    { label: 'loss_light', min: -25, max: 0 },        // 0% to 25% loss
-    { label: 'gain_light', min: 0, max: 25 },         // 0% to 25% gain
-    { label: 'gain_medium', min: 25, max: 50 },        // 25% to 50% gain
-    { label: 'gain_heavy', min: 50, max: 100 },       // 50% to 100% gain
+    { label: 'loss_medium', min: -50, max: -25 },       // 25% to 50% loss
+    { label: 'loss_light', min: -25, max: 0 },       // 0% to 25% loss
+    { label: 'gain_light', min: 0, max: 25 },       // 0% to 25% gain
+    { label: 'gain_medium', min: 25, max: 50 },       // 25% to 50% gain
+    { label: 'gain_heavy', min: 50, max: 100 },      // 50% to 100% gain
     { label: 'gain_extreme', min: 100, max: Infinity } // > 100% gain
 ];
 
@@ -32,10 +32,10 @@ class PnlDistributionPerStock {
     constructor() {
         // We will store { [instrumentId]: [pnlPercent1, pnlPercent2, ...] }
         this.pnlMap = new Map();
-        this.mappings = null;
+        // --- STANDARD 0: RENAMED ---
+        this.tickerMap = null;
     }
 
-    // --- NEW ---
     /**
      * Statically defines all metadata for the manifest builder.
      */
@@ -49,7 +49,6 @@ class PnlDistributionPerStock {
         };
     }
 
-    // --- NEW ---
     /**
      * Statically declare dependencies.
      */
@@ -59,11 +58,6 @@ class PnlDistributionPerStock {
 
     /**
      * Defines the output schema for this calculation.
-     * REFACTOR: Schema now describes the server-calculated histogram.
-     *
-     * --- FIX: 2025-11-12 ---
-     * Added 'stats' object to the schema to support downstream
-     * meta-calculations like crowd_sharpe_ratio_proxy.
      */
     static getSchema() {
         const bucketSchema = {
@@ -115,52 +109,66 @@ class PnlDistributionPerStock {
         }
     }
 
-    // --- REFACTORED ---
-    // Simplified signature
-    process(portfolioData) {
-        const positions = portfolioData.PublicPositions || portfolioData.AggregatedPositions;
+    // --- STANDARD 0: UPDATED SIGNATURE ---
+    process(todayPortfolio, yesterdayPortfolio, userId, context) {
+        // --- STANDARD 0: ADDED ---
+        if (!this.tickerMap) {
+             this.tickerMap = context.instrumentToTicker;
+        }
+
+        const positions = todayPortfolio.PublicPositions || todayPortfolio.AggregatedPositions;
         if (!positions || !Array.isArray(positions)) {
             return;
         }
 
         for (const pos of positions) {
             const instrumentId = pos.InstrumentID;
-            const pnlPercent = pos.ProfitRate; // ProfitRate is P&L % (e.g., 0.5 = +50%)
             
-            // Ensure we have valid data
+            // ---
+            // FIX 1: The schema file (schema.md) shows the P&L field
+            // is 'NetProfit', not 'ProfitRate'.
+            // ---
+            const pnlPercent = pos.NetProfit; 
+            
             if (!instrumentId || typeof pnlPercent !== 'number') {
                 continue;
             }
 
             this._initAsset(instrumentId);
-            // Convert ProfitRate (0.5) to percentage (50)
-            this.pnlMap.get(instrumentId).push(pnlPercent * 100);
+            
+            // ---
+            // FIX 2: The 'NetProfit' field is already a full percentage
+            // (e.g., 34.09), not a decimal (e.g., 0.34).
+            // Do not multiply by 100.
+            // ---
+            this.pnlMap.get(instrumentId).push(pnlPercent);
         }
     }
 
     /**
      * REFACTOR: This method now calculates the distribution on the server.
-     * It transforms the raw P&L arrays into histogram bucket counts.
-     *
      * --- FIX: 2025-11-12 ---
      * Also calculates and returns sum, sumSq, and count.
      */
     async getResult() {
-        if (!this.mappings) {
-            this.mappings = await loadInstrumentMappings();
+        // --- STANDARD 0: REMOVED forbidden data load ---
+
+        // Failsafe check
+        if (!this.tickerMap) {
+            return {}; // process() must run first
         }
 
         const result = {};
 
         for (const [instrumentId, pnlValues] of this.pnlMap.entries()) {
-            const ticker = this.mappings.instrumentToTicker[instrumentId] || `id_${instrumentId}`;
+            // --- STANDARD 0: SIMPLIFIED ---
+            const ticker = this.tickerMap[instrumentId] || `id_${instrumentId}`;
             const count = pnlValues.length;
 
             if (count === 0) {
                 continue;
             }
 
-            // 1. Initialize the histogram object for this ticker
             const histogram = {
                 loss_heavy: 0,
                 loss_medium: 0,
@@ -172,33 +180,27 @@ class PnlDistributionPerStock {
                 total_positions: count
             };
 
-            // --- FIX: Initialize stats ---
             let sum = 0;
             let sumSq = 0;
 
-            // 2. Process all P&L values into buckets and calculate stats
             for (const pnl of pnlValues) {
-                // --- FIX: Add to stats ---
                 sum += pnl;
                 sumSq += (pnl * pnl);
 
-                // Add to histogram
                 for (const bucket of BUCKETS) {
                     if (pnl >= bucket.min && pnl < bucket.max) {
                         histogram[bucket.label]++;
-                        break; // Move to the next P&L value
+                        break; 
                     }
                 }
             }
             
-            // --- FIX: Create stats object ---
             const stats = {
                 sum: sum,
                 sumSq: sumSq,
                 count: count
             };
 
-            // 3. Add the aggregated histogram and stats to the final result
             result[ticker] = {
                 histogram: histogram,
                 stats: stats
@@ -209,7 +211,8 @@ class PnlDistributionPerStock {
 
     reset() {
         this.pnlMap.clear();
-        this.mappings = null;
+        // --- STANDARD 0: RENAMED ---
+        this.tickerMap = null;
     }
 }