aiden-shared-calculations-unified 1.0.76 → 1.0.77

package/calculations/{pnl/asset_pnl_status.js → core/asset-pnl-status.js}

@@ -81,6 +81,26 @@ class AssetPnlStatus {
         };
     }
 
+    /**
+     * Statically defines all metadata for the manifest builder.
+     */
+    static getMetadata() {
+        return {
+            type: 'standard',
+            rootDataDependencies: ['portfolio'],
+            isHistorical: false,
+            userType: 'all',
+            category: 'core_pnl'
+        };
+    }
+
+    /**
+     * Statically declare dependencies.
+     */
+    static getDependencies() {
+        return [];
+    }
+
     _initAsset(instrumentId) {
         if (!this.assets.has(instrumentId)) {
             this.assets.set(instrumentId, {

package/calculations/{asset_metrics/asset_position_size.js → core/asset-position-size.js}

@@ -9,6 +9,28 @@ class AssetPositionSize {
         this.mappings = null;
     }
 
+    // --- NEW ---
+    /**
+     * Statically defines all metadata for the manifest builder.
+     */
+    static getMetadata() {
+        return {
+            type: 'standard', // It processes each user
+            rootDataDependencies: ['portfolio'], // It only needs portfolio data
+            isHistorical: false, // It only needs today's portfolio
+            userType: 'all', // It runs for all users
+            category: 'core_metrics' // Belongs to the core product line
+        };
+    }
+
+    // --- NEW ---
+    /**
+     * Statically declare dependencies.
+     */
+    static getDependencies() {
+        return []; // This is a Pass 1 calculation
+    }
+
     /**
      * Defines the output schema for this calculation.
      * @returns {object} JSON Schema object
@@ -45,7 +67,9 @@ class AssetPositionSize {
         };
     }
 
-    process(portfolioData, yesterdayPortfolio, userId, context, todayInsights, yesterdayInsights) {
+    // --- REFACTORED ---
+    // Simplified signature. This calc doesn't need history, context, or insights.
+    process(portfolioData) {
         const positions = portfolioData.AggregatedPositions || portfolioData.PublicPositions;
         if (!positions || !Array.isArray(positions)) return;
 

package/calculations/{pnl/average_daily_pnl_all_users.js → core/average-daily-pnl-all-users.js}

@@ -12,6 +12,28 @@ class AverageDailyPnlAllUsers {
         this.userCount = 0;
     }
 
+    // --- NEW ---
+    /**
+     * Statically defines all metadata for the manifest builder.
+     */
+    static getMetadata() {
+        return {
+            type: 'standard',
+            rootDataDependencies: ['portfolio'], // Needs portfolio.Summary
+            isHistorical: false,
+            userType: 'all',
+            category: 'core_pnl'
+        };
+    }
+
+    // --- NEW ---
+    /**
+     * Statically declare dependencies.
+     */
+    static getDependencies() {
+        return [];
+    }
+
     /**
      * Defines the output schema for this calculation.
      * @returns {object} JSON Schema object

package/calculations/{pnl/average_daily_pnl_per_sector.js → core/average-daily-pnl-per-sector.js}

@@ -15,6 +15,28 @@ class AverageDailyPnlPerSector {
         this.mappings = null;
     }
 
+    // --- NEW ---
+    /**
+     * Statically defines all metadata for the manifest builder.
+     */
+    static getMetadata() {
+        return {
+            type: 'standard',
+            rootDataDependencies: ['portfolio'], // Needs portfolio positions
+            isHistorical: false,
+            userType: 'all',
+            category: 'core_pnl'
+        };
+    }
+
+    // --- NEW ---
+    /**
+     * Statically declare dependencies.
+     */
+    static getDependencies() {
+        return [];
+    }
+
     /**
      * Defines the output schema for this calculation.
      * @returns {object} JSON Schema object

package/calculations/{pnl/average_daily_pnl_per_stock.js → core/average-daily-pnl-per-stock.js}

@@ -13,6 +13,28 @@ class AverageDailyPnlPerStock {
         this.mappings = null;
     }
 
+    // --- NEW ---
+    /**
+     * Statically defines all metadata for the manifest builder.
+     */
+    static getMetadata() {
+        return {
+            type: 'standard',
+            rootDataDependencies: ['portfolio'], // Needs portfolio positions
+            isHistorical: false,
+            userType: 'all',
+            category: 'core_pnl'
+        };
+    }
+
+    // --- NEW ---
+    /**
+     * Statically declare dependencies.
+     */
+    static getDependencies() {
+        return [];
+    }
+
     /**
      * Defines the output schema for this calculation.
      * @returns {object} JSON Schema object

package/calculations/{pnl/average_daily_position_pnl.js → core/average-daily-position-pnl.js}

@@ -13,6 +13,28 @@ class AverageDailyPositionPnl {
         this.positionCount = 0;
     }
 
+    // --- NEW ---
+    /**
+     * Statically defines all metadata for the manifest builder.
+     */
+    static getMetadata() {
+        return {
+            type: 'standard',
+            rootDataDependencies: ['portfolio'], // Needs portfolio positions
+            isHistorical: false,
+            userType: 'all',
+            category: 'core_pnl'
+        };
+    }
+
+    // --- NEW ---
+    /**
+     * Statically declare dependencies.
+     */
+    static getDependencies() {
+        return [];
+    }
+
     /**
      * Defines the output schema for this calculation.
      * @returns {object} JSON Schema object

package/calculations/{behavioural/historical/holding_duration_per_asset.js → core/holding-duration-per-asset.js}

@@ -17,6 +17,28 @@ class HoldingDurationPerAsset {
         this.mappings = null;
     }
 
+    // --- NEW ---
+    /**
+     * Statically defines all metadata for the manifest builder.
+     */
+    static getMetadata() {
+        return {
+            type: 'standard',
+            rootDataDependencies: ['history'], // It only needs the history doc
+            isHistorical: false, // It only needs today's history doc
+            userType: 'all',
+            category: 'core_metrics'
+        };
+    }
+
+    // --- NEW ---
+    /**
+     * Statically declare dependencies.
+     */
+    static getDependencies() {
+        return [];
+    }
+
     /**
      * Defines the output schema for this calculation.
      * @returns {object} JSON Schema object
@@ -53,14 +75,32 @@ class HoldingDurationPerAsset {
         }
     }
 
+    // --- REFACTORED ---
     /**
      * Process data from the 'history' root data source.
-     * @param {object} rootData - The root data object from the runner.
+     * @param {object} todayPortfolio - (Not used)
+     * @param {object} yesterdayPortfolio - (Not used)
      * @param {string} userId - The user ID.
+     * @param {object} context - (Not used)
+     * @param {object} todayInsights - (Not used)
+     * @param {object} yesterdayInsights - (Not used)
+     * @param {object} todaySocialPostInsights - (Not used)
+     * @param {object} yesterdaySocialPostInsights - (Not used)
+     * @param {object} todayHistory - The user's history doc for today.
      */
-    process(rootData, userId) {
-        // 1. Get the history data
-        const historyData = rootData.history;
+    process(
+        todayPortfolio, 
+        yesterdayPortfolio, 
+        userId, 
+        context, 
+        todayInsights, 
+        yesterdayInsights, 
+        todaySocialPostInsights, 
+        yesterdaySocialPostInsights,
+        todayHistory
+    ) {
+        // 1. Get the history data from the 9th argument
+        const historyData = todayHistory;
         if (!historyData || !Array.isArray(historyData.assets)) {
             return;
         }

package/calculations/{meta/gem_instrument-price-momentum.js → core/instrument-price-momentum-20d.js}

@@ -7,6 +7,7 @@
  * It is a 'meta' calculation that runs once, loads all price data,
  * and provides a reusable momentum signal for downstream passes.
  */
+// The dependency path is relative to the *calculations* folder
 const { loadAllPriceData } = require('../../utils/price_data_provider');
 
 class InstrumentPriceMomentum {
@@ -37,6 +38,19 @@ class InstrumentPriceMomentum {
         };
     }
 
+    /**
+     * Statically defines all metadata for the manifest builder.
+     */
+    static getMetadata() {
+        return {
+            type: 'meta', // Explicitly a 'meta' calculation
+            rootDataDependencies: [], // Relies on price data, not root data
+            isHistorical: false,
+            userType: 'n/a', // Does not run per-user
+            category: 'core_metrics'
+        };
+    }
+
     /**
      * This is a Pass 1 calculation and has no dependencies.
      */
@@ -75,10 +89,9 @@ class InstrumentPriceMomentum {
      * @returns {Promise<object>} The calculation result.
      */
     async process(dateStr, dependencies, config, fetchedDependencies) {
-        const { logger, calculationUtils, mappings } = dependencies;
+        const { logger, calculationUtils } = dependencies;
         
-        // Load all price data and mappings
-        const priceMap = await loadAllPriceData();
+        const priceMap = await calculationUtils.loadAllPriceData();
         const tickerMap = await calculationUtils.loadInstrumentMappings();
         
         if (!priceMap || !tickerMap || !tickerMap.instrumentToTicker) {
@@ -93,7 +106,7 @@ class InstrumentPriceMomentum {
             const instrumentPrices = priceMap[instrumentId];
             const ticker = tickerMap.instrumentToTicker[instrumentId];
             
-            if (!ticker) continue; // Skip if we can't map ID to ticker
+            if (!ticker) continue; 
 
             const priceT = this._findPrice(instrumentPrices, dateStr);
             const priceT20 = this._findPrice(instrumentPrices, dateStrT20);

package/calculations/{short_and_long_stats/long_position_per_stock.js → core/long-position-per-stock.js}

@@ -13,6 +13,28 @@ class LongPositionPerStock {
         this.mappings = null;
     }
 
+    // --- NEW ---
+    /**
+     * Statically defines all metadata for the manifest builder.
+     */
+    static getMetadata() {
+        return {
+            type: 'standard',
+            rootDataDependencies: ['portfolio'],
+            isHistorical: false,
+            userType: 'all',
+            category: 'core_sentiment' // Based on Computation_documentation.md (short_and_long_stats -> sentiment_per_stock)
+        };
+    }
+
+    // --- NEW ---
+    /**
+     * Statically declare dependencies.
+     */
+    static getDependencies() {
+        return [];
+    }
+
     /**
      * Defines the output schema for this calculation.
      * @returns {object} JSON Schema object
@@ -40,6 +62,8 @@ class LongPositionPerStock {
         }
     }
 
+    // --- REFACTORED ---
+    // Simplified signature
     process(portfolioData) {
         const positions = portfolioData.PublicPositions || portfolioData.AggregatedPositions;
         if (!positions || !Array.isArray(positions)) {

package/calculations/{behavioural/overall_holding_duration.js → core/overall-holding-duration.js}

@@ -12,6 +12,28 @@ class AverageHoldingDurationOverall {
         this.durationsHours = [];
     }
 
+    // --- NEW ---
+    /**
+     * Statically defines all metadata for the manifest builder.
+     */
+    static getMetadata() {
+        return {
+            type: 'standard',
+            rootDataDependencies: ['history'], // Needs the history doc
+            isHistorical: false, // Needs today's history doc
+            userType: 'all',
+            category: 'core_metrics'
+        };
+    }
+
+    // --- NEW ---
+    /**
+     * Statically declare dependencies.
+     */
+    static getDependencies() {
+        return [];
+    }
+
     /**
      * Defines the output schema for this calculation.
      * @returns {object} JSON Schema object
@@ -34,14 +56,16 @@ class AverageHoldingDurationOverall {
         };
     }
 
+    // --- REFACTORED ---
     /**
      * Process data from the 'history' root data source.
-     * @param {object} rootData - The root data object from the runner.
+     * @param {object} todayPortfolio - Contains today's history doc
+     * @param {object} yesterdayPortfolio - (Not used)
      * @param {string} userId - The user ID.
      */
-    process(rootData, userId) {
+    process(todayPortfolio, yesterdayPortfolio, userId) {
         // 1. Get the history data
-        const historyData = rootData.history;
+        const historyData = todayPortfolio?.history; // Accessing from the portfolio object
         if (!historyData || !historyData.all) {
             return;
         }

package/calculations/{pnl/overall_profitability_ratio.js → core/overall-profitability-ratio.js}

@@ -11,6 +11,28 @@ class ProfitabilityRatioOverall {
         this.unprofitable = 0;
     }
 
+    // --- NEW ---
+    /**
+     * Statically defines all metadata for the manifest builder.
+     */
+    static getMetadata() {
+        return {
+            type: 'standard',
+            rootDataDependencies: ['portfolio'],
+            isHistorical: false,
+            userType: 'all',
+            category: 'core_pnl'
+        };
+    }
+
+    // --- NEW ---
+    /**
+     * Statically declare dependencies.
+     */
+    static getDependencies() {
+        return [];
+    }
+
     /**
      * Defines the output schema for this calculation.
      * @returns {object} JSON Schema object
@@ -37,6 +59,8 @@ class ProfitabilityRatioOverall {
         };
     }
 
+    // --- REFACTORED ---
+    // Simplified signature
     process(portfolioData) {
         const positions = portfolioData.PublicPositions || portfolioData.AggregatedPositions;
         if (!positions || !Array.isArray(positions)) {

package/calculations/{insights/daily_buy_sell_sentiment_count.js → core/platform-buy-sell-sentiment.js}

@@ -7,6 +7,28 @@
  */
 class DailyBuySellSentimentCount {
 
+    // --- NEW ---
+    /**
+     * Statically defines all metadata for the manifest builder.
+     */
+    static getMetadata() {
+        return {
+            type: 'meta',
+            rootDataDependencies: ['insights'], // Needs insights doc
+            isHistorical: false,
+            userType: 'n/a',
+            category: 'core_sentiment'
+        };
+    }
+
+    // --- NEW ---
+    /**
+     * Statically declare dependencies.
+     */
+    static getDependencies() {
+        return [];
+    }
+
     /**
      * Defines the output schema for this calculation.
      * @returns {object} JSON Schema object

package/calculations/{insights/historical/daily_bought_vs_sold_count.js → core/platform-daily-bought-vs-sold-count.js}

@@ -16,6 +16,28 @@ class DailyBoughtVsSoldCount {
         this.mappings = null;
     }
 
+    // --- NEW ---
+    /**
+     * Statically defines all metadata for the manifest builder.
+     */
+    static getMetadata() {
+        return {
+            type: 'standard',
+            rootDataDependencies: ['portfolio'],
+            isHistorical: true, // Needs yesterday's portfolio
+            userType: 'all',
+            category: 'core_metrics'
+        };
+    }
+
+    // --- NEW ---
+    /**
+     * Statically declare dependencies.
+     */
+    static getDependencies() {
+        return [];
+    }
+
     /**
      * Defines the output schema for this calculation.
      * @returns {object} JSON Schema object

package/calculations/{insights/historical/daily_ownership_delta.js → core/platform-daily-ownership-delta.js}

@@ -12,6 +12,28 @@ const { loadInstrumentMappings } = require('../../../utils/sector_mapping_provid
 
 class DailyOwnershipDelta {
     
+    // --- NEW ---
+    /**
+     * Statically defines all metadata for the manifest builder.
+     */
+    static getMetadata() {
+        return {
+            type: 'meta',
+            rootDataDependencies: ['insights'], // Needs insights doc
+            isHistorical: true, // Needs yesterday's insights doc
+            userType: 'n/a',
+            category: 'core_metrics'
+        };
+    }
+
+    // --- NEW ---
+    /**
+     * Statically declare dependencies.
+     */
+    static getDependencies() {
+        return [];
+    }
+
     /**
      * Defines the output schema for this calculation.
      * @returns {object} JSON Schema object

package/calculations/{insights/daily_ownership_per_sector.js → core/platform-ownership-per-sector.js}

@@ -10,6 +10,28 @@ const { loadInstrumentMappings } = require('../../utils/sector_mapping_provider'
 
 class DailyOwnershipPerSector {
 
+    // --- NEW ---
+    /**
+     * Statically defines all metadata for the manifest builder.
+     */
+    static getMetadata() {
+        return {
+            type: 'meta',
+            rootDataDependencies: ['insights'], // Needs insights doc
+            isHistorical: false,
+            userType: 'n/a',
+            category: 'core_metrics'
+        };
+    }
+
+    // --- NEW ---
+    /**
+     * Statically declare dependencies.
+     */
+    static getDependencies() {
+        return [];
+    }
+
     /**
      * Defines the output schema for this calculation.
      * @returns {object} JSON Schema object

package/calculations/{insights/daily_total_positions_held.js → core/platform-total-positions-held.js}

@@ -7,6 +7,28 @@
  */
 class DailyTotalPositionsHeld {
     
+    // --- NEW ---
+    /**
+     * Statically defines all metadata for the manifest builder.
+     */
+    static getMetadata() {
+        return {
+            type: 'meta',
+            rootDataDependencies: ['insights'], // Needs insights doc
+            isHistorical: false,
+            userType: 'n/a',
+            category: 'core_metrics'
+        };
+    }
+
+    // --- NEW ---
+    /**
+     * Statically declare dependencies.
+     */
+    static getDependencies() {
+        return [];
+    }
+
     /**
      * Defines the output schema for this calculation.
      * @returns {object} JSON Schema object

package/calculations/{pnl/pnl_distribution_per_stock.js → core/pnl-distribution-per-stock.js}

@@ -35,6 +35,28 @@ class PnlDistributionPerStock {
         this.mappings = null;
     }
 
+    // --- NEW ---
+    /**
+     * Statically defines all metadata for the manifest builder.
+     */
+    static getMetadata() {
+        return {
+            type: 'standard',
+            rootDataDependencies: ['portfolio'],
+            isHistorical: false,
+            userType: 'all',
+            category: 'core_pnl'
+        };
+    }
+
+    // --- NEW ---
+    /**
+     * Statically declare dependencies.
+     */
+    static getDependencies() {
+        return [];
+    }
+
     /**
      * Defines the output schema for this calculation.
      * REFACTOR: Schema now describes the server-calculated histogram.
@@ -93,6 +115,8 @@ class PnlDistributionPerStock {
         }
     }
 
+    // --- REFACTORED ---
+    // Simplified signature
     process(portfolioData) {
         const positions = portfolioData.PublicPositions || portfolioData.AggregatedPositions;
         if (!positions || !Array.isArray(positions)) {

package/calculations/{pnl/profitability_ratio_per_sector,js → core/profitability-ratio-per-sector.js}

@@ -13,6 +13,28 @@ class ProfitabilityRatioPerSector {
         this.mappings = null;
     }
 
+    // --- NEW ---
+    /**
+     * Statically defines all metadata for the manifest builder.
+     */
+    static getMetadata() {
+        return {
+            type: 'standard',
+            rootDataDependencies: ['portfolio'],
+            isHistorical: false,
+            userType: 'all',
+            category: 'core_pnl'
+        };
+    }
+
+    // --- NEW ---
+    /**
+     * Statically declare dependencies.
+     */
+    static getDependencies() {
+        return [];
+    }
+
     /**
      * Defines the output schema for this calculation.
      * @returns {object} JSON Schema object
@@ -47,14 +69,19 @@ class ProfitabilityRatioPerSector {
         }
     }
 
-    async process(portfolioData) {
+    // --- REFACTORED ---
+    // This method *is* async because it might load mappings on the first run.
+    // The runner should handle this with `await Promise.resolve(calc.process(...))`.
+    // The signature is correct because it needs `context` for mappings.
+    async process(portfolioData, yesterdayPortfolio, userId, context) {
         if (!this.mappings) {
             // Load mappings on first process call
-            this.mappings = await loadInstrumentMappings();
+            // Using context.mappings which are pre-loaded in Pass 1
+            this.mappings = context.mappings;
         }
 
         const positions = portfolioData.PublicPositions || portfolioData.AggregatedPositions;
-        if (!positions || !Array.isArray(positions)) {
+        if (!positions || !Array.isArray(positions) || !this.mappings) {
             return;
         }
 
@@ -67,7 +94,10 @@ class ProfitabilityRatioPerSector {
             }
             
             // Find sector name
-            const sectorName = this.mappings.instrumentToSectorName[instrumentId] || 'N/A';
+            // --- FIX: Use the correct mapping ---
+            // The mapping from the provider is `instrumentToSector` (ID -> Sector Name)
+            // `instrumentToSectorName` is not a property.
+            const sectorName = this.mappings.instrumentToSector[instrumentId] || 'N/A';
             this._initSector(sectorName);
             const data = this.sectorMap.get(sectorName);
 
@@ -97,7 +127,7 @@ class ProfitabilityRatioPerSector {
 
     reset() {
         this.sectorMap.clear();
-        // Do not reset mappings, it's expensive to load
+        this.mappings = null; // Reset mappings
     }
 }