aiden-shared-calculations-unified 1.0.69 → 1.0.71

package/calculations/behavioural/historical/in_loss_asset_crowd_flow.js

@@ -79,6 +79,8 @@ class InLossAssetCrowdFlow {
 
     /**
      * Helper to get the cohort data from the dependency.
+     * --- MODIFIED ---
+     * Reads `data.users_in_loss` as a string array, not an object array.
      */
     _getInLossCohorts(fetchedDependencies) {
         if (this.inLossCohorts) {
@@ -94,7 +96,8 @@ class InLossAssetCrowdFlow {
         // Map<ticker, Set<userId>>
         this.inLossCohorts = new Map();
         for (const [ticker, data] of Object.entries(pnlStatusData)) {
-            const userSet = new Set(data.users_in_loss.map(u => u.userId));
+            // `data.users_in_loss` is now a string[], so no .map() is needed.
+            const userSet = new Set(data.users_in_loss || []); // <-- MODIFIED
             this.inLossCohorts.set(ticker, userSet);
         }
         return this.inLossCohorts;

package/calculations/behavioural/historical/in_profit_asset_crowd_flow.js

@@ -79,6 +79,8 @@ class InProfitAssetCrowdFlow {
 
     /**
      * Helper to get the cohort data from the dependency.
+     * --- MODIFIED ---
+     * Reads `data.users_in_profit` as a string array, not an object array.
      */
     _getInProfitCohorts(fetchedDependencies) {
         if (this.inProfitCohorts) {
@@ -94,7 +96,8 @@ class InProfitAssetCrowdFlow {
         // Map<ticker, Set<userId>>
         this.inProfitCohorts = new Map();
         for (const [ticker, data] of Object.entries(pnlStatusData)) {
-            const userSet = new Set(data.users_in_profit.map(u => u.userId));
+            // `data.users_in_profit` is now a string[], so no .map() is needed.
+            const userSet = new Set(data.users_in_profit || []); // <-- MODIFIED
             this.inProfitCohorts.set(ticker, userSet);
         }
         return this.inProfitCohorts;

package/calculations/pnl/asset_pnl_status.js

@@ -5,21 +5,32 @@
  * sample are in profit versus in loss?"
  *
  * This provides a crowd-wide P&L status for each instrument.
+ *
+ * --- FIX ---
+ * This version is modified to only store user *IDs* in the arrays,
+ * not the full user P&L objects, to prevent exceeding the
+ * 1 MiB Firestore document size limit.
  */
 const { loadInstrumentMappings } = require('../../utils/sector_mapping_provider');
 
 class AssetPnlStatus {
     constructor() {
-        // We will store { [instrumentId]: { in_profit: Set(), in_loss: Set() } }
+        // We will store { [instrumentId]: { in_profit: Map(), in_loss: Map() } }
+        // The maps will store <userId, pnl> but only the keys (userIds) will be saved.
         this.assets = new Map();
         this.mappings = null;
     }
 
     /**
      * Defines the output schema for this calculation.
+     * --- MODIFIED ---
+     * The `users_in_profit` and `users_in_loss` schemas are changed
+     * from `items: userSchema` to `items: { "type": "string" }`.
      * @returns {object} JSON Schema object
      */
     static getSchema() {
+        /*
+        // The userSchema is no longer needed in the output
         const userSchema = {
             "type": "object",
             "properties": {
@@ -28,6 +39,7 @@ class AssetPnlStatus {
             },
             "required": ["userId", "pnl"]
         };
+        */
 
         const tickerSchema = {
             "type": "object",
@@ -47,13 +59,13 @@ class AssetPnlStatus {
                 },
                 "users_in_profit": {
                     "type": "array",
-                    "description": "List of users in profit.",
-                    "items": userSchema
+                    "description": "List of user IDs in profit.",
+                    "items": { "type": "string" } // <-- MODIFIED
                 },
                 "users_in_loss": {
                     "type": "array",
-                    "description": "List of users in loss.",
-                    "items": userSchema
+                    "description": "List of user IDs in loss.",
+                    "items": { "type": "string" } // <-- MODIFIED
                 }
             },
             "required": ["in_profit_count", "in_loss_count", "profit_ratio", "users_in_profit", "users_in_loss"]
@@ -100,6 +112,11 @@ class AssetPnlStatus {
         }
     }
 
+    /**
+     * --- MODIFIED ---
+     * This now saves an array of strings (user IDs) instead of
+     * an array of {userId, pnl} objects to save space.
+     */
     async getResult() {
         if (!this.mappings) {
             this.mappings = await loadInstrumentMappings();
@@ -118,9 +135,9 @@ class AssetPnlStatus {
                     in_profit_count: profitCount,
                     in_loss_count: lossCount,
                     profit_ratio: (profitCount / total) * 100,
-                    // Convert Maps to arrays of objects for the final result
-                    users_in_profit: Array.from(data.in_profit, ([userId, pnl]) => ({ userId, pnl })),
-                    users_in_loss: Array.from(data.in_loss, ([userId, pnl]) => ({ userId, pnl }))
+                    // Convert Maps to arrays of *keys* (user IDs)
+                    users_in_profit: Array.from(data.in_profit.keys()), // <-- MODIFIED
+                    users_in_loss: Array.from(data.in_loss.keys())   // <-- MODIFIED
                 };
             }
         }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "aiden-shared-calculations-unified",
-  "version": "1.0.69",
+  "version": "1.0.71",
   "description": "Shared calculation modules for the BullTrackers Computation System.",
   "main": "index.js",
   "files": [