aiden-shared-calculations-unified 1.0.33 → 1.0.35

package/calculations/behavioural/historical/asset_crowd_flow.js

@@ -82,7 +82,7 @@ class AssetCrowdFlow {
     async getResult() {
         if (this.user_count === 0 || !this.dates.today) {
             console.warn('[AssetCrowdFlow] No users processed or dates missing.');
-            return null; // <--- MODIFICATION
+            return null; // <--- Returns null if no users
         }
 
         // Load priceMap and mappings if not loaded
@@ -95,18 +95,14 @@ class AssetCrowdFlow {
                 this.priceMap = priceData;
                 this.mappings = mappingData;
 
-                // --- START NEW CHECK ---
-                // If priceData failed to load (e.g., returned {} from provider)
-                // this.priceMap will be empty. We must abort.
                 if (!this.priceMap || Object.keys(this.priceMap).length === 0) {
                     console.error('[AssetCrowdFlow] CRITICAL: Price map is empty or failed to load. Aborting calculation to allow backfill.');
                     return null; // Return null to trigger backfill
                 }
-                // --- END NEW CHECK ---
 
             } catch (err) {
                 console.error('[AssetCrowdFlow] Failed to load dependencies:', err);
-                return null; // <--- MODIFICATION: Return null on error
+                return null; // <--- Return null on error
             }
         }
 
@@ -121,29 +117,17 @@ class AssetCrowdFlow {
             const avg_day1_value = this.asset_values[rawInstrumentId].day1_value_sum / this.user_count;
             const avg_day2_value = this.asset_values[rawInstrumentId].day2_value_sum / this.user_count;
 
-            let priceChangePct = null;
-
-            // Check priceMap presence
-            if (!this.priceMap || !this.priceMap[instrumentId]) {
-                console.debug(`[AssetCrowdFlow] Missing priceMap entry for instrumentId ${instrumentId} (${ticker})`);
-            } else {
-                const priceDay1 = this.priceMap[instrumentId][yesterdayStr];
-                const priceDay2 = this.priceMap[instrumentId][todayStr];
-
-                if (priceDay1 == null) console.debug(`[AssetCrowdFlow] Missing price for ${instrumentId} (${ticker}) on ${yesterdayStr}`);
-                if (priceDay2 == null) console.debug(`[AssetCrowdFlow] Missing price for ${instrumentId} (${ticker}) on ${todayStr}`);
-
-                if (priceDay1 != null && priceDay2 != null && priceDay1 > 0) {
-                    priceChangePct = (priceDay2 - priceDay1) / priceDay1;
-                }
-            }
+            // --- THIS IS THE FIX YOU APPLIED ---
+            const priceChangePct = getDailyPriceChange(instrumentId, yesterdayStr, todayStr, this.priceMap);
+            // --- END FIX ---
 
             if (priceChangePct === null) {
-                // <--- MODIFICATION: We no longer add a warning object. We just skip it.
-                // If it's missing price data, it won't be in finalResults.
+                // If price is missing, we simply skip this ticker.
+                // It will not be in the final output.
                 continue;
             }
 
+            // --- THIS IS THE LOGIC THAT IS BROKEN IN YOUR FILE ---
             // Calculate expected day2 value from price movement
             const expected_day2_value = avg_day1_value * (1 + priceChangePct);
 
@@ -152,22 +136,19 @@ class AssetCrowdFlow {
 
             finalResults[ticker] = {
                 net_crowd_flow_pct,
-                avg_value_day1,
-                avg_value_day2,
+                avg_value_day1_pct: avg_day1_value, // <-- Note: I've also fixed the key name here
+                avg_value_day2_pct: avg_day2_value, // <-- Note: I've also fixed the key name here
                 expected_day2_value,
                 price_change_pct: priceChangePct,
                 user_sample_size: this.user_count
             };
+            // --- END BROKEN LOGIC ---
         }
 
-        // --- START NEW CHECK ---
-        // If all tickers were skipped due to missing price data,
-        // finalResults will be empty. Return null to trigger backfill.
         if (Object.keys(finalResults).length === 0) {
             console.warn(`[AssetCrowdFlow] No results generated for ${this.dates.today}. This likely means all price data was missing. Returning null for backfill.`);
-            return null;
+            return null; // <--- Returns null if all tickers failed
         }
-        // --- END NEW CHECK ---
 
         return finalResults;
     }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "aiden-shared-calculations-unified",
-  "version": "1.0.33",
+  "version": "1.0.35",
   "description": "Shared calculation modules for the BullTrackers Computation System.",
   "main": "index.js",
   "files": [