aiden-shared-calculations-unified 1.0.31 → 1.0.32

package/calculations/behavioural/historical/asset_crowd_flow.js

@@ -82,7 +82,7 @@ class AssetCrowdFlow {
     async getResult() {
         if (this.user_count === 0 || !this.dates.today) {
             console.warn('[AssetCrowdFlow] No users processed or dates missing.');
-            return {};
+            return null; // <--- MODIFICATION
         }
 
         // Load priceMap and mappings if not loaded
@@ -94,9 +94,19 @@ class AssetCrowdFlow {
                 ]);
                 this.priceMap = priceData;
                 this.mappings = mappingData;
+
+                // --- START NEW CHECK ---
+                // If priceData failed to load (e.g., returned {} from provider)
+                // this.priceMap will be empty. We must abort.
+                if (!this.priceMap || Object.keys(this.priceMap).length === 0) {
+                    console.error('[AssetCrowdFlow] CRITICAL: Price map is empty or failed to load. Aborting calculation to allow backfill.');
+                    return null; // Return null to trigger backfill
+                }
+                // --- END NEW CHECK ---
+
             } catch (err) {
                 console.error('[AssetCrowdFlow] Failed to load dependencies:', err);
-                return {};
+                return null; // <--- MODIFICATION: Return null on error
             }
         }
 
@@ -129,14 +139,8 @@ class AssetCrowdFlow {
             }
 
             if (priceChangePct === null) {
-                finalResults[ticker] = {
-                    net_crowd_flow_pct: 0,
-                    avg_value_day1: avg_day1_value,
-                    avg_value_day2: avg_day2_value,
-                    price_change_pct: null,
-                    user_sample_size: this.user_count,
-                    warning: 'Missing price data for calculation'
-                };
+                // <--- MODIFICATION: We no longer add a warning object. We just skip it.
+                // If it's missing price data, it won't be in finalResults.
                 continue;
             }
 
@@ -156,6 +160,15 @@ class AssetCrowdFlow {
             };
         }
 
+        // --- START NEW CHECK ---
+        // If all tickers were skipped due to missing price data,
+        // finalResults will be empty. Return null to trigger backfill.
+        if (Object.keys(finalResults).length === 0) {
+            console.warn(`[AssetCrowdFlow] No results generated for ${this.dates.today}. This likely means all price data was missing. Returning null for backfill.`);
+            return null;
+        }
+        // --- END NEW CHECK ---
+
         return finalResults;
     }
 
@@ -169,4 +182,4 @@ class AssetCrowdFlow {
     }
 }
 
-module.exports = AssetCrowdFlow;
+module.exports = AssetCrowdFlow;

package/calculations/meta/cash-flow-deployment.js

@@ -45,6 +45,18 @@ class CashFlowDeployment {
             if (snap.exists) dataMap.set(idx, snap.data());
         });
 
+        // --- START MODIFICATION ---
+        // Check for THIS DATE's dependencies (cash-flow and asset-flow) FIRST.
+        // These are at the end of the 'dates' array.
+        const cashFlowData = dataMap.get(this.lookbackDays);
+        const assetFlowData = dataMap.get(this.lookbackDays + 1);
+
+        if (!cashFlowData || !assetFlowData) {
+            logger.log('WARN', `[CashFlowDeployment] Missing critical dependency data (cash-flow or asset-flow) for ${dateStr}. Skipping to allow backfill.`);
+            return null; // This allows backfill
+        }
+        // --- END MODIFICATION ---
+
         // find deposit signal
         let depositSignal = null;
         let depositSignalDay = null;
@@ -77,14 +89,10 @@ class CashFlowDeployment {
             };
         }
 
-        // today's two dependencies are the last 2 refs
-        const cashFlowData = dataMap.get(this.lookbackDays);
-        const assetFlowData = dataMap.get(this.lookbackDays + 1);
-
-        if (!cashFlowData || !assetFlowData) {
-            logger.log('WARN', `[CashFlowDeployment] Missing dependency data for ${dateStr}. Skipping.`);
-            return null;
-        }
+        // --- REMOVED ---
+        // The check for cashFlowData and assetFlowData was here
+        // but has been moved up.
+        // --- END REMOVED ---
 
         const netSpendPct = cashFlowData.components?.trading_effect || 0;
         const netDepositPct = Math.abs(depositSignal.cash_flow_effect_proxy);
@@ -114,4 +122,4 @@ class CashFlowDeployment {
     reset() {}
 }
 
-module.exports = CashFlowDeployment;
+module.exports = CashFlowDeployment;

package/calculations/meta/cash-flow-liquidation.js

@@ -59,6 +59,18 @@ class CashFlowLiquidation {
             if (snap.exists) dataMap.set(idx, snap.data());
         });
 
+        // --- START MODIFICATION ---
+        // Check for THIS DATE's dependencies (cash-flow and asset-flow) FIRST.
+        const cashFlowData = dataMap.get(this.lookbackDays);
+        const assetFlowData = dataMap.get(this.lookbackDays + 1);
+
+        if (!cashFlowData || !assetFlowData) {
+            logger.log('WARN', `[CashFlowLiquidation] Missing critical dependency data (cash-flow or asset-flow) for ${dateStr}. Skipping to allow backfill.`);
+            return null; // This allows backfill
+        }
+        // --- END MODIFICATION ---
+
+
         // 2. Find the withdrawal signal
         let withdrawalSignal = null;
         let withdrawalSignalDay = null;
@@ -92,14 +104,10 @@ class CashFlowLiquidation {
             };
         }
 
-        // 3. Get today's data to find the correlation
-        const cashFlowData = dataMap.get(this.lookbackDays);
-        const assetFlowData = dataMap.get(this.lookbackDays + 1);
-
-        if (!cashFlowData || !assetFlowData) {
-            logger.log('WARN', `[CashFlowLiquidation] Missing dependency data for ${dateStr}. Skipping.`);
-            return null;
-        }
+        // --- REMOVED ---
+        // The check for cashFlowData and assetFlowData was here
+        // but has been moved up.
+        // --- END REMOVED ---
 
         // 'trading_effect' will be negative if the crowd is net-selling
         const netSellPct = cashFlowData.components?.trading_effect || 0;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "aiden-shared-calculations-unified",
-  "version": "1.0.31",
+  "version": "1.0.32",
   "description": "Shared calculation modules for the BullTrackers Computation System.",
   "main": "index.js",
   "files": [