aiden-shared-calculations-unified 1.0.28 → 1.0.29

package/calculations/behavioural/historical/asset_crowd_flow.js

@@ -81,64 +81,85 @@ class AssetCrowdFlow {
 
     async getResult() {
         if (this.user_count === 0 || !this.dates.today) {
-            return {}; // No users processed or dates not found
+            console.warn('[AssetCrowdFlow] No users processed or dates missing.');
+            return {};
         }
 
-        // Load dependencies (prices and mappings) in parallel
+        // Load priceMap and mappings if not loaded
         if (!this.priceMap || !this.mappings) {
-            const [priceData, mappingData] = await Promise.all([
-                loadAllPriceData(),
-                loadInstrumentMappings()
-            ]);
-            this.priceMap = priceData;
-            this.mappings = mappingData;
+            try {
+                const [priceData, mappingData] = await Promise.all([
+                    loadAllPriceData(),
+                    loadInstrumentMappings()
+                ]);
+                this.priceMap = priceData;
+                this.mappings = mappingData;
+            } catch (err) {
+                console.error('[AssetCrowdFlow] Failed to load dependencies:', err);
+                return {};
+            }
         }
-        
+
         const finalResults = {};
         const todayStr = this.dates.today;
         const yesterdayStr = this.dates.yesterday;
 
-        for (const instrumentId in this.asset_values) {
-            const ticker = this.mappings.instrumentToTicker[instrumentId] || `id_${instrumentId}`;
-            
-            // 1. Calculate average % values
-            const avg_day1_value = this.asset_values[instrumentId].day1_value_sum / this.user_count;
-            const avg_day2_value = this.asset_values[instrumentId].day2_value_sum / this.user_count;
-            
-            // 2. Get the actual price change
-            const priceChangePct = getDailyPriceChange(instrumentId, yesterdayStr, todayStr, this.priceMap);
+        for (const rawInstrumentId in this.asset_values) {
+            const instrumentId = String(rawInstrumentId); // normalize
+            const ticker = this.mappings.instrumentToTicker?.[instrumentId] || `id_${instrumentId}`;
+
+            const avg_day1_value = this.asset_values[rawInstrumentId].day1_value_sum / this.user_count;
+            const avg_day2_value = this.asset_values[rawInstrumentId].day2_value_sum / this.user_count;
+
+            let priceChangePct = null;
+
+            // Check priceMap presence
+            if (!this.priceMap || !this.priceMap[instrumentId]) {
+                console.debug(`[AssetCrowdFlow] Missing priceMap entry for instrumentId ${instrumentId} (${ticker})`);
+            } else {
+                const priceDay1 = this.priceMap[instrumentId][yesterdayStr];
+                const priceDay2 = this.priceMap[instrumentId][todayStr];
+
+                if (priceDay1 == null) console.debug(`[AssetCrowdFlow] Missing price for ${instrumentId} (${ticker}) on ${yesterdayStr}`);
+                if (priceDay2 == null) console.debug(`[AssetCrowdFlow] Missing price for ${instrumentId} (${ticker}) on ${todayStr}`);
+
+                if (priceDay1 != null && priceDay2 != null && priceDay1 > 0) {
+                    priceChangePct = (priceDay2 - priceDay1) / priceDay1;
+                }
+            }
 
             if (priceChangePct === null) {
-                // Cannot calculate if price data is missing for either day
                 finalResults[ticker] = {
                     net_crowd_flow_pct: 0,
-                    error: "Missing price data for calculation."
+                    avg_value_day1: avg_day1_value,
+                    avg_value_day2: avg_day2_value,
+                    price_change_pct: null,
+                    user_sample_size: this.user_count,
+                    warning: 'Missing price data for calculation'
                 };
                 continue;
             }
 
-            // 3. Calculate the expected value (the "price-move" effect)
-            // We use avg_day1_value as the base. The cash flow proxy calculation
-            // uses (avg_value - avg_invested) because it's solving for a different unknown.
-            // Here, we are solving for flow *relative to the asset itself*.
+            // Calculate expected day2 value from price movement
             const expected_day2_value = avg_day1_value * (1 + priceChangePct);
 
-            // 4. Find the signal (the "crowd-flow" effect)
+            // Net crowd flow = actual minus expected
             const net_crowd_flow_pct = avg_day2_value - expected_day2_value;
 
             finalResults[ticker] = {
-                net_crowd_flow_pct: net_crowd_flow_pct,
-                avg_value_day1_pct: avg_day1_value,
-                avg_value_day2_pct: avg_day2_value,
-                expected_value_day2_pct: expected_day2_value,
+                net_crowd_flow_pct,
+                avg_value_day1,
+                avg_value_day2,
+                expected_day2_value,
                 price_change_pct: priceChangePct,
                 user_sample_size: this.user_count
             };
         }
-        
+
         return finalResults;
     }
 
+
     reset() {
         this.asset_values = {};
         this.user_count = 0;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "aiden-shared-calculations-unified",
-  "version": "1.0.28",
+  "version": "1.0.29",
   "description": "Shared calculation modules for the BullTrackers Computation System.",
   "main": "index.js",
   "files": [