aiden-shared-calculations-unified 1.0.2 → 1.0.4

package/calculations/asset_metrics/asset_dollar_metrics.js

@@ -17,7 +17,7 @@ class AssetDollarMetrics {
         }
     }
 
-    process(portfolioData, userId, context) {
+    process(portfolioData, yesterdayPortfolio, userId, context, todayInsights, yesterdayInsights) {
         const { instrumentMappings } = context;
 
         // FIX: Use the correct portfolio position properties

package/calculations/asset_metrics/asset_position_size.js

@@ -9,7 +9,7 @@ class AssetPositionSize {
         this.mappings = null;
     }
 
-    process(portfolioData, userId, context) {
+    process(portfolioData, yesterdayPortfolio, userId, context, todayInsights, yesterdayInsights) {
         const positions = portfolioData.AggregatedPositions || portfolioData.PublicPositions;
         if (!positions || !Array.isArray(positions)) return;
 

package/calculations/pnl/asset_pnl_status.js

@@ -12,8 +12,8 @@ class AssetPnlStatus {
             this.assets[ticker] = { profit_count: 0, loss_count: 0 };
         }
     }
-
-    process(portfolioData, userId, context) {
+    
+    process(portfolioData, yesterdayPortfolio, userId, context, todayInsights, yesterdayInsights) {
         const { instrumentMappings } = context;
         const processedTickers = new Set(); // Ensure one user is only counted once per ticker
 

package/calculations/pnl/profitable_and_unprofitable_status.js

@@ -0,0 +1,65 @@
+/**
+ * @fileoverview Counts the number of users whose overall portfolio is in profit vs. loss for the current day.
+ */
+
+class DailyUserPnlStatus {
+    constructor() {
+        // Initialize counters
+        this.profitableUsers = 0;
+        this.unprofitableUsers = 0;
+    }
+
+    /**
+     * Processes a single user's portfolio for the current day.
+     * @param {object} todayPortfolio - The portfolio data for the current day.
+     * @param {object} yesterdayPortfolio - Not used in this calculation.
+     * @param {string} userId - The user's ID.
+     * @param {object} context - Shared context data (not used here).
+     */
+    process(todayPortfolio, yesterdayPortfolio, userId, context) {
+        // Prefer AggregatedPositions as it typically contains NetProfit
+        const positions = todayPortfolio?.AggregatedPositions || todayPortfolio?.PublicPositions;
+
+        // Ensure we have portfolio data and positions
+        if (!positions || !Array.isArray(positions) || positions.length === 0) {
+            return; // Skip if no positions data for the user today
+        }
+
+        // Calculate the sum of NetProfit across all positions for the user
+        let totalUserPnl = 0;
+        for (const position of positions) {
+            // Ensure NetProfit exists and is a number, default to 0 otherwise
+            totalUserPnl += (typeof position.NetProfit === 'number' ? position.NetProfit : 0);
+        }
+
+        // Increment the appropriate counter based on the total P/L
+        if (totalUserPnl > 0) {
+            this.profitableUsers++;
+        } else if (totalUserPnl < 0) {
+            this.unprofitableUsers++;
+        }
+        // Users with exactly zero P/L are ignored
+    }
+
+    /**
+     * Returns the final aggregated counts.
+     * @returns {object} Object containing the counts of profitable and unprofitable users.
+     */
+    getResult() {
+        // Return the raw counts
+        return {
+            profitable_user_count: this.profitableUsers,
+            unprofitable_user_count: this.unprofitableUsers
+        };
+    }
+
+    /**
+     * Resets the internal counters for the next processing run.
+     */
+    reset() {
+        this.profitableUsers = 0;
+        this.unprofitableUsers = 0;
+    }
+}
+
+module.exports = DailyUserPnlStatus;

package/calculations/sectors/sector_dollar_metrics.js

@@ -17,7 +17,7 @@ class SectorDollarMetrics {
         }
     }
 
-    process(portfolioData, userId, context) {
+    process(portfolioData, yesterdayPortfolio, userId, context, todayInsights, yesterdayInsights) {
         const { sectorMapping } = context; // Assumes sectorMapping is in context
 
         // FIX: Use the correct portfolio position properties

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "aiden-shared-calculations-unified",
-  "version": "1.0.2",
+  "version": "1.0.4",
   "description": "Shared calculation modules for the BullTrackers Computation System.",
   "main": "index.js",
   "files": [