aicodeman 1.44.0 → 1.45.0

package/dist/web/routes/session-routes.js

@@ -3,6 +3,7 @@
  * Covers session CRUD, input/output, terminal buffer, quick-start, quick-run,
  * auto-clear, auto-compact, image watcher, flicker filter, and logout.
  */
+import { claudeProjectDirName } from '../../case-rename.js';
 import { join, dirname, extname, basename, resolve as resolvePath } from 'node:path';
 import { homedir } from 'node:os';
 import { existsSync, statSync, mkdirSync, writeFileSync } from 'node:fs';
@@ -27,8 +28,9 @@ import { TabLayoutValidationError } from '../../tab-layout.js';
 import { sessionWaits, resolveWaitSignals, sessionHookOptions, signalForStatus, WaitCapacityError, } from '../session-wait-registry.js';
 import { RemoteWakeRegistry, REMOTE_WAKE_REQUEST_READY_TIMEOUT_MS, createDefaultRemoteWakeDeps, isProbeable, } from '../../remote-wake.js';
 import { clampWaitMs, MAX_BUFFER_SCAN_BYTES } from '../../config/agent-wait.js';
-import { autoConfigureRalph, canAccessOwned, CASES_DIR, findPersistedSessionOrFail, findSessionOrFail, getAuthUser, isAdmin, isPlainPromptInput, isWorkingDirAllowed, ownerFor, parseBody, persistAndBroadcastSession, readJsonConfig, resolveAgentCaseOrigin, resolveCasesDir, resolveParentSessionId, sessionCapacityMessage, SETTINGS_PATH, validatePathWithinBase, } from '../route-helpers.js';
+import { autoConfigureRalph, canAccessOwned, CASES_DIR, findPersistedSessionOrFail, findSessionOrFail, getAuthUser, isAdmin, isPlainPromptInput, isWorkingDirAllowed, ownerFor, parseBody, persistAndBroadcastSession, readJsonConfig, resolveAgentCaseOrigin, resolveCasesDir, resolveParentSessionId, sessionCapacityMessage, SETTINGS_PATH, validatePathWithinBase, waitCapacityResponse, abortOnClientHangUp, } from '../route-helpers.js';
 import { buildAgentCaseMarker, writeAgentCaseMarker } from '../../agent-case-marker.js';
+import { agentInbox } from '../agent-inbox.js';
 import { canUsernameRunPrivilegedCommands, resolveClaudeModeForUsername } from '../../user-store.js';
 import { clampEnvOverridesForOwner } from '../../session-env-clamp.js';
 import { enabledClis, getCli } from '../../config/cli-registry/registry.js';
@@ -548,22 +550,6 @@ function parseWaitQuery(schema, query, label) {
         body: createErrorResponse(ApiErrorCode.INVALID_INPUT, message),
     });
 }
-/**
- * Map a waiter-cap rejection to the code that tells the caller the truth.
- *
- * The two caps mean different things and warrant different recovery: `session` is
- * genuinely about THIS session, while `owner` and `total` are process-wide budgets
- * that say nothing about it. Reporting a global cap as `SESSION_BUSY` (409,
- * documented as "Session is busy") sent an agent off to a different session to hit
- * the identical error. `RATE_LIMITED` is the code whose whole meaning is "come back
- * later", and clients and proxies already treat 429 that way.
- */
-function waitCapacityResponse(err) {
-    const code = err.scope === 'session' ? ApiErrorCode.SESSION_BUSY : ApiErrorCode.RATE_LIMITED;
-    // The registry's message already names the scope and the limit; passing it through
-    // verbatim keeps the wording in one place.
-    return createErrorResponse(code, err.message);
-}
 /**
  * The signal a session is ALREADY emitting, corrected for liveness.
  *
@@ -730,34 +716,6 @@ export function _resetPaneLivenessState() {
 export function _paneDeathWatcherCount() {
     return paneDeathWatchers.size;
 }
-/**
- * An `AbortController` that fires when the CLIENT goes away, and only then.
- *
- * Freeing an abandoned waiter matters because the documented pattern is a loop of
- * short waits: `curl --max-time 30 ".../wait?timeout=600000"` abandons a live waiter
- * every iteration until the cap is hit and an innocent session reports busy. Same for
- * any proxy that cuts the connection.
- *
- * ⚠️ **It must listen on the RESPONSE, not the request.** `req.raw` emits `'close'`
- * as soon as the request body has finished streaming, which on a POST is BEFORE the
- * handler ever blocks — measured at +1ms with `aborted: false`, indistinguishable
- * from a real hang-up at +0ms. Wiring the abort there cancels every send-and-wait
- * instantly and silently kills the feature (it survives on GET only because a GET has
- * no body to finish). `reply.raw` emits `'close'` both when the response completes
- * and when the socket dies, and `writableFinished` is what tells those apart: true
- * only if the response actually went out. The guard is load-bearing, not defensive.
- *
- * `app.inject()` never emits `'close'` at all, so this is only observable over real
- * HTTP — which is why the regression test for it binds a port.
- */
-function abortOnClientHangUp(reply) {
-    const controller = new AbortController();
-    reply.raw.on('close', () => {
-        if (!reply.raw.writableFinished)
-            controller.abort();
-    });
-    return controller;
-}
 /**
  * Inject the agent skill into a case on create, surfacing only the REFUSALS.
  *
@@ -1403,6 +1361,9 @@ options = {}) {
             // below re-looks-up the record by id, so the returned SessionState is unused here.
             findPersistedSessionOrFail(ctx.store, id, req);
             ctx.store.demoteOrRemoveSession(id);
+            // A detached session kept its agent inbox (server.ts _doCleanupSession drops it
+            // only on killMux); retiring the row is the delete, so the mail goes now.
+            agentInbox.drop(id);
             // Mirrors the broadcast at the tail of the live-session cleanup path
             // (_doCleanupSession in server.ts) — without it, other open tabs keep
             // showing the retired row until their next unrelated fetch.
@@ -4453,6 +4414,7 @@ options = {}) {
         if (!stat?.isDirectory())
             return out;
         const workingDir = await decodeProjectKey(projDir);
+        const staleCwd = new Map();
         const entries = await fs.readdir(projPath).catch(() => []);
         for (const entry of entries) {
             if (!entry.endsWith('.jsonl'))
@@ -4554,13 +4516,29 @@ options = {}) {
                 worktreeName: headGit.worktreeName ?? tailGit.worktreeName,
                 worktreeRepo: headGit.worktreeRepo ?? tailGit.worktreeRepo,
             };
+            // A case rename moves the project directory but leaves the old path in each transcript's
+            // cwd. When that cwd is gone and the decoded key is a real folder that encodes back to this
+            // very key (not the $HOME collapse of #265), the key is the truer answer.
+            let cwd = git.cwd;
+            if (cwd !== undefined && cwd !== workingDir) {
+                let stale = staleCwd.get(cwd);
+                if (stale === undefined) {
+                    stale =
+                        claudeProjectDirName(workingDir) === projDir &&
+                            (await fs.stat(cwd).then(() => false, () => true)) &&
+                            (await fs.stat(workingDir).then((s) => s.isDirectory(), () => false));
+                    staleCwd.set(cwd, stale);
+                }
+                if (stale)
+                    cwd = undefined;
+            }
             out.push({
                 sessionId,
                 // The transcript's literal cwd beats decodeProjectKey's stat-walked guess,
                 // which silently collapses to $HOME once the directory is gone (#265).
                 // Absent cwd falls back to the old behaviour rather than inventing a path.
-                workingDir: git.cwd ?? workingDir,
-                workingDirExact: git.cwd !== undefined,
+                workingDir: cwd ?? workingDir,
+                workingDirExact: cwd !== undefined,
                 projectKey: projDir,
                 sizeBytes: fileStat.size,
                 lastModified: fileStat.mtime.toISOString(),