aicodeman 1.35.0 → 1.40.0

package/dist/web/routes/session-routes.js

@@ -11,7 +11,7 @@ import fs from 'node:fs/promises';
 import { randomBytes, randomUUID } from 'node:crypto';
 import { performance } from 'node:perf_hooks';
 import { ApiErrorCode, createErrorResponse, getErrorMessage, } from '../../types.js';
-import { Session, cliTakesSessionModel, isAltScreenStripMode, isExternalCliMode, isMuxAltScreenOnlyStripMode, } from '../../session.js';
+import { Session, cliTakesSessionModel, isAltScreenStripMode, isExternalCliMode, isMuxAltScreenOnlyStripMode, isMuxMouseStripMode, } from '../../session.js';
 import { SseEvent } from '../sse-events.js';
 import { webviewCapabilities } from '../../webview-capabilities.js';
 import { CreateSessionSchema, SessionNameSchema, SessionColorSchema, RunPromptSchema, SessionInputWithLimitSchema, ResizeSchema, AutoClearSchema, AutoCompactSchema, AutoResumeSchema, PinSessionSchema, ImageWatcherSchema, FlickerFilterSchema, QuickRunSchema, QuickStartSchema, InteractiveStartSchema, SessionOrderUpdateSchema, SessionWaitQuerySchema, SessionWaitOutputQuerySchema, CustomModelSelectionSchema, } from '../schemas.js';
@@ -30,6 +30,7 @@ import { canUsernameRunPrivilegedCommands, resolveClaudeModeForUsername } from '
 import { clampEnvOverridesForOwner } from '../../session-env-clamp.js';
 import { enabledClis, getCli } from '../../config/cli-registry/registry.js';
 import { resolveCliLaunchError } from '../../utils/cli-launcher.js';
+import { applyLaunchDefaults } from '../launch-defaults.js';
 import { legacyConfigForMode } from '../../session-cli-registry-bridge.js';
 import { isMultiUserMode } from '../../config/multiuser.js';
 import { AUTH_COOKIE_NAME } from '../middleware/auth.js';
@@ -88,6 +89,37 @@ const ERASE_SCROLLBACK_PATTERN = /\x1b\[3J/g;
 // strip existed can still carry them; strip on replay for parity.
 // eslint-disable-next-line no-control-regex
 const MOUSE_TRACKING_PATTERN = /\x1b\[\?(?:1000|1001|1002|1003|1005|1006|1007)[hl]/g;
+/**
+ * The replay half of the strip parity triangle: what `_handleTerminalOutput` (session.ts)
+ * removes from the live stream, removed again from a stored buffer before it is replayed,
+ * because a buffer recorded before the live-side strip existed (or by an older server)
+ * still carries the sequences, and one replayed enable is enough to re-park xterm.
+ *
+ * - `strip-full` (claude/codex/gemini): alt-screen toggles, `3J` and mouse DECSETs.
+ *   xterm obeys the toggles by switching to its scrollback-less alt buffer and wiping
+ *   saved lines, so history disappeared on tab switch.
+ * - `strip-mux-and-mouse` (opencode, tmux-backed): alt-screen toggles and mouse DECSETs.
+ *   A replayed tracking enable parks xterm in report mode, where a drag goes to the CLI
+ *   instead of selecting text (and Ctrl+C without a selection is opencode's app_exit).
+ *   `3J` stays: a TUI is not a `clear` consumer.
+ * - every other mode, tmux-backed: tmux's own client smcup only (#205).
+ *
+ * Exported so the parity with the live strip is a test (claude-scrollback-strip.test.ts).
+ */
+export function stripReplayBuffer(buffer, mode, usesMux) {
+    if (isAltScreenStripMode(mode)) {
+        return buffer
+            .replace(ALT_SCREEN_TOGGLE_PATTERN, '')
+            .replace(ERASE_SCROLLBACK_PATTERN, '')
+            .replace(MOUSE_TRACKING_PATTERN, '');
+    }
+    if (isMuxMouseStripMode(mode, usesMux)) {
+        return buffer.replace(ALT_SCREEN_TOGGLE_PATTERN, '').replace(MOUSE_TRACKING_PATTERN, '');
+    }
+    if (isMuxAltScreenOnlyStripMode(mode, usesMux))
+        return buffer.replace(ALT_SCREEN_TOGGLE_PATTERN, '');
+    return buffer;
+}
 /**
  * Strip redundant Ink spinner/status-bar redraw frames from the terminal buffer.
  * Ink (Claude Code's TUI) uses absolute cursor positioning (CSI n d = VPA) to animate
@@ -593,6 +625,20 @@ export function resolveOmpConfigForCreate(mode, workingDir, ompConfig) {
     }
     return resolvedId ? { ...ompConfig, resumeSessionId: resolvedId } : ompConfig;
 }
+/**
+ * The tmux history lines a full capture may read (`capture-pane -S -<n>`): the
+ * optional `lines` query parameter, an integer of at least 1, never more than
+ * the configured history limit; absent or malformed, the limit itself, as
+ * before. A grid tile sends its own scrollback size: its xterm keeps no more
+ * than that, while a capture of the whole history (tens of thousands of lines,
+ * cut to `tail` only afterwards) is synchronous work on this event loop.
+ */
+function captureHistoryLines(raw, historyLimit) {
+    if (typeof raw !== 'string' || !/^\d{1,9}$/.test(raw))
+        return historyLimit;
+    const lines = Number(raw);
+    return lines >= 1 ? Math.min(lines, historyLimit) : historyLimit;
+}
 /**
  * `RemoteHost` → the wake registry's host shape. They differ in one field name only
  * (`id` in host config vs `hostId` on a session's `remote`), but the rename is load-
@@ -880,6 +926,10 @@ options = {}) {
         const globalNice = await ctx.getGlobalNiceConfig();
         const modelConfig = await ctx.getModelConfig();
         const mode = body.mode || 'claude';
+        // Synced App Settings launch defaults (capabilities.launchDefaults, codex's model and
+        // effort today) fill the CLI's own config object where the caller left it unset.
+        // Local launches only: a remote attach runs whatever the remote pane already runs.
+        const launchBody = remote ? body : await applyLaunchDefaults(mode, body);
         // Where a model override comes from is a capability, and the three answers are
         // genuinely different mechanisms:
         //   'flag'                 — the CLI takes --model, so read the value the caller sent
@@ -893,7 +943,7 @@ options = {}) {
         //                            (docs/deepseek-integration.md). Both get nothing.
         const modelSource = getCli(mode)?.capabilities.model;
         const model = modelSource?.source === 'flag'
-            ? legacyConfigForMode(mode, body)?.[modelSource.param ?? 'model']
+            ? legacyConfigForMode(mode, launchBody)?.[modelSource.param ?? 'model']
             : modelSource?.source === 'claude-settings-file'
                 ? body.model || modelConfig?.defaultModel || undefined
                 : undefined;
@@ -901,7 +951,7 @@ options = {}) {
         // Section 6.3: force non-granted users to a classifier-guarded mode.
         const effectiveClaudeMode = await resolveClaudeModeForUsername(claudeModeConfig.claudeMode, owner);
         // Section 6.3: clamp Codex/Gemini/Antigravity bypass switches for a non-granted owner (no-op single-user/granted).
-        const { codexConfig: gatedCodexConfig, geminiConfig: gatedGeminiConfig, antigravityConfig: gatedAntigravityConfig, piConfig: gatedPiConfig, grokConfig: gatedGrokConfig, deepSeekConfig: gatedDeepSeekConfig, } = await _clampExternalCliBypassForOwner(owner, body.codexConfig, body.geminiConfig, body.antigravityConfig, body.piConfig, body.grokConfig, body.deepSeekConfig);
+        const { codexConfig: gatedCodexConfig, geminiConfig: gatedGeminiConfig, antigravityConfig: gatedAntigravityConfig, piConfig: gatedPiConfig, grokConfig: gatedGrokConfig, deepSeekConfig: gatedDeepSeekConfig, } = await _clampExternalCliBypassForOwner(owner, launchBody.codexConfig, launchBody.geminiConfig, launchBody.antigravityConfig, launchBody.piConfig, launchBody.grokConfig, launchBody.deepSeekConfig);
         const terminalHistoryConfig = await ctx.getTerminalHistoryConfig();
         const session = new Session({
             workingDir,
@@ -913,14 +963,14 @@ options = {}) {
             model,
             claudeMode: effectiveClaudeMode,
             allowedTools: claudeModeConfig.allowedTools,
-            openCodeConfig: mode === 'opencode' ? body.openCodeConfig : undefined,
+            openCodeConfig: mode === 'opencode' ? launchBody.openCodeConfig : undefined,
             codexConfig: mode === 'codex' ? gatedCodexConfig : undefined,
             geminiConfig: mode === 'gemini' ? gatedGeminiConfig : undefined,
             antigravityConfig: mode === 'antigravity' ? gatedAntigravityConfig : undefined,
             piConfig: mode === 'pi' ? gatedPiConfig : undefined,
             grokConfig: mode === 'grok' ? gatedGrokConfig : undefined,
             deepSeekConfig: mode === 'deepseek' ? gatedDeepSeekConfig : undefined,
-            ompConfig: resolveOmpConfigForCreate(mode, workingDir, body.ompConfig),
+            ompConfig: resolveOmpConfigForCreate(mode, workingDir, launchBody.ompConfig),
             resumeSessionId: validatedResumeId,
             envOverrides: await clampEnvOverridesForOwner(owner, body.envOverrides),
             effort: body.effort,
@@ -2594,8 +2644,14 @@ options = {}) {
         // single reason: `capturedGeometry` comes BACK on it, and the response has
         // to tell the client what size the frame it is about to render was built
         // for. See PaneCaptureOptions.capturedGeometry.
+        // `lines` bounds only the history a FULL capture reads; the visible-frame
+        // path reads no history and is untouched by it.
         const captureOpts = isFullReload
-            ? { fullHistory: true, historyLimitLines: tmuxHistoryLimit, maxCaptureBytes: terminalBufferMaxBytes }
+            ? {
+                fullHistory: true,
+                historyLimitLines: captureHistoryLines(query.lines, tmuxHistoryLimit),
+                maxCaptureBytes: terminalBufferMaxBytes,
+            }
             : {};
         const liveMuxBuffer = muxName && typeof ctx.mux.captureActivePaneBuffer === 'function'
             ? ctx.mux.captureActivePaneBuffer(muxName, captureOpts)
@@ -2667,22 +2723,9 @@ options = {}) {
         let strippedBuffer = isFullCapture || getCli(session.mode)?.capabilities.stripInkBloat === false
             ? rawBuffer
             : stripInkRedrawBloat(rawBuffer);
-        // Strip alt-screen toggles and scrollback-erase from Codex/Claude byte
-        // streams. xterm.js obeys them by switching to its scrollback-less alt
-        // buffer and wiping saved lines, so conversation history disappears on tab
-        // switch. Same gate as the live-stream strip in session.ts.
-        if (isAltScreenStripMode(session.mode)) {
-            strippedBuffer = strippedBuffer
-                .replace(ALT_SCREEN_TOGGLE_PATTERN, '')
-                .replace(ERASE_SCROLLBACK_PATTERN, '')
-                .replace(MOUSE_TRACKING_PATTERN, '');
-        }
-        else if (isMuxAltScreenOnlyStripMode(session.mode, session.usesMux)) {
-            // tmux-backed shell/opencode/antigravity: drop tmux's own client smcup only.
-            // A byte buffer recorded before the live-side strip existed can still carry
-            // it, and one replayed `\x1b[?1049h` re-parks xterm in the alt buffer (#205).
-            strippedBuffer = strippedBuffer.replace(ALT_SCREEN_TOGGLE_PATTERN, '');
-        }
+        // Same strip as the live stream (session.ts), so a buffer recorded before the
+        // live-side strip existed cannot re-park xterm on replay. See stripReplayBuffer.
+        strippedBuffer = stripReplayBuffer(strippedBuffer, session.mode, session.usesMux);
         if (tailBytes > 0 && strippedBuffer.length > tailBytes) {
             // Fast path: tail from the end, skip expensive banner search on full 2MB buffer.
             // Banner is near the top and gets discarded by tail anyway.
@@ -3295,28 +3338,37 @@ options = {}) {
         // Apply global Nice priority config and model config from settings
         const niceConfig = await ctx.getGlobalNiceConfig();
         const qsModelConfig = await ctx.getModelConfig();
+        // Synced App Settings launch defaults, as on the create path: local launches only, so
+        // never a remote or Docker case, and never a custom model endpoint launch.
+        const qsRequestConfigs = {
+            openCodeConfig,
+            codexConfig,
+            geminiConfig,
+            antigravityConfig,
+            piConfig,
+            grokConfig,
+            deepSeekConfig,
+            ompConfig,
+        };
+        const qsLaunchConfigs = remote || docker ? qsRequestConfigs : await applyLaunchDefaults(mode, qsRequestConfigs, !!customModel);
+        // ⚠️ The model is read from a bag WITHOUT ompConfig, as it always was here: quick-start
+        // has never taken omp's session model from ompConfig (the create path does). Kept as
+        // found rather than changed in passing.
+        const { ompConfig: qsLaunchOmpConfig, ...qsModelConfigs } = qsLaunchConfigs;
         // See the create path for why this is a capability rather than a mode ladder.
         const qsModelSource = getCli(mode)?.capabilities.model;
         const qsModel = qsModelSource?.source === 'flag'
-            ? legacyConfigForMode(mode, {
-                openCodeConfig,
-                codexConfig,
-                geminiConfig,
-                antigravityConfig,
-                piConfig,
-                grokConfig,
-                deepSeekConfig,
-            })?.[qsModelSource.param ?? 'model']
+            ? legacyConfigForMode(mode, qsModelConfigs)?.[qsModelSource.param ?? 'model']
             : qsModelSource?.source === 'claude-settings-file'
                 ? qsModelConfig?.defaultModel || undefined
                 : undefined;
         const qsClaudeModeConfig = await ctx.getClaudeModeConfig();
         const qsEffectiveClaudeMode = await resolveClaudeModeForUsername(qsClaudeModeConfig.claudeMode, owner);
         // Section 6.3: clamp Codex/Gemini/Antigravity bypass switches for a non-granted owner (no-op single-user/granted).
-        const { codexConfig: qsGatedCodexConfig, geminiConfig: qsGatedGeminiConfig, antigravityConfig: qsGatedAntigravityConfig, piConfig: qsGatedPiConfig, grokConfig: qsGatedGrokConfig, deepSeekConfig: qsGatedDeepSeekConfig, } = await _clampExternalCliBypassForOwner(owner, codexConfig, geminiConfig, antigravityConfig, piConfig, grokConfig, deepSeekConfig);
+        const { codexConfig: qsGatedCodexConfig, geminiConfig: qsGatedGeminiConfig, antigravityConfig: qsGatedAntigravityConfig, piConfig: qsGatedPiConfig, grokConfig: qsGatedGrokConfig, deepSeekConfig: qsGatedDeepSeekConfig, } = await _clampExternalCliBypassForOwner(owner, qsLaunchConfigs.codexConfig, qsLaunchConfigs.geminiConfig, qsLaunchConfigs.antigravityConfig, qsLaunchConfigs.piConfig, qsLaunchConfigs.grokConfig, qsLaunchConfigs.deepSeekConfig);
         const qsTerminalHistoryConfig = await ctx.getTerminalHistoryConfig();
         const qsGatedEnvOverrides = await clampEnvOverridesForOwner(owner, envOverrides);
-        const qsResolvedOmpConfig = resolveOmpConfigForCreate(mode, resolvedCasePath, ompConfig);
+        const qsResolvedOmpConfig = resolveOmpConfigForCreate(mode, resolvedCasePath, qsLaunchOmpConfig);
         // Custom Model Endpoint Profiles, applied AT CREATE TIME (docs/custom-model-endpoints-plan.md)
         // rather than via the dedicated restart-in-place route (POST /api/sessions/:id/custom-
         // model, still what an ALREADY-RUNNING session uses to switch later): computing the
@@ -3442,7 +3494,7 @@ options = {}) {
             claudeMode: qsEffectiveClaudeMode,
             allowedTools: qsClaudeModeConfig.allowedTools,
             owner,
-            openCodeConfig: mode === 'opencode' ? openCodeConfig : undefined,
+            openCodeConfig: mode === 'opencode' ? qsLaunchConfigs.openCodeConfig : undefined,
             codexConfig: mode === 'codex' ? qsGatedCodexConfig : undefined,
             geminiConfig: mode === 'gemini' ? qsGatedGeminiConfig : undefined,
             antigravityConfig: mode === 'antigravity' ? qsGatedAntigravityConfig : undefined,