ai-unit-test-generator 2.0.3 → 2.0.5

package/CHANGELOG.md

@@ -5,6 +5,66 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [2.0.5] - 2025-01-11
+
+### ✨ Feature: Simplified AI Suggestion Review
+
+**Problem**: Previous review UX was too complex, requiring category-by-category selection.
+
+**Solution**: Completely redesigned `lib/ai/reviewer.mjs` with:
+- ✅ **One-click Accept All** (`a`) - instantly accept all AI suggestions
+- ✅ **One-click Reject All** (`r`) - instantly reject all suggestions
+- ✅ **Partial Accept** (input numbers like `1,3,5`) - granular control
+- ✅ **Compact Display** - all suggestions shown at once with global indexing
+- ✅ **Clear Summary** - final acceptance count before applying changes
+
+**User Experience**:
+```bash
+ai-test analyze
+
+# AI 分析完成后立即展示所有建议：
+🤖 AI Analysis Results: 12 suggestions
+
+🔴 Business Critical Paths (5):
+  [1] services/payment/** | BC=10 | Conf: 95%
+      → Handles Stripe payment processing
+  [2] ...
+
+⚠️  High Risk Modules (4):
+  [6] utils/date/** | ER=8 | Conf: 88%
+      → Complex timezone calculations
+  [7] ...
+
+✅ Testability Adjustments (3):
+  [10] utils/** | Adj=+1 | Conf: 92%
+      → Pure functions, easy to test
+
+❓ Choose action:
+   [a] Accept all 12 suggestions
+   [r] Reject all
+   Or input numbers (comma-separated, e.g. 1,3,5-8)
+
+> a  # 或 r，或 1,3,5
+```
+
+**Changes**:
+- Removed multi-stage category review loop
+- Added global indexing across all categories
+- Simplified user input parsing (a/r/numbers only)
+- Removed per-category score adjustment (can be done manually after if needed)
+- Single confirmation step at the end
+
+---
+
+## [2.0.4] - 2025-01-11
+
+### 🐛 Hotfix
+- **Fixed**: ESM import error in `lib/workflows/analyze.mjs` - replaced `require` with proper `import`
+- Added `readFileSync` to imports at module top
+- Resolves `ReferenceError: require is not defined` in ESM context
+
+---
+
 ## [2.0.3] - 2025-01-11
 
 ### 🐛 Hotfix

package/lib/ai/reviewer.mjs

@@ -1,6 +1,6 @@
 /**
  * 交互式 AI 建议审核器
- * 支持分类审核、逐条选择、批量调整分数
+ * 支持：一键全接受、一键全拒绝、部分接受（输数字）
  */
 
 import readline from 'readline'
@@ -47,234 +47,200 @@ function getCategoryName(category) {
 }
 
 /**
- * 获取分类名称（小写）
- */
-function getCategoryNameLower(category) {
-  const names = {
-    businessCriticalPaths: 'business critical paths',
-    highRiskModules: 'high risk modules',
-    testabilityAdjustments: 'testability adjustments'
-  }
-  return names[category] || category
-}
-
-/**
- * 格式化单个建议
+ * 格式化单个建议（紧凑格式）
  */
 function formatSuggestion(item, index, category) {
-  let output = `\n  [${index}] ${item.pattern}\n`
+  let scoreInfo = ''
   
   if (category === 'businessCriticalPaths') {
-    output += `      BC: ${item.suggestedBC} | Confidence: ${(item.confidence * 100).toFixed(0)}%\n`
+    scoreInfo = `BC=${item.suggestedBC}`
   } else if (category === 'highRiskModules') {
-    output += `      ER: ${item.suggestedER} | Confidence: ${(item.confidence * 100).toFixed(0)}%\n`
+    scoreInfo = `ER=${item.suggestedER}`
   } else if (category === 'testabilityAdjustments') {
-    output += `      Adjustment: ${item.adjustment} | Confidence: ${(item.confidence * 100).toFixed(0)}%\n`
+    scoreInfo = `Adj=${item.adjustment}`
   }
   
-  output += `      Reason: ${item.reason}\n`
-  output += `      Evidence:\n`
-  item.evidence.forEach(e => {
-    output += `      - ${e}\n`
-  })
-  
-  return output
-}
-
-/**
- * 显示建议列表
- */
-function displaySuggestions(category, items) {
-  const icon = getCategoryIcon(category)
-  const name = getCategoryName(category)
-  
-  console.log(`\n━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━\n`)
-  console.log(`${icon} ${name} (${items.length} suggestions):`)
-  
-  items.forEach((item, i) => {
-    console.log(formatSuggestion(item, i + 1, category))
-  })
-  
-  console.log(`\n━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━\n`)
-}
-
-/**
- * 解析用户选择
- */
-function parseSelection(input, maxCount) {
-  if (!input || input.trim() === '') {
-    return []
-  }
+  const confidence = `${(item.confidence * 100).toFixed(0)}%`
   
-  return input.split(',')
-    .map(s => parseInt(s.trim()))
-    .filter(n => !isNaN(n) && n >= 1 && n <= maxCount)
+  return `  [${index}] ${item.pattern} | ${scoreInfo} | Conf: ${confidence}\n      → ${item.reason}`
 }
 
 /**
- * 批量调整分数
+ * 显示所有建议（紧凑视图）
  */
-async function adjustScores(rl, items, category) {
-  console.log(`\nAdjust scores (press Enter to keep original):`)
+function displayAllSuggestions(validated) {
+  const categories = ['businessCriticalPaths', 'highRiskModules', 'testabilityAdjustments']
+  const totalSuggestions = Object.values(validated).reduce((sum, arr) => sum + arr.length, 0)
   
-  const scoreField = category === 'businessCriticalPaths' ? 'suggestedBC' : 'suggestedER'
-  const minScore = category === 'businessCriticalPaths' ? 8 : 7
-  const maxScore = 10
+  console.log(`\n━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━`)
+  console.log(`\n🤖 AI Analysis Results: ${totalSuggestions} suggestions\n`)
   
-  const adjusted = []
+  let globalIndex = 1
+  const indexMapping = [] // [{ globalIndex, category, localIndex }, ...]
   
-  for (let i = 0; i < items.length; i++) {
-    const item = { ...items[i] }
-    const currentScore = item[scoreField]
+  for (const category of categories) {
+    const items = validated[category] || []
+    if (items.length === 0) continue
     
-    const input = await ask(rl, `  [${i + 1}] ${item.pattern} (${scoreField}: ${currentScore}): `)
+    const icon = getCategoryIcon(category)
+    const name = getCategoryName(category)
     
-    if (input && input.trim() !== '') {
-      const newScore = parseInt(input.trim())
-      if (!isNaN(newScore) && newScore >= minScore && newScore <= maxScore) {
-        item[scoreField] = newScore
-        console.log(`  ✅ Updated: ${currentScore} → ${newScore}`)
-      } else {
-        console.log(`  ⚠️  Invalid score (must be ${minScore}-${maxScore}), keeping original`)
-      }
-    }
+    console.log(`\n${icon} ${name} (${items.length}):`)
     
-    adjusted.push(item)
+    items.forEach((item, localIndex) => {
+      console.log(formatSuggestion(item, globalIndex, category))
+      indexMapping.push({ globalIndex, category, localIndex })
+      globalIndex++
+    })
   }
   
-  return adjusted
+  console.log(`\n━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━\n`)
+  
+  return { totalSuggestions, indexMapping }
 }
 
 /**
- * 审核单个分类
+ * 解析用户输入
  */
-async function reviewCategory(rl, category, items) {
-  if (items.length === 0) {
-    return []
-  }
+function parseUserInput(input, totalCount) {
+  const trimmed = input.trim().toLowerCase()
   
-  // 显示建议
-  displaySuggestions(category, items)
+  // 全接受
+  if (trimmed === 'a' || trimmed === 'all') {
+    return { type: 'accept_all' }
+  }
   
-  // 询问操作
-  const categoryName = getCategoryNameLower(category)
-  const action = await ask(rl,
-    `❓ Review ${categoryName}:\n` +
-    `   [a] Accept all (${items.length})\n` +
-    `   [r] Reject all\n` +
-    `   [s] Select individually\n` +
-    `   [n] Skip (keep empty)\n` +
-    `> `
-  )
+  // 全拒绝
+  if (trimmed === 'r' || trimmed === 'reject') {
+    return { type: 'reject_all' }
+  }
   
-  const actionLower = action.trim().toLowerCase()
+  // 部分接受（数字列表）
+  const numbers = input.split(',')
+    .map(s => parseInt(s.trim()))
+    .filter(n => !isNaN(n) && n >= 1 && n <= totalCount)
   
-  if (actionLower === 'a') {
-    // 接受全部
-    console.log(`✅ Accepted: ${items.length}/${items.length} ${categoryName}`)
-    
-    // 询问是否调整分数
-    if (category === 'businessCriticalPaths' || category === 'highRiskModules') {
-      const adjustInput = await ask(rl, `\nAdjust scores? (y/n) `)
-      if (adjustInput.trim().toLowerCase() === 'y') {
-        return await adjustScores(rl, items, category)
-      }
-    }
-    
-    return items
-  } else if (actionLower === 's') {
-    // 逐条选择
-    const selection = await ask(rl, `\nSelect which suggestions to accept (comma-separated, e.g. 1,3):\n> `)
-    const indices = parseSelection(selection, items.length)
-    
-    if (indices.length === 0) {
-      console.log(`❌ No suggestions selected`)
-      return []
-    }
-    
-    const selected = indices.map(i => items[i - 1])
-    console.log(`✅ Selected: ${selected.length}/${items.length} ${categoryName}`)
-    
-    // 询问是否调整分数
-    if (category === 'businessCriticalPaths' || category === 'highRiskModules') {
-      const adjustInput = await ask(rl, `\nAdjust scores? (y/n) `)
-      if (adjustInput.trim().toLowerCase() === 'y') {
-        return await adjustScores(rl, selected, category)
-      }
-    }
-    
-    return selected
-  } else if (actionLower === 'r') {
-    // 拒绝全部
-    console.log(`❌ Rejected: all ${categoryName}`)
-    return []
-  } else {
-    // 跳过
-    console.log(`⏭️  Skipped ${categoryName}`)
-    return []
+  if (numbers.length > 0) {
+    return { type: 'partial', indices: numbers }
   }
+  
+  return { type: 'invalid' }
 }
 
 /**
- * 显示总结
+ * 显示最终总结
  */
-function displaySummary(result, validated) {
+function displayFinalSummary(result, validated) {
   const totalSuggested = Object.values(validated).reduce((sum, arr) => sum + arr.length, 0)
   const totalAccepted = Object.values(result).reduce((sum, arr) => sum + arr.length, 0)
   
-  console.log(`\n━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━\n`)
-  console.log(`📊 Summary:`)
-  console.log(`   Business Critical Paths: ${result.businessCriticalPaths.length}/${validated.businessCriticalPaths?.length || 0} accepted`)
-  console.log(`   High Risk Modules: ${result.highRiskModules.length}/${validated.highRiskModules?.length || 0} accepted`)
-  console.log(`   Testability Adjustments: ${result.testabilityAdjustments.length}/${validated.testabilityAdjustments?.length || 0} accepted`)
-  console.log(`   Total: ${totalAccepted}/${totalSuggested} suggestions accepted`)
+  console.log(`\n━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━`)
+  console.log(`\n📊 Final Summary:`)
+  console.log(`   🔴 Business Critical Paths: ${result.businessCriticalPaths.length}/${validated.businessCriticalPaths?.length || 0}`)
+  console.log(`   ⚠️  High Risk Modules: ${result.highRiskModules.length}/${validated.highRiskModules?.length || 0}`)
+  console.log(`   ✅ Testability Adjustments: ${result.testabilityAdjustments.length}/${validated.testabilityAdjustments?.length || 0}`)
+  console.log(`   Total: ${totalAccepted}/${totalSuggested} accepted\n`)
   
-  if (totalAccepted === 0) {
-    console.log(`\n⚠️  No suggestions accepted. Config will not be modified.`)
+  if (totalAccepted > 0) {
+    console.log(`💡 These suggestions will be added to ai-test.config.jsonc`)
+    console.log(`   and will take effect on next: ai-test scan`)
   }
+  
+  console.log(`\n━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━\n`)
 }
 
 /**
- * 交互式审核
+ * 交互式审核（简化版）
  * @param {Object} validated - 已验证的建议
  * @returns {Object|null} - 用户批准的建议，或 null（取消）
  */
 export async function interactiveReview(validated) {
   const rl = createInterface()
   
-  const result = {
-    businessCriticalPaths: [],
-    highRiskModules: [],
-    testabilityAdjustments: []
-  }
-  
   try {
-    // 审核每个分类
-    const categories = ['businessCriticalPaths', 'highRiskModules', 'testabilityAdjustments']
+    // 1. 显示所有建议
+    const { totalSuggestions, indexMapping } = displayAllSuggestions(validated)
     
-    for (const category of categories) {
-      const items = validated[category] || []
-      if (items.length === 0) continue
-      
-      result[category] = await reviewCategory(rl, category, items)
+    if (totalSuggestions === 0) {
+      console.log('⚠️  No suggestions to review.')
+      rl.close()
+      return null
     }
     
-    // 显示总结
-    displaySummary(result, validated)
-    
-    const totalAccepted = Object.values(result).reduce((sum, arr) => sum + arr.length, 0)
+    // 2. 询问用户操作
+    const userInput = await ask(rl,
+      `❓ Choose action:\n` +
+      `   [a] Accept all ${totalSuggestions} suggestions\n` +
+      `   [r] Reject all\n` +
+      `   Or input numbers (comma-separated, e.g. 1,3,5-8)\n` +
+      `\n> `
+    )
+    
+    const parsed = parseUserInput(userInput, totalSuggestions)
+    
+    // 3. 处理用户选择
+    const result = {
+      businessCriticalPaths: [],
+      highRiskModules: [],
+      testabilityAdjustments: []
+    }
     
-    if (totalAccepted === 0) {
+    if (parsed.type === 'accept_all') {
+      // 全接受
+      result.businessCriticalPaths = validated.businessCriticalPaths || []
+      result.highRiskModules = validated.highRiskModules || []
+      result.testabilityAdjustments = validated.testabilityAdjustments || []
+      
+      console.log(`\n✅ Accepted all ${totalSuggestions} suggestions`)
+      
+    } else if (parsed.type === 'reject_all') {
+      // 全拒绝
+      console.log(`\n❌ Rejected all suggestions`)
+      rl.close()
+      return null
+      
+    } else if (parsed.type === 'partial') {
+      // 部分接受
+      const selectedIndices = new Set(parsed.indices)
+      
+      indexMapping.forEach(({ globalIndex, category, localIndex }) => {
+        if (selectedIndices.has(globalIndex)) {
+          const item = validated[category][localIndex]
+          result[category].push(item)
+        }
+      })
+      
+      const totalAccepted = Object.values(result).reduce((sum, arr) => sum + arr.length, 0)
+      console.log(`\n✅ Accepted ${totalAccepted}/${totalSuggestions} suggestions`)
+      
+      if (totalAccepted === 0) {
+        console.log(`⚠️  No valid suggestions selected`)
+        rl.close()
+        return null
+      }
+      
+    } else {
+      // 无效输入
+      console.log(`\n❌ Invalid input. No changes made.`)
       rl.close()
       return null
     }
     
-    // 最终确认
-    const save = await ask(rl, `\n💾 Save these changes to ai-test.config.jsonc? (y/n)\n> `)
+    // 4. 显示最终总结
+    displayFinalSummary(result, validated)
+    
+    // 5. 最终确认
+    const confirm = await ask(rl, `💾 Apply these changes? (y/n)\n> `)
     
     rl.close()
     
-    return save.trim().toLowerCase() === 'y' ? result : null
+    if (confirm.trim().toLowerCase() === 'y') {
+      return result
+    } else {
+      console.log(`\n❌ Changes discarded.`)
+      return null
+    }
+    
   } catch (err) {
     rl.close()
     throw err

package/lib/workflows/analyze.mjs

@@ -3,7 +3,7 @@
  */
 
 import { spawn } from 'node:child_process'
-import { writeFileSync } from 'node:fs'
+import { writeFileSync, readFileSync } from 'node:fs'
 import { detectConfig } from '../utils/config-manager.mjs'
 import { sampleCodeFiles, analyzeProjectStructure } from '../ai/sampler.mjs'
 import { buildProjectContext } from '../ai/context-builder.mjs'
@@ -122,8 +122,6 @@ export async function analyze(options) {
  */
 async function callCursorAgent(promptPath) {
   return new Promise((resolve, reject) => {
-    const { readFileSync } = require('node:fs')
-    
     // 读取 prompt
     let prompt
     try {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "ai-unit-test-generator",
-  "version": "2.0.3",
+  "version": "2.0.5",
   "description": "AI-powered unit test generator with smart priority scoring",
   "keywords": [
     "unit-test",