ai-spec-dev 0.38.0 → 0.41.0

package/tests/dsl-coverage-checker.test.ts

@@ -0,0 +1,230 @@
+import { describe, it, expect } from "vitest";
+import {
+  extractKeywords,
+  extractSpecRequirements,
+  checkDslCoverage,
+  SpecRequirement,
+} from "../core/dsl-coverage-checker";
+import { SpecDSL } from "../core/dsl-types";
+
+// ─── extractKeywords ────────────────────────────────────────────────────────
+
+describe("extractKeywords", () => {
+  it("extracts English words", () => {
+    const kw = extractKeywords("Create order with payment");
+    expect(kw.has("create")).toBe(true);
+    expect(kw.has("order")).toBe(true);
+    expect(kw.has("payment")).toBe(true);
+  });
+
+  it("filters English stopwords", () => {
+    const kw = extractKeywords("the user is able to get a list");
+    expect(kw.has("the")).toBe(false);
+    expect(kw.has("is")).toBe(false);
+    expect(kw.has("list")).toBe(true);
+  });
+
+  it("extracts CJK characters and bigrams", () => {
+    const kw = extractKeywords("订单管理系统");
+    expect(kw.has("订")).toBe(true);
+    expect(kw.has("订单")).toBe(true);
+    expect(kw.has("管理")).toBe(true);
+  });
+
+  it("handles mixed CJK + English", () => {
+    const kw = extractKeywords("创建 order API 接口");
+    expect(kw.has("order")).toBe(true);
+    expect(kw.has("api")).toBe(true);
+    expect(kw.has("创建")).toBe(true);
+    expect(kw.has("接口")).toBe(true);
+  });
+
+  it("filters CJK stopwords", () => {
+    const kw = extractKeywords("用户可以使用系统");
+    // "用户", "可以", "使用", "系统" are all stopwords
+    expect(kw.has("用户")).toBe(false);
+    expect(kw.has("可以")).toBe(false);
+  });
+
+  it("returns empty set for empty input", () => {
+    expect(extractKeywords("").size).toBe(0);
+  });
+});
+
+// ─── extractSpecRequirements ────────────────────────────────────────────────
+
+describe("extractSpecRequirements", () => {
+  it("extracts Chinese user stories", () => {
+    const spec = `## 3. 用户故事
+- 作为 **管理员**，我希望 **查看所有订单**，以便 **管理业务**
+- 作为 **客户**，我希望 **提交订单**，以便 **购买商品**`;
+
+    const reqs = extractSpecRequirements(spec);
+    const stories = reqs.filter((r) => r.section === "user_story");
+    expect(stories.length).toBe(2);
+    expect(stories[0].id).toBe("US-1");
+    expect(stories[0].text).toContain("管理员");
+  });
+
+  it("extracts English user stories", () => {
+    const spec = `## 3. User Stories
+- As a **manager**, I want to **view all orders**, so that **I can manage business**
+- As an **admin**, I want to **delete users**`;
+
+    const reqs = extractSpecRequirements(spec);
+    const stories = reqs.filter((r) => r.section === "user_story");
+    expect(stories.length).toBe(2);
+  });
+
+  it("extracts functional requirements from checklist", () => {
+    const spec = `## 4. 功能需求
+- [ ] 创建订单接口，支持多商品
+- [ ] 订单状态流转（待支付→已支付→已发货→已完成）
+- [x] 查询订单列表，支持分页
+## 5. API 设计`;
+
+    const reqs = extractSpecRequirements(spec);
+    const frs = reqs.filter((r) => r.section === "functional_req");
+    expect(frs.length).toBe(3);
+    expect(frs[0].text).toContain("创建订单");
+  });
+
+  it("extracts numbered sub-items", () => {
+    const spec = `### 4. Functional Requirements
+4.1.1 Users can register with email and password
+4.1.2 Email verification is required
+## 5. API`;
+
+    const reqs = extractSpecRequirements(spec);
+    const frs = reqs.filter((r) => r.section === "functional_req");
+    expect(frs.length).toBe(2);
+  });
+
+  it("extracts boundary conditions", () => {
+    const spec = `### 边界条件
+- 当订单金额为0时，应返回错误
+- 库存不足时，应提示用户
+## 5. 下一节`;
+
+    const reqs = extractSpecRequirements(spec);
+    const bcs = reqs.filter((r) => r.section === "boundary_condition");
+    expect(bcs.length).toBe(2);
+    expect(bcs[0].id).toBe("BC-1");
+  });
+
+  it("returns empty for spec with no requirements", () => {
+    const reqs = extractSpecRequirements("# Overview\nSome description.");
+    expect(reqs.length).toBe(0);
+  });
+});
+
+// ─── checkDslCoverage ───────────────────────────────────────────────────────
+
+function makeDsl(overrides: Partial<SpecDSL> = {}): SpecDSL {
+  return {
+    version: "1.0",
+    feature: { id: "test", title: "Test Feature", description: "A test" },
+    models: [],
+    endpoints: [],
+    behaviors: [],
+    ...overrides,
+  };
+}
+
+describe("checkDslCoverage", () => {
+  it("returns 1.0 coverage when no requirements", () => {
+    const result = checkDslCoverage([], makeDsl());
+    expect(result.coverageRatio).toBe(1.0);
+  });
+
+  it("detects covered requirements via endpoint description match", () => {
+    const reqs: SpecRequirement[] = [
+      { id: "US-1", text: "查看所有订单列表", section: "user_story" },
+    ];
+    const dsl = makeDsl({
+      endpoints: [{
+        id: "EP-001", method: "GET", path: "/orders",
+        description: "获取订单列表，支持分页查询",
+        auth: true, successStatus: 200, successDescription: "ok",
+      }],
+    });
+
+    const result = checkDslCoverage(reqs, dsl);
+    expect(result.coverageRatio).toBe(1.0);
+    expect(result.covered.length).toBe(1);
+  });
+
+  it("detects uncovered requirements", () => {
+    const reqs: SpecRequirement[] = [
+      { id: "US-1", text: "export data to Excel spreadsheet", section: "user_story" },
+      { id: "US-2", text: "view order details", section: "user_story" },
+    ];
+    const dsl = makeDsl({
+      endpoints: [{
+        id: "EP-001", method: "GET", path: "/orders/:id",
+        description: "Get order details by ID",
+        auth: true, successStatus: 200, successDescription: "ok",
+      }],
+    });
+
+    const result = checkDslCoverage(reqs, dsl);
+    expect(result.uncovered.length).toBe(1);
+    expect(result.uncovered[0].id).toBe("US-1");
+    expect(result.coverageRatio).toBe(0.5);
+  });
+
+  it("matches via model field names", () => {
+    const reqs: SpecRequirement[] = [
+      { id: "FR-1", text: "record payment amount and payment method", section: "functional_req" },
+    ];
+    const dsl = makeDsl({
+      models: [{
+        name: "Payment",
+        fields: [
+          { name: "amount", type: "Float", required: true },
+          { name: "method", type: "String", required: true, description: "payment method" },
+        ],
+      }],
+    });
+
+    const result = checkDslCoverage(reqs, dsl);
+    expect(result.coverageRatio).toBe(1.0);
+  });
+
+  it("matches via behavior descriptions", () => {
+    const reqs: SpecRequirement[] = [
+      { id: "FR-1", text: "send email notification after order confirmed", section: "functional_req" },
+    ];
+    const dsl = makeDsl({
+      behaviors: [{
+        id: "BHV-001",
+        description: "Send email notification when order status changes to confirmed",
+        trigger: "order.confirmed",
+      }],
+    });
+
+    const result = checkDslCoverage(reqs, dsl);
+    expect(result.coverageRatio).toBe(1.0);
+  });
+
+  it("reports low coverage ratio correctly", () => {
+    const reqs: SpecRequirement[] = [
+      { id: "US-1", text: "manage user permissions", section: "user_story" },
+      { id: "US-2", text: "upload file attachments", section: "user_story" },
+      { id: "US-3", text: "generate monthly reports", section: "user_story" },
+      { id: "US-4", text: "schedule automated tasks", section: "user_story" },
+      { id: "US-5", text: "configure system settings", section: "user_story" },
+    ];
+    const dsl = makeDsl({
+      endpoints: [{
+        id: "EP-001", method: "GET", path: "/settings",
+        description: "Get system settings and configuration",
+        auth: true, successStatus: 200, successDescription: "ok",
+      }],
+    });
+
+    const result = checkDslCoverage(reqs, dsl);
+    expect(result.coverageRatio).toBeLessThan(0.8);
+    expect(result.uncovered.length).toBeGreaterThan(0);
+  });
+});

package/tests/dsl-feedback.test.ts

@@ -238,6 +238,51 @@ describe("extractStructuralFindings", () => {
       expect(f.description.length).toBeGreaterThan(0);
     }
   });
+
+  it("parses structured JSON block from review text", () => {
+    const pass1 = `## Architecture
+Score: 5/10
+
+## 🔍 结构性发现 JSON
+\`\`\`json
+{
+  "structuralFindings": [
+    { "category": "auth_design", "description": "POST /admin lacks auth" },
+    { "category": "model_design", "description": "User model missing email field" }
+  ]
+}
+\`\`\``;
+    const findings = extractStructuralFindings(`${pass1}\n${SEP}\nimpl`);
+    expect(findings).toHaveLength(2);
+    expect(findings[0].category).toBe("auth_design");
+    expect(findings[1].category).toBe("model_design");
+  });
+
+  it("filters invalid entries from JSON block", () => {
+    const pass1 = `Score: 5/10
+\`\`\`json
+{
+  "structuralFindings": [
+    { "category": "auth_design", "description": "valid" },
+    { "bad": true },
+    "not an object"
+  ]
+}
+\`\`\``;
+    const findings = extractStructuralFindings(pass1);
+    expect(findings).toHaveLength(1);
+    expect(findings[0].description).toBe("valid");
+  });
+
+  it("falls back to regex when JSON is malformed", () => {
+    const pass1 = `Score: 5/10
+\`\`\`json
+{ broken json!!!
+\`\`\`
+Several endpoints have missing auth requirements.`;
+    const findings = extractStructuralFindings(pass1);
+    expect(findings.some((f) => f.category === "auth_design")).toBe(true);
+  });
 });
 
 // ─── Prompt builders (smoke tests) ────────────────────────────────────────────

package/tests/dsl-validator-xref.test.ts

@@ -0,0 +1,99 @@
+import { describe, it, expect } from "vitest";
+import { validateDsl } from "../core/dsl-validator";
+
+/** Minimal valid DSL for testing cross-reference checks. */
+function baseDsl(overrides: Record<string, unknown> = {}) {
+  return {
+    version: "1.0",
+    feature: { id: "f1", title: "Test", description: "test" },
+    models: [
+      { name: "User", fields: [{ name: "id", type: "string", required: true }] },
+      { name: "Post", fields: [{ name: "id", type: "string", required: true }], relations: ["User hasMany Post"] },
+    ],
+    endpoints: [
+      {
+        id: "get-users", method: "GET", path: "/users", description: "List users",
+        auth: false, successStatus: 200, successDescription: "ok",
+      },
+    ],
+    behaviors: [],
+    ...overrides,
+  };
+}
+
+describe("DSL validator cross-reference checks", () => {
+  it("detects duplicate path+method", () => {
+    const dsl = baseDsl({
+      endpoints: [
+        { id: "ep1", method: "GET", path: "/users", description: "a", auth: false, successStatus: 200, successDescription: "ok" },
+        { id: "ep2", method: "GET", path: "/users", description: "b", auth: false, successStatus: 200, successDescription: "ok" },
+      ],
+    });
+    const result = validateDsl(dsl);
+    expect(result.valid).toBe(false);
+    expect(result.errors?.some((e) => e.message.includes("Duplicate route"))).toBe(true);
+  });
+
+  it("allows same path with different methods", () => {
+    const dsl = baseDsl({
+      endpoints: [
+        { id: "ep1", method: "GET", path: "/users", description: "a", auth: false, successStatus: 200, successDescription: "ok" },
+        { id: "ep2", method: "POST", path: "/users", description: "b", auth: false, successStatus: 201, successDescription: "ok" },
+      ],
+    });
+    const result = validateDsl(dsl);
+    expect(result.valid).toBe(true);
+  });
+
+  it("detects relation referencing non-existent model", () => {
+    const dsl = baseDsl({
+      models: [
+        {
+          name: "User",
+          fields: [{ name: "id", type: "string", required: true }],
+          relations: ["User hasMany Comment"],
+        },
+      ],
+    });
+    const result = validateDsl(dsl);
+    expect(result.valid).toBe(false);
+    expect(result.errors?.some((e) => e.message.includes('"Comment"'))).toBe(true);
+  });
+
+  it("passes when relation references existing model", () => {
+    const dsl = baseDsl(); // User hasMany Post — both models exist
+    const result = validateDsl(dsl);
+    expect(result.valid).toBe(true);
+  });
+
+  it("detects component apiCalls referencing non-existent endpoint", () => {
+    const dsl = baseDsl({
+      components: [
+        {
+          id: "c1", name: "UserList", description: "Shows users",
+          props: [{ name: "limit", type: "number", required: false }],
+          events: [{ name: "select" }],
+          apiCalls: ["get-users", "nonexistent-endpoint"],
+        },
+      ],
+    });
+    const result = validateDsl(dsl);
+    expect(result.valid).toBe(false);
+    expect(result.errors?.some((e) => e.message.includes('"nonexistent-endpoint"'))).toBe(true);
+  });
+
+  it("passes when component apiCalls reference existing endpoints", () => {
+    const dsl = baseDsl({
+      components: [
+        {
+          id: "c1", name: "UserList", description: "Shows users",
+          props: [{ name: "limit", type: "number", required: false }],
+          events: [{ name: "select" }],
+          apiCalls: ["get-users"],
+        },
+      ],
+    });
+    const result = validateDsl(dsl);
+    expect(result.valid).toBe(true);
+  });
+});