ai-spec-dev 0.35.0 → 0.37.0

package/dist/cli/index.mjs

@@ -132,14 +132,49 @@ function classifyError(err, label) {
   const e = err;
   const status = e.status ?? e.response?.status;
   if (status === 401 || status === 403)
-    return new ProviderError(`Auth error \u2014 check your API key (${label})`, "auth", err);
+    return new ProviderError(
+      `Auth error (${label}): API key is invalid or expired.
+  \u2192 Check that the correct API key is set in your environment or ~/.ai-spec-keys.json
+  \u2192 Run "ai-spec model" to reconfigure your provider and key`,
+      "auth",
+      err
+    );
   if (status === 429)
-    return new ProviderError(`Rate limit hit (${label}) \u2014 try again later or switch provider`, "rate_limit", err);
+    return new ProviderError(
+      `Rate limit hit (${label}): too many requests.
+  \u2192 Wait a few minutes and retry, or switch to a different provider/model
+  \u2192 Check your provider's billing dashboard for quota status`,
+      "rate_limit",
+      err
+    );
   if (e._timeout || e.message?.toLowerCase().includes("timed out"))
     return new ProviderError(`Request timed out (${label})`, "timeout", err);
   if (e.code === "ECONNRESET" || e.code === "ENOTFOUND" || e.code === "ECONNREFUSED")
-    return new ProviderError(`Network error \u2014 check connection/proxy (${label}): ${e.message}`, "network", err);
-  return new ProviderError(`Provider error (${label}): ${e.message}`, "provider", err);
+    return new ProviderError(
+      `Network error (${label}): ${e.message}
+  \u2192 Check your internet connection and proxy settings (HTTPS_PROXY)
+  \u2192 If behind a firewall, ensure the provider's API endpoint is reachable`,
+      "network",
+      err
+    );
+  const msg = e.message ?? "";
+  if (status === 404 || msg.includes("model") && (msg.includes("not found") || msg.includes("does not exist")))
+    return new ProviderError(
+      `Model not found (${label}): ${msg}
+  \u2192 Run "ai-spec model" to see available models for your provider
+  \u2192 The model name may have changed \u2014 check your provider's documentation`,
+      "provider",
+      err
+    );
+  if (msg.includes("insufficient") || msg.includes("quota") || msg.includes("balance"))
+    return new ProviderError(
+      `Quota/balance error (${label}): ${msg}
+  \u2192 Check your provider's billing dashboard
+  \u2192 Consider switching to a different provider with "ai-spec model"`,
+      "provider",
+      err
+    );
+  return new ProviderError(`Provider error (${label}): ${msg}`, "provider", err);
 }
 function isRetryable(err) {
   const e = err;
@@ -4165,7 +4200,7 @@ ${currentSpec}`,
 
 // core/code-generator.ts
 import chalk8 from "chalk";
-import { execSync } from "child_process";
+import { execSync, spawnSync } from "child_process";
 import * as path9 from "path";
 import * as fs10 from "fs-extra";
 
@@ -4792,6 +4827,21 @@ function validateDsl(raw) {
     for (let i = 0; i < Math.min(eps.length, MAX_ENDPOINTS); i++) {
       validateEndpoint(eps[i], `endpoints[${i}]`, errors);
     }
+    const seenEpIds = /* @__PURE__ */ new Set();
+    for (let i = 0; i < Math.min(eps.length, MAX_ENDPOINTS); i++) {
+      const ep = eps[i];
+      if (ep && typeof ep === "object" && typeof ep["id"] === "string") {
+        const id = ep["id"];
+        if (seenEpIds.has(id)) {
+          errors.push({
+            path: `endpoints[${i}].id`,
+            message: `Duplicate endpoint id "${id}" \u2014 each endpoint must have a unique id`
+          });
+        } else {
+          seenEpIds.add(id);
+        }
+      }
+    }
   }
   if (obj["behaviors"] !== void 0) {
     if (!Array.isArray(obj["behaviors"])) {
@@ -4848,6 +4898,21 @@ function validateModel(raw, path40, errors) {
     for (let j2 = 0; j2 < Math.min(fields.length, MAX_FIELDS_PER_MODEL); j2++) {
       validateModelField(fields[j2], `${path40}.fields[${j2}]`, errors);
     }
+    const seenFieldNames = /* @__PURE__ */ new Set();
+    for (let j2 = 0; j2 < Math.min(fields.length, MAX_FIELDS_PER_MODEL); j2++) {
+      const f = fields[j2];
+      if (f && typeof f === "object" && typeof f["name"] === "string") {
+        const name = f["name"];
+        if (seenFieldNames.has(name)) {
+          errors.push({
+            path: `${path40}.fields[${j2}].name`,
+            message: `Duplicate field name "${name}" \u2014 each field within a model must have a unique name`
+          });
+        } else {
+          seenFieldNames.add(name);
+        }
+      }
+    }
   }
   if (m["relations"] !== void 0) {
     if (!Array.isArray(m["relations"])) {
@@ -5315,7 +5380,10 @@ var DslExtractor = class {
    *   - throws if user chose to abort
    */
   async extract(specContent, opts = {}) {
-    const specForAI = specContent.length > MAX_SPEC_CHARS ? specContent.slice(0, MAX_SPEC_CHARS) + "\n... (truncated for DSL extraction)" : specContent;
+    const specForAI = specContent.length > MAX_SPEC_CHARS ? (() => {
+      console.log(chalk6.yellow(`  \u26A0 Spec is ${specContent.length} chars \u2014 truncating to ${MAX_SPEC_CHARS} for DSL extraction. Details at the end may be lost.`));
+      return specContent.slice(0, MAX_SPEC_CHARS) + "\n... (truncated for DSL extraction)";
+    })() : specContent;
     let lastRawOutput = "";
     let lastErrors = [];
     for (let attempt = 1; attempt <= MAX_RETRIES; attempt++) {
@@ -5339,6 +5407,11 @@ var DslExtractor = class {
         parsed = parseJsonFromOutput(rawOutput);
       } catch (parseErr) {
         console.log(chalk6.red(`  \u2718 Failed to parse JSON from AI output: ${parseErr.message}`));
+        const preview = rawOutput.slice(0, 500).replace(/\n/g, "\\n");
+        console.log(chalk6.gray(`  AI output preview (first 500 chars): ${preview}`));
+        if (rawOutput.length > MAX_SPEC_CHARS) {
+          console.log(chalk6.gray(`  Note: spec was truncated to ${MAX_SPEC_CHARS} chars \u2014 long specs may lose context`));
+        }
         lastErrors = [{ path: "root", message: "Output is not valid JSON \u2014 see raw output above" }];
         if (attempt < MAX_RETRIES) continue;
         return this.handleFailure(opts, "AI produced invalid JSON after retries");
@@ -6447,9 +6520,10 @@ ${tasks.map((t) => `${t.id} [${t.layer}] ${t.title}
       console.log(chalk8.cyan(`  \u{1F916} Auto mode: running claude -p (non-interactive)...`));
       console.log(chalk8.gray(`  Spec: ${specFilePath}`));
       try {
-        execSync(`${claudeCmd} -p "${promptContent.replace(/"/g, '\\"')}"`, {
+        spawnSync(claudeCmd, ["-p", promptContent], {
           cwd: workingDir,
-          stdio: "inherit"
+          stdio: "inherit",
+          shell: false
         });
         console.log(chalk8.green("\n  \u2714 Claude Code completed."));
       } catch {
@@ -6501,9 +6575,10 @@ Full spec is at: ${specFilePath}
 Implement ONLY this task. Do not implement other tasks.`;
       let taskStatus = "done";
       try {
-        execSync(`${claudeCmd} -p "${taskPrompt.replace(/"/g, '\\"').replace(/\n/g, "\\n")}"`, {
+        spawnSync(claudeCmd, ["-p", taskPrompt], {
           cwd: workingDir,
-          stdio: "inherit"
+          stdio: "inherit",
+          shell: false
         });
         completed++;
       } catch {
@@ -9285,7 +9360,7 @@ function assessDslRichness(dsl) {
   const endpointsWithoutErrors = dsl.endpoints.filter(
     (ep) => !ep.errors || ep.errors.length === 0
   );
-  if (endpointsWithoutErrors.length > 0 && dsl.endpoints.length >= 2) {
+  if (endpointsWithoutErrors.length === dsl.endpoints.length && dsl.endpoints.length >= 2) {
     gaps.push({
       code: "missing_errors",
       message: `${endpointsWithoutErrors.length}/${dsl.endpoints.length} endpoints have no error definitions`,
@@ -9871,13 +9946,15 @@ async function readStore() {
     if (await fs19.pathExists(KEY_STORE_FILE)) {
       return await fs19.readJson(KEY_STORE_FILE);
     }
-  } catch {
+  } catch (err) {
+    console.warn(`Warning: Could not read key store at ${KEY_STORE_FILE}: ${err.message}. Using empty store.`);
   }
   return {};
 }
 async function writeStore(store) {
-  await fs19.writeJson(KEY_STORE_FILE, store, { spaces: 2 });
+  await fs19.ensureFile(KEY_STORE_FILE);
   await fs19.chmod(KEY_STORE_FILE, 384);
+  await fs19.writeJson(KEY_STORE_FILE, store, { spaces: 2 });
 }
 async function getSavedKey(provider) {
   const store = await readStore();
@@ -10970,8 +11047,10 @@ function registerCreate(program2) {
         console.log(chalk20.cyan("[8/9] TDD mode \u2014 error feedback loop driving implementation to pass tests..."));
       }
       runLogger.stageStart("error_feedback");
+      const defaultCycles = opts.tdd ? 3 : 2;
+      const maxCycles = config2.maxErrorCycles ?? defaultCycles;
       compilePassed = await runErrorFeedback(codegenProvider, workingDir, extractedDsl, {
-        maxCycles: opts.tdd ? 3 : 2
+        maxCycles
       });
       runLogger.stageEnd("error_feedback");
     }
@@ -11074,6 +11153,18 @@ function registerCreate(program2) {
       logger: runLogger
     });
     printSelfEval(selfEvalResult);
+    const minHarness = config2.minHarnessScore ?? 0;
+    if (minHarness > 0 && selfEvalResult.harnessScore < minHarness && !opts.force) {
+      console.log(chalk20.red(
+        `
+  \u2718 Harness score ${selfEvalResult.harnessScore}/10 is below the minimum threshold ${minHarness}/10.`
+      ));
+      console.log(chalk20.gray(`  Gate threshold set in .ai-spec.json \u2192 "minHarnessScore": ${minHarness}`));
+      console.log(chalk20.gray(`  Use --force to bypass, or improve the spec and re-run.`));
+      runLogger.stageEnd("self_eval", { gateBlocked: true, score: selfEvalResult.harnessScore, threshold: minHarness });
+      runLogger.finish();
+      process.exit(1);
+    }
     if (accumulatePromise) await accumulatePromise;
     if (specVcrRecorder) {
       const vcrPath = await specVcrRecorder.save(currentDir, runId, codegenVcrRecorder ?? void 0);
@@ -11645,7 +11736,7 @@ import * as path26 from "path";
 import * as fs27 from "fs-extra";
 import chalk24 from "chalk";
 function registerConfig(program2) {
-  program2.command("config").description(`Set default configuration for this project (saved to ${CONFIG_FILE})`).option("--provider <name>", "Default AI provider for spec generation").option("--model <name>", "Default model for spec generation").option("--codegen <mode>", "Default code generation mode (claude-code|api|plan)").option("--codegen-provider <name>", "Default provider for code generation").option("--codegen-model <name>", "Default model for code generation").option("--min-spec-score <score>", "Minimum overall spec score (1-10) to pass Approval Gate (0 = disabled)").option("--show", "Print current configuration").option("--reset", "Reset configuration to empty").option("--clear-keys", "Delete all saved API keys from ~/.ai-spec-keys.json").option("--clear-key <provider>", "Delete saved API key for a specific provider").option("--list-keys", "Show which providers have a saved key").action(async (opts) => {
+  program2.command("config").description(`Set default configuration for this project (saved to ${CONFIG_FILE})`).option("--provider <name>", "Default AI provider for spec generation").option("--model <name>", "Default model for spec generation").option("--codegen <mode>", "Default code generation mode (claude-code|api|plan)").option("--codegen-provider <name>", "Default provider for code generation").option("--codegen-model <name>", "Default model for code generation").option("--min-spec-score <score>", "Minimum overall spec score (1-10) to pass Approval Gate (0 = disabled)").option("--min-harness-score <score>", "Minimum harness score (1-10) for pipeline success (0 = disabled)").option("--max-error-cycles <n>", "Maximum error-feedback fix cycles (1-10, default: 2)").option("--show", "Print current configuration").option("--reset", "Reset configuration to empty").option("--clear-keys", "Delete all saved API keys from ~/.ai-spec-keys.json").option("--clear-key <provider>", "Delete saved API key for a specific provider").option("--list-keys", "Show which providers have a saved key").action(async (opts) => {
     const currentDir = process.cwd();
     const configPath = path26.join(currentDir, CONFIG_FILE);
     if (opts.clearKeys) {
@@ -11703,6 +11794,22 @@ File: ${KEY_STORE_FILE}`));
       }
       updated.minSpecScore = score;
     }
+    if (opts.minHarnessScore !== void 0) {
+      const score = parseInt(opts.minHarnessScore, 10);
+      if (isNaN(score) || score < 0 || score > 10) {
+        console.error(chalk24.red("  --min-harness-score must be a number between 0 and 10"));
+        process.exit(1);
+      }
+      updated.minHarnessScore = score;
+    }
+    if (opts.maxErrorCycles !== void 0) {
+      const cycles = parseInt(opts.maxErrorCycles, 10);
+      if (isNaN(cycles) || cycles < 1 || cycles > 10) {
+        console.error(chalk24.red("  --max-error-cycles must be a number between 1 and 10"));
+        process.exit(1);
+      }
+      updated.maxErrorCycles = cycles;
+    }
     await fs27.writeJson(configPath, updated, { spaces: 2 });
     console.log(chalk24.green(`\u2714 Config saved to ${configPath}`));
     console.log(JSON.stringify(updated, null, 2));