ai-spec-dev 0.1.0 → 0.14.1

package/core/error-feedback.ts

@@ -0,0 +1,354 @@
+import chalk from "chalk";
+import { execSync } from "child_process";
+import * as fs from "fs-extra";
+import * as path from "path";
+import { AIProvider } from "./spec-generator";
+import { getCodeGenSystemPrompt } from "../prompts/codegen.prompt";
+import { SpecDSL } from "./dsl-types";
+import { buildDslContextSection } from "./dsl-extractor";
+
+// ─── Types ──────────────────────────────────────────────────────────────────────
+
+interface ErrorEntry {
+  source: "test" | "lint" | "build";
+  message: string;
+  file?: string;
+}
+
+interface FixResult {
+  fixed: boolean;
+  file: string;
+  explanation: string;
+}
+
+// ─── Error Detection ────────────────────────────────────────────────────────────
+
+function runCommand(cmd: string, cwd: string): { success: boolean; output: string } {
+  try {
+    const output = execSync(cmd, { cwd, encoding: "utf-8", timeout: 60_000 });
+    return { success: true, output };
+  } catch (err) {
+    const e = err as { stdout?: string; stderr?: string; message?: string };
+    return { success: false, output: e.stdout || e.stderr || e.message || "" };
+  }
+}
+
+/**
+ * Detect TypeScript type-check command for the given directory.
+ * Returns null for non-TS projects or projects without tsconfig.
+ */
+function detectBuildCommand(workingDir: string): string | null {
+  // Only applies to Node.js / frontend TypeScript projects
+  if (!fs.existsSync(path.join(workingDir, "tsconfig.json"))) return null;
+
+  // vue-tsc for Vue projects (catches template type errors too)
+  const pkgPath = path.join(workingDir, "package.json");
+  try {
+    const pkg = JSON.parse(fs.readFileSync(pkgPath, "utf-8"));
+    const allDeps = { ...pkg.dependencies, ...pkg.devDependencies };
+    if (allDeps["vue-tsc"]) return "npx vue-tsc --noEmit";
+    // If there's a type-check or tsc script, prefer it
+    if (pkg.scripts?.["type-check"]) return "npm run type-check";
+    if (pkg.scripts?.["typecheck"]) return "npm run typecheck";
+  } catch {
+    // ignore
+  }
+
+  return "npx tsc --noEmit";
+}
+
+function detectTestCommand(workingDir: string): string | null {
+  // ── Go ──────────────────────────────────────────────────────────────────────
+  if (fs.existsSync(path.join(workingDir, "go.mod"))) return "go test ./...";
+
+  // ── PHP (Lumen / Laravel) ───────────────────────────────────────────────────
+  if (fs.existsSync(path.join(workingDir, "composer.json"))) {
+    return fs.existsSync(path.join(workingDir, "vendor", "bin", "phpunit"))
+      ? "./vendor/bin/phpunit --colors=never"
+      : "php artisan test --no-ansi";
+  }
+
+  // ── Rust ────────────────────────────────────────────────────────────────────
+  if (fs.existsSync(path.join(workingDir, "Cargo.toml"))) return "cargo test";
+
+  // ── Java (Maven / Gradle) ───────────────────────────────────────────────────
+  if (fs.existsSync(path.join(workingDir, "pom.xml"))) return "mvn test -q";
+  if (
+    fs.existsSync(path.join(workingDir, "build.gradle")) ||
+    fs.existsSync(path.join(workingDir, "build.gradle.kts"))
+  ) {
+    return "./gradlew test";
+  }
+
+  // ── Python ──────────────────────────────────────────────────────────────────
+  if (
+    fs.existsSync(path.join(workingDir, "requirements.txt")) ||
+    fs.existsSync(path.join(workingDir, "pyproject.toml")) ||
+    fs.existsSync(path.join(workingDir, "setup.py"))
+  ) {
+    return "pytest";
+  }
+
+  // ── Node.js ──────────────────────────────────────────────────────────────────
+  const pkgPath = path.join(workingDir, "package.json");
+  try {
+    const pkg = JSON.parse(fs.readFileSync(pkgPath, "utf-8"));
+    if (pkg.scripts?.test) return "npm test";
+    if (pkg.scripts?.vitest) return "npx vitest run";
+  } catch {
+    // no package.json
+  }
+  for (const f of ["vitest.config.ts", "vitest.config.js", "jest.config.ts", "jest.config.js"]) {
+    if (fs.existsSync(path.join(workingDir, f))) {
+      return f.startsWith("vitest") ? "npx vitest run" : "npx jest --forceExit";
+    }
+  }
+  return null;
+}
+
+function detectLintCommand(workingDir: string): string | null {
+  // ── Go ──────────────────────────────────────────────────────────────────────
+  if (fs.existsSync(path.join(workingDir, "go.mod"))) {
+    // golangci-lint is optional; fall back to go vet
+    return "go vet ./...";
+  }
+
+  // ── PHP (Lumen / Laravel) ───────────────────────────────────────────────────
+  if (fs.existsSync(path.join(workingDir, "composer.json"))) {
+    return fs.existsSync(path.join(workingDir, "vendor", "bin", "phpstan"))
+      ? "./vendor/bin/phpstan analyse --no-progress --memory-limit=512M"
+      : null;
+  }
+
+  // ── Rust ────────────────────────────────────────────────────────────────────
+  if (fs.existsSync(path.join(workingDir, "Cargo.toml"))) return "cargo clippy -- -D warnings";
+
+  // ── Java — no universal lint, skip ──────────────────────────────────────────
+  if (
+    fs.existsSync(path.join(workingDir, "pom.xml")) ||
+    fs.existsSync(path.join(workingDir, "build.gradle"))
+  ) {
+    return null;
+  }
+
+  // ── Python ──────────────────────────────────────────────────────────────────
+  if (
+    fs.existsSync(path.join(workingDir, "requirements.txt")) ||
+    fs.existsSync(path.join(workingDir, "pyproject.toml")) ||
+    fs.existsSync(path.join(workingDir, "setup.py"))
+  ) {
+    // Prefer ruff if available, fall back to flake8
+    return "ruff check . || flake8 .";
+  }
+
+  // ── Node.js ──────────────────────────────────────────────────────────────────
+  const pkgPath = path.join(workingDir, "package.json");
+  try {
+    const pkg = JSON.parse(fs.readFileSync(pkgPath, "utf-8"));
+    if (pkg.scripts?.lint) return "npm run lint";
+  } catch {
+    // ignore
+  }
+  if (
+    fs.existsSync(path.join(workingDir, ".eslintrc")) ||
+    fs.existsSync(path.join(workingDir, ".eslintrc.js")) ||
+    fs.existsSync(path.join(workingDir, ".eslintrc.json")) ||
+    fs.existsSync(path.join(workingDir, "eslint.config.js"))
+  ) {
+    return "npx eslint . --max-warnings=0";
+  }
+  return null;
+}
+
+function parseErrors(output: string, source: ErrorEntry["source"]): ErrorEntry[] {
+  const errors: ErrorEntry[] = [];
+  if (!output.trim()) return errors;
+
+  // Take the last 80 lines — most relevant error output
+  const lines = output.split("\n").slice(-80);
+
+  for (const line of lines) {
+    const trimmed = line.trim();
+    if (!trimmed) continue;
+    // Filter noise: skip npm timing, node warnings, stack traces to node_modules
+    if (trimmed.startsWith("npm timing")) continue;
+    if (trimmed.includes("node_modules")) continue;
+    if (trimmed.startsWith("at ")) continue;
+    if (trimmed.startsWith("Node.js ")) continue;
+
+    // Try to extract file path (supports TS/JS, Go, Python, Java, Rust, PHP)
+    const fileMatch = trimmed.match(/^([^:]+\.(?:ts|js|tsx|jsx|go|py|java|rs|php)):\d+/);
+    errors.push({
+      source,
+      message: trimmed.slice(0, 300),
+      file: fileMatch?.[1],
+    });
+  }
+
+  return errors.slice(0, 20); // cap at 20 errors
+}
+
+// ─── Auto-Fix ───────────────────────────────────────────────────────────────────
+
+async function attemptFix(
+  provider: AIProvider,
+  errors: ErrorEntry[],
+  workingDir: string,
+  dsl?: SpecDSL | null
+): Promise<FixResult[]> {
+  const results: FixResult[] = [];
+
+  // Group errors by file (fix one file at a time)
+  const errorsByFile = new Map<string, ErrorEntry[]>();
+  for (const err of errors) {
+    const file = err.file || "(unknown)";
+    if (!errorsByFile.has(file)) errorsByFile.set(file, []);
+    errorsByFile.get(file)!.push(err);
+  }
+
+  for (const [file, fileErrors] of errorsByFile) {
+    const fullPath = path.join(workingDir, file);
+    let existingContent = "";
+    try {
+      existingContent = await fs.readFile(fullPath, "utf-8");
+    } catch {
+      results.push({ fixed: false, file, explanation: "File not found — cannot auto-fix." });
+      continue;
+    }
+
+    const dslSection = dsl ? `\n${buildDslContextSection(dsl)}\n` : "";
+    const errorSummary = fileErrors.map((e) => `[${e.source}] ${e.message}`).join("\n");
+
+    const prompt = `Fix the following errors in the file.
+
+File: ${file}
+${dslSection}
+=== Errors ===
+${errorSummary}
+
+=== Current File Content ===
+${existingContent}
+
+Output ONLY the complete fixed file content. No markdown fences, no explanations.`;
+
+    try {
+      const raw = await provider.generate(prompt, getCodeGenSystemPrompt());
+      const fixed = raw.replace(/^```\w*\n?/gm, "").replace(/\n?```$/gm, "").trim();
+      await fs.writeFile(fullPath, fixed, "utf-8");
+      results.push({ fixed: true, file, explanation: `Fixed ${fileErrors.length} error(s)` });
+      console.log(chalk.green(`  ✔ Auto-fixed: ${file}`));
+    } catch (err) {
+      results.push({ fixed: false, file, explanation: `AI fix failed: ${(err as Error).message}` });
+      console.log(chalk.yellow(`  ⚠ Could not auto-fix: ${file}`));
+    }
+  }
+
+  return results;
+}
+
+// ─── Public API ─────────────────────────────────────────────────────────────────
+
+export interface ErrorFeedbackOptions {
+  /** Max fix-verify cycles (default: 2) */
+  maxCycles?: number;
+  /** Whether to skip test runs (--auto mode may want to skip for speed) */
+  skipTests?: boolean;
+  /** Whether to skip lint runs */
+  skipLint?: boolean;
+  /** Whether to skip TypeScript type-check (tsc --noEmit / vue-tsc --noEmit) */
+  skipBuild?: boolean;
+}
+
+/**
+ * Run error feedback loop: detect errors → auto-fix → re-verify.
+ * Returns true if all checks pass after fixes, false if errors remain.
+ */
+export async function runErrorFeedback(
+  provider: AIProvider,
+  workingDir: string,
+  dsl?: SpecDSL | null,
+  opts: ErrorFeedbackOptions = {}
+): Promise<boolean> {
+  const maxCycles = opts.maxCycles ?? 2;
+
+  console.log(chalk.blue("\n─── Error Feedback ──────────────────────────────"));
+
+  const testCmd  = opts.skipTests ? null : detectTestCommand(workingDir);
+  const lintCmd  = opts.skipLint  ? null : detectLintCommand(workingDir);
+  const buildCmd = opts.skipBuild ? null : detectBuildCommand(workingDir);
+
+  if (!testCmd && !lintCmd && !buildCmd) {
+    console.log(chalk.gray("  No test / lint / type-check commands detected. Skipping error feedback."));
+    return true;
+  }
+
+  if (buildCmd) console.log(chalk.gray(`  Type-check: ${buildCmd}`));
+
+  for (let cycle = 1; cycle <= maxCycles; cycle++) {
+    const allErrors: ErrorEntry[] = [];
+
+    // ── TypeScript type-check (fast, runs before tests) ──────────────────────
+    if (buildCmd) {
+      console.log(chalk.gray(`\n  [cycle ${cycle}/${maxCycles}] Type-check: ${buildCmd}`));
+      const buildResult = runCommand(buildCmd, workingDir);
+      if (!buildResult.success) {
+        // Detect tool crash (ReferenceError / TypeError inside node_modules) —
+        // this means the type-check tool itself is broken (e.g. vue-tsc version
+        // incompatibility), NOT a user code error. Skip silently instead of
+        // feeding garbage into the auto-fix loop.
+        const isToolCrash =
+          /ReferenceError:|TypeError:|SyntaxError:/.test(buildResult.output) &&
+          buildResult.output.includes("node_modules");
+        if (isToolCrash) {
+          console.log(chalk.yellow(`  ⚠ Type-check tool crashed (possible version incompatibility). Skipping.`));
+          console.log(chalk.gray(`    Tip: run \`${buildCmd}\` manually to investigate.`));
+        } else {
+          const buildErrors = parseErrors(buildResult.output, "build");
+          allErrors.push(...buildErrors);
+          console.log(chalk.yellow(`  ✘ Type errors (${buildErrors.length} captured)`));
+        }
+      } else {
+        console.log(chalk.green("  ✔ Type-check passed."));
+      }
+    }
+
+    // Run tests
+    if (testCmd) {
+      console.log(chalk.gray(`\n  [cycle ${cycle}/${maxCycles}] Running tests: ${testCmd}`));
+      const testResult = runCommand(testCmd, workingDir);
+      if (!testResult.success) {
+        const testErrors = parseErrors(testResult.output, "test");
+        allErrors.push(...testErrors);
+        console.log(chalk.yellow(`  ✘ Tests failed (${testErrors.length} error(s) captured)`));
+      } else {
+        console.log(chalk.green("  ✔ Tests passed."));
+      }
+    }
+
+    // Run lint
+    if (lintCmd) {
+      console.log(chalk.gray(`  [cycle ${cycle}/${maxCycles}] Running lint: ${lintCmd}`));
+      const lintResult = runCommand(lintCmd, workingDir);
+      if (!lintResult.success) {
+        const lintErrors = parseErrors(lintResult.output, "lint");
+        allErrors.push(...lintErrors);
+        console.log(chalk.yellow(`  ✘ Lint failed (${lintErrors.length} error(s) captured)`));
+      } else {
+        console.log(chalk.green("  ✔ Lint passed."));
+      }
+    }
+
+    if (allErrors.length === 0) {
+      console.log(chalk.green(`\n  ✔ All checks passed after ${cycle} cycle(s).`));
+      return true;
+    }
+
+    if (cycle < maxCycles) {
+      console.log(chalk.cyan(`\n  Attempting auto-fix (${allErrors.length} error(s))...`));
+      await attemptFix(provider, allErrors, workingDir, dsl);
+    }
+  }
+
+  console.log(chalk.yellow("\n  ⚠ Some errors remain after auto-fix cycles. Manual intervention needed."));
+  return false;
+}