ai-sdlc 0.2.1-alpha.1 → 0.3.0-alpha.10

package/dist/agents/review.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"review.d.ts","sourceRoot":"","sources":["../../src/agents/review.ts"],"names":[],"mappings":"AASA,OAAO,EAAE,KAAK,EAAE,WAAW,EAAE,YAAY,EAAE,WAAW,EAA8E,YAAY,EAAE,MAAM,mBAAmB,CAAC;AAqH5K;;;;;;;;GAQG;AACH,wBAAgB,iBAAiB,CAAC,MAAM,EAAE,YAAY,EAAE,GAAG,MAAM,EAAE,CA0BlE;AAED;;;;;;;;GAQG;AACH,wBAAgB,iBAAiB,CAAC,UAAU,EAAE,MAAM,EAAE,GAAG,WAAW,EAAE,CAOrE;AAiBD;;GAEG;AACH,MAAM,MAAM,4BAA4B,GAAG,CAAC,KAAK,EAAE,OAAO,GAAG,MAAM,EAAE,MAAM,EAAE,UAAU,GAAG,SAAS,GAAG,QAAQ,GAAG,QAAQ,EAAE,OAAO,CAAC,EAAE,MAAM,KAAK,IAAI,CAAC;AAuZrJ;;;;;;;;;;;GAWG;AACH,wBAAgB,wCAAwC,CAAC,MAAM,EAAE,WAAW,EAAE,GAAG;IAC/E,gBAAgB,EAAE,OAAO,CAAC;IAC1B,oBAAoB,EAAE,OAAO,CAAC;IAC9B,cAAc,EAAE,OAAO,CAAC;CACzB,CAsBA;AAsED;;;;;;;;GAQG;AACH,wBAAgB,oBAAoB,CAAC,UAAU,EAAE,MAAM,GAAG,MAAM,EAAE,CA2BjE;AAED;;;;;;;;GAQG;AACH,wBAAgB,YAAY,CAAC,UAAU,EAAE,MAAM,GAAG,OAAO,CA2BxD;AAED;;;;;;;;;;GAUG;AACH,wBAAgB,qBAAqB,CAAC,MAAM,EAAE,WAAW,EAAE,EAAE,aAAa,EAAE,MAAM,GAAG,MAAM,CA+F1F;AAED;;GAEG;AACH,MAAM,WAAW,kBAAkB;IACjC,iDAAiD;IACjD,sBAAsB,CAAC,EAAE,4BAA4B,CAAC;CACvD;AAED;;;;;GAKG;AACH,wBAAsB,cAAc,CAClC,SAAS,EAAE,MAAM,EACjB,QAAQ,EAAE,MAAM,EAChB,OAAO,CAAC,EAAE,kBAAkB,GAC3B,OAAO,CAAC,YAAY,CAAC,CA+YvB;AAED;;;GAGG;AACH,wBAAgB,oBAAoB,CAAC,OAAO,EAAE,MAAM,GAAG,KAAK,CAAC;IAAE,KAAK,EAAE,MAAM,CAAC;IAAC,OAAO,EAAE,MAAM,CAAA;CAAE,CAAC,CAkB/F;AAED;;;;GAIG;AACH,wBAAgB,0BAA0B,CAAC,OAAO,EAAE,MAAM,GAAG,MAAM,CAelE;AAED;;;GAGG;AACH,wBAAgB,eAAe,CAAC,SAAS,EAAE,MAAM,EAAE,MAAM,EAAE,MAAM,EAAE,UAAU,EAAE,MAAM,GAAG,MAAM,CAiB7F;AAED;;;;GAIG;AACH,wBAAgB,mBAAmB,CAAC,KAAK,EAAE,KAAK,EAAE,YAAY,EAAE,MAAM,GAAG,MAAM,CAsC9E;AAED;;;;GAIG;AACH,wBAAgB,cAAc,CAAC,IAAI,EAAE,MAAM,EAAE,SAAS,GAAE,MAAc,GAAG,MAAM,CAqC9E;AAgCD;;GAEG;AACH,MAAM,WAAW,eAAe;IAC9B,+EAA+E;IAC/E,KAAK,CAAC,EAAE,OAAO,CAAC;CACjB;AAED;;GAEG;AACH,wBAAsB,iBAAiB,CACrC,SAAS,EAAE,MAAM,EACjB,QAAQ,EAAE,MAAM,EAChB,OAAO,CAAC,EAAE,eAAe,GACxB,OAAO,CAAC,WAAW,CAAC,CAqKtB"}
+{"version":3,"file":"review.d.ts","sourceRoot":"","sources":["../../src/agents/review.ts"],"names":[],"mappings":"AAUA,OAAO,EAAE,KAAK,EAAE,WAAW,EAAE,YAAY,EAAE,WAAW,EAA8E,YAAY,EAAE,WAAW,EAAE,MAAM,mBAAmB,CAAC;AAsHzL;;;;;;;;GAQG;AACH,wBAAgB,iBAAiB,CAAC,MAAM,EAAE,YAAY,EAAE,GAAG,MAAM,EAAE,CA0BlE;AAED;;;;;;;;GAQG;AACH,wBAAgB,iBAAiB,CAAC,UAAU,EAAE,MAAM,EAAE,GAAG,WAAW,EAAE,CAOrE;AAiBD;;GAEG;AACH,MAAM,MAAM,4BAA4B,GAAG,CAAC,KAAK,EAAE,OAAO,GAAG,MAAM,EAAE,MAAM,EAAE,UAAU,GAAG,SAAS,GAAG,QAAQ,GAAG,QAAQ,EAAE,OAAO,CAAC,EAAE,MAAM,KAAK,IAAI,CAAC;AAyZrJ;;;;;;;;;;;GAWG;AACH,wBAAgB,wCAAwC,CAAC,MAAM,EAAE,WAAW,EAAE,GAAG;IAC/E,gBAAgB,EAAE,OAAO,CAAC;IAC1B,oBAAoB,EAAE,OAAO,CAAC;IAC9B,cAAc,EAAE,OAAO,CAAC;CACzB,CAsBA;AAkGD;;;;;;;;;;;GAWG;AACH,wBAAgB,oBAAoB,CAAC,UAAU,EAAE,MAAM,GAAG,MAAM,EAAE,CA6BjE;AAED;;;;;;;;;;;;;;GAcG;AACH,wBAAgB,uBAAuB,CAAC,UAAU,EAAE,MAAM,GAAG,MAAM,EAAE,CAuDpE;AAED;;;;;;;;;;;;;GAaG;AACH,wBAAgB,uBAAuB,CAAC,UAAU,EAAE,MAAM,GAAG,MAAM,EAAE,CAkCpE;AAED;;;;;;;;;;GAUG;AACH,wBAAgB,6BAA6B,CAAC,KAAK,EAAE,KAAK,GAAG,WAAW,CAavE;AAED;;;;;;;;;;GAUG;AACH,wBAAgB,YAAY,CAAC,UAAU,EAAE,MAAM,GAAG,OAAO,CA6BxD;AAED;;;;;;;;;;GAUG;AACH,wBAAgB,qBAAqB,CAAC,MAAM,EAAE,WAAW,EAAE,EAAE,aAAa,EAAE,MAAM,GAAG,MAAM,CA+F1F;AAED;;GAEG;AACH,MAAM,WAAW,kBAAkB;IACjC,iDAAiD;IACjD,sBAAsB,CAAC,EAAE,4BAA4B,CAAC;CACvD;AAED;;;;;GAKG;AACH,wBAAsB,cAAc,CAClC,SAAS,EAAE,MAAM,EACjB,QAAQ,EAAE,MAAM,EAChB,OAAO,CAAC,EAAE,kBAAkB,GAC3B,OAAO,CAAC,YAAY,CAAC,CA4fvB;AAED;;;GAGG;AACH,wBAAgB,oBAAoB,CAAC,OAAO,EAAE,MAAM,GAAG,KAAK,CAAC;IAAE,KAAK,EAAE,MAAM,CAAC;IAAC,OAAO,EAAE,MAAM,CAAA;CAAE,CAAC,CAkB/F;AAED;;;;GAIG;AACH,wBAAgB,0BAA0B,CAAC,OAAO,EAAE,MAAM,GAAG,MAAM,CAelE;AAED;;;GAGG;AACH,wBAAgB,eAAe,CAAC,SAAS,EAAE,MAAM,EAAE,MAAM,EAAE,MAAM,EAAE,UAAU,EAAE,MAAM,GAAG,MAAM,CAiB7F;AAED;;;;GAIG;AACH,wBAAgB,mBAAmB,CAAC,KAAK,EAAE,KAAK,EAAE,YAAY,EAAE,MAAM,GAAG,MAAM,CAsC9E;AAED;;;;GAIG;AACH,wBAAgB,cAAc,CAAC,IAAI,EAAE,MAAM,EAAE,SAAS,GAAE,MAAc,GAAG,MAAM,CAqC9E;AAgCD;;GAEG;AACH,MAAM,WAAW,eAAe;IAC9B,+EAA+E;IAC/E,KAAK,CAAC,EAAE,OAAO,CAAC;CACjB;AAED;;GAEG;AACH,wBAAsB,iBAAiB,CACrC,SAAS,EAAE,MAAM,EACjB,QAAQ,EAAE,MAAM,EAChB,OAAO,CAAC,EAAE,eAAe,GACxB,OAAO,CAAC,WAAW,CAAC,CAqKtB"}

package/dist/agents/review.js

@@ -2,6 +2,7 @@ import { execSync, spawn, spawnSync } from 'child_process';
 import path from 'path';
 import fs from 'fs';
 import { z } from 'zod';
+import { ProcessManager } from '../core/process-manager.js';
 import { parseStory, updateStoryStatus, appendToSection, updateStoryField, isAtMaxRetries, appendReviewHistory, snapshotMaxRetries, getEffectiveMaxRetries, getEffectiveMaxImplementationRetries } from '../core/story.js';
 import { runAgentQuery } from '../core/client.js';
 import { getLogger } from '../core/logger.js';
@@ -10,6 +11,7 @@ import { extractStructuredResponseSync } from '../core/llm-utils.js';
 import { ReviewDecision, ReviewSeverity } from '../types/index.js';
 import { sanitizeInput, truncateText } from '../cli/formatting.js';
 import { detectTestDuplicationPatterns } from './test-pattern-detector.js';
+import { getBaseBranch, getMergeBase } from '../core/git-utils.js';
 /**
  * Security: Validate Git branch name to prevent command injection
  * Only allows alphanumeric characters, hyphens, underscores, and forward slashes
@@ -173,6 +175,7 @@ async function runCommandAsync(command, workingDir, timeout, onProgress) {
             cwd: workingDir,
             stdio: ['pipe', 'pipe', 'pipe'],
         });
+        ProcessManager.getInstance().registerChild(child);
         const timeoutId = setTimeout(() => {
             killed = true;
             child.kill('SIGTERM');
@@ -589,9 +592,38 @@ function formatIssuesForDisplay(issues) {
     }
     return output;
 }
+/**
+ * Get the base commit reference for git diff comparisons
+ *
+ * Attempts to find the merge-base between the current branch and the base branch (main/master).
+ * Falls back to HEAD~1 if merge-base cannot be determined.
+ *
+ * This allows detecting source code changes across the entire feature branch,
+ * not just from the most recent commit.
+ *
+ * @param workingDir - Working directory to run git commands in
+ * @returns Commit reference to use for git diff comparison
+ */
+function getBaseCommitForDiff(workingDir) {
+    try {
+        const baseBranch = getBaseBranch(workingDir);
+        const mergeBase = getMergeBase(workingDir, baseBranch);
+        if (mergeBase) {
+            return mergeBase;
+        }
+    }
+    catch {
+        // If we can't determine base branch or merge-base, fall back to HEAD~1
+    }
+    // Fallback to HEAD~1 (original behavior)
+    return 'HEAD~1';
+}
 /**
  * Get source code changes from git diff
  *
+ * Compares current branch HEAD against the base branch (main/master) merge-base
+ * to detect all source code changes in the feature branch, not just the most recent commit.
+ *
  * Returns list of source files that have been modified (excludes tests and story files).
  * Uses spawnSync for security (prevents command injection).
  *
@@ -600,8 +632,9 @@ function formatIssuesForDisplay(issues) {
  */
 export function getSourceCodeChanges(workingDir) {
     try {
+        const baseCommit = getBaseCommitForDiff(workingDir);
         // Security: Use spawnSync with explicit args (not shell) to prevent injection
-        const result = spawnSync('git', ['diff', '--name-only', 'HEAD~1'], {
+        const result = spawnSync('git', ['diff', '--name-only', baseCommit], {
             cwd: workingDir,
             encoding: 'utf-8',
             stdio: ['ignore', 'pipe', 'pipe'],
@@ -624,9 +657,148 @@ export function getSourceCodeChanges(workingDir) {
         return ['unknown'];
     }
 }
+/**
+ * Get configuration file changes from git diff
+ *
+ * Compares current branch HEAD against the base branch merge-base.
+ *
+ * Detects changes to configuration files including:
+ * - .claude/ directory (Agent SDK skills, CLAUDE.md)
+ * - .github/ directory (workflows, actions, issue templates)
+ * - Root config files (tsconfig.json, package.json, .gitignore, vitest.config.ts, etc.)
+ *
+ * Uses spawnSync for security (prevents command injection).
+ *
+ * @param workingDir - Working directory to run git diff in
+ * @returns Array of configuration file paths that have changed, or ['unknown'] if git fails
+ */
+export function getConfigurationChanges(workingDir) {
+    try {
+        const baseCommit = getBaseCommitForDiff(workingDir);
+        // Security: Use spawnSync with explicit args (not shell) to prevent injection
+        const result = spawnSync('git', ['diff', '--name-only', baseCommit], {
+            cwd: workingDir,
+            encoding: 'utf-8',
+            stdio: ['ignore', 'pipe', 'pipe'],
+        });
+        if (result.status !== 0) {
+            // Git command failed - fail open (assume changes exist)
+            return ['unknown'];
+        }
+        const output = result.stdout.toString();
+        return output
+            .split('\n')
+            .filter(f => f.trim())
+            .filter(f => {
+            // Configuration directories
+            if (f.startsWith('.claude/'))
+                return true;
+            if (f.startsWith('.github/'))
+                return true;
+            // Root configuration files (common patterns)
+            const rootConfigs = [
+                'tsconfig.json',
+                'package.json',
+                'package-lock.json',
+                '.gitignore',
+                '.gitattributes',
+                'vitest.config.ts',
+                'vitest.config.js',
+                'jest.config.js',
+                'jest.config.ts',
+                '.eslintrc',
+                '.eslintrc.js',
+                '.eslintrc.json',
+                '.prettierrc',
+                '.prettierrc.js',
+                '.prettierrc.json',
+                'Makefile',
+                'Dockerfile',
+                'docker-compose.yml',
+                '.env.example',
+            ];
+            return rootConfigs.includes(f);
+        });
+    }
+    catch {
+        // If git diff fails, assume there are changes (fail open, not closed)
+        return ['unknown'];
+    }
+}
+/**
+ * Get documentation file changes from git diff
+ *
+ * Compares current branch HEAD against the base branch merge-base.
+ *
+ * Detects changes to documentation files including:
+ * - Markdown files (.md) anywhere in the project (excluding story files)
+ * - docs/ directory (any file type)
+ *
+ * Uses spawnSync for security (prevents command injection).
+ *
+ * @param workingDir - Working directory to run git diff in
+ * @returns Array of documentation file paths that have changed, or ['unknown'] if git fails
+ */
+export function getDocumentationChanges(workingDir) {
+    try {
+        const baseCommit = getBaseCommitForDiff(workingDir);
+        // Security: Use spawnSync with explicit args (not shell) to prevent injection
+        const result = spawnSync('git', ['diff', '--name-only', baseCommit], {
+            cwd: workingDir,
+            encoding: 'utf-8',
+            stdio: ['ignore', 'pipe', 'pipe'],
+        });
+        if (result.status !== 0) {
+            // Git command failed - fail open (assume changes exist)
+            return ['unknown'];
+        }
+        const output = result.stdout.toString();
+        return output
+            .split('\n')
+            .filter(f => f.trim())
+            .filter(f => {
+            // Markdown files (excluding story files in .ai-sdlc/stories/)
+            if (f.endsWith('.md') && !f.startsWith('.ai-sdlc/stories/'))
+                return true;
+            // Files in docs/ directory (any file type - images, diagrams, etc.)
+            if (f.startsWith('docs/'))
+                return true;
+            return false;
+        });
+    }
+    catch {
+        // If git diff fails, assume there are changes (fail open, not closed)
+        return ['unknown'];
+    }
+}
+/**
+ * Determine the effective content type for validation
+ *
+ * Resolves the final content type based on story frontmatter fields:
+ * 1. If requires_source_changes === false, treat as 'configuration'
+ * 2. If requires_source_changes === true, treat as 'code'
+ * 3. Otherwise, use content_type field (default: 'code' for backward compatibility)
+ *
+ * @param story - Story with frontmatter to analyze
+ * @returns The effective content type to use for validation
+ */
+export function determineEffectiveContentType(story) {
+    const frontmatter = story.frontmatter;
+    // Manual override takes precedence
+    if (frontmatter.requires_source_changes === false) {
+        return 'configuration';
+    }
+    if (frontmatter.requires_source_changes === true) {
+        return 'code';
+    }
+    // Use explicit content_type or default to 'code'
+    return frontmatter.content_type || 'code';
+}
 /**
  * Check if test files exist in git diff
  *
+ * Compares current branch HEAD against the base branch merge-base.
+ *
  * Returns true if any test files have been modified/added, false otherwise.
  * Uses spawnSync for security (prevents command injection).
  *
@@ -635,8 +807,9 @@ export function getSourceCodeChanges(workingDir) {
  */
 export function hasTestFiles(workingDir) {
     try {
+        const baseCommit = getBaseCommitForDiff(workingDir);
         // Security: Use spawnSync with explicit args (not shell) to prevent injection
-        const result = spawnSync('git', ['diff', '--name-only', 'HEAD~1'], {
+        const result = spawnSync('git', ['diff', '--name-only', baseCommit], {
             cwd: workingDir,
             encoding: 'utf-8',
             stdio: ['ignore', 'pipe', 'pipe'],
@@ -813,94 +986,193 @@ export async function runReviewAgent(storyPath, sdlcRoot, options) {
                 feedback: errorMsg,
             };
         }
-        // PRE-CHECK GATE: Detect documentation-only implementations before running expensive LLM reviews
-        const sourceChanges = getSourceCodeChanges(workingDir);
-        if (sourceChanges.length === 0) {
-            // No source code changes detected - check if we can recover
+        // PRE-CHECK GATE: Content type-aware validation before running expensive LLM reviews
+        const contentType = determineEffectiveContentType(story);
+        logger.info('review', 'Running content-type-specific validation', {
+            storyId: story.frontmatter.id,
+            contentType,
+            explicitContentType: story.frontmatter.content_type,
+            requiresSourceChanges: story.frontmatter.requires_source_changes,
+        });
+        // Validation flags
+        let validationFailed = false;
+        let validationReason = '';
+        let validationCategory = 'implementation';
+        // Check source code changes for 'code' and 'mixed' types
+        if (contentType === 'code' || contentType === 'mixed') {
+            const sourceChanges = getSourceCodeChanges(workingDir);
+            if (sourceChanges.length === 0) {
+                validationFailed = true;
+                validationReason = contentType === 'mixed'
+                    ? 'Mixed story requires both source AND configuration changes - no source code was modified.'
+                    : 'Implementation wrote documentation/planning only - no source code was modified.';
+                logger.warn('review', 'Source code validation failed', {
+                    storyId: story.frontmatter.id,
+                    contentType,
+                    sourceChangesFound: sourceChanges.length,
+                });
+            }
+            else {
+                logger.info('review', 'Source code changes detected', {
+                    storyId: story.frontmatter.id,
+                    fileCount: sourceChanges.length,
+                });
+            }
+        }
+        // Check configuration changes for 'configuration' and 'mixed' types
+        if (!validationFailed && (contentType === 'configuration' || contentType === 'mixed')) {
+            const configChanges = getConfigurationChanges(workingDir);
+            if (configChanges.length === 0) {
+                validationFailed = true;
+                validationReason = contentType === 'mixed'
+                    ? 'Mixed story requires both source AND configuration changes. No configuration file changes detected.'
+                    : 'Configuration story requires changes to config files (.claude/, .github/, or root config files). No configuration changes detected.';
+                logger.warn('review', 'Configuration validation failed', {
+                    storyId: story.frontmatter.id,
+                    contentType,
+                    configChangesFound: configChanges.length,
+                });
+            }
+            else {
+                logger.info('review', 'Configuration changes detected', {
+                    storyId: story.frontmatter.id,
+                    fileCount: configChanges.length,
+                });
+            }
+        }
+        // Check documentation changes for 'documentation' type
+        if (!validationFailed && contentType === 'documentation') {
+            const docChanges = getDocumentationChanges(workingDir);
+            if (docChanges.length === 0) {
+                validationFailed = true;
+                validationReason = 'Documentation story requires changes to markdown files (.md) or docs/ directory. No documentation changes detected.';
+                logger.warn('review', 'Documentation validation failed', {
+                    storyId: story.frontmatter.id,
+                    contentType,
+                    docChangesFound: docChanges.length,
+                });
+            }
+            else {
+                logger.info('review', 'Documentation changes detected', {
+                    storyId: story.frontmatter.id,
+                    fileCount: docChanges.length,
+                });
+            }
+        }
+        // Handle validation failure (if any)
+        if (validationFailed) {
             const retryCount = story.frontmatter.implementation_retry_count || 0;
             const maxRetries = getEffectiveMaxImplementationRetries(story, config);
             if (retryCount < maxRetries) {
                 // RECOVERABLE: Trigger implementation recovery
-                logger.warn('review', 'No source code changes detected - triggering implementation recovery', {
+                logger.warn('review', 'Validation failed - triggering implementation recovery', {
                     storyId: story.frontmatter.id,
                     retryCount,
                     maxRetries,
+                    contentType,
                 });
                 await updateStoryField(story, 'implementation_complete', false);
-                await updateStoryField(story, 'last_restart_reason', 'No source code changes detected. Implementation wrote documentation only.');
+                // Set restart reason based on content type
+                const restartReason = contentType === 'configuration'
+                    ? 'Configuration story requires changes to config files (.claude/, .github/, or root config files). No configuration changes detected.'
+                    : contentType === 'mixed'
+                        ? 'Mixed story requires both source AND configuration changes - no source code was modified.'
+                        : contentType === 'documentation'
+                            ? 'Documentation story requires changes to markdown files (.md) or docs/ directory. No documentation changes detected.'
+                            : 'No source code changes detected. Implementation wrote documentation only.';
+                await updateStoryField(story, 'last_restart_reason', restartReason);
+                // Create user-friendly recovery description
+                const recoveryDescription = contentType === 'configuration'
+                    ? 'No configuration file modifications detected. Re-running implementation phase.'
+                    : contentType === 'mixed'
+                        ? 'No source code modifications detected. Re-running implementation phase.'
+                        : contentType === 'documentation'
+                            ? 'No documentation file modifications detected. Re-running implementation phase.'
+                            : 'No source code modifications detected. Re-running implementation phase.';
                 return {
                     success: true,
                     story: parseStory(storyPath),
-                    changesMade: ['Detected documentation-only implementation', 'Triggered implementation recovery'],
+                    changesMade: ['Detected incomplete implementation', 'Triggered implementation recovery'],
                     passed: false,
                     decision: ReviewDecision.RECOVERY,
                     reviewType: 'pre-check',
                     issues: [{
                             severity: 'critical',
-                            category: 'implementation',
-                            description: 'No source code modifications detected. Re-running implementation phase.',
+                            category: validationCategory,
+                            description: recoveryDescription,
                         }],
-                    feedback: 'Implementation recovery triggered - no source changes found.',
+                    feedback: `Implementation recovery triggered - ${validationReason}`,
                 };
             }
             else {
                 // NON-RECOVERABLE: Max retries reached
                 const maxRetriesDisplay = Number.isFinite(maxRetries) ? maxRetries : '∞';
-                logger.error('review', 'No source code changes detected and max implementation retries reached', {
+                logger.error('review', 'Validation failed and max implementation retries reached', {
                     storyId: story.frontmatter.id,
                     retryCount,
                     maxRetries,
+                    contentType,
                 });
                 return {
                     success: true,
                     story: parseStory(storyPath),
-                    changesMade: ['Detected documentation-only implementation', 'Max retries reached'],
+                    changesMade: ['Detected incomplete implementation', 'Max retries reached'],
                     passed: false,
                     decision: ReviewDecision.FAILED,
                     severity: ReviewSeverity.CRITICAL,
                     reviewType: 'pre-check',
                     issues: [{
                             severity: 'blocker',
-                            category: 'implementation',
-                            description: `Implementation phase wrote documentation/planning only - no source code was modified. This has occurred ${retryCount} time(s) (max: ${maxRetriesDisplay}). Manual intervention required.`,
-                            suggestedFix: 'Review the story requirements and implementation plan. The agent may be confused about what needs to be built. Consider simplifying the story or providing more explicit guidance.',
+                            category: validationCategory,
+                            description: `${validationReason} This has occurred ${retryCount} time(s) (max: ${maxRetriesDisplay}). Manual intervention required.`,
+                            suggestedFix: 'Review the story requirements and implementation plan. Verify the content_type field matches the expected implementation. Consider simplifying the story or providing more explicit guidance.',
                         }],
-                    feedback: 'Implementation failed to produce code changes after multiple attempts.',
+                    feedback: 'Implementation failed validation after multiple attempts.',
                 };
             }
         }
-        // Source changes exist - proceed with normal review flow
-        logger.info('review', 'Source code changes detected - proceeding with verification', {
+        // Validation passed - proceed with normal review flow
+        logger.info('review', 'Content validation passed - proceeding with verification', {
             storyId: story.frontmatter.id,
-            fileCount: sourceChanges.length,
+            contentType,
         });
-        // PRE-CHECK GATE: Check if test files exist
-        const testsExist = hasTestFiles(workingDir);
-        if (!testsExist) {
-            logger.warn('review', 'No test files detected in implementation changes', {
+        // PRE-CHECK GATE: Check if test files exist (only for code/mixed types)
+        // Documentation and configuration stories don't require test files
+        const requiresTests = contentType === 'code' || contentType === 'mixed';
+        if (requiresTests) {
+            const testsExist = hasTestFiles(workingDir);
+            if (!testsExist) {
+                logger.warn('review', 'No test files detected in implementation changes', {
+                    storyId: story.frontmatter.id,
+                });
+                return {
+                    success: true,
+                    story: parseStory(storyPath),
+                    changesMade: ['No test files found for implementation'],
+                    passed: false,
+                    decision: ReviewDecision.REJECTED,
+                    severity: ReviewSeverity.CRITICAL,
+                    reviewType: 'pre-check',
+                    issues: [{
+                            severity: 'blocker',
+                            category: 'testing',
+                            description: 'No tests found for this implementation. All implementations must include tests.',
+                            suggestedFix: 'Add test files (*.test.ts, *.spec.ts, or files in __tests__/ directory) that verify the implementation.',
+                        }],
+                    feedback: formatIssuesForDisplay([{
+                            severity: 'blocker',
+                            category: 'testing',
+                            description: 'No tests found for this implementation. All implementations must include tests.',
+                            suggestedFix: 'Add test files (*.test.ts, *.spec.ts, or files in __tests__/ directory) that verify the implementation.',
+                        }]),
+                };
+            }
+        }
+        else {
+            logger.info('review', 'Test file check skipped for non-code content type', {
                 storyId: story.frontmatter.id,
+                contentType,
             });
-            return {
-                success: true,
-                story: parseStory(storyPath),
-                changesMade: ['No test files found for implementation'],
-                passed: false,
-                decision: ReviewDecision.REJECTED,
-                severity: ReviewSeverity.CRITICAL,
-                reviewType: 'pre-check',
-                issues: [{
-                        severity: 'blocker',
-                        category: 'testing',
-                        description: 'No tests found for this implementation. All implementations must include tests.',
-                        suggestedFix: 'Add test files (*.test.ts, *.spec.ts, or files in __tests__/ directory) that verify the implementation.',
-                    }],
-                feedback: formatIssuesForDisplay([{
-                        severity: 'blocker',
-                        category: 'testing',
-                        description: 'No tests found for this implementation. All implementations must include tests.',
-                        suggestedFix: 'Add test files (*.test.ts, *.spec.ts, or files in __tests__/ directory) that verify the implementation.',
-                    }]),
-            };
         }
         // Run build and tests BEFORE reviews (async with progress)
         changesMade.push('Running build and test verification...');