ai-sdlc 0.2.0-alpha.42 → 0.2.0-alpha.44

package/dist/agents/orchestrator.js

@@ -0,0 +1,443 @@
+/**
+ * Sequential Task Orchestrator
+ *
+ * Orchestrates implementation by running each task as an isolated agent,
+ * preventing context window exhaustion and enabling intelligent retry/recovery.
+ */
+import { spawnSync } from 'child_process';
+import fs from 'fs';
+import path from 'path';
+import { parseImplementationTasks } from '../core/task-parser.js';
+import { getTaskProgress, updateTaskProgress, initializeTaskProgress, readStoryFile, } from '../core/task-progress.js';
+import { runSingleTaskAgent } from './single-task.js';
+import { getLogger } from '../core/logger.js';
+const logger = getLogger();
+/**
+ * Default orchestrator options
+ */
+const DEFAULT_OPTIONS = {
+    maxRetriesPerTask: 2,
+    commitAfterEachTask: true,
+    stopOnFirstFailure: true,
+    dryRun: false,
+};
+/**
+ * Build minimal context for a single task
+ *
+ * Extracts relevant acceptance criteria, existing file contents, and project conventions.
+ * Truncates if context exceeds reasonable size (~2000 chars for projectPatterns).
+ *
+ * @param task - Task to build context for
+ * @param storyContent - Full story content
+ * @param workingDirectory - Working directory for task execution
+ * @returns Minimal task context
+ */
+export function buildTaskContext(task, storyContent, workingDirectory) {
+    // Extract acceptance criteria section
+    const acceptanceCriteria = [];
+    const acMatch = storyContent.match(/##\s+Acceptance\s+Criteria\s*\n([\s\S]*?)(?=\n##|$)/i);
+    if (acMatch) {
+        const acSection = acMatch[1];
+        const lines = acSection.split('\n');
+        for (const line of lines) {
+            const trimmed = line.trim();
+            if (trimmed.startsWith('-') || trimmed.startsWith('*')) {
+                // Remove checkbox and bullet
+                const criterion = trimmed.replace(/^[-*]\s+\[[ x]\]\s*/, '').replace(/^[-*]\s+/, '');
+                if (criterion) {
+                    acceptanceCriteria.push(criterion);
+                }
+            }
+        }
+    }
+    // Filter acceptance criteria to only those relevant to task files
+    const taskFiles = task.files || [];
+    const relevantCriteria = acceptanceCriteria.filter((criterion) => {
+        // Include if criterion mentions any task file
+        return taskFiles.some((file) => {
+            const fileName = path.basename(file);
+            const fileBaseName = fileName.replace(/\.(ts|tsx|js|jsx)$/, '');
+            return (criterion.includes(file) ||
+                criterion.includes(fileName) ||
+                criterion.includes(fileBaseName));
+        });
+    });
+    // If no specific matches, include first 3 criteria as general context
+    const finalCriteria = relevantCriteria.length > 0 ? relevantCriteria : acceptanceCriteria.slice(0, 3);
+    // Read existing files
+    const existingFiles = [];
+    for (const file of taskFiles) {
+        const filePath = path.join(workingDirectory, file);
+        if (fs.existsSync(filePath)) {
+            try {
+                const content = fs.readFileSync(filePath, 'utf-8');
+                existingFiles.push({ path: file, content });
+            }
+            catch (error) {
+                logger.warn('orchestrator', `Failed to read file ${file}: ${error.message}`);
+            }
+        }
+    }
+    // Extract project conventions (brief summary)
+    let projectPatterns = '';
+    const conventionsMatch = storyContent.match(/##\s+(Technical\s+Specification|Project\s+Conventions)\s*\n([\s\S]*?)(?=\n##|$)/i);
+    if (conventionsMatch) {
+        projectPatterns = conventionsMatch[2].trim();
+    }
+    // Truncate if too long
+    const MAX_PATTERN_LENGTH = 2000;
+    if (projectPatterns.length > MAX_PATTERN_LENGTH) {
+        projectPatterns =
+            projectPatterns.substring(0, MAX_PATTERN_LENGTH) + '\n\n[... truncated for length]';
+    }
+    return {
+        task,
+        acceptanceCriteria: finalCriteria,
+        existingFiles,
+        projectPatterns,
+        workingDirectory,
+    };
+}
+/**
+ * Evaluate task result and categorize failure type
+ *
+ * Returns:
+ * - 'success': Task completed successfully
+ * - 'recoverable': Failure that can be retried (timeout, transient error, verification failed)
+ * - 'unrecoverable': Failure that should stop orchestration (deps not met, impossible task, max retries)
+ *
+ * @param result - Result from single-task agent execution
+ * @param attemptCount - Number of attempts made so far (including this one)
+ * @param maxRetries - Maximum retry attempts allowed
+ * @returns Failure category
+ */
+export function evaluateTaskResult(result, attemptCount, maxRetries) {
+    if (result.success) {
+        return 'success';
+    }
+    const error = result.error || '';
+    const lowerError = error.toLowerCase();
+    // Check if max retries exceeded (becomes unrecoverable)
+    if (attemptCount > maxRetries) {
+        logger.warn('orchestrator', `Task ${result.task.id} exceeded max retries (${maxRetries})`);
+        return 'unrecoverable';
+    }
+    // Unrecoverable: Dependencies not met
+    if (lowerError.includes('dependency') ||
+        lowerError.includes('depends on') ||
+        lowerError.includes('prerequisite')) {
+        return 'unrecoverable';
+    }
+    // Unrecoverable: Impossible task or design flaw
+    if (lowerError.includes('impossible') ||
+        lowerError.includes('cannot be done') ||
+        lowerError.includes('design flaw')) {
+        return 'unrecoverable';
+    }
+    // Unrecoverable: Files outside scope modified
+    if (result.scopeViolation && result.scopeViolation.length > 0) {
+        logger.warn('orchestrator', `Task ${result.task.id} modified files outside scope: ${result.scopeViolation.join(', ')}`);
+        return 'unrecoverable';
+    }
+    // Recoverable: Timeout
+    if (lowerError.includes('timeout') || lowerError.includes('timed out')) {
+        return 'recoverable';
+    }
+    // Recoverable: Transient API error
+    if (lowerError.includes('rate limit') ||
+        lowerError.includes('network') ||
+        lowerError.includes('connection') ||
+        lowerError.includes('api error')) {
+        return 'recoverable';
+    }
+    // Recoverable: Verification failed (tests/lint/build)
+    if (!result.verificationPassed ||
+        lowerError.includes('test') ||
+        lowerError.includes('lint') ||
+        lowerError.includes('build')) {
+        return 'recoverable';
+    }
+    // Recoverable: Unclear requirements (agent needs clarification)
+    if (lowerError.includes('unclear') ||
+        lowerError.includes('need') ||
+        lowerError.includes('missing file') ||
+        result.missingDependencies) {
+        return 'recoverable';
+    }
+    // Default to recoverable for unknown errors (give it a chance to retry)
+    return 'recoverable';
+}
+/**
+ * Get next task to execute based on dependencies and progress
+ *
+ * Returns task with status 'pending' or 'in_progress' whose dependencies are all completed.
+ * Detects circular dependencies and throws error.
+ *
+ * @param tasks - All tasks from implementation plan
+ * @param progress - Current task progress
+ * @returns Next eligible task or null if none available
+ * @throws Error if circular dependency detected
+ */
+export function getNextTask(tasks, progress) {
+    // Build progress map for quick lookup
+    const progressMap = new Map();
+    for (const p of progress) {
+        progressMap.set(p.taskId, p.status);
+    }
+    // Find tasks eligible for execution
+    const eligibleTasks = tasks.filter((task) => {
+        const status = progressMap.get(task.id);
+        // Only consider pending or in_progress tasks
+        if (status !== 'pending' && status !== 'in_progress') {
+            return false;
+        }
+        // Check if all dependencies are completed
+        const deps = task.dependencies || [];
+        const allDepsCompleted = deps.every((depId) => progressMap.get(depId) === 'completed');
+        return allDepsCompleted;
+    });
+    // Prioritize in_progress tasks (resume interrupted work)
+    const inProgressTask = eligibleTasks.find((task) => progressMap.get(task.id) === 'in_progress');
+    if (inProgressTask) {
+        return inProgressTask;
+    }
+    // Return first pending task
+    const pendingTask = eligibleTasks.find((task) => progressMap.get(task.id) === 'pending');
+    if (pendingTask) {
+        return pendingTask;
+    }
+    // No eligible tasks - check for circular dependencies
+    const incompleteTasks = tasks.filter((task) => {
+        const status = progressMap.get(task.id);
+        return status !== 'completed' && status !== 'failed';
+    });
+    if (incompleteTasks.length > 0) {
+        // We have incomplete tasks but none are eligible - likely circular dependency
+        const taskIds = incompleteTasks.map((t) => t.id).join(', ');
+        throw new Error(`Circular dependency detected: tasks [${taskIds}] cannot be executed due to unmet dependencies`);
+    }
+    return null;
+}
+/**
+ * Commit task completion to git
+ *
+ * Stages modified files, creates commit with standard message format.
+ * Verifies no files outside task scope were modified.
+ *
+ * @param task - Task that was completed
+ * @param filesChanged - Files modified by task
+ * @param storyId - Story ID for commit message
+ * @param workingDir - Working directory
+ * @throws Error if git operations fail
+ */
+async function commitTaskCompletion(task, filesChanged, storyId, workingDir) {
+    if (filesChanged.length === 0) {
+        logger.warn('orchestrator', `Task ${task.id} completed but no files changed, skipping commit`);
+        return;
+    }
+    // Validate file paths
+    const declaredFiles = task.files || [];
+    const violations = filesChanged.filter((f) => !declaredFiles.includes(f));
+    if (violations.length > 0) {
+        throw new Error(`Task ${task.id} modified files outside declared scope: ${violations.join(', ')}`);
+    }
+    // Stage files using safe git invocation
+    const addResult = spawnSync('git', ['add', ...filesChanged], {
+        cwd: workingDir,
+        encoding: 'utf8',
+    });
+    if (addResult.error) {
+        throw new Error(`Failed to stage files: ${addResult.error.message}`);
+    }
+    if (addResult.status !== 0) {
+        const stderr = addResult.stderr || addResult.stdout || '';
+        throw new Error(`Failed to stage files: ${stderr}`);
+    }
+    // Create commit
+    const commitMessage = `feat(${storyId}): Complete task ${task.id} - ${task.description}`;
+    const commitResult = spawnSync('git', ['commit', '-m', commitMessage], {
+        cwd: workingDir,
+        encoding: 'utf8',
+    });
+    if (commitResult.error) {
+        throw new Error(`Failed to commit: ${commitResult.error.message}`);
+    }
+    if (commitResult.status !== 0) {
+        const stderr = commitResult.stderr || commitResult.stdout || '';
+        throw new Error(`Failed to commit: ${stderr}`);
+    }
+    logger.info('orchestrator', `Committed task ${task.id}: ${commitMessage}`);
+}
+/**
+ * Run implementation orchestrator
+ *
+ * Main orchestration loop:
+ * 1. Parse tasks from plan
+ * 2. Load/initialize progress
+ * 3. Loop: get next task → run agent → evaluate → commit → repeat
+ * 4. Return summary result
+ *
+ * @param storyPath - Absolute path to story.md file
+ * @param sdlcRoot - SDLC root directory
+ * @param options - Orchestrator options
+ * @returns Orchestration result summary
+ */
+export async function runImplementationOrchestrator(storyPath, sdlcRoot, options) {
+    const opts = { ...DEFAULT_OPTIONS, ...options };
+    const workingDir = path.dirname(storyPath);
+    logger.info('orchestrator', 'Starting implementation orchestration', {
+        storyPath,
+        options: opts,
+    });
+    // Parse tasks from plan
+    const storyContent = await readStoryFile(storyPath);
+    const tasks = parseImplementationTasks(storyContent);
+    if (tasks.length === 0) {
+        logger.warn('orchestrator', 'No tasks found in implementation plan');
+        return {
+            success: true,
+            tasksCompleted: 0,
+            tasksFailed: 0,
+            tasksRemaining: 0,
+            failedTasks: [],
+            totalAgentInvocations: 0,
+        };
+    }
+    logger.info('orchestrator', `Found ${tasks.length} tasks in plan`);
+    // Load or initialize progress
+    let progress = await getTaskProgress(storyPath);
+    if (progress.length === 0) {
+        logger.info('orchestrator', 'Initializing task progress tracking');
+        await initializeTaskProgress(storyPath, tasks.map((t) => t.id));
+        progress = await getTaskProgress(storyPath);
+    }
+    // Extract story ID from path
+    const storyId = path.basename(path.dirname(storyPath));
+    // Track statistics
+    // Count already-completed tasks from previous runs
+    const alreadyCompleted = progress.filter((p) => p.status === 'completed').length;
+    const alreadyFailed = progress.filter((p) => p.status === 'failed').length;
+    let tasksCompleted = alreadyCompleted;
+    let tasksFailed = alreadyFailed;
+    let totalAgentInvocations = 0;
+    const failedTasks = [];
+    const retryCount = new Map();
+    // Main orchestration loop
+    while (true) {
+        // Get next eligible task
+        let nextTask;
+        try {
+            nextTask = getNextTask(tasks, progress);
+        }
+        catch (error) {
+            // Circular dependency or other fatal error
+            logger.error('orchestrator', 'Failed to get next task', { error: error.message });
+            return {
+                success: false,
+                tasksCompleted,
+                tasksFailed: tasks.length - tasksCompleted,
+                tasksRemaining: tasks.length - tasksCompleted - tasksFailed,
+                failedTasks,
+                totalAgentInvocations,
+            };
+        }
+        if (!nextTask) {
+            // No more eligible tasks
+            break;
+        }
+        logger.info('orchestrator', `Executing task ${nextTask.id}: ${nextTask.description}`);
+        // Mark task in progress
+        await updateTaskProgress(storyPath, nextTask.id, 'in_progress');
+        // Build task context
+        const taskContext = buildTaskContext(nextTask, storyContent, workingDir);
+        // Execute task agent (or simulate in dry run)
+        let result;
+        if (opts.dryRun) {
+            logger.info('orchestrator', `[DRY RUN] Would execute task ${nextTask.id}`);
+            result = {
+                success: true,
+                task: nextTask,
+                filesChanged: nextTask.files || [],
+                verificationPassed: true,
+            };
+        }
+        else {
+            result = await runSingleTaskAgent(taskContext);
+        }
+        totalAgentInvocations++;
+        const attempts = (retryCount.get(nextTask.id) || 0) + 1;
+        retryCount.set(nextTask.id, attempts);
+        // Evaluate result
+        const evaluation = evaluateTaskResult(result, attempts, opts.maxRetriesPerTask);
+        if (evaluation === 'success') {
+            // Task succeeded
+            await updateTaskProgress(storyPath, nextTask.id, 'completed');
+            tasksCompleted++;
+            // Commit if enabled
+            if (opts.commitAfterEachTask && !opts.dryRun) {
+                try {
+                    await commitTaskCompletion(nextTask, result.filesChanged, storyId, workingDir);
+                }
+                catch (error) {
+                    logger.error('orchestrator', `Failed to commit task ${nextTask.id}`, {
+                        error: error.message,
+                    });
+                    // Continue despite commit failure
+                }
+            }
+            logger.info('orchestrator', `Task ${nextTask.id} completed successfully`);
+        }
+        else if (evaluation === 'recoverable') {
+            // Recoverable failure - retry if under max attempts
+            if (attempts <= opts.maxRetriesPerTask) {
+                logger.warn('orchestrator', `Task ${nextTask.id} failed (recoverable), will retry (attempt ${attempts}/${opts.maxRetriesPerTask})`);
+                // Keep status as 'in_progress' to retry
+            }
+            else {
+                // Max retries exceeded
+                await updateTaskProgress(storyPath, nextTask.id, 'failed', result.error || 'Max retries exceeded');
+                tasksFailed++;
+                failedTasks.push({
+                    taskId: nextTask.id,
+                    error: result.error || 'Max retries exceeded',
+                    attempts,
+                });
+                logger.error('orchestrator', `Task ${nextTask.id} failed after ${attempts} attempts`);
+                if (opts.stopOnFirstFailure) {
+                    logger.error('orchestrator', 'Stopping orchestration due to unrecoverable failure');
+                    break;
+                }
+            }
+        }
+        else {
+            // Unrecoverable failure
+            await updateTaskProgress(storyPath, nextTask.id, 'failed', result.error || 'Unrecoverable failure');
+            tasksFailed++;
+            failedTasks.push({
+                taskId: nextTask.id,
+                error: result.error || 'Unrecoverable failure',
+                attempts,
+            });
+            logger.error('orchestrator', `Task ${nextTask.id} failed (unrecoverable)`);
+            if (opts.stopOnFirstFailure) {
+                logger.error('orchestrator', 'Stopping orchestration due to unrecoverable failure');
+                break;
+            }
+        }
+        // Reload progress for next iteration
+        progress = await getTaskProgress(storyPath);
+    }
+    // Calculate remaining tasks
+    const tasksRemaining = tasks.length - tasksCompleted - tasksFailed;
+    const result = {
+        success: tasksFailed === 0 && tasksRemaining === 0,
+        tasksCompleted,
+        tasksFailed,
+        tasksRemaining,
+        failedTasks,
+        totalAgentInvocations,
+    };
+    logger.info('orchestrator', 'Orchestration complete', result);
+    return result;
+}
+//# sourceMappingURL=orchestrator.js.map

package/dist/agents/orchestrator.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"orchestrator.js","sourceRoot":"","sources":["../../src/agents/orchestrator.ts"],"names":[],"mappings":"AAAA;;;;;GAKG;AAEH,OAAO,EAAE,SAAS,EAAE,MAAM,eAAe,CAAC;AAC1C,OAAO,EAAE,MAAM,IAAI,CAAC;AACpB,OAAO,IAAI,MAAM,MAAM,CAAC;AAYxB,OAAO,EAAE,wBAAwB,EAAE,MAAM,wBAAwB,CAAC;AAClE,OAAO,EACL,eAAe,EACf,kBAAkB,EAClB,sBAAsB,EACtB,aAAa,GACd,MAAM,0BAA0B,CAAC;AAClC,OAAO,EAAE,kBAAkB,EAAE,MAAM,kBAAkB,CAAC;AACtD,OAAO,EAAE,SAAS,EAAE,MAAM,mBAAmB,CAAC;AAE9C,MAAM,MAAM,GAAG,SAAS,EAAE,CAAC;AAE3B;;GAEG;AACH,MAAM,eAAe,GAAkC;IACrD,iBAAiB,EAAE,CAAC;IACpB,mBAAmB,EAAE,IAAI;IACzB,kBAAkB,EAAE,IAAI;IACxB,MAAM,EAAE,KAAK;CACd,CAAC;AAEF;;;;;;;;;;GAUG;AACH,MAAM,UAAU,gBAAgB,CAC9B,IAAwB,EACxB,YAAoB,EACpB,gBAAwB;IAExB,sCAAsC;IACtC,MAAM,kBAAkB,GAAa,EAAE,CAAC;IACxC,MAAM,OAAO,GAAG,YAAY,CAAC,KAAK,CAAC,sDAAsD,CAAC,CAAC;IAC3F,IAAI,OAAO,EAAE,CAAC;QACZ,MAAM,SAAS,GAAG,OAAO,CAAC,CAAC,CAAC,CAAC;QAC7B,MAAM,KAAK,GAAG,SAAS,CAAC,KAAK,CAAC,IAAI,CAAC,CAAC;QACpC,KAAK,MAAM,IAAI,IAAI,KAAK,EAAE,CAAC;YACzB,MAAM,OAAO,GAAG,IAAI,CAAC,IAAI,EAAE,CAAC;YAC5B,IAAI,OAAO,CAAC,UAAU,CAAC,GAAG,CAAC,IAAI,OAAO,CAAC,UAAU,CAAC,GAAG,CAAC,EAAE,CAAC;gBACvD,6BAA6B;gBAC7B,MAAM,SAAS,GAAG,OAAO,CAAC,OAAO,CAAC,qBAAqB,EAAE,EAAE,CAAC,CAAC,OAAO,CAAC,UAAU,EAAE,EAAE,CAAC,CAAC;gBACrF,IAAI,SAAS,EAAE,CAAC;oBACd,kBAAkB,CAAC,IAAI,CAAC,SAAS,CAAC,CAAC;gBACrC,CAAC;YACH,CAAC;QACH,CAAC;IACH,CAAC;IAED,kEAAkE;IAClE,MAAM,SAAS,GAAG,IAAI,CAAC,KAAK,IAAI,EAAE,CAAC;IACnC,MAAM,gBAAgB,GAAG,kBAAkB,CAAC,MAAM,CAAC,CAAC,SAAS,EAAE,EAAE;QAC/D,8CAA8C;QAC9C,OAAO,SAAS,CAAC,IAAI,CAAC,CAAC,IAAI,EAAE,EAAE;YAC7B,MAAM,QAAQ,GAAG,IAAI,CAAC,QAAQ,CAAC,IAAI,CAAC,CAAC;YACrC,MAAM,YAAY,GAAG,QAAQ,CAAC,OAAO,CAAC,oBAAoB,EAAE,EAAE,CAAC,CAAC;YAChE,OAAO,CACL,SAAS,CAAC,QAAQ,CAAC,IAAI,CAAC;gBACxB,SAAS,CAAC,QAAQ,CAAC,QAAQ,CAAC;gBAC5B,SAAS,CAAC,QAAQ,CAAC,YAAY,CAAC,CACjC,CAAC;QACJ,CAAC,CAAC,CAAC;IACL,CAAC,CAAC,CAAC;IAEH,sEAAsE;IACtE,MAAM,aAAa,GACjB,gBAAgB,CAAC,MAAM,GAAG,CAAC,CAAC,CAAC,CAAC,gBAAgB,CAAC,CAAC,CAAC,kBAAkB,CAAC,KAAK,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC;IAElF,sBAAsB;IACtB,MAAM,aAAa,GAAkB,EAAE,CAAC;IACxC,KAAK,MAAM,IAAI,IAAI,SAAS,EAAE,CAAC;QAC7B,MAAM,QAAQ,GAAG,IAAI,CAAC,IAAI,CAAC,gBAAgB,EAAE,IAAI,CAAC,CAAC;QACnD,IAAI,EAAE,CAAC,UAAU,CAAC,QAAQ,CAAC,EAAE,CAAC;YAC5B,IAAI,CAAC;gBACH,MAAM,OAAO,GAAG,EAAE,CAAC,YAAY,CAAC,QAAQ,EAAE,OAAO,CAAC,CAAC;gBACnD,aAAa,CAAC,IAAI,CAAC,EAAE,IAAI,EAAE,IAAI,EAAE,OAAO,EAAE,CAAC,CAAC;YAC9C,CAAC;YAAC,OAAO,KAAU,EAAE,CAAC;gBACpB,MAAM,CAAC,IAAI,CAAC,cAAc,EAAE,uBAAuB,IAAI,KAAK,KAAK,CAAC,OAAO,EAAE,CAAC,CAAC;YAC/E,CAAC;QACH,CAAC;IACH,CAAC;IAED,8CAA8C;IAC9C,IAAI,eAAe,GAAG,EAAE,CAAC;IACzB,MAAM,gBAAgB,GAAG,YAAY,CAAC,KAAK,CACzC,kFAAkF,CACnF,CAAC;IACF,IAAI,gBAAgB,EAAE,CAAC;QACrB,eAAe,GAAG,gBAAgB,CAAC,CAAC,CAAC,CAAC,IAAI,EAAE,CAAC;IAC/C,CAAC;IAED,uBAAuB;IACvB,MAAM,kBAAkB,GAAG,IAAI,CAAC;IAChC,IAAI,eAAe,CAAC,MAAM,GAAG,kBAAkB,EAAE,CAAC;QAChD,eAAe;YACb,eAAe,CAAC,SAAS,CAAC,CAAC,EAAE,kBAAkB,CAAC,GAAG,gCAAgC,CAAC;IACxF,CAAC;IAED,OAAO;QACL,IAAI;QACJ,kBAAkB,EAAE,aAAa;QACjC,aAAa;QACb,eAAe;QACf,gBAAgB;KACjB,CAAC;AACJ,CAAC;AAED;;;;;;;;;;;;GAYG;AACH,MAAM,UAAU,kBAAkB,CAChC,MAAuB,EACvB,YAAoB,EACpB,UAAkB;IAElB,IAAI,MAAM,CAAC,OAAO,EAAE,CAAC;QACnB,OAAO,SAAS,CAAC;IACnB,CAAC;IAED,MAAM,KAAK,GAAG,MAAM,CAAC,KAAK,IAAI,EAAE,CAAC;IACjC,MAAM,UAAU,GAAG,KAAK,CAAC,WAAW,EAAE,CAAC;IAEvC,wDAAwD;IACxD,IAAI,YAAY,GAAG,UAAU,EAAE,CAAC;QAC9B,MAAM,CAAC,IAAI,CAAC,cAAc,EAAE,QAAQ,MAAM,CAAC,IAAI,CAAC,EAAE,0BAA0B,UAAU,GAAG,CAAC,CAAC;QAC3F,OAAO,eAAe,CAAC;IACzB,CAAC;IAED,sCAAsC;IACtC,IACE,UAAU,CAAC,QAAQ,CAAC,YAAY,CAAC;QACjC,UAAU,CAAC,QAAQ,CAAC,YAAY,CAAC;QACjC,UAAU,CAAC,QAAQ,CAAC,cAAc,CAAC,EACnC,CAAC;QACD,OAAO,eAAe,CAAC;IACzB,CAAC;IAED,gDAAgD;IAChD,IACE,UAAU,CAAC,QAAQ,CAAC,YAAY,CAAC;QACjC,UAAU,CAAC,QAAQ,CAAC,gBAAgB,CAAC;QACrC,UAAU,CAAC,QAAQ,CAAC,aAAa,CAAC,EAClC,CAAC;QACD,OAAO,eAAe,CAAC;IACzB,CAAC;IAED,8CAA8C;IAC9C,IAAI,MAAM,CAAC,cAAc,IAAI,MAAM,CAAC,cAAc,CAAC,MAAM,GAAG,CAAC,EAAE,CAAC;QAC9D,MAAM,CAAC,IAAI,CACT,cAAc,EACd,QAAQ,MAAM,CAAC,IAAI,CAAC,EAAE,kCAAkC,MAAM,CAAC,cAAc,CAAC,IAAI,CAAC,IAAI,CAAC,EAAE,CAC3F,CAAC;QACF,OAAO,eAAe,CAAC;IACzB,CAAC;IAED,uBAAuB;IACvB,IAAI,UAAU,CAAC,QAAQ,CAAC,SAAS,CAAC,IAAI,UAAU,CAAC,QAAQ,CAAC,WAAW,CAAC,EAAE,CAAC;QACvE,OAAO,aAAa,CAAC;IACvB,CAAC;IAED,mCAAmC;IACnC,IACE,UAAU,CAAC,QAAQ,CAAC,YAAY,CAAC;QACjC,UAAU,CAAC,QAAQ,CAAC,SAAS,CAAC;QAC9B,UAAU,CAAC,QAAQ,CAAC,YAAY,CAAC;QACjC,UAAU,CAAC,QAAQ,CAAC,WAAW,CAAC,EAChC,CAAC;QACD,OAAO,aAAa,CAAC;IACvB,CAAC;IAED,sDAAsD;IACtD,IACE,CAAC,MAAM,CAAC,kBAAkB;QAC1B,UAAU,CAAC,QAAQ,CAAC,MAAM,CAAC;QAC3B,UAAU,CAAC,QAAQ,CAAC,MAAM,CAAC;QAC3B,UAAU,CAAC,QAAQ,CAAC,OAAO,CAAC,EAC5B,CAAC;QACD,OAAO,aAAa,CAAC;IACvB,CAAC;IAED,gEAAgE;IAChE,IACE,UAAU,CAAC,QAAQ,CAAC,SAAS,CAAC;QAC9B,UAAU,CAAC,QAAQ,CAAC,MAAM,CAAC;QAC3B,UAAU,CAAC,QAAQ,CAAC,cAAc,CAAC;QACnC,MAAM,CAAC,mBAAmB,EAC1B,CAAC;QACD,OAAO,aAAa,CAAC;IACvB,CAAC;IAED,wEAAwE;IACxE,OAAO,aAAa,CAAC;AACvB,CAAC;AAED;;;;;;;;;;GAUG;AACH,MAAM,UAAU,WAAW,CACzB,KAA2B,EAC3B,QAAwB;IAExB,sCAAsC;IACtC,MAAM,WAAW,GAAG,IAAI,GAAG,EAAsB,CAAC;IAClD,KAAK,MAAM,CAAC,IAAI,QAAQ,EAAE,CAAC;QACzB,WAAW,CAAC,GAAG,CAAC,CAAC,CAAC,MAAM,EAAE,CAAC,CAAC,MAAM,CAAC,CAAC;IACtC,CAAC;IAED,oCAAoC;IACpC,MAAM,aAAa,GAAG,KAAK,CAAC,MAAM,CAAC,CAAC,IAAI,EAAE,EAAE;QAC1C,MAAM,MAAM,GAAG,WAAW,CAAC,GAAG,CAAC,IAAI,CAAC,EAAE,CAAC,CAAC;QAExC,6CAA6C;QAC7C,IAAI,MAAM,KAAK,SAAS,IAAI,MAAM,KAAK,aAAa,EAAE,CAAC;YACrD,OAAO,KAAK,CAAC;QACf,CAAC;QAED,0CAA0C;QAC1C,MAAM,IAAI,GAAG,IAAI,CAAC,YAAY,IAAI,EAAE,CAAC;QACrC,MAAM,gBAAgB,GAAG,IAAI,CAAC,KAAK,CAAC,CAAC,KAAK,EAAE,EAAE,CAAC,WAAW,CAAC,GAAG,CAAC,KAAK,CAAC,KAAK,WAAW,CAAC,CAAC;QAEvF,OAAO,gBAAgB,CAAC;IAC1B,CAAC,CAAC,CAAC;IAEH,yDAAyD;IACzD,MAAM,cAAc,GAAG,aAAa,CAAC,IAAI,CAAC,CAAC,IAAI,EAAE,EAAE,CAAC,WAAW,CAAC,GAAG,CAAC,IAAI,CAAC,EAAE,CAAC,KAAK,aAAa,CAAC,CAAC;IAChG,IAAI,cAAc,EAAE,CAAC;QACnB,OAAO,cAAc,CAAC;IACxB,CAAC;IAED,4BAA4B;IAC5B,MAAM,WAAW,GAAG,aAAa,CAAC,IAAI,CAAC,CAAC,IAAI,EAAE,EAAE,CAAC,WAAW,CAAC,GAAG,CAAC,IAAI,CAAC,EAAE,CAAC,KAAK,SAAS,CAAC,CAAC;IACzF,IAAI,WAAW,EAAE,CAAC;QAChB,OAAO,WAAW,CAAC;IACrB,CAAC;IAED,sDAAsD;IACtD,MAAM,eAAe,GAAG,KAAK,CAAC,MAAM,CAAC,CAAC,IAAI,EAAE,EAAE;QAC5C,MAAM,MAAM,GAAG,WAAW,CAAC,GAAG,CAAC,IAAI,CAAC,EAAE,CAAC,CAAC;QACxC,OAAO,MAAM,KAAK,WAAW,IAAI,MAAM,KAAK,QAAQ,CAAC;IACvD,CAAC,CAAC,CAAC;IAEH,IAAI,eAAe,CAAC,MAAM,GAAG,CAAC,EAAE,CAAC;QAC/B,8EAA8E;QAC9E,MAAM,OAAO,GAAG,eAAe,CAAC,GAAG,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;QAC5D,MAAM,IAAI,KAAK,CACb,wCAAwC,OAAO,gDAAgD,CAChG,CAAC;IACJ,CAAC;IAED,OAAO,IAAI,CAAC;AACd,CAAC;AAED;;;;;;;;;;;GAWG;AACH,KAAK,UAAU,oBAAoB,CACjC,IAAwB,EACxB,YAAsB,EACtB,OAAe,EACf,UAAkB;IAElB,IAAI,YAAY,CAAC,MAAM,KAAK,CAAC,EAAE,CAAC;QAC9B,MAAM,CAAC,IAAI,CAAC,cAAc,EAAE,QAAQ,IAAI,CAAC,EAAE,kDAAkD,CAAC,CAAC;QAC/F,OAAO;IACT,CAAC;IAED,sBAAsB;IACtB,MAAM,aAAa,GAAG,IAAI,CAAC,KAAK,IAAI,EAAE,CAAC;IACvC,MAAM,UAAU,GAAG,YAAY,CAAC,MAAM,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,aAAa,CAAC,QAAQ,CAAC,CAAC,CAAC,CAAC,CAAC;IAC1E,IAAI,UAAU,CAAC,MAAM,GAAG,CAAC,EAAE,CAAC;QAC1B,MAAM,IAAI,KAAK,CACb,QAAQ,IAAI,CAAC,EAAE,2CAA2C,UAAU,CAAC,IAAI,CAAC,IAAI,CAAC,EAAE,CAClF,CAAC;IACJ,CAAC;IAED,wCAAwC;IACxC,MAAM,SAAS,GAAG,SAAS,CAAC,KAAK,EAAE,CAAC,KAAK,EAAE,GAAG,YAAY,CAAC,EAAE;QAC3D,GAAG,EAAE,UAAU;QACf,QAAQ,EAAE,MAAM;KACjB,CAAC,CAAC;IAEH,IAAI,SAAS,CAAC,KAAK,EAAE,CAAC;QACpB,MAAM,IAAI,KAAK,CAAC,0BAA0B,SAAS,CAAC,KAAK,CAAC,OAAO,EAAE,CAAC,CAAC;IACvE,CAAC;IAED,IAAI,SAAS,CAAC,MAAM,KAAK,CAAC,EAAE,CAAC;QAC3B,MAAM,MAAM,GAAG,SAAS,CAAC,MAAM,IAAI,SAAS,CAAC,MAAM,IAAI,EAAE,CAAC;QAC1D,MAAM,IAAI,KAAK,CAAC,0BAA0B,MAAM,EAAE,CAAC,CAAC;IACtD,CAAC;IAED,gBAAgB;IAChB,MAAM,aAAa,GAAG,QAAQ,OAAO,oBAAoB,IAAI,CAAC,EAAE,MAAM,IAAI,CAAC,WAAW,EAAE,CAAC;IAEzF,MAAM,YAAY,GAAG,SAAS,CAAC,KAAK,EAAE,CAAC,QAAQ,EAAE,IAAI,EAAE,aAAa,CAAC,EAAE;QACrE,GAAG,EAAE,UAAU;QACf,QAAQ,EAAE,MAAM;KACjB,CAAC,CAAC;IAEH,IAAI,YAAY,CAAC,KAAK,EAAE,CAAC;QACvB,MAAM,IAAI,KAAK,CAAC,qBAAqB,YAAY,CAAC,KAAK,CAAC,OAAO,EAAE,CAAC,CAAC;IACrE,CAAC;IAED,IAAI,YAAY,CAAC,MAAM,KAAK,CAAC,EAAE,CAAC;QAC9B,MAAM,MAAM,GAAG,YAAY,CAAC,MAAM,IAAI,YAAY,CAAC,MAAM,IAAI,EAAE,CAAC;QAChE,MAAM,IAAI,KAAK,CAAC,qBAAqB,MAAM,EAAE,CAAC,CAAC;IACjD,CAAC;IAED,MAAM,CAAC,IAAI,CAAC,cAAc,EAAE,kBAAkB,IAAI,CAAC,EAAE,KAAK,aAAa,EAAE,CAAC,CAAC;AAC7E,CAAC;AAED;;;;;;;;;;;;;GAaG;AACH,MAAM,CAAC,KAAK,UAAU,6BAA6B,CACjD,SAAiB,EACjB,QAAgB,EAChB,OAA6B;IAE7B,MAAM,IAAI,GAAG,EAAE,GAAG,eAAe,EAAE,GAAG,OAAO,EAAE,CAAC;IAChD,MAAM,UAAU,GAAG,IAAI,CAAC,OAAO,CAAC,SAAS,CAAC,CAAC;IAE3C,MAAM,CAAC,IAAI,CAAC,cAAc,EAAE,uCAAuC,EAAE;QACnE,SAAS;QACT,OAAO,EAAE,IAAI;KACd,CAAC,CAAC;IAEH,wBAAwB;IACxB,MAAM,YAAY,GAAG,MAAM,aAAa,CAAC,SAAS,CAAC,CAAC;IACpD,MAAM,KAAK,GAAG,wBAAwB,CAAC,YAAY,CAAC,CAAC;IAErD,IAAI,KAAK,CAAC,MAAM,KAAK,CAAC,EAAE,CAAC;QACvB,MAAM,CAAC,IAAI,CAAC,cAAc,EAAE,uCAAuC,CAAC,CAAC;QACrE,OAAO;YACL,OAAO,EAAE,IAAI;YACb,cAAc,EAAE,CAAC;YACjB,WAAW,EAAE,CAAC;YACd,cAAc,EAAE,CAAC;YACjB,WAAW,EAAE,EAAE;YACf,qBAAqB,EAAE,CAAC;SACzB,CAAC;IACJ,CAAC;IAED,MAAM,CAAC,IAAI,CAAC,cAAc,EAAE,SAAS,KAAK,CAAC,MAAM,gBAAgB,CAAC,CAAC;IAEnE,8BAA8B;IAC9B,IAAI,QAAQ,GAAG,MAAM,eAAe,CAAC,SAAS,CAAC,CAAC;IAChD,IAAI,QAAQ,CAAC,MAAM,KAAK,CAAC,EAAE,CAAC;QAC1B,MAAM,CAAC,IAAI,CAAC,cAAc,EAAE,qCAAqC,CAAC,CAAC;QACnE,MAAM,sBAAsB,CAC1B,SAAS,EACT,KAAK,CAAC,GAAG,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,EAAE,CAAC,CACvB,CAAC;QACF,QAAQ,GAAG,MAAM,eAAe,CAAC,SAAS,CAAC,CAAC;IAC9C,CAAC;IAED,6BAA6B;IAC7B,MAAM,OAAO,GAAG,IAAI,CAAC,QAAQ,CAAC,IAAI,CAAC,OAAO,CAAC,SAAS,CAAC,CAAC,CAAC;IAEvD,mBAAmB;IACnB,mDAAmD;IACnD,MAAM,gBAAgB,GAAG,QAAQ,CAAC,MAAM,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,MAAM,KAAK,WAAW,CAAC,CAAC,MAAM,CAAC;IACjF,MAAM,aAAa,GAAG,QAAQ,CAAC,MAAM,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,MAAM,KAAK,QAAQ,CAAC,CAAC,MAAM,CAAC;IAC3E,IAAI,cAAc,GAAG,gBAAgB,CAAC;IACtC,IAAI,WAAW,GAAG,aAAa,CAAC;IAChC,IAAI,qBAAqB,GAAG,CAAC,CAAC;IAC9B,MAAM,WAAW,GAAqB,EAAE,CAAC;IACzC,MAAM,UAAU,GAAG,IAAI,GAAG,EAAkB,CAAC;IAE7C,0BAA0B;IAC1B,OAAO,IAAI,EAAE,CAAC;QACZ,yBAAyB;QACzB,IAAI,QAAmC,CAAC;QACxC,IAAI,CAAC;YACH,QAAQ,GAAG,WAAW,CAAC,KAAK,EAAE,QAAQ,CAAC,CAAC;QAC1C,CAAC;QAAC,OAAO,KAAU,EAAE,CAAC;YACpB,2CAA2C;YAC3C,MAAM,CAAC,KAAK,CAAC,cAAc,EAAE,yBAAyB,EAAE,EAAE,KAAK,EAAE,KAAK,CAAC,OAAO,EAAE,CAAC,CAAC;YAClF,OAAO;gBACL,OAAO,EAAE,KAAK;gBACd,cAAc;gBACd,WAAW,EAAE,KAAK,CAAC,MAAM,GAAG,cAAc;gBAC1C,cAAc,EAAE,KAAK,CAAC,MAAM,GAAG,cAAc,GAAG,WAAW;gBAC3D,WAAW;gBACX,qBAAqB;aACtB,CAAC;QACJ,CAAC;QAED,IAAI,CAAC,QAAQ,EAAE,CAAC;YACd,yBAAyB;YACzB,MAAM;QACR,CAAC;QAED,MAAM,CAAC,IAAI,CAAC,cAAc,EAAE,kBAAkB,QAAQ,CAAC,EAAE,KAAK,QAAQ,CAAC,WAAW,EAAE,CAAC,CAAC;QAEtF,wBAAwB;QACxB,MAAM,kBAAkB,CAAC,SAAS,EAAE,QAAQ,CAAC,EAAE,EAAE,aAAa,CAAC,CAAC;QAEhE,qBAAqB;QACrB,MAAM,WAAW,GAAG,gBAAgB,CAAC,QAAQ,EAAE,YAAY,EAAE,UAAU,CAAC,CAAC;QAEzE,8CAA8C;QAC9C,IAAI,MAAuB,CAAC;QAC5B,IAAI,IAAI,CAAC,MAAM,EAAE,CAAC;YAChB,MAAM,CAAC,IAAI,CAAC,cAAc,EAAE,gCAAgC,QAAQ,CAAC,EAAE,EAAE,CAAC,CAAC;YAC3E,MAAM,GAAG;gBACP,OAAO,EAAE,IAAI;gBACb,IAAI,EAAE,QAAQ;gBACd,YAAY,EAAE,QAAQ,CAAC,KAAK,IAAI,EAAE;gBAClC,kBAAkB,EAAE,IAAI;aACzB,CAAC;QACJ,CAAC;aAAM,CAAC;YACN,MAAM,GAAG,MAAM,kBAAkB,CAAC,WAAW,CAAC,CAAC;QACjD,CAAC;QAED,qBAAqB,EAAE,CAAC;QACxB,MAAM,QAAQ,GAAG,CAAC,UAAU,CAAC,GAAG,CAAC,QAAQ,CAAC,EAAE,CAAC,IAAI,CAAC,CAAC,GAAG,CAAC,CAAC;QACxD,UAAU,CAAC,GAAG,CAAC,QAAQ,CAAC,EAAE,EAAE,QAAQ,CAAC,CAAC;QAEtC,kBAAkB;QAClB,MAAM,UAAU,GAAG,kBAAkB,CAAC,MAAM,EAAE,QAAQ,EAAE,IAAI,CAAC,iBAAiB,CAAC,CAAC;QAEhF,IAAI,UAAU,KAAK,SAAS,EAAE,CAAC;YAC7B,iBAAiB;YACjB,MAAM,kBAAkB,CAAC,SAAS,EAAE,QAAQ,CAAC,EAAE,EAAE,WAAW,CAAC,CAAC;YAC9D,cAAc,EAAE,CAAC;YAEjB,oBAAoB;YACpB,IAAI,IAAI,CAAC,mBAAmB,IAAI,CAAC,IAAI,CAAC,MAAM,EAAE,CAAC;gBAC7C,IAAI,CAAC;oBACH,MAAM,oBAAoB,CAAC,QAAQ,EAAE,MAAM,CAAC,YAAY,EAAE,OAAO,EAAE,UAAU,CAAC,CAAC;gBACjF,CAAC;gBAAC,OAAO,KAAU,EAAE,CAAC;oBACpB,MAAM,CAAC,KAAK,CAAC,cAAc,EAAE,yBAAyB,QAAQ,CAAC,EAAE,EAAE,EAAE;wBACnE,KAAK,EAAE,KAAK,CAAC,OAAO;qBACrB,CAAC,CAAC;oBACH,kCAAkC;gBACpC,CAAC;YACH,CAAC;YAED,MAAM,CAAC,IAAI,CAAC,cAAc,EAAE,QAAQ,QAAQ,CAAC,EAAE,yBAAyB,CAAC,CAAC;QAC5E,CAAC;aAAM,IAAI,UAAU,KAAK,aAAa,EAAE,CAAC;YACxC,oDAAoD;YACpD,IAAI,QAAQ,IAAI,IAAI,CAAC,iBAAiB,EAAE,CAAC;gBACvC,MAAM,CAAC,IAAI,CACT,cAAc,EACd,QAAQ,QAAQ,CAAC,EAAE,8CAA8C,QAAQ,IAAI,IAAI,CAAC,iBAAiB,GAAG,CACvG,CAAC;gBACF,wCAAwC;YAC1C,CAAC;iBAAM,CAAC;gBACN,uBAAuB;gBACvB,MAAM,kBAAkB,CACtB,SAAS,EACT,QAAQ,CAAC,EAAE,EACX,QAAQ,EACR,MAAM,CAAC,KAAK,IAAI,sBAAsB,CACvC,CAAC;gBACF,WAAW,EAAE,CAAC;gBACd,WAAW,CAAC,IAAI,CAAC;oBACf,MAAM,EAAE,QAAQ,CAAC,EAAE;oBACnB,KAAK,EAAE,MAAM,CAAC,KAAK,IAAI,sBAAsB;oBAC7C,QAAQ;iBACT,CAAC,CAAC;gBAEH,MAAM,CAAC,KAAK,CAAC,cAAc,EAAE,QAAQ,QAAQ,CAAC,EAAE,iBAAiB,QAAQ,WAAW,CAAC,CAAC;gBAEtF,IAAI,IAAI,CAAC,kBAAkB,EAAE,CAAC;oBAC5B,MAAM,CAAC,KAAK,CAAC,cAAc,EAAE,qDAAqD,CAAC,CAAC;oBACpF,MAAM;gBACR,CAAC;YACH,CAAC;QACH,CAAC;aAAM,CAAC;YACN,wBAAwB;YACxB,MAAM,kBAAkB,CACtB,SAAS,EACT,QAAQ,CAAC,EAAE,EACX,QAAQ,EACR,MAAM,CAAC,KAAK,IAAI,uBAAuB,CACxC,CAAC;YACF,WAAW,EAAE,CAAC;YACd,WAAW,CAAC,IAAI,CAAC;gBACf,MAAM,EAAE,QAAQ,CAAC,EAAE;gBACnB,KAAK,EAAE,MAAM,CAAC,KAAK,IAAI,uBAAuB;gBAC9C,QAAQ;aACT,CAAC,CAAC;YAEH,MAAM,CAAC,KAAK,CAAC,cAAc,EAAE,QAAQ,QAAQ,CAAC,EAAE,yBAAyB,CAAC,CAAC;YAE3E,IAAI,IAAI,CAAC,kBAAkB,EAAE,CAAC;gBAC5B,MAAM,CAAC,KAAK,CAAC,cAAc,EAAE,qDAAqD,CAAC,CAAC;gBACpF,MAAM;YACR,CAAC;QACH,CAAC;QAED,qCAAqC;QACrC,QAAQ,GAAG,MAAM,eAAe,CAAC,SAAS,CAAC,CAAC;IAC9C,CAAC;IAED,4BAA4B;IAC5B,MAAM,cAAc,GAAG,KAAK,CAAC,MAAM,GAAG,cAAc,GAAG,WAAW,CAAC;IAEnE,MAAM,MAAM,GAAuB;QACjC,OAAO,EAAE,WAAW,KAAK,CAAC,IAAI,cAAc,KAAK,CAAC;QAClD,cAAc;QACd,WAAW;QACX,cAAc;QACd,WAAW;QACX,qBAAqB;KACtB,CAAC;IAEF,MAAM,CAAC,IAAI,CAAC,cAAc,EAAE,wBAAwB,EAAE,MAAM,CAAC,CAAC;IAE9D,OAAO,MAAM,CAAC;AAChB,CAAC"}

package/dist/agents/review.d.ts

@@ -50,6 +50,16 @@ export declare function deriveIndividualPassFailFromPerspectives(issues: ReviewI
  * @returns Array of source file paths that have changed, or ['unknown'] if git fails
  */
 export declare function getSourceCodeChanges(workingDir: string): string[];
+/**
+ * Check if test files exist in git diff
+ *
+ * Returns true if any test files have been modified/added, false otherwise.
+ * Uses spawnSync for security (prevents command injection).
+ *
+ * @param workingDir - Working directory to run git diff in
+ * @returns True if test files exist in changes, false otherwise
+ */
+export declare function hasTestFiles(workingDir: string): boolean;
 /**
  * Generate executive summary from review issues (1-3 sentences)
  *

package/dist/agents/review.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"review.d.ts","sourceRoot":"","sources":["../../src/agents/review.ts"],"names":[],"mappings":"AASA,OAAO,EAAE,KAAK,EAAE,WAAW,EAAE,YAAY,EAAE,WAAW,EAA8E,YAAY,EAAE,MAAM,mBAAmB,CAAC;AAqH5K;;;;;;;;GAQG;AACH,wBAAgB,iBAAiB,CAAC,MAAM,EAAE,YAAY,EAAE,GAAG,MAAM,EAAE,CA0BlE;AAED;;;;;;;;GAQG;AACH,wBAAgB,iBAAiB,CAAC,UAAU,EAAE,MAAM,EAAE,GAAG,WAAW,EAAE,CAOrE;AAiBD;;GAEG;AACH,MAAM,MAAM,4BAA4B,GAAG,CAAC,KAAK,EAAE,OAAO,GAAG,MAAM,EAAE,MAAM,EAAE,UAAU,GAAG,SAAS,GAAG,QAAQ,GAAG,QAAQ,EAAE,OAAO,CAAC,EAAE,MAAM,KAAK,IAAI,CAAC;AAqWrJ;;;;;;;;;;;GAWG;AACH,wBAAgB,wCAAwC,CAAC,MAAM,EAAE,WAAW,EAAE,GAAG;IAC/E,gBAAgB,EAAE,OAAO,CAAC;IAC1B,oBAAoB,EAAE,OAAO,CAAC;IAC9B,cAAc,EAAE,OAAO,CAAC;CACzB,CAsBA;AAsED;;;;;;;;GAQG;AACH,wBAAgB,oBAAoB,CAAC,UAAU,EAAE,MAAM,GAAG,MAAM,EAAE,CA2BjE;AAED;;;;;;;;;;GAUG;AACH,wBAAgB,qBAAqB,CAAC,MAAM,EAAE,WAAW,EAAE,EAAE,aAAa,EAAE,MAAM,GAAG,MAAM,CA+F1F;AAED;;GAEG;AACH,MAAM,WAAW,kBAAkB;IACjC,iDAAiD;IACjD,sBAAsB,CAAC,EAAE,4BAA4B,CAAC;CACvD;AAED;;;;;GAKG;AACH,wBAAsB,cAAc,CAClC,SAAS,EAAE,MAAM,EACjB,QAAQ,EAAE,MAAM,EAChB,OAAO,CAAC,EAAE,kBAAkB,GAC3B,OAAO,CAAC,YAAY,CAAC,CAiXvB;AAED;;;GAGG;AACH,wBAAgB,oBAAoB,CAAC,OAAO,EAAE,MAAM,GAAG,KAAK,CAAC;IAAE,KAAK,EAAE,MAAM,CAAC;IAAC,OAAO,EAAE,MAAM,CAAA;CAAE,CAAC,CAkB/F;AAED;;;;GAIG;AACH,wBAAgB,0BAA0B,CAAC,OAAO,EAAE,MAAM,GAAG,MAAM,CAelE;AAED;;;GAGG;AACH,wBAAgB,eAAe,CAAC,SAAS,EAAE,MAAM,EAAE,MAAM,EAAE,MAAM,EAAE,UAAU,EAAE,MAAM,GAAG,MAAM,CAiB7F;AAED;;;;GAIG;AACH,wBAAgB,mBAAmB,CAAC,KAAK,EAAE,KAAK,EAAE,YAAY,EAAE,MAAM,GAAG,MAAM,CAsC9E;AAED;;;;GAIG;AACH,wBAAgB,cAAc,CAAC,IAAI,EAAE,MAAM,EAAE,SAAS,GAAE,MAAc,GAAG,MAAM,CAqC9E;AAgCD;;GAEG;AACH,MAAM,WAAW,eAAe;IAC9B,+EAA+E;IAC/E,KAAK,CAAC,EAAE,OAAO,CAAC;CACjB;AAED;;GAEG;AACH,wBAAsB,iBAAiB,CACrC,SAAS,EAAE,MAAM,EACjB,QAAQ,EAAE,MAAM,EAChB,OAAO,CAAC,EAAE,eAAe,GACxB,OAAO,CAAC,WAAW,CAAC,CAqKtB"}
+{"version":3,"file":"review.d.ts","sourceRoot":"","sources":["../../src/agents/review.ts"],"names":[],"mappings":"AASA,OAAO,EAAE,KAAK,EAAE,WAAW,EAAE,YAAY,EAAE,WAAW,EAA8E,YAAY,EAAE,MAAM,mBAAmB,CAAC;AAqH5K;;;;;;;;GAQG;AACH,wBAAgB,iBAAiB,CAAC,MAAM,EAAE,YAAY,EAAE,GAAG,MAAM,EAAE,CA0BlE;AAED;;;;;;;;GAQG;AACH,wBAAgB,iBAAiB,CAAC,UAAU,EAAE,MAAM,EAAE,GAAG,WAAW,EAAE,CAOrE;AAiBD;;GAEG;AACH,MAAM,MAAM,4BAA4B,GAAG,CAAC,KAAK,EAAE,OAAO,GAAG,MAAM,EAAE,MAAM,EAAE,UAAU,GAAG,SAAS,GAAG,QAAQ,GAAG,QAAQ,EAAE,OAAO,CAAC,EAAE,MAAM,KAAK,IAAI,CAAC;AAuZrJ;;;;;;;;;;;GAWG;AACH,wBAAgB,wCAAwC,CAAC,MAAM,EAAE,WAAW,EAAE,GAAG;IAC/E,gBAAgB,EAAE,OAAO,CAAC;IAC1B,oBAAoB,EAAE,OAAO,CAAC;IAC9B,cAAc,EAAE,OAAO,CAAC;CACzB,CAsBA;AAsED;;;;;;;;GAQG;AACH,wBAAgB,oBAAoB,CAAC,UAAU,EAAE,MAAM,GAAG,MAAM,EAAE,CA2BjE;AAED;;;;;;;;GAQG;AACH,wBAAgB,YAAY,CAAC,UAAU,EAAE,MAAM,GAAG,OAAO,CA2BxD;AAED;;;;;;;;;;GAUG;AACH,wBAAgB,qBAAqB,CAAC,MAAM,EAAE,WAAW,EAAE,EAAE,aAAa,EAAE,MAAM,GAAG,MAAM,CA+F1F;AAED;;GAEG;AACH,MAAM,WAAW,kBAAkB;IACjC,iDAAiD;IACjD,sBAAsB,CAAC,EAAE,4BAA4B,CAAC;CACvD;AAED;;;;;GAKG;AACH,wBAAsB,cAAc,CAClC,SAAS,EAAE,MAAM,EACjB,QAAQ,EAAE,MAAM,EAChB,OAAO,CAAC,EAAE,kBAAkB,GAC3B,OAAO,CAAC,YAAY,CAAC,CA+YvB;AAED;;;GAGG;AACH,wBAAgB,oBAAoB,CAAC,OAAO,EAAE,MAAM,GAAG,KAAK,CAAC;IAAE,KAAK,EAAE,MAAM,CAAC;IAAC,OAAO,EAAE,MAAM,CAAA;CAAE,CAAC,CAkB/F;AAED;;;;GAIG;AACH,wBAAgB,0BAA0B,CAAC,OAAO,EAAE,MAAM,GAAG,MAAM,CAelE;AAED;;;GAGG;AACH,wBAAgB,eAAe,CAAC,SAAS,EAAE,MAAM,EAAE,MAAM,EAAE,MAAM,EAAE,UAAU,EAAE,MAAM,GAAG,MAAM,CAiB7F;AAED;;;;GAIG;AACH,wBAAgB,mBAAmB,CAAC,KAAK,EAAE,KAAK,EAAE,YAAY,EAAE,MAAM,GAAG,MAAM,CAsC9E;AAED;;;;GAIG;AACH,wBAAgB,cAAc,CAAC,IAAI,EAAE,MAAM,EAAE,SAAS,GAAE,MAAc,GAAG,MAAM,CAqC9E;AAgCD;;GAEG;AACH,MAAM,WAAW,eAAe;IAC9B,+EAA+E;IAC/E,KAAK,CAAC,EAAE,OAAO,CAAC;CACjB;AAED;;GAEG;AACH,wBAAsB,iBAAiB,CACrC,SAAS,EAAE,MAAM,EACjB,QAAQ,EAAE,MAAM,EAChB,OAAO,CAAC,EAAE,eAAe,GACxB,OAAO,CAAC,WAAW,CAAC,CAqKtB"}

package/dist/agents/review.js

@@ -253,7 +253,7 @@ Output your review as a JSON object with this structure:
   "issues": [
     {
       "severity": "blocker" | "critical" | "major" | "minor",
-      "category": "code_quality" | "security" | "requirements" | "testing" | etc,
+      "category": "code_quality" | "security" | "requirements" | "testing" | "test_alignment" | etc,
       "description": "Detailed description of the issue",
       "file": "path/to/file.ts" (if applicable),
       "line": 42 (if applicable),
@@ -264,7 +264,7 @@ Output your review as a JSON object with this structure:
 }
 
 Severity guidelines:
-- blocker: Must be fixed before merging (security holes, broken functionality)
+- blocker: Must be fixed before merging (security holes, broken functionality, test misalignment)
 - critical: Should be fixed before merging (major bugs, poor practices)
 - major: Should be addressed soon (code quality, maintainability)
 - minor: Nice to have improvements (style, optimizations)
@@ -305,6 +305,56 @@ Evaluate:
 - Is documentation adequate for users and maintainers?
 - Does the implementation align with the story goals?
 
+## Test-Implementation Alignment (BLOCKER category)
+
+**CRITICAL PRE-REVIEW REQUIREMENT**: Tests have already been executed and passed. However, passing tests don't guarantee correctness if they verify outdated behavior.
+
+During code review, you MUST verify test alignment:
+
+1. **For each changed production file, identify its test file**
+   - Check if tests exist for modified functions/modules
+   - Read the test assertions carefully
+
+2. **Verify tests match NEW behavior, not OLD**
+   - Do test assertions expect the current implementation behavior?
+   - If production code changed from sync to async, do tests use await?
+   - If function signature changed, do tests call it correctly?
+   - If return values changed, do tests expect the new values?
+
+3. **Flag misalignment as BLOCKER**
+   - If tests reference changed code but still expect old behavior:
+     - This is a **BLOCKER** severity issue
+     - Category MUST be: \`"test_alignment"\`
+     - Specify which test files need updating and why
+     - Provide example of correct assertion for new behavior
+
+**Example of misaligned test (BLOCKER):**
+\`\`\`typescript
+// Production code changed from sync to async
+async function loadConfig(): Promise<Config> {
+  return await fetchConfig();
+}
+
+// Test still expects sync behavior - MISSING await (BLOCKER)
+test('loads config', () => {
+  const config = loadConfig(); // ❌ Missing await! Returns Promise<Config>, not Config
+  expect(config.port).toBe(3000); // ❌ Checking Promise.port, not config.port
+});
+
+// Correct aligned test:
+test('loads config', async () => {
+  const config = await loadConfig(); // ✅ Awaits async function
+  expect(config.port).toBe(3000);     // ✅ Checks actual config
+});
+\`\`\`
+
+**When to flag test_alignment issues:**
+- Tests verify old function signatures that no longer exist
+- Tests expect old return value formats that changed
+- Tests miss new error conditions introduced
+- Tests pass but don't exercise the new code paths
+- Mock expectations don't match the new implementation calls
+
 ## CRITICAL DEDUPLICATION INSTRUCTIONS:
 
 1. **DO NOT repeat the same underlying issue from different perspectives**
@@ -574,6 +624,39 @@ export function getSourceCodeChanges(workingDir) {
         return ['unknown'];
     }
 }
+/**
+ * Check if test files exist in git diff
+ *
+ * Returns true if any test files have been modified/added, false otherwise.
+ * Uses spawnSync for security (prevents command injection).
+ *
+ * @param workingDir - Working directory to run git diff in
+ * @returns True if test files exist in changes, false otherwise
+ */
+export function hasTestFiles(workingDir) {
+    try {
+        // Security: Use spawnSync with explicit args (not shell) to prevent injection
+        const result = spawnSync('git', ['diff', '--name-only', 'HEAD~1'], {
+            cwd: workingDir,
+            encoding: 'utf-8',
+            stdio: ['ignore', 'pipe', 'pipe'],
+        });
+        if (result.status !== 0) {
+            // Git command failed - fail open (assume tests exist to avoid false blocks)
+            return true;
+        }
+        const output = result.stdout.toString();
+        const files = output.split('\n').filter(f => f.trim());
+        // Check if any files match test patterns
+        return files.some(f => f.includes('.test.') ||
+            f.includes('.spec.') ||
+            f.includes('__tests__/'));
+    }
+    catch {
+        // If git diff fails, assume tests exist (fail open, not closed)
+        return true;
+    }
+}
 /**
  * Generate executive summary from review issues (1-3 sentences)
  *
@@ -791,6 +874,34 @@ export async function runReviewAgent(storyPath, sdlcRoot, options) {
             storyId: story.frontmatter.id,
             fileCount: sourceChanges.length,
         });
+        // PRE-CHECK GATE: Check if test files exist
+        const testsExist = hasTestFiles(workingDir);
+        if (!testsExist) {
+            logger.warn('review', 'No test files detected in implementation changes', {
+                storyId: story.frontmatter.id,
+            });
+            return {
+                success: true,
+                story: parseStory(storyPath),
+                changesMade: ['No test files found for implementation'],
+                passed: false,
+                decision: ReviewDecision.REJECTED,
+                severity: ReviewSeverity.CRITICAL,
+                reviewType: 'pre-check',
+                issues: [{
+                        severity: 'blocker',
+                        category: 'testing',
+                        description: 'No tests found for this implementation. All implementations must include tests.',
+                        suggestedFix: 'Add test files (*.test.ts, *.spec.ts, or files in __tests__/ directory) that verify the implementation.',
+                    }],
+                feedback: formatIssuesForDisplay([{
+                        severity: 'blocker',
+                        category: 'testing',
+                        description: 'No tests found for this implementation. All implementations must include tests.',
+                        suggestedFix: 'Add test files (*.test.ts, *.spec.ts, or files in __tests__/ directory) that verify the implementation.',
+                    }]),
+            };
+        }
         // Run build and tests BEFORE reviews (async with progress)
         changesMade.push('Running build and test verification...');
         const verification = await runVerificationAsync(workingDir, config, options?.onVerificationProgress);
@@ -837,7 +948,7 @@ export async function runReviewAgent(storyPath, sdlcRoot, options) {
                     severity: 'blocker',
                     category: 'testing',
                     description: `Tests must pass before code review can proceed.\n\nCommand: ${config.testCommand}\n\nTest output:\n\`\`\`\n${testOutput}${truncationNote}\n\`\`\``,
-                    suggestedFix: 'Fix failing tests before review can proceed.',
+                    suggestedFix: 'Fix failing tests before review can proceed. If tests are failing after implementation changes, verify that tests were updated to match the new behavior (not just the old behavior).',
                 });
                 verificationContext += `\n## Test Results ❌\nTest command \`${config.testCommand}\` FAILED:\n\`\`\`\n${testOutput}${truncationNote}\n\`\`\`\n`;
             }