ai-foreman 1.7.22 → 1.7.23

package/dist/ticketPlanning.d.ts

@@ -64,11 +64,15 @@ export interface TicketPlanningContext {
     }>;
     existingNext: string[];
 }
+/** The tracker facts needed to validate a proposal before it is approved. */
+export interface TicketPlanValidationContext {
+    futureWorkIds?: Iterable<number>;
+}
 export declare function readTicketPlanningContext(projectDir: string): TicketPlanningContext;
 export declare function ticketPlanningFingerprint(projectDir: string): PlanningFingerprint[];
 export declare function planningFingerprintChanges(projectDir: string, expected: PlanningFingerprint[]): string[];
-export declare function extractTicketPlanProposal(output: string, existingTickets?: TicketDef[]): TicketPlanProposal;
-export declare function validateTicketPlanProposal(value: unknown, existingTickets?: TicketDef[]): string[];
+export declare function extractTicketPlanProposal(output: string, existingTickets?: TicketDef[], context?: TicketPlanValidationContext): TicketPlanProposal;
+export declare function validateTicketPlanProposal(value: unknown, existingTickets?: TicketDef[], context?: TicketPlanValidationContext): string[];
 export interface ApplyTicketPlanOptions {
     expectedFingerprint: PlanningFingerprint[];
     docsRoot: string;

package/dist/ticketPlanning.js

@@ -12,6 +12,9 @@ import { normalizeDeliveryConfig, validateDeliveryConfig } from "./tickets/deliv
 import { loadTicketSetupConfig, mergeTicketSetup, saveTicketSetupConfig } from "./tickets/setupConfig.js";
 export const PROPOSAL_START = "RAFI_PROPOSAL_START";
 export const PROPOSAL_END = "RAFI_PROPOSAL_END";
+const TICKET_STATUSES = new Set([
+    "planned", "next", "in_progress", "blocked", "done", "canceled", "obsolete",
+]);
 export function readTicketPlanningContext(projectDir) {
     const config = loadTicketsConfig(projectDir);
     const paths = resolveTicketPaths(config, projectDir);
@@ -41,7 +44,7 @@ export function ticketPlanningFingerprint(projectDir) {
 export function planningFingerprintChanges(projectDir, expected) {
     return expected.filter((item) => fileHash(join(projectDir, item.path)) !== item.sha256).map((item) => item.path);
 }
-export function extractTicketPlanProposal(output, existingTickets = []) {
+export function extractTicketPlanProposal(output, existingTickets = [], context = {}) {
     const start = output.lastIndexOf(PROPOSAL_START);
     const end = output.lastIndexOf(PROPOSAL_END);
     if (start < 0 || end <= start)
@@ -54,12 +57,12 @@ export function extractTicketPlanProposal(output, existingTickets = []) {
     catch (err) {
         throw new Error(`planner proposal is not valid JSON: ${err instanceof Error ? err.message : String(err)}`);
     }
-    const issues = validateTicketPlanProposal(parsed, existingTickets);
+    const issues = validateTicketPlanProposal(parsed, existingTickets, context);
     if (issues.length)
         throw new Error(`invalid planner proposal:\n${issues.map((issue) => `- ${issue}`).join("\n")}`);
     return parsed;
 }
-export function validateTicketPlanProposal(value, existingTickets = []) {
+export function validateTicketPlanProposal(value, existingTickets = [], context = {}) {
     const issues = [];
     if (!value || typeof value !== "object" || Array.isArray(value))
         return ["proposal must be an object"];
@@ -109,9 +112,26 @@ export function validateTicketPlanProposal(value, existingTickets = []) {
             if (!ids.has(id))
                 issues.push(`supersession references unknown ticket ${id}`);
     }
-    for (const change of p.state_changes)
-        if (!ids.has(change.id) || !change.reason?.trim())
-            issues.push(`invalid state change for ${change.id}`);
+    for (const change of p.state_changes) {
+        if (!change || typeof change !== "object" || !ids.has(change.id) || !change.reason?.trim()) {
+            issues.push(`invalid state change for ${String(change && typeof change === "object" ? change.id : undefined)}`);
+            continue;
+        }
+        if (!TICKET_STATUSES.has(change.status))
+            issues.push(`state change for ${change.id} has invalid status ${String(change.status)}`);
+    }
+    const futureWorkIds = context.futureWorkIds ? new Set(context.futureWorkIds) : undefined;
+    for (const disposition of p.future_work) {
+        if (!disposition || typeof disposition !== "object" || !Number.isInteger(disposition.id)) {
+            issues.push(`future work disposition has invalid id ${String(disposition && typeof disposition === "object" ? disposition.id : undefined)}`);
+            continue;
+        }
+        if (!["accepted", "rejected", "merged", "queued"].includes(disposition.disposition)) {
+            issues.push(`future work item ${disposition.id} has invalid disposition ${String(disposition.disposition)}`);
+        }
+        if (futureWorkIds && !futureWorkIds.has(disposition.id))
+            issues.push(`future work item ${disposition.id} does not exist`);
+    }
     for (const item of p.source_reconciliation) {
         if (!item.source?.trim() || !item.item?.trim())
             issues.push("source reconciliation needs source and item");
@@ -151,7 +171,8 @@ export function applyApprovedTicketPlan(projectDir, proposal, opts) {
     const existing = loadTickets(paths.tickets);
     if (existing.length > 0 && !existsSync(paths.stateDb))
         throw new Error("tickets exist but the ignored ticket-state database is missing; restore it before planning so completed work is not treated as new");
-    const proposalIssues = validateTicketPlanProposal(proposal, existing);
+    const currentContext = readTicketPlanningContext(root);
+    const proposalIssues = validateTicketPlanProposal(proposal, existing, { futureWorkIds: currentContext.futureWork.flatMap((item) => typeof item.id === "number" ? [item.id] : []) });
     if (proposalIssues.length)
         throw new Error(`approved proposal is invalid:\n${proposalIssues.map((issue) => `- ${issue}`).join("\n")}`);
     const lockPath = join(root, ".tickets", "planning.lock");

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "ai-foreman",
-  "version": "1.7.22",
+  "version": "1.7.23",
   "description": "An orchestrator that keeps Codex CLI / Claude Code builders moving through their step list unattended. Part of Rafi.",
   "license": "Apache-2.0",
   "type": "module",