ai-engineering-loop 1.0.18 → 1.0.21
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/.agents/workflows/ai-engineering-loop.md +2 -2
- package/.claude/skills/ai-engineering-loop/SKILL.md +3 -3
- package/.gemini/skills/ai-engineering-loop/SKILL.md +3 -3
- package/.grok/skills/ai-engineering-loop/SKILL.md +3 -3
- package/README.md +2 -2
- package/adapters/dot/README.md +12 -8
- package/adapters/dot/gitlab.md +29 -5
- package/adapters/dot/multi-branch.md +47 -68
- package/adapters/dot/skills/dot-dev-workflow/SKILL.md +6 -8
- package/adapters/generate-workflow/SKILL.md +9 -2
- package/adapters/github/pull-request.md +15 -0
- package/adapters/gitlab/merge-request.md +15 -0
- package/adapters/standard/README.md +1 -0
- package/bin/ai-engineering-loop.js +2 -2
- package/core/repo-config-schema.md +1 -1
- package/lib/generate-workflow.js +2 -1
- package/lib/intern-catalog.js +53 -0
- package/package.json +1 -1
- package/templates/repo-config/workflow.md +1 -1
- package/tests/dot-branch-policy.test.js +65 -0
- package/tests/generate-workflow.test.js +3 -2
- package/tests/intern-catalog.test.js +72 -0
- package/tests/qa-delivery-template.test.js +90 -0
- package/tests/skill-host-compat.test.js +5 -1
|
@@ -7,7 +7,7 @@ Follow `policies/review-budget.md`. Parent is Maker plus orchestrator. Do not us
|
|
|
7
7
|
|
|
8
8
|
Compact map (not a second OS): Specify (stages 0-1), Make (stages 2-4), Review (stages 5-7), Deliver (stage 8). Keep the 8-stage numbers. Do not skip Goal Contract, verification, Devil's Advocate, or Judge.
|
|
9
9
|
|
|
10
|
-
Stage 1: if the user asks for ideas, list a short menu and wait; do not implement. Grill if the task is ambiguous (`core/grill-policy.md`), then freeze the Goal Contract file. Chat agreement is not freeze. If the user prompt has no numbered AC, draft `.ai-engineering-loop/tasks/goal-contract.md` with a failure table, show it, wait for freeze. Do not start Maker. On business-logic change, and always on `adapter_type: dot`, grill includes blast radius: lifecycle sketch, four pillars (state, sibling, approval, queues), ASCII picture. Load `task-impact-inquiry` if present. Do not run a second interview. Passing unit tests are not isolation proof. Use `.ai-engineering-loop/glossary.md`. Name test seams. AC is a failure table (happy, empty/omit, boundary, sibling, error). One red test per AC row. Do not freeze sunny-path-only. Stages 2-4: Read `maker_intern` from workflow.md (missing or none = parent is Maker).
|
|
10
|
+
Stage 1: if the user asks for ideas, list a short menu and wait; do not implement. Grill if the task is ambiguous (`core/grill-policy.md`), then freeze the Goal Contract file. Chat agreement is not freeze. If the user prompt has no numbered AC, draft `.ai-engineering-loop/tasks/goal-contract.md` with a failure table, show it, wait for freeze. Do not start Maker. On business-logic change, and always on `adapter_type: dot`, grill includes blast radius: lifecycle sketch, four pillars (state, sibling, approval, queues), ASCII picture. Load `task-impact-inquiry` if present. Do not run a second interview. Passing unit tests are not isolation proof. Use `.ai-engineering-loop/glossary.md`. Name test seams. AC is a failure table (happy, empty/omit, boundary, sibling, error). One red test per AC row. Do not freeze sunny-path-only. Stages 2-4: Read `maker_intern` from workflow.md (missing or none = parent is Maker). Do not type a model name. If intern is set, confirm it came from this host's list (`/models` if that command exists). If the list command is missing or the id is not on it, parent is Maker; say intern INVOCATION_UNAVAILABLE. Intern cannot skip verification, Devil's Advocate, or Judge. Maker: TDD at those seams (`policies/tdd-policy.md`): one red test per AC row. Bugs: red repro first (`core/root-cause-analysis.md`). Mid-loop stop: `core/handoff-policy.md`.
|
|
11
11
|
|
|
12
12
|
If `invoke_subagent` (or Task) exists, spawn `devil-advocate` then `judge` as siblings. Wait for each child. Do not run them in the background. Use `general-purpose` only if the named type is rejected.
|
|
13
13
|
|
|
@@ -17,4 +17,4 @@ If `invoke_subagent` (or Task) exists, spawn `devil-advocate` then `judge` as si
|
|
|
17
17
|
|
|
18
18
|
If no subagent tool exists, run the same budgets in this session as CONTEXT_ISOLATION_ONLY. Do not claim independent agent execution.
|
|
19
19
|
|
|
20
|
-
Init/status/refresh/sync-hosts/generate-adapter/generate-workflow: `npx ai-engineering-loop <command>`. generate-workflow grills Q1-Q6. Stage 0: `npx ai-engineering-loop sync-hosts` then `npx ai-engineering-loop status`. Read `.ai-engineering-loop/glossary.md`. Read `.ai-engineering-loop/lessons.md` and `.ai-engineering-loop/workflow.md` if they exist. Follow workflow.md hooks (`before_grill`, `after_freeze`, `after_pass`). Do not skip Goal Contract, verification, Devil's Advocate, or Judge even if workflow.md asks. If workflow.md is missing, run the default 8-stage loop (no extra hooks). If sync-hosts copied files, tell the user a new session is needed for updated skill text; keep going with this session. After Judge PASS: run the `after_pass` hook if it is not `none`. Stage 8: load `adapters/<adapter_type>/`. If adapter.md is missing, run `generate-adapter` (grill). Do not invent a company pipeline. Confirmed process lessons go to `lessons.md`, not a chat dump.
|
|
20
|
+
Init/status/refresh/sync-hosts/generate-adapter/generate-workflow: `npx ai-engineering-loop <command>`. generate-workflow grills Q1-Q6. Q6 Maker intern: pick from the host catalog (`grok models` or `/models` if that command exists); do not type a model name. Stage 0: `npx ai-engineering-loop sync-hosts` then `npx ai-engineering-loop status`. Read `.ai-engineering-loop/glossary.md`. Read `.ai-engineering-loop/lessons.md` and `.ai-engineering-loop/workflow.md` if they exist. Follow workflow.md hooks (`before_grill`, `after_freeze`, `after_pass`). Do not skip Goal Contract, verification, Devil's Advocate, or Judge even if workflow.md asks. If workflow.md is missing, run the default 8-stage loop (no extra hooks). If sync-hosts copied files, tell the user a new session is needed for updated skill text; keep going with this session. After Judge PASS: run the `after_pass` hook if it is not `none`. Stage 8: load `adapters/<adapter_type>/`. If adapter.md is missing, run `generate-adapter` (grill). Do not invent a company pipeline. PR/MR body must include `Steps to Reproduce & Testing (QA)` from the adapter (reproduce + how to test). On a bugfix, do not leave those placeholders empty. Confirmed process lessons go to `lessons.md`, not a chat dump.
|
|
@@ -26,7 +26,7 @@ Claude Code talks to strict proxies (including Kiro). Follow this exactly:
|
|
|
26
26
|
|
|
27
27
|
- `init` / `status` / `refresh` / `sync-hosts` / `generate-adapter` / `generate-workflow`: run `npx ai-engineering-loop <command>` in the repo. Do not commit unless asked.
|
|
28
28
|
- `generate-adapter`: load skill `generate-adapter` if present. Grill Q1-Q5. Then write `.ai-engineering-loop/adapter.md`. Do not start Maker.
|
|
29
|
-
- `generate-workflow`: load skill `generate-workflow` if present. Grill Q1-Q6. Then write `.ai-engineering-loop/workflow.md` and empty `lessons.md` if missing. Do not start Maker.
|
|
29
|
+
- `generate-workflow`: load skill `generate-workflow` if present. Grill Q1-Q6. Q6 Maker intern: if `/models` exists in this session, use it and show numbered options; else only `none`. Do not type a model name. Then write `.ai-engineering-loop/workflow.md` and empty `lessons.md` if missing. Do not start Maker.
|
|
30
30
|
- Any other argument: full loop for that task.
|
|
31
31
|
|
|
32
32
|
## Loop
|
|
@@ -37,7 +37,7 @@ Parent session is Maker plus orchestrator. Spawn Devil's Advocate and Judge as *
|
|
|
37
37
|
|
|
38
38
|
1. Stage 0: `npx ai-engineering-loop sync-hosts` then `npx ai-engineering-loop status` (init or refresh if missing or stale). Read `.ai-engineering-loop/glossary.md`. Read `.ai-engineering-loop/lessons.md` and `.ai-engineering-loop/workflow.md` if they exist. Follow workflow.md hooks (`before_grill`, `after_freeze`, `after_pass`). Do not skip Goal Contract, verification, Devil's Advocate, or Judge even if workflow.md asks. If workflow.md is missing, run the default 8-stage loop (no extra hooks). If sync-hosts copied files, tell the user a new session is needed for updated skill text; keep going with this session.
|
|
39
39
|
2. Stage 1: Goal Contract (`core/goal-contract.md`). If the user asks for ideas, list a short menu and wait; do not implement. If the task is ambiguous and the user can answer, grill first (`core/grill-policy.md`): design tree, recommended answers, do not ask look-up facts. Skip grill if the contract is already frozen or the user waived it. On business-logic change, and always on `adapter_type: dot`, grill includes blast radius: lifecycle sketch, four pillars (state, sibling, approval, queues), ASCII picture. Load `task-impact-inquiry` if present. Do not run a second interview. Passing unit tests are not isolation proof. Chat agreement is not freeze: every user-visible decision must be a numbered AC in the Goal Contract file. Freeze before any production edit. Name test seams. Use glossary terms. AC is a failure table (happy, empty/omit, boundary, sibling, error). One red test per AC row. Do not freeze sunny-path-only. If the user prompt has no numbered AC, draft `.ai-engineering-loop/tasks/goal-contract.md` with a failure table, show it, wait for freeze. Do not start Maker.
|
|
40
|
-
3. Stages 2-4: Read `maker_intern` from workflow.md (missing or none = parent is Maker).
|
|
40
|
+
3. Stages 2-4: Read `maker_intern` from workflow.md (missing or none = parent is Maker). Do not type a model name. If intern is set, confirm it came from this host's list (`/models` if that command exists). If the list command is missing or the id is not on it, parent is Maker; say intern INVOCATION_UNAVAILABLE. Do not add a model key or HTTP client. Intern cannot skip verification, Devil's Advocate, or Judge. Bugs: red repro first (`core/root-cause-analysis.md`). Features: TDD at named seams (`policies/tdd-policy.md`): one red test per AC row. Surgical diff.
|
|
41
41
|
4. Stage 5: run commands from `.ai-engineering-loop/verification.md`. Keep command, exit code, stdout, test counts. Vague "seems green" is invalid. Write `.ai-engineering-loop/tasks/claimed-vs-reality.md` (AC, Claimed, Reality from command log). Do not spawn Devil's Advocate if the file is missing or any Claimed row lacks Reality.
|
|
42
42
|
5. Write artifacts, then spawn. Before Devil's Advocate:
|
|
43
43
|
- Write `git diff` to a file (for example `.ai-engineering-loop/tasks/current.diff`).
|
|
@@ -48,7 +48,7 @@ Parent session is Maker plus orchestrator. Spawn Devil's Advocate and Judge as *
|
|
|
48
48
|
6. Stage 6: Task `subagent_type: devil-advocate`. Use `general-purpose` only if that type is rejected. If the Task schema includes `run_in_background`, set it false. Then wait for Task to return. Do not start Judge or more Maker work until the Finding Ledger is back. Prompt: diff file path, name-only list, Goal Contract path, verification log path, conventions.md path, and "at most 8 tool calls; read the diff file; skip css and generated files". Report Spec and Standards axes separately.
|
|
49
49
|
7. Stage 7: Task `subagent_type: judge` the same way (wait, no background). Use `general-purpose` only if `judge` is rejected. Prompt: Goal Contract path, verification evidence path, Finding Ledger, and "at most 4 tool calls; ledger and contract only; skip css; do not re-review the whole diff".
|
|
50
50
|
8. ITERATE with iteration under 3: fix in the parent, re-verify, spawn a **new** Devil's Advocate (do not resume the previous child).
|
|
51
|
-
9. After Judge PASS: run the `after_pass` hook from workflow.md if it is not `none`. Then Stage 8: delivery from `.ai-engineering-loop/adapter.md`. Load shipped spec `adapters/<adapter_type>/` (`standard`, `github`, `gitlab`, `dot`). If adapter.md is missing or the type is unknown, run `generate-adapter` (grill). Do not invent a company pipeline. When the user confirms a process lesson, append one row to `lessons.md` (not a chat dump). Terms go to glossary.md.
|
|
51
|
+
9. After Judge PASS: run the `after_pass` hook from workflow.md if it is not `none`. Then Stage 8: delivery from `.ai-engineering-loop/adapter.md`. Load shipped spec `adapters/<adapter_type>/` (`standard`, `github`, `gitlab`, `dot`). If adapter.md is missing or the type is unknown, run `generate-adapter` (grill). Do not invent a company pipeline. PR/MR body must include `Steps to Reproduce & Testing (QA)` from the adapter (reproduce + how to test). On a bugfix, do not leave those placeholders empty. When the user confirms a process lesson, append one row to `lessons.md` (not a chat dump). Terms go to glossary.md.
|
|
52
52
|
|
|
53
53
|
## Report header
|
|
54
54
|
|
|
@@ -21,7 +21,7 @@ Canonical mode ids: `TRUE_INDEPENDENT_AGENT`, `ISOLATED_AGENT_INSTANCE`, `FRESH_
|
|
|
21
21
|
|
|
22
22
|
- `init` / `status` / `refresh` / `sync-hosts` / `generate-adapter` / `generate-workflow`: run `npx ai-engineering-loop <command>` in the repo. Do not commit unless asked.
|
|
23
23
|
- `generate-adapter`: load skill `generate-adapter` if present. Grill Q1-Q5. Then write `.ai-engineering-loop/adapter.md`. Do not start Maker.
|
|
24
|
-
- `generate-workflow`: load skill `generate-workflow` if present. Grill Q1-Q6. Then write `.ai-engineering-loop/workflow.md` and empty `lessons.md` if missing. Do not start Maker.
|
|
24
|
+
- `generate-workflow`: load skill `generate-workflow` if present. Grill Q1-Q6. Q6 Maker intern: if `/models` exists in this session, use it and show numbered options; else only `none`. Do not type a model name. Then write `.ai-engineering-loop/workflow.md` and empty `lessons.md` if missing. Do not start Maker.
|
|
25
25
|
- Any other argument: full loop for that task.
|
|
26
26
|
|
|
27
27
|
## Loop
|
|
@@ -30,7 +30,7 @@ Compact map (not a second OS): Specify (stages 0-1), Make (stages 2-4), Review (
|
|
|
30
30
|
|
|
31
31
|
1. Stage 0: `npx ai-engineering-loop sync-hosts` then `npx ai-engineering-loop status` (init or refresh if missing or stale). Read `.ai-engineering-loop/glossary.md`. Read `.ai-engineering-loop/lessons.md` and `.ai-engineering-loop/workflow.md` if they exist. Follow workflow.md hooks (`before_grill`, `after_freeze`, `after_pass`). Do not skip Goal Contract, verification, Devil's Advocate, or Judge even if workflow.md asks. If workflow.md is missing, run the default 8-stage loop (no extra hooks). If sync-hosts copied files, tell the user a new session is needed for updated skill text; keep going with this session.
|
|
32
32
|
2. Stage 1: Goal Contract (`core/goal-contract.md`). If the user asks for ideas, list a short menu and wait; do not implement. If the task is ambiguous and the user can answer, grill first (`core/grill-policy.md`): design tree, recommended answers, do not ask look-up facts. Skip grill if the contract is already frozen or the user waived it. On business-logic change, and always on `adapter_type: dot`, grill includes blast radius: lifecycle sketch, four pillars (state, sibling, approval, queues), ASCII picture. Load `task-impact-inquiry` if present. Do not run a second interview. Passing unit tests are not isolation proof. Chat agreement is not freeze: every user-visible decision must be a numbered AC in the Goal Contract file. Freeze before any production edit. Name test seams. Use glossary terms. AC is a failure table (happy, empty/omit, boundary, sibling, error). One red test per AC row. Do not freeze sunny-path-only. If the user prompt has no numbered AC, draft `.ai-engineering-loop/tasks/goal-contract.md` with a failure table, show it, wait for freeze. Do not start Maker.
|
|
33
|
-
3. Stages 2-4: Read `maker_intern` from workflow.md (missing or none = parent is Maker).
|
|
33
|
+
3. Stages 2-4: Read `maker_intern` from workflow.md (missing or none = parent is Maker). Do not type a model name. If intern is set, confirm it came from this host's list (`/models` if that command exists). If the list command is missing or the id is not on it, parent is Maker; say intern INVOCATION_UNAVAILABLE. Do not add HTTP clients or API keys. Intern cannot skip verification, Devil's Advocate, or Judge. After intern returns, parent runs Stage 5. Bugs: red repro first (`core/root-cause-analysis.md`). Features: TDD at named seams (`policies/tdd-policy.md`): one red test per AC row. Surgical diff.
|
|
34
34
|
4. Stage 5: run commands from `.ai-engineering-loop/verification.md`. Keep command, exit code, stdout, test counts. Vague "seems green" is invalid. Write `.ai-engineering-loop/tasks/claimed-vs-reality.md` (AC, Claimed, Reality from command log). Do not spawn Devil's Advocate if the file is missing or any Claimed row lacks Reality.
|
|
35
35
|
5. Write artifacts, then spawn. Before Devil's Advocate:
|
|
36
36
|
- Write `git diff` to a file (for example `.ai-engineering-loop/tasks/current.diff`).
|
|
@@ -41,7 +41,7 @@ Compact map (not a second OS): Specify (stages 0-1), Make (stages 2-4), Review (
|
|
|
41
41
|
6. Stage 6: spawn `devil-advocate`. Wait. Prompt: diff file path, name-only list, Goal Contract path, verification log path, conventions.md path, and "at most 8 tool calls; read the diff file; skip css and generated files". Report Spec and Standards axes separately.
|
|
42
42
|
7. Stage 7: spawn `judge` the same way (wait, no background). Prompt: Goal Contract path, verification evidence path, Finding Ledger, and "at most 4 tool calls; ledger and contract only; skip css; do not re-review the whole diff".
|
|
43
43
|
8. ITERATE with iteration under 3: fix in the parent, re-verify, spawn a **new** Devil's Advocate.
|
|
44
|
-
9. After Judge PASS: run the `after_pass` hook from workflow.md if it is not `none`. Then Stage 8: delivery from `.ai-engineering-loop/adapter.md`. Load shipped spec `adapters/<adapter_type>/` (`standard`, `github`, `gitlab`, `dot`). If adapter.md is missing or the type is unknown, run `generate-adapter` (grill). Do not invent a company pipeline. When the user confirms a process lesson, append one row to `lessons.md` (not a chat dump). Terms go to glossary.md.
|
|
44
|
+
9. After Judge PASS: run the `after_pass` hook from workflow.md if it is not `none`. Then Stage 8: delivery from `.ai-engineering-loop/adapter.md`. Load shipped spec `adapters/<adapter_type>/` (`standard`, `github`, `gitlab`, `dot`). If adapter.md is missing or the type is unknown, run `generate-adapter` (grill). Do not invent a company pipeline. PR/MR body must include `Steps to Reproduce & Testing (QA)` from the adapter (reproduce + how to test). On a bugfix, do not leave those placeholders empty. When the user confirms a process lesson, append one row to `lessons.md` (not a chat dump). Terms go to glossary.md.
|
|
45
45
|
|
|
46
46
|
## Report header
|
|
47
47
|
|
|
@@ -40,7 +40,7 @@ Optional fallback if `devil-advocate` / `judge` types are not registered: `subag
|
|
|
40
40
|
|
|
41
41
|
### `/ai-engineering-loop init|status|refresh|sync-hosts|generate-adapter|generate-workflow`
|
|
42
42
|
|
|
43
|
-
Run `npx ai-engineering-loop <command>` in the target repo. Do not commit unless the user asks. `sync-hosts` copies this package's skills/agents/commands into `~/.claude`, `~/.grok`, `~/.gemini`, and `~/.agents` for hosts that already exist. `generate-adapter`: load skill `generate-adapter` if present. Grill Q1-Q5. Then write `.ai-engineering-loop/adapter.md`. Do not start Maker. `generate-workflow`: load skill `generate-workflow` if present. Grill Q1-Q6. Then write `.ai-engineering-loop/workflow.md` and empty `lessons.md` if missing. Do not start Maker.
|
|
43
|
+
Run `npx ai-engineering-loop <command>` in the target repo. Do not commit unless the user asks. `sync-hosts` copies this package's skills/agents/commands into `~/.claude`, `~/.grok`, `~/.gemini`, and `~/.agents` for hosts that already exist. `generate-adapter`: load skill `generate-adapter` if present. Grill Q1-Q5. Then write `.ai-engineering-loop/adapter.md`. Do not start Maker. `generate-workflow`: load skill `generate-workflow` if present. Grill Q1-Q6. Q6 Maker intern: run `grok models` (or `/models` if that slash command exists here), drop grok-imagine-* and video, show numbered options plus none. Do not type a model name. Then write `.ai-engineering-loop/workflow.md` and empty `lessons.md` if missing. Do not start Maker.
|
|
44
44
|
|
|
45
45
|
### `/ai-engineering-loop [task]`
|
|
46
46
|
|
|
@@ -48,7 +48,7 @@ Compact map (not a second OS): Specify (stages 0-1), Make (stages 2-4), Review (
|
|
|
48
48
|
|
|
49
49
|
1. Stage 0: `npx ai-engineering-loop sync-hosts` then `npx ai-engineering-loop status` (init/refresh if missing or stale). Read `.ai-engineering-loop/glossary.md`. Read `.ai-engineering-loop/lessons.md` and `.ai-engineering-loop/workflow.md` if they exist. Follow workflow.md hooks (`before_grill`, `after_freeze`, `after_pass`). Do not skip Goal Contract, verification, Devil's Advocate, or Judge even if workflow.md asks. If workflow.md is missing, run the default 8-stage loop (no extra hooks). If sync-hosts copied files, tell the user a new session is needed for updated skill text; keep going with this session.
|
|
50
50
|
2. Stage 1: Goal Contract (`core/goal-contract.md`). If the user asks for ideas, list a short menu and wait; do not implement. If the task is ambiguous and the user can answer, grill first (`core/grill-policy.md`): design tree, recommended answers, do not ask look-up facts. Skip grill if the contract is already frozen or the user waived it. On business-logic change, and always on `adapter_type: dot`, grill includes blast radius: lifecycle sketch, four pillars (state, sibling, approval, queues), ASCII picture. Load `task-impact-inquiry` if present. Do not run a second interview. Passing unit tests are not isolation proof. Chat agreement is not freeze: every user-visible decision must be a numbered AC in the Goal Contract file. Freeze before any production edit. Name test seams. Use glossary terms. AC is a failure table (happy, empty/omit, boundary, sibling, error). One red test per AC row. Do not freeze sunny-path-only. If the user prompt has no numbered AC, draft `.ai-engineering-loop/tasks/goal-contract.md` with a failure table, show it, wait for freeze. Do not start Maker.
|
|
51
|
-
3. Stages 2–4: Read `maker_intern` from workflow.md (missing or none = parent is Maker). If a label is set, write `.ai-engineering-loop/tasks/maker-brief.md` and spawn that intern as a sibling (`background: false`, wait). Pass a model key only if that key exists on the spawn schema. Do not invent keys, HTTP clients, or
|
|
51
|
+
3. Stages 2–4: Read `maker_intern` from workflow.md (missing or none = parent is Maker). Do not type a model name. If a label is set, run `grok models` and confirm the id is in the coding list (not grok-imagine-*). If missing, parent is Maker; say intern INVOCATION_UNAVAILABLE. Otherwise write `.ai-engineering-loop/tasks/maker-brief.md` and spawn that intern as a sibling (`background: false`, wait). Pass a model key only if that key exists on the spawn schema. Do not invent keys, HTTP clients, or custom endpoints. Intern must not spawn DA or Judge (depth 1). After intern returns, parent runs Stage 5 then DA/Judge. Intern cannot skip verification, Devil's Advocate, or Judge. Bugs: red repro first (`core/root-cause-analysis.md`). Features: TDD at named seams (`policies/tdd-policy.md`): one red test per AC row. Surgical diff.
|
|
52
52
|
4. Stage 5: run verification from `.ai-engineering-loop/verification.md`. Keep command, exit code, stdout, test counts. Vague "seems green" is invalid. Write `.ai-engineering-loop/tasks/claimed-vs-reality.md` (AC, Claimed, Reality from command log). Do not spawn Devil's Advocate if the file is missing or any Claimed row lacks Reality.
|
|
53
53
|
5. Write artifacts to disk so children do not need parent chat:
|
|
54
54
|
- Goal Contract path
|
|
@@ -59,7 +59,7 @@ Compact map (not a second OS): Specify (stages 0-1), Make (stages 2-4), Review (
|
|
|
59
59
|
6. Stage 6: `spawn_subagent` Devil's Advocate. `background: false`. `capability_mode: "execute"`. Do **not** pass `resume_from`. Wait for the child. Prompt: diff file path, name-only file list, Goal Contract path, verification log path, conventions.md path, plus "at most 8 tool calls; read the diff file; skip css and generated files". Report Spec and Standards axes separately.
|
|
60
60
|
7. Stage 7: `spawn_subagent` Judge the same way (`background: false`, wait). Use `general-purpose` only if `judge` is rejected. Prompt: Goal Contract path, verification evidence path, Finding Ledger, and "at most 4 tool calls; ledger and contract only; skip css; do not re-review the whole diff".
|
|
61
61
|
8. If Judge says `ITERATE` and iteration < 3, Maker fixes in the parent, re-verify, spawn a **fresh** DA (new spawn, no resume).
|
|
62
|
-
9. After Judge PASS: run the `after_pass` hook from workflow.md if it is not `none`. Then Stage 8: delivery from `.ai-engineering-loop/adapter.md`. Load shipped spec `adapters/<adapter_type>/` (`standard`, `github`, `gitlab`, `dot`). If adapter.md is missing or the type is unknown, run `generate-adapter` (grill). Do not invent a company pipeline. When the user confirms a process lesson, append one row to `lessons.md` (not a chat dump). Terms go to glossary.md.
|
|
62
|
+
9. After Judge PASS: run the `after_pass` hook from workflow.md if it is not `none`. Then Stage 8: delivery from `.ai-engineering-loop/adapter.md`. Load shipped spec `adapters/<adapter_type>/` (`standard`, `github`, `gitlab`, `dot`). If adapter.md is missing or the type is unknown, run `generate-adapter` (grill). Do not invent a company pipeline. PR/MR body must include `Steps to Reproduce & Testing (QA)` from the adapter (reproduce + how to test). On a bugfix, do not leave those placeholders empty. When the user confirms a process lesson, append one row to `lessons.md` (not a chat dump). Terms go to glossary.md.
|
|
63
63
|
|
|
64
64
|
After a proven Grok DA spawn, the report header must be:
|
|
65
65
|
|
package/README.md
CHANGED
|
@@ -6,7 +6,7 @@
|
|
|
6
6
|
[](https://opensource.org/licenses/MIT)
|
|
7
7
|
[](https://github.com/egagofur/ai-engineering-loop/pulls)
|
|
8
8
|
[](https://github.com/egagofur/ai-engineering-loop)
|
|
9
|
-
[](https://github.com/egagofur/ai-engineering-loop/releases)
|
|
10
10
|
|
|
11
11
|
**A Reusable, Framework-Agnostic AI Engineering Operating System for Autonomous Coding Agents**
|
|
12
12
|
|
|
@@ -67,7 +67,7 @@ The 8-stage loop stays one OS. These techniques sit **inside** existing stages (
|
|
|
67
67
|
| 1 | Grill until the design-tree frontier is empty, then freeze the Goal Contract. Idea requests: menu, wait, then grill the pick. Chat `setuju` is not freeze; user-visible decisions must be numbered AC in the contract file. AC is a **failure table** (happy, empty/omit, boundary, sibling, error), not sunny path only. **Sloppy prompt** (no numbered AC): draft the Goal Contract file, show it, wait for freeze — do not Maker. Business-logic change: **blast radius** (lifecycle sketch, four pillars, ASCII picture) via `task-impact-inquiry` inside grill — not a second loop. Passing unit tests are not isolation proof. | `core/grill-policy.md` |
|
|
68
68
|
| 1 | Ubiquitous language in `.ai-engineering-loop/glossary.md`; load-bearing choices in `.ai-engineering-loop/adrs/` | `core/repo-config-schema.md` |
|
|
69
69
|
| 2 | Bugs: red repro → minimise → hypothesise → instrument → fix | `core/root-cause-analysis.md` |
|
|
70
|
-
| 4 | Optional **Maker intern**:
|
|
70
|
+
| 4 | Optional **Maker intern**: overlay `maker_intern`. Default `none`. Pick from the host catalog (`grok models` or `/models` if that command exists; numbered options). Do not type a model name. No custom endpoint. Imagine/video models are not intern picks. Unknown id → parent Maker (`INVOCATION_UNAVAILABLE`). Devil's Advocate and Judge stay on the parent. | `.ai-engineering-loop/workflow.md` |
|
|
71
71
|
| 4–5 | Red-green at named **seams**; failure table (not happy path only); coverage is a map; no grep/tautology | `policies/tdd-policy.md` |
|
|
72
72
|
| 5 | **Claimed vs Reality** table before DA. Missing file or empty Reality blocks Devil's Advocate. "Seems green" is not Reality. | `core/verification-loop.md` |
|
|
73
73
|
| 6–7 | Spec vs Standards reported separately. Standards BLOCKER/HIGH iterate only when `hardConvention` is true | `policies/finding-policy.md` |
|
package/adapters/dot/README.md
CHANGED
|
@@ -14,10 +14,12 @@ flowchart TD
|
|
|
14
14
|
|
|
15
15
|
subgraph DOTAdapter [DOT Delivery Pipeline]
|
|
16
16
|
PASS --> Issue[1. GitLab Issue Card via glab]
|
|
17
|
-
Issue --> BaseMR[2.
|
|
18
|
-
BaseMR -->
|
|
19
|
-
|
|
20
|
-
|
|
17
|
+
Issue --> BaseMR[2. One Merge Request via glab]
|
|
18
|
+
BaseMR --> AskPropagate{User named extra envs this turn?}
|
|
19
|
+
AskPropagate -->|No| CoreviewTriage[3. External @coreview-bot Review Triage]
|
|
20
|
+
AskPropagate -->|Yes| MultiBranch[Optional cherry-pick staging / develop]
|
|
21
|
+
MultiBranch --> CoreviewTriage
|
|
22
|
+
CoreviewTriage --> MattermostDispatch[4. Mattermost Markdown Notification via MCP]
|
|
21
23
|
end
|
|
22
24
|
```
|
|
23
25
|
|
|
@@ -31,13 +33,15 @@ The DOT adapter is organized into four dedicated specification modules:
|
|
|
31
33
|
- CLI automation with `glab`.
|
|
32
34
|
- Standardized issue card templates with actual vs expected tables and QA testing steps.
|
|
33
35
|
- Standardized MR descriptions linking issue IDs and change summaries.
|
|
34
|
-
2. **[
|
|
35
|
-
-
|
|
36
|
-
-
|
|
36
|
+
2. **[Topic branch and optional propagate (`multi-branch.md`)](multi-branch.md)**:
|
|
37
|
+
- Unrelated HEAD (`main` / `develop` / `staging` / other ticket): new `type/name` branch.
|
|
38
|
+
- Related `feat/…` or `fix/…`: stay. One MR. Do not open three MRs.
|
|
39
|
+
- Base: `origin/develop` when develop is in use (default branch is `develop`), including when HEAD is `main`. HEAD being `main` does not override an in-use `develop` default. `origin/main` only when develop is unused leftover (default branch is `main` / `master`). Do not force leftover develop.
|
|
40
|
+
- Cherry-pick extra envs only if the user named them this turn. Chat `setuju` is not propagate.
|
|
37
41
|
3. **[Coreview External Reviewer Triage (`coreview.md`)](coreview.md)**:
|
|
38
42
|
- Ingestion of `@coreview-bot` automated PR comments.
|
|
39
43
|
- Mandatory Phase 8 Triage reporting gate before Mattermost dispatch.
|
|
40
|
-
- Rigorous evaluation of bot suggestions into `VALID` (fix
|
|
44
|
+
- Rigorous evaluation of bot suggestions into `VALID` (fix on the same topic MR; do not cherry-pick unless the user named extra envs this turn) vs `HALU` (false positive pushback) using principles from `gitlab-mr-feedback` and `receiving-code-review`.
|
|
41
45
|
4. **[Mattermost Notifications (`mattermost.md`)](mattermost.md)**:
|
|
42
46
|
- Repository-to-channel resolution using persistent configuration.
|
|
43
47
|
- MCP `mattermost_send_message` dispatch with mandatory `from: "AI Agent"` attribution.
|
package/adapters/dot/gitlab.md
CHANGED
|
@@ -76,11 +76,20 @@ glab issue create \
|
|
|
76
76
|
- [x] [Component 2 modified]
|
|
77
77
|
- [x] [Unit tests added in path/to/test.ts]
|
|
78
78
|
|
|
79
|
-
## Testing
|
|
80
|
-
|
|
81
|
-
|
|
82
|
-
|
|
83
|
-
|
|
79
|
+
## Steps to Reproduce & Testing (QA)
|
|
80
|
+
### Pre-conditions
|
|
81
|
+
- <environment / data / permissions>
|
|
82
|
+
### Steps to Reproduce
|
|
83
|
+
1. <action>
|
|
84
|
+
2. <action that triggers the bug or the new path>
|
|
85
|
+
### How to Test
|
|
86
|
+
1. <same path after the fix, or the feature path>
|
|
87
|
+
2. <what QA should click / call / assert>
|
|
88
|
+
### Actual Result (before the fix / sebelum fix)
|
|
89
|
+
- <error / status / log — N/A on a pure feature>
|
|
90
|
+
### Expected Result (after the fix / setelah fix)
|
|
91
|
+
- <normal behaviour / status>
|
|
92
|
+
- <no error popup, no crash, no new error logs>
|
|
84
93
|
|
|
85
94
|
## Expectation
|
|
86
95
|
| Kondisi / Skenario | Logika Lama (Sebelum) | Logika Baru (Sesudah) |
|
|
@@ -120,6 +129,21 @@ glab mr create \
|
|
|
120
129
|
- <Concise point 2 explaining edge cases handled>
|
|
121
130
|
- <Concise point 3 mentioning unit test coverage>
|
|
122
131
|
|
|
132
|
+
## Steps to Reproduce & Testing (QA)
|
|
133
|
+
### Pre-conditions
|
|
134
|
+
- <environment / data / permissions>
|
|
135
|
+
### Steps to Reproduce
|
|
136
|
+
1. <action>
|
|
137
|
+
2. <action that triggers the bug or the new path>
|
|
138
|
+
### How to Test
|
|
139
|
+
1. <same path after the fix, or the feature path>
|
|
140
|
+
2. <what QA should click / call / assert>
|
|
141
|
+
### Actual Result (before the fix / sebelum fix)
|
|
142
|
+
- <error / status / log — N/A on a pure feature>
|
|
143
|
+
### Expected Result (after the fix / setelah fix)
|
|
144
|
+
- <normal behaviour / status>
|
|
145
|
+
- <no error popup, no crash, no new error logs>
|
|
146
|
+
|
|
123
147
|
## Screenshot / Video
|
|
124
148
|
<!-- Attach screenshots, terminal test logs, or UI captures if available -->
|
|
125
149
|
|
|
@@ -1,90 +1,69 @@
|
|
|
1
|
-
# DOT Adapter:
|
|
2
|
-
|
|
3
|
-
## 1.
|
|
4
|
-
|
|
5
|
-
|
|
6
|
-
|
|
7
|
-
|
|
8
|
-
|
|
9
|
-
|
|
10
|
-
|
|
11
|
-
|
|
12
|
-
|
|
13
|
-
|
|
14
|
-
|
|
15
|
-
|
|
16
|
-
|
|
17
|
-
|
|
18
|
-
|
|
19
|
-
|
|
20
|
-
|
|
21
|
-
|
|
22
|
-
|
|
23
|
-
|
|
24
|
-
|
|
25
|
-
|
|
26
|
-
|
|
27
|
-
|
|
28
|
-
|
|
1
|
+
# DOT Adapter: Topic branch, base, and optional propagate
|
|
2
|
+
|
|
3
|
+
## 1. Default: one topic branch, one MR
|
|
4
|
+
|
|
5
|
+
Do not open three MRs. Cherry-pick to `staging` or `develop` is opt-in (section 4).
|
|
6
|
+
|
|
7
|
+
### Related HEAD — stay
|
|
8
|
+
|
|
9
|
+
HEAD is related when the branch name is `feat/…` or `fix/…` (or the same ticket id) for **this** feature.
|
|
10
|
+
|
|
11
|
+
Stay on that branch. Do not create a new topic branch. Open **one MR** onto the branch it was cut from.
|
|
12
|
+
|
|
13
|
+
### Unrelated HEAD — new topic branch
|
|
14
|
+
|
|
15
|
+
HEAD is unrelated when it is `main`, `master`, `develop`, `staging`, or another ticket's branch.
|
|
16
|
+
|
|
17
|
+
Create a new `type/descriptive-name` branch from the live integration base (section 2). Then open **one MR** onto that base.
|
|
18
|
+
|
|
19
|
+
## 2. Pick the base
|
|
20
|
+
|
|
21
|
+
1. `git fetch origin`
|
|
22
|
+
2. Default branch: `git remote show origin` → `HEAD branch`.
|
|
23
|
+
3. Do not `git pull` into the current HEAD. Cut the topic branch from `origin/<base>` so local `main` / leftover `develop` stay untouched.
|
|
24
|
+
|
|
25
|
+
**`develop` is in use** only when the default branch is `develop`. Then always cut the new topic branch from `origin/develop`, even if HEAD is `main`, `staging`, or another ticket. HEAD being `main` does not override an in-use `develop` default:
|
|
26
|
+
|
|
27
|
+
```bash
|
|
28
|
+
git fetch origin
|
|
29
|
+
git checkout -b <type>/<descriptive-name> origin/develop
|
|
30
|
+
```
|
|
31
|
+
|
|
32
|
+
**`develop` is unused** (leftover) when the default branch is `main` / `master`, even if `origin/develop` exists and even if HEAD is `develop`. Do not force leftover develop:
|
|
33
|
+
|
|
34
|
+
```bash
|
|
35
|
+
git fetch origin
|
|
36
|
+
git checkout -b <type>/<descriptive-name> origin/main
|
|
29
37
|
```
|
|
30
38
|
|
|
31
|
-
|
|
32
|
-
|
|
33
|
-
3.
|
|
39
|
+
(`master` if that is the default.)
|
|
40
|
+
|
|
41
|
+
## 3. Environments (names only)
|
|
34
42
|
|
|
35
|
-
|
|
43
|
+
These exist on many DOT remotes. They are **not** automatic MR targets.
|
|
36
44
|
|
|
37
|
-
|
|
45
|
+
1. **`main` / `master`** — production (`[MR MAIN]` / `[MR PROD]`).
|
|
46
|
+
2. **`staging`** — QA (`[MR STAGING]`).
|
|
47
|
+
3. **`develop`** — integration (`[MR DEV]`).
|
|
38
48
|
|
|
39
|
-
|
|
49
|
+
## 4. Optional propagate (this turn only)
|
|
40
50
|
|
|
41
|
-
|
|
51
|
+
Do not cherry-pick to `staging` or `develop` unless the user named those branches **this turn** (`propagate`, `3 branch`, `staging dan develop`, `multi-branch`). Chat `setuju` is not propagate. `.ai-engineering-loop/adapter.md` cannot turn this on by itself.
|
|
42
52
|
|
|
43
|
-
|
|
53
|
+
When asked, for each named extra target:
|
|
44
54
|
|
|
45
55
|
```bash
|
|
46
|
-
# 1. Fetch latest changes from remote
|
|
47
56
|
git fetch origin <target-env>
|
|
48
|
-
|
|
49
|
-
# 2. Checkout a new dedicated branch tracking the remote environment
|
|
50
57
|
git checkout -b <branch-name>-<target-env> origin/<target-env>
|
|
51
|
-
|
|
52
|
-
# 3. Cherry-pick the verified fix commit
|
|
53
58
|
git cherry-pick <commit-hash>
|
|
54
|
-
|
|
55
|
-
# 4. Resolve any target-specific differences and verify tests pass
|
|
56
59
|
# commands from .ai-engineering-loop/verification.md
|
|
57
|
-
npx jest
|
|
58
|
-
npx tsc --noEmit
|
|
59
|
-
|
|
60
|
-
# 5. Push the branch to remote
|
|
61
60
|
git push -u origin <branch-name>-<target-env>
|
|
62
|
-
|
|
63
|
-
# 6. Create the environment-specific Merge Request via glab
|
|
64
61
|
glab mr create \
|
|
65
|
-
--repo <repo> \
|
|
66
62
|
--source-branch <branch-name>-<target-env> \
|
|
67
63
|
--target-branch <target-env> \
|
|
68
64
|
--title "<type>(<scope>): <short description>" \
|
|
69
65
|
--description "<MR Description Markdown>" \
|
|
70
|
-
--assignee <username> \
|
|
71
66
|
--yes
|
|
72
67
|
```
|
|
73
68
|
|
|
74
|
-
|
|
75
|
-
|
|
76
|
-
## 3. Conflict & Environment Discrepancy Handling
|
|
77
|
-
|
|
78
|
-
1. **Clean Cherry-Picks**:
|
|
79
|
-
Because the [generic AI Engineering Loop](../../README.md) enforces surgical, minimal diffs, cherry-picking should be clean in >95% of cases.
|
|
80
|
-
2. **Merge Conflicts**:
|
|
81
|
-
If a merge conflict occurs due to divergent code between `main` and `develop`:
|
|
82
|
-
- Resolve the conflict surgically preserving the fix semantics.
|
|
83
|
-
- Run the full test suite (`npx jest`) to prove correctness on the specific environment.
|
|
84
|
-
- Complete the cherry-pick:
|
|
85
|
-
```bash
|
|
86
|
-
git add <resolved-files>
|
|
87
|
-
git cherry-pick --continue
|
|
88
|
-
```
|
|
89
|
-
3. **Environment-Specific Tests**:
|
|
90
|
-
Always execute deterministic test suites (`npx jest`, `npx tsc --noEmit`) on each branch prior to pushing.
|
|
69
|
+
Conflicts: resolve surgically, re-run verification, `git cherry-pick --continue`.
|
|
@@ -1,6 +1,6 @@
|
|
|
1
1
|
---
|
|
2
2
|
name: dot-dev-workflow
|
|
3
|
-
description: DOT Stage 8 delivery after AI Engineering Loop Judge PASS. GitLab issue/MR,
|
|
3
|
+
description: DOT Stage 8 delivery after AI Engineering Loop Judge PASS. GitLab issue/MR, one topic-branch MR (extra env cherry-pick only if named this turn), Coreview triage, Mattermost. Not a substitute for ai-engineering-loop.
|
|
4
4
|
---
|
|
5
5
|
|
|
6
6
|
# DOT Delivery Workflow (Stage 8)
|
|
@@ -33,7 +33,7 @@ While AEL Maker runs, still enforce:
|
|
|
33
33
|
- `backend-development` for naming, queries, layering.
|
|
34
34
|
- `backend-safety-guardrails` on mutations, jobs, recalculation: never bypass BullMQ; scope by entity id not coarse date strings; never overwrite `APPROVED`/`REJECTED` without explicit force; BigInt as string across boundaries; container moves sync old and new parents.
|
|
35
35
|
- Tests: commands in `.ai-engineering-loop/verification.md` (fallback `npx jest && npx tsc --noEmit`).
|
|
36
|
-
-
|
|
36
|
+
- Topic branch: if HEAD is already `feat/…` or `fix/…` for this feature, stay on that branch. Do not create a new topic branch. If HEAD is unrelated (`main`, `master`, `develop`, `staging`, other ticket), `git fetch origin`, then `git checkout -b type/descriptive-name origin/develop` when develop is in use (default branch is `develop`). Do not `git pull` into the current HEAD. HEAD being `main` does not override an in-use `develop` default. If develop is unused leftover (default branch is `main` / `master`), `git checkout -b type/descriptive-name origin/main` even if HEAD is `develop`. Do not force leftover develop.
|
|
37
37
|
|
|
38
38
|
Print these six invariants before commit (N/A allowed only with one sentence citing the diff):
|
|
39
39
|
|
|
@@ -46,7 +46,7 @@ Print these six invariants before commit (N/A allowed only with one sentence cit
|
|
|
46
46
|
|
|
47
47
|
---
|
|
48
48
|
|
|
49
|
-
## Stage 8a —
|
|
49
|
+
## Stage 8a — Topic-branch MR and issue card (`glab`)
|
|
50
50
|
|
|
51
51
|
If the workspace has `adapters/dot/gitlab.md` and `adapters/dot/multi-branch.md`, follow those. Otherwise:
|
|
52
52
|
|
|
@@ -57,11 +57,9 @@ git add <modified-files>
|
|
|
57
57
|
git commit -m "<type>(<scope>): <summary>"
|
|
58
58
|
```
|
|
59
59
|
|
|
60
|
-
2. Create a GitLab issue if none is linked (`glab issue create` with module title, scope checkboxes,
|
|
60
|
+
2. Create a GitLab issue if none is linked (`glab issue create` with module title, scope checkboxes, `Steps to Reproduce & Testing (QA)` from `adapters/dot/gitlab.md`, expectation table, label `Ready to Test`). On a bugfix, do not leave those placeholders empty.
|
|
61
61
|
|
|
62
|
-
3.
|
|
63
|
-
|
|
64
|
-
4. Propagate to `staging` and `develop`: fetch, branch from origin, cherry-pick the commit, re-run verification, push, open MR per environment.
|
|
62
|
+
3. Open **one** MR (`glab mr create` onto the live integration base from the topic-branch rules above; description links the issue). Issue and MR descriptions must include `Steps to Reproduce & Testing (QA)` (reproduce + how to test). On a bugfix, do not leave those placeholders empty. Do not cherry-pick to `staging` or `develop` unless the user named those branches this turn. Chat `setuju` is not propagate. Do not open three MRs.
|
|
65
63
|
|
|
66
64
|
---
|
|
67
65
|
|
|
@@ -88,7 +86,7 @@ glab api "projects/:fullpath/merge_requests/<mr-id>/discussions"
|
|
|
88
86
|
glab api "projects/:fullpath/merge_requests/<mr-id>/discussions/<discussion_id>/notes" -X POST -F "body=<text>"
|
|
89
87
|
```
|
|
90
88
|
|
|
91
|
-
- VALID: fix surgically, re-verify, commit,
|
|
89
|
+
- VALID: fix surgically, re-verify, commit, push to the same topic MR, reply with commit hash. Do not cherry-pick to `staging` or `develop` unless the user named those branches this turn. Chat `setuju` is not propagate.
|
|
92
90
|
- HALU: do not change code; reply with file-cited technical pushback.
|
|
93
91
|
|
|
94
92
|
---
|
|
@@ -71,13 +71,18 @@ Recommended: keep AEL default
|
|
|
71
71
|
Q5 - Skip generate-adapter when adapter.md already exists: yes | no
|
|
72
72
|
Recommended: yes
|
|
73
73
|
|
|
74
|
-
Q6 - Maker intern:
|
|
74
|
+
Q6 - Maker intern: pick from the host catalog. Do not type a model name.
|
|
75
|
+
Look up models with this host's list command:
|
|
76
|
+
- Grok CLI: `grok models`
|
|
77
|
+
- Many agent CLIs (Codex and others): `/models` if that slash command exists in this session
|
|
78
|
+
Drop image/video/imagine ids. Show numbered options plus 0) none.
|
|
79
|
+
If no list command exists here: only 0) none.
|
|
75
80
|
Recommended: none
|
|
76
81
|
```
|
|
77
82
|
|
|
78
83
|
If they name a tool or step, write that name into the matching hook. Do not invent Figma/Jira/Slack unless they said so.
|
|
79
84
|
|
|
80
|
-
Q6
|
|
85
|
+
Q6 writes `maker_intern` from the numbered pick only. Do not type a model name. Do not use a custom endpoint. Do not paste API keys or URLs. Default none = parent is Maker.
|
|
81
86
|
|
|
82
87
|
### 3. Write
|
|
83
88
|
|
|
@@ -132,3 +137,5 @@ Next: /ai-engineering-loop for product work. Stage 0 reads these files.
|
|
|
132
137
|
- Dumping chat into lessons
|
|
133
138
|
- Mermaid or LaTeX
|
|
134
139
|
- Running the 8-stage product loop inside this skill
|
|
140
|
+
- Typing a model name for Q6
|
|
141
|
+
- Custom intern endpoints
|
|
@@ -12,6 +12,21 @@ gh pr create \
|
|
|
12
12
|
- <edge cases>
|
|
13
13
|
- <tests added>
|
|
14
14
|
|
|
15
|
+
## Steps to Reproduce & Testing (QA)
|
|
16
|
+
### Pre-conditions
|
|
17
|
+
- <environment / data / permissions>
|
|
18
|
+
### Steps to Reproduce
|
|
19
|
+
1. <action>
|
|
20
|
+
2. <action that triggers the bug or the new path>
|
|
21
|
+
### How to Test
|
|
22
|
+
1. <same path after the fix, or the feature path>
|
|
23
|
+
2. <what QA should click / call / assert>
|
|
24
|
+
### Actual Result (before the fix)
|
|
25
|
+
- <error / status / log — N/A on a pure feature>
|
|
26
|
+
### Expected Result (after the fix)
|
|
27
|
+
- <normal behaviour / status>
|
|
28
|
+
- <no error popup, no crash, no new error logs>
|
|
29
|
+
|
|
15
30
|
## Verification
|
|
16
31
|
Commands from `.ai-engineering-loop/verification.md` (exit 0).
|
|
17
32
|
EOF
|
|
@@ -14,6 +14,21 @@ glab mr create \
|
|
|
14
14
|
- <edge cases>
|
|
15
15
|
- <tests added>
|
|
16
16
|
|
|
17
|
+
## Steps to Reproduce & Testing (QA)
|
|
18
|
+
### Pre-conditions
|
|
19
|
+
- <environment / data / permissions>
|
|
20
|
+
### Steps to Reproduce
|
|
21
|
+
1. <action>
|
|
22
|
+
2. <action that triggers the bug or the new path>
|
|
23
|
+
### How to Test
|
|
24
|
+
1. <same path after the fix, or the feature path>
|
|
25
|
+
2. <what QA should click / call / assert>
|
|
26
|
+
### Actual Result (before the fix)
|
|
27
|
+
- <error / status / log — N/A on a pure feature>
|
|
28
|
+
### Expected Result (after the fix)
|
|
29
|
+
- <normal behaviour / status>
|
|
30
|
+
- <no error popup, no crash, no new error logs>
|
|
31
|
+
|
|
17
32
|
## Verification
|
|
18
33
|
Commands from `.ai-engineering-loop/verification.md` (exit 0).
|
|
19
34
|
EOF
|
|
@@ -40,5 +40,6 @@ git push -u origin HEAD
|
|
|
40
40
|
|
|
41
41
|
- One branch, one change request, default branch only.
|
|
42
42
|
- Link the Goal Contract path in the PR/MR body (not the whole chat).
|
|
43
|
+
- If the human opens a PR/MR, the body must include `Steps to Reproduce & Testing (QA)` from `adapters/github/pull-request.md` or `adapters/gitlab/merge-request.md` (reproduce + how to test).
|
|
43
44
|
- No secrets, no internal hostnames, no coworker handles in the description.
|
|
44
45
|
- If the forge CLI is missing, do not install it silently. Tell the user.
|
|
@@ -34,7 +34,7 @@ const {
|
|
|
34
34
|
lessonsMarkdown
|
|
35
35
|
} = require('../lib/generate-workflow.js');
|
|
36
36
|
|
|
37
|
-
const VERSION = '1.0.
|
|
37
|
+
const VERSION = '1.0.21';
|
|
38
38
|
const CWD = process.cwd();
|
|
39
39
|
const CONTEXT_DIR = path.join(CWD, '.ai-engineering-loop');
|
|
40
40
|
|
|
@@ -288,7 +288,7 @@ function generateContextFiles(rootDir, discovery, trigger = 'init', impact = 'IN
|
|
|
288
288
|
|
|
289
289
|
// 0. metadata.json (Baseline)
|
|
290
290
|
const metadataJson = {
|
|
291
|
-
contextVersion: '1.0.
|
|
291
|
+
contextVersion: '1.0.21',
|
|
292
292
|
generatedAt: new Date().toISOString(),
|
|
293
293
|
repositoryRevision: currentRevision,
|
|
294
294
|
projectProfile: discovery.profile,
|
|
@@ -83,7 +83,7 @@ Maintains lightweight state for instant drift detection:
|
|
|
83
83
|
|
|
84
84
|
### 10. `workflow.md` — Loop overlay (optional)
|
|
85
85
|
- Hooks around the 8-stage OS: `before_grill`, `after_freeze`, `after_pass`.
|
|
86
|
-
- Optional `maker_intern` (default `none`).
|
|
86
|
+
- Optional `maker_intern` (default `none`). Pick from this host's catalog (`grok models` or `/models`). Do not type a guessed slug. Not a key or URL.
|
|
87
87
|
- Cannot skip Goal Contract, verification, Devil's Advocate, or Judge.
|
|
88
88
|
- Missing file means default 8-stage loop (no extra hooks, parent is Maker).
|
|
89
89
|
- Generate with `npx ai-engineering-loop generate-workflow` (grill Q1–Q6) or `--write`.
|
package/lib/generate-workflow.js
CHANGED
|
@@ -90,7 +90,7 @@ This file adds hooks around the AI Engineering Loop. It does not replace the 8-s
|
|
|
90
90
|
## Maker intern
|
|
91
91
|
- **maker_intern**: ${intern}
|
|
92
92
|
|
|
93
|
-
Default \`none\` = parent is Maker.
|
|
93
|
+
Default \`none\` = parent is Maker. Pick \`maker_intern\` from this host's catalog (\`grok models\` or \`/models\`). Do not type a guessed slug. AEL does not store intern API keys. Devil's Advocate and Judge stay on the parent. Intern cannot skip them.
|
|
94
94
|
|
|
95
95
|
## Optional skips
|
|
96
96
|
${skipLine}
|
|
@@ -202,6 +202,7 @@ function formatGenerateWorkflowReport({ version, wrote } = {}) {
|
|
|
202
202
|
'This is not a second OS. Required: Goal Contract, verification, Devil\'s Advocate, Judge.',
|
|
203
203
|
'Files: .ai-engineering-loop/workflow.md and lessons.md',
|
|
204
204
|
'Next: load skill generate-workflow. Ask Q1-Q6. Wait.',
|
|
205
|
+
'Q6: pick from host catalog (grok models or /models). Do not type a model name. Recommended: none',
|
|
205
206
|
'Headless: npx ai-engineering-loop generate-workflow --write'
|
|
206
207
|
];
|
|
207
208
|
if (wrote) {
|
|
@@ -0,0 +1,53 @@
|
|
|
1
|
+
'use strict';
|
|
2
|
+
|
|
3
|
+
const HOST_MODEL_LIST_COMMANDS = ['grok models', '/models'];
|
|
4
|
+
|
|
5
|
+
function parseGrokModelsOutput(text) {
|
|
6
|
+
const models = [];
|
|
7
|
+
let defaultModel = '';
|
|
8
|
+
const raw = String(text || '');
|
|
9
|
+
const def = raw.match(/Default model:\s*(\S+)/i);
|
|
10
|
+
if (def) defaultModel = def[1];
|
|
11
|
+
for (const line of raw.split('\n')) {
|
|
12
|
+
const match = line.match(/^\s*[-*]\s+(\S+)/);
|
|
13
|
+
if (!match) continue;
|
|
14
|
+
const id = match[1].replace(/\(default\)/i, '').trim();
|
|
15
|
+
if (id && !models.includes(id)) models.push(id);
|
|
16
|
+
}
|
|
17
|
+
return { defaultModel, models };
|
|
18
|
+
}
|
|
19
|
+
|
|
20
|
+
function isCodingInternModel(id) {
|
|
21
|
+
const s = String(id || '').toLowerCase();
|
|
22
|
+
if (!s) return false;
|
|
23
|
+
if (/imagine/.test(s)) return false;
|
|
24
|
+
if (/(^|-)video($|-)/.test(s)) return false;
|
|
25
|
+
return true;
|
|
26
|
+
}
|
|
27
|
+
|
|
28
|
+
function codingInternModels(models) {
|
|
29
|
+
return (models || []).filter(isCodingInternModel);
|
|
30
|
+
}
|
|
31
|
+
|
|
32
|
+
function formatInternPickList(models) {
|
|
33
|
+
const lines = ['0) none (Recommended)'];
|
|
34
|
+
codingInternModels(models).forEach((id, i) => {
|
|
35
|
+
lines.push(`${i + 1}) ${id}`);
|
|
36
|
+
});
|
|
37
|
+
return lines.join('\n');
|
|
38
|
+
}
|
|
39
|
+
|
|
40
|
+
function internInCatalog(id, models) {
|
|
41
|
+
const s = String(id || '').trim();
|
|
42
|
+
if (!s || /^none$/i.test(s)) return true;
|
|
43
|
+
return codingInternModels(models).includes(s);
|
|
44
|
+
}
|
|
45
|
+
|
|
46
|
+
module.exports = {
|
|
47
|
+
HOST_MODEL_LIST_COMMANDS,
|
|
48
|
+
parseGrokModelsOutput,
|
|
49
|
+
isCodingInternModel,
|
|
50
|
+
codingInternModels,
|
|
51
|
+
formatInternPickList,
|
|
52
|
+
internInCatalog
|
|
53
|
+
};
|
package/package.json
CHANGED
|
@@ -16,7 +16,7 @@ This file adds hooks around the AI Engineering Loop. It does not replace the 8-s
|
|
|
16
16
|
## Maker intern
|
|
17
17
|
- **maker_intern**: none
|
|
18
18
|
|
|
19
|
-
Default `none` = parent is Maker.
|
|
19
|
+
Default `none` = parent is Maker. Pick `maker_intern` from this host's catalog (`grok models` or `/models`). Do not type a guessed slug. AEL does not store intern API keys. Devil's Advocate and Judge stay on the parent. Intern cannot skip them.
|
|
20
20
|
|
|
21
21
|
## Optional skips
|
|
22
22
|
none
|
|
@@ -0,0 +1,65 @@
|
|
|
1
|
+
'use strict';
|
|
2
|
+
|
|
3
|
+
const test = require('node:test');
|
|
4
|
+
const assert = require('node:assert');
|
|
5
|
+
const fs = require('fs');
|
|
6
|
+
const path = require('path');
|
|
7
|
+
|
|
8
|
+
const ROOT = path.join(__dirname, '..');
|
|
9
|
+
|
|
10
|
+
function readRepo(rel) {
|
|
11
|
+
return fs.readFileSync(path.join(ROOT, rel), 'utf8');
|
|
12
|
+
}
|
|
13
|
+
|
|
14
|
+
const MULTI = 'adapters/dot/multi-branch.md';
|
|
15
|
+
const README = 'adapters/dot/README.md';
|
|
16
|
+
const WORKFLOW = 'adapters/dot/skills/dot-dev-workflow/SKILL.md';
|
|
17
|
+
|
|
18
|
+
test('AC-1 unrelated HEAD and in-use develop: new topic branch from origin/develop after fetch/pull', () => {
|
|
19
|
+
const text = `${readRepo(MULTI)}\n${readRepo(WORKFLOW)}`;
|
|
20
|
+
assert.match(text, /unrelated|not related/i);
|
|
21
|
+
assert.match(text, /git fetch origin/);
|
|
22
|
+
assert.match(text, /origin\/develop/);
|
|
23
|
+
assert.match(text, /git checkout -b/);
|
|
24
|
+
assert.match(text, /Do not `git pull` into the current HEAD/);
|
|
25
|
+
assert.doesNotMatch(readRepo(MULTI), /git pull origin develop/);
|
|
26
|
+
assert.match(text, /HEAD being `main` does not override an in-use `develop` default/);
|
|
27
|
+
});
|
|
28
|
+
|
|
29
|
+
test('AC-2 related feat/fix branch stays; do not create another topic branch or three MRs', () => {
|
|
30
|
+
const text = `${readRepo(MULTI)}\n${readRepo(WORKFLOW)}`;
|
|
31
|
+
assert.match(text, /feat\//);
|
|
32
|
+
assert.match(text, /fix\//);
|
|
33
|
+
assert.match(text, /Stay on that branch|keep the current branch/i);
|
|
34
|
+
assert.match(text, /Do not create a new topic branch/i);
|
|
35
|
+
assert.match(text, /Do not open three MRs|one MR/i);
|
|
36
|
+
});
|
|
37
|
+
|
|
38
|
+
test('AC-3 main or unused leftover develop: new topic branch from origin/main', () => {
|
|
39
|
+
const text = `${readRepo(MULTI)}\n${readRepo(WORKFLOW)}`;
|
|
40
|
+
assert.match(text, /unused leftover/i);
|
|
41
|
+
assert.match(text, /origin\/main/);
|
|
42
|
+
assert.match(text, /Do not force leftover develop/);
|
|
43
|
+
assert.match(text, /even if HEAD is `develop`/);
|
|
44
|
+
});
|
|
45
|
+
|
|
46
|
+
test('AC-4 generic GitHub/GitLab stay non-DOT; extra envs only if adapter.md lists them', () => {
|
|
47
|
+
const gitlab = readRepo('adapters/gitlab/README.md');
|
|
48
|
+
const github = readRepo('adapters/github/README.md');
|
|
49
|
+
assert.match(gitlab, /not the DOT adapter/);
|
|
50
|
+
assert.match(gitlab, /No extra environment cherry-picks unless/);
|
|
51
|
+
assert.doesNotMatch(gitlab, /Coreview/);
|
|
52
|
+
assert.match(github, /Extra branches, review bots, and chat are \*\*off\*\*/);
|
|
53
|
+
});
|
|
54
|
+
|
|
55
|
+
test('AC-5 chat setuju is not propagate; extra env MRs only if named this turn', () => {
|
|
56
|
+
const text = `${readRepo(MULTI)}\n${readRepo(WORKFLOW)}\n${readRepo(README)}`;
|
|
57
|
+
assert.match(text, /setuju/);
|
|
58
|
+
assert.match(text, /this turn/);
|
|
59
|
+
assert.match(text, /Do not cherry-pick to `staging` or `develop` unless/i);
|
|
60
|
+
const workflow = readRepo(WORKFLOW);
|
|
61
|
+
assert.doesNotMatch(workflow, /```mermaid/);
|
|
62
|
+
assert.doesNotMatch(workflow, /commit, propagate, reply/);
|
|
63
|
+
assert.match(workflow, /push to the same topic MR/);
|
|
64
|
+
assert.doesNotMatch(readRepo(README), /fix & propagate/);
|
|
65
|
+
});
|
|
@@ -97,6 +97,7 @@ test('CLI generate-workflow without --write prints grill protocol', () => {
|
|
|
97
97
|
const out = execFileSync('node', [CLI, 'generate-workflow'], { cwd: dir, encoding: 'utf8' });
|
|
98
98
|
assert.match(out, /generate-workflow/);
|
|
99
99
|
assert.match(out, /Q1-Q6/);
|
|
100
|
+
assert.match(out, /Do not type a model name/);
|
|
100
101
|
assert.ok(!fs.existsSync(path.join(dir, '.ai-engineering-loop', 'workflow.md')));
|
|
101
102
|
});
|
|
102
103
|
|
|
@@ -130,8 +131,8 @@ test('AC-1 default overlay maker_intern is none', () => {
|
|
|
130
131
|
const parsed = parseWorkflowFile(dir);
|
|
131
132
|
assert.match(workflow, /\*\*maker_intern\*\*: none/);
|
|
132
133
|
assert.strictEqual(parsed.makerIntern, 'none');
|
|
133
|
-
assert.match(workflowMarkdown(), /
|
|
134
|
-
assert.match(workflowMarkdown(), /
|
|
134
|
+
assert.match(workflowMarkdown(), /host's catalog/);
|
|
135
|
+
assert.match(workflowMarkdown(), /Do not type a guessed slug/);
|
|
135
136
|
});
|
|
136
137
|
|
|
137
138
|
test('AC-2 missing workflow.md makerIntern is none', () => {
|
|
@@ -0,0 +1,72 @@
|
|
|
1
|
+
'use strict';
|
|
2
|
+
|
|
3
|
+
const test = require('node:test');
|
|
4
|
+
const assert = require('node:assert');
|
|
5
|
+
const {
|
|
6
|
+
HOST_MODEL_LIST_COMMANDS,
|
|
7
|
+
parseGrokModelsOutput,
|
|
8
|
+
codingInternModels,
|
|
9
|
+
formatInternPickList,
|
|
10
|
+
internInCatalog
|
|
11
|
+
} = require('../lib/intern-catalog.js');
|
|
12
|
+
|
|
13
|
+
const GROK_MODELS_FIXTURE = `You are logged in with grok.com.
|
|
14
|
+
|
|
15
|
+
Default model: grok-4.6
|
|
16
|
+
|
|
17
|
+
Available models:
|
|
18
|
+
- grok-4.20-0309-non-reasoning
|
|
19
|
+
- grok-4.20-0309-reasoning
|
|
20
|
+
- grok-4.20-multi-agent-0309
|
|
21
|
+
- grok-4.3
|
|
22
|
+
- grok-4.5
|
|
23
|
+
* grok-4.6 (default)
|
|
24
|
+
- grok-build-0.1
|
|
25
|
+
- grok-imagine-image
|
|
26
|
+
- grok-imagine-image-2.0
|
|
27
|
+
- grok-imagine-image-quality
|
|
28
|
+
- grok-imagine-video
|
|
29
|
+
- grok-imagine-video-1.5
|
|
30
|
+
`;
|
|
31
|
+
|
|
32
|
+
test('host list commands include grok models and /models', () => {
|
|
33
|
+
assert.ok(HOST_MODEL_LIST_COMMANDS.includes('grok models'));
|
|
34
|
+
assert.ok(HOST_MODEL_LIST_COMMANDS.includes('/models'));
|
|
35
|
+
});
|
|
36
|
+
|
|
37
|
+
test('AC-1 parse grok models into ids plus default', () => {
|
|
38
|
+
const parsed = parseGrokModelsOutput(GROK_MODELS_FIXTURE);
|
|
39
|
+
assert.strictEqual(parsed.defaultModel, 'grok-4.6');
|
|
40
|
+
assert.ok(parsed.models.includes('grok-build-0.1'));
|
|
41
|
+
assert.ok(parsed.models.includes('grok-4.6'));
|
|
42
|
+
});
|
|
43
|
+
|
|
44
|
+
test('AC-2 empty catalog pick list is only none', () => {
|
|
45
|
+
assert.strictEqual(formatInternPickList([]), '0) none (Recommended)');
|
|
46
|
+
assert.strictEqual(internInCatalog('none', []), true);
|
|
47
|
+
assert.strictEqual(internInCatalog('', []), true);
|
|
48
|
+
});
|
|
49
|
+
|
|
50
|
+
test('AC-3 Claude has no grok catalog so only none is in-catalog', () => {
|
|
51
|
+
assert.strictEqual(internInCatalog('gemini-flash', []), false);
|
|
52
|
+
assert.strictEqual(internInCatalog('grok-build-0.1', []), false);
|
|
53
|
+
});
|
|
54
|
+
|
|
55
|
+
test('AC-4 imagine and video models are not coding intern picks', () => {
|
|
56
|
+
const { models } = parseGrokModelsOutput(GROK_MODELS_FIXTURE);
|
|
57
|
+
const coding = codingInternModels(models);
|
|
58
|
+
assert.ok(coding.includes('grok-build-0.1'));
|
|
59
|
+
assert.ok(!coding.includes('grok-imagine-image'));
|
|
60
|
+
assert.ok(!coding.includes('grok-imagine-video'));
|
|
61
|
+
const list = formatInternPickList(models);
|
|
62
|
+
assert.match(list, /0\) none \(Recommended\)/);
|
|
63
|
+
assert.match(list, /grok-build-0.1/);
|
|
64
|
+
assert.doesNotMatch(list, /imagine/);
|
|
65
|
+
});
|
|
66
|
+
|
|
67
|
+
test('AC-5 unknown slug is not in catalog', () => {
|
|
68
|
+
const { models } = parseGrokModelsOutput(GROK_MODELS_FIXTURE);
|
|
69
|
+
assert.strictEqual(internInCatalog('grok-build-0.1', models), true);
|
|
70
|
+
assert.strictEqual(internInCatalog('not-a-real-model', models), false);
|
|
71
|
+
assert.strictEqual(internInCatalog('sk-abc', models), false);
|
|
72
|
+
});
|
|
@@ -0,0 +1,90 @@
|
|
|
1
|
+
'use strict';
|
|
2
|
+
|
|
3
|
+
const test = require('node:test');
|
|
4
|
+
const assert = require('node:assert');
|
|
5
|
+
const fs = require('fs');
|
|
6
|
+
const path = require('path');
|
|
7
|
+
|
|
8
|
+
const ROOT = path.join(__dirname, '..');
|
|
9
|
+
|
|
10
|
+
function readRepo(rel) {
|
|
11
|
+
return fs.readFileSync(path.join(ROOT, rel), 'utf8');
|
|
12
|
+
}
|
|
13
|
+
|
|
14
|
+
const QA_HEADINGS = [
|
|
15
|
+
/## Steps to Reproduce & Testing \(QA\)/,
|
|
16
|
+
/### Pre-conditions/,
|
|
17
|
+
/### Steps to Reproduce/,
|
|
18
|
+
/### How to Test/,
|
|
19
|
+
/### Actual Result/,
|
|
20
|
+
/### Expected Result/
|
|
21
|
+
];
|
|
22
|
+
|
|
23
|
+
const HOSTS = [
|
|
24
|
+
'.claude/skills/ai-engineering-loop/SKILL.md',
|
|
25
|
+
'.grok/skills/ai-engineering-loop/SKILL.md',
|
|
26
|
+
'.gemini/skills/ai-engineering-loop/SKILL.md',
|
|
27
|
+
'.agents/workflows/ai-engineering-loop.md'
|
|
28
|
+
];
|
|
29
|
+
|
|
30
|
+
test('AC-1 GitHub PR and GitLab MR bodies include the QA reproduce and how-to-test block', () => {
|
|
31
|
+
for (const rel of [
|
|
32
|
+
'adapters/github/pull-request.md',
|
|
33
|
+
'adapters/gitlab/merge-request.md'
|
|
34
|
+
]) {
|
|
35
|
+
const text = readRepo(rel);
|
|
36
|
+
for (const heading of QA_HEADINGS) {
|
|
37
|
+
assert.match(text, heading, `${rel} missing ${heading}`);
|
|
38
|
+
}
|
|
39
|
+
}
|
|
40
|
+
});
|
|
41
|
+
|
|
42
|
+
test('AC-2 pure feature may mark Actual Result N/A; How to Test stays required', () => {
|
|
43
|
+
for (const rel of [
|
|
44
|
+
'adapters/github/pull-request.md',
|
|
45
|
+
'adapters/gitlab/merge-request.md'
|
|
46
|
+
]) {
|
|
47
|
+
const text = readRepo(rel);
|
|
48
|
+
assert.match(text, /N\/A on a pure feature/, rel);
|
|
49
|
+
assert.match(text, /### How to Test/, rel);
|
|
50
|
+
assert.match(text, /### Expected Result/, rel);
|
|
51
|
+
}
|
|
52
|
+
});
|
|
53
|
+
|
|
54
|
+
test('AC-3 QA block does not become a dump of diffs, tokens, or machine paths', () => {
|
|
55
|
+
for (const rel of [
|
|
56
|
+
'adapters/github/pull-request.md',
|
|
57
|
+
'adapters/gitlab/merge-request.md'
|
|
58
|
+
]) {
|
|
59
|
+
const text = readRepo(rel);
|
|
60
|
+
assert.match(text, /Do not paste raw diffs, tokens, or local machine paths/, rel);
|
|
61
|
+
}
|
|
62
|
+
});
|
|
63
|
+
|
|
64
|
+
test('AC-4 generic GitLab stays non-DOT; standard does not copy the DOT issue card; DOT issue and MR both have the QA block', () => {
|
|
65
|
+
const gitlab = readRepo('adapters/gitlab/merge-request.md');
|
|
66
|
+
assert.doesNotMatch(gitlab, /Coreview/);
|
|
67
|
+
assert.doesNotMatch(gitlab, /Mattermost/);
|
|
68
|
+
|
|
69
|
+
const standard = readRepo('adapters/standard/README.md');
|
|
70
|
+
assert.match(standard, /Steps to Reproduce & Testing \(QA\)/);
|
|
71
|
+
assert.doesNotMatch(standard, /Ready to Test/);
|
|
72
|
+
|
|
73
|
+
const dot = readRepo('adapters/dot/gitlab.md');
|
|
74
|
+
const hits = dot.split('## Steps to Reproduce & Testing (QA)').length - 1;
|
|
75
|
+
assert.ok(hits >= 2, `DOT gitlab.md needs QA block on issue and MR, got ${hits}`);
|
|
76
|
+
for (const heading of QA_HEADINGS) {
|
|
77
|
+
assert.match(dot, heading, `DOT gitlab.md missing ${heading}`);
|
|
78
|
+
}
|
|
79
|
+
});
|
|
80
|
+
|
|
81
|
+
test('AC-5 host Stage 8 and DOT Stage 8a require the QA block; bugfix placeholders must not stay empty', () => {
|
|
82
|
+
for (const rel of HOSTS) {
|
|
83
|
+
const text = readRepo(rel);
|
|
84
|
+
assert.match(text, /Steps to Reproduce & Testing \(QA\)/, rel);
|
|
85
|
+
}
|
|
86
|
+
const delivery = readRepo('adapters/dot/skills/dot-dev-workflow/SKILL.md');
|
|
87
|
+
assert.match(delivery, /Steps to Reproduce & Testing \(QA\)/);
|
|
88
|
+
assert.match(delivery, /bugfix placeholders must not stay empty|do not leave those placeholders empty/i);
|
|
89
|
+
assert.doesNotMatch(delivery, /```mermaid/);
|
|
90
|
+
});
|
|
@@ -222,7 +222,10 @@ test('generate-workflow skill is Claude-safe and host skills read the overlay',
|
|
|
222
222
|
assert.match(skill, /maker_intern/);
|
|
223
223
|
assert.match(skill, /Do not start Maker/);
|
|
224
224
|
assert.match(skill, /lessons\.md/);
|
|
225
|
-
assert.match(skill, /
|
|
225
|
+
assert.match(skill, /grok models/);
|
|
226
|
+
assert.match(skill, /\/models/);
|
|
227
|
+
assert.match(skill, /Do not type a model name/);
|
|
228
|
+
assert.doesNotMatch(skill, /any host-native label \(gemini-flash/);
|
|
226
229
|
for (const rel of [
|
|
227
230
|
'.claude/skills/ai-engineering-loop/SKILL.md',
|
|
228
231
|
'.grok/skills/ai-engineering-loop/SKILL.md',
|
|
@@ -236,6 +239,7 @@ test('generate-workflow skill is Claude-safe and host skills read the overlay',
|
|
|
236
239
|
assert.match(text, /generate-workflow/, rel);
|
|
237
240
|
assert.match(text, /maker_intern/, rel);
|
|
238
241
|
assert.match(text, /INVOCATION_UNAVAILABLE/, rel);
|
|
242
|
+
assert.match(text, /Do not type a model name/, rel);
|
|
239
243
|
}
|
|
240
244
|
});
|
|
241
245
|
|